On Thu, Oct 21, 2021 at 08:06:13PM +0800, fengchengwen wrote:
> Hi Bruce,
> 
> I observed a large number of checkpatch errors [1] when synchronizing to our 
> inner CI,
> almost all of them are over 80 lines, and many are not LONG LOG.
> 
> The DPDK coding style recommends to be not more than 80 characters unless 
> rarest
> situations (which LONG LOG belongs to this one I think).
> 
> I don't know which to follow: just ignore or should fix it ?

I'd rather not change these as the code is more readable unwrapped.
Although the docs do indeed recommend 80 characters, in practice we allow
up to 100 characters and the CI's run using that limit for checkpatch. I've
actually submitted a patchset to try and update our doc and usertools to
match the in-practice policy.

/Bruce

[1] 
http://patches.dpdk.org/project/dpdk/patch/20211020142601.157649-1-bruce.richard...@intel.com/

Reply via email to