[dpdk-dev] [PATCH] net/ice: fix TM hierarchy commit flag not reset correctly

2021-10-13 Thread Ting Xu
After DCF commits TM hierarchy configuration, the commit flag is set to avoid duplicated commit. But the flag is not reset after device stop, which prevents the update of hierarchy configuration unless close the device. It is not reasonable. This patch fix to reset the commit flag after device stop

[dpdk-dev] [PATCH v4 2/2] net/mlx5: support socket direct mode bonding

2021-10-13 Thread Rongwei Liu
In socket direct mode, it's possible to bind any two (maybe four in future) PCIe devices with IDs like :xx:xx.x and :yy:yy.y. Bonding member interfaces are unnecessary to have the same PCIe domain/bus/device ID anymore, Kernel driver uses "system_image_guid" to identify if devices can be b

[dpdk-dev] [PATCH v4 1/2] common/mlx5: support pcie device guid query

2021-10-13 Thread Rongwei Liu
sysfs entry "phys_switch_id" holds each PCIe device' guid. The devices which reside in the same physical NIC should have the same guid. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/linux/mlx5_common_os.c | 41 ++ drivers/common/mlx5/linu

[dpdk-dev] [PATCH v4 0/2] support socket direct mode bonding

2021-10-13 Thread Rongwei Liu
In socket direct mode, it's possible to bind any two (maybe four in the future) PCIe devices with IDs like :xx:xx.x and :yy:yy.y. Bonding member interfaces are unnecessary to have the same PCIe domain/bus/device ID anymore. Doesn't need to backport to DPDK 20.11 v2: fix ci warnings. v3: a

[dpdk-dev] [Bug 798] mlx5 hw flow performance problem

2021-10-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=798 Asaf Penso (as...@nvidia.com) changed: What|Removed |Added Status|RESOLVED|CONFIRMED Resolution|WORKS

Re: [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on DPDK

2021-10-13 Thread Peng, ZhihongX
> -Original Message- > From: dev On Behalf Of Peng, ZhihongX > Sent: Thursday, October 14, 2021 2:34 PM > To: Richardson, Bruce ; David Marchand > > Cc: Burakov, Anatoly ; Ananyev, Konstantin > ; Stephen Hemminger > ; dev ; Lin, Xueqin > ; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v2] ip_frag: fix fragmenting IPv4 fragment

2021-10-13 Thread Thomas Monjalon
> > Current implementation of rte_ipv4_fragment_packet() doesn’t take > > into account offset and flag values of the given packet, but blindly > > assumes they are always zero (original packet is not fragmented). > > According to RFC791, fragment and flag values for new fragment > > should take int

Re: [dpdk-dev] [PATCH v9 1/3] Enable ASan for memory detector on DPDK

2021-10-13 Thread Peng, ZhihongX
> -Original Message- > From: David Marchand > Sent: Thursday, October 14, 2021 12:45 AM > To: Peng, ZhihongX > Cc: Burakov, Anatoly ; Ananyev, Konstantin > ; Stephen Hemminger > ; dev ; Lin, Xueqin > ; Richardson, Bruce ; > Thomas Monjalon > Subject: Re: [PATCH v9 1/3] Enable ASan for me

Re: [dpdk-dev] [PATCH v2] net/virtio: handle Tx checksums correctly for tunnel packets

2021-10-13 Thread Andrew Rybchenko
Hi Maxime, Chenbo, is the any problem with the patch below? Thanks, Andrew. On 9/16/21 9:49 PM, Ivan Malov wrote: > Tx prepare method calls rte_net_intel_cksum_prepare(), which > handles tunnel packets correctly, but Tx burst path does not > take tunnel presence into account when computing the o

Re: [dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs

2021-10-13 Thread Thomas Monjalon
14/10/2021 00:48, Walker, Benjamin: > > From: Thomas Monjalon > > > Yes I think we need to agree on functions to keep as-is for compatibility. > > Waiting for your input please. > > We've added a task to our backlog to propose a stable ABI for out of tree > drivers here. It's not as simple as

Re: [dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs

2021-10-13 Thread Thomas Monjalon
14/10/2021 04:21, Xia, Chenbo: > From: Thomas Monjalon > > 13/10/2021 19:56, Walker, Benjamin: > > > > From: Thomas Monjalon > > > > > > > > In order to be perfectly clear, all the changes done around this option > > > > enable_driver_sdk share the goal of tidying stuff in DPDK so that ABI > > be

Re: [dpdk-dev] [PATCH v1 1/1] ci: enable DPDK GHA for arm64 with self-hosted runners

2021-10-13 Thread Thomas Monjalon
14/10/2021 06:20, Serena He: > From: Thomas Monjalon > > 13/10/2021 10:03, Serena He: > > > CI jobs are triggered only for repos installed with given GHApp and > > > runners > > [...] > > > +# Here, runners for arm64 are accessed by installed GitHub APP, thus > > will not be available by fork

Re: [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on DPDK

2021-10-13 Thread Peng, ZhihongX
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, October 13, 2021 4:00 PM > To: David Marchand > Cc: Peng, ZhihongX ; Burakov, Anatoly > ; Ananyev, Konstantin > ; Stephen Hemminger > ; dev ; Lin, Xueqin > ; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH v6 1/2] Enable

Re: [dpdk-dev] [PATCH v2] app/test-eventdev: add burst enqueue support

2021-10-13 Thread Jerin Jacob
On Thu, Oct 14, 2021 at 1:46 AM Rashmi Shetty wrote: > > This commit introduces a new command line option prod_enq_burst_sz > to set burst size for eventdev enqueue at producer in perf_queue > test. The newly added function perf_producer_burst is called when > prod_enq_burst_sz is greater than 1.

Re: [dpdk-dev] [PATCH] net/ice: fix dereferenced null pointer

2021-10-13 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Monday, October 11, 2021 4:25 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Wenjun1 ; Su, Simei > > Subject: [PATCH] net/ice: fix dereferenced null pointer > > This patch fixes coverity issue by avoiding use of null pointer in taking > f

[dpdk-dev] [PATCH v5 11/12] app/test: replace .sh scripts with .py scripts

2021-10-13 Thread Jie Zhou
- Add python script to get coremask - Add python script to check if system supports hugepages - Remove two corresponding .sh scripts - Replace calling of .sh with corresponding .py in meson.build Signed-off-by: Jie Zhou --- app/test/get-coremask.sh | 13 - app/test/get_coremask.py |

[dpdk-dev] [PATCH v5 12/12] app/test: enable subset of unit tests on Windows

2021-10-13 Thread Jie Zhou
- For fast tests and perf tests, add test stubs to skip not supported ones. - For driver tests, just skip on Windows totally to avoid unnecessary amount of test stubs. For example, there are about 30 cryptodev related tests (even though in the meson for CI it only listed about half) which w

[dpdk-dev] [PATCH v5 09/12] app/test: differentiate a strerror on different OS

2021-10-13 Thread Jie Zhou
On Windows, strerror returns just "Unknown error" for errnum greater than MAX_ERRNO, while linux and freebsd returns "Unknown error ", which is the current expectation for errno_autotest. Differentiate the error string on Windows to remove a "duplicate error code" failure. Signed-off-by: Jie Zhou

[dpdk-dev] [PATCH v5 07/12] app/test: temporarily "skip" one cmdline test case

2021-10-13 Thread Jie Zhou
cmdline tests pass except one failure at the test_cmdline_socket_fns test case with error: failed to open /dev/null for reading! Temporarily "skip" this case while enable all other passing cases. Issue is tracked internally and will add the corresponding case on Windows in future. Signed-off-by:

[dpdk-dev] [PATCH v5 10/12] app/test: remove two alarm_autotest cases

2021-10-13 Thread Jie Zhou
Remove two alarm_autotest test cases which do bogus range check on Windows. Signed-off-by: Jie Zhou --- app/test/test_alarm.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test/test_alarm.c b/app/test/test_alarm.c index b4034339b8..70e97a3109 100644 --- a/app/test/test_alarm.c +++

[dpdk-dev] [PATCH v5 06/12] app/test: skip interrupt tests on Windows

2021-10-13 Thread Jie Zhou
Even though test_interrupts.c can compile on Windows, skip interrupt tests for now since majority of eal_interrupt on Windows are stubs. Will remove the skip after interrupt being fully enabled on Windows. Signed-off-by: Jie Zhou --- app/test/test_interrupts.c | 10 ++ 1 file changed, 10

[dpdk-dev] [PATCH v5 08/12] app/test: skip two logs_autotest cases on Windows

2021-10-13 Thread Jie Zhou
DPDK logs_autotest on Windows failed at "dynamic log types" tests. The failures are on 2 test cases for rte_log_set_level_regexp API, due to regular expression is not supported on Windows in DPDK yet and regcomp/regexec are just stubs on Windows (in regex.h). In app\test\test_logs.c, ifndef these

[dpdk-dev] [PATCH v5 05/12] app/test: exclude ENOTSUP as failure

2021-10-13 Thread Jie Zhou
Check rte_errno to exclude ENOTSUP as failures in test_memory.c Signed-off-by: Jie Zhou --- app/test/test_memory.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test/test_memory.c b/app/test/test_memory.c index dbf6871e71..379b0f99ca 100644 --- a/app/test/test_memory.

[dpdk-dev] [PATCH v5 00/12] app/test: enable subset of tests on Windows

2021-10-13 Thread Jie Zhou
This patchset is to enable a subset of unit tests on windows. It mainly includes: - Enable building libraries on Windows that some tests depend on - Replace POSIX specific codes - Fix some lib and tests per failures investigation - Replace .sh scripts with .py scripts for meson.build - Enable buil

[dpdk-dev] [PATCH v5 04/12] app/test: replace POSIX specific code

2021-10-13 Thread Jie Zhou
- Include rte_os_shim.h - Replace sleep and usleep with rte_delay_us_sleep - #ifndef RTE_EXEC_ENV_WINDOWS for POSIX code only Signed-off-by: Jie Zhou --- app/test/packet_burst_generator.c | 1 + app/test/process.h| 4 +++- app/test/test.c | 4 app/test/test

[dpdk-dev] [PATCH v5 03/12] app/test: remove unnecessary headers

2021-10-13 Thread Jie Zhou
Remove unnecessary header inclusion Signed-off-by: Jie Zhou --- app/test/commands.c | 2 -- app/test/test.c | 1 - app/test/test_cmdline_lib.c | 1 - 3 files changed, 4 deletions(-) diff --git a/app/test/commands.c b/app/test/commands.c index 76f6ee5d23..82bd8bf474 100644 --

[dpdk-dev] [PATCH v5 01/12] lib: build libraries that some tests depend on

2021-10-13 Thread Jie Zhou
Enable building subset of libraries that tests depend on for Windows Signed-off-by: Jie Zhou --- lib/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index b2ba7258d8..bd6c27deef 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -82,9 +82,11

[dpdk-dev] [PATCH v5 02/12] eal/windows: return ENOTSUP for not supported API

2021-10-13 Thread Jie Zhou
UT memory_autotest on Windows has 2 failed cases on eal APIs eal_memalloc_get_seg_fd and eal_memalloc_get_seg_fd_offset. These 2 APIs are not supported on Windows yet. Should return ENOTSUP such that in test_memory.c these 2 ENOTSUP cases will not be marked as failures, same as other ENOTSUP cases.

Re: [dpdk-dev] [PATCH v1 1/1] ci: enable DPDK GHA for arm64 with self-hosted runners

2021-10-13 Thread Serena He
Hi Thomas, thanks for the feedback. > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 13, 2021 5:47 PM > To: Serena He > Cc: acon...@redhat.com; maicolgabr...@hotmail.com; > david.march...@redhat.com; dev@dpdk.org; Honnappa Nagarahalli > ; Ruifeng Wang > ; Dean Arno

Re: [dpdk-dev] [PATCH V2] ethdev: fix eth device released repeatedly

2021-10-13 Thread lihuisong (C)
在 2021/10/12 23:33, Thomas Monjalon 写道: 12/10/2021 13:39, Huisong Li: The rte_eth_dev_pci_generic_remove() will be called to detach an Ethernet device when App calls rte_dev_remove() to detach a pci device. In addition, the rte_eth_dev_close() can also detach an Ethernet device. In secondary p

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] ip_frag: fix fragmenting IPv4 fragment

2021-10-13 Thread 蔡慧超
Hi,Monjalon We use to capitalize name with family name at last. Is it OK to assume this format for your name? Huichao Cai --Yes,this is my real name.I'll change my name to "Huichao Cai". --Thank you for your reminder. I see that Konstantin is saying Kevin, is it your alias? --Yes,this is

[dpdk-dev] [PATCH v4 12/12] app/test: enable subset of unit tests on Windows

2021-10-13 Thread Jie Zhou
- For fast tests and perf tests, add test stubs to skip not supported ones. - For driver tests, just skip on Windows totally to avoid unnecessary amount of test stubs. For example, there are about 30 cryptodev related tests (even though in the meson for CI it only listed about half) which w

[dpdk-dev] [PATCH v4 11/12] app/test: replace .sh scripts with .py scripts

2021-10-13 Thread Jie Zhou
- Add python script to get coremask - Add python script to check if system supports hugepages - Remove two corresponding .sh scripts - Replace calling of .sh with corresponding .py in meson.build Signed-off-by: Jie Zhou --- app/test/get-coremask.sh | 13 - app/test/get_coremask.py |

[dpdk-dev] [PATCH v4 09/12] app/test: differentiate a strerror on different OS

2021-10-13 Thread Jie Zhou
On Windows, strerror returns just "Unknown error" for errnum greater than MAX_ERRNO, while linux and freebsd returns "Unknown error ", which is the current expectation for errno_autotest. Differentiate the error string on Windows to remove a "duplicate error code" failure. Signed-off-by: Jie Zhou

[dpdk-dev] [PATCH v4 10/12] app/test: remove two alarm_autotest cases

2021-10-13 Thread Jie Zhou
Remove two alarm_autotest test cases which do bogus range check on Windows. Signed-off-by: Jie Zhou --- app/test/test_alarm.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test/test_alarm.c b/app/test/test_alarm.c index b4034339b8..70e97a3109 100644 --- a/app/test/test_alarm.c +++

[dpdk-dev] [PATCH v4 08/12] app/test: skip two logs_autotest cases on Windows

2021-10-13 Thread Jie Zhou
DPDK logs_autotest on Windows failed at "dynamic log types" tests. The failures are on 2 test cases for rte_log_set_level_regexp API, due to regular expression is not supported on Windows in DPDK yet and regcomp/regexec are just stubs on Windows (in regex.h). In app\test\test_logs.c, ifndef these

[dpdk-dev] [PATCH v4 07/12] app/test: temporarily "skip" one cmdline test case

2021-10-13 Thread Jie Zhou
cmdline tests pass except one failure at the test_cmdline_socket_fns test case with error: failed to open /dev/null for reading! Temporarily "skip" this case while enable all other passing cases. Issue is tracked internally and will add the corresponding case on Windows in future. Signed-off-by:

[dpdk-dev] [PATCH v4 06/12] app/test: skip interrupt tests on Windows

2021-10-13 Thread Jie Zhou
Even though test_interrupts.c can compile on Windows, skip interrupt tests for now since majority of eal_interrupt on Windows are stubs. Will remove the skip after interrupt being fully enabled on Windows. Signed-off-by: Jie Zhou --- app/test/test_interrupts.c | 10 ++ 1 file changed, 10

[dpdk-dev] [PATCH v4 05/12] app/test: exclude ENOTSUP as failure

2021-10-13 Thread Jie Zhou
Check rte_errno to exclude ENOTSUP as failures in test_memory.c Signed-off-by: Jie Zhou --- app/test/test_memory.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test/test_memory.c b/app/test/test_memory.c index dbf6871e71..379b0f99ca 100644 --- a/app/test/test_memory.

[dpdk-dev] [PATCH v4 00/12] app/test: enable subset of tests on Windows

2021-10-13 Thread Jie Zhou
This patchset is to enable a subset of unit tests on windows. It mainly includes: - Enable building libraries on Windows that some tests depend on - Replace POSIX specific codes - Fix some lib and tests per failures investigation - Replace .sh scripts with .py scripts for meson.build - Enable buil

[dpdk-dev] [PATCH v4 04/12] app/test: replace POSIX specific code

2021-10-13 Thread Jie Zhou
- Include rte_os_shim.h - Replace sleep and usleep with rte_delay_us_sleep - #ifndef RTE_EXEC_ENV_WINDOWS for POSIX code only Signed-off-by: Jie Zhou --- app/test/packet_burst_generator.c | 1 + app/test/process.h| 4 +++- app/test/test.c | 4 app/test/test

[dpdk-dev] [PATCH v4 03/12] app/test: remove unnecessary headers

2021-10-13 Thread Jie Zhou
Remove unnecessary header inclusion Signed-off-by: Jie Zhou --- app/test/commands.c | 2 -- app/test/test.c | 1 - app/test/test_cmdline_lib.c | 1 - 3 files changed, 4 deletions(-) diff --git a/app/test/commands.c b/app/test/commands.c index 76f6ee5d23..82bd8bf474 100644 --

[dpdk-dev] [PATCH v4 02/12] eal/windows: return ENOTSUP for not supported API

2021-10-13 Thread Jie Zhou
UT memory_autotest on Windows has 2 failed cases on eal APIs eal_memalloc_get_seg_fd and eal_memalloc_get_seg_fd_offset. These 2 APIs are not supported on Windows yet. Should return ENOTSUP such that in test_memory.c these 2 ENOTSUP cases will not be marked as failures, same as other ENOTSUP cases.

[dpdk-dev] [PATCH v4 01/12] lib: build libraries that some tests depend on

2021-10-13 Thread Jie Zhou
Enable building subset of libraries that tests depend on for Windows Signed-off-by: Jie Zhou --- lib/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index b2ba7258d8..bd6c27deef 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -82,9 +82,11

Re: [dpdk-dev] [RFC 01/14] vhost: move async data in a dedicated structure

2021-10-13 Thread Hu, Jiayu
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, October 8, 2021 6:00 AM > To: dev@dpdk.org; Xia, Chenbo ; Hu, Jiayu > ; Wang, YuanX ; Ma, > WenwuX ; Richardson, Bruce > ; Mcnamara, John > > Cc: Maxime Coquelin > Subject: [RFC 01/14] vhost: move async data in a de

[dpdk-dev] [PATCH v4] ethdev: add API to query proxy port to manage transfer flows

2021-10-13 Thread Ivan Malov
Not all DPDK ports in a given switching domain may have the privilege to manage "transfer" flows. Add an API to find a port with sufficient privileges by any port in the domain. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Acked-by: Ori Kam --- Patch series [1] has reworked support f

[dpdk-dev] 回复: [RFC PATCH v3 1/5] eal: add new definitions for wait scheme

2021-10-13 Thread Feifei Wang
> -邮件原件- > 发件人: Stephen Hemminger > 发送时间: Thursday, October 14, 2021 1:00 AM > 收件人: Ananyev, Konstantin > 抄送: Feifei Wang ; Ruifeng Wang > ; dev@dpdk.org; nd > 主题: Re: [dpdk-dev] [RFC PATCH v3 1/5] eal: add new definitions for wait > scheme > > On Wed, 13 Oct 2021 15:03:56 + > "An

[dpdk-dev] 回复: [RFC PATCH v3 1/5] eal: add new definitions for wait scheme

2021-10-13 Thread Feifei Wang
> -邮件原件- > 发件人: Ananyev, Konstantin > 发送时间: Wednesday, October 13, 2021 11:04 PM > 收件人: Feifei Wang ; Ruifeng Wang > > 抄送: dev@dpdk.org; nd ; nd > 主题: RE: [dpdk-dev] [RFC PATCH v3 1/5] eal: add new definitions for wait > scheme > > > > > [snip] > > > > > > diff --git a/lib/eal/include/g

Re: [dpdk-dev] [PATCH 08/32] net/ngbe: support basic statistics

2021-10-13 Thread Jiawen Wu
On September 16, 2021 12:51 AM, Ferruh Yigit wrote: > On 9/8/2021 9:37 AM, Jiawen Wu wrote: > > Support to read and clear basic statistics, and configure per-queue > > stats counter mapping. > > > > Signed-off-by: Jiawen Wu > > --- > > doc/guides/nics/features/ngbe.ini | 2 + > > doc/guides/ni

Re: [dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs

2021-10-13 Thread Xia, Chenbo
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, October 14, 2021 3:00 AM > To: Harris, James R ; Walker, Benjamin > > Cc: Liu, Changpeng ; Xia, Chenbo > ; David Marchand ; > dev@dpdk.org; Aaron Conole ; Zawadzki, Tomasz > > Subject: Re: [dpdk-dev] [PATCH v2 0/7

[dpdk-dev] Question about bonding port promiscuous

2021-10-13 Thread Min Hu (Connor)
Hi, Declan Doherty, In function "bond_ethdev_promiscuous_disable", for "ROUND ROBIN","BALANCE","BROADCAST","8023AD" mode, Promiscuous mode is propagated to all slaves. While for "ACTIVE_BACKUP", "TLB", "ALB", promiscuous mode is propagated only to primary slave. Why? The second questi

[dpdk-dev] [PATCH v2] net/softnic: fix memory leak of meter policy

2021-10-13 Thread dapengx . yu
From: Dapeng Yu After the meter policies are created, they are not freed on device close. This patch fixes it. Fixes: 5f0d54f372f0 ("ethdev: add pre-defined meter policy API") Cc: sta...@dpdk.org Signed-off-by: Dapeng Yu --- V2: * Rebase on top of main branch --- drivers/net/softnic/rte_eth_

Re: [dpdk-dev] [PATCH] hash: promote APIs to stable

2021-10-13 Thread Wang, Yipeng1
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, October 13, 2021 5:19 PM > To: Stephen Hemminger > Cc: dev@dpdk.org; m...@ashroe.eu; Wang, Yipeng1 > ; Dharmik Thakkar ; > nd ; Medvedkin, Vladimir ; > nd > Subject: RE: [dpdk-dev] [PATCH] hash: promote APIs to stable >

Re: [dpdk-dev] [PATCH] net/bnxt: remove debug macro breaking build

2021-10-13 Thread Ajit Khaparde
On Wed, Oct 13, 2021 at 12:23 PM Ferruh Yigit wrote: > > On 10/13/2021 6:34 PM, Ajit Khaparde wrote: > > On Wed, Oct 13, 2021 at 9:31 AM Ferruh Yigit wrote: > >> > >> Setting 'RTE_LIBRTE_BNXT_TRUFLOW_DEBUG' macro cause build error, > >> removing it. > >> > >> Also with meson build system compile

Re: [dpdk-dev] [PATCH v2 2/6] eal/interrupts: avoid direct access to interrupt handle

2021-10-13 Thread Dmitry Kozlyuk
2021-10-05 17:44 (UTC+0530), Harman Kalra: > Making changes to the interrupt framework to use interrupt handle > APIs to get/set any field. Direct access to any of the fields > should be avoided to avoid any ABI breakage in future. How is ABI breakage applicable to internal consumers? This protec

Re: [dpdk-dev] [PATCH v2 1/6] eal/interrupts: implement get set APIs

2021-10-13 Thread Dmitry Kozlyuk
2021-10-05 17:44 (UTC+0530), Harman Kalra: > [...] > +int rte_intr_instance_copy(struct rte_intr_handle *intr_handle, > +const struct rte_intr_handle *src) > +{ > + if (intr_handle == NULL) { > + RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n"); > +

Re: [dpdk-dev] [PATCH] hash: promote APIs to stable

2021-10-13 Thread Honnappa Nagarahalli
> > On Wed, 13 Oct 2021 16:38:58 -0500 > Honnappa Nagarahalli wrote: > > > --- a/lib/hash/rte_hash.h > > +++ b/lib/hash/rte_hash.h > > @@ -430,7 +430,6 @@ rte_hash_get_key_with_position(const struct > rte_hash *h, const int32_t position, > > * - 0 if freed successfully > > * - -EINVAL

Re: [dpdk-dev] [PATCH] net/bnxt: remove debug macro breaking build

2021-10-13 Thread Ferruh Yigit
On 10/13/2021 6:34 PM, Ajit Khaparde wrote: On Wed, Oct 13, 2021 at 9:31 AM Ferruh Yigit wrote: Setting 'RTE_LIBRTE_BNXT_TRUFLOW_DEBUG' macro cause build error, removing it. Also with meson build system compile time debug macros should be documented in driver documentation, since there is not

Re: [dpdk-dev] [PATCH v7 06/12] ethdev: deprecate direction attributes in transfer flows

2021-10-13 Thread Slava Ovsiienko
Hi, > -Original Message- > From: dev On Behalf Of Ivan Malov > Sent: Wednesday, October 13, 2021 20:35 > To: dev@dpdk.org > Cc: Ferruh Yigit ; NBU-Contact-Thomas Monjalon > ; Ori Kam ; Andrew Rybchenko > ; Ray Kinsella > Subject: [dpdk-dev] [PATCH v7 06/12] ethdev: deprecate direction at

Re: [dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs

2021-10-13 Thread Walker, Benjamin
> From: Thomas Monjalon > Yes I think we need to agree on functions to keep as-is for compatibility. > Waiting for your input please. We've added a task to our backlog to propose a stable ABI for out of tree drivers here. It's not as simple as just keeping a couple of the existing functions -

[dpdk-dev] [PATCH v6 5/5] net/mlx5: update modify field action

2021-10-13 Thread Viacheslav Ovsiienko
Update immediate value/pointer source operand support for modify field RTE Flow action: - source operand data can be presented by byte buffer (instead of former uint64_t) or by pointer - no host byte ordering is assumed anymore for immediate data buffer (not uint64_t anymore) - no im

[dpdk-dev] [PATCH v6 4/5] app/testpmd: fix hex string parser in flow commands

2021-10-13 Thread Viacheslav Ovsiienko
The hexadecimal string parser does not check the target field buffer size, buffer overflow happens and might cause the application failure (segmentation fault is observed usually). Fixes: 169a9fed1f4c ("app/testpmd: fix hex string parser support for flow API") Cc: sta...@dpdk.org Signed-off-by: V

[dpdk-dev] [PATCH v6 2/5] ethdev: fix missed experimental tag for modify field action

2021-10-13 Thread Viacheslav Ovsiienko
EXPERIMENTAL tag was missed in rte_flow_action_modify_data structure description. Fixes: 73b68f4c54a0 ("ethdev: introduce generic modify flow action") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko Acked-by: Ori Kam Acked-by: Andrew Rybchenko --- lib/ethdev/rte_flow.h | 3 +++ 1 file

[dpdk-dev] [PATCH v6 3/5] app/testpmd: update modify field flow action support

2021-10-13 Thread Viacheslav Ovsiienko
The testpmd flow create command updates provided: - modify field action supports the updated actions - pointer type added for action source field - pointer and value source field takes hex string instead of unsigned int in host endianness There are some examples of flow with update modi

[dpdk-dev] [PATCH v6 1/5] ethdev: update modify field flow action

2021-10-13 Thread Viacheslav Ovsiienko
The generic modify field flow action introduced in [1] has some issues related to the immediate source operand: - immediate source can be presented either as an unsigned 64-bit integer or pointer to data pattern in memory. There was no explicit pointer field defined in the union. - th

[dpdk-dev] [PATCH v6 0/5] ethdev: update modify field flow action

2021-10-13 Thread Viacheslav Ovsiienko
The generic modify field flow action introduced in [1] has some issues related to the immediate source operand: - immediate source can be presented either as an unsigned 64-bit integer or pointer to data pattern in memory. There was no explicit pointer field defined in the union - the

Re: [dpdk-dev] [PATCH] hash: promote APIs to stable

2021-10-13 Thread Stephen Hemminger
On Wed, 13 Oct 2021 16:38:58 -0500 Honnappa Nagarahalli wrote: > --- a/lib/hash/rte_hash.h > +++ b/lib/hash/rte_hash.h > @@ -430,7 +430,6 @@ rte_hash_get_key_with_position(const struct rte_hash *h, > const int32_t position, > * - 0 if freed successfully > * - -EINVAL if the parameters ar

Re: [dpdk-dev] [PATCH v3 01/12] ethdev: add port representor item to flow API

2021-10-13 Thread Slava Ovsiienko
Hi, > -Original Message- > From: Ivan Malov > Sent: Wednesday, October 13, 2021 2:15 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; Ori Kam > ; Xiaoyun Li ; Ferruh Yigit > ; Andrew Rybchenko > > Subject: Re: [dpdk-dev] [PATCH v3 01/12] ethdev: add port represent

Re: [dpdk-dev] [PATCH v6 10/12] net/mlx5: support represented port flow action

2021-10-13 Thread Slava Ovsiienko
Hi, > -Original Message- > From: Ivan Malov > Sent: Wednesday, October 13, 2021 20:03 > To: dev@dpdk.org > Cc: Ferruh Yigit ; NBU-Contact-Thomas Monjalon > ; Ori Kam ; Andrew Rybchenko > ; Matan Azrad ; Slava > Ovsiienko > Subject: [PATCH v6 10/12] net/mlx5: support represented port flo

Re: [dpdk-dev] [PATCH] net/bnxt: remove debug macro breaking build

2021-10-13 Thread Ferruh Yigit
On 10/13/2021 10:35 PM, Ajit Khaparde wrote: On Wed, Oct 13, 2021 at 12:23 PM Ferruh Yigit wrote: On 10/13/2021 6:34 PM, Ajit Khaparde wrote: On Wed, Oct 13, 2021 at 9:31 AM Ferruh Yigit wrote: Setting 'RTE_LIBRTE_BNXT_TRUFLOW_DEBUG' macro cause build error, removing it. Also with meson b

Re: [dpdk-dev] [PATCH] net/softnic: remove useless address check

2021-10-13 Thread Ferruh Yigit
On 10/13/2021 4:54 PM, Singh, Jasvinder wrote: -Original Message- From: Yigit, Ferruh Sent: Monday, October 4, 2021 6:27 PM To: Singh, Jasvinder ; Dumitrescu, Cristian Cc: Yigit, Ferruh ; dev@dpdk.org Subject: [PATCH] net/softnic: remove useless address check Reported by "gcc (GCC)

Re: [dpdk-dev] [dpdk-stable] [Patch v2] bus/vmbus: map to the correct ring buffer addresses for the secondary process

2021-10-13 Thread Long Li
> Subject: Re: [dpdk-stable] [Patch v2] bus/vmbus: map to the correct ring > buffer > addresses for the secondary process > > 29/09/2021 22:46, lon...@linuxonhyperv.com: > > From: Long Li > > > > The driver code had wrong assumption that all the addresses to ring > > buffers in the secondary pro

[dpdk-dev] [PATCH] hash: promote APIs to stable

2021-10-13 Thread Honnappa Nagarahalli
Promote rte_hash_free_key_with_position and rte_hash_rcu_qsbr_add APIs to stable. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar --- lib/hash/rte_hash.h | 2 -- lib/hash/version.map | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/hash/rte_hash.h b

Re: [dpdk-dev] [PATCH] net/bnxt: remove debug macro breaking build

2021-10-13 Thread Ajit Khaparde
On Wed, Oct 13, 2021 at 9:31 AM Ferruh Yigit wrote: > > Setting 'RTE_LIBRTE_BNXT_TRUFLOW_DEBUG' macro cause build error, > removing it. > > Also with meson build system compile time debug macros should be > documented in driver documentation, since there is not other way to s/not/no > figure out

[dpdk-dev] [PATCH v6 0/2] net: introduce IPv4 ihl and version fields

2021-10-13 Thread Gregory Etelson
Gregory Etelson (2): net: fix IPv4 change announce net: introduce IPv4 ihl and version fields app/test/test_flow_classify.c | 8 doc/guides/rel_notes/deprecation.rst | 6 -- doc/guides/rel_notes/release_21_11.rst | 3 +++ lib/net/rte_ip.h | 16

[dpdk-dev] [PATCH v6 1/2] net: fix IPv4 change announce

2021-10-13 Thread Gregory Etelson
IPv4 header encodes fragment information into 16 bits field. 3 bits hold flags and remaining 13 bits are for fragment offset. 13 bits bit-field cannot be defined both for big and little endian systems. The patch removes IPv4 fragments union announce. Fixes: f7383e7c7ec1 ("net: announce changes in

[dpdk-dev] [PATCH v6 2/2] net: introduce IPv4 ihl and version fields

2021-10-13 Thread Gregory Etelson
RTE IPv4 header definition combines the `version' and `ihl' fields into a single structure member. This patch introduces dedicated structure members for both `version' and `ihl' IPv4 fields. Separated header fields definitions allow to create simplified code to match on the IHL value in a flow rul

Re: [dpdk-dev] [PATCH v5] net: introduce IPv4 ihl and version fields

2021-10-13 Thread Gregory Etelson
Hello, ..snip.. > > The deprecation notice for `fragment_offset` > seems not implemented but removed. > > What do you think to remove the relevant part > that is implemented in this patch, > remove the residue in another patch explaining > why it is not implemented? I'll update the patch in v6.

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] ip_frag: fix fragmenting IPv4 fragment

2021-10-13 Thread Thomas Monjalon
09/10/2021 09:27, huichao cai: > Current implementation of rte_ipv4_fragment_packet() doesn’t take > into account offset and flag values of the given packet, but blindly > assumes they are always zero (original packet is not fragmented). > According to RFC791, fragment and flag values for new fragm

Re: [dpdk-dev] [PATCH v7 00/12] ethdev: rework transfer flow API

2021-10-13 Thread Ferruh Yigit
On 10/13/2021 6:34 PM, Ivan Malov wrote: As per RFC [1], action PORT_ID appears to be ambiguous. Its name suggests that matching traffic be sent to the ethdev with the specified ID, that is, to the application. However, in Open vSwitch, the action is used to send traffic to a remote entity repres

Re: [dpdk-dev] [PATCH v2] mbuf: remove deprecated bad outer IPv4 checksum flag on Rx

2021-10-13 Thread Thomas Monjalon
11/10/2021 16:28, Andrew Rybchenko: > Removed offload flag PKT_RX_EIP_CKSUM_BAD. PKT_RX_OUTER_IP_CKSUM_BAD > should be used as a replacement. > > Signed-off-by: Andrew Rybchenko > Acked-by: Olivier Matz Applied, thanks.

Re: [dpdk-dev] [PATCH] mempool: fix name size in mempool structure

2021-10-13 Thread Thomas Monjalon
13/10/2021 13:07, David Marchand: > On Wed, Oct 13, 2021 at 10:57 AM Andrew Rybchenko > wrote: > > > > Use correct define as a name array size. > > > > The change breaks ABI and therefore cannot be backported to > > stable branches. > > > > Fixes: 38c9817ee1d8 ("mempool: adjust name size in relate

[dpdk-dev] [PATCH v5 2/2] build: add meson options of max_memseg_lists

2021-10-13 Thread Kefu Chai
RTE_MAX_MEMSEG_LISTS = 128 is not enough for many-core machines, in our case, we need to increase it to 8192. so add an option so user can override it. Signed-off-by: Kefu Chai --- config/meson.build | 1 + config/rte_config.h | 1 - meson_options.txt | 2 ++ 3 files changed, 3 insertions(+),

[dpdk-dev] [PATCH v5 1/2] build: add meson options of atomic_mbuf_ref_counts

2021-10-13 Thread Kefu Chai
RTE_MBUF_REFCNT_ATOMIC = 0 is not necessary for applications like Seastar, where it's safe to assume that the mbuf refcnt is only updated by a single core only. Signed-off-by: Kefu Chai --- config/meson.build | 4 +++- config/rte_config.h | 1 - meson_options.txt | 2 ++ 3 files changed, 5 in

[dpdk-dev] [PATCH v5 0/2] build: add meson option of "max_memseg_lists" and "mbuf_refcnt_atomic"

2021-10-13 Thread Kefu Chai
--- v5: * split the changes of two options into two separated commits one for atomic_mbuf_ref_counts, the other for max_memseg_lists v4: * fix the coding style issue by reduce the line length to under 75. this change should silence the warning like: v3: * s/mbuf_refcnt_atomic/atomic_mbuf_

[dpdk-dev] [PATCH v2] stack: remove duplicated include of atomic

2021-10-13 Thread Dharmik Thakkar
From: Joyce Kong In stack module, remove the header file rte_atomic.h as it is not being used. Signed-off-by: Joyce Kong Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- v2: Change commit message (Olivier) --- app/test/test_stack.c | 1 - lib/stack/rte_stack.c | 1 - lib/stack

[dpdk-dev] [PATCH v4 2/2] test/eal: add a test for rte_ctrl_thread_create

2021-10-13 Thread Honnappa Nagarahalli
Add a testcase to test launching of control threads. Signed-off-by: Honnappa Nagarahalli --- app/test/test_lcores.c | 41 + 1 file changed, 41 insertions(+) diff --git a/app/test/test_lcores.c b/app/test/test_lcores.c index 19a7ab9fce..35c47d5372 100644 -

[dpdk-dev] [PATCH v4 1/2] eal: simplify the implementation of rte_ctrl_thread_create

2021-10-13 Thread Honnappa Nagarahalli
Remove the usage of pthread barrier and replace it with synchronization using atomic variable. This also removes the use of reference count required to synchronize freeing the memory. Signed-off-by: Honnappa Nagarahalli --- v4: 1) Used rte_delay_us_sleep instead of sched_yield. Using sched_yield

Re: [dpdk-dev] [PATCH 1/2] doc: fix the list of supported flow actions in net/sfc

2021-10-13 Thread Ferruh Yigit
On 10/13/2021 6:52 PM, Ivan Malov wrote: The list is sorted alphabetically. Fixes: fc793bd2 ("net/sfc: support jump flows in tunnel offload") Signed-off-by: Ivan Malov For series, Squashed into relevant commit in next-net, thanks.

Re: [dpdk-dev] [PATCH v6 0/6] hide eth dev related structures

2021-10-13 Thread Ferruh Yigit
On 10/13/2021 2:36 PM, Konstantin Ananyev wrote: v6 changes: - Update comments (Andrew) - Move callback related variables under corresponding ifdefs (Andrew) - Few nits in rte_eth_macaddrs_get (Andrew) - Rebased on top of next-net tree v5 changes: - Fix spelling (Thomas/David) - Rename internal

[dpdk-dev] [PATCH v2] app/test-eventdev: add burst enqueue support

2021-10-13 Thread Rashmi Shetty
This commit introduces a new command line option prod_enq_burst_sz to set burst size for eventdev enqueue at producer in perf_queue test. The newly added function perf_producer_burst is called when prod_enq_burst_sz is greater than 1. Signed-off-by: Rashmi Shetty --- app/test-eventdev/evt_common

[dpdk-dev] [PATCH v2] test/hash: fix buffer overflow

2021-10-13 Thread Vladimir Medvedkin
This patch fixes buffer overflow reported by ASAN, please reference https://bugs.dpdk.org/show_bug.cgi?id=818 Some tests for the rte_hash table use the rte_jhash_32b() as the hash function. This hash function interprets the length argument in units of 4 bytes. This patch divides configured key le

Re: [dpdk-dev] [PATCH] test/hash: fix buffer overflow

2021-10-13 Thread Medvedkin, Vladimir
Hi David, On 11/10/2021 13:03, David Marchand wrote: On Fri, Oct 8, 2021 at 11:28 PM Vladimir Medvedkin wrote: This patch fixes buffer overflow reported by ASAN, please reference https://bugs.dpdk.org/show_bug.cgi?id=818 Some tests for the rte_hash table use the rte_jhash_32b() as the hash f

Re: [dpdk-dev] [PATCH] net/bnxt: remove debug macro breaking build

2021-10-13 Thread Ferruh Yigit
On 10/13/2021 6:34 PM, Ajit Khaparde wrote: On Wed, Oct 13, 2021 at 9:31 AM Ferruh Yigit wrote: Setting 'RTE_LIBRTE_BNXT_TRUFLOW_DEBUG' macro cause build error, removing it. Also with meson build system compile time debug macros should be documented in driver documentation, since there is not

[dpdk-dev] [PATCH v2 7/7] cryptodev: pass session iova in configure session

2021-10-13 Thread Akhil Goyal
Some PMDs need session physical address which can be passed to the hardware. But since sym_session_configure does not allow PMD to get mempool object, the PMD cannot call rte_mempool_virt2iova(). Hence the library layer need to calculate the iova for session private data and pass it to the PMD. Si

[dpdk-dev] [PATCH v2 6/7] cryptodev: hide sym session structure

2021-10-13 Thread Akhil Goyal
Structure rte_cryptodev_sym_session is moved to internal headers which are not visible to applications. The only field which should be used by app is opaque_data. This field can now be accessed via set/get APIs added in this patch. Subsequent changes in app and lib are made to compile the code. Si

[dpdk-dev] [PATCH v2 5/7] cryptodev: rework session framework

2021-10-13 Thread Akhil Goyal
As per current design, rte_cryptodev_sym_session_create() and rte_cryptodev_sym_session_init() use separate mempool objects for a single session. And structure rte_cryptodev_sym_session is not directly used by the application, it may cause ABI breakage if the structure is modified in future. To ad

[dpdk-dev] [PATCH v2 4/7] security: pass session iova in PMD sess create

2021-10-13 Thread Akhil Goyal
Some PMDs need session physical address which can be passed to the hardware. But since security_session_create does not allow PMD to get mempool object, the PMD cannot call rte_mempool_virt2iova(). Hence the library layer need to calculate the iova for session private data and pass it to the PMD.

[dpdk-dev] [PATCH v2 3/7] net/cnxk: rework security session framework

2021-10-13 Thread Akhil Goyal
Aligned the security session create and destroy as per the recent changes in rte_security and used the fast mdata field introduced in rte_security. Enabled compilation of cnxk driver. Signed-off-by: Nithin Dabilpuram Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 64 ++

[dpdk-dev] [PATCH v2 2/7] security: hide security session struct

2021-10-13 Thread Akhil Goyal
rte_security_session struct is now hidden in the library. application can access the opaque data and fast_mdata using the set/get APIs introduced in this patch. Signed-off-by: Akhil Goyal --- lib/ipsec/rte_ipsec.h | 2 +- lib/ipsec/rte_ipsec_group.h| 5 +-- lib/ipsec/ses.c

  1   2   3   4   5   >