Re: [dpdk-dev] [EXT] Re: [PATCH v2 3/3] security: add reserved bitfields

2021-10-11 Thread Thomas Monjalon
11/10/2021 18:58, Akhil Goyal: > > 08/10/2021 22:45, Akhil Goyal: > > > In struct rte_security_ipsec_sa_options, for every new option > > > added, there is an ABI breakage, to avoid, a reserved_opts > > > bitfield is added to for the remaining bits available in the > > > structure. > > > Now for ev

Re: [dpdk-dev] [dpdk-ci] [PATCH v6 0/3] eal: add memory pre-allocation from existing files

2021-10-11 Thread Thomas Monjalon
11/10/2021 23:12, Lincoln Lavoie: > Hi All, > > I'm assuming this should be added to the "checkpatch" job / report? I think yes. > Correct, or do folks feel this should be a separate run / report? Please what are the tests already run in this job? I may suggest more. > On Mon, Oct 11, 2021 at

Re: [dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16 check

2021-10-11 Thread Thomas Monjalon
11/10/2021 22:38, Chautru, Nicolas: > From: Thomas Monjalon > > 13/08/2021 18:51, Nicolas Chautru: > > > Adding a missing operation when CRC16 > > > is being used for TB CRC check. > > > > > > Signed-off-by: Nicolas Chautru > > > --- > > > --- a/doc/guides/rel_notes/release_21_11.rst > > > +++ b/

Re: [dpdk-dev] [PATCH v3 2/4] mempool: add non-IO flag

2021-10-11 Thread Andrew Rybchenko
On 10/12/21 3:04 AM, Dmitry Kozlyuk wrote: > Mempool is a generic allocator that is not necessarily used for device > IO operations and its memory for DMA. Add MEMPOOL_F_NON_IO flag to mark > such mempools. > Discussion: https://mails.dpdk.org/archives/dev/2021-August/216654.html > > Signed-off-by

Re: [dpdk-dev] [PATCH v3 1/4] mempool: add event callbacks

2021-10-11 Thread Andrew Rybchenko
On 10/12/21 3:04 AM, Dmitry Kozlyuk wrote: > Data path performance can benefit if the PMD knows which memory it will > need to handle in advance, before the first mbuf is sent to the PMD. > It is impractical, however, to consider all allocated memory for this > purpose. Most often mbuf memory comes

Re: [dpdk-dev] [RFC 00/14] vhost: clean-up and simplify async implementation

2021-10-11 Thread Hu, Jiayu
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, October 8, 2021 6:00 AM > To: dev@dpdk.org; Xia, Chenbo ; Hu, Jiayu > ; Wang, YuanX ; Ma, > WenwuX ; Richardson, Bruce > ; Mcnamara, John > > Cc: Maxime Coquelin > Subject: [RFC 00/14] vhost: clean-up and simplify a

[dpdk-dev] [PATCH v4 5/5] examples/l3fwd-power: support virtio/vhost

2021-10-11 Thread Miao Li
In l3fwd-power, there is default port configuration which requires RSS and IPV4/UDP/TCP checksum. Once device does not support these, the l3fwd-power will exit and report an error. This patch updates the port configuration based on device capabilities after getting the device information to support

[dpdk-dev] [PATCH v4 4/5] power: modify return of queue_stopped

2021-10-11 Thread Miao Li
Since some vdevs like virtio and vhost do not support rxq_info_get and queue state inquiry, the error return value -ENOTSUP need to be ignored when queue_stopped cannot get rx queue information and rx queue state. This patch changes the return value of queue_stopped when rte_eth_rx_queue_info_get r

[dpdk-dev] [PATCH v4 3/5] net/vhost: implement rte_power_monitor API

2021-10-11 Thread Miao Li
This patch implements rte_power_monitor API in vhost PMD to reduce power consumption when no packet come in. According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value against the expected value and vhost_get_mo

[dpdk-dev] [PATCH v4 2/5] vhost: implement rte_power_monitor API

2021-10-11 Thread Miao Li
This patch defines rte_vhost_power_monitor_cond which is used to pass some information to vhost driver. The information is including the address to monitor, the expected value, the mask to extract value read from 'addr', the value size of monitor address, the match flag used to distinguish the valu

[dpdk-dev] [PATCH v4 1/5] net/virtio: implement rte_power_monitor API

2021-10-11 Thread Miao Li
This patch implements rte_power_monitor API in virtio PMD to reduce power consumption when no packet come in. According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value against the expected value and virtio_get_

[dpdk-dev] [PATCH v4 0/5] Implement rte_power_monitor API in virtio/vhost PMD

2021-10-11 Thread Miao Li
This patchset implements rte_power_monitor API in virtio and vhost PMD to reduce power consumption when no packet come in. This API can be called and tested in l3fwd-power after adding vhost and virtio support in l3fwd-power and ignoring the rx queue information check in queue_stopped(). v4: -modi

Re: [dpdk-dev] [PATCH v2 2/4] mempool: add non-IO flag

2021-10-11 Thread Andrew Rybchenko
On 10/5/21 7:39 PM, Thomas Monjalon wrote: > 29/09/2021 16:52, dkozl...@oss.nvidia.com: >> From: Dmitry Kozlyuk >> >> Mempool is a generic allocator that is not necessarily used for device >> IO operations and its memory for DMA. Add MEMPOOL_F_NON_IO flag to mark >> such mempools. >> >> Signed-off

Re: [dpdk-dev] [RFC 08/14] vhost: improve IO vector logic

2021-10-11 Thread Hu, Jiayu
Hi, > -Original Message- > From: Maxime Coquelin > Sent: Friday, October 8, 2021 6:00 AM > To: dev@dpdk.org; Xia, Chenbo ; Hu, Jiayu > ; Wang, YuanX ; Ma, > WenwuX ; Richardson, Bruce > ; Mcnamara, John > > Cc: Maxime Coquelin > Subject: [RFC 08/14] vhost: improve IO vector logic > > I

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: fix max Rx packet length

2021-10-11 Thread Andrew Rybchenko
On 10/12/21 2:53 AM, Ferruh Yigit wrote: > There is a confusion on setting max Rx packet length, this patch aims to > clarify it. > > 'rte_eth_dev_configure()' API accepts max Rx packet size via > 'uint32_t max_rx_pkt_len' field of the config struct 'struct > rte_eth_conf'. > > Also 'rte_eth_dev_

Re: [dpdk-dev] [PATCH v6 5/6] ethdev: unify MTU checks

2021-10-11 Thread Andrew Rybchenko
On 10/12/21 2:53 AM, Ferruh Yigit wrote: > Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but > have slightly different checks. Like one checks min MTU against > RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. > > Checks moved into common function to unify the checks. Also this h

Re: [dpdk-dev] [PATCH v12 1/2] ethdev: add an API to get device configuration

2021-10-11 Thread Andrew Rybchenko
On 10/12/21 5:54 AM, Jie Wang wrote: > The driver may change offloads info into dev->data->dev_conf > in dev_configure which may cause apps use outdated values. > > Add a new API to get actual device configuration. > > Signed-off-by: Jie Wang Acked-by: Andrew Rybchenko [snip] > diff --git a/

Re: [dpdk-dev] [PATCH v5 2/7] ethdev: allocate max space for internal queue array

2021-10-11 Thread Andrew Rybchenko
On 10/12/21 2:06 AM, Ananyev, Konstantin wrote: > At queue configure stage always allocate space for maximum possible > number (RTE_MAX_QUEUES_PER_PORT) of queue pointers. > That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer > pointer to internal queue data withou

Re: [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on DPDK

2021-10-11 Thread Peng, ZhihongX
> -Original Message- > From: David Marchand > Sent: Friday, October 8, 2021 4:30 PM > To: Peng, ZhihongX ; Richardson, Bruce > > Cc: Burakov, Anatoly ; Ananyev, Konstantin > ; Stephen Hemminger > ; dev ; Lin, Xueqin > ; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH v6 1/2] Enable ASan

[dpdk-dev] [PATCH v2] net/bnxt: enhance support for RSS action

2021-10-11 Thread Ajit Khaparde
Enhance support for RSS action in the non-TruFlow path. This will allow the user or application to update the RSS settings using RTE_FLOW API. Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Reviewed-by: Kalesh AP --- v1->v2: sent the correct patch. --- drivers/net/bnxt/bnxt_filter.

Re: [dpdk-dev] [PATCH v5 5/6] ethdev: unify MTU checks

2021-10-11 Thread lihuisong (C)
在 2021/10/12 4:15, Ferruh Yigit 写道: On 10/9/2021 12:43 PM, lihuisong (C) wrote: Hi, Ferruh 在 2021/10/8 0:56, Ferruh Yigit 写道: Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but have slightly different checks. Like one checks min MTU against RTE_ETHER_MIN_MTU and other RTE_

Re: [dpdk-dev] [PATCH v25 2/6] dmadev: add control plane API support

2021-10-11 Thread fengchengwen
On 2021/10/11 23:44, Bruce Richardson wrote: > On Mon, Oct 11, 2021 at 03:33:44PM +0800, Chengwen Feng wrote: >> This patch add control plane API for dmadev. >> >> Signed-off-by: Chengwen Feng >> Acked-by: Bruce Richardson >> Acked-by: Morten Brørup >> Reviewed-by: Kevin Laatz >> Reviewed-by: C

Re: [dpdk-dev] [PATCH v3 2/4] mempool: add non-IO flag

2021-10-11 Thread Jerin Jacob
On Tue, Oct 12, 2021 at 5:34 AM Dmitry Kozlyuk wrote: > > Mempool is a generic allocator that is not necessarily used for device > IO operations and its memory for DMA. Add MEMPOOL_F_NON_IO flag to mark > such mempools. > Discussion: https://mails.dpdk.org/archives/dev/2021-August/216654.html > >

Re: [dpdk-dev] [kmods PATCH v1] windows/netuio: add Intel e1000 device IDs

2021-10-11 Thread Kadam, Pallavi
Hi William, On 10/11/2021 11:49 AM, William Tu wrote: Add Intel Ethernet e1000 device IDs to netuio inf file. Signed-off-by: William Tu -- DPDK patch at: http://inbox.dpdk.org/dev/20211007202451.90271-1-u9012...@gmail.com/T/#t --- windows/netuio/netuio.inf | 4 1 file changed, 4 insert

Re: [dpdk-dev] [PATCH 1/4] mempool: add event callbacks

2021-10-11 Thread Jerin Jacob
On Wed, Aug 18, 2021 at 2:38 PM Dmitry Kozlyuk wrote: > > Performance of MLX5 PMD of different classes can benefit if PMD knows > which memory it will need to handle in advance, before the first mbuf > is sent to the PMD. It is impractical, however, to consider > all allocated memory for this purp

Re: [dpdk-dev] [PATCH v2] ethdev: fix one MAC address occupies two index in mac addrs

2021-10-11 Thread lihuisong (C)
在 2021/10/11 18:35, Thomas Monjalon 写道: 11/10/2021 11:28, Min Hu (Connor): From: Huisong Li The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by rte_eth_dev_default_mac_addr_set() API. However, If the new default MAC address has

[dpdk-dev] [PATCH v12 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-10-11 Thread Jie Wang
The driver may change offloads info into dev->data->dev_conf in dev_configure which may cause port->dev_conf and port->rx_conf contain outdated values. This patch updates the offloads info if it changes to fix this issue. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Signe

[dpdk-dev] [PATCH v12 1/2] ethdev: add an API to get device configuration

2021-10-11 Thread Jie Wang
The driver may change offloads info into dev->data->dev_conf in dev_configure which may cause apps use outdated values. Add a new API to get actual device configuration. Signed-off-by: Jie Wang --- doc/guides/rel_notes/release_21_11.rst | 4 lib/ethdev/rte_ethdev.c| 20 +++

[dpdk-dev] [PATCH v12 0/2] testpmd shows incorrect rx_offload configuration

2021-10-11 Thread Jie Wang
Launch testpmd with multiple queues, and check rx_offload info. When testpmd shows the port configuration, it doesn't show RSS_HASH. --- v12: update the commit log and the API comment. v11: - update the commit log. - rename the function and variable name. v10: - update the commit log. - merge

[dpdk-dev] [PATCH] net/bnxt: updates to RSS action support

2021-10-11 Thread Ajit Khaparde
Some changes to the RSS action support to return appropriate error. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.h | 2 +- drivers/net/bnxt/bnxt_flow.c | 60 +++--- 2 files changed, 34 insertions(+), 28 deletions(-) diff --git a/drivers/net/bnxt/b

Re: [dpdk-dev] [PATCH] net/bnxt: fix clang compiler warnings

2021-10-11 Thread Stephen Hemminger
On Sat, 9 Oct 2021 21:07:55 -0700 Ajit Khaparde wrote: > + if ((uint32_t)item->type >= > + (uint32_t)BNXT_RTE_FLOW_ITEM_TYPE_END) { This doesn't look right, you are casting away your troubles, not addressing the root cause. item->type is type rte_flow_item_type BNX

Re: [dpdk-dev] [dpdk-stable] [PATCH v6 2/2] lib/pipeline: Fix gcc compilation error using ASan

2021-10-11 Thread Peng, ZhihongX
> -Original Message- > From: David Marchand > Sent: Thursday, September 30, 2021 4:30 PM > To: Peng, ZhihongX > Cc: Burakov, Anatoly ; Ananyev, Konstantin > ; Stephen Hemminger > ; dev ; Lin, Xueqin > ; dpdk stable > Subject: Re: [dpdk-stable] [PATCH v6 2/2] lib/pipeline: Fix gcc compila

Re: [dpdk-dev] [PATCH v12 00/12] Packet capture framework update

2021-10-11 Thread Stephen Hemminger
On Fri, 1 Oct 2021 09:26:53 -0700 Stephen Hemminger wrote: > This patch set is a more complete version of the the enhanced > packet capture support described last year. > > The new capture library and utility are: > - faster avoids lots of extra I/O, does bursting, etc. > - gives more infor

Re: [dpdk-dev] [kmods PATCH v1] windows/netuio: add Intel e1000 device IDs

2021-10-11 Thread Dmitry Kozlyuk
2021-10-11 11:49 (UTC-0700), William Tu: > Add Intel Ethernet e1000 device IDs to netuio inf file. > > Signed-off-by: William Tu Acked-by: Dmitry Kozlyuk

Re: [dpdk-dev] [PATCH v4] app/testpmd: add command to print representor info

2021-10-11 Thread Li, Xiaoyun
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 11, 2021 21:09 > To: Li, Xiaoyun > Cc: dev@dpdk.org; Viacheslav Galaktionov > ; Andy Moreton ; > Xueming Li ; Ajit Khaparde > > Subject: [PATCH v4] app/testpmd: add command to print representor info > > From: Viachesl

[dpdk-dev] [kmods PATCH] windows/netuio: add interrupt support

2021-10-11 Thread Dmitry Kozlyuk
Add IOCTL for interrupt event delivery to user space. * IOCTL_NETUIO_INTR_CONTROL: Enable/disable the delivery of interrupt events. This is a software switch to ignore received interrupts. Programming the HW to stop issuing interrupts is up to the user. * IOCTL_NETUIO_INTR_QUERY: Wait for

Re: [dpdk-dev] [dpdk-ci] RHEL7 failures

2021-10-11 Thread Ferruh Yigit
On 10/11/2021 11:45 PM, Thinh Tran wrote: Hi Brandon, Does the rebuild have the fix for RHEL 7? Please check. I just checked the build status, it still hits the same failure on RHEL 7: https://lab.dpdk.org/results/dashboard/patchsets/19066/ Your patch still applied on 'dpdk (086d426406bd3f6f

[dpdk-dev] [kmods PATCH v3 3/3] windows/virt2phys: add tracing

2021-10-11 Thread Dmitry Kozlyuk
WPP tracing [1] allows kernel drivers to print logs that can be viewed without attaching a debugger to the running system. Traces are colelcted only when enabled. Instrument virt2phys with traces: * ERROR: failures that prevent the driver from working. * WARNING: incorrect calls to the driver. *

[dpdk-dev] [kmods PATCH v3 2/3] windows/virt2phys: add limits against resource exhaustion

2021-10-11 Thread Dmitry Kozlyuk
Tracked processes are enumerated in process creation/termination callback, making it O(N = number of tracked processes). A malicious user could cause system-wide slowdown of process termination by making just one call to virt2phys from many processes. Limit the number of tracked processes by `Proce

[dpdk-dev] [kmods PATCH v3 1/3] windows/virt2phys: do not expose pageable physical addresses

2021-10-11 Thread Dmitry Kozlyuk
virt2phys relied on the user to ensure that memory for which physical address (PA) is obtained is non-pageable and remains such for the lifetime of the process. While DPDK does lock pages in memory, virt2phys can be accessed by any process with sufficient privileges. A malicious process could get P

[dpdk-dev] [kmods PATCH v3 0/3] windows/virt2phys: fix paging issue

2021-10-11 Thread Dmitry Kozlyuk
Physical addresses exposed by virt2phys driver could become pageable. This presents stability and security issues that prevent Microsoft from signing virt2phys, because a signed driver would be trusted by all end-user machines. Ensure that memory for which physical addresses are exposed by virt2ph

Re: [dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs

2021-10-11 Thread Harris, James R
On 10/11/21, 5:55 AM, "Thomas Monjalon" wrote: 11/10/2021 08:58, Xia, Chenbo: > From: Liu, Changpeng > > Another issue raised by Jim Harris is that for distro packaged DPDK, since > > this option isn't enabled by default, this will not allow SPDK > > to use the distro pac

Re: [dpdk-dev] Mmap query

2021-10-11 Thread Brijesh Singh
Hi Dmitry, Thank you for your response. The mystery is that we are not doing mmap anonymous, and ftrace shows high time for clear page. I suspect, the file is being unlinked before being opened. But we haven't been able to trace it yet. Regards, Brijesh On Mon, Oct 11, 2021 at 12:38 PM Dmitr

[dpdk-dev] [PATCH v3 3/4] common/mlx5: add mempool registration facilities

2021-10-11 Thread Dmitry Kozlyuk
Add internal API to register mempools, that is, to create memory regions (MR) for their memory and store them in a separate database. Implementation deals with multi-process, so that class drivers don't need to. Each protection domain has its own database. Memory regions can be shared within a data

[dpdk-dev] [PATCH v3 4/4] net/mlx5: support mempool registration

2021-10-11 Thread Dmitry Kozlyuk
When the first port in a given protection domain (PD) starts, install a mempool event callback for this PD and register all existing memory regions (MR) for it. When the last port in a PD closes, remove the callback and unregister all mempools for this PD. This behavior can be switched off with a n

[dpdk-dev] [PATCH v3 2/4] mempool: add non-IO flag

2021-10-11 Thread Dmitry Kozlyuk
Mempool is a generic allocator that is not necessarily used for device IO operations and its memory for DMA. Add MEMPOOL_F_NON_IO flag to mark such mempools. Discussion: https://mails.dpdk.org/archives/dev/2021-August/216654.html Signed-off-by: Dmitry Kozlyuk Acked-by: Matan Azrad --- doc/guide

[dpdk-dev] [PATCH v3 1/4] mempool: add event callbacks

2021-10-11 Thread Dmitry Kozlyuk
Data path performance can benefit if the PMD knows which memory it will need to handle in advance, before the first mbuf is sent to the PMD. It is impractical, however, to consider all allocated memory for this purpose. Most often mbuf memory comes from mempools that can come and go. PMD can enumer

[dpdk-dev] [PATCH v3 0/4] net/mlx5: implicit mempool registration

2021-10-11 Thread Dmitry Kozlyuk
MLX5 hardware has its internal IOMMU where PMD registers the memory. On the data path, PMD translates VA into a key consumed by the device IOMMU. It is impractical for the PMD to register all allocated memory because of increased lookup cost both in HW and SW. Most often mbuf memory comes from me

[dpdk-dev] [PATCH v6 6/6] examples/ip_reassembly: remove unused parameter

2021-10-11 Thread Ferruh Yigit
Remove 'max-pkt-len' parameter. Signed-off-by: Ferruh Yigit Acked-by: Konstantin Ananyev --- examples/ip_reassembly/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index 4caa9ac3cafa..4f0e12e62447 100644 --- a/examples/ip

[dpdk-dev] [PATCH v6 5/6] ethdev: unify MTU checks

2021-10-11 Thread Ferruh Yigit
Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but have slightly different checks. Like one checks min MTU against RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. Checks moved into common function to unify the checks. Also this has benefit to have common error logs. Default 'dev

[dpdk-dev] [PATCH v6 4/6] ethdev: remove jumbo offload flag

2021-10-11 Thread Ferruh Yigit
Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. Instead of drivers announce this capability, application can deduct the capability by checking reported 'dev_info.max_mtu' or 'dev_info.max_rx_pktlen'. And instead of application setting this flag explicitly to enable jumbo frames, this can be d

[dpdk-dev] [PATCH v6 3/6] ethdev: move check to library for MTU set

2021-10-11 Thread Ferruh Yigit
Move requested MTU value check to the API to prevent the duplicated code. Signed-off-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko Reviewed-by: Rosen Xu Acked-by: Somnath Kotur Acked-by: Konstantin Ananyev --- drivers/net/axgbe/axgbe_ethdev.c| 15 --- drivers/net/bnxt/bn

[dpdk-dev] [PATCH v6 2/6] ethdev: move jumbo frame offload check to library

2021-10-11 Thread Ferruh Yigit
Setting MTU bigger than RTE_ETHER_MTU requires the jumbo frame support, and application should enable the jumbo frame offload support for it. When jumbo frame offload is not enabled by application, but MTU bigger than RTE_ETHER_MTU is requested there are two options, either fail or enable jumbo fr

Re: [dpdk-dev] [PATCH v5 2/7] ethdev: allocate max space for internal queue array

2021-10-11 Thread Ananyev, Konstantin
> >>> At queue configure stage always allocate space for maximum possible > >>> number (RTE_MAX_QUEUES_PER_PORT) of queue pointers. > >>> That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer > >>> pointer to internal queue data without extra checking of current number > >>> of con

Re: [dpdk-dev] [dpdk-ci] RHEL7 failures

2021-10-11 Thread Thinh Tran
Hi Brandon, Does the rebuild have the fix for RHEL 7? Please check. I just checked the build status, it still hits the same failure on RHEL 7: [1502/2903] Compiling C object drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o FAILED: drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o c

Re: [dpdk-dev] [PATCH v3 06/12] ethdev: deprecate direction attributes in transfer flows

2021-10-11 Thread Ori Kam
Hi Ivan, > -Original Message- > From: Ivan Malov > Sent: Sunday, October 10, 2021 5:39 PM > Subject: [PATCH v3 06/12] ethdev: deprecate direction attributes in transfer > flows > > Attributes "ingress" and "egress" can only apply unambiguosly to > non-"transfer" flows. In "transfer" >

Re: [dpdk-dev] [PATCH v3 05/12] ethdev: deprecate hard-to-use or ambiguous items and actions

2021-10-11 Thread Ori Kam
Hi Ivan, > -Original Message- > From: Ivan Malov > Sent: Sunday, October 10, 2021 5:39 PM > Subject: [PATCH v3 05/12] ethdev: deprecate hard-to-use or ambiguous items > and actions > > PF, VF and PHY_PORT require that applications have extra knowledge of the > underlying NIC and thus a

Re: [dpdk-dev] [PATCH v3 04/12] ethdev: add represented port action to flow API

2021-10-11 Thread Ori Kam
Hi Ivan, > -Original Message- > From: Ivan Malov > Sent: Sunday, October 10, 2021 5:39 PM > Subject: [PATCH v3 04/12] ethdev: add represented port action to flow API > > For use in "transfer" flows. Supposed to send matching traffic to the entity > represented by the given > ethdev, at

Re: [dpdk-dev] [PATCH v3 03/12] ethdev: add port representor action to flow API

2021-10-11 Thread Ori Kam
Hi Ivan > -Original Message- > From: Ivan Malov > Sent: Sunday, October 10, 2021 5:39 PM > Subject: [PATCH v3 03/12] ethdev: add port representor action to flow API > > For use in "transfer" flows. Supposed to send matching traffic to the given > ethdev (to the application), at > embedd

[dpdk-dev] [PATCH v3 5/5] app/testpmd: add flex item CLI commands

2021-10-11 Thread Viacheslav Ovsiienko
From: Gregory Etelson Network port hardware is shipped with fixed number of supported network protocols. If application must work with a protocol that is not included in the port hardware by default, it can try to add the new protocol to port hardware. Flex item or flex parser is port infrastruc

[dpdk-dev] [PATCH v3 4/5] app/testpmd: add jansson library

2021-10-11 Thread Viacheslav Ovsiienko
From: Gregory Etelson Testpmd interactive mode provides CLI to configure application commands. Testpmd reads CLI command and parameters from STDIN, and converts input into C objects with internal parser. The patch adds jansson dependency to testpmd. With jansson, testpmd can read input in JSON fo

[dpdk-dev] [PATCH v3 0/5] ethdev: introduce configurable flexible item

2021-10-11 Thread Viacheslav Ovsiienko
1. Introduction and Retrospective Nowadays the networks are evolving fast and wide, the network structures are getting more and more complicated, the new application areas are emerging. To address these challenges the new network protocols are continuously being developed, considered by technical

[dpdk-dev] [PATCH v3 3/5] ethdev: implement RTE flex item API

2021-10-11 Thread Viacheslav Ovsiienko
From: Gregory Etelson RTE flex item API was introduced in "ethdev: introduce configurable flexible item" patch. The API allows DPDK application to define parser for custom network header in port hardware and offload flows that will match the custom header elements. Signed-off-by: Gregory Etelso

[dpdk-dev] [PATCH v3 1/5] ethdev: introduce configurable flexible item

2021-10-11 Thread Viacheslav Ovsiienko
1. Introduction and Retrospective Nowadays the networks are evolving fast and wide, the network structures are getting more and more complicated, the new application areas are emerging. To address these challenges the new network protocols are continuously being developed, considered by technical

[dpdk-dev] [PATCH v3 2/5] ethdev: support flow elements with variable length

2021-10-11 Thread Viacheslav Ovsiienko
From: Gregory Etelson RTE flow API provides RAW item type for packet patterns of variable length. The RAW item structure has fixed size members that describe the variable pattern length and methods to process it. A new RTE flow item type with variable length pattern that does not fit the RAW ite

Re: [dpdk-dev] [EXT] Re: [PATCH v2 3/3] security: add reserved bitfields

2021-10-11 Thread Stephen Hemminger
On Mon, 11 Oct 2021 16:58:24 + Akhil Goyal wrote: > > 08/10/2021 22:45, Akhil Goyal: > > > In struct rte_security_ipsec_sa_options, for every new option > > > added, there is an ABI breakage, to avoid, a reserved_opts > > > bitfield is added to for the remaining bits available in the > > >

Re: [dpdk-dev] [PATCH v4 1/6] ethdev: fix max Rx packet length

2021-10-11 Thread Ferruh Yigit
On 10/10/2021 7:30 AM, Matan Azrad wrote: Hi Ferruh From: Ferruh Yigit There is a confusion on setting max Rx packet length, this patch aims to clarify it. 'rte_eth_dev_configure()' API accepts max Rx packet size via 'uint32_t max_rx_pkt_len' field of the config struct 'struct rte_eth_conf'.

Re: [dpdk-dev] [PATCH] net/bnxt: fix clang compiler warnings

2021-10-11 Thread Ajit Khaparde
On Sat, Oct 9, 2021 at 9:07 PM Ajit Khaparde wrote: > > From: Shahaji Bhosle > > Fix an error reported during CLANG compilation. > > -Wtautological-constant-out-of-range-compare for enums > > $ export CC=clang > $ meson --werror --buildtype=debugoptimized build && ninja-build -C build > " > [..]

Re: [dpdk-dev] [dpdk-ci] [PATCH v6 0/3] eal: add memory pre-allocation from existing files

2021-10-11 Thread Lincoln Lavoie
Hi All, I'm assuming this should be added to the "checkpatch" job / report? Correct, or do folks feel this should be a separate run / report? Cheers, Lincoln On Mon, Oct 11, 2021 at 2:52 PM Thomas Monjalon wrote: > 11/10/2021 10:56, Dmitry Kozlyuk: > > v6: fix copyright line (Thomas), add SPDX

Re: [dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16 check

2021-10-11 Thread Chautru, Nicolas
> -Original Message- > From: Thomas Monjalon > Sent: Monday, October 11, 2021 1:17 PM > To: gak...@marvell.com; Chautru, Nicolas > Cc: dev@dpdk.org; t...@redhat.com; hemant.agra...@nxp.com; Zhang, > Mingshan > Subject: Re: [dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16 > ch

Re: [dpdk-dev] [PATCH v3 5/6] doc: clarification of usage of HARQ in bbdev doc

2021-10-11 Thread Chautru, Nicolas
> -Original Message- > From: Thomas Monjalon > Sent: Monday, October 11, 2021 1:29 PM > To: Chautru, Nicolas > Cc: dev@dpdk.org; gak...@marvell.com; hemant.agra...@nxp.com; Zhang, > Mingshan ; Joshi, Arun > ; Tom Rix > Subject: Re: [dpdk-dev] [PATCH v3 5/6] doc: clarification of usage

Re: [dpdk-dev] [PATCH v3 5/6] doc: clarification of usage of HARQ in bbdev doc

2021-10-11 Thread Thomas Monjalon
12/09/2021 14:44, Tom Rix: > On 9/7/21 6:15 PM, Nicolas Chautru wrote: > > New paragraph detailing typical VRAN usecase and mapping > > to bbdev API usage. > > > > Signed-off-by: Nicolas Chautru > > --- > > doc/guides/prog_guide/bbdev.rst | 23 +++ > > 1 file changed, 23 ins

Re: [dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16 check

2021-10-11 Thread Thomas Monjalon
13/08/2021 18:51, Nicolas Chautru: > Adding a missing operation when CRC16 > is being used for TB CRC check. > > Signed-off-by: Nicolas Chautru > --- > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -84,6 +84,7 @@ API Changes > Also, make sure

Re: [dpdk-dev] [PATCH v5 5/6] ethdev: unify MTU checks

2021-10-11 Thread Ferruh Yigit
On 10/9/2021 12:43 PM, lihuisong (C) wrote: Hi, Ferruh 在 2021/10/8 0:56, Ferruh Yigit 写道: Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but have slightly different checks. Like one checks min MTU against RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. Checks moved into commo

Re: [dpdk-dev] [RFC PATCH 2/2] ethdev: add capability to keep indirect actions on restart

2021-10-11 Thread Ori Kam
Hi Andrew and Ajit, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 11, 2021 4:58 PM > Subject: Re: [dpdk-dev] [RFC PATCH 2/2] ethdev: add capability to keep > indirect actions on restart > > On 10/7/21 11:16 AM, Dmitry Kozlyuk wrote: > >> -Original Message

Re: [dpdk-dev] [PATCH v5 5/6] ethdev: unify MTU checks

2021-10-11 Thread Ferruh Yigit
On 10/8/2021 5:51 PM, Ananyev, Konstantin wrote: Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but have slightly different checks. Like one checks min MTU against RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. Checks moved into common function to unify the checks. Also thi

Re: [dpdk-dev] [PATCH v5 1/6] ethdev: fix max Rx packet length

2021-10-11 Thread Ferruh Yigit
On 10/8/2021 4:57 PM, Ananyev, Konstantin wrote: There is a confusion on setting max Rx packet length, this patch aims to clarify it. 'rte_eth_dev_configure()' API accepts max Rx packet size via 'uint32_t max_rx_pkt_len' field of the config struct 'struct rte_eth_conf'. Also 'rte_eth_dev_set

Re: [dpdk-dev] Mmap query

2021-10-11 Thread Dmitry Kozlyuk
Hi Brijesh, 2021-10-11 10:25 (UTC-0700), Brijesh Singh: > Hi there, > We are seeing high mmap time for 1G hugepage during eal memalloc init. Most > time is spent for clearing page, each 4k size.. > It's not clear to me why clear huge pages is called? The code mmaps rte_map > file with map_populate

Re: [dpdk-dev] [PATCH] doc/windows_gsg: update section on driver installation

2021-10-11 Thread Thomas Monjalon
08/10/2021 23:11, Dmitry Kozlyuk: > Windows GSG included a section only on virt2phys driver installation, > but not on NetUIO. The content of the section duplicated documentation > in dpdk-kmods, but contained no links to it, only a reference. > > Add subsections for virt2phys and NetUIO, explaini

Re: [dpdk-dev] [PATCH v4 0/6] ethdev: introduce shared Rx queue

2021-10-11 Thread Xueming(Steven) Li
On Mon, 2021-10-11 at 14:49 +0300, Andrew Rybchenko wrote: > Hi Xueming, > > On 9/30/21 5:55 PM, Xueming Li wrote: > > In current DPDK framework, all RX queues is pre-loaded with mbufs for > > incoming packets. When number of representors scale out in a switch > > domain, the memory consumption be

Re: [dpdk-dev] [PATCH 0/2] buildtools: enable chkincs on Windows

2021-10-11 Thread Thomas Monjalon
01/10/2021 18:37, Dmitry Kozlyuk: > Dmitry Kozlyuk (2): > eal/windows: do not install virt2phys header > buildtools: enable chkincs on Windows Applied, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] eal/windows: do not install virt2phys header

2021-10-11 Thread Thomas Monjalon
01/10/2021 18:37, Dmitry Kozlyuk: > The header was not intended to be a public one. > DPDK users should use `rte_mem_virt2iova()` to translate addresses. > Other virt2phys users should use the header from the driver instead. > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management"

Re: [dpdk-dev] [PATCH] MAINTAINERS: update entry for compressdev

2021-10-11 Thread Thomas Monjalon
06/10/2021 18:25, Fiona Trahe: > Replacing myself with Fan as compressdev API maintainer. > > Signed-off-by: Fiona Trahe Fan, do you ack?

[dpdk-dev] [PATCH v1] doc: fix typo of Intel device name

2021-10-11 Thread William Tu
The device name should be 82574L Gigabit Ethernet Controller. Signed-off-by: William Tu Cc: Haiyue Wang --- doc/guides/nics/e1000em.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/e1000em.rst b/doc/guides/nics/e1000em.rst index 041c9a09a3a5..b9249b62f3d6

Re: [dpdk-dev] [PATCH v6 0/3] eal: add memory pre-allocation from existing files

2021-10-11 Thread Thomas Monjalon
11/10/2021 10:56, Dmitry Kozlyuk: > v6: fix copyright line (Thomas), add SPDX header for the new test file > (BTW, why didn't the CI complain in previous versions?) Probably because the CI doesn't run the script devtools/check-spdx-tag.sh Cc c...@dpdk.org to add this test.

[dpdk-dev] [kmods PATCH v1] windows/netuio: add Intel e1000 device IDs

2021-10-11 Thread William Tu
Add Intel Ethernet e1000 device IDs to netuio inf file. Signed-off-by: William Tu -- DPDK patch at: http://inbox.dpdk.org/dev/20211007202451.90271-1-u9012...@gmail.com/T/#t --- windows/netuio/netuio.inf | 4 1 file changed, 4 insertions(+) diff --git a/windows/netuio/netuio.inf b/windows/n

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] eal/windows: ensure all enabled CPUs are counted

2021-10-11 Thread Thomas Monjalon
18/08/2021 15:46, Narcisa Ana Maria Vasile: > From: Narcisa Vasile > > On Windows, -l/--lcores EAL option was unable to process CPU sets > containing CPUs other than 0 and 1, because CPU_COUNT() macro > only checked these CPUs in the set. Fix CPU_COUNT() by enumerating > all possible CPU indices.

[dpdk-dev] [PATCH] update MAINTAINERs for mrvl PMDs

2021-10-11 Thread lironh
From: Liron Himi update MRVL PMDs, Tomasz is no longer with semihalf Signed-off-by: Liron Himi --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index bc98b9167..339309089 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -704,7 +704,6 @@ F: doc/guides/

[dpdk-dev] [PATCH] maintainers: update for oxteontx2 regex

2021-10-11 Thread lironh
From: Liron Himi Removing Guy Kaneti Adding Liron Himi Signed-off-by: Liron Himi --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 278e5b3226..7209a3137d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1197,7 +1197,7 @@ RegEx Dri

Re: [dpdk-dev] [PATCH v2 0/5] cryptodev: hide internal structures

2021-10-11 Thread Zhang, Roy Fan
Hi Kai and Akhil, Thanks Kai for finding the problem. To resolve the seg fault for multi-process and keep the structure private, Instead of creating the fp_ops we may ditch making rte_cryptodev_enqueue_burst() and rte_cryptodev_dequeue_burst() inline, and keep everything else as it was? To me

[dpdk-dev] Mmap query

2021-10-11 Thread Brijesh Singh
Hi there, We are seeing high mmap time for 1G hugepage during eal memalloc init. Most time is spent for clearing page, each 4k size.. It's not clear to me why clear huge pages is called? The code mmaps rte_map file with map_populate and map_shared this shouldn't cause page zeroing. I am curious to

Re: [dpdk-dev] [PATCH v5 4/7] ethdev: copy fast-path API into separate structure

2021-10-11 Thread Andrew Rybchenko
On 10/11/21 7:52 PM, Ananyev, Konstantin wrote: On 10/7/21 2:27 PM, Konstantin Ananyev wrote: Copy public function pointers (rx_pkt_burst(), etc.) and related pointers to internal data from rte_eth_dev structure into a separate flat array. That array will remain in a public header. The intent

Re: [dpdk-dev] [dpdk-ci] RHEL7 failures

2021-10-11 Thread Brandon Lo
Hi Thinh, I have started a rerun of the patch https://patches.dpdk.org/patch/100042 (patchset https://lab.dpdk.org/results/dashboard/patchsets/19066/). You should see the new results reported over email soon. Thanks, Brandon On Mon, Oct 11, 2021 at 12:39 PM Thinh Tran wrote: > > Hi Linconln, >

Re: [dpdk-dev] [PATCH v5 2/7] ethdev: allocate max space for internal queue array

2021-10-11 Thread Andrew Rybchenko
On 10/11/21 7:25 PM, Ananyev, Konstantin wrote: At queue configure stage always allocate space for maximum possible number (RTE_MAX_QUEUES_PER_PORT) of queue pointers. That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer pointer to internal queue data without extra checking of

Re: [dpdk-dev] [PATCH v4 1/6] ethdev: introduce shared Rx queue

2021-10-11 Thread Xueming(Steven) Li
On Mon, 2021-10-11 at 13:47 +0300, Andrew Rybchenko wrote: > On 9/30/21 5:55 PM, Xueming Li wrote: > > In current DPDK framework, each RX queue is pre-loaded with mbufs for > > RX -> Rx > > > incoming packets. When number of representors scale out in a switch > > domain, the memory consumption be

Re: [dpdk-dev] [PATCH v2 0/5] cryptodev: hide internal structures

2021-10-11 Thread Ji, Kai
Hi Akhil, Just ran a quick mutli process test against the patch set, unfortunately it failed on the secondary process enqueue or dequeue. USER1: Configuring vector 0, using session 0 USER1: Start enqueuing packets on dev 0 qp 0 USER1: Start dequeuing packets on dev 0 qp 0 USER1: Enqueuing - Dequ

Re: [dpdk-dev] [PATCH v5 7/7] ethdev: hide eth dev related structures

2021-10-11 Thread Andrew Rybchenko
On 10/11/21 6:54 PM, Ananyev, Konstantin wrote: On 10/7/21 2:27 PM, Konstantin Ananyev wrote: Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related data into private header (ethdev_driver.h). Few minor changes to keep DPDK building after that. Signed-off-by: Konstantin Anany

Re: [dpdk-dev] [PATCH v5 5/7] ethdev: make fast-path functions to use new flat array

2021-10-11 Thread Andrew Rybchenko
On 10/11/21 6:47 PM, Ananyev, Konstantin wrote: On 10/7/21 2:27 PM, Konstantin Ananyev wrote: Rework fast-path ethdev functions to use rte_eth_fp_ops[]. While it is an API/ABI breakage, this change is intended to be transparent for both users (no changes in user app is required) and PMD devel

Re: [dpdk-dev] [EXT] Re: [PATCH v2 3/3] security: add reserved bitfields

2021-10-11 Thread Akhil Goyal
> 08/10/2021 22:45, Akhil Goyal: > > In struct rte_security_ipsec_sa_options, for every new option > > added, there is an ABI breakage, to avoid, a reserved_opts > > bitfield is added to for the remaining bits available in the > > structure. > > Now for every new sa option, these reserved_opts can

Re: [dpdk-dev] [PATCH v5 4/7] ethdev: copy fast-path API into separate structure

2021-10-11 Thread Ananyev, Konstantin
> On 10/7/21 2:27 PM, Konstantin Ananyev wrote: > > Copy public function pointers (rx_pkt_burst(), etc.) and related > > pointers to internal data from rte_eth_dev structure into a > > separate flat array. That array will remain in a public header. > > The intention here is to make rte_eth_dev an

  1   2   3   4   >