[dpdk-dev] [v9 4/4] net/cnxk: add telemetry endpoints to ethdev

2021-09-28 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to ethdev. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/net/cnxk/cnxk_ethdev_telemetry.c | 93 drivers/net/cnxk/meson.build | 1 + 2 files changed, 94 insertions(+) create mode 100644 drivers/net/cnxk/cnxk_ethdev_telemetry.c

[dpdk-dev] [v9 3/4] mempool/cnxk: add telemetry endpoints mempool

2021-09-28 Thread Gowrishankar Muthukrishnan
Adding telemetry endpoints to cnxk mempool driver. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/mempool/cnxk/cnxk_mempool_telemetry.c | 57 +++ drivers/mempool/cnxk/meson.build | 1 + 2 files changed, 58 insertions(+) create mode 100644 drivers/mempool/cnx

[dpdk-dev] [v9 2/4] common/cnxk: add telemetry endpoints to nix

2021-09-28 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to nix. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry_nix.c | 849 +++ drivers/common/cnxk/meson.build | 3 +- drivers/common/cnxk/roc_nix.c| 3 + drivers/common/cnxk/roc_nix_priv.h |

[dpdk-dev] [v9 1/4] common/cnxk: add telemetry endpoints to npa

2021-09-28 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to npa. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry.h | 26 +++ drivers/common/cnxk/cnxk_telemetry_npa.c | 224 +++ drivers/common/cnxk/meson.build | 6 +- drivers/common/cnxk/roc_platform.h |

[dpdk-dev] [v9 0/4] cnxk: enable telemetry endpoints

2021-09-28 Thread Gowrishankar Muthukrishnan
This patch series enables telemetry in cnxk for the following: - NPA LF - NIX LF - Mempool driver - Ethdev driver Depends-on: series-18612 ("net/cnxk: support for inline ipsec") Depends-on: patch-19248 ("ethdev: add telemetry endpoint for device info") Depends-on: patch-19251 ("mempool: add te

Re: [dpdk-dev] [PATCH v3 5/5] examples/l3fwd-power: support virtio/vhost

2021-09-28 Thread Xia, Chenbo
> -Original Message- > From: Li, Miao > Sent: Friday, September 24, 2021 6:23 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Li, Miao > > Subject: [PATCH v3 5/5] examples/l3fwd-power: support virtio/vhost > > In l3fwd-power, there is default port configuration whic

[dpdk-dev] [v1] cryptodev: add telemetry endpoint for cryptodev info

2021-09-28 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint for cryptodev info. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: patch-18355 ("cryptodev: add telemetry callbacks") Depends-on: patch-19247 ("telemetry: fix json output buffer size") --- lib/cryptodev/rte_cryptodev.c | 68 +++ 1

[dpdk-dev] [v1] mempool: add telemetry endpoint for mempool info

2021-09-28 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint for mempool info. Signed-off-by: Gowrishankar Muthukrishnan --- lib/mempool/rte_mempool.c | 84 +++ 1 file changed, 84 insertions(+) diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index 59a588425b..b8dad2997a 100644

Re: [dpdk-dev] [PATCH v2] drivers/net: remove queue xstats auto-fill flag

2021-09-28 Thread Andrew Rybchenko
On 9/28/21 8:10 PM, Stephen Hemminger wrote: > On Tue, 28 Sep 2021 19:48:54 +0300 > Andrew Rybchenko wrote: > >> Some drivers do not provide per-queue statistics. So, there is no point >> to have these misleading zeros in xstats. >> >> Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-f

Re: [dpdk-dev] [PATCH] eal: detach interrupt and worker threads

2021-09-28 Thread David Marchand
On Thu, Aug 19, 2021 at 4:41 AM Stephen Hemminger wrote: > > The EAL library does not wait (pthread_join) these threads > so the should be detached so that library can release resources. > This shows up when looking for memory leaks with tools like > valgrind. The FreeBSD interrupt thread can be

Re: [dpdk-dev] [PATCH v6 2/2] vhost: enable IOMMU for async vhost

2021-09-28 Thread Hu, Jiayu
Hi Xuan, > -Original Message- > From: Ding, Xuan > Sent: Wednesday, September 29, 2021 10:41 AM > To: dev@dpdk.org; Burakov, Anatoly ; > maxime.coque...@redhat.com; Xia, Chenbo > Cc: Hu, Jiayu ; Jiang, Cheng1 ; > Richardson, Bruce ; Pai G, Sunil > ; Wang, Yinan ; Yang, > YvonneX ; Ding,

Re: [dpdk-dev] [PATCH v3] eventdev: add Rx timestamp in mbuf using mbuf dynamic field

2021-09-28 Thread Jerin Jacob
On Tue, Sep 28, 2021 at 10:09 PM Ganapati Kundapura wrote: > > Add support to register timestamp dynamic field in mbuf. > > Update the timestamp in mbuf for each packet before enqueuing > to event device if the timestamp is not already set. > > Adding the timestamp in Rx adapter avoids additional

Re: [dpdk-dev] [PATCH v1 1/7] eal: promote IPC API's to stable

2021-09-28 Thread David Marchand
On Fri, Sep 10, 2021 at 5:51 PM Kinsella, Ray wrote: > On 10/09/2021 13:30, Anatoly Burakov wrote: > > As per ABI policy, move the formerly experimental API's to the stable > > section. > > > > Signed-off-by: Anatoly Burakov > Acked-by: Ray Kinsella Series applied. For the record, I sorted the

Re: [dpdk-dev] [PATCH v3 1/5] eventdev/rx_adapter: add event buffer size configurability

2021-09-28 Thread Jerin Jacob
On Wed, Sep 22, 2021 at 8:44 PM Naga Harish K S V wrote: > > Currently event buffer is static array with a default size defined > internally. > > To configure event buffer size from application, > ``rte_event_eth_rx_adapter_create_with_params`` api is added which > takes ``struct rte_event_eth_rx_

Re: [dpdk-dev] [EXT] [PATCH] cryptodev: add telemetry callbacks

2021-09-28 Thread Gowrishankar Muthukrishnan
> An example usage can be seen below: > > Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > {"version": "DPDK 21.11.0-rc0", "pid": 1135019, "max_output_len": 16384} > --> / > {"/": ["/", "/cryptodev/list", "/cryptodev/stats", ...]} > --> /cryptodev/list > {"/cryptodev/list": {":1a:01.0_qat_s

Re: [dpdk-dev] [PATCH] crypto/octeontx2: fix lookaside IPsec capabilities

2021-09-28 Thread Anoob Joseph
> > Adding cbc, sha1-hmac and sha256-hmac to lookaside IPsec capabilities. > > Fixes: 8f685ec2d545 ("crypto/octeontx2: support AES-CBC SHA1-HMAC") > Fixes: 61baeec4682c ("crypto/octeontx2: support AES-CBC SHA256-128- > HMAC") > > Signed-off-by: Tejasree Kondoj Acked-by: Anoob Joseph Cc: sta

Re: [dpdk-dev] [PATCH] crypto/octeontx2: update min headroom and tailroom

2021-09-28 Thread Anoob Joseph
> > The driver consume 208B of tailroom but has min requirement as 8B and > headroom needed is 48B, but minimum requirement is set as 24B. This patch > correct minimum requirements which application should honour. > > Signed-off-by: Akhil Goyal Acked-by: Anoob Joseph

[dpdk-dev] [PATCH v2] net/iavf: fix QFI field bit check for GTPU EH

2021-09-28 Thread Junfeng Guo
If GTPU Extionsion header has no pdu_type setting, the parsed value of gtp_psc_spec->pdu_type will be 0, which is same as IAVF_GTPU_EH_DWLINK. Thus, for this case, we should check gtp_psc_mask->pdu_type instead, to set QFI field bit of GTPU_EH first. Fixes: 45cc3a5435fc ("net/iavf: fix QFI fields

[dpdk-dev] [v1] ethdev: add telemetry endpoint for device info

2021-09-28 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint /ethdev/info for device info. Signed-off-by: Gowrishankar Muthukrishnan Change-Id: I3e6ee2bd1a80675473adf0bd884b194f98e28536 --- lib/ethdev/rte_ethdev.c | 92 + 1 file changed, 92 insertions(+) diff --git a/lib/ethdev/rte_ethdev.c b

[dpdk-dev] [v5] telemetry: fix json output buffer size

2021-09-28 Thread Gowrishankar Muthukrishnan
Fix json output buffer size for an actual data length. Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON") Signed-off-by: Gowrishankar Muthukrishnan --- lib/telemetry/telemetry_json.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/telemetry/t

[dpdk-dev] [PATCH] net/iavf: fix QFI field bit check for GTPU EH

2021-09-28 Thread Junfeng Guo
If GTPU Extionsion header has no pdu_type setting, the parsed value of gtp_psc_spec->pdu_type will be 0, which is same as IAVF_GTPU_EH_DWLINK. Thus, fot this case, we should check gtp_psc_mask->pdu_type instead, to set QFI field bit of GTPU_EH first. Fixes: 45cc3a5435fc ("net/iavf: fix QFI fields

[dpdk-dev] [PATCH v5] net/mlx5: fix mutex unlock in txpp cleanup

2021-09-28 Thread Chengfeng Ye
The lock sh->txpp.mutex was not correctly released on one path of cleanup function return, potentially causing the deadlock. Fixes: d133f4cdb7 ("net/mlx5: create clock queue for packet pacing") Cc: sta...@dpdk.org Signed-off-by: Chengfeng Ye --- drivers/net/mlx5/mlx5_txpp.c | 6 +- 1 file c

Re: [dpdk-dev] [PATCH v3 4/5] power: modify return of queue_stopped

2021-09-28 Thread Xia, Chenbo
> -Original Message- > From: Li, Miao > Sent: Friday, September 24, 2021 6:23 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Li, Miao > > Subject: [PATCH v3 4/5] power: modify return of queue_stopped > > Since some vdevs like virtio and vhost do not support rxq_inf

Re: [dpdk-dev] [PATCH v3 2/5] vhost: implement rte_power_monitor API

2021-09-28 Thread Xia, Chenbo
Hi Miao, > -Original Message- > From: Li, Miao > Sent: Friday, September 24, 2021 6:23 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Li, Miao > > Subject: [PATCH v3 2/5] vhost: implement rte_power_monitor API > > This patch defines rte_vhost_power_monitor_cond wh

[dpdk-dev] [PATCH v6 2/2] vhost: enable IOMMU for async vhost

2021-09-28 Thread Xuan Ding
The use of IOMMU has many advantages, such as isolation and address translation. This patch extends the capbility of DMA engine to use IOMMU if the DMA engine is bound to vfio. When set memory table, the guest memory will be mapped into the default container of DPDK. Signed-off-by: Xuan Ding ---

[dpdk-dev] [PATCH v6 1/2] vfio: allow partially unmapping adjacent memory

2021-09-28 Thread Xuan Ding
Currently, if we map a memory area A, then map a separate memory area B that by coincidence happens to be adjacent to A, current implementation will merge these two segments into one, and if partial unmapping is not supported, these segments will then be only allowed to be unmapped in one go. In ot

[dpdk-dev] [PATCH v6 0/2] support IOMMU for DMA device

2021-09-28 Thread Xuan Ding
This series supports DMA device to use vfio in async vhost. The first patch extends the capability of current vfio dma mapping API to allow partial unmapping for adjacent memory if the platform does not support partial unmapping. The second patch involves the IOMMU programming for guest memory in

Re: [dpdk-dev] [PATCH v3 1/5] net/virtio: implement rte_power_monitor API

2021-09-28 Thread Xia, Chenbo
> -Original Message- > From: Li, Miao > Sent: Friday, September 24, 2021 6:23 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Li, Miao > > Subject: [PATCH v3 1/5] net/virtio: implement rte_power_monitor API > > This patch implements rte_power_monitor API in virtio P

[dpdk-dev] [PATCH v2 3/3] test/crypto: add UDP encapsulation ports verification tests

2021-09-28 Thread Tejasree Kondoj
Adding UDP encapsulation ports verification test cases. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 17 + app/test/test_cryptodev_security_ipsec.c | 11 +++ app/test/test_cryptodev_security_ipsec.h | 1 + 3 files changed, 29 insertions(+

[dpdk-dev] [PATCH v2 2/3] common/cnxk: add support for UDP ports verification

2021-09-28 Thread Tejasree Kondoj
Adding support to verify UDP encapsulation ports in IPsec inbound. Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/cnxk_security.c | 3 +++ drivers/common/cnxk/roc_ie_ot.h | 4 ++-- drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + 3 files changed, 6

[dpdk-dev] [PATCH v2 1/3] security: add option to configure UDP ports verification

2021-09-28 Thread Tejasree Kondoj
Add option to indicate whether UDP encapsulation ports verification need to be done as part of inbound IPsec processing. Signed-off-by: Tejasree Kondoj Acked-by: Hemant Agrawal Acked-by: Akhil Goyal --- doc/guides/rel_notes/release_21_11.rst | 4 lib/security/rte_security.h| 7

[dpdk-dev] [PATCH v2 0/3] add option to configure UDP ports verification

2021-09-28 Thread Tejasree Kondoj
Add option to indicate whether UDP encapsulation ports verification need to be done as part of inbound IPsec processing. CNXK PMD support and unit tests are also added for the same. Depends on https://patches.dpdk.org/project/dpdk/list/?series=18755 v2: * Fixed release notes * Moved newly added s

Re: [dpdk-dev] [PATCH v8] ethdev: add IPv4 and L4 checksum RSS offload types

2021-09-28 Thread Zhang, AlvinX
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, September 28, 2021 9:09 PM > To: Zhang, AlvinX ; Zhang, Qi Z > > Cc: dev@dpdk.org; Ajit Khaparde ; Singh, > Aman Deep ; Thomas Monjalon > > Subject: Re: [PATCH v8] ethdev: add IPv4 and L4 checksum RSS offload types > > On 9/15/

Re: [dpdk-dev] [PATCH v2] net/i40e: fix Rx packet statistics

2021-09-28 Thread Zhang, AlvinX
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, September 28, 2021 7:17 PM > To: Zhang, AlvinX ; Xing, Beilei > ; Guo, Junfeng ; > ktray...@redhat.com > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix Rx packet statistics > >

Re: [dpdk-dev] [PATCH v4 06/13] net/bnxt: add support for tunnel offload API

2021-09-28 Thread Ajit Khaparde
On Tue, Sep 28, 2021 at 5:43 AM Ferruh Yigit wrote: > > On 9/20/2021 8:42 AM, Venkat Duvvuru wrote: > > From: Kishore Padmanabha > > > > Add support for tunnel offload APIs. Specifically the following > > are supported. > > tunnel_decap_set, tunnel_match, tunnel_action_decap_release, > > tunnel_i

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-28 Thread Ananyev, Konstantin
> > > > > > > > > > > > > > In current DPDK framework, each RX queue is > > > > > > > > > > > > > > pre-loaded with mbufs > > > > > > > > > > > > > > for incoming packets. When number of > > > > > > > > > > > > > > representors scale out in a > > > > > > > > > > > > > > switch domain, the memory c

Re: [dpdk-dev] [PATCH v6 06/10] ipsec: add transmit segmentation offload support

2021-09-28 Thread Ananyev, Konstantin
> On 9/23/2021 3:09 PM, Ananyev, Konstantin wrote: > > > >> Add support for transmit segmentation offload to inline crypto processing > >> mode. This offload is not supported by other offload modes, as at a > >> minimum it requires inline crypto for IPsec to be supported on the > >> network interf

[dpdk-dev] [PATCH v2, 20.11] net/i40e: fix i40evf device initialization

2021-09-28 Thread Ben Magistro
The i40evf driver is not initializing the eth_dev attribute which can result in a nullptr dereference. Changes were modeled after the iavf_dev_init() per suggestion from the mailing list[1]. [1] https://mails.dpdk.org/archives/dev/2021-August/217251.html Cc: sta...@dpdk.org Signed-off-by: Ben Ma

[dpdk-dev] [PATCH v2 2/2] cmdline: make struct rdline opaque

2021-09-28 Thread Dmitry Kozlyuk
Hide struct rdline definition and some RDLINE_* constants in order to be able to change internal buffer sizes transparently to the user. Add new functions: * rdline_create(): allocate and initialize struct rdline. This function replaces rdline_init() and takes an extra parameter: opaque user d

[dpdk-dev] [PATCH v2 1/2] cmdline: make struct cmdline opaque

2021-09-28 Thread Dmitry Kozlyuk
Remove the definition of `struct cmdline` from public header. Deprecation notice: https://mails.dpdk.org/archives/dev/2020-September/183310.html Signed-off-by: Dmitry Kozlyuk Acked-by: David Marchand Acked-by: Olivier Matz --- doc/guides/rel_notes/deprecation.rst | 4 doc/guides/rel_no

[dpdk-dev] [PATCH v2 0/2] cmdline: reduce ABI

2021-09-28 Thread Dmitry Kozlyuk
Hide struct cmdline following the deprecation notice. Hide struct rdline following the v1 discussion. Dmitry Kozlyuk (2): cmdline: make struct cmdline opaque cmdline: make struct rdline opaque app/test-cmdline/commands.c| 2 +- app/test/test_cmdline_lib.c| 19 +++---

Re: [dpdk-dev] [PATCH] eal: promote rte_mcfg_get_single_file_segment to stable ABI

2021-09-28 Thread David Marchand
Hello Jakub, On Mon, Sep 13, 2021 at 10:44 AM Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco) wrote: > > Signed-off-by: Jakub Grajciar jgraj...@cisco.com Anatoly already sent a patch for this symbol: https://patchwork.dpdk.org/project/dpdk/patch/37d174136f8f8

Re: [dpdk-dev] [PATCH] vhost: rework RARP packet injection

2021-09-28 Thread Maxime Coquelin
On 9/28/21 17:32, Maxime Coquelin wrote: On 9/15/21 16:54, David Marchand wrote: Caught by code review, this copy is unnecessary. Signed-off-by: David Marchand ---   lib/vhost/virtio_net.c | 11 +++   1 file changed, 3 insertions(+), 8 deletions(-) Applied to dpdk-next-virtio/ma

[dpdk-dev] Recent change to make rte_cryptodev_pmd.h internal prevents some important functionality

2021-09-28 Thread Luse, Paul E
Hi Everyone, We use cryptodev in SPDK and included rte_cryptodev_pmd.h so that we may release qpair memory that was allocated when we called rte_cryptodev_queue_pair_setup(). We’d do so by calling the function pointer queue_pair_release() which I believe is the prescribed way to do this. The

Re: [dpdk-dev] [PATCH v2] drivers/net: remove queue xstats auto-fill flag

2021-09-28 Thread Stephen Hemminger
On Tue, 28 Sep 2021 19:48:54 +0300 Andrew Rybchenko wrote: > Some drivers do not provide per-queue statistics. So, there is no point > to have these misleading zeros in xstats. > > Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue > xstats") > Cc: sta...@dpdk.org > > Si

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-09-28 Thread Andrew Rybchenko
On 9/28/21 7:50 PM, Ferruh Yigit wrote: > On 9/28/2021 1:05 PM, Andrew Rybchenko wrote: >> From: Ivan Ilchenko >> >> Update xstats by IDs callbacks documentation in accordance with >> ethdev usage of these callbacks. Document valid combinations of >> input arguments to make driver implementation s

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-09-28 Thread Ferruh Yigit
On 9/28/2021 1:05 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Update xstats by IDs callbacks documentation in accordance with > ethdev usage of these callbacks. Document valid combinations of > input arguments to make driver implementation simpler. > > Fixes: 79c913a42f0 ("ethdev: retr

[dpdk-dev] [PATCH v2] drivers/net: remove queue xstats auto-fill flag

2021-09-28 Thread Andrew Rybchenko
Some drivers do not provide per-queue statistics. So, there is no point to have these misleading zeros in xstats. Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/bnx2x/bnx2x_ethdev.c |

[dpdk-dev] [PATCH v3] eventdev: add Rx timestamp in mbuf using mbuf dynamic field

2021-09-28 Thread Ganapati Kundapura
Add support to register timestamp dynamic field in mbuf. Update the timestamp in mbuf for each packet before enqueuing to event device if the timestamp is not already set. Adding the timestamp in Rx adapter avoids additional latency due to the event device. Acked-by: Jerin Jacob Signed-off-by:

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: fix docs of functions getting xstats by IDs

2021-09-28 Thread Ferruh Yigit
On 9/28/2021 1:05 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Document valid combinations of input arguments in accordance with > current implementation in ethdev. > > Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") > Cc: sta...@dpdk.org > > Signed-off-by: Ivan Ilchenko > Signed

Re: [dpdk-dev] [EXT] [PATCH v2 0/9] drivers/crypto: introduce ipsec_mb framework

2021-09-28 Thread Akhil Goyal
> This set of patches introduces a new framework, making all common code of > SW crypto PMD implementations built on top of intel-ipsec-mb library > sharable. This helps to reduce future effort on the code maintenance and > future updates. It also moves all SW PMD implementation specific details >

Re: [dpdk-dev] [PATCH 1/3] security: add SA config option for inner pkt csum

2021-09-28 Thread Akhil Goyal
> Add inner packet IPv4 hdr and L4 checksum enable options > in conf. These will be used in case of protocol offload. > Per SA, application could specify whether the > checksum(compute/verify) can be offloaded to security device. > > Signed-off-by: Archana Muniganti > --- > doc/guides/rel_notes/

[dpdk-dev] [PATCH v3 1/8] examples/ioat: always use same lcore for both DMA requests enqueue and dequeue

2021-09-28 Thread Kevin Laatz
From: Konstantin Ananyev Few changes in ioat sample behaviour: - Always do SW copy for packet metadata (mbuf fields) - Always use same lcore for both DMA requests enqueue and dequeue Main reasons for that: a) it is safer, as idxd PMD doesn't support MT safe enqueue/dequeue (yet). b) sort of more

[dpdk-dev] [PATCH v3 0/8] port ioatfwd app to dmadev

2021-09-28 Thread Kevin Laatz
This patchset first adds some additional command line options to the existing ioatfwd application to enhance usability. The last 3 patches of this set then port the ioatfwd application to use the dmadev library APIs instead of the IOAT rawdev APIs. Following the port, all variables etc are renamed

[dpdk-dev] [PATCH v3 8/8] examples/ioat: rename application to dmafwd

2021-09-28 Thread Kevin Laatz
Since the APIs have been updated from rawdev to dmadev, the application should also be renamed to match. This patch also includes the documentation updates for the renaming. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v3: fix api names after prefix renaming --- .../sample_app_ug/{i

[dpdk-dev] [PATCH v3 7/8] examples/ioat: update naming to match change to dmadev

2021-09-28 Thread Kevin Laatz
Existing functions, structures, defines etc need to be updated to reflect the change to using the dmadev APIs. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- examples/ioat/ioatfwd.c | 189 1 file changed, 94 insertions(+), 95 deletions(-) diff

[dpdk-dev] [PATCH v3 6/8] examples/ioat: port application to dmadev APIs

2021-09-28 Thread Kevin Laatz
The dmadev library abstraction allows applications to use the same APIs for all DMA device drivers in DPDK. This patch updates the ioatfwd application to make use of the new dmadev APIs, in turn making it a generic application which can be used with any of the DMA device drivers. Signed-off-by: Ke

[dpdk-dev] [PATCH v3 5/8] examples/ioat: add signal-triggered device dumps

2021-09-28 Thread Kevin Laatz
Enable dumping device info via the signal handler. With this change, when a SIGUSR1 is issued, the application will print a dump of all devices being used by the application. Signed-off-by: Kevin Laatz --- examples/ioat/ioatfwd.c | 17 + 1 file changed, 17 insertions(+) diff --g

[dpdk-dev] [PATCH v3 4/8] examples/ioat: add cmd line option to control stats print interval

2021-09-28 Thread Kevin Laatz
Add a command line option to control the interval between stats prints. Signed-off-by: Kevin Laatz --- doc/guides/sample_app_ug/ioat.rst | 4 +++- examples/ioat/ioatfwd.c | 31 +++ 2 files changed, 26 insertions(+), 9 deletions(-) diff --git a/doc/guides/s

[dpdk-dev] [PATCH v3 3/8] examples/ioat: add cmd line option to control max frame size

2021-09-28 Thread Kevin Laatz
From: Konstantin Ananyev Add command line option for setting the max frame size. Signed-off-by: Konstantin Ananyev Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/sample_app_ug/ioat.rst | 4 +++- examples/ioat/ioatfwd.c | 25 +++-- 2 files ch

[dpdk-dev] [PATCH v3 2/8] examples/ioat: add cmd line option to control DMA batch size

2021-09-28 Thread Kevin Laatz
From: Konstantin Ananyev Add a commandline options to control the HW copy batch size in the application. Signed-off-by: Konstantin Ananyev Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/sample_app_ug/ioat.rst | 4 +++- examples/ioat/ioatfwd.c | 40 +

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-09-28 Thread Andrew Rybchenko
On 9/28/21 6:58 PM, Stephen Hemminger wrote: > On Tue, 28 Sep 2021 18:23:00 +0300 > Andrew Rybchenko wrote: > >> @@ -2498,24 +2498,11 @@ struct rte_flow_query_age { >> * Counters can be retrieved and reset through ``rte_flow_query()``, see >> * ``struct rte_flow_query_count``. >> * >> - * @

[dpdk-dev] [PATCH V4 3/5] common/mlx5: add MMO configuration for the DevX QP

2021-09-28 Thread Raja Zidane
A new configuration MMO was added to QP Context. If set, MMO WQEs are supported on this QP. For DMA MMO, supported only when dma_mmo_qp==1. For REGEXP MMO, supported only when regexp_mmo_qp==1. For COMPRESS MMO, supported only when compress_mmo_qp==1. For DECOMPRESS MMO, supported only when decompr

[dpdk-dev] [PATCH V4 5/5] regex/mlx5: refactor HW queue objects

2021-09-28 Thread Raja Zidane
The mlx5 PMD for regex class uses an MMO WQE operated by the GGA engine in BF devices. Currently, all the MMO WQEs are managed by the SQ object. Starting from BF3, the queue of the MMO WQEs should be connected to the GGA engine using a new configuration, MMO, that will be supported only in the QP o

[dpdk-dev] [PATCH V4 2/5] common/mlx5: update new MMO HCA capabilities

2021-09-28 Thread Raja Zidane
New MMO HCA capabilities were added and others were renamed. Align hca capabilities with new prm. Add support in devx interface for changes in HCA capabilities. Signed-off-by: Raja Zidane Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 15 --- drivers/common/mlx5/m

[dpdk-dev] [PATCH V4 4/5] compress/mlx5: refactor queue HW object

2021-09-28 Thread Raja Zidane
The mlx5 PMD for compress class uses an MMO WQE operated by the GGA engine in BF devices. Currently, all the MMO WQEs are managed by the SQ object. Starting from BF3, the queue of the MMO WQEs should be connected to the GGA engine using a new configuration, MMO, that will be supported only in the Q

[dpdk-dev] [PATCH V4 1/5] common/mlx5: share DevX QP operations

2021-09-28 Thread Raja Zidane
Currently drivers using QP (vDPA, crypto and compress, regex soon) manage their memory, creation, modification and destruction of the QP, in almost identical code. Move QP memory management, creation and destruction to common. Add common function to change QP state to RTS. Add user_index attribute

[dpdk-dev] [PATCH V4 0/5] mlx5: replaced hardware queue object

2021-09-28 Thread Raja Zidane
The mlx5 PMDs for compress and regex classes use an MMO WQE operated by the GGA engine in BF devices. Currently, all the MMO WQEs are managed by the SQ object. Starting from BF3, the queue of the MMO WQEs should be connected to the GGA engine using a new configuration, mmo, that will be supported o

[dpdk-dev] [PATCH] ethdev: remove legacy mirroring API

2021-09-28 Thread Andrew Rybchenko
A more file grain flow API should be used instead of it. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 283 doc/guides/nics/features.rst| 11 - doc/guides/nics/features/default.ini| 1 - doc/guides/nics/features/i40e

Re: [dpdk-dev] [PATCH 1/3] security: add option to configure UDP ports verification

2021-09-28 Thread Akhil Goyal
> Add option to indicate whether UDP encapsulation ports > verification need to be done as part of inbound > IPsec processing. > > Signed-off-by: Tejasree Kondoj > --- > doc/guides/rel_notes/release_21_11.rst | 5 + > lib/security/rte_security.h| 7 +++ > 2 files changed, 12

[dpdk-dev] [PATCH v6 2/2] examples/vhost: use API to check inflight packets

2021-09-28 Thread Xuan Ding
In async data path, call rte_vhost_async_get_inflight_thread_unsafe() API to directly return the number of inflight packets instead of maintaining a local variable. Signed-off-by: Xuan Ding --- examples/vhost/main.c | 31 +-- examples/vhost/main.h | 1 - 2 files chan

[dpdk-dev] [PATCH v6 1/2] vhost: add unsafe API to check inflight packets

2021-09-28 Thread Xuan Ding
In async data path, when vring state changes or device is destroyed, it is necessary to know the number of inflight packets in DMA engine. This patch provides a thread unsafe API to return the number of inflight packets for a vhost queue without using any lock. Signed-off-by: Xuan Ding --- doc/g

[dpdk-dev] [PATCH v6 0/2] add unsafe API to get inflight packets

2021-09-28 Thread Xuan Ding
This patchset introduces an unsafe API to get the number of inflight packets in DMA engine in some situations. Like vring state changes or device is destroyed. Compared with rte_vhost_async_get_inflight(), this is a lock free version. v6: * Fixed an issue of infinite loop. v5: * Rebased to the la

Re: [dpdk-dev] [PATCH v2 1/3] security: add option to configure tunnel header verification

2021-09-28 Thread Akhil Goyal
> Add option to indicate whether outer header verification > need to be done as part of inbound IPsec processing. > > With inline IPsec processing, SA lookup would be happening > in the Rx path of rte_ethdev. When rte_flow is configured to > support more than one SA, SPI would be used to lookup

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-09-28 Thread Stephen Hemminger
On Tue, 28 Sep 2021 18:23:00 +0300 Andrew Rybchenko wrote: > @@ -2498,24 +2498,11 @@ struct rte_flow_query_age { > * Counters can be retrieved and reset through ``rte_flow_query()``, see > * ``struct rte_flow_query_count``. > * > - * @deprecated Shared attribute is deprecated, use generic >

Re: [dpdk-dev] [PATCH v4 06/13] net/bnxt: add support for tunnel offload API

2021-09-28 Thread Ferruh Yigit
On 9/28/2021 4:46 PM, Thomas Monjalon wrote: > 28/09/2021 14:43, Ferruh Yigit: >> On 9/20/2021 8:42 AM, Venkat Duvvuru wrote: >>> From: Kishore Padmanabha >>> >>> Add support for tunnel offload APIs. Specifically the following >>> are supported. >>> tunnel_decap_set, tunnel_match, tunnel_action_de

Re: [dpdk-dev] [PATCH v4] efd: change data type of parameter

2021-09-28 Thread David Christensen
On 9/28/21 6:58 AM, Pablo de Lara wrote: rte_efd_create() function was using uint8_t for a socket bitmask, for one of its parameters. This limits the maximum of NUMA sockets to be 8. Changing to to uint64_t increases it to 64, which should be more future-proof. Coverity issue: 366390 Fixes: 5

[dpdk-dev] [PATCH] ethdev: remove legacy Rx descriptor done API

2021-09-28 Thread Andrew Rybchenko
rte_eth_rx_descriptor_status() should be used as a replacement. Signed-off-by: Andrew Rybchenko --- doc/guides/nics/features.rst| 6 +- doc/guides/rel_notes/deprecation.rst| 5 - doc/guides/rel_notes/release_21_11.rst | 4 drivers/net/e1000/e1000_ethdev.h

Re: [dpdk-dev] [PATCH v2] eventdev: update rx timestamp in mbuf using mbuf dynamic field

2021-09-28 Thread Kundapura, Ganapati
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: 28 September 2021 19:55 > To: Kundapura, Ganapati > Cc: Jayatheerthan, Jay ; dpdk-dev > ; Yigit, Ferruh > Subject: Re: [PATCH v2] eventdev: update rx timestamp in mbuf using mbuf > dynamic field > > On Thu, Sep 16, 2021 at 2:45

Re: [dpdk-dev] [PATCH v1 2/7] eal/interrupts: implement get set APIs

2021-09-28 Thread David Marchand
On Fri, Sep 3, 2021 at 2:42 PM Harman Kalra wrote: > > Implementing get set APIs for interrupt handle fields. > To make any change to the interrupt handle fields, one > should make use of these APIs. Some global comments. - Please merge API prototype (from patch 1) and actual implementation in a

Re: [dpdk-dev] [PATCH v4 06/13] net/bnxt: add support for tunnel offload API

2021-09-28 Thread Thomas Monjalon
28/09/2021 14:43, Ferruh Yigit: > On 9/20/2021 8:42 AM, Venkat Duvvuru wrote: > > From: Kishore Padmanabha > > > > Add support for tunnel offload APIs. Specifically the following > > are supported. > > tunnel_decap_set, tunnel_match, tunnel_action_decap_release, > > tunnel_item_release. > > > >

Re: [dpdk-dev] [PATCH] net/virtio: fix virtio-user init when using existing tap

2021-09-28 Thread Maxime Coquelin
On 9/17/21 11:33, David Marchand wrote: When attaching to an existing mono queue tap, the virtio-user was not reporting that the virtio device was not properly initialised which prevented from starting the port later. $ ip tuntap add test mode tap $ dpdk-testpmd --vdev \ net_virtio_user0,i

Re: [dpdk-dev] [PATCH] net/virtio: do not use PMD log type

2021-09-28 Thread Maxime Coquelin
On 9/16/21 15:25, David Marchand wrote: Fixes: 1982462eadea ("net/virtio: add Rx free threshold setting") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/virtio/virtio_rxtx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Applied to dpdk-next-virtio/mai

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-28 Thread Xueming(Steven) Li
On Tue, 2021-09-28 at 15:05 +0530, Jerin Jacob wrote: On Sun, Sep 26, 2021 at 11:06 AM Xueming(Steven) Li mailto:xuemi...@nvidia.com>> wrote: On Wed, 2021-08-11 at 13:04 +0100, Ferruh Yigit wrote: On 8/11/2021 9:28 AM, Xueming(Steven) Li wrote: -Original Message- From: Jerin Jacob

Re: [dpdk-dev] [PATCH v2] net/virtio: remove blank lines in log

2021-09-28 Thread Maxime Coquelin
On 9/16/21 11:53, Thomas Monjalon wrote: The macros PMD_*_LOG already include the line feed character. Redundant \n are removed. Signed-off-by: Thomas Monjalon Reviewed-by: David Marchand Reviewed-by: Chenbo Xia --- v2: fix more macros than PMD_INIT_LOG --- drivers/net/virtio/virtio_ethd

Re: [dpdk-dev] [PATCH v2] vhost: normalize return type and function name

2021-09-28 Thread Maxime Coquelin
On 9/16/21 06:34, Xuan Ding wrote: In some function definitions, adjust return type and function name on a separate line to be consistent with DPDK coding style. Signed-off-by: Xuan Ding --- v2: * Fixed one format issue. --- lib/vhost/vhost.c | 15 ++- 1 file changed, 10 inser

Re: [dpdk-dev] [PATCH] net/virtio: report max/min/align Tx desc limits in dev info

2021-09-28 Thread Maxime Coquelin
On 9/15/21 14:23, Andrew Rybchenko wrote: From: Ivan Ilchenko Report max/min/align Tx descriptors limits in device info get callback. Before calling the callback, rte_eth_dev_info_get() provides default values of nb_min as zero and nb_max as UINT16_MAX that are not correct for the driver, so

Re: [dpdk-dev] [PATCH] vhost: rework RARP packet injection

2021-09-28 Thread Maxime Coquelin
On 9/15/21 16:54, David Marchand wrote: Caught by code review, this copy is unnecessary. Signed-off-by: David Marchand --- lib/vhost/virtio_net.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) Applied to dpdk-next-virtio/main. Thanks, Maxime

Re: [dpdk-dev] [PATCH v2] net/virtio: wait device ready during reset

2021-09-28 Thread Maxime Coquelin
On 9/15/21 12:12, Xueming Li wrote: According to virtio spec, the device MUST reset when 0 is written to device_status, and present 0 in device_status once reset is done. This patch waits status value to be 0 during reset operation, if timeout in 3 seconds, log and continue. Signed-off-by: X

Re: [dpdk-dev] [PATCH v2 2/2] net/virtio: fix Tx completed mbufs leak on device stop

2021-09-28 Thread Maxime Coquelin
On 9/15/21 11:19, Andrew Rybchenko wrote: From: Ivan Ilchenko Free Tx completed mbufs on device stop. Not completed Tx mbufs cannot be freed since they are still in use. Fixes: c1f86306a02 ("virtio: add new driver") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Ry

Re: [dpdk-dev] [PATCH v2 1/2] net/virtio: fix Tx cleanup functions to have same signature

2021-09-28 Thread Maxime Coquelin
On 9/15/21 11:19, Andrew Rybchenko wrote: From: Ivan Ilchenko There is a family of cleanup from completed transmits functions. Fix packed virtqueues cleanup functions to have the same signature as split virtqueues have. This lets all functions of the family to match the same callback prototy

Re: [dpdk-dev] [PATCH] vhost: Clean iotlb cache on vring stop

2021-09-28 Thread Maxime Coquelin
On 8/27/21 18:12, Eugenio Pérez wrote: Old IOVA cache entries are left when there is a change on virtio driver in VM. In case that all these old entries have iova addresses lesser than new iova entries, vhost code will need to iterate all the cache to find the new ones. In case of just a new i

[dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-09-28 Thread Andrew Rybchenko
Indirect actions should be used to do shared counters. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline_flow.c| 10 -- doc/guides/prog_guide/rte_flow.rst | 19 +-- doc/guides/rel_notes/deprecation.rst | 4 - doc/guides/rel_notes/release_21_11.rst |

Re: [dpdk-dev] [PATCH v6 06/10] ipsec: add transmit segmentation offload support

2021-09-28 Thread Nicolau, Radu
On 9/23/2021 3:09 PM, Ananyev, Konstantin wrote: Add support for transmit segmentation offload to inline crypto processing mode. This offload is not supported by other offload modes, as at a minimum it requires inline crypto for IPsec to be supported on the network interface. Signed-off-by:

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-28 Thread Jerin Jacob
On Tue, Sep 28, 2021 at 8:10 PM Xueming(Steven) Li wrote: > > On Tue, 2021-09-28 at 13:59 +, Ananyev, Konstantin wrote: > > > > > > On Tue, Sep 28, 2021 at 6:55 PM Xueming(Steven) Li > > > wrote: > > > > > > > > On Tue, 2021-09-28 at 18:28 +0530, Jerin Jacob wrote: > > > > > On Tue, Sep 28, 2

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-28 Thread Xueming(Steven) Li
On Tue, 2021-09-28 at 19:08 +0530, Jerin Jacob wrote: > On Tue, Sep 28, 2021 at 6:55 PM Xueming(Steven) Li > wrote: > > > > On Tue, 2021-09-28 at 18:28 +0530, Jerin Jacob wrote: > > > On Tue, Sep 28, 2021 at 5:07 PM Xueming(Steven) Li > > > wrote: > > > > > > > > On Tue, 2021-09-28 at 15:05 +

Re: [dpdk-dev] [PATCH v4 0/6] Add SA lifetime in security

2021-09-28 Thread Akhil Goyal
> Add SA lifetime configuration in security. SA lifetime tracking can be > offloaded on supported PMDs. > > SA lifetime would cover soft & hard expiry in units of number of packets and > bytes. When SA soft expiry happens, the packet is successfuly processed but > with additional expiry notificati

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-28 Thread Xueming(Steven) Li
On Tue, 2021-09-28 at 13:59 +, Ananyev, Konstantin wrote: > > > > On Tue, Sep 28, 2021 at 6:55 PM Xueming(Steven) Li > > wrote: > > > > > > On Tue, 2021-09-28 at 18:28 +0530, Jerin Jacob wrote: > > > > On Tue, Sep 28, 2021 at 5:07 PM Xueming(Steven) Li > > > > wrote: > > > > > > > > > > On

Re: [dpdk-dev] [PATCH v2] eventdev: update rx timestamp in mbuf using mbuf dynamic field

2021-09-28 Thread Jerin Jacob
On Thu, Sep 16, 2021 at 2:45 PM Ganapati Kundapura wrote: > > Add support to register timestamp dynamic field in mbuf. > > Update the timestamp in mbuf for each packet before enqueuing > to event device if the timestamp is not already set. > > Adding the timestamp in Rx adapter avoids additional l

Re: [dpdk-dev] [PATCH v3 1/8] ethdev: introduce shared Rx queue

2021-09-28 Thread Xueming(Steven) Li
On Mon, 2021-09-27 at 16:53 -0700, Ajit Khaparde wrote: > On Fri, Sep 17, 2021 at 1:02 AM Xueming Li wrote: > > > > In current DPDK framework, each RX queue is pre-loaded with mbufs for > > incoming packets. When number of representors scale out in a switch > > domain, the memory consumption beca

  1   2   3   >