If GTPU Extionsion header has no pdu_type setting, the parsed value of
gtp_psc_spec->pdu_type will be 0, which is same as IAVF_GTPU_EH_DWLINK.
Thus, for this case, we should check gtp_psc_mask->pdu_type instead,
to set QFI field bit of GTPU_EH first.

Fixes: 45cc3a5435fc ("net/iavf: fix QFI fields of GTPU UL/DL for FDIR")
Cc: sta...@dpdk.org

Signed-off-by: Junfeng Guo <junfeng....@intel.com>
---
 drivers/net/iavf/iavf_fdir.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c
index 560589a496..227a089ce0 100644
--- a/drivers/net/iavf/iavf_fdir.c
+++ b/drivers/net/iavf/iavf_fdir.c
@@ -1171,17 +1171,15 @@ iavf_fdir_parse_pattern(__rte_unused struct 
iavf_adapter *ad,
                        if (gtp_psc_spec && gtp_psc_mask) {
                                if (gtp_psc_mask->qfi == UINT8_MAX) {
                                        input_set |= IAVF_INSET_GTPU_QFI;
-                                       if (gtp_psc_spec->pdu_type ==
-                                                               
IAVF_GTPU_EH_UPLINK)
+                                       if (!gtp_psc_mask->pdu_type)
                                                
VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr,
-                                                                               
 GTPU_UP, QFI);
-                                       else if (gtp_psc_spec->pdu_type ==
-                                                               
IAVF_GTPU_EH_DWLINK)
+                                                                               
 GTPU_EH, QFI);
+                                       else if (gtp_psc_spec->pdu_type == 
IAVF_GTPU_EH_DWLINK)
                                                
VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr,
                                                                                
 GTPU_DWN, QFI);
-                                       else
+                                       else if (gtp_psc_spec->pdu_type == 
IAVF_GTPU_EH_UPLINK)
                                                
VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr,
-                                                                               
 GTPU_EH, QFI);
+                                                                               
 GTPU_UP, QFI);
                                }
 
                                rte_memcpy(hdr->buffer, gtp_psc_spec,
-- 
2.25.1

Reply via email to