Re: [dpdk-dev] [PATCH] ethdev: replace bit shifts with macros

2021-09-15 Thread Andrew Rybchenko
On 9/16/21 12:04 AM, Thomas Monjalon wrote: > The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. > The macro UINT64C is also used to replace remaining occurrences of ULL. > > Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. > > Signed-off-by: Thomas Monjalon Goo

Re: [dpdk-dev] [PATCH 2/8] app/testpmd: use PCI memory resource access APIs

2021-09-15 Thread Xia, Chenbo
Hi, > -Original Message- > From: Li, Xiaoyun > Sent: Thursday, September 16, 2021 2:10 PM > To: Xia, Chenbo ; dev@dpdk.org > Subject: RE: [PATCH 2/8] app/testpmd: use PCI memory resource access APIs > > Hi > > > -Original Message- > > From: Xia, Chenbo > > Sent: Friday, Septemb

Re: [dpdk-dev] [RFC] ethdev: improve link speed to string

2021-09-15 Thread Andrew Rybchenko
On 9/16/21 5:56 AM, Min Hu (Connor) wrote: > Currently, link speed to string only supports specific speeds, like 10M, > 100M, 1G etc. > > This patch expands support for any link speed which is over 1M and one > decimal place will kept for display at most. > > Signed-off-by: Min Hu (Connor) > ---

Re: [dpdk-dev] [PATCH 2/8] app/testpmd: use PCI memory resource access APIs

2021-09-15 Thread Li, Xiaoyun
Hi > -Original Message- > From: Xia, Chenbo > Sent: Friday, September 10, 2021 10:24 > To: dev@dpdk.org > Cc: Li, Xiaoyun > Subject: [PATCH 2/8] app/testpmd: use PCI memory resource access APIs > > Currently testpmd uses struct rte_pci_device to access PCI memory resource. > Since this

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix parsing of flow queue

2021-09-15 Thread Anoob Joseph
Documentation specifies that flow port & queue is provided as, <...> port 0 queue 0 But code is expecting the same as, <...> port 0 0 Fix the above to match documentation. Fixes: 8e693616fcb2 ("examples/ipsec-secgw: enable flow based distribution") Signed-off-by: Anoob Joseph --- examples/i

[dpdk-dev] [PATCH v2 2/2] net/iavf: remove support for IP fragment default RSS

2021-09-15 Thread Wenjun Wu
To support independent IP fragment default RSS, considerable additional work need to be done, so we decide to remove this feature to avoid some unexpected behavior we have observed, meanwhile user always can use rte_flow to create RSS for IP fragment packet explicitly. Signed-off-by: Wenjun Wu --

[dpdk-dev] [PATCH v2 1/2] net/ice: remove support for IP fragment default RSS

2021-09-15 Thread Wenjun Wu
To support independent IP fragment default RSS, considerable additional work need to be done, so we decide to remove this feature to avoid some unexpected behavior we have observed, meanwhile user always can use rte_flow to create RSS for IP fragment packet explicitly. Signed-off-by: Wenjun Wu --

[dpdk-dev] [PATCH v2 0/2] remove support for IP fragment default RSS

2021-09-15 Thread Wenjun Wu
To support independent IP fragment default RSS, considerable additional work need to be done, so we decide to remove this feature to avoid some unexpected behavior we have observed, meanwhile user always can use rte_flow to create RSS for IP fragment packet explicitly. v2: - fix commit message

Re: [dpdk-dev] [PATCH] app/testpmd: fix statistics in multiple process

2021-09-15 Thread Li, Xiaoyun
Hi > -Original Message- > From: Min Hu (Connor) > Sent: Tuesday, September 14, 2021 11:13 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun > Subject: [PATCH] app/testpmd: fix statistics in multiple process > > Currently, 'clear port stats all' in secondary will clear stats in PMD, a

[dpdk-dev] [PATCH v1 2/2] net/iavf: remove support for IP fragment default RSS

2021-09-15 Thread Wenjun Wu
To support independent IP fragment default RSS, considerable additional work need to be done, so we decide to remove this feature to avoid some unexpected behavior we have observed, meanwhile user always can use rte_flow to create RSS for IP fragment packet explicitly. Signed-off-by: Wenjun Wu --

[dpdk-dev] [PATCH v1 1/2] net/ice: remove support for IP fragment default RSS

2021-09-15 Thread Wenjun Wu
To support independent IP fragment default RSS, considerable additional work need to be done, so we decide to remove this feature to avoid some unexpected behavior we have observed, meanwhile user always can use rte_flow to create RSS for IP fragment packet explicitly. Signed-off-by: Wenjun Wu --

[dpdk-dev] [PATCH v1 0/2] remove support for IP fragment default RSS

2021-09-15 Thread Wenjun Wu
To support independent IP fragment default RSS, considerable additional work need to be done, so we decide to remove this feature to avoid some unexpected behavior we have observed, meanwhile user always can use rte_flow to create RSS for IP fragment packet explicitly. Wenjun Wu (2): net/ice: re

Re: [dpdk-dev] DPDK Max Mbuf Allocation

2021-09-15 Thread Kamaraj P
Hello All, Thank you for the clarification. Is there any guildliness(readme) that can be added as part of each release notes. This would help us to align our DPDK upgrade in our product. Thanks again for your support Thanks, Kamaraj On Tue, Sep 14, 2021 at 7:35 AM Lance Richardson < lance.richa

Re: [dpdk-dev] [PATCH 1/2] lib/eventdev: add usage hints to port configure API

2021-09-15 Thread Jerin Jacob
On Thu, Sep 9, 2021 at 6:24 PM Harry van Haaren wrote: > > This commit introduces 3 flags to the port configuration flags. > These flags allow the application to indicate what type of work > is expected to be performed by an eventdev port. > > The three new flags are > - RTE_EVENT_PORT_CFG_HINT_PR

Re: [dpdk-dev] [PATCH v1] eventdev: update rx timestamp in mbuf using mbuf dynamic field

2021-09-15 Thread Jerin Jacob
On Tue, Sep 14, 2021 at 12:44 PM Ganapati Kundapura wrote: > > Add support to register timestamp dynamic field in mbuf. > > Update the timestamp in mbuf for each packet before enqueuing > to event device if the timestamp is not already set. > > Adding the timestamp in Rx adapter avoids additional

Re: [dpdk-dev] [PATCH v3 1/3] eventdev: add rx queue info get api

2021-09-15 Thread Jerin Jacob
() On Wed, Sep 8, 2021 at 1:51 PM Kundapura, Ganapati wrote: > > Hi Jerin, > > > -Original Message- > > From: Jerin Jacob > > Sent: 07 September 2021 15:07 > > To: Kundapura, Ganapati > > Cc: Jayatheerthan, Jay ; dpdk-dev > > ; Pavan Nikhilesh > > Subject: Re: [PATCH v3 1/3] eventdev:

[dpdk-dev] [PATCH v2] vhost: normalize return type and function name

2021-09-15 Thread Xuan Ding
In some function definitions, adjust return type and function name on a separate line to be consistent with DPDK coding style. Signed-off-by: Xuan Ding --- v2: * Fixed one format issue. --- lib/vhost/vhost.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/lib

Re: [dpdk-dev] [PATCH v14] eventdev: simplify Rx adapter event vector config

2021-09-15 Thread Jerin Jacob
On Wed, Sep 15, 2021 at 6:48 PM Kinsella, Ray wrote: > > > > On 15/09/2021 14:15, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Include vector configuration into the structure > > ``rte_event_eth_rx_adapter_queue_conf`` that is used to configure > > Rx adapter ethernet device

Re: [dpdk-dev] [PATCH v2 01/15] ethdev: introduce shared Rx queue

2021-09-15 Thread Jerin Jacob
On Wed, Sep 15, 2021 at 8:15 PM Xueming(Steven) Li wrote: > > Hi Jerin, > > On Mon, 2021-08-30 at 15:01 +0530, Jerin Jacob wrote: > > On Sat, Aug 28, 2021 at 7:46 PM Xueming(Steven) Li > > wrote: > > > > > > > > > > > > > -Original Message- > > > > From: Jerin Jacob > > > > Sent: Thursd

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-15 Thread fengchengwen
Hi Thomas, Most fixed in V22, some please see inline comment Thanks. On 2021/9/9 18:33, Thomas Monjalon wrote: > Hi, > > I am having a surface look at the API. > I hope we can do better than previous libs. > > 07/09/2021 14:56, Chengwen Feng: >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -49

[dpdk-dev] [PATCH v22 5/5] app/test: add dmadev API test

2021-09-15 Thread Chengwen Feng
This patch add dmadev API test which based on 'dma_skeleton' vdev. The test cases could be executed using 'dmadev_autotest' command in test framework. Signed-off-by: Chengwen Feng Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh --- MAINTAINERS

[dpdk-dev] [PATCH v22 1/5] dmadev: introduce DMA device library

2021-09-15 Thread Chengwen Feng
The 'dmadevice' is a generic type of DMA device. This patch introduce the 'dmadevice' device allocation APIs and it's multi-process support. The infrastructure is prepared to welcome drivers in drivers/dma/ Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Acked-

[dpdk-dev] [PATCH v22 4/5] dma/skeleton: introduce skeleton dmadev driver

2021-09-15 Thread Chengwen Feng
Skeleton dmadevice driver, on the lines of rawdev skeleton, is for showcasing of the dmadev library. Design of skeleton involves a virtual device which is plugged into VDEV bus on initialization. Also, enable compilation of dmadev skeleton drivers. Signed-off-by: Chengwen Feng Reviewed-by: Kevi

[dpdk-dev] [PATCH v22 3/5] dmadev: add data plane function support

2021-09-15 Thread Chengwen Feng
This patch add data plane functions for dmadev. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/prog_guide/dmadev.rst | 22 ++ doc/guides/rel_notes/release_21_11.rst | 2 +- lib/dmadev/r

[dpdk-dev] [PATCH v22 2/5] dmadev: add control plane function support

2021-09-15 Thread Chengwen Feng
This patch add control plane functions for dmadev. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/prog_guide/dmadev.rst | 41 +++ doc/guides/rel_notes/release_21_11.rst | 1 + lib/dmade

[dpdk-dev] [PATCH v22 0/5] support dmadev

2021-09-15 Thread Chengwen Feng
This patch set contains five patch for new add dmadev. Chengwen Feng (5): dmadev: introduce DMA device library dmadev: add control plane function support dmadev: add data plane function support dma/skeleton: introduce skeleton dmadev driver app/test: add dmadev API test --- v22: * funct

Re: [dpdk-dev] [RFC PATCH] build/pkg-config: remove machine arch flag

2021-09-15 Thread Jerin Jacob
On Thu, Sep 16, 2021 at 2:53 AM David Christensen wrote: > > > > On 9/15/21 9:28 AM, Bruce Richardson wrote: > > On Fri, Dec 11, 2020 at 03:51:11PM +, Bruce Richardson wrote: > >> Traditionally any apps built using DPDK had to support the same > >> instruction sets as supported when the DPDK S

[dpdk-dev] [PATCH] vhost: Normalize return type and function name

2021-09-15 Thread Xuan Ding
In function definitions, adjust some return types and function names on a separate line to be consistent with DPDK coding style. --- lib/vhost/vhost.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index 24ae1025ea..69e9d2

Re: [dpdk-dev] [PATCH v8 10/12] test: enable bpf autotest

2021-09-15 Thread Stephen Hemminger
On Mon, 13 Sep 2021 11:15:08 -0700 Stephen Hemminger wrote: > The BPF autotest is defined but not run automatically. > Since it is short, it should be added to the autotest suite. > > Signed-off-by: Stephen Hemminger > --- > app/test/meson.build | 2 ++ > 1 file changed, 2 insertions(+) > > d

Re: [dpdk-dev] [PATCH] net/ice: add ability to reduce the Rx latency

2021-09-15 Thread Tu, Lijuan
> -Original Message- > From: dev On Behalf Of Alvin Zhang > Sent: 2021年9月14日 9:31 > To: Zhang, Qi Z ; Guo, Junfeng > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [dpdk-dev] [PATCH] net/ice: add ability to reduce the Rx latency > > This patch adds a devarg parameter to enable/disable reduc

[dpdk-dev] [Bug 811] BPF tests fail with clang

2021-09-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=811 Bug ID: 811 Summary: BPF tests fail with clang Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/3] app/testpmd: fix RSS hash type update

2021-09-15 Thread Li, Xiaoyun
Hi > -Original Message- > From: stable On Behalf Of Nélio Laranjeiro > Sent: Tuesday, September 14, 2021 15:20 > To: Maxime Coquelin ; Yigit, Ferruh > > Cc: Andrew Rybchenko ; dev@dpdk.org; Xia, > Chenbo ; amore...@redhat.com; > david.march...@redhat.com; michae...@nvidia.com; viachesl..

[dpdk-dev] [PATCH v3] vhost: add unsafe API to check inflight packets

2021-09-15 Thread Xuan Ding
In async data path, when vring state changes, it is necessary to know the number of inflight packets in DMA engine. This patch provides a thread unsafe API to return the number of inflight packets without using any lock. Signed-off-by: Xuan Ding --- v3: * Fixed one typo. * Revised the doc to be m

[dpdk-dev] [RFC] ethdev: improve link speed to string

2021-09-15 Thread Min Hu (Connor)
Currently, link speed to string only supports specific speeds, like 10M, 100M, 1G etc. This patch expands support for any link speed which is over 1M and one decimal place will kept for display at most. Signed-off-by: Min Hu (Connor) --- lib/ethdev/rte_ethdev.c | 34 +---

[dpdk-dev] [PATCH v2 2/2] net/iavf: fix RSS configuration failure

2021-09-15 Thread Wenjun Wu
According to patch [1], IPv4 and IPv6 fragment ptypes should be separated from IP other ptypes. That is to say, when RSS for IP packets is enabled, it should not affect IP fragment packets. Previously, we try to enable RSS for both IP packets and IP fragment packets with hash field of src and dst

[dpdk-dev] [PATCH v2 1/2] net/ice: fix RSS configuration failure

2021-09-15 Thread Wenjun Wu
According to patch [1], IPv4 and IPv6 fragment ptypes should be separated from IP other ptypes. That is to say, when RSS for IP packets is enabled, it should not affect IP fragment packets. Previously, we try to enable RSS for both IP packets and IP fragment packets with hash field of src and dst

[dpdk-dev] [PATCH v2 0/2] fix RSS configuration failure

2021-09-15 Thread Wenjun Wu
Due to share code limitation, independent configuration of default RSS for IP fragment packets need to be removed. v2: - update commit message. Wenjun Wu (2): net/ice: fix RSS configuration failure net/iavf: fix RSS configuration failure drivers/net/iavf/iavf_hash.c | 10 -- dri

[dpdk-dev] [PATCH v2] Enable AddressSanitizer feature on DPDK

2021-09-15 Thread zhihongx . peng
From: Zhihong Peng AddressSanitizer (ASan) is a google memory error detect standard tool. It could help to detect use-after-free and {heap,stack,global}-buffer overflow bugs in C/C++ programs, print detailed error information when error happens, large improve debug efficiency. By referring to it

Re: [dpdk-dev] [PATCH] vhost: rework RARP packet injection

2021-09-15 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Wednesday, September 15, 2021 10:55 PM > To: dev@dpdk.org > Cc: Maxime Coquelin ; Xia, Chenbo > > Subject: [PATCH] vhost: rework RARP packet injection > > Caught by code review, this copy is unnecessary. > > Signed-off-by: David Marcha

Re: [dpdk-dev] [PATCH] net/virtio: remove blank lines in log

2021-09-15 Thread Xia, Chenbo
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, September 15, 2021 10:15 PM > To: dev@dpdk.org > Cc: Maxime Coquelin ; Xia, Chenbo > > Subject: [PATCH] net/virtio: remove blank lines in log > > The macro PMD_INIT_LOG includes already the line feed character. > Redundant \

[dpdk-dev] [PATCH v9 12/12] MAINTAINERS: add entry for new packet capture features

2021-09-15 Thread Stephen Hemminger
Since the packet capture is just extension of existing pdump; add myself as maintainer of that. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1e0d3033946d..081f90c9a0ba 100644 --- a

[dpdk-dev] [PATCH v9 11/12] doc: changes for new pcapng and dumpcap

2021-09-15 Thread Stephen Hemminger
Describe the new packet capture library and utilities Signed-off-by: Stephen Hemminger --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + .../howto/img/packet_capture_framework.svg| 96 +-- doc/guides/howto/packet_c

[dpdk-dev] [PATCH v9 10/12] test: enable bpf autotest

2021-09-15 Thread Stephen Hemminger
The BPF autotest is defined but not run automatically. Since it is short, it should be added to the autotest suite. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- app/test/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/meson.build b/app/test/meson.

[dpdk-dev] [PATCH v9 08/12] test: add test for bpf_convert

2021-09-15 Thread Stephen Hemminger
Add some functional tests for the Classic BPF to DPDK BPF converter. Signed-off-by: Stephen Hemminger --- app/test/test_bpf.c | 200 1 file changed, 200 insertions(+) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 527c06b80708..543a5fd6

[dpdk-dev] [PATCH v9 09/12] test: add a test for pcapng library

2021-09-15 Thread Stephen Hemminger
Simple unit test that created pcapng file using API. To run this test you need to have at least one device. For example: DPDK_TEST=pcapng_autotest ./build/app/test/dpdk-test -l 0-15 \ --no-huge -m 2048 --vdev=net_tap,iface=dummy Signed-off-by: Stephen Hemminger --- app/test/meson.build |

[dpdk-dev] [PATCH v9 07/12] app/dumpcap: add new packet capture application

2021-09-15 Thread Stephen Hemminger
This is a new packet capture application to replace existing pdump. The new application works like Wireshark dumpcap program and supports the pdump API features. It is not complete yet some features such as filtering are not implemented. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c

[dpdk-dev] [PATCH v9 06/12] pdump: support pcapng and filtering

2021-09-15 Thread Stephen Hemminger
This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version number (not part of exposed API or ABI) is intentionally

[dpdk-dev] [PATCH v9 05/12] bpf: add function to dump eBPF instructions

2021-09-15 Thread Stephen Hemminger
When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/bpf/bpf_dump.c | 118 lib/bpf/meson.build | 1 + lib/bpf/rte_bpf.h | 14 ++ li

[dpdk-dev] [PATCH v9 04/12] bpf: add function to convert classic BPF to DPDK BPF

2021-09-15 Thread Stephen Hemminger
The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the resulting program in hugepage shared memory so it

[dpdk-dev] [PATCH v9 03/12] bpf: allow self-xor operation

2021-09-15 Thread Stephen Hemminger
Some BPF programs may use XOR of a register with itself as a way to zero register in one instruction. The BPF filter converter generates this in the prolog to the generated code. The BPF validator would not allow this because the value of register was undefined. But after this operation it always

[dpdk-dev] [PATCH v9 02/12] lib: pdump is not supported on Windows

2021-09-15 Thread Stephen Hemminger
The current version of the pdump library was building on Windows, but it was useless since the pdump utility was not being built and Windows does not have multi-process support. The new version of pdump with filtering now has dependency on bpf. But bpf library is not available on Windows. Signed-

[dpdk-dev] [PATCH v9 01/12] librte_pcapng: add new library for writing pcapng files

2021-09-15 Thread Stephen Hemminger
This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See draft RFC https://www.ietf.org/id/draft-tuexen-opsawg-pcapng-03.html and https://github.com/pcapng/pcapng/ Signed-off-by: Stephe

[dpdk-dev] [PATCH v9 00/12] Packet capture framework enhancements

2021-09-15 Thread Stephen Hemminger
This patch set is a more complete version of the the enhanced packet capture support described last year. The new capture library and utility are: - faster avoids lots of extra I/O, does bursting, etc. - gives more information (multiple ports, queues, etc) - has a better user interface (same

Re: [dpdk-dev] [PATCH v8 10/12] test: enable bpf autotest

2021-09-15 Thread Stephen Hemminger
On Wed, 15 Sep 2021 11:27:15 + "Ananyev, Konstantin" wrote: > > The BPF autotest is defined but not run automatically. > > Since it is short, it should be added to the autotest suite. > > > > Signed-off-by: Stephen Hemminger > > --- > > app/test/meson.build | 2 ++ > > 1 file changed, 2 in

Re: [dpdk-dev] [PATCH 4/5] ring: rename local variables for Windows compatibility

2021-09-15 Thread Honnappa Nagarahalli
> > Windows SDK headers define `max` macro which breaks the definitions of > `max` variable inside inline functions. Rename the variables to allow > inclusion > of both DPDK and Windows headers in the same file. Minor comment, typically we include the error message in the commit log. In this c

[dpdk-dev] [PATCH 5/5] net: rename Ethernet header fields

2021-09-15 Thread Dmitry Kozlyuk
Definition of `rte_ether_addr` structure used a workaround allowing DPDK and Windows SDK headers to be used in the same file, because Windows SDK defines `s_addr` as a macro. Rename `s_addr` to `src_addr` and `d_addr` to `dst_addr` to avoid the conflict and remove the workaround. Deprecation notice

[dpdk-dev] [PATCH 4/5] ring: rename local variables for Windows compatibility

2021-09-15 Thread Dmitry Kozlyuk
Windows SDK headers define `max` macro which breaks the definitions of `max` variable inside inline functions. Rename the variables to allow inclusion of both DPDK and Windows headers in the same file. Signed-off-by: Dmitry Kozlyuk --- lib/ring/rte_ring_c11_pvt.h | 8 lib/ring/rte_

[dpdk-dev] [PATCH 3/5] table: rename local variable for Windows compatibility

2021-09-15 Thread Dmitry Kozlyuk
Windows SDK headers define `min` macro which breaks the definition of `min` variable in `f_lru_pos()` inline function. Rename the variable to allow inclusion of both DPDK and Windows headers in the same file. Signed-off-by: Dmitry Kozlyuk --- lib/table/rte_lru_x86.h | 4 ++-- 1 file changed, 2 i

[dpdk-dev] [PATCH 1/5] compressdev: rename fields for Windows compatibility

2021-09-15 Thread Dmitry Kozlyuk
Windows SDK headers define `min` and `max` macros which break definition of `struct rte_param_log2_range`. Rename the structure fields to `minimum` and `maximum` to allow inclusion of both DPDK and Windows headers in the same file. Deprecation notice: https://mails.dpdk.org/archives/dev/2021-July/2

[dpdk-dev] [PATCH 0/5] lib: Windows compatibility renaming

2021-09-15 Thread Dmitry Kozlyuk
Windows SDK headers define `s_addr`, `min`, and `max` macros. When Windows SDK and DPDK headers are used in the same file, these macros break definitions of some DPDK structures and inline functions. Rename the problematic fields and local variables per the deprecation notice: https://mails.dpdk.or

Re: [dpdk-dev] [RFC PATCH] build/pkg-config: remove machine arch flag

2021-09-15 Thread David Christensen
On 9/15/21 9:28 AM, Bruce Richardson wrote: On Fri, Dec 11, 2020 at 03:51:11PM +, Bruce Richardson wrote: Traditionally any apps built using DPDK had to support the same instruction sets as supported when the DPDK SDK itself was built, since that was "leaked" through to the end-app and DP

[dpdk-dev] [PATCH] app/test: enable crypto unit tests on Windows

2021-09-15 Thread Tal Shnaiderman
Enable cryptography unit tests on Windows supported crypto PMDs. Signed-off-by: Tal Shnaiderman --- Depends-on: series-18674 ("app/test: enable subset of tests on Windows") Depends-on: patch-98942 ("security: build on Windows") --- app/test/meson.build | 12 ++-- 1 file changed, 6 insert

[dpdk-dev] [PATCH] ethdev: replace bit shifts with macros

2021-09-15 Thread Thomas Monjalon
The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. The macro UINT64C is also used to replace remaining occurrences of ULL. Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. Signed-off-by: Thomas Monjalon --- lib/ethdev/rte_ethdev.c | 16 ++--- lib/ethdev/rte_eth

Re: [dpdk-dev] [PATCH] windows/netuio: add Intel Virtual Function device IDs

2021-09-15 Thread Menon, Ranjit
Hi, Dmitry On 9/15/2021 12:07 PM, Dmitry Kozlyuk wrote: 2021-09-14 17:51 (UTC-0700), Pallavi Kadam: Add Intel Ethernet Virtual Function device IDs to netuio inf file to support Intel 40GbE and 100GbE deives on Windows VM. Nit: why only VM? Can't VF be used from the host? I'm not an expert he

[dpdk-dev] [PATCH 1/2] security: use the net library for IP structs

2021-09-15 Thread Tal Shnaiderman
Remove the netinet includes and replaces them with rte_ip.h to support the in_addr/in6_addr structs on all operating systems. Signed-off-by: Tal Shnaiderman --- lib/net/rte_ip.h| 1 + lib/security/meson.build| 2 +- lib/security/rte_security.h | 5 + 3 files changed, 3 insert

[dpdk-dev] [PATCH 2/2] security: build on Windows

2021-09-15 Thread Tal Shnaiderman
Build the security library on Windows. Remove unneeded export from version file. Signed-off-by: Tal Shnaiderman --- Depends-on: patch-98796 ("cryptodev: build on Windows") --- lib/meson.build | 1 + lib/security/version.map | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --

Re: [dpdk-dev] [PATCH v3 0/5] more build tests

2021-09-15 Thread Ferruh Yigit
On 8/8/2021 1:51 PM, Thomas Monjalon wrote: > While testing more build types, some errors occur. > > v3: fix minsize build with GCC > v2: fix init of var buildtype > > Thomas Monjalon (5): > net/qede: fix minsize build > regex/mlx5: fix minsize build > vdpa/mlx5: fix minsize build > test/

Re: [dpdk-dev] [PATCH v1] net/ixgbe: Add support for Windows

2021-09-15 Thread William Tu
On Wed, Sep 15, 2021 at 12:05 PM Dmitry Kozlyuk wrote: > > 2021-09-15 18:44 (UTC+), William Tu: > > This patch enables building the ixgbe driver for Windows. > > It also enables its dependencies on security and cryptodev. > > Tal Shnaiderman posted patches for cryptodev and security today, > s

Re: [dpdk-dev] [PATCH] vhost: rework RARP packet injection

2021-09-15 Thread Maxime Coquelin
On 9/15/21 4:54 PM, David Marchand wrote: > Caught by code review, this copy is unnecessary. > > Signed-off-by: David Marchand > --- > lib/vhost/virtio_net.c | 11 +++ > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c >

Re: [dpdk-dev] [PATCH] eal/windows: fix token pasting build warning

2021-09-15 Thread Dmitry Kozlyuk
2021-09-13 19:55 (UTC+0300), Tal Shnaiderman: > When building DPDK on Windows in debug mode the following > warning appear: > > warning: token pasting of ',' and __VA_ARGS__ is a GNU extension > [-Wgnu-zero-variadic-macro-arguments] #define open(path, flags, ...) > _open(path, flags, ##__VA_ARGS__

Re: [dpdk-dev] [PATCH] windows/netuio: add Intel Virtual Function device IDs

2021-09-15 Thread Dmitry Kozlyuk
2021-09-14 17:51 (UTC-0700), Pallavi Kadam: > Add Intel Ethernet Virtual Function device IDs to netuio inf file > to support Intel 40GbE and 100GbE deives on Windows VM. Nit: why only VM? Can't VF be used from the host? > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon Acked-by: Dm

Re: [dpdk-dev] [PATCH v1] net/ixgbe: Add support for Windows

2021-09-15 Thread Dmitry Kozlyuk
2021-09-15 18:44 (UTC+), William Tu: > This patch enables building the ixgbe driver for Windows. > It also enables its dependencies on security and cryptodev. Tal Shnaiderman posted patches for cryptodev and security today, so I won't comment on that part. IMO your patch should depend on them

Re: [dpdk-dev] [PATCH] maintainers: sort NXP raw drivers

2021-09-15 Thread David Marchand
On Wed, Sep 15, 2021 at 6:49 PM Thomas Monjalon wrote: > > Drivers are alphabetically sorted. > > Signed-off-by: Thomas Monjalon Acked-by: David Marchand -- David Marchand

Re: [dpdk-dev] [PATCH v2 01/15] ethdev: introduce shared Rx queue

2021-09-15 Thread Xueming(Steven) Li
Hi Jerin, On Mon, 2021-08-30 at 15:01 +0530, Jerin Jacob wrote: > On Sat, Aug 28, 2021 at 7:46 PM Xueming(Steven) Li > wrote: > > > > > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Thursday, August 26, 2021 7:58 PM > > > To: Xueming(Steven) Li > > > Cc: dpdk-dev ;

[dpdk-dev] [PATCH v1] net/ixgbe: Add support for Windows

2021-09-15 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Signed-off-by: William Tu --- drivers/net/ixgbe/base/ixgbe_hv_vf.c | 1 + drivers/net/ixgbe/base/ixgbe_osdep.h | 10 ++

Re: [dpdk-dev] [dpdk-stable] [DPDK] net/virtio: fix check scatter on all Rx queues

2021-09-15 Thread David Marchand
On Wed, Aug 4, 2021 at 10:36 AM wrote: > > From: Zhihong Peng > > This patch fixes the wrong way to obtain virtqueue. > The end of virtqueue cannot be judged based on whether > the array is NULL. Indeed, good catch. I can reproduce a crash with v20.11.3 which has backport of 4e8169eb0d2d. I can

Re: [dpdk-dev] [EXT] [PATCH 1/2] security: use the net library for IP structs

2021-09-15 Thread Akhil Goyal
> Remove the netinet includes and replaces them > with rte_ip.h to support the in_addr/in6_addr structs > on all operating systems. > > Signed-off-by: Tal Shnaiderman > --- > lib/net/rte_ip.h| 1 + > lib/security/meson.build| 2 +- > lib/security/rte_security.h | 5 + > 3 fil

Re: [dpdk-dev] [PATCH] lib: remove C++ include guard from private headers

2021-09-15 Thread Stephen Hemminger
On Wed, 15 Sep 2021 18:46:35 +0200 Thomas Monjalon wrote: > The private headers are compiled internally with a C compiler. > Thus extern "C" declaration is useless in such files. > > Signed-off-by: Thomas Monjalon > --- Makes sense, make sure it doesn't break Windows builds. There is not a C++

[dpdk-dev] [PATCH] doc/examples: fix build on FreeBSD

2021-09-15 Thread Bruce Richardson
On FreeBSD, "find" does not support the "printf" flag, so we need to use "gfind" from the "findutils" package. Fixes: 8260f4f98cfe ("mk: use script to generate examples.dox") Cc: bl...@debian.org Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- doc/api/generate_examples.sh | 14 +

Re: [dpdk-dev] [PATCH 32/32] doc: update for ngbe

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Add ngbe PMD new features in release note 21.11. > Can you please distribute the content of this patch to the commit that adds the feature documented here? As a result there shouldn't be a separate patch for release notes update. Thanks. > Signed-off-by:

Re: [dpdk-dev] [PATCH 28/32] net/ngbe: add IPsec context creation

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Initialize securiry context, and support to get security > capabilities. > > Signed-off-by: Jiawen Wu <...> > --- a/drivers/net/ngbe/ngbe_ethdev.c > +++ b/drivers/net/ngbe/ngbe_ethdev.c > @@ -430,6 +430,12 @@ eth_ngbe_dev_init(struct rte_eth_dev *eth_dev,

Re: [dpdk-dev] [PATCH 04/32] net/ngbe: support TSO

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Add transmit datapath with offloads, and support TCP segmentation > offload. > > Signed-off-by: Jiawen Wu <...> > +/* Takes an ethdev and a queue and sets up the tx function to be used based > on > + * the queue parameters. Used in tx_queue_setup by prim

Re: [dpdk-dev] [PATCH 19/32] net/ngbe: add mailbox process operations

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Add check operation for vf function level reset, > mailbox messages and ack from vf. > Waiting to process the messages. > > Signed-off-by: Jiawen Wu <...> > --- a/drivers/net/ngbe/meson.build > +++ b/drivers/net/ngbe/meson.build > @@ -20,3 +20,5 @@ source

[dpdk-dev] [PATCH v2] telemetry: remove experimental tags from APIs

2021-09-15 Thread Bruce Richardson
The telemetry APIs have been present and unchanged for >1 year now, so remove experimental tag from them. Signed-off-by: Bruce Richardson --- v2: remove note from docs about telemetry being experimental. doc/guides/howto/telemetry.rst | 4 lib/telemetry/rte_telemetry.h | 18 -

Re: [dpdk-dev] [PATCH 16/32] net/ngbe: support VLAN filter

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Support to filter of a VLAN tag identifier. > > Signed-off-by: Jiawen Wu <...> > @@ -2411,7 +2536,10 @@ static const struct eth_dev_ops ngbe_eth_dev_ops = { > .queue_stats_mapping_set= ngbe_dev_queue_stats_mapping_set, > .fw_version_get

Re: [dpdk-dev] [PATCH 14/32] net/ngbe: support Rx interrupt

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Support Rx queue interrupt. > > Signed-off-by: Jiawen Wu > --- > doc/guides/nics/features/ngbe.ini | 1 + > doc/guides/nics/ngbe.rst | 1 + > drivers/net/ngbe/ngbe_ethdev.c| 35 +++ > 3 files changed, 37 insertion

Re: [dpdk-dev] [PATCH 12/32] net/ngbe: support getting FW version

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Add firmware version get operation. > > Signed-off-by: Jiawen Wu <...> > +static int > +ngbe_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t > fw_size) > +{ > + struct ngbe_hw *hw = ngbe_dev_hw(dev); > + int ret; > + > + ret

Re: [dpdk-dev] [PATCH 10/32] net/ngbe: support MTU set

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Support updating port MTU. > Although this won't conflict more, if it is not urgent, can you please hold the feature until following set is clarified: https://patches.dpdk.org/project/dpdk/list/?series=17956 > Signed-off-by: Jiawen Wu > --- > doc/guides

Re: [dpdk-dev] [PATCH 08/32] net/ngbe: support basic statistics

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Support to read and clear basic statistics, and configure per-queue > stats counter mapping. > > Signed-off-by: Jiawen Wu > --- > doc/guides/nics/features/ngbe.ini | 2 + > doc/guides/nics/ngbe.rst | 1 + > drivers/net/ngbe/base/ngbe_dummy.h

[dpdk-dev] [PATCH] maintainers: sort NXP raw drivers

2021-09-15 Thread Thomas Monjalon
Drivers are alphabetically sorted. Signed-off-by: Thomas Monjalon --- MAINTAINERS | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1e0d303394..e2ef601893 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1304,16 +1304,6 @@ F

Re: [dpdk-dev] [PATCH 06/32] net/ngbe: support jumbo frame

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Add to support Rx jumbo frames. > > Signed-off-by: Jiawen Wu > --- > doc/guides/nics/features/ngbe.ini | 1 + > doc/guides/nics/ngbe.rst | 1 + > drivers/net/ngbe/ngbe_rxtx.c | 11 ++- > 3 files changed, 12 insertions(+), 1 deletion

Re: [dpdk-dev] [PATCH 05/32] net/ngbe: support CRC offload

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Support to strip or keep CRC in Rx path. > > Signed-off-by: Jiawen Wu > --- > doc/guides/nics/features/ngbe.ini | 1 + > drivers/net/ngbe/ngbe_rxtx.c | 53 +-- > drivers/net/ngbe/ngbe_rxtx.h | 1 + > 3 files changed,

Re: [dpdk-dev] [PATCH 03/32] net/ngbe: support Rx checksum offload

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Support IP/L4 checksum on Rx, and convert it to mbuf flags. > > Signed-off-by: Jiawen Wu > --- > doc/guides/nics/features/ngbe.ini | 2 + > doc/guides/nics/ngbe.rst | 1 + > drivers/net/ngbe/ngbe_rxtx.c | 75 +--

Re: [dpdk-dev] [PATCH 01/32] net/ngbe: add packet type

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Add packet type marco definition and convert ptype to ptid. > > Signed-off-by: Jiawen Wu > --- > doc/guides/nics/features/ngbe.ini | 1 + > doc/guides/nics/ngbe.rst | 1 + > drivers/net/ngbe/meson.build | 1 + > drivers/net/ngbe/ngbe_et

[dpdk-dev] [PATCH] lib: remove C++ include guard from private headers

2021-09-15 Thread Thomas Monjalon
The private headers are compiled internally with a C compiler. Thus extern "C" declaration is useless in such files. Signed-off-by: Thomas Monjalon --- lib/acl/acl_vect.h| 8 lib/acl/tb_mem.h | 8 lib/bpf/bpf_def.h |

Re: [dpdk-dev] [PATCH 4/4] security: add reserved bitfields

2021-09-15 Thread Stephen Hemminger
On Sat, 31 Jul 2021 23:43:27 +0530 Akhil Goyal wrote: > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > index 88d31de0a6..4606425e8d 100644 > --- a/lib/security/rte_security.h > +++ b/lib/security/rte_security.h > @@ -181,6 +181,12 @@ struct rte_security_ipsec_sa_options

Re: [dpdk-dev] logs about hugepages detection

2021-09-15 Thread Stephen Hemminger
On Wed, 15 Sep 2021 15:59:38 +0100 Bruce Richardson wrote: > On Wed, Sep 15, 2021 at 04:39:21PM +0200, Thomas Monjalon wrote: > > 15/09/2021 16:25, Bruce Richardson: > > > On Wed, Sep 15, 2021 at 03:52:35PM +0200, Thomas Monjalon wrote: > > > > Hi, > > > > > > > > I would like to discuss som

Re: [dpdk-dev] [PATCH] doc: remove references to the old build system

2021-09-15 Thread Bruce Richardson
On Wed, Sep 15, 2021 at 06:28:45PM +0200, Thomas Monjalon wrote: > Some docs and comments in Meson files are still mentioning > the old build system based on "make", removed in 20.11. > After one year, such references are better to be removed. > > Signed-off-by: Thomas Monjalon > --- > doc/guide

[dpdk-dev] [PATCH v6 3/3] examples/ipsec-secgw: update event mode inline path

2021-09-15 Thread Nithin Dabilpuram
Update mbuf.l2_len with L2 header size for outbound inline processing. This patch also fixes a bug in arg parsing. Signed-off-by: Nithin Dabilpuram Acked-by: Konstantin Ananyev Acked-by: Akhil Goyal --- examples/ipsec-secgw/ipsec-secgw.c | 2 ++ examples/ipsec-secgw/ipsec_worker.c | 41

Re: [dpdk-dev] [PATCH] doc: remove template comments in old release notes

2021-09-15 Thread Bruce Richardson
On Wed, Sep 15, 2021 at 06:25:09PM +0200, Thomas Monjalon wrote: > The release notes comments mention how to generate the documentation > with the old & removed build system. > > Rather than fixing these comments, all old release notes comments > are removed, because they are useful only for the c

  1   2   3   >