On Wed, Sep 15, 2021 at 12:05 PM Dmitry Kozlyuk <dmitry.kozl...@gmail.com> wrote: > > 2021-09-15 18:44 (UTC+0000), William Tu: > > This patch enables building the ixgbe driver for Windows. > > It also enables its dependencies on security and cryptodev. > > Tal Shnaiderman posted patches for cryptodev and security today, > so I won't comment on that part. IMO your patch should depend on them > (https://doc.dpdk.org/guides/contributing/patches.html#patch-dependencies). > > [...] > > diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h > > b/drivers/net/ixgbe/base/ixgbe_osdep.h > > index cacf724198..fe28029ef7 100644 > > --- a/drivers/net/ixgbe/base/ixgbe_osdep.h > > +++ b/drivers/net/ixgbe/base/ixgbe_osdep.h > > @@ -17,6 +17,12 @@ > > #include <rte_byteorder.h> > > #include <rte_io.h> > > > > +#ifndef RTE_EXEC_ENV_WINDOWS > > +#include <netinet/in.h> > > +#else > > +#include <Ws2tcpip.h> > > +#endif > > + > > #include <rte_ip.h> instead.
Hi Dmitry, Thanks for your feedback. I will send v2. William
