[dpdk-dev] [PATCH 2/2] net/iavf: support IPv4/L4 checksum RSS offload

2021-09-08 Thread Alvin Zhang
Add supports for RSS_IPV4_CHKSUM & RSS_L4_CHKSUM RSS offload types in RSS flow. Signed-off-by: Alvin Zhang --- drivers/net/iavf/iavf_hash.c | 38 +++--- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/

[dpdk-dev] [PATCH 1/2] common/iavf: enable hash calculation based on IPv4 checksum

2021-09-08 Thread Alvin Zhang
Add IPv4 header checksum field selector, it can be used in creating FDIR or RSS rules related to IPv4 header checksum. Signed-off-by: Alvin Zhang --- drivers/common/iavf/virtchnl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h

[dpdk-dev] [PATCH] net/ice: support IPv4/L4 checksum RSS offload

2021-09-08 Thread Alvin Zhang
Add supports for RSS_IPV4_CHKSUM & RSS_L4_CHKSUM RSS offload types in RSS flow. Signed-off-by: Alvin Zhang --- drivers/net/ice/ice_hash.c | 33 ++--- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c

[dpdk-dev] [PATCH] vhost: add unsafe API to check inflight packets

2021-09-08 Thread Xuan Ding
In async data path, when vring state changes, it is necessary to know the number of inflight packets in DMA engine. This patch provides a thread unsafe API to return the number of inflight packets without using any lock. Signed-off-by: Xuan Ding --- doc/guides/prog_guide/vhost_lib.rst| 5 ++

[dpdk-dev] [PATCH v4] net/pcap: improve rx statistics

2021-09-08 Thread Qiming Chen
In the receiving direction, if alloc mbuf or jumbo process failed, there is no err_pkts count, which makes it difficult to locate the problem. Because alloc mbuf failed, the rx_nombuf field is counted. Signed-off-by: Qiming Chen --- v2: Clear coding style issues. v3: 1) Send direction does no

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix vf mac remains

2021-09-08 Thread Qiming Chen
OK,Thanks your test and reply. It may be that the pf kernel version I tested before is older, and the code snippets you posted have not yet been implemented. I will test it again based on the latest version.

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix probability of obtaining mailbox lock failure

2021-09-08 Thread Qiming Chen
This is a problem triggered by the existing network. I discovered it a long time ago. I use the link state as an example. It is not to say that it is a link state problem, but to show that ixgbevf does have such a probability problem. The current modification and repeated verification can indee

Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-09-08 Thread Li, Xiaoyun
Hi > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, September 9, 2021 00:51 > To: Wang, Jie1X ; dev@dpdk.org; Li, Xiaoyun > > Cc: andrew.rybche...@oktetlabs.ru; tho...@monjalon.net > Subject: Re: [PATCH v8 2/2] app/testpmd: fix testpmd doesn't show RSS hash > offload > > On

Re: [dpdk-dev] [PATCH v3] net/pcap: improve rx statistics

2021-09-08 Thread Stephen Hemminger
On Thu, 9 Sep 2021 10:45:31 +0800 Qiming Chen wrote: > In the receiving direction, if alloc mbuf or jumbo process failed, there > is no err_pkts count, which makes it difficult to locate the problem. > Because alloc mbuf failed, the rx_nombuf field is counted. > > Signed-off-by: Qiming Chen >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix probability of obtaining mailbox lock failure

2021-09-08 Thread Wang, Haiyue
I have to say that ixgbevf PMD have limitation to handle the reset event, so for your application demo, if the link down/up event is detected, it needs to reset the ixgbevf as kernel does: BTW, retry doesn't help to make things better, you have to wait the PF notify you thing is done. https://git

[dpdk-dev] [PATCH v3] net/pcap: improve rx statistics

2021-09-08 Thread Qiming Chen
In the receiving direction, if alloc mbuf or jumbo process failed, there is no err_pkts count, which makes it difficult to locate the problem. Because alloc mbuf failed, the rx_nombuf field is counted. Signed-off-by: Qiming Chen --- v2: Clear coding style issues. v3: 1) Send direction does no

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix vf mac remains

2021-09-08 Thread Wang, Haiyue
Please use the testpmd firstly to verify the PMD's issue! And I tested in testpmd. 1. mac_addr set 0 00:11:22:33:44:88 2. quit testpmd. 3. Add debug message in PF: https://www.intel.com/content/www/us/en/download/14302/14687/intel-network-adapter-driver-for-pcie-intel-10-gigabit-ethernet-ne

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix probability of obtaining mailbox lock failure

2021-09-08 Thread Wang, Haiyue
Again, Please DON’T REPLY with rich text, it is hard to handle in patchwork. And DON'T REPLY on top. BR, Haiyue From: Qiming Chen Sent: Thursday, September 9, 2021 09:57 To: Wang, Haiyue Cc: dev@dpdk.org; sta...@dpdk.org Subject: Re: [PATCH v2] net/ixgbe: fix probability of obtaining mailbox l

Re: [dpdk-dev] [PATCH] vhost: promote some APIs to stable

2021-09-08 Thread Xia, Chenbo
Hi Kevin, > -Original Message- > From: Kevin Traynor > Sent: Wednesday, September 8, 2021 8:01 PM > To: Xia, Chenbo ; dev@dpdk.org; > maxime.coque...@redhat.com > Cc: Liu, Changpeng ; m...@ashroe.eu > Subject: Re: [dpdk-dev] [PATCH] vhost: promote some APIs to stable > > On 07/09/2021 03

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix probability of obtaining mailbox lock failure

2021-09-08 Thread Qiming Chen
This problem is not based on the log to observe and locate, you can try the following steps to reproduce: 1) kernel pf + dpdk vf mode; 2) The vf control panel keeps adding or acquiring configurations, such as create thread to get link status, etc. 3) Write a script to repeatedly perform "if confi

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix vf mac remains

2021-09-08 Thread Qiming Chen
thanks your reply. kernal PF + dpdk VF mode, I developed a demo based on dpdk. I used igb_uio to take over the vf port, and then added a unicast MAC address to the port. As a result, the MAC packet was flowed to test ok, and then the demo was restarted, and the traffic still passed. From this

[dpdk-dev] [PATCH v2] net/ice: add 1PPS support for E810

2021-09-08 Thread Simei Su
The E810 supports four single-ended GPIO signals (SDP[20:23]). The 1PPS signal outputs via SDP[20:23], which is measured by an oscilloscope. This feature can be turned by a devargs which can select GPIO pin index flexibly. Pin index 0 means SDP20, pin index 1 means SDP21 and so on. The example for

[dpdk-dev] [PATCH v3] net/ice: support IEEE 1588 PTP for E810

2021-09-08 Thread Simei Su
Add ice support for new ethdev APIs to enable/disable and read/write/adjust IEEE1588 PTP timstamps. Currently, only scalar path supports 1588 PTP, vector path doesn't. The example command for running ptpclient is as below: ./build/examples/dpdk-ptpclient -c 1 -n 3 -- -T 0 -p 0x1 Signed-off-by: Si

Re: [dpdk-dev] [PATCH v3 13/13] app/test: enable subset of unit tests on Windows

2021-09-08 Thread Jie Zhou
On Tue, Sep 07, 2021 at 09:43:56AM -0400, Aaron Conole wrote: > Jie Zhou writes: > > > Enable a subset of unit tests on Windows. Currently not all the > > dependencies (e.g. libraries and some functionalities) of all unit > > tests are supported on Windows yet. > > > > Signed-off-by: Jie Zhou >

[dpdk-dev] [PATCH v5 9/9] MAINTAINERS: add entry for new pcapng and dumper

2021-09-08 Thread Stephen Hemminger
Claim responsibility for the new code. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 266f5ac1dae8..06384ac2702d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1429,6 +1429,12 @@ F: app/test/test_pdump.*

[dpdk-dev] [PATCH v5 8/9] doc: changes for new pcapng and dumpcap

2021-09-08 Thread Stephen Hemminger
Describe the new packet capture library and utilities Signed-off-by: Stephen Hemminger --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + .../howto/img/packet_capture_framework.svg| 96 +-- doc/guides/howto/packet_c

[dpdk-dev] [PATCH v5 7/9] app/dumpcap: add new packet capture application

2021-09-08 Thread Stephen Hemminger
This is a new packet capture application to replace existing pdump. The new application works like Wireshark dumpcap program and supports the pdump API features. It is not complete yet some features such as filtering are not implemented. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c

[dpdk-dev] [PATCH v5 6/9] pdump: support pcapng and filtering

2021-09-08 Thread Stephen Hemminger
This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version number (not part of exposed API or ABI) is intentionally

[dpdk-dev] [PATCH v5 5/9] lib: pdump is not supported on Windows

2021-09-08 Thread Stephen Hemminger
The original version of the pdump library was building on Windows, but it was useless since the pdump utility was not being built. The new version of pdump with filtering now has dependency on bpf. But bpf library is not available on Windows. For now, just stop trying to build pdump on Windows. E

[dpdk-dev] [PATCH v5 4/9] bpf: add function to dump eBPF instructions

2021-09-08 Thread Stephen Hemminger
When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_dump.c | 118 lib/bpf/meson.build | 1 + lib/bpf/rte_bpf.h | 14 ++ lib/bpf/version.map | 1 + 4 f

[dpdk-dev] [PATCH v5 3/9] bpf: add function to convert classic BPF to DPDK BPF

2021-09-08 Thread Stephen Hemminger
The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the resulting program in hugepage shared memory so it

[dpdk-dev] [PATCH v5 2/9] bpf: allow self-xor operation

2021-09-08 Thread Stephen Hemminger
When doing BPF filter program conversion, a common way to zero a register in single instruction is: xor r7,r7 The BPF validator would not allow this because the value of r7 was undefined. But after this operation it always zero. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_validate.c |

[dpdk-dev] [PATCH v5 1/9] librte_pcapng: add new library for writing pcapng files

2021-09-08 Thread Stephen Hemminger
This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See draft RFC https://www.ietf.org/id/draft-tuexen-opsawg-pcapng-03.html and https://github.com/pcapng/pcapng/ Signed-off-by: Stephe

[dpdk-dev] [PATCH v5 0/9] Packet capture framework enhancements

2021-09-08 Thread Stephen Hemminger
This patch set is a more complete version of the the enhanced packet capture support described last year. The new capture library and utility are: - faster avoids lots of extra I/O, does bursting, etc. - gives more information (multiple ports, queues, etc) - has a better user interface (same

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-08 Thread Jerin Jacob
On Tue, 7 Sep 2021, 10:25 pm Bruce Richardson, wrote: > From: Kevin Laatz > > Add a burst capacity check API to the dmadev library. This API is useful to > applications which need to how many descriptors can be enqueued in the > current batch. For example, it could be used to determine whether a

[dpdk-dev] [PATCH v2] test/atomic: fix false failures for 128-bit atomic compare exchange test

2021-09-08 Thread David Christensen
When checking the results of the rte_atomic128_cmp_exchange() function, current code compares the values of a uint32_t and a uint64_t variable. If the number of lcores used by the test is large, or the value of the iteration count N is increased, the variable size mismatch can cause a false test fa

Re: [dpdk-dev] [PATCH] eal/ppc: ignore gcc 10 stringop-overflow warnings

2021-09-08 Thread David Christensen
Suppress gcc warning "warning: writing 16 bytes into a region of size 0" for users of the POWER rte_memcpy() function. Existing rte_memcpy() code takes different code paths based on the actual size of the move so the warning is already addressed. See also commit b5b3ea803e47 ("eal/x86: ignore gcc

[dpdk-dev] [PATCH v2] test/atomic: fix false failures for 128-bit atomic compare exchange test

2021-09-08 Thread David Christensen
When checking the results of the rte_atomic128_cmp_exchange() function, current code compares the values of a uint32_t and a uint64_t variable. If the number of lcores used by the test is large, or the value of the iteration count N is increased, the variable size mismatch can cause a false test fa

[dpdk-dev] [PATCH v4 8/8] MAINTAINERS: add entry for new pcapng and dumper

2021-09-08 Thread Stephen Hemminger
Claim responsibility for the new code. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 266f5ac1dae8..06384ac2702d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1429,6 +1429,12 @@ F: app/test/test_pdump.*

[dpdk-dev] [PATCH v4 7/8] doc: changes for new pcapng and dumpcap

2021-09-08 Thread Stephen Hemminger
Describe the new packet capture library and utilities Signed-off-by: Stephen Hemminger --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + .../howto/img/packet_capture_framework.svg| 96 +-- doc/guides/howto/packet_c

[dpdk-dev] [PATCH v4 6/8] app/dumpcap: add new packet capture application

2021-09-08 Thread Stephen Hemminger
This is a new packet capture application to replace existing pdump. The new application works like Wireshark dumpcap program and supports the pdump API features. It is not complete yet some features such as filtering are not implemented. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c

[dpdk-dev] [PATCH v4 5/8] pdump: support pcapng and filtering

2021-09-08 Thread Stephen Hemminger
This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version number (not part of exposed API or ABI) is intentionally

[dpdk-dev] [PATCH v4 4/8] bpf: add function to dump eBPF instructions

2021-09-08 Thread Stephen Hemminger
When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_dump.c | 118 lib/bpf/meson.build | 1 + lib/bpf/rte_bpf.h | 14 ++ lib/bpf/version.map | 1 + 4 f

[dpdk-dev] [PATCH v4 3/8] bpf: add function to convert classic BPF to DPDK BPF

2021-09-08 Thread Stephen Hemminger
The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the resulting program in hugepage shared memory so it

[dpdk-dev] [PATCH v4 2/8] bpf: allow self-xor operation

2021-09-08 Thread Stephen Hemminger
When doing BPF filter program conversion, a common way to zero a register in single instruction is: xor r7,r7 The BPF validator would not allow this because the value of r7 was undefined. But after this operation it always zero. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_validate.c |

[dpdk-dev] [PATCH v4 1/8] librte_pcapng: add new library for writing pcapng files

2021-09-08 Thread Stephen Hemminger
This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See draft RFC https://www.ietf.org/id/draft-tuexen-opsawg-pcapng-03.html and https://github.com/pcapng/pcapng/ Signed-off-by: Stephe

[dpdk-dev] [PATCH v4 0/8] Packet capture framework enhancements

2021-09-08 Thread Stephen Hemminger
This patch set is a more complete version of the the enhanced packet capture support described last year. The new capture library and utility are: - faster avoids lots of extra I/O, does bursting, etc. - gives more information (multiple ports, queues, etc) - has a better user interface (same

Re: [dpdk-dev] [PATCH v2] config/ppc: ignore gcc 11 psabi warnings

2021-09-08 Thread David Christensen
Suppress the gcc warning "note: the layout of aggregates containing vectors with 4-byte alignment has changed in GCC 5" on POWER systems by setting "-Wno-psabi". Warning was originally added to gcc in commit https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9832651 to warn of the vector alignment ch

[dpdk-dev] [PATCH v4] build: add meson options of max_memseg_lists and atomic_mbuf_ref_counts

2021-09-08 Thread Kefu Chai
RTE_MAX_MEMSEG_LISTS = 128 is not enough for high-memory machines, in our case, we need to increase it to 8192. so add an option so user can override it. RTE_MBUF_REFCNT_ATOMIC = 0 is not necessary for applications like Seastar, where it's safe to assume that the mbuf refcnt is only updated by a si

Re: [dpdk-dev] [PATCH] fib: promote experimental API's to stable

2021-09-08 Thread Conor Walsh
The fib and fib6 API's have been in since 19.11 and should be marked as stable. Signed-off-by: Vladimir Medvedkin Acked-by: Conor Walsh

[dpdk-dev] [v7, 6/6] crypto/cnxk: add telemetry endpoints to cryptodev

2021-09-08 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to cryptodev. Signed-off-by: Gowrishankar Muthukrishnan Change-Id: I7a0387fe11f383fca95169cfe2ec97bca46221ac --- .../crypto/cnxk/cnxk_cryptodev_telemetry.c| 154 ++ drivers/crypto/cnxk/meson.build | 1 + 2 files changed, 155 insertions(

[dpdk-dev] [v7, 5/6] telemetry: fix json output buffer size

2021-09-08 Thread Gowrishankar Muthukrishnan
Fix json output buffer size for a single largest value. Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON") Signed-off-by: Gowrishankar Muthukrishnan Change-Id: Ida314114b654b5085244a659eb08b22969339856 --- lib/telemetry/telemetry_json.h | 7 +-- 1 file changed, 5 ins

[dpdk-dev] [v7, 4/6] net/cnxk: add telemetry endpoing to ethdev

2021-09-08 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint to ethdev. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/net/cnxk/cnxk_ethdev_telemetry.c | 129 +++ drivers/net/cnxk/meson.build | 1 + 2 files changed, 130 insertions(+) create mode 100644 drivers/net/cnxk/cnxk_ethdev_telemetry.

[dpdk-dev] [v7, 3/6] common/cnxk: add telemetry endpoints to nix

2021-09-08 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to nix. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry_nix.c | 849 +++ drivers/common/cnxk/meson.build | 3 +- drivers/common/cnxk/roc_nix.c| 3 + drivers/common/cnxk/roc_nix_priv.h |

[dpdk-dev] [v7, 2/6] mempool/cnxk: add telemetry end points

2021-09-08 Thread Gowrishankar Muthukrishnan
Adding telemetry end points to cnxk mempool driver. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/mempool/cnxk/cnxk_mempool_telemetry.c | 100 ++ drivers/mempool/cnxk/meson.build | 1 + 2 files changed, 101 insertions(+) create mode 100644 drivers/mempool/

[dpdk-dev] [v7, 0/6] cnxk: enable telemetry endpoints

2021-09-08 Thread Gowrishankar Muthukrishnan
This patch series enables telemetry for cnxk in the following: - NPA LF - Mempool driver - NIX LF - Ethdev driver - Crypto driver Depends-on: series-18612 ("net/cnxk: support for inline ipsec") v7: - Added cryptodev endppoints. - minor cleanup in other patches. Gowrishankar Muthukrishnan

[dpdk-dev] [v7, 1/6] common/cnxk: add telemetry endpoints to npa

2021-09-08 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to npa. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry.h | 26 +++ drivers/common/cnxk/cnxk_telemetry_npa.c | 224 +++ drivers/common/cnxk/meson.build | 6 +- drivers/common/cnxk/roc_platform.h |

Re: [dpdk-dev] [PATCH] fib: add rib extension size parameter

2021-09-08 Thread Conor Walsh
This patch adds a new parameter to the fib configuration to specify the size of the extension for internal RIB structure. Signed-off-by: Vladimir Medvedkin Tested-by: Conor Walsh

Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-09-08 Thread Ferruh Yigit
On 8/27/2021 9:17 AM, Jie Wang wrote: > The driver may change offloads info into dev->data->dev_conf > in dev_configure which may cause port->dev_conf and port->rx_conf > contain outdated values. > > This patch updates the offloads info if it changes to fix this issue. > > Fixes: ce8d561418d4 ("a

Re: [dpdk-dev] [PATCH v3 05/17] dma/idxd: create dmadev instances on bus probe

2021-09-08 Thread Conor Walsh
idxd.qid = dev->addr.wq_id; - idxd.u.vdev.dsa_id = dev->addr.device_id; + idxd.u.bus.dsa_id = dev->addr.device_id; This should be done in previous patch. Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v3 06/17] dma/idxd: create dmadev instances on pci probe

2021-09-08 Thread Conor Walsh
When a suitable device is found during the PCI probe, create a dmadev instance for each HW queue. HW definitions required are also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v3 03/17] dma/idxd: add skeleton for VFIO based DSA device

2021-09-08 Thread Conor Walsh
On 08/09/2021 11:30, Kevin Laatz wrote: Add the basic device probe/remove skeleton code for DSA device bound to the vfio pci driver. Relevant documentation and MAINTAINERS update also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v3 04/17] dma/idxd: add bus device probing

2021-09-08 Thread Conor Walsh
+static void * +idxd_vdev_mmap_wq(struct rte_dsa_device *dev) Some inconsistent naming between vdev and bus in some of these functions the above should be idxd_bus_mmap_wq for example. +{ + void *addr; + char path[PATH_MAX]; + int fd; + + snprintf(path, sizeof(pa

Re: [dpdk-dev] [PATCH v8 1/2] ethdev: add an API to get device configuration info

2021-09-08 Thread Ferruh Yigit
On 8/27/2021 9:17 AM, Jie Wang wrote: > This patch adds a new API "rte_eth_dev_conf_info_get()" to help users get > device configuration info. > > Signed-off-by: Jie Wang > --- > lib/ethdev/rte_ethdev.c | 28 > lib/ethdev/rte_ethdev.h | 21 + > li

Re: [dpdk-dev] [EXT] [PATCH 4/7] examples/ipsec-secgw: enable stats by default

2021-09-08 Thread Hemant Agrawal
On 9/8/2021 6:38 PM, Akhil Goyal wrote: Enable stats screen by default Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- I believe timeout should be configurable like we have in l3fwd/l2fwd. And without recompiling, there should be a way out to disable it. If we are not doing an

Re: [dpdk-dev] [PATCH v3 02/17] doc: initial commit for dmadevs section

2021-09-08 Thread Conor Walsh
Add new section to the programmer's guide for dmadev devices. Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v3 01/17] raw/ioat: only build if dmadev not present

2021-09-08 Thread Conor Walsh
From: Bruce Richardson Only build the rawdev IDXD/IOAT drivers if the dmadev drivers are not present. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/meson.build | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/raw/ioat/meson.build

Re: [dpdk-dev] [EXT] [PATCH v12 4/4] devtools: add asym crypto to symbol-tool ignore

2021-09-08 Thread Akhil Goyal
> -- > Add asym crypto to the symbol-tool's ignore file. > > Signed-off-by: Ray Kinsella > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [EXT] [PATCH v4 0/5] support of MAC-I

2021-09-08 Thread Akhil Goyal
> -Original Message- > -- > This series add support of Message Authentication Code > - Integrity on DPAAX platforms. > > v2-change-log: > * update commit message > * merged an existing patch with this series: > https:/

Re: [dpdk-dev] [PATCH v4 2/4] cryptodev: change valid dev API

2021-09-08 Thread Akhil Goyal
> Subject: [PATCH v4 2/4] cryptodev: change valid dev API > > The API rte_cryptodev_pmd_is_valid_dev, can be used > by the application as well as PMD to check whether > the device is valid or not. Hence, _pmd is removed > from the API. > The applications and drivers which use this API are > also u

[dpdk-dev] [PATCH v12 4/4] devtools: add asym crypto to symbol-tool ignore

2021-09-08 Thread Ray Kinsella
Add asym crypto to the symbol-tool's ignore file. Signed-off-by: Ray Kinsella --- devtools/symboltool.ignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 devtools/symboltool.ignore diff --git a/devtools/symboltool.ignore b/devtools/symboltool.ignore new file mode 100644 index 00

[dpdk-dev] [PATCH v12 3/4] maintainers: add new abi scripts

2021-09-08 Thread Ray Kinsella
Add new abi management scripts to the MAINTAINERS file. Signed-off-by: Ray Kinsella --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 266f5ac1da..ff8245271f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -129,6 +129,8 @@ F: devtools/gen-abi.sh

[dpdk-dev] [PATCH v12 2/4] devtools: script to send notifications of expired symbols

2021-09-08 Thread Ray Kinsella
Use this script with the output of the DPDK symbol tool, to notify maintainers of expired symbols by email. You need to define the environment variable DPDK_GETMAINTAINER_PATH for this tool to work. Use terminal output to review the emails before sending. e.g. $ devtools/symbol-tool.py list-expire

[dpdk-dev] [PATCH v12 1/4] devtools: script to track symbols over releases

2021-09-08 Thread Ray Kinsella
This script tracks the growth of stable and experimental symbols over releases since v19.11. The script has the ability to count the added symbols between two dpdk releases, and to list experimental symbols present in two dpdk releases (expired symbols). example usages: Count symbols added since

[dpdk-dev] [PATCH v12 0/4] devtools: scripts to count and track symbols

2021-09-08 Thread Ray Kinsella
Scripts to count and track the lifecycle of DPDK symbols. The symbol-tool script reports on the growth of symbols over releases and list expired symbols. The notify-symbol-maintainers script consumes the input from symbol-tool and generates email notifications of expired symbols. v2: reworked to

[dpdk-dev] [PATCH v11 3/3] maintainers: add new abi scripts

2021-09-08 Thread Ray Kinsella
Add new abi management scripts to the MAINTAINERS file. Signed-off-by: Ray Kinsella --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 266f5ac1da..ff8245271f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -129,6 +129,8 @@ F: devtools/gen-abi.sh

[dpdk-dev] [PATCH v11 2/3] devtools: script to send notifications of expired symbols

2021-09-08 Thread Ray Kinsella
Use this script with the output of the DPDK symbol tool, to notify maintainers of expired symbols by email. You need to define the environment variable DPDK_GETMAINTAINER_PATH for this tool to work. Use terminal output to review the emails before sending. e.g. $ devtools/symbol-tool.py list-expire

[dpdk-dev] [PATCH v11 1/3] devtools: script to track symbols over releases

2021-09-08 Thread Ray Kinsella
This script tracks the growth of stable and experimental symbols over releases since v19.11. The script has the ability to count the added symbols between two dpdk releases, and to list experimental symbols present in two dpdk releases (expired symbols). example usages: Count symbols added since

[dpdk-dev] [PATCH v11 0/3] devtools: scripts to count and track symbols

2021-09-08 Thread Ray Kinsella
Scripts to count and track the lifecycle of DPDK symbols. The symbol-tool script reports on the growth of symbols over releases and list expired symbols. The notify-symbol-maintainers script consumes the input from symbol-tool and generates email notifications of expired symbols. v2: reworked to

Re: [dpdk-dev] [PATCH] fib: promote experimental API's to stable

2021-09-08 Thread Stephen Hemminger
On Wed, 8 Sep 2021 15:57:54 +0200 "Medvedkin, Vladimir" wrote: > Hi Stephen, > > On 07/09/2021 02:34, Stephen Hemminger wrote: > > On Mon, 6 Sep 2021 17:01:15 +0100 > > Vladimir Medvedkin wrote: > > > >> diff --git a/lib/fib/version.map b/lib/fib/version.map > >> index be975ea..af76add 1006

Re: [dpdk-dev] [EXT] [PATCH 7/7] examples/ipsec-secgw: add ethdev reset callback

2021-09-08 Thread Akhil Goyal
> Add event handler for ethdev reset callback I believe the below patch need to be split in 4-5 patches. It has a lot of irrelevant stuff. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > --- > examples/ipsec-secgw/ipsec-secgw.c | 18 +++- > examples/ipsec-secgw/ipsec.h

Re: [dpdk-dev] [EXT] [PATCH 6/7] examples/ipsec-secgw: add support for defining initial sequence number value

2021-09-08 Thread Akhil Goyal
> Add esn field to SA definition block to allow initial ESN value > Add description about the new option added and how to use it. > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > --- > examples/ipsec-secgw/ipsec.c | 5 + > examples/ipsec-secgw/ipsec.h | 2 ++ > examples/i

Re: [dpdk-dev] [EXT] [PATCH 5/7] examples/ipsec-secgw: add support for telemetry

2021-09-08 Thread Akhil Goyal
> Add telemetry support to the IPsec GW sample app > Add description about how user can use this feature. > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > @@ -779,20 +790,27 @@ outbound_sp(struct sp_ctx *sp, struct traffic_type > *ip, > if (ip->num == 0 || sp == NULL) >

Re: [dpdk-dev] [PATCH 4/5] test/thash: add tests for a new Toeplitz hash function

2021-09-08 Thread Medvedkin, Vladimir
Hi Stephen, On 07/09/2021 02:35, Stephen Hemminger wrote: On Mon, 6 Sep 2021 17:03:58 +0100 Vladimir Medvedkin wrote: +uint8_t big_rss_key[] = { +0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2, +0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0, +0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,

Re: [dpdk-dev] [PATCH] fib: promote experimental API's to stable

2021-09-08 Thread Medvedkin, Vladimir
Hi Stephen, On 07/09/2021 02:34, Stephen Hemminger wrote: On Mon, 6 Sep 2021 17:01:15 +0100 Vladimir Medvedkin wrote: diff --git a/lib/fib/version.map b/lib/fib/version.map index be975ea..af76add 100644 --- a/lib/fib/version.map +++ b/lib/fib/version.map @@ -1,4 +1,4 @@ -EXPERIMENTAL { +DPDK

Re: [dpdk-dev] [PATCH v2] net/axgbe: fix potential unreleased lock problem

2021-09-08 Thread Ferruh Yigit
On 8/26/2021 8:02 PM, Chengfeng Ye wrote: > The lock pdata->phy_mutex may not be correctly released if the > function return in these two branches, which may lead to > deadlock if the lock is acquired again. > > Cc: cy...@connect.ust.hk > Bugzilla ID: 776 > > Signed-off-by: Chengfeng Ye > --- >

Re: [dpdk-dev] [PATCH v2] net/axgbe: fix potential unreleased lock problem in axgbe_i2c_xfer

2021-09-08 Thread Ferruh Yigit
On 8/26/2021 7:55 PM, Chengfeng Ye wrote: > The lock pdata->i2c_mutex is not released if the function return in > these two patched branches, which may lead to deadlock problem if > this lock is acquired again. > > Cc: cy...@connect.ust.hk > Bugzilla ID: 777 > > Signed-off-by: Chengfeng Ye Revi

Re: [dpdk-dev] [PATCH v3 3/8] app/test: add basic dmadev instance tests

2021-09-08 Thread Kevin Laatz
On 07/09/2021 17:49, Bruce Richardson wrote: Run basic sanity tests for configuring, starting and stopping a dmadev instance to help validate drivers. This also provides the framework for future tests for data-path operation. Signed-off-by: Bruce Richardson Reviewed-by: Conor Walsh --- app/t

Re: [dpdk-dev] [PATCH v3 1/8] dmadev: add channel status check for testing use

2021-09-08 Thread Kevin Laatz
On 07/09/2021 17:49, Bruce Richardson wrote: Add in a function to check if a device or vchan has completed all jobs assigned to it, without gathering in the results. This is primarily for use in testing, to allow the hardware to be in a known-state prior to gathering completions. Signed-off-by:

Re: [dpdk-dev] [EXT] [PATCH 4/7] examples/ipsec-secgw: enable stats by default

2021-09-08 Thread Akhil Goyal
> Enable stats screen by default > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > --- I believe timeout should be configurable like we have in l3fwd/l2fwd. And without recompiling, there should be a way out to disable it. If we are not doing an effort to do that, then by defa

Re: [dpdk-dev] [EXT] [PATCH 3/7] examples/ipsec-secgw: add support for TSO

2021-09-08 Thread Akhil Goyal
> Add support to allow user to specific MSS for TSO offload on a per SA Spell check 'specify' > basis. MSS configuration in the context of IPsec is only supported for > outbound SA's in the context of an inline IPsec Crypto offload. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nico

[dpdk-dev] [PATCH v4 5/5] crypto/dpaa_sec: add pdcp short MAC-I support

2021-09-08 Thread Gagandeep Singh
This patch add pdcp security short MAC-I support for dpaa_sec driver. Signed-off-by: Gagandeep Singh --- doc/guides/rel_notes/release_21_11.rst | 4 drivers/crypto/dpaa_sec/dpaa_sec.c | 3 +++ drivers/crypto/dpaa_sec/dpaa_sec.h | 11 ++- 3 files changed, 17 insertions(+),

[dpdk-dev] [PATCH v4 4/5] crypto/dpaa2_sec: add PDCP short MAC-I support

2021-09-08 Thread Gagandeep Singh
This patch add PDCP short mac support in dpaa2_sec driver. Signed-off-by: Gagandeep Singh --- doc/guides/rel_notes/release_21_11.rst | 4 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 9 + 3 files changed, 17 insertions(+)

[dpdk-dev] [PATCH v4 3/5] test/crypto: add pdcp security short MAC-I support

2021-09-08 Thread Gagandeep Singh
This patch add support to test the pdcp short mac packets support in crypto. Signed-off-by: Gagandeep Singh --- app/test/test_cryptodev.c | 48 ...est_cryptodev_security_pdcp_test_vectors.h | 105 +- 2 files changed, 152 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v4 2/5] security: add pdcp short MAC-I support

2021-09-08 Thread Gagandeep Singh
From: Hemant Agrawal This patch add support to handle PDCP short MAC-I domain along with standard control and data domains as it has to be treaty as special case with PDCP protocol offload support. ShortMAC-I is the 16 least significant bits of calculated MAC-I. Usually when a RRC message is exc

[dpdk-dev] [PATCH v4 1/5] crypto/dpaa2_sec: support integrity only case for PDCP

2021-09-08 Thread Gagandeep Singh
From: Hemant Agrawal To support short MAC-I, integrity only case is required to be supported for PDCP. Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 25 +++-- 1 file changed, 13 insertions(+), 12 deletions(-) di

[dpdk-dev] [PATCH v4 0/5] support of MAC-I

2021-09-08 Thread Gagandeep Singh
This series add support of Message Authentication Code - Integrity on DPAAX platforms. v2-change-log: * update commit message * merged an existing patch with this series: https://patches.dpdk.org/project/dpdk/patch/20210825081837.23830-1-hemant.agra...@nxp.com/mbox/ v3-change-log: * updated relea

Re: [dpdk-dev] [EXT] [PATCH 1/7] examples/ipsec-secgw: add ol_flags support

2021-09-08 Thread Akhil Goyal
> Add support for ol_flags to the IPsec GW sample app. Description is not appropriate. ol_flags are supported to do what? How the existing code was not good and what benefit do we get from this patch? > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > --- > examples/ipsec-secgw

Re: [dpdk-dev] [PATCH 2/4] cryptodev: promote asym APIs to stable

2021-09-08 Thread Kinsella, Ray
Folks, On 07/09/2021 12:45, Akhil Goyal wrote: >>> Do you think all the asym APIs are not eligible for promoting it to stable >> APIs? >>> I haven't seen any changes for quite some time and we cannot have it >>> experimental Forever. >>> The APIs which you think are expected to change, we can leav

Re: [dpdk-dev] [EXT] [PATCH v3 1/4] security: support PDCP short MAC-I

2021-09-08 Thread Gagandeep Singh
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, September 8, 2021 5:45 PM > To: Gagandeep Singh ; dev@dpdk.org > Cc: tho...@monjalon.net; Hemant Agrawal > Subject: RE: [EXT] [PATCH v3 1/4] security: support PDCP short MAC-I > > > From: Hemant Agrawal > > > > This patch ad

Re: [dpdk-dev] [PATCH v2] net/pcap: improve rxtx statistics

2021-09-08 Thread Ferruh Yigit
On 8/26/2021 4:23 AM, Qiming Chen wrote: > In the receiving direction, if alloc mbuf or jumbo process failed, there > is no err_pkts count, which makes it difficult to locate the problem. ack, but patch adds two places that updates the 'err_pkts'. One of them is where mbuf allocation failed, and f

Re: [dpdk-dev] [EXT] [PATCH v3 1/4] security: support PDCP short MAC-I

2021-09-08 Thread Akhil Goyal
> From: Hemant Agrawal > > This patch add support to handle PDCP short MAC-I domain > along with standard control and data domains as it has to > be treated as special case with PDCP protocol offload support. > > ShortMAC-I is the 16 least significant bits of calculated MAC-I. Usually > when a R

Re: [dpdk-dev] [RFC 15/15] eventdev: promote trace variables to stable

2021-09-08 Thread Kinsella, Ray
On 23/08/2021 20:40, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Promote rte_trace global variables to stable i.e. remove them > from experimental section of version map. Minor niggle - they are being made INTERNAL, not promoted to stable. > > Signed-off-by: Pavan Nikhilesh

Re: [dpdk-dev] [PATCH v2] common/cnxk: fix attaching NPA LF to CPT VF

2021-09-08 Thread Akhil Goyal
> ATTACH_RESOURCES mailbox for CPT LFs is being called without > setting modify bit. Because of this previously attached NPA LF > to the CPT VF is getting removed, when only CPT VF is whitelisted. > This patch fixes the same. > > Fixes: c045d2e5cbbc ("common/cnxk: add CPT configuration") > > v2:

Re: [dpdk-dev] [RFC 13/15] eventdev: promote event vector API to stable

2021-09-08 Thread Kinsella, Ray
On 23/08/2021 20:40, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Promote event vector configuration APIs to stable. > > Signed-off-by: Pavan Nikhilesh > --- > lib/eventdev/rte_event_eth_rx_adapter.h | 2 -- > lib/eventdev/rte_eventdev.h | 1 - > lib/eventdev/vers

  1   2   3   >