[dpdk-dev] [PATCH v3] net/pcap: improve rx statistics

[Qiming Chen]

In the receiving direction, if alloc mbuf or jumbo process failed, there
is no err_pkts count, which makes it difficult to locate the problem.
Because alloc mbuf failed, the rx_nombuf field is counted.

Signed-off-by: Qiming Chen <chenqiming_hua...@163.com>
---
v2:
  Clear coding style issues.
v3:
  1) Send direction does not release mbuf.
  2) Failed to alloc mbuf is counted to the rx_nombuf field.
---
 drivers/net/pcap/pcap_ethdev.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
index a8774b7a43..64b0dbf0e4 100644
--- a/drivers/net/pcap/pcap_ethdev.c
+++ b/drivers/net/pcap/pcap_ethdev.c
@@ -297,8 +297,10 @@ eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t 
nb_pkts)
                        break;
 
                mbuf = rte_pktmbuf_alloc(pcap_q->mb_pool);
-               if (unlikely(mbuf == NULL))
-                       break;
+               if (unlikely(mbuf == NULL)) {
+                       pcap_q->rx_stat.err_pkts++;
+                       continue;
+               }
 
                if (header.caplen <= rte_pktmbuf_tailroom(mbuf)) {
                        /* pcap packet will fit in the mbuf, can copy it */
@@ -311,6 +313,7 @@ eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t 
nb_pkts)
                                                       mbuf,
                                                       packet,
                                                       header.caplen) == -1)) {
+                               pcap_q->rx_stat.err_pkts++;
                                rte_pktmbuf_free(mbuf);
                                break;
                        }
@@ -742,7 +745,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats 
*stats)
 {
        unsigned int i;
        unsigned long rx_packets_total = 0, rx_bytes_total = 0;
-       unsigned long rx_missed_total = 0;
+       unsigned long rx_missed_total = 0, rx_nombuf = 0;
        unsigned long tx_packets_total = 0, tx_bytes_total = 0;
        unsigned long tx_packets_err_total = 0;
        const struct pmd_internals *internal = dev->data->dev_private;
@@ -751,6 +754,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats 
*stats)
                        i < dev->data->nb_rx_queues; i++) {
                stats->q_ipackets[i] = internal->rx_queue[i].rx_stat.pkts;
                stats->q_ibytes[i] = internal->rx_queue[i].rx_stat.bytes;
+               rx_nombuf += internal->rx_queue[i].rx_stat.err_pkts;
                rx_packets_total += stats->q_ipackets[i];
                rx_bytes_total += stats->q_ibytes[i];
                rx_missed_total += queue_missed_stat_get(dev, i);
@@ -771,6 +775,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats 
*stats)
        stats->opackets = tx_packets_total;
        stats->obytes = tx_bytes_total;
        stats->oerrors = tx_packets_err_total;
+       stats->rx_nombuf = rx_nombuf;
 
        return 0;
 }
@@ -784,6 +789,7 @@ eth_stats_reset(struct rte_eth_dev *dev)
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
                internal->rx_queue[i].rx_stat.pkts = 0;
                internal->rx_queue[i].rx_stat.bytes = 0;
+               internal->rx_queue[i].rx_stat.err_pkts = 0;
                queue_missed_stat_reset(dev, i);
        }
 
-- 
2.30.1.windows.1