[dpdk-dev] [PATCH v13] eventdev: simplify Rx adapter event vector config

2021-08-17 Thread pbhagavatula
From: Pavan Nikhilesh Include vector configuration into the structure ``rte_event_eth_rx_adapter_queue_conf`` that is used to configure Rx adapter ethernet device Rx queue parameters. This simplifies event vector configuration as it avoids splitting configuration per Rx queue. Signed-off-by: Pav

[dpdk-dev] [PATCH v1 12/13] app/test: replace .sh scripts with .py scripts

2021-08-17 Thread Jie Zhou
- Add python scripts to get coremask and check hugepage config - Remove two corresponding .sh scripts - Replace calling of .sh with corresponding .py in meson.build Signed-off-by: Jie Zhou --- app/test/get-coremask.sh | 13 - app/test/get_coremask.py | 8 app/test/has-hugep

[dpdk-dev] [PATCH v1 13/13] app/test: enable subset of unit tests on Windows

2021-08-17 Thread Jie Zhou
In app/test/meson.build - Specify the subset of source files to compile on Windows - Specify the subset of tests to be enabled on Windows Signed-off-by: Jie Zhou --- app/test/meson.build | 859 ++- 1 file changed, 515 insertions(+), 344 deletions(-) diff

[dpdk-dev] [PATCH v1 11/13] app/test: remove two alarm_autotest cases

2021-08-17 Thread Jie Zhou
Remove two alarm_autotest test cases which do bogus range check on Windows. Signed-off-by: Jie Zhou --- app/test/test_alarm.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test/test_alarm.c b/app/test/test_alarm.c index b4034339b8..70e97a3109 100644 --- a/app/test/test_alarm.c +++

[dpdk-dev] [PATCH v1 10/13] app/test: differentiate a strerror on different OS

2021-08-17 Thread Jie Zhou
From: Jie Zhou On Windows, strerror returns just "Unknown error" for errnum greater than MAX_ERRNO, while linux and freebsd returns "Unknown error ", which is the current expectation for errno_autotest. Differentiate the error string on Windows. Otherwise, currently errno_autotest has a "duplicat

[dpdk-dev] [PATCH v1 05/13] app/test: replace POSIX specific code

2021-08-17 Thread Jie Zhou
- Include rte_os_shim.h - Replace sleep and usleep with rte_delay_us_sleep - #ifndef RTE_EXEC_ENV_WINDOWS for POSIX code only Signed-off-by: Jie Zhou --- app/test/packet_burst_generator.c | 1 + app/test/process.h| 4 +++- app/test/test.c | 4 app/test/test

[dpdk-dev] [PATCH v1 08/13] app/test: temporarily "skip" one cmdline test case

2021-08-17 Thread Jie Zhou
From: Jie Zhou cmdline tests pass except one failure at the test_cmdline_socket_fns test case with error: failed to open /dev/null for reading! Temporarily "skip" this case while enable all other passing cases. Issue is tracked internally and will add the corresponding case on Windows in future

[dpdk-dev] [PATCH v1 06/13] app/test: exclude ENOTSUP as failure

2021-08-17 Thread Jie Zhou
Check rte_errno to exclude ENOTSUP as failures in test_memory.c Signed-off-by: Jie Zhou --- app/test/test_memory.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test/test_memory.c b/app/test/test_memory.c index 7d5ae99bab..6f4fc02c03 100644 --- a/app/test/test_memo

[dpdk-dev] [PATCH v1 07/13] app/test: skip interrupt tests on Windows

2021-08-17 Thread Jie Zhou
Even though test_interrupts.c can compile on Windows, skip interrupt tests for now since majority of eal_interrupt on Windows are stubs. Will remove the skip after interrupt being fully enabled on Windows. Signed-off-by: Jie Zhou --- app/test/test_interrupts.c | 10 ++ 1 file changed, 10

[dpdk-dev] [PATCH v1 09/13] app/test: skip two logs_autotest cases on Windows

2021-08-17 Thread Jie Zhou
From: Jie Zhou DPDK logs_autotest on Windows failed at "dynamic log types" tests. The failures are on 2 test cases for rte_log_set_level_regexp API, due to regular expression is not supported on Windows in DPDK yet and regcomp/regexec are just stubs on Windows (in regex.h). In app\test\test_logs

[dpdk-dev] [PATCH v1 04/13] app/test: remove unnecessary headers

2021-08-17 Thread Jie Zhou
Remove unnecessary header inclusion Signed-off-by: Jie Zhou --- app/test/commands.c | 2 -- app/test/test.c | 1 - app/test/test_cmdline_lib.c | 1 - 3 files changed, 4 deletions(-) diff --git a/app/test/commands.c b/app/test/commands.c index 76f6ee5d23..82bd8bf474 100644 --

[dpdk-dev] [PATCH v1 01/13] lib: build libraries that some tests depend on

2021-08-17 Thread Jie Zhou
Enable building subset of libraries that tests depend on for Windows Signed-off-by: Jie Zhou --- lib/meson.build | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 1673ca4323..f109d6987d 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -81,10 +

[dpdk-dev] [PATCH v1 00/13] app/test: enable subset of tests on Windows

2021-08-17 Thread Jie Zhou
This patchset is to enable a subset of unit tests on Windows. It mainly includes: - Enable building libraries on Windows that some tests depend on - Replace POSIX specific codes - Fix some lib and tests per failures investigation - Replace .sh scripts with .py scripts for meson.build - Enable buil

[dpdk-dev] [PATCH v1 03/13] eal/windows: return ENOTSUP for not supported API

2021-08-17 Thread Jie Zhou
UT memory_autotest on Windows has 2 failed cases on eal APIs eal_memalloc_get_seg_fd and eal_memalloc_get_seg_fd_offset. These 2 APIs are not supported on Windows yet. Should return ENOTSUP such that in test_memory.c these 2 ENOTSUP cases will not be marked as failures, same as other ENOTSUP cases.

[dpdk-dev] [PATCH v1 02/13] driver/mempool: build mempool stack on Windows

2021-08-17 Thread Jie Zhou
From: Jie Zhou mempool_autotest failed on Windows at setting the "stack" handler test case. Per debugging, in rte_mempool_ops_table, there are only 6 ring ops registered, and no "stack" ops registered which caused the failure of rte_mempool_set_ops_byname and thus the test failed. Per code invest

[dpdk-dev] [PATCH v12] eventdev: simplify Rx adapter event vector config

2021-08-17 Thread pbhagavatula
From: Pavan Nikhilesh Include vector configuration into the structure ``rte_event_eth_rx_adapter_queue_conf`` used when configuring rest of the Rx adapter ethernet device Rx queue parameters. This simplifies event vector configuration as it avoids splitting configuration per Rx queue. Signed-off

[dpdk-dev] [PATCH v11] eventdev: simplify Rx adapter event vector config

2021-08-17 Thread pbhagavatula
From: Pavan Nikhilesh Include vector configuration into the structure ``rte_event_eth_rx_adapter_queue_conf`` used when configuring rest of the Rx adapter ethernet device Rx queue parameters. This simplifies event vector configuration as it avoids splitting configuration per Rx queue. Signed-off

[dpdk-dev] [PATCH v5] ethdev: add IPv4 and L4 checksum RSS offload types

2021-08-17 Thread Alvin Zhang
This patch defines new RSS offload types for IPv4 and L4(TCP/UDP/SCTP) checksum, which are required when users want to distribute packets based on the IPv4 or L4 checksum field. For example "flow create 0 ingress pattern eth / ipv4 / end actions rss types ipv4-chksum end queues end / end", this fl

Re: [dpdk-dev] [PATCH v1] net/ice: fix memzone leak when device init failed

2021-08-17 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Tuesday, August 17, 2021 17:19 > To: Wang, Haiyue > Cc: dev ; Zhang, Qi Z ; dpdk stable > ; Yang, > Qiming ; Xiaolong Ye ; Xing, > Beilei > ; Wang, Ying A > Subject: Re: [PATCH v1] net/ice: fix memzone leak when device init failed >

Re: [dpdk-dev] [PATCH v2] bus/vmbus: Fix crash when handling packets in secondary process

2021-08-17 Thread Long Li
In the 2nd part, the mapped addresses for the sub-channels in the second process should be the same as those mapped addresses in the primary process. You are correct on seting br->vbr to mapaddr. (To the same addresses used by the primary process) This can be done by recording the mapped address

Re: [dpdk-dev] [PATCH v6] eal: remove sys/queue.h from public headers.

2021-08-17 Thread Dmitry Kozlyuk
Hi William, just a few minor corrections remain, please see inline. 2021-08-14 02:51 (UTC+), William Tu: [...] > diff --git a/lib/eal/common/eal_common_devargs.c > b/lib/eal/common/eal_common_devargs.c > index 23aaf8b7e4..7edc6798fe 100644 > --- a/lib/eal/common/eal_common_devargs.c > +++ b/l

Re: [dpdk-dev] [PATCH] eal: allow hugetlbfs sub-directories

2021-08-17 Thread John Levon
On Mon, Aug 09, 2021 at 12:24:34PM +0100, John Levon wrote: > get_hugepage_dir() was implemented in such a way that a --huge-dir > option had to exactly match the mountpoint, but there's no reason for > this restriction: DPDK might not be the only user of hugepages, and > shouldn't assume it owns

[dpdk-dev] [PATCH] test/crypto-perf: support lookaside IPsec

2021-08-17 Thread Akhil Goyal
Added support for lookaside IPsec protocol offload. Supported cases: -AEAD -Cipher+auth Command used for testing: ./dpdk-test-crypto-perf -c 0xf -- --devtype crypto_octeontx2 --ptest throughput --optype ipsec --cipher-algo aes-cbc --pool-sz 16384 --cipher-op encrypt --cipher-key-sz 16 --cipher-iv-

[dpdk-dev] [RFC 20/21] crypto/mlx5: use HCA attributes from context device

2021-08-17 Thread Michael Baum
Use HCA attributes from context device structure, instead of query it for itself. Signed-off-by: Michael Baum --- drivers/crypto/mlx5/mlx5_crypto.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 4f390c8bf4..

[dpdk-dev] [RFC 21/21] net/mlx5: use HCA attributes from context device

2021-08-17 Thread Michael Baum
Use HCA attributes from context device structure, instead of query it for itself. Signed-off-by: Michael Baum --- drivers/net/mlx5/linux/mlx5_os.c | 7 +-- drivers/net/mlx5/windows/mlx5_os.c | 7 +-- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/net/mlx5/linux

[dpdk-dev] [RFC 19/21] compress/mlx5: use HCA attributes from context device

2021-08-17 Thread Michael Baum
Use HCA attributes from context device structure, instead of query it for itself. Signed-off-by: Michael Baum --- drivers/compress/mlx5/mlx5_compress.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx

[dpdk-dev] [RFC 15/21] mlx5: share context device structure between drivers

2021-08-17 Thread Michael Baum
Create and initialize context device structure ones in common probing, and give a pointer to it for each driver. Signed-off-by: Michael Baum --- drivers/common/mlx5/mlx5_common.c | 40 +-- drivers/common/mlx5/mlx5_common.h | 30 +--- drivers/common

[dpdk-dev] [RFC 18/21] vdpa/mlx5: use HCA attributes from context device

2021-08-17 Thread Michael Baum
Use HCA attributes from context device structure, instead of query it for itself. Signed-off-by: Michael Baum --- drivers/vdpa/mlx5/mlx5_vdpa.c | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5

[dpdk-dev] [RFC 16/21] common/mlx5: add HCA attributes to context device structure

2021-08-17 Thread Michael Baum
Add HCA attributes structure as a field of context device structure. It query in common probing, and check if the device supports the chosen classes. Signed-off-by: Michael Baum --- drivers/common/mlx5/mlx5_common.c | 67 ++- drivers/common/mlx5/mlx5_common.h | 9 +++

[dpdk-dev] [RFC 17/21] regex/mlx5: use HCA attributes from context device

2021-08-17 Thread Michael Baum
Use HCA attributes from context device structure, instead of query it for itself. Signed-off-by: Michael Baum --- drivers/regex/mlx5/mlx5_regex.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_rege

[dpdk-dev] [RFC 13/21] vdpa/mlx5: use context device structure

2021-08-17 Thread Michael Baum
Use common context device structure as a priv field. Signed-off-by: Michael Baum --- drivers/vdpa/mlx5/mlx5_vdpa.c | 185 drivers/vdpa/mlx5/mlx5_vdpa.h | 4 +- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 19 +-- drivers/vdpa/mlx5/mlx5_vdpa_lm.c| 6 +-

[dpdk-dev] [RFC 14/21] mlx5: update device sent to probing

2021-08-17 Thread Michael Baum
Use mlx5 device structure as a parameter to probe function. This structure will contain the shared device context. Signed-off-by: Michael Baum --- drivers/common/mlx5/mlx5_common.c | 4 ++-- drivers/common/mlx5/mlx5_common.h | 10 +++-- drivers/common/mlx5/mlx5_common_privat

[dpdk-dev] [RFC 10/21] net/mlx5: use context device structure

2021-08-17 Thread Michael Baum
Use common context device structure as a sh field. Signed-off-by: Michael Baum --- drivers/common/mlx5/mlx5_common.c| 2 +- drivers/common/mlx5/mlx5_common.h| 6 +- drivers/common/mlx5/version.map | 2 +- drivers/common/mlx5/windows/mlx5_common_os.c |

[dpdk-dev] [RFC 11/21] net/mlx5: move NUMA node field to context device

2021-08-17 Thread Michael Baum
Remove numa node field from sh structure, and use instead in context device structure. Signed-off-by: Michael Baum --- drivers/net/mlx5/mlx5.c | 3 +-- drivers/net/mlx5/mlx5.h | 1 - drivers/net/mlx5/mlx5_devx.c | 11 ++- drivers/net/mlx5/mlx5_txpp.c | 10 +- 4 files

[dpdk-dev] [RFC 12/21] common/mlx5: add ROCE disable in context device creation

2021-08-17 Thread Michael Baum
Add option to get IB device after disabling RoCE. It is relevant if there is vDPA class in device arguments list. Signed-off-by: Michael Baum --- drivers/common/mlx5/linux/mlx5_common_os.c | 126 - 1 file changed, 125 insertions(+), 1 deletion(-) diff --git a/drivers/common/

[dpdk-dev] [RFC 08/21] net/mlx5: improve probe function on Linux

2021-08-17 Thread Michael Baum
some improvements: - Update parameters for mlx5_device_bond_pci_match function. - Fix spelling and typos in comments. - Prevent breaking lines on drv logs. Signed-off-by: Michael Baum --- drivers/net/mlx5/linux/mlx5_os.c | 96 ++-- 1 file changed, 42 insertions(+), 54

[dpdk-dev] [RFC 06/21] regex/mlx5: use context device structure

2021-08-17 Thread Michael Baum
Use common context device structure as a priv field. Signed-off-by: Michael Baum --- drivers/regex/mlx5/mlx5_regex.c | 59 +++--- drivers/regex/mlx5/mlx5_regex.h | 23 + drivers/regex/mlx5/mlx5_regex_control.c | 12 ++--- drivers/regex/mlx5/mlx5_regex_f

[dpdk-dev] [RFC 09/21] net/mlx5: improve spawn function

2021-08-17 Thread Michael Baum
Add name as a parameter to spawn structure. Signed-off-by: Michael Baum --- drivers/net/mlx5/linux/mlx5_os.c | 24 ++-- drivers/net/mlx5/mlx5.c| 5 ++--- drivers/net/mlx5/mlx5.h| 1 + drivers/net/mlx5/windows/mlx5_os.c | 1 + 4 files changed, 14 i

[dpdk-dev] [RFC 07/21] net/mlx5: improve probe function on Windows

2021-08-17 Thread Michael Baum
some improvements: - use aux function to find match device. - use spawn a local variable instead of pointing to a list with a single member. Signed-off-by: Michael Baum --- drivers/common/mlx5/mlx5_common.h| 2 + drivers/common/mlx5/version.map | 1 + drivers/common/

[dpdk-dev] [RFC 02/21] net/mlx5: fix PCI probing error flow

2021-08-17 Thread Michael Baum
In PCI probing, there is internal probe function that is called several times for several PFs. When one of them fails, the previous PFs are not destroyed what nay cause a memory leak. Destroy them. Fixes: 08c2772fc747 ("net/mlx5: support list of representor PF") Cc: sta...@dpdk.org Signed-off-b

[dpdk-dev] [RFC 03/21] common/mlx5: add context device structure

2021-08-17 Thread Michael Baum
Add context device structure which contains ctx and pd of dievice. In addition, provides prepare and release functions for this structure. Signed-off-by: Michael Baum --- drivers/common/mlx5/linux/mlx5_common_os.c | 144 - drivers/common/mlx5/mlx5_common.c| 166

[dpdk-dev] [RFC 04/21] compress/mlx5: use context device structure

2021-08-17 Thread Michael Baum
Use common context device structure as a priv field. Signed-off-by: Michael Baum --- drivers/compress/mlx5/mlx5_compress.c | 110 ++ 1 file changed, 42 insertions(+), 68 deletions(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compres

[dpdk-dev] [RFC 05/21] crypto/mlx5: use context device structure

2021-08-17 Thread Michael Baum
Use common context device structure as a priv field. Signed-off-by: Michael Baum --- drivers/crypto/mlx5/mlx5_crypto.c | 114 ++ drivers/crypto/mlx5/mlx5_crypto.h | 4 +- drivers/crypto/mlx5/mlx5_crypto_dek.c | 5 +- 3 files changed, 49 insertions(+), 74 delet

[dpdk-dev] [PATCH] crypto/octeontx2: update min headroom and tailroom

2021-08-17 Thread Akhil Goyal
The driver consume 208B of tailroom but has min requirement as 8B and headroom needed is 48B, but minimum requirement is set as 24B. This patch correct minimum requirements which application should honour. Signed-off-by: Akhil Goyal --- drivers/crypto/octeontx2/otx2_cryptodev_ops.h | 4 ++-- 1 f

[dpdk-dev] [RFC 01/21] net/mlx5: fix shared device context creation error flow

2021-08-17 Thread Michael Baum
In shared device context creation, there are two validations after MR btree memory allocation. When one of them fails, the MR btree memory was not freed what caused a memory leak. Free it. Fixes: 632f0f19056f ("net/mlx5: manage shared counters in three-level table") Cc: sta...@dpdk.org Signed-o

[dpdk-dev] [RFC 00/21] mlx5: sharing global MR cache between drivers

2021-08-17 Thread Michael Baum
There are 5 classes of mlx5 drivers (net\eth, RegEx, vDPA, compress and crypto). The various drivers are registered under the common mlx5 driver and are managed by it. The common driver probing calls in a loop to the probe function of each driver registered to it. Each driver creates for itself all

Re: [dpdk-dev] [PATCH v4 2/2] net: added macro to extract MAC address bytes

2021-08-17 Thread Stephen Hemminger
On Tue, 17 Aug 2021 17:44:51 +0100 Ferruh Yigit wrote: > On 8/17/2021 4:25 PM, Stephen Hemminger wrote: > > On Tue, 17 Aug 2021 09:11:17 +0100 > > Ferruh Yigit wrote: > > > >> On 8/17/2021 12:03 AM, Stephen Hemminger wrote: > >>> On Mon, 16 Aug 2021 15:27:28 +0530 > >>> Aman Singh wrote: >

Re: [dpdk-dev] [PATCH v4 2/2] net: added macro to extract MAC address bytes

2021-08-17 Thread Ferruh Yigit
On 8/17/2021 4:25 PM, Stephen Hemminger wrote: > On Tue, 17 Aug 2021 09:11:17 +0100 > Ferruh Yigit wrote: > >> On 8/17/2021 12:03 AM, Stephen Hemminger wrote: >>> On Mon, 16 Aug 2021 15:27:28 +0530 >>> Aman Singh wrote: >>> Added macros to simplify print of MAC address. The six byte

Re: [dpdk-dev] [PATCH v3 0/7] Refactor the NFP PMD

2021-08-17 Thread Ferruh Yigit
On 7/29/2021 2:47 PM, Heinrich Kuhn wrote: > This patch set restructures the NFP PMD, aligning it more with the > common layout adopted by most other PMD's. Although the changes look > fairly large, functionally nothing is added or removed from the driver > and the existing code is mostly just reor

Re: [dpdk-dev] [PATCH v3 4/7] net/nfp: prototype common functions in header file

2021-08-17 Thread Ferruh Yigit
On 8/17/2021 3:44 PM, Ferruh Yigit wrote: > On 7/29/2021 2:47 PM, Heinrich Kuhn wrote: >> The majority of "ethdev" type functions are used for both PF devices and >> VF devices. Prototype these functions in the nfp_net_pmd header file in >> preparation of splitting PF and VF specific functions. >>

Re: [dpdk-dev] [dpdk-ci] [PATCH] version: 21.11-rc0

2021-08-17 Thread Ali Alnubani
Hi, > -Original Message- > From: David Marchand > Sent: Tuesday, August 17, 2021 6:20 PM > To: Lincoln Lavoie > Cc: NBU-Contact-Thomas Monjalon ; c...@dpdk.org; > dev ; Ray Kinsella ; Ali Alnubani > > Subject: Re: [dpdk-ci] [PATCH] version: 21.11-rc0 > > On Tue, Aug 17, 2021 at 2:04 PM

Re: [dpdk-dev] [PATCH v2 1/6] eal: introduce oops handling API

2021-08-17 Thread Stephen Hemminger
On Tue, 17 Aug 2021 20:57:50 +0530 Jerin Jacob wrote: > On Tue, Aug 17, 2021 at 8:39 PM Stephen Hemminger > wrote: > > > > On Tue, 17 Aug 2021 13:08:46 +0530 > > Jerin Jacob wrote: > > > > > On Tue, Aug 17, 2021 at 9:23 AM Stephen Hemminger > > > wrote: > > > > > > > > On Tue, 17 Aug 2021

Re: [dpdk-dev] [PATCH v2 01/15] ethdev: introduce shared Rx queue

2021-08-17 Thread Xueming(Steven) Li
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, August 17, 2021 5:33 PM > To: Xueming(Steven) Li > Cc: dpdk-dev ; Ferruh Yigit ; > NBU-Contact-Thomas Monjalon ; > Andrew Rybchenko > Subject: Re: [PATCH v2 01/15] ethdev: introduce shared Rx queue > > On Wed, Aug 11, 2021 at

Re: [dpdk-dev] [PATCH v2 1/6] eal: introduce oops handling API

2021-08-17 Thread Jerin Jacob
On Tue, Aug 17, 2021 at 8:39 PM Stephen Hemminger wrote: > > On Tue, 17 Aug 2021 13:08:46 +0530 > Jerin Jacob wrote: > > > On Tue, Aug 17, 2021 at 9:23 AM Stephen Hemminger > > wrote: > > > > > > On Tue, 17 Aug 2021 08:57:18 +0530 > > > wrote: > > > > > > > From: Jerin Jacob > > > > > > > > In

Re: [dpdk-dev] [PATCH v4 2/2] net: added macro to extract MAC address bytes

2021-08-17 Thread Stephen Hemminger
On Tue, 17 Aug 2021 09:11:17 +0100 Ferruh Yigit wrote: > On 8/17/2021 12:03 AM, Stephen Hemminger wrote: > > On Mon, 16 Aug 2021 15:27:28 +0530 > > Aman Singh wrote: > > > >> Added macros to simplify print of MAC address. > >> The six bytes of a MAC address are extracted in > >> a macro here,

Re: [dpdk-dev] [dpdk-ci] [PATCH] version: 21.11-rc0

2021-08-17 Thread David Marchand
On Tue, Aug 17, 2021 at 2:04 PM Lincoln Lavoie wrote: > > Hi David, > > ABI testing was disable / stopped on Friday in the Community CI lab. Patches > from before that for 21.11 would have still had the test run and could have > failures listed. I'm not sure if there is a way to "remove" those

Re: [dpdk-dev] [PATCH v2 01/15] ethdev: introduce shared Rx queue

2021-08-17 Thread Jerin Jacob
On Tue, Aug 17, 2021 at 5:01 PM Xueming(Steven) Li wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, August 17, 2021 5:33 PM > > To: Xueming(Steven) Li > > Cc: dpdk-dev ; Ferruh Yigit ; > > NBU-Contact-Thomas Monjalon ; > > Andrew Rybchenko > > Subject: Re: [

Re: [dpdk-dev] [PATCH v2 1/6] eal: introduce oops handling API

2021-08-17 Thread Stephen Hemminger
On Tue, 17 Aug 2021 13:08:46 +0530 Jerin Jacob wrote: > On Tue, Aug 17, 2021 at 9:23 AM Stephen Hemminger > wrote: > > > > On Tue, 17 Aug 2021 08:57:18 +0530 > > wrote: > > > > > From: Jerin Jacob > > > > > > Introducing oops handling API with following specification > > > and enable stub im

Re: [dpdk-dev] EAL: failed to parse device "XX:XX.X" on CentOS 7

2021-08-17 Thread Bruce Richardson
On Mon, Aug 16, 2021 at 07:13:54AM -0600, Thao Hull wrote: > Thank you! Will try that when I get back from vacation. Thao > > On Mon, Aug 16, 2021, 4:48 AM Mikulicz, Szymon (Nokia - PL/Krakow) < > szymon.mikul...@nokia.com> wrote: > > > Hi Thao, > > > > the original issue was resolved by updati

Re: [dpdk-dev] [PATCH v3 4/7] net/nfp: prototype common functions in header file

2021-08-17 Thread Ferruh Yigit
On 7/29/2021 2:47 PM, Heinrich Kuhn wrote: > The majority of "ethdev" type functions are used for both PF devices and > VF devices. Prototype these functions in the nfp_net_pmd header file in > preparation of splitting PF and VF specific functions. > > Signed-off-by: Heinrich Kuhn > Signed-off-by

Re: [dpdk-dev] [PATCH] build: fix install from arbitrary directory for meson 0.55

2021-08-17 Thread Bruce Richardson
On Wed, Aug 11, 2021 at 02:03:22AM +0300, Dmitry Kozlyuk wrote: > Install command for meson >= 0.55.0 referenced the script by a plain > string, assuming the build directory to be directly under the source > tree root. This resulted in an error when the assumption did not hold: > > c:\python\p

Re: [dpdk-dev] Windows community call: MoM 2021-08-04

2021-08-17 Thread Bruce Richardson
On Fri, Aug 06, 2021 at 04:17:32PM -0700, William Tu wrote: > On Thu, Aug 5, 2021 at 12:15 PM Dmitry Kozlyuk > wrote: > > > snip > > > # Porting OvS build system to meson (William Tu) > > > > Status: OvS compiles with some features disabled, with a lot of warnings. > > Issues: > > > > * vhost-us

Re: [dpdk-dev] [PATCH] net/mlx5: fix matching on eCPRI

2021-08-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dmitry Kozlyuk > Sent: Monday, August 9, 2021 5:27 PM > To: dev@dpdk.org > Cc: Bing Zhao ; sta...@dpdk.org; Matan Azrad > ; Shahaf Shuler ; Slava > Ovsiienko > Subject: [dpdk-dev] [PATCH] net/mlx5: fix matching on eCPRI > > When an ETH o

Re: [dpdk-dev] [PATCH] net/mlx5: fix mbufs replenishment check for zipped CQEs

2021-08-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, August 4, 2021 9:23 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: fix mbufs replenishment check for zipped CQEs > > A core dump is being ge

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion for inner tunnel VLAN

2021-08-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Lior Margalit > Sent: Tuesday, August 3, 2021 9:13 PM > To: Matan Azrad > Cc: dev@dpdk.org; Lior Margalit ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion for inner tunnel > VLAN > > The RSS expansion alg is

[dpdk-dev] [PATCH 5/5] test/crypto: add packets hard expiry tests

2021-08-17 Thread Anoob Joseph
Add tests to validate packets hard expiry handling. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 19 ++- app/test/test_cryptodev_security_ipsec.c | 22 +++--- app/test/test_cryptodev_security_ipsec.h | 1 + 3 files changed, 38 insert

[dpdk-dev] [PATCH 4/5] test/crypto: add packets soft expiry tests

2021-08-17 Thread Anoob Joseph
Add tests to validate packets soft expiry handling. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 21 +++-- app/test/test_cryptodev_security_ipsec.c | 18 -- app/test/test_cryptodev_security_ipsec.h | 4 +++- 3 files changed, 38 inser

[dpdk-dev] [PATCH 3/5] crypto/octeontx2: add checks for life configuration

2021-08-17 Thread Anoob Joseph
Lifetime tracking is not supported by hardware and is not implemented in software either. Return failure when lifetime is configured. Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/octeontx2/otx2_i

[dpdk-dev] [PATCH 2/5] common/cnxk: support lifetime configuration

2021-08-17 Thread Anoob Joseph
Add support for SA lifetime configuration. Expiry can be either in units of octets or packets. Also, updated cryptodev dequeue path to update crypto op result to indicate soft expiry. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_security.c | 70 +++

[dpdk-dev] [PATCH 1/5] security: add SA lifetime configuration

2021-08-17 Thread Anoob Joseph
Add SA lifetime configuration to register soft and hard expiry limits. Expiry can be in units of number of packets or bytes. Crypto op status is also updated to include new field, aux_flags, which can be used to indicate cases such as soft expiry in case of lookaside protocol operations. In case o

[dpdk-dev] [PATCH 0/5] Add SA lifetime in security

2021-08-17 Thread Anoob Joseph
Add SA lifetime configuration in security. SA lifetime tracking can be offloaded on supported PMDs. SA lifetime would cover soft & hard expiry in units of number of packets and bytes. When SA soft expiry happens, the packet is successfuly processed but with additional expiry notification. Crypto o

Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0

2021-08-17 Thread Jerin Jacob
On Tue, Aug 17, 2021 at 5:59 PM Bruce Richardson wrote: > > On Fri, Jul 30, 2021 at 01:05:48PM +0530, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Since meson 0.59.0 version, the extract_all_objects() API > > need to pass explicit boolean value. > > > > To remove the following warning[

Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0

2021-08-17 Thread Bruce Richardson
On Fri, Jul 30, 2021 at 01:05:48PM +0530, jer...@marvell.com wrote: > From: Jerin Jacob > > Since meson 0.59.0 version, the extract_all_objects() API > need to pass explicit boolean value. > > To remove the following warning[1], added explicit `true` for > extract_all_objects() use in codebase w

Re: [dpdk-dev] [PATCH 2/2] Allow the flow_classify example to add an ACL table for tcp.

2021-08-17 Thread Iremonger, Bernard
Hi Sowmini, > -Original Message- > From: Sowmini Varadhan > Sent: Thursday, August 12, 2021 9:18 PM > To: sowmin...@gmail.com; Iremonger, Bernard > ; dev@dpdk.org; sowmi...@gmail.com; > sovar...@linux.microsoft.com > Cc: tho...@monjalon.net > Subject: [PATCH 2/2] Allow the flow_classify e

Re: [dpdk-dev] [dpdk-ci] [PATCH] version: 21.11-rc0

2021-08-17 Thread Lincoln Lavoie
Hi David, ABI testing was disable / stopped on Friday in the Community CI lab. Patches from before that for 21.11 would have still had the test run and could have failures listed. I'm not sure if there is a way to "remove" those failure marks from patchworks. But, for all new patches since then,

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx

2021-08-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Li, Xiaoyun > Sent: Tuesday, August 17, 2021 4:54 AM > To: Nithin Dabilpuram > Cc: jer...@marvell.com; dev@dpdk.org; Raslan Darawsheh > ; sta...@dpdk.org > Subject: RE: [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx > > > > > -Original Messa

Re: [dpdk-dev] [PATCH 1/2] Hooks to allow the setting of filters on tcp flags

2021-08-17 Thread Iremonger, Bernard
Hi Sowmini, > -Original Message- > From: Sowmini Varadhan > Sent: Thursday, August 12, 2021 9:18 PM > To: sowmin...@gmail.com; Iremonger, Bernard > ; dev@dpdk.org; > sovar...@linux.microsoft.com > Cc: tho...@monjalon.net > Subject: [PATCH 1/2] Hooks to allow the setting of filters on tcp

Re: [dpdk-dev] [PATCH v1 0/2] Features for hns3 PMD

2021-08-17 Thread Ferruh Yigit
On 7/26/2021 11:59 AM, Min Hu (Connor) wrote: > This patch set contains two features: > add start/stop Tx datapath request for MP > support set link up/down for PF > > Huisong Li (2): > net/hns3: add start/stop Tx datapath request for MP > net/hns3: support set link up/down for PF > Series a

Re: [dpdk-dev] [PATCH v4 1/2] config/arm: split march cfg into arch and features

2021-08-17 Thread Juraj Linkeš
Resending, since there was an error when sending to Chengwen. > -Original Message- > From: Juraj Linkeš > Sent: Tuesday, August 17, 2021 12:57 PM > To: tho...@monjalon.net; david.march...@redhat.com; > bruce.richard...@intel.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com; fengc

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum

2021-08-17 Thread Nithin Dabilpuram
On Tue, Aug 17, 2021 at 01:43:27AM +, Li, Xiaoyun wrote: > > > > -Original Message- > > From: Nithin Dabilpuram > > Sent: Monday, August 16, 2021 18:56 > > To: Li, Xiaoyun > > Cc: jer...@marvell.com; dev@dpdk.org; jia@intel.com; sta...@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH v4 2/2] config/arm: make n2 'crypto' an optional feature

2021-08-17 Thread Juraj Linkeš
Not all Neoverse-N2 cpus must support the crypto feature/extension which makes it an optional feature. Only enable the feature for SoCs which support it. Signed-off-by: Juraj Linkeš --- v4: rebase --- config/arm/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/co

[dpdk-dev] [PATCH v4 1/2] config/arm: split march cfg into arch and features

2021-08-17 Thread Juraj Linkeš
Older compilers may not support all arch versions and all features that the target SoC supports, in which case it's better to figure out the highest arch version and features that the compiler supports. Implement a way to achieve this: 1. Find the highest arch version that the compiler supports, ke

[dpdk-dev] [PATCH v6] build: optional NUMA and cpu counts detection

2021-08-17 Thread Juraj Linkeš
Add an option to automatically discover the host's numa and cpu counts and use those values for a non cross-build. Give users the option to override the per-arch default values or values from cross files by specifying them on the command line with -Dmax_lcores and -Dmax_numa_nodes. Signed-off-by:

Re: [dpdk-dev] [PATCH v2 2/6] eal: oops handling API implementation

2021-08-17 Thread Jerin Jacob
On Tue, Aug 17, 2021 at 9:22 AM Stephen Hemminger wrote: > > On Tue, 17 Aug 2021 08:57:19 +0530 > wrote: > > > +#define oops_print(...) rte_log(RTE_LOG_ERR, RTE_LOGTYPE_EAL, __VA_ARGS__) > > It is problematic to call rte_log from a signal handler. > The malloc pool maybe corrupted and rte_log can

[dpdk-dev] [PATCH v5] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-08-17 Thread Jie Wang
The driver may change offloads info into dev->data->dev_conf in dev_configure which may cause port->dev_conf and port->rx_conf contain outdated values. This patch updates the offloads info if it changes to fix this issue. It adds a new API "rte_eth_dev_conf_info_get()" to help testpmd get device

Re: [dpdk-dev] [PATCH v2 06/15] app/testpmd: add common fwd wrapper function

2021-08-17 Thread Jerin Jacob
On Wed, Aug 11, 2021 at 7:35 PM Xueming Li wrote: > > From: Xiaoyu Min > > Added an inline common wrapper function for all fwd engines > which do the following in common: > > 1. get_start_cycles > 2. rte_eth_rx_burst(...,nb_pkt_per_burst) > 3. if rxq_share do forward_shared_rxq(), otherwise do fw

Re: [dpdk-dev] [PATCH v2 01/15] ethdev: introduce shared Rx queue

2021-08-17 Thread Jerin Jacob
On Wed, Aug 11, 2021 at 7:34 PM Xueming Li wrote: > > In current DPDK framework, each RX queue is pre-loaded with mbufs for > incoming packets. When number of representors scale out in a switch > domain, the memory consumption became significant. Most important, > polling all ports leads to high c

Re: [dpdk-dev] [PATCH v1] net/ice: fix memzone leak when device init failed

2021-08-17 Thread David Marchand
On Fri, Aug 13, 2021 at 8:45 AM Haiyue Wang wrote: > > When flow engine initialization or FXP resource reset failed, it needs > to free the memory zone and unregister the interrupt callback. > > Bugzilla ID: 752 > Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") > Fixes: 7615a6895009 (

[dpdk-dev] [PATCH v3 2/2] net/ice: fix default RSS field for IP fragment packets

2021-08-17 Thread Wenjun Wu
Previously, hash value is calculated by src IP address, dst IP address and IP ID. However, default RSS field only needs src and dst IP address. This patch removes IP ID from default RSS field for IP fragment packets to improve default RSS configuration. Fixes: 4027fffe86f4 ("net/ice: support defa

[dpdk-dev] [PATCH v3 1/2] net/iavf: fix default RSS field for IP fragment packets

2021-08-17 Thread Wenjun Wu
Previously, hash value is calculated by src IP address, dst IP address and IP ID. However, default RSS field only needs src and dst IP address. This patch removes IP ID from default RSS field for IP fragment packets to improve default RSS configuration. Fixes: 9e29a278bc0c ("net/iavf: support def

[dpdk-dev] [PATCH v3 0/2] fix default RSS field for IP fragment packets

2021-08-17 Thread Wenjun Wu
This patch set removes redundant default RSS field for both IPv4 and IPv6 fragment packets. Only src and dst address are needed. v3: * Rework commit log v2: * Rework commit log Wenjun Wu (2): net/iavf: fix default RSS field for IP fragment packets net/ice: fix default RSS field for IP fragmen

Re: [dpdk-dev] [PATCH 21.11 v2 0/3] octeontx build only on 64-bit Linux

2021-08-17 Thread David Marchand
On Thu, Mar 25, 2021 at 3:52 PM Thomas Monjalon wrote: > > This is a reorg of the patches from Pavan. > It has been discussed that it should wait for DPDK 21.11 > for ABI compatibility reason. > > Pavan Nikhilesh (3): > net/thunderx: enable build only on 64-bit Linux > common/octeontx: enable

Re: [dpdk-dev] EAL: failed to parse device "XX:XX.X" on CentOS 7

2021-08-17 Thread Thao Hull
Thank you! Will try that when I get back from vacation. Thao On Mon, Aug 16, 2021, 4:48 AM Mikulicz, Szymon (Nokia - PL/Krakow) < szymon.mikul...@nokia.com> wrote: > Hi Thao, > > the original issue was resolved by updating pkg-config. I compiled a new > version of it on our centos 7 setup. We a

Re: [dpdk-dev] [PATCH v2] test/func_reentrancy: free memzones after creating test case

2021-08-17 Thread David Marchand
On Sat, Jul 31, 2021 at 2:04 PM Joyce Kong wrote: > > Function reentrancy test limits maximum number of iterations > simultaneously, however it doesn't free the 'fr_test_once' > memzones after the fact, so introduce freeing 'fr_test_once' > in ring/mempool/hash/fbk/lpm_clean. > > Meanwhile, add th

Re: [dpdk-dev] [PATCH v4 2/2] net: added macro to extract MAC address bytes

2021-08-17 Thread Ferruh Yigit
On 8/17/2021 12:03 AM, Stephen Hemminger wrote: > On Mon, 16 Aug 2021 15:27:28 +0530 > Aman Singh wrote: > >> Added macros to simplify print of MAC address. >> The six bytes of a MAC address are extracted in >> a macro here, to improve code readablity. >> >> Signed-off-by: Aman Singh >> Reviewed

Re: [dpdk-dev] [PATCH] net/ice: fix wrong rxdid

2021-08-17 Thread Huang, ZhiminX
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, August 17, 2021 11:41 AM > To: Yang, Qiming > Cc: Huang, ZhiminX ; dev@dpdk.org; Zhang, > Qi Z ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix wrong rxdid > > Since DPDK 20.11 the default rxdid is changed from 16 to 22, but the

Re: [dpdk-dev] [PATCH RFC] net/virtio: Add virtio support for Windows.

2021-08-17 Thread David Marchand
On Sun, Aug 15, 2021 at 9:50 PM Dmitry Kozlyuk wrote: > > diff --git a/drivers/net/virtio/virtio_pci_ethdev.c > > b/drivers/net/virtio/virtio_pci_ethdev.c > > index 4083853c48..03e9dfab71 100644 > > --- a/drivers/net/virtio/virtio_pci_ethdev.c > > +++ b/drivers/net/virtio/virtio_pci_ethdev.c > >

[dpdk-dev] [PATCH v1 4/4] common/iavf: update the driver version

2021-08-17 Thread Haiyue Wang
Update the driver version to trace the change. Signed-off-by: Haiyue Wang --- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index 611fdcea94..89bdbc827e 100644 --- a/drivers/common/iavf/READM

[dpdk-dev] [PATCH v1 3/4] common/iavf: remove the FDIR query opcode

2021-08-17 Thread Haiyue Wang
The VIRTCHNL_OP_QUERY_FDIR_FILTER opcode is not used, so remove it. Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 38 -- 1 file changed, 38 deletions(-) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index c56c668cf

[dpdk-dev] [PATCH v1 2/4] common/iavf: add proto hdr field support for L4 checksum

2021-08-17 Thread Haiyue Wang
From: Alvin Zhang Add TCP/UDP/SCTP header checksum field selectors. Signed-off-by: Alvin Zhang Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index 9fa5e3e891.

  1   2   >