Re: [dpdk-dev] [PATCH v8] dmadev: introduce DMA device library

2021-07-19 Thread fengchengwen
Thanks Jerin, comment inline On 2021/7/20 13:03, Jerin Jacob wrote: > On Tue, Jul 20, 2021 at 6:48 AM Chengwen Feng wrote: >> >> This patch introduce 'dmadevice' which is a generic type of DMA >> device. >> >> The APIs of dmadev library exposes some generic operations which can >> enable configur

Re: [dpdk-dev] [PATCH 2/2] lib/security: add SA lifetime configuration

2021-07-19 Thread Anoob Joseph
Hi Akhil, Declan, Fan, Hemant, Konstantin, This patch & and a patch submitted by Archana earlier (http://patches.dpdk.org/project/dpdk/patch/20210630111248.746-1-march...@marvell.com/), aims at extending rte_crypto_op so that it can be used to communicate any warnings from the rte_security offl

[dpdk-dev] [PATCH 2/2] lib/security: add SA lifetime configuration

2021-07-19 Thread Anoob Joseph
Add SA lifetime configuration to register soft and hard expiry limits. Expiry can be in units of number of packets or bytes. Crypto op status is also updated to cover warnings indicating soft expiry in case of lookaside protocol operations. In case of soft expiry, the packets are successfully IPse

[dpdk-dev] [PATCH 1/2] lib/security: add IV generation

2021-07-19 Thread Anoob Joseph
Enable application to offload IV generation to PMD. In case of lookaside protocol offload, IV would be provided by application in rte_crypto_op. Allow offloading the same to PMD with such support. Signed-off-by: Anoob Joseph --- lib/security/rte_security.h | 14 ++ 1 file changed, 14

[dpdk-dev] [PATCH 0/2] Improvements to rte_security

2021-07-19 Thread Anoob Joseph
Add options for offloading - IV generation - SA lifetime With lookaside protocol (IPsec) offloads, application is expected to provide IV in rte_crypto_op. For cryptodevs which can generate true random, this operation can be offloaded. SA lifetime is used in tracking SA expiries and initiating SA

Re: [dpdk-dev] [PATCH v8] dmadev: introduce DMA device library

2021-07-19 Thread Jerin Jacob
On Tue, Jul 20, 2021 at 6:48 AM Chengwen Feng wrote: > > This patch introduce 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng > --- >

[dpdk-dev] [PATCH v3 8/8] test/rcu: use compiler atomics for data sync

2021-07-19 Thread Joyce Kong
Covert rte_atomic usages to compiler atomic built-ins in rcu_perf testcases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Stephen Hemminger --- app/test/test_rcu_qsbr_perf.c | 98 +-- 1 file changed, 49 insertions(+), 49 deletions(-) diff --git

[dpdk-dev] [PATCH v3 7/8] test/service_cores: use compiler atomics for lock sync

2021-07-19 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lock sync in service_cores testcases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Stephen Hemminger --- app/test/test_service_cores.c | 36 +++ 1 file changed, 20 insertions(+), 16 dele

[dpdk-dev] [PATCH v3 6/8] test/mempool_perf: use compiler atomics for lcores sync

2021-07-19 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcores sync in mempool_perf testcases. Meanwhile, remove unnecessary synchro init as it would be set to 0 when launching cores. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Stephen Hemminger --- app/test/test_mempool_p

[dpdk-dev] [PATCH v3 5/8] test/mempool: remove unused variable for lcores sync

2021-07-19 Thread Joyce Kong
Remove the unused synchro variable as there is no lcores sync in mempool function test. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Stephen Hemminger --- app/test/test_mempool.c | 5 - 1 file changed, 5 deletions(-) diff --git a/app/test/test_mempool.c b/app/test/test_me

[dpdk-dev] [PATCH v3 4/8] test/mcslock: use compiler atomics for lcores sync

2021-07-19 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcores sync in mcslock testcases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Stephen Hemminger --- app/test/test_mcslock.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/app/test/t

[dpdk-dev] [PATCH v3 3/8] test/rwlock: use compiler atomics for lcores sync

2021-07-19 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcores sync in rwlock testcases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Stephen Hemminger --- app/test/test_rwlock.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/app/test/test_rw

[dpdk-dev] [PATCH v3 2/8] test/spinlock: use compile atomics for lcores sync

2021-07-19 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcores sync in spinlock testcases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Stephen Hemminger --- app/test/test_spinlock.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/app/test/test_

[dpdk-dev] [PATCH v3 1/8] test/ticketlock: use compiler atomics for lcores sync

2021-07-19 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcores sync in ticketlock testcases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Stephen Hemminger --- app/test/test_ticketlock.c | 10 -- 1 file changed, 4 insertions(+), 6

[dpdk-dev] [PATCH v3 0/8] use compiler atomic builtins for test

2021-07-19 Thread Joyce Kong
Since atomic operations have been adopted in DPDK now[1], change rte_atomicNN_xxx APIs to compiler's atomic built-ins in test cases. [1] https://www.dpdk.org/blog/2021/03/26/dpdk-adopts-the-c11-memory-model/ v3: Change 'GCC atomic builtins' to 'compiler atomic builtins' as clang adopted the sam

Re: [dpdk-dev] [PATCH v2] vhost: fix assuming packed ring size is a power of 2

2021-07-19 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, July 7, 2021 6:30 PM > To: dev@dpdk.org; Jiang, Cheng1 ; Xia, Chenbo > > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH v2] vhost: fix assuming packed ring size is a power of 2 > > Unlike split ring, packed ring doe

Re: [dpdk-dev] [PATCH] net/virtio: fix refill order in packed ring datapath

2021-07-19 Thread Xia, Chenbo
> -Original Message- > From: Jiang, Cheng1 > Sent: Thursday, July 8, 2021 5:58 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Liu, Yong > ; Yang, YvonneX ; Jiang, Cheng1 > ; sta...@dpdk.org > Subject: [PATCH] net/virtio: fix refill order in packed ring da

Re: [dpdk-dev] [PATCH v3] vhost: allow to check in-flight packets for async vhost

2021-07-19 Thread Xia, Chenbo
> -Original Message- > From: Hu, Jiayu > Sent: Thursday, July 8, 2021 6:21 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Hu, Jiayu > > Subject: [PATCH v3] vhost: allow to check in-flight packets for async vhost > > This patch allows to check the amount of in-fligh

Re: [dpdk-dev] [PATCH] vhost: fix async packed ring batch datapath

2021-07-19 Thread Xia, Chenbo
> -Original Message- > From: Jiang, Cheng1 > Sent: Thursday, July 8, 2021 6:25 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Jiang, Cheng1 ; > sta...@dpdk.org > Subject: [PATCH] vhost: fix async packed ring batch datapath > > We assume

Re: [dpdk-dev] [PATCH v2] vhost: fix index overflow for packed ring in async vhost

2021-07-19 Thread Xia, Chenbo
> -Original Message- > From: Jiang, Cheng1 > Sent: Thursday, July 15, 2021 5:51 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Jiang, Cheng1 ; > sta...@dpdk.org > Subject: [PATCH v2] vhost: fix index overflow for packed ring in async vho

Re: [dpdk-dev] [PATCH v5] vhost: check header for legacy dequeue offload

2021-07-19 Thread Xia, Chenbo
> -Original Message- > From: Wang, Xiao W > Sent: Monday, June 21, 2021 4:21 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > david.march...@redhat.com > Cc: Jiang, Cheng1 ; dev@dpdk.org; Wang, Xiao W > ; sta...@dpdk.org > Subject: [PATCH v5] vhost: check header for legacy dequeue offl

[dpdk-dev] [PATCH v8] dmadev: introduce DMA device library

2021-07-19 Thread Chengwen Feng
This patch introduce 'dmadevice' which is a generic type of DMA device. The APIs of dmadev library exposes some generic operations which can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng --- v8: * fix pcie access port diagram doxygen problem. * fix typo. * fix c

[dpdk-dev] [PATCH v2] build: check AVX512 rather than compiler version

2021-07-19 Thread Liang Ma
From: Liang Ma GCC 6.3.0 has a known bug which related to _mm512_extracti64x4_epi64. Please reference https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82887 Some DPDK PMD avx512 version heavily use _mm512_extracti64x4_epi6, which cause building failure with debug buildtype. Therefore, it's helpful

Re: [dpdk-dev] [PATCH] eal: fix argument to rte_bsf32_safe

2021-07-19 Thread Stephen Hemminger
On Mon, 19 Jul 2021 10:15:34 -0700 Tyler Retzlaff wrote: > On Tue, Jul 13, 2021 at 01:12:21PM -0700, Stephen Hemminger wrote: > > The first argument to rte_bsf32_safe was incorrectly declared as > > a 64 bit value. This function only correctly handles on 32 bit values > > and the underlying funct

Re: [dpdk-dev] [PATCH v2] net/virtio: fix Rx scatter offload

2021-07-19 Thread Andrew Rybchenko
On 7/19/21 10:15 PM, Andrew Rybchenko wrote: From: Ivan Ilchenko Report Rx scatter offload capability depending on VIRTIO_NET_F_MRG_RXBUF. If Rx scatter is not requested, ensure that provided Rx buffers on each Rx queue are big enough to fit Rx packets up to configured MTU. Fixes: ce17eddefc2

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add UDP encapsulation for inline protocol

2021-07-19 Thread Akhil Goyal
> > > > > Subject: [PATCH 2/2] examples/ipsec-secgw: add UDP encapsulation for > > > inline protocol > > > > > > Adds support to allow udp-encap option for > > > RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL mode also. > > > > > > Signed-off-by: Srujana Challa > > > --- > > Acked-by: Akhil Goyal > > >

[dpdk-dev] [PATCH v2] net/virtio: fix Rx scatter offload

2021-07-19 Thread Andrew Rybchenko
From: Ivan Ilchenko Report Rx scatter offload capability depending on VIRTIO_NET_F_MRG_RXBUF. If Rx scatter is not requested, ensure that provided Rx buffers on each Rx queue are big enough to fit Rx packets up to configured MTU. Fixes: ce17eddefc20 ("ethdev: introduce Rx queue offloads API") C

Re: [dpdk-dev] [EXT] [v2] test: fix crypto_op length for sessionless case

2021-07-19 Thread Akhil Goyal
> Currently, private_data_offset for the sessionless is computed > wrongly which includes extra bytes added by > sizeof(struct rte_crypto_sym_xform) * 2. This causes buffer > overflow which leads to test application crash while freeing the > ops mempool. This patch provides fix for the same and als

Re: [dpdk-dev] [EXT] [PATCH v5] crypto/ccp: moving vdev to PCI driver

2021-07-19 Thread Akhil Goyal
> From: Amaranath Somalapuram > > drop all the code duplicating the PCI bus driver > develped for Enable IOMMU in vdev. > > Signed-off-by: Amaranath Somalapuram > I believe v5 is sent without any change. And you should supersede the previous version in patchworks. Please address the comments f

Re: [dpdk-dev] [PATCH 2/4] ethdev: move jumbo frame offload check to library

2021-07-19 Thread Ajit Khaparde
On Fri, Jul 9, 2021 at 10:30 AM Ferruh Yigit wrote: > Setting MTU bigger than RTE_ETHER_MTU requires the jumbo frame support, > and application should enable the jumbo frame offload support for it. > > When jumbo frame offload is not enabled by application, but MTU bigger > than RTE_ETHER_MTU is

Re: [dpdk-dev] [PATCH] eal: fix argument to rte_bsf32_safe

2021-07-19 Thread Tyler Retzlaff
On Tue, Jul 13, 2021 at 01:12:21PM -0700, Stephen Hemminger wrote: > The first argument to rte_bsf32_safe was incorrectly declared as > a 64 bit value. This function only correctly handles on 32 bit values > and the underlying function rte_bsf32 only accepts 32 bit values. > This was introduced whe

Re: [dpdk-dev] RHEL 7 support

2021-07-19 Thread Tyler Retzlaff
On Mon, Jul 12, 2021 at 05:34:21PM +, Honnappa Nagarahalli wrote: > > > > > > Hi, > > > > I would like to open a discussion about RHEL 7 support in DPDK. > > How long do we want to support it in new DPDK versions? > > Can we drop RHEL 7 support starting DPDK 21.11? > I think the concerns we

Re: [dpdk-dev] RFC enabling dll/dso for dpdk on windows

2021-07-19 Thread Tyler Retzlaff
On Mon, Jul 19, 2021 at 12:12:12PM +0300, Dmitry Kozlyuk wrote: > > > > mingw emutls just makes it compile allowing the variables to be exported, > > the binaries still won't work without loader support. or are you saying > > they do? > > > > > > > > No, it is not acceptable to add a generic fea

Re: [dpdk-dev] [PATCH] ethdev: fix representor port ID search by name

2021-07-19 Thread Xueming(Steven) Li
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, July 19, 2021 8:36 PM > To: Xueming(Steven) Li ; Ajit Khaparde > ; Somnath Kotur > ; John Daley ; Hyong Youb Kim > ; Beilei Xing > ; Qiming Yang ; Qi Zhang > ; Haiyue Wang > ; Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienk

Re: [dpdk-dev] [PATCH] app/testpmd: remove most uses of rte_eth_devices

2021-07-19 Thread Ferruh Yigit
On 7/15/2021 2:20 PM, Paulis Gributs wrote: > This patch removes most uses of the global variable rte_eth_devices > from testpmd. This was done to avoid using the object directly which > applications should not do. > > Most uses have been replaced with standard function calls, however > the use of

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-07-19 Thread Ferruh Yigit
On 7/19/2021 10:55 AM, Wang, Jie1X wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Friday, July 16, 2021 4:52 PM >> To: Li, Xiaoyun ; Wang, Jie1X ; >> dev@dpdk.org >> Cc: andrew.rybche...@oktetlabs.ru; sta...@dpdk.org >> Subject: Re: [dpdk-stable] [PATCH v4] app/testpmd:

Re: [dpdk-dev] [PATCH] eventdev: configure the Rx event buffer size

2021-07-19 Thread Jerin Jacob
On Mon, Jul 19, 2021 at 8:57 PM Kundapura, Ganapati wrote: > > Hi Jerin, HI Ganapati >Please find my response in lined. > > -Original Message- > From: Jerin Jacob > Sent: 19 July 2021 12:14 > To: Kundapura, Ganapati > Cc: Jayatheerthan, Jay ; dpdk-dev > Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH] ethdev: fix representor port ID search by name

2021-07-19 Thread Xueming(Steven) Li
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, July 19, 2021 4:46 PM > To: Xueming(Steven) Li ; Ajit Khaparde > ; Somnath Kotur > ; John Daley ; Hyong Youb Kim > ; Beilei Xing > ; Qiming Yang ; Qi Zhang > ; Haiyue Wang > ; Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienk

Re: [dpdk-dev] [PATCH] eventdev: configure the Rx event buffer size

2021-07-19 Thread Kundapura, Ganapati
Hi Jerin, Please find my response in lined. -Original Message- From: Jerin Jacob Sent: 19 July 2021 12:14 To: Kundapura, Ganapati Cc: Jayatheerthan, Jay ; dpdk-dev Subject: Re: [dpdk-dev] [PATCH] eventdev: configure the Rx event buffer size On Fri, Jul 16, 2021 at 10:33 PM Ganapati

Re: [dpdk-dev] [EXT] [PATCH v3] test/crypto: check if RAW API is supported

2021-07-19 Thread Akhil Goyal
> This patch adds checking if RAW API is supported at the start > of the test command "cryptodev_qat_raw_api_autotest". > > Signed-off-by: Adam Dybkowski > Acked-by: Fan Zhang > --- > app/test/test_cryptodev.c | 34 +- > 1 file changed, 33 insertions(+), 1 deleti

[dpdk-dev] [PATCH 7/7] doc: remove SDK info form individual dev guides

2021-07-19 Thread Hemant Agrawal
The prerequisite info is already present in the platform guide. No need to repeat it in individual dev guides. Signed-off-by: Hemant Agrawal --- doc/guides/cryptodevs/dpaa2_sec.rst | 6 -- doc/guides/eventdevs/dpaa2.rst | 6 -- doc/guides/nics/dpaa2.rst | 6 -- doc/gui

[dpdk-dev] [PATCH 6/7] net/dpaa2: add input validation

2021-07-19 Thread Hemant Agrawal
From: Vanshika Shukla This patch adds validation of the port id for rte_pmd_dpaa2_set_custom_hash API to check if the port is a valid DPAA2 port. Also handles some edge cases in the rte_pmd_dpaa2_mux_flow_create API. Signed-off-by: Vanshika Shukla Acked-by: Hemant Agrawal --- drivers/net/dpaa

[dpdk-dev] [PATCH 5/7] net/dpaa2: add per thread init PMD API

2021-07-19 Thread Hemant Agrawal
From: Nipun Gupta DPAA2 hardware require a hardware portal context. If a thread doing DPAA2 i/o do not have portal, it will allocate it on run-time. This may cause a delay in the datapath at run-time. To avoid it, it is better to allocate a hw context portal at the start of thread expected to do

[dpdk-dev] [PATCH 4/7] net/dpaa: add check for parsing default Rx queue

2021-07-19 Thread Hemant Agrawal
From: Rohit Raj Add check for the PCD queue from the kernel interface for default and error queues. Signed-off-by: Rohit Raj Acked-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 16 +++- drivers/bus/dpaa/include/fman.h | 7 +-- drivers/net/dpaa/dpaa_fmc.c

[dpdk-dev] [PATCH 3/7] bus/dpaa: reduce syscall usages

2021-07-19 Thread Hemant Agrawal
Reuse dpdk rte_gettid instead of syscall. It will help to reduce the dpaa portal allocation time. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 3 +-- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 9 - 2 files changed, 5 insertions(+), 7 deletions(-) diff --g

[dpdk-dev] [PATCH 2/7] net/dpaa: fix headroom in VSP case

2021-07-19 Thread Hemant Agrawal
From: Nipun Gupta This patch fixes providing the correct headroom size when VSP is enabled. Fixes: e4abd4ff183c ("net/dpaa: support virtual storage profile") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta --- drivers/net/dpaa/dpaa_flow.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(

[dpdk-dev] [PATCH 1/7] bus/dpaa: fix to use right type of memory free

2021-07-19 Thread Hemant Agrawal
if was allocated with rte_malloc, free shall be equivalent. Fixes: 4762b3d419c3 ("bus/dpaa: delay fman device list to bus probe") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/b

[dpdk-dev] [PATCH 0/7] NXP DPAAx fixes and improvements

2021-07-19 Thread Hemant Agrawal
This series add few minor fixes and enhancements for the NXP DPAAx drivers. Hemant Agrawal (3): bus/dpaa: fix to use right type of memory free bus/dpaa: reduce syscall usages doc: remove SDK info form individual dev guides Nipun Gupta (2): net/dpaa: fix headroom in VSP case net/dpaa2: a

Re: [dpdk-dev] [PATCH v6] dmadev: introduce DMA device library

2021-07-19 Thread Jerin Jacob
On Mon, Jul 19, 2021 at 6:50 PM fengchengwen wrote: > > Many thank. > > Most of the comment fixed in v7, and v7 still include implementation. Changes good to me. > > I did a thorough test of the implementation, so could you please review > the implementation also ? Wiil do > > One comment is m

Re: [dpdk-dev] [PATCH v6] dmadev: introduce DMA device library

2021-07-19 Thread fengchengwen
Many thank. Most of the comment fixed in v7, and v7 still include implementation. I did a thorough test of the implementation, so could you please review the implementation also ? One comment is modified as follows: COMMENT: >> +*| | |-- >> +

[dpdk-dev] [PATCH v7] dmadev: introduce DMA device library

2021-07-19 Thread Chengwen Feng
This patch introduce 'dmadevice' which is a generic type of DMA device. The APIs of dmadev library exposes some generic operations which can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng --- v7: * add rte_dmadev_get_dev_id API. * fix typo. * use the default macr

Re: [dpdk-dev] [EXT] [PATCH v2 16/16] test/crypto: check if RAW API is supported

2021-07-19 Thread Dybkowski, AdamX
Hi. Rebased patch sent as http://patches.dpdk.org/project/dpdk/patch/20210719123718.15960-1-adamx.dybkow...@intel.com/ Please mark v2 [16/16] as superseded. Thanks. Adam Dybkowski > -Original Message- > From: Akhil Goyal > Sent: Friday, 16 July, 2021 20:06 > To: Kusztal, ArkadiuszX ; d

[dpdk-dev] [PATCH v3] test/crypto: check if RAW API is supported

2021-07-19 Thread Adam Dybkowski
This patch adds checking if RAW API is supported at the start of the test command "cryptodev_qat_raw_api_autotest". Signed-off-by: Adam Dybkowski Acked-by: Fan Zhang --- app/test/test_cryptodev.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --gi

Re: [dpdk-dev] [PATCH] ethdev: fix representor port ID search by name

2021-07-19 Thread Andrew Rybchenko
On 7/19/21 2:54 PM, Xueming(Steven) Li wrote: -Original Message- From: Andrew Rybchenko Sent: Monday, July 19, 2021 4:46 PM To: Xueming(Steven) Li ; Ajit Khaparde ; Somnath Kotur ; John Daley ; Hyong Youb Kim ; Beilei Xing ; Qiming Yang ; Qi Zhang ; Haiyue Wang ; Matan Azrad ; Shah

[dpdk-dev] [PATCH] app/testpmd: fix TX checksum calculation for tunnel

2021-07-19 Thread Gregory Etelson
TX checksum of a tunnelled packet can be calculated for outer headers only or for both outer and inner parts. The calculation method is determined by application. If TX checksum calculation can be offloaded, hardware ignores existing checksum value and replaces it with an updated result. If TX chec

Re: [dpdk-dev] [PATCH v2] doc/guides: add details for new test structure

2021-07-19 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, July 16, 2021 2:40 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Doherty, Declan > ; acon...@redhat.com; Power, Ciara > > Subject: [PATCH v2] doc/guides: add details for new test structure > > The testing guide is now updated to in

Re: [dpdk-dev] [PATCH] ethdev: fix representor port ID search by name

2021-07-19 Thread Xueming(Steven) Li
> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, July 13, 2021 12:18 AM > To: Ajit Khaparde ; Somnath Kotur > ; John Daley > ; Hyong Youb Kim ; Beilei Xing > ; Qiming Yang > ; Qi Zhang ; Haiyue Wang > ; Matan Azrad > ; Shahaf Shuler ; Slava Ovsiienko > ; NBU-Contact-Th

Re: [dpdk-dev] [PATCH] buildtools: Check GCC version to avoid GCC 6.3.0 avx512 bug

2021-07-19 Thread Liang Ma
On Mon, Jul 19, 2021 at 09:38:14AM +0100, Bruce Richardson wrote: > On Sun, Jul 18, 2021 at 10:33:15AM +0100, Liang Ma wrote: > > On Sat, Jul 17, 2021 at 06:08:04PM -0700, Stephen Hemminger wrote: > > > On Sat, 17 Jul 2021 23:13:04 +0100 > > > Liang Ma wrote: > > > > > > > On Sat, Jul 17, 2021 at

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add UDP encapsulation for inline protocol

2021-07-19 Thread Ananyev, Konstantin
> > > Subject: [PATCH 2/2] examples/ipsec-secgw: add UDP encapsulation for > > inline protocol > > > > Adds support to allow udp-encap option for > > RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL mode also. > > > > Signed-off-by: Srujana Challa > > --- > Acked-by: Akhil Goyal > > @Konstantin Anany

Re: [dpdk-dev] RFC enabling dll/dso for dpdk on windows

2021-07-19 Thread Dmitry Kozlyuk
2021-07-18 20:45 (UTC-0700), Tyler Retzlaff: > On Fri, Jul 16, 2021 at 12:40:35PM +0300, Dmitry Kozlyuk wrote: > > 2021-07-08 18:03 (UTC-0700), Tyler Retzlaff: > > > On Thu, Jul 08, 2021 at 11:49:53PM +0300, Dmitry Kozlyuk wrote: > > > > Hi Tyler, > > > > > > > > 2021-07-08 12:21 (UTC-0700), T

Re: [dpdk-dev] [PATCH] vhost: fix async packed ring batch datapath

2021-07-19 Thread Maxime Coquelin
Hi, On 7/8/21 12:25 PM, Cheng Jiang wrote: > We assume that in the sync path, if there is no buffer wrap in the > avail descriptors fetched in a batch, there is no buffer wrap in the > used descriptors which need to be written back in this batch, but > this assumption is wrong in the async path si

[dpdk-dev] [PATCH v5] crypto/ccp: moving vdev to PCI driver

2021-07-19 Thread asomalap
From: Amaranath Somalapuram drop all the code duplicating the PCI bus driver develped for Enable IOMMU in vdev. Signed-off-by: Amaranath Somalapuram --- drivers/crypto/ccp/ccp_dev.c | 66 + drivers/crypto/ccp/ccp_dev.h | 3 +- drivers/crypto/ccp/rte_ccp_pmd.c | 163 +

Re: [dpdk-dev] [PATCH] ethdev: fix representor port ID search by name

2021-07-19 Thread Andrew Rybchenko
On 7/19/21 9:58 AM, Xueming(Steven) Li wrote: -Original Message- From: Andrew Rybchenko Sent: Tuesday, July 13, 2021 12:18 AM To: Ajit Khaparde ; Somnath Kotur ; John Daley ; Hyong Youb Kim ; Beilei Xing ; Qiming Yang ; Qi Zhang ; Haiyue Wang ; Matan Azrad ; Shahaf Shuler ; Slava O

Re: [dpdk-dev] [PATCH] buildtools: Check GCC version to avoid GCC 6.3.0 avx512 bug

2021-07-19 Thread Bruce Richardson
On Sun, Jul 18, 2021 at 10:33:15AM +0100, Liang Ma wrote: > On Sat, Jul 17, 2021 at 06:08:04PM -0700, Stephen Hemminger wrote: > > On Sat, 17 Jul 2021 23:13:04 +0100 > > Liang Ma wrote: > > > > > On Sat, Jul 17, 2021 at 10:48:49AM -0700, Stephen Hemminger wrote: > > > > On Sat, 17 Jul 2021 18:08:

[dpdk-dev] [PATCH v6 3/3] vhost: add thread unsafe async registeration functions

2021-07-19 Thread Jiayu Hu
This patch adds thread unsafe version for async register and unregister functions. Signed-off-by: Jiayu Hu Reviewed-by: Chenbo Xia --- doc/guides/prog_guide/vhost_lib.rst | 16 lib/vhost/rte_vhost_async.h | 41 ++ lib/vhost/version.map | 4 + lib/vhost/vho

[dpdk-dev] [PATCH v6 2/3] vhost: rework async configuration structure

2021-07-19 Thread Jiayu Hu
This patch reworks the async configuration structure to improve code readability. In addition, add preserved padding fields on the structure for future usage. Signed-off-by: Jiayu Hu Reviewed-by: Chenbo Xia --- doc/guides/prog_guide/vhost_lib.rst | 21 ++ examples/vhost/main.c

[dpdk-dev] [PATCH v6 1/3] vhost: fix lock on device readiness notification

2021-07-19 Thread Jiayu Hu
The vhost notifies the application of device readiness via vhost_user_notify_queue_state(), but calling this function is not protected by the lock. This patch is to make this function call lock protected. Fixes: d0fcc38f5fa4 ("vhost: improve device readiness notifications") Cc: sta...@dpdk.org Si

[dpdk-dev] [PATCH v6 0/3] provide thread unsafe async registration functions

2021-07-19 Thread Jiayu Hu
Lock protection is needed during the vhost notifies the application of device readiness, so the first patch adds lock protection. In addition, the second patch reworks async feature structure to improve readability. After performing locking, existed async vhost registration functions will cause dea

Re: [dpdk-dev] [PATCH] net/virtio: fix refill order in packed ring datapath

2021-07-19 Thread Maxime Coquelin
On 7/8/21 11:58 AM, Cheng Jiang wrote: > The front-end should refill the descriptor with the mbuf indicated by > the buff_id rather then the index of used descriptor. Back-end may > return buffers out of order if async copy mode is enabled. > > When initializing rxq, refill the descriptors in o

[dpdk-dev] [PATCH v6 5/5] doc: update doc for inflight packets clear API in vhost lib

2021-07-19 Thread Cheng Jiang
Update the program guide and release notes for inflight packets clear API in vhost lib. Signed-off-by: Cheng Jiang --- doc/guides/prog_guide/vhost_lib.rst| 5 + doc/guides/rel_notes/release_21_08.rst | 5 + 2 files changed, 10 insertions(+) diff --git a/doc/guides/prog_guide/vhost_l

[dpdk-dev] [PATCH v6 4/5] examples/vhost: handle memory hotplug for async vhost

2021-07-19 Thread Cheng Jiang
When the guest memory is hotplugged, the vhost application which enables DMA acceleration must stop DMA transfers before the vhost re-maps the guest memory. To accomplish that, we need to do these changes in the vhost sample: 1. add inflight packets count. 2. add vring_state_changed() callback. 3.

[dpdk-dev] [PATCH v6 3/5] vhost: handle memory hotplug for async vhost

2021-07-19 Thread Cheng Jiang
From: Jiayu Hu When the guest memory is hotplugged, the vhost application which enables DMA acceleration must stop DMA transfers before the vhost re-maps the guest memory. This patch is to notify the vhost application of stopping DMA transfers. Signed-off-by: Jiayu Hu --- lib/vhost/vhost_user

[dpdk-dev] [PATCH v6 2/5] vhost: add unsafe API to clear packets in async vhost

2021-07-19 Thread Cheng Jiang
Applications need to stop DMA transfers and finish all the inflight packets when in VM memory hot-plug case and async vhost is used. This patch is to provide an unsafe API to clear inflight packets which are submitted to DMA engine in vhost async data path. Signed-off-by: Cheng Jiang --- lib/vho

[dpdk-dev] [PATCH v6 1/5] vhost: fix async vhost ops return type

2021-07-19 Thread Cheng Jiang
The async vhost callback ops should return negative value when there are something wrong in the callback, so the return type should be changed into int32_t. The issue in vhost example is also fixed. Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring") Fixes: 819a71685826 ("vhost:

[dpdk-dev] [PATCH v6 0/5] vhost: handle memory hotplug for async vhost

2021-07-19 Thread Cheng Jiang
When the guest memory is hotplugged, the vhost application which enables DMA acceleration must stop DMA transfers before the vhost re-maps the guest memory. This patch set is to provide an unsafe API to drain inflight pkts which are submitted to DMA engine in vhost async data path, and notify the

Re: [dpdk-dev] [PATCH v2 01/14] common/mlx5: add common device driver

2021-07-19 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Monday, July 19, 2021 2:29 AM > To: Xueming(Steven) Li > Cc: Slava Ovsiienko ; dev@dpdk.org; Xueming(Steven) > Li ; Matan Azrad > ; Shahaf Shuler ; Ray Kinsella > > Subject: Re: [dpdk-dev] [PATCH v2 01/14] common/mlx5: add common

Re: [dpdk-dev] [PATCH v5 3/5] vhost: handle memory hotplug for async vhost

2021-07-19 Thread Hu, Jiayu
> -Original Message- > From: Xia, Chenbo > Sent: Monday, July 19, 2021 1:19 PM > To: Jiang, Cheng1 ; maxime.coque...@redhat.com; > Hu, Jiayu > Cc: dev@dpdk.org; Yang, YvonneX > Subject: RE: [PATCH v5 3/5] vhost: handle memory hotplug for async vhost > > Hi Cheng & Jiayu, > > > -O

[dpdk-dev] Call for help - fixes for 19.11.x in regard to new toolchains, kernels ...

2021-07-19 Thread Christian Ehrhardt
Hello everyone and maintainers in particular, I wanted to use this chance for an extra call for help before we later on this year call 19.11 EOL and done. There have been a bunch of issues found in the 19.11 testing. We have had a few extra respins of 19.11.9 this time which resolved a few of the

[dpdk-dev] [dpdk-announce] DPDK 19.11.9 released

2021-07-19 Thread Christian Ehrhardt
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-19.11.9.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=19.11 The full release notes can be found at: https://doc.dpdk.org/guides-19.11/rel_notes/release_19_11.html#id25 Thanks to ever

Re: [dpdk-dev] [PATCH v5 2/3] vhost: rework async configuration structure

2021-07-19 Thread Maxime Coquelin
On 7/16/21 9:51 PM, Jiayu Hu wrote: > This patch reworks the async configuration structure to improve code > readability. In addition, add preserved padding fields on the structure > for future usage. > > Signed-off-by: Jiayu Hu > --- > doc/guides/prog_guide/vhost_lib.rst | 21 +--

Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-07-19 Thread Chengchang Tang
On 2021/7/18 1:53, Stephen Hemminger wrote: > On Sun, 25 Apr 2021 21:02:22 +0800 > "Min Hu (Connor)" wrote: > >> snprintf(file_name, MAX_FILE_NAME_SZ, "%s-port%u", >> +file_prefix, i); >> +fp_regs = fopen(file_name, "wb"); >> +if