Many thank. Most of the comment fixed in v7, and v7 still include implementation.
I did a thorough test of the implementation, so could you please review the implementation also ? One comment is modified as follows: COMMENT: >> + * | | | ------------------ >> + * | |DMA| | | ------ >> + * | | | | |--------| EP | >> + * | | |--------| PCIE Core2 | ------ >> + * | | | | | ------ >> + * | | | | |--------| EP | >> + * | | | | | ------ >> + * | ----- ------------------ > > > This diagram does not show correctly in doxygen. Please fix it. REPLY: I can't find the right way to show it as correctly except split them to two part (one with doxygen format, and the other not), so if you have a good idea, please let me know, thanks. On 2021/7/19 14:21, Jerin Jacob wrote: > On Mon, Jul 19, 2021 at 9:02 AM Chengwen Feng <fengcheng...@huawei.com> wrote: >> >> This patch introduce 'dmadevice' which is a generic type of DMA >> device. >> >> The APIs of dmadev library exposes some generic operations which can >> enable configuration and I/O with the DMA devices. >> >> Signed-off-by: Chengwen Feng <fengcheng...@huawei.com> > > > The API specification aspects look pretty good to me. > > Some minor comments are below. You can add my Acked by on future version > API header file where you will split the patch. > [snip]
