Re: [dpdk-dev] [PATCH] Add Armv7 support

2021-06-23 Thread Ruifeng Wang
From: Supriya Shekhar Mane Sent: Thursday, June 24, 2021 2:21 PM To: Ruifeng Wang Cc: tho...@monjalon.net; Chandrakant Sharpa ; dev@dpdk.org; Zaheer R M ; Gurusidhesh G H ; david.march...@redhat.com; bruce.richard...@intel.com; Jan Viktorin ; jer...@marvell.com; Honnappa Nagarahalli ; nd Su

Re: [dpdk-dev] [RFC] toolchain specific macro expansion

2021-06-23 Thread Thomas Monjalon
23/06/2021 20:26, Tyler Retzlaff: > today rte_common.h defines common macros for use by dpdk and consuming > applications. most expansions are specific to the gcc toolchain. > > example > // lib/eal/include/rte_common.h > > /** > * Hint never returning function > */ > #define __rte_noreturn __a

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-23 Thread Jerin Jacob
On Wed, Jun 23, 2021 at 7:50 PM Bruce Richardson wrote: > > On Wed, Jun 23, 2021 at 05:10:22PM +0530, Jerin Jacob wrote: > > On Wed, Jun 23, 2021 at 3:07 PM Bruce Richardson > > wrote: > > > > > > On Wed, Jun 23, 2021 at 12:51:07PM +0530, Jerin Jacob wrote: > > > > On Wed, Jun 23, 2021 at 9:00 AM

Re: [dpdk-dev] [PATCH v4 2/2] bus/auxiliary: introduce auxiliary bus

2021-06-23 Thread Thomas Monjalon
23/06/2021 16:52, Xueming(Steven) Li: > From: Thomas Monjalon > > 23/06/2021 01:50, Xueming(Steven) Li: > > > From: Thomas Monjalon > > > > 13/06/2021 14:58, Xueming Li: > > > > > --- /dev/null > > > > > +++ b/drivers/bus/auxiliary/version.map > > > > > @@ -0,0 +1,7 @@ > > > > > +EXPERIMENTAL { >

Re: [dpdk-dev] [PATCH] Add Armv7 support

2021-06-23 Thread Supriya Shekhar Mane
Hi Ruifeng, > On Wed, Jun 23, 2021 at 12:05 PM Ruifeng Wang wrote: > > Do you have any plan on CI? > I don't think DPDK Lab has Armv7 hardware to run tests. Yes, we do have plans for CI for armv7, We are currently conducting our testing with WPJ419 platform. I would like to note what all things

Re: [dpdk-dev] [PATCH] kni: fix crash on userspace VA for segmented packets

2021-06-23 Thread Ajit Khaparde
On Tue, Jun 22, 2021 at 5:39 AM Ferruh Yigit wrote: > > When IOVA=VA, address translation for segmented packets is wrong, it > assumes the address in the mbuf->next is physical address, not VA > address. > > Fixing the address translation to work both PA & VA mode. > > Fixes: e73831dc6c26 ("kni: s

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] kni: fix mbuf allocation for alloc FIFO

2021-06-23 Thread Ajit Khaparde
On Tue, Jun 22, 2021 at 5:44 AM wangyunjian wrote: > > From: Yunjian Wang > > In kni_allocate_mbufs(), we alloc mbuf for alloc_q as this code. > allocq_free = (kni->alloc_q->read - kni->alloc_q->write - 1) \ > & (MAX_MBUF_BURST_NUM - 1); > The value of allocq_free maybe zero, for

Re: [dpdk-dev] [PATCH v4 1/2] power: add support for cppc cpufreq

2021-06-23 Thread Richael Zhuang
> -Original Message- > From: David Hunt > Sent: Wednesday, June 23, 2021 10:10 PM > To: Richael Zhuang ; dev@dpdk.org > Cc: yux.ji...@intel.com > Subject: Re: [PATCH v4 1/2] power: add support for cppc cpufreq > > Hi Richael > > On 23/6/2021 4:55 AM, Richael Zhuang wrote: > > Currently

[dpdk-dev] [PATCH v1] lib/eal: enforce alarm APIs parameters check

2021-06-23 Thread Jie Zhou
From: Jie Zhou lib/eal alarm APIs rte_eal_alarm_set and rte_eal_alarm_cancel on Windows do not check parameters to fail fast for invalid parameters, which captured by DPDK UT alarm_autotest. Enforce Windows lib/eal alarm APIs parameters check and log invalid parameter info. Signed-off-by: Jie Z

[dpdk-dev] [PATCH v14 5/9] app/testpmd: resolve name collisions

2021-06-23 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman Acked-by: Dmitry Kozlyuk --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test-

[dpdk-dev] [PATCH v14 9/9] app/testpmd: enable building testpmd on Windows

2021-06-23 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman Acked-by: Dmitry Kozlyuk --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app

[dpdk-dev] [PATCH v14 8/9] app/testpmd: fix unused function warnings

2021-06-23 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/config.c | 82

[dpdk-dev] [PATCH v14 7/9] app/testpmd: replace POSIX specific code

2021-06-23 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now - Include rte_os_shim.h in testpmd.h - Remove redunda

[dpdk-dev] [PATCH v14 6/9] app/testpmd: fix parse_fec_mode return type name

2021-06-23 Thread Jie Zhou
Replace parse_fec_mode misleading return type name mode with fec_capa Fixes: b19da32e3151 ("app/testpmd: add FEC command") Cc: sta...@dpdk.org Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h | 2 +-

[dpdk-dev] [PATCH v14 3/9] eal/windows: add device event stubs

2021-06-23 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman Acked-by: Dmitry Kozlyuk --- lib/eal/windows/eal_dev.c | 33 + lib/eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) cre

[dpdk-dev] [PATCH v14 4/9] eal/Windows: add clock_gettime on Windows

2021-06-23 Thread Jie Zhou
Add clock_gettime on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 33 +++ 1 file changed, 33 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h

[dpdk-dev] [PATCH v14 0/9] app/testpmd: enable testpmd on Windows

2021-06-23 Thread Jie Zhou
This patchset is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that testpmd depends on - Add necessary macros required by testpmd on Windows in rte_os_shim.h - Add device event stubs for Windows - Resolve name collisions with Windows types - Add clock_gett

[dpdk-dev] [PATCH v14 2/9] eal/windows: add necessary macros

2021-06-23 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/i

[dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

2021-06-23 Thread Jie Zhou
Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 4a64756a68..1673ca4323 100644 --- a/lib/meson.build +++ b/lib/meso

Re: [dpdk-dev] [PATCH v13 09/10] app/testpmd: fix unused function warnings

2021-06-23 Thread Jie Zhou
On Mon, Jun 21, 2021 at 02:30:53AM +0300, Dmitry Kozlyuk wrote: > 2021-05-05 12:12 (UTC-0700), Jie Zhou: > > Function print_fdir_mask and print_fdir_flex_payload is only called > > when either i40e or ixgbe presents. Add #if defined to remove > > "unused function" compilation warning. > > > > Sign

Re: [dpdk-dev] [PATCH v13 08/10] app/testpmd: fix headers inclusion

2021-06-23 Thread Jie Zhou
On Mon, Jun 21, 2021 at 02:30:48AM +0300, Dmitry Kozlyuk wrote: > 2021-05-05 12:12 (UTC-0700), Jie Zhou: > > - Include rte_os_shim.h in testpmd.h > > - Remove redundant headers > > > > Signed-off-by: Jie Zhou > > Signed-off-by: Jie Zhou > > Acked-by: Tal Shnaiderman > > It would be logical to

Re: [dpdk-dev] [PATCH v13 04/10] eal/Windows: add clock_gettime on Windows

2021-06-23 Thread Jie Zhou
On Mon, Jun 21, 2021 at 02:30:36AM +0300, Dmitry Kozlyuk wrote: > 2021-05-05 12:12 (UTC-0700), Jie Zhou: > > Add clock_gettime on Windows in rte_os_shim.h > > > > Signed-off-by: Jie Zhou > > Signed-off-by: Jie Zhou > > --- > > lib/eal/windows/include/rte_os_shim.h | 38 +

[dpdk-dev] [PATCH v2 2/2] drivers: add octeontx crypto adapter data path

2021-06-23 Thread Shijith Thotton
Added support for crypto adapter OP_FORWARD mode. As OcteonTx CPT crypto completions could be out of order, each crypto op is enqueued to CPT, dequeued from CPT and enqueued to SSO one-by-one. Signed-off-by: Shijith Thotton --- doc/guides/rel_notes/release_21_08.rst| 4 + drivers/comm

[dpdk-dev] [PATCH v2 1/2] drivers: add octeontx crypto adapter framework

2021-06-23 Thread Shijith Thotton
Set crypto adapter event device slow-path call backs. Signed-off-by: Shijith Thotton --- drivers/crypto/octeontx/meson.build | 1 + drivers/crypto/octeontx/otx_cryptodev.c | 4 ++ drivers/crypto/octeontx/otx_cryptodev.h | 4 -- .../crypto/octeontx/otx_cryptodev_hw_access

[dpdk-dev] [PATCH v2 0/2] OCTEONTX crypto adapter support

2021-06-23 Thread Shijith Thotton
Below patches add crypto adapter OP_FORWARD support for OCTEON TX PMD. v1: - Build fixes for 32-bit arch. Shijith Thotton (2): drivers: add octeontx crypto adapter framework drivers: add octeontx crypto adapter data path doc/guides/rel_notes/release_21_08.rst| 4 + drivers/common/

Re: [dpdk-dev] [PATCH v13 02/10] eal/windows: add necessary macros

2021-06-23 Thread Jie Zhou
On Mon, Jun 21, 2021 at 02:28:27AM +0300, Dmitry Kozlyuk wrote: > 2021-05-05 12:12 (UTC-0700), Jie Zhou: > > Add required macros by testpmd on Windows in rte_os_shim.h > > > > Signed-off-by: Jie Zhou > > Signed-off-by: Jie Zhou > > Acked-by: Tal Shnaiderman > > --- > > lib/eal/windows/include/

[dpdk-dev] [PATCH] bus/pci: Add VA support for PowerVM system LPARs

2021-06-23 Thread David Christensen
Add IOMMU detection logic for PowerVM LPARs. PowerNV $ cat /proc/cpuinfo ... timebase : 51200 platform : PowerNV model: 8335-GTW PowerVM LPAR $ cat /proc/cpuinfo ... timebase     : 51200 platform     : pSeries model: IBM,9009-22A machine  : CHRP IBM,9009-22A MM

[dpdk-dev] [PATCH] net/memif: replace memcpy() with rte_memcpy() to improve perf

2021-06-23 Thread David Christensen
Replacing memcpy() with rte_memcpy() improved 64 byte packet performance by 33% on a POWER9 system and by 10% on an x86_64 system. Signed-off-by: David Christensen --- v2: Fixed last patch which was bungled due to a bad local git squash drivers/net/memif/rte_eth_memif.c | 4 ++-- 1 file changed

Re: [dpdk-dev] [PATCH 0/4] net/bnxt: various fixes

2021-06-23 Thread Ajit Khaparde
On Wed, Jun 16, 2021 at 11:09 AM Lance Richardson wrote: > > Several fixes for the bnxt PMD: >- Fix NUMA-aware memory allocations. >- Fix transmit descriptor status implementation. >- Fix handling of transmit completions in non-vector path. >- Remove dead code. > > Lance Richardson

Re: [dpdk-dev] [PATCH] doc: note KNI alternatives and deprecation plan

2021-06-23 Thread Stephen Hemminger
On Wed, 23 Jun 2021 18:31:42 +0100 Ferruh Yigit wrote: > Add a note that KNI kernel module will be moved to dpdk-kmods git repo > and there is a long term plan to deprecate it. > > Also add some more details on the alternatives to KNI and cons of the > KNI against these alternatives. > > Signed

[dpdk-dev] [RFC] toolchain specific macro expansion

2021-06-23 Thread Tyler Retzlaff
today rte_common.h defines common macros for use by dpdk and consuming applications. most expansions are specific to the gcc toolchain. example // lib/eal/include/rte_common.h /** * Hint never returning function */ #define __rte_noreturn __attribute__((noreturn)) there is an anticipated need r

[dpdk-dev] [PATCH v3] tests/cmdline: fix memory leaks

2021-06-23 Thread ohilyard
From: Owen Hilyard Fixes for a few memory leaks in the cmdline_autotest unit test. All of the leaks were related to not freeing the commandline struct after testing had completed. Fixes: dbb860e03e ("cmdline: tests") Signed-off-by: Owen Hilyard Reviewed-by: David Marchand --- app/test/test_

[dpdk-dev] [PATCH] doc: note KNI alternatives and deprecation plan

2021-06-23 Thread Ferruh Yigit
Add a note that KNI kernel module will be moved to dpdk-kmods git repo and there is a long term plan to deprecate it. Also add some more details on the alternatives to KNI and cons of the KNI against these alternatives. Signed-off-by: Ferruh Yigit --- doc/guides/nics/tap.rst

[dpdk-dev] [PATCH v2] flow_classify: fix leaking rules on delete

2021-06-23 Thread ohilyard
From: Owen Hilyard Rules in a classify table were not freed if the table had a delete function. Fixes: be41ac2a3 ("flow_classify: introduce flow classify library") Signed-off-by: Owen Hilyard --- lib/flow_classify/rte_flow_classify.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH] net/memif: replace memcpy() with rte_memcpy() to improve perf

2021-06-23 Thread Stephen Hemminger
On Wed, 23 Jun 2021 09:49:35 -0700 David Christensen wrote: > Replacing memcpy() with rte_memcpy() improved 64 byte packet > performance by 33% on a POWER9 system and by 10% on an x86_64 > system. I see rte_memcpy was already used in the patch diff > Signed-off-by: David Christensen > --- > d

Re: [dpdk-dev] doc: update dependency requirement for some PMDs

2021-06-23 Thread Zhang, Roy Fan
Hi Stephen, You are right, but without this we cannot rule out the chance that the user downloaded DPDK, reverted to any version earlier than 20.11 (where make and meson co-existed) and use make to compile - also they happened to have intel-ipsec-mb version 1.0 or newer installed before compiling

[dpdk-dev] [PATCH] net/memif: replace memcpy() with rte_memcpy() to improve perf

2021-06-23 Thread David Christensen
Replacing memcpy() with rte_memcpy() improved 64 byte packet performance by 33% on a POWER9 system and by 10% on an x86_64 system. Signed-off-by: David Christensen --- drivers/net/memif/rte_eth_memif.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/memif/r

Re: [dpdk-dev] doc: update dependency requirement for some PMDs

2021-06-23 Thread Stephen Hemminger
On Wed, 23 Jun 2021 17:20:15 +0100 Fan Zhang wrote: > diff --git a/doc/guides/cryptodevs/aesni_gcm.rst > b/doc/guides/cryptodevs/aesni_gcm.rst > index 19f95bde8e..11b23958d5 100644 > --- a/doc/guides/cryptodevs/aesni_gcm.rst > +++ b/doc/guides/cryptodevs/aesni_gcm.rst > @@ -83,9 +83,10 @@ and th

[dpdk-dev] doc: update dependency requirement for some PMDs

2021-06-23 Thread Fan Zhang
This patch updates the dependency requirement information for aesni-gcm, aesni-mb, snow3g, zuc, and kasumi PMDs. Previously building these PMDs with Make will fail when the system is installed inte-ipsec-mb library version 1.0 or newer. Since Make build system is deprecated already, instead of fix

[dpdk-dev] [PATCH] config/ppc: ignore gcc 11 psabi warnings

2021-06-23 Thread David Christensen
Suppress the gcc warning "note: the layout of aggregates containing vectors with 4-byte alignment has changed in GCC 5" on POWER systems by setting "-Wno-psabi". Warning was originally added to gcc in commit https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9832651 to warn of the vector alignment cha

[dpdk-dev] [PATCH] eal/ppc: ignore gcc 10 stringop-overflow warnings

2021-06-23 Thread David Christensen
Suppress gcc warning "warning: writing 16 bytes into a region of size 0" for users of the POWER rte_memcpy() function. Existing rte_memcpy() code takes different code paths based on the actual size of the move so the warning is already addressed. See also commit b5b3ea803e47 ("eal/x86: ignore gcc

Re: [dpdk-dev] [PATCH v2 0/8] use GCC's C11 atomic builtins for test

2021-06-23 Thread Tyler Retzlaff
On Wed, Jun 23, 2021 at 12:24:55PM +0200, Thomas Monjalon wrote: > 18/06/2021 01:26, Honnappa Nagarahalli: > > Yes such wrapper is not required *today*. > We have 2 options: > 1/ introduce a wrapper now to anticipate any future issue > 2/ introduce a wrapper later when required > > Gi

Re: [dpdk-dev] dpdk-stable-20.11.1 compile with all examples fails on openSUSE Leap 15.3

2021-06-23 Thread Loftus, Ciara
> > Hi, > > I can't compile dpdk-stable-20.11.1 on openSUSE Leap 15.3. > > kernel: 5.3.18-59.5-default > > Configuration options: > Message: > = > Libraries Enabled > = > > libs: > kvargs, telemetry, eal, ring, rcu, mempool, mbuf, net, > meter, e

Re: [dpdk-dev] [PATCH v2] common/mlx5: add provider query port support to glue library

2021-06-23 Thread Slava Ovsiienko
Hi, David > -Original Message- > From: David Marchand > Sent: Wednesday, June 23, 2021 16:52 > To: Slava Ovsiienko > Cc: dev ; Raslan Darawsheh ; Matan > Azrad ; NBU-Contact-Thomas Monjalon > ; dpdk stable > Subject: Re: [dpdk-dev] [PATCH v2] common/mlx5: add provider query port > suppo

[dpdk-dev] dpdk-stable-20.11.1 compile with all examples fails on openSUSE Leap 15.3

2021-06-23 Thread Phytophage3
Hi, I can't compile dpdk-stable-20.11.1 on openSUSE Leap 15.3. kernel: 5.3.18-59.5-default Configuration options: Message: = Libraries Enabled = libs: kvargs, telemetry, eal, ring, rcu, mempool, mbuf, net, meter, ethdev, pci, cmdline, metrics, has

[dpdk-dev] [PATCH v4] rib: fix max depth IPv6 lookup

2021-06-23 Thread ohilyard
From: Owen Hilyard ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. The fix for the stack buffer overflow was to make sure depth was always < 128, since when depth = 128 it caused the index into the ip address to be 16, which read off the end of the array. While trying to solve

Re: [dpdk-dev] [EXT] [PATCH v3] doc: announce API changes for Windows compatibility

2021-06-23 Thread Dmitry Kozlyuk
2021-06-09 18:52 (UTC+0300), Dmitry Kozlyuk: > 2021-05-20 20:17 (UTC+), Akhil Goyal: > > > > > > 2021-05-20 18:59 (UTC+), Akhil Goyal: > > > > > Windows system headers define `s_addr`, `min`, and `max` macros which > > > > > break structure definitions containing fields with one of the

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-23 Thread Bruce Richardson
This is developing into quite a long discussion with multiple threads ongoing at the same time. Since it's getting relatively hard to follow (at least for me), can I suggest that we actually hold a call to discuss "dmadev" and to move things along. Since most of the dicussion participants I believe

Re: [dpdk-dev] [PATCH v4 2/2] bus/auxiliary: introduce auxiliary bus

2021-06-23 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 23, 2021 4:15 PM > To: Xueming(Steven) Li > Cc: Parav Pandit ; dev@dpdk.org; Wang Haiyue > ; Kinsella Ray ; > david.march...@redhat.com; ferruh.yi...@intel.com > Subject: Re: [dpdk-dev] [PATCH v4 2/2] bus/auxiliary:

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] kni: fix mbuf allocation for alloc FIFO

2021-06-23 Thread Thomas Monjalon
23/06/2021 16:11, Ferruh Yigit: > On 6/23/2021 1:16 PM, wangyunjian wrote: > > > > > >> -Original Message- > >> From: Thomas Monjalon [mailto:tho...@monjalon.net] > >> Sent: Wednesday, June 23, 2021 4:46 AM > >> To: wangyunjian ; liucheng (J) > >> > >> Cc: dev@dpdk.org; sta...@dpdk.org;

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-23 Thread Bruce Richardson
On Wed, Jun 23, 2021 at 05:16:28PM +0530, Jerin Jacob wrote: > On Wed, Jun 23, 2021 at 3:11 PM Bruce Richardson > wrote: > > > > On Tue, Jun 22, 2021 at 10:55:24PM +0530, Jerin Jacob wrote: > > > On Fri, Jun 18, 2021 at 3:11 PM fengchengwen > > > wrote: > > > > > > > > On 2021/6/18 13:52, Jerin J

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-23 Thread Bruce Richardson
On Wed, Jun 23, 2021 at 05:10:22PM +0530, Jerin Jacob wrote: > On Wed, Jun 23, 2021 at 3:07 PM Bruce Richardson > wrote: > > > > On Wed, Jun 23, 2021 at 12:51:07PM +0530, Jerin Jacob wrote: > > > On Wed, Jun 23, 2021 at 9:00 AM fengchengwen > > > wrote: > > > > > > > > > > > > > Currently, it i

Re: [dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power

2021-06-23 Thread Burakov, Anatoly
On 23-Jun-21 1:09 PM, David Hunt wrote: On 23/6/2021 11:14 AM, Burakov, Anatoly wrote: On 22-Jun-21 3:07 PM, David Hunt wrote: The PMD Power Management scheme currently has 3 modes, scale, monitor and pause. However, it would be nice to have a baseline mode for easy comparison of power savings

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Burakov, Anatoly
On 23-Jun-21 2:27 PM, Ananyev, Konstantin wrote: On 23-Jun-21 12:00 PM, Ananyev, Konstantin wrote: Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexib

Re: [dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action

2021-06-23 Thread Andrew Rybchenko
On 6/23/21 4:39 PM, Ori Kam wrote: > Hi Jan, > >> -Original Message- >> From: Jan Viktorin >> Sent: Wednesday, June 23, 2021 12:18 PM >> >> The struct rte_flow_action was missing from DPDK API documentation. >> >> Signed-off-by: Jan Viktorin >> --- >> lib/ethdev/rte_flow.h | 2 +- >> 1

Re: [dpdk-dev] [PATCH v4 2/2] test/power: round cpuinfo cur freq only when using CPPC cpufreq

2021-06-23 Thread David Hunt
Hi Richael, On 23/6/2021 4:55 AM, Richael Zhuang wrote: On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what was set when using CPPC cpufreq driver. For other cpufreq driver, no need to round it currently, or else this check will fail with turbo enabled.

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] kni: fix mbuf allocation for alloc FIFO

2021-06-23 Thread Ferruh Yigit
On 6/23/2021 1:16 PM, wangyunjian wrote: > > >> -Original Message- >> From: Thomas Monjalon [mailto:tho...@monjalon.net] >> Sent: Wednesday, June 23, 2021 4:46 AM >> To: wangyunjian ; liucheng (J) >> >> Cc: dev@dpdk.org; sta...@dpdk.org; ferruh.yi...@intel.com; >> gowrishanka...@linux.vn

Re: [dpdk-dev] [PATCH v4 1/2] power: add support for cppc cpufreq

2021-06-23 Thread David Hunt
Hi Richael On 23/6/2021 4:55 AM, Richael Zhuang wrote: Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are supported, which are both not available on arm64 platforms. Add support for cppc_cpufreq driver which works on most arm64 platforms. Signed-off-by: Richael Zhuang --- app

Re: [dpdk-dev] [PATCH v4 2/2] bus/auxiliary: introduce auxiliary bus

2021-06-23 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 23, 2021 4:22 PM > To: Parav Pandit ; Xueming(Steven) Li > Cc: dev@dpdk.org; Wang Haiyue ; Kinsella Ray > ; david.march...@redhat.com; > ferruh.yi...@intel.com > Subject: Re: [dpdk-dev] [PATCH v4 2/2] bus/auxiliary:

Re: [dpdk-dev] [PATCH v2] common/mlx5: add provider query port support to glue library

2021-06-23 Thread David Marchand
On Wed, Jun 23, 2021 at 1:27 PM Slava Ovsiienko wrote: > > > This patch is highly desirable to be provided in DPDK LTS releases due > > > to it covers the major compatibility issue. > > > > This patch is a fix, yet nothing tells this story in the title. > > This patch is not a fix. Actually it cov

Re: [dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action

2021-06-23 Thread Ori Kam
Hi Jan, > -Original Message- > From: Jan Viktorin > Sent: Wednesday, June 23, 2021 12:18 PM > > The struct rte_flow_action was missing from DPDK API documentation. > > Signed-off-by: Jan Viktorin > --- > lib/ethdev/rte_flow.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Ananyev, Konstantin
> On 23-Jun-21 12:00 PM, Ananyev, Konstantin wrote: > > > > > >> Previously, the semantics of power monitor were such that we were > >> checking current value against the expected value, and if they matched, > >> then the sleep was aborted. This is somewhat inflexible, because it

[dpdk-dev] [Bug 746] net/mlx5: segfault on MPRQ pool exhaustion

2021-06-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=746 Bug ID: 746 Summary: net/mlx5: segfault on MPRQ pool exhaustion Product: DPDK Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH v6 2/2] power: refactor pstate and acpi code

2021-06-23 Thread Burakov, Anatoly
On 23-Jun-21 1:03 PM, David Hunt wrote: From: Anatoly Burakov Currently, ACPI and PSTATE modes have lots of code duplication, confusing logic, and a bunch of other issues that can, and have, led to various bugs and resource leaks. This commit factors out the common parts of sysfs reading/writi

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] kni: fix mbuf allocation for alloc FIFO

2021-06-23 Thread wangyunjian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, June 23, 2021 4:46 AM > To: wangyunjian ; liucheng (J) > > Cc: dev@dpdk.org; sta...@dpdk.org; ferruh.yi...@intel.com; > gowrishanka...@linux.vnet.ibm.com; dingxiaoxiong > ; wangyunjian > Subjec

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Burakov, Anatoly
On 23-Jun-21 12:00 PM, Ananyev, Konstantin wrote: Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexible, because it only allowed us to check for a specif

Re: [dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power

2021-06-23 Thread David Hunt
On 23/6/2021 11:14 AM, Burakov, Anatoly wrote: On 22-Jun-21 3:07 PM, David Hunt wrote: The PMD Power Management scheme currently has 3 modes, scale, monitor and pause. However, it would be nice to have a baseline mode for easy comparison of power savings with and without these modes. This pat

[dpdk-dev] [PATCH v6 2/2] power: refactor pstate and acpi code

2021-06-23 Thread David Hunt
From: Anatoly Burakov Currently, ACPI and PSTATE modes have lots of code duplication, confusing logic, and a bunch of other issues that can, and have, led to various bugs and resource leaks. This commit factors out the common parts of sysfs reading/writing for ACPI and PSTATE drivers. Signed-of

[dpdk-dev] [PATCH v6 1/2] power: don't use rte prefix in internal code

2021-06-23 Thread David Hunt
From: Anatoly Burakov Currently, ACPI code uses rte_power_info as the struct name, which gives the appearance that this is an externally visible API. Fix to use internal namespace. Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- lib/power/power_acpi_cpufreq.c | 34 +---

Re: [dpdk-dev] [PATCH v3] net/mlx5: add TCP and IPv6 to supported flow items list in Windows

2021-06-23 Thread Matan Azrad
From: Tal Shnaiderman > WINOF2 2.70 Windows kernel driver allows DevX rule creation of types TCP > and IPv6. > > Added the types to the supported items in mlx5_flow_os_item_supported > to allow them to be created in the PMD. > > Added description of new rules support in Windows kernel driver W

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-23 Thread Jerin Jacob
On Wed, Jun 23, 2021 at 3:11 PM Bruce Richardson wrote: > > On Tue, Jun 22, 2021 at 10:55:24PM +0530, Jerin Jacob wrote: > > On Fri, Jun 18, 2021 at 3:11 PM fengchengwen > > wrote: > > > > > > On 2021/6/18 13:52, Jerin Jacob wrote: > > > > On Thu, Jun 17, 2021 at 2:46 PM Bruce Richardson > > > >

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-23 Thread Jerin Jacob
On Wed, Jun 23, 2021 at 3:07 PM Bruce Richardson wrote: > > On Wed, Jun 23, 2021 at 12:51:07PM +0530, Jerin Jacob wrote: > > On Wed, Jun 23, 2021 at 9:00 AM fengchengwen > > wrote: > > > > > > > > > Currently, it is hard to define generic dma descriptor, I think the > > > well-defined > > > AP

Re: [dpdk-dev] [PATCH v2] common/mlx5: add provider query port support to glue library

2021-06-23 Thread Slava Ovsiienko
Hi David, > -Original Message- > From: David Marchand > Sent: Wednesday, June 23, 2021 13:43 > To: Slava Ovsiienko > Cc: dev ; Raslan Darawsheh ; Matan > Azrad ; NBU-Contact-Thomas Monjalon > ; dpdk stable > Subject: Re: [dpdk-dev] [PATCH v2] common/mlx5: add provider query port > suppo

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-23 Thread Jerin Jacob
On Wed, Jun 23, 2021 at 11:04 AM Hu, Jiayu wrote: > > > > > -Original Message- > > From: dev On Behalf Of Bruce Richardson > > Sent: Thursday, June 17, 2021 1:31 AM > > To: fengchengwen > > Cc: tho...@monjalon.net; Yigit, Ferruh ; > > dev@dpdk.org; nipun.gu...@nxp.com; hemant.agra...@nxp

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Ananyev, Konstantin
> >>> > Previously, the semantics of power monitor were such that we were > checking current value against the expected value, and if they matched, > then the sleep was aborted. This is somewhat inflexible, because it only > allowed us to check for a specific value. > > >>

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-23 Thread Jerin Jacob
On Wed, Jun 23, 2021 at 9:20 AM fengchengwen wrote: > > On 2021/6/23 1:51, Jerin Jacob wrote: > > On Fri, Jun 18, 2021 at 2:22 PM fengchengwen > > wrote: > >> > >> On 2021/6/17 22:18, Bruce Richardson wrote: > >>> On Thu, Jun 17, 2021 at 12:02:00PM +0100, Bruce Richardson wrote: > On Thu, J

Re: [dpdk-dev] [PATCH v2] common/mlx5: add provider query port support to glue library

2021-06-23 Thread David Marchand
On Sat, Jun 19, 2021 at 2:49 PM Viacheslav Ovsiienko wrote: > > The rdma-core mlx5 provider introduced the port attributes query > API since version v35.0 - the mlx5dv_query_port routine. In order > to support this change in the rdma-core the conditional compilation > flag HAVE_MLX5DV_DR_DEVX_PORT

Re: [dpdk-dev] [PATCH v2 0/8] use GCC's C11 atomic builtins for test

2021-06-23 Thread Thomas Monjalon
18/06/2021 01:26, Honnappa Nagarahalli: > > On Tue, Jun 15, 2021 at 09:54:51PM -0500, Joyce Kong wrote: > > > Since C11 memory model is adopted in DPDK now[1], use GCC's atomic > > > builtins in test cases. > > > > as previously discussed these atomics are not "C11" they are direct use of > > gcc

Re: [dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power

2021-06-23 Thread Burakov, Anatoly
On 22-Jun-21 3:07 PM, David Hunt wrote: The PMD Power Management scheme currently has 3 modes, scale, monitor and pause. However, it would be nice to have a baseline mode for easy comparison of power savings with and without these modes. This patch adds a 'baseline' mode were the pmd power manag

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-23 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, 23 June 2021 11.41 > > [Also, you are not likely to want to offload a small > copy, are you?] Maybe. I would consider it for two reasons: 1. To avoid CPU cache pollution. E.g. copy packet data (or part of

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Burakov, Anatoly
On 23-Jun-21 10:55 AM, Ananyev, Konstantin wrote: -Original Message- From: Burakov, Anatoly Sent: Wednesday, June 23, 2021 10:43 AM To: Ananyev, Konstantin ; dev@dpdk.org; Richardson, Bruce Cc: Loftus, Ciara ; Hunt, David Subject: Re: [PATCH v1 1/7] power_intrinsics: allow monitor

Re: [dpdk-dev] [PATCH v1 5/7] power: support callbacks for multiple Rx queues

2021-06-23 Thread Burakov, Anatoly
On 23-Jun-21 10:49 AM, Ananyev, Konstantin wrote: On 22-Jun-21 10:41 AM, Ananyev, Konstantin wrote: Currently, there is a hard limitation on the PMD power management support that only allows it to support a single queue per lcore. This is not ideal as most DPDK use cases will poll multiple

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Ananyev, Konstantin
> -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, June 23, 2021 10:43 AM > To: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce > Cc: Loftus, Ciara ; Hunt, David > Subject: Re: [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion > > On 21-Jun-21 1:56

Re: [dpdk-dev] [PATCH v1 4/7] power: remove thread safety from PMD power API's

2021-06-23 Thread Ananyev, Konstantin
> > On 22-Jun-21 10:13 AM, Ananyev, Konstantin wrote: > > > >> Currently, we expect that only one callback can be active at any given > >> moment, for a particular queue configuration, which is relatively easy > >> to implement in a thread-safe way. However, we're about to add support > >> for m

Re: [dpdk-dev] [PATCH v1 5/7] power: support callbacks for multiple Rx queues

2021-06-23 Thread Ananyev, Konstantin
> > On 22-Jun-21 10:41 AM, Ananyev, Konstantin wrote: > > > >> Currently, there is a hard limitation on the PMD power management > >> support that only allows it to support a single queue per lcore. This is > >> not ideal as most DPDK use cases will poll multiple queues per core. > >> > >> The PM

Re: [dpdk-dev] [PATCH v1 4/7] power: remove thread safety from PMD power API's

2021-06-23 Thread Burakov, Anatoly
On 22-Jun-21 10:13 AM, Ananyev, Konstantin wrote: Currently, we expect that only one callback can be active at any given moment, for a particular queue configuration, which is relatively easy to implement in a thread-safe way. However, we're about to add support for multiple queues per lcore, w

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Burakov, Anatoly
On 21-Jun-21 1:56 PM, Ananyev, Konstantin wrote: Hi Anatoly, Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexible, because it only allowed us to check fo

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-23 Thread Bruce Richardson
On Tue, Jun 22, 2021 at 10:55:24PM +0530, Jerin Jacob wrote: > On Fri, Jun 18, 2021 at 3:11 PM fengchengwen wrote: > > > > On 2021/6/18 13:52, Jerin Jacob wrote: > > > On Thu, Jun 17, 2021 at 2:46 PM Bruce Richardson > > > wrote: > > >> > > >> On Wed, Jun 16, 2021 at 08:07:26PM +0530, Jerin Jacob

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-23 Thread Bruce Richardson
On Wed, Jun 23, 2021 at 12:51:07PM +0530, Jerin Jacob wrote: > On Wed, Jun 23, 2021 at 9:00 AM fengchengwen wrote: > > > > > >>> > > > > > The above will give better performance and is the best trade-off c > > > between performance and per transfer variables. > > > > We may

Re: [dpdk-dev] [PATCH v1 5/7] power: support callbacks for multiple Rx queues

2021-06-23 Thread Burakov, Anatoly
On 22-Jun-21 10:41 AM, Ananyev, Konstantin wrote: Currently, there is a hard limitation on the PMD power management support that only allows it to support a single queue per lcore. This is not ideal as most DPDK use cases will poll multiple queues per core. The PMD power management mechanism r

Re: [dpdk-dev] [PATCH] devtools: fix file listing in maintainers check

2021-06-23 Thread Thomas Monjalon
15/06/2021 14:49, Thomas Monjalon: > When having multiple working trees, the main one has a .git directory > while attached trees have a .git file. > Thus the git check should work for both file and directory. > > In the case there is no working tree (.git not readable), the command > "find" is us

[dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action

2021-06-23 Thread Jan Viktorin
The struct rte_flow_action was missing from DPDK API documentation. Signed-off-by: Jan Viktorin --- lib/ethdev/rte_flow.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 961a5884fe..70f455d47d 100644 --- a/lib/ethdev/rte_flo

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads for the newly attached port

2021-06-23 Thread Singh, Aman Deep
Acked-by: Aman Deep Singh On 6/19/2021 9:10 PM, Viacheslav Ovsiienko wrote: For the newly attached ports (with "port attach" command) the default offloads settings, configured from application command line, were not applied, causing port start failure following the attach. For example, if scatt

Re: [dpdk-dev] [PATCH v5 2/2] power: refactor pstate and acpi code

2021-06-23 Thread David Hunt
On 23/6/2021 9:54 AM, Richael Zhuang wrote: Hi, There is a bug in lib/power/power_common.c: +write_core_sysfs_s(FILE *f, const char *str) +{ + int ret; + + ret = fseek(f, 0, SEEK_SET); + if (ret != 0) + return -1; + + ret = fputs(str, f); + if (ret

Re: [dpdk-dev] [PATCH v5 2/2] power: refactor pstate and acpi code

2021-06-23 Thread Richael Zhuang
Hi, There is a bug in lib/power/power_common.c: +write_core_sysfs_s(FILE *f, const char *str) +{ + int ret; + + ret = fseek(f, 0, SEEK_SET); + if (ret != 0) + return -1; + + ret = fputs(str, f); + if (ret != 0) + return -1; Here, I mentione

[dpdk-dev] [PATCH v2] net/i40e: add logic of processing continuous DD bits for Arm

2021-06-23 Thread Joyce Kong
For Arm platforms, reading descs can get re-ordered, then the status of DD bits will be discontinuous, so add the logic to only process continuous descs by checking DD bits. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang

Re: [dpdk-dev] [PATCH] tests/cmdline: fix memory leaks

2021-06-23 Thread Olivier Matz
Hi Owen, Thanks for fixing this test. Some comments below. On Wed, Jun 16, 2021 at 02:07:24PM -0400, ohily...@iol.unh.edu wrote: > From: Owen Hilyard > > Fixes for a few memory leaks in the cmdline_autotest unit test. > > All of the leaks were related to not freeing the commandline struct > af

Re: [dpdk-dev] [PATCH v8 1/2] config/arm: select most suitable -march for kunpeng soc

2021-06-23 Thread fengchengwen
On 2021/6/23 16:08, Thomas Monjalon wrote: > 21/06/2021 02:52, fengchengwen: >> Hi, Thomas >> >> Another patch '[dpdk-dev] [PATCH v8 2/2] net/hns3: refactor SVE code compile >> method' >> has nothing to do with this patch (they're just in the same patchset) and >> has been >> reviewed by ARM guys

Re: [dpdk-dev] [PATCH v4 2/2] bus/auxiliary: introduce auxiliary bus

2021-06-23 Thread Thomas Monjalon
23/06/2021 01:50, Xueming(Steven) Li: > From: Thomas Monjalon > > 13/06/2021 14:58, Xueming Li: > > > + struct rte_auxiliary_driver *driver; /**< driver used in probing */ > > > > Why in probing? > > I suggest "Device driver" > > A SF device could be probed by a class driver t then another

Re: [dpdk-dev] [PATCH v4 2/2] bus/auxiliary: introduce auxiliary bus

2021-06-23 Thread Thomas Monjalon
23/06/2021 01:50, Xueming(Steven) Li: > From: Thomas Monjalon > > 13/06/2021 14:58, Xueming Li: > > > --- /dev/null > > > +++ b/drivers/bus/auxiliary/version.map > > > @@ -0,0 +1,7 @@ > > > +EXPERIMENTAL { > > > + global: > > > + > > > + # added in 21.08 > > > + rte_auxiliary_register; > > > + rte

  1   2   >