On Wed, Jun 23, 2021 at 1:27 PM Slava Ovsiienko <viachesl...@nvidia.com> wrote: > > > This patch is highly desirable to be provided in DPDK LTS releases due > > > to it covers the major compatibility issue. > > > > This patch is a fix, yet nothing tells this story in the title. > > This patch is not a fix. Actually it covers the compatibility issue, not a > bug.
I still think it counts as a fix in the sense that the mlx5 driver behavior changes to an undesired state if rdma-core gets updated. It's not about preferring "fix" in the title. It is more accurate/descriptive to me. If you feel strongly against "fix", I won't insist. Yet "add provider quer port support to glue library" is just black magic to most of us. > The Upstream rdma-core was evolved, its community adopted a > slightly different API version than was presented in the vendor version. > Our PMD should conform both versions and we provided this patch for DPDK. Let's try differently. Place yourself as someone who does not know a thing about the mlx5 driver and rdma-core. How does such a person understand the impact of this patch? I would state in the title that the mlx5 driver can now handle correctly rdma-core 35. Additionally, it could indicate which feature X is now behaving as intended. But if feature X is something internal to the mlx5 driver, it is worth skipping. -- David Marchand
