[dpdk-dev] [PATCH 14/14] net/i40e/base: update version in readme

2021-06-17 Thread Robin Zhang
Update base code version in README. Signed-off-by: Robin Zhang --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 6af2993116..c84764005b 100644 --- a/drivers/net/i40e/base/README +

[dpdk-dev] [PATCH 13/14] net/i40e/base: fix potentially uninitialized variables in NVM code

2021-06-17 Thread Robin Zhang
The status of i40e_read_nvm_word is not checked, so variables set from this function could be used uninitialized. In this case, preserve the existing flow that does not block initialization by initializing these values from the start. The variable checksum from i40e_calc_nvm_checksum is used befor

[dpdk-dev] [PATCH 12/14] net/i40e/base: fix headers to match functions

2021-06-17 Thread Robin Zhang
Fix several kernel-doc warnings when building with W=1. These changes are only to comments. Fixes: 8db9e2a1b232 ("i40e: base driver") Fixes: 842ea1996335 ("i40e/base: save link module type") Fixes: fd72a2284a89 ("i40e/base: support LED blinking with new PHY") Fixes: 788fc17b2dec ("i40e/base: suppo

[dpdk-dev] [PATCH 11/14] net/i40e/base: 10GBASE-ER Optical modules recognition

2021-06-17 Thread Robin Zhang
This change adds a new PHY type for 10GBASE-ER modules. Signed-off-by: Stanislaw Grzeszczak Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 2 ++ drivers/net/i40e/base/i40e_common.c | 1 + drivers/net/i40e/base/i40e_type.h | 1 + 3 files changed, 4 insertions(

[dpdk-dev] [PATCH 10/14] net/i40e/base: add flags and fields for double vlan processing

2021-06-17 Thread Robin Zhang
Add flags for outer vlan and include set port parameters in Linux compilation. Add flags, which describe port and switch state for both double vlan functionality and outer vlan processing. Signed-off-by: Przemyslaw Patynowski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.

[dpdk-dev] [PATCH 09/14] net/i40e/base: fix AOC media type reported by ethtool

2021-06-17 Thread Robin Zhang
For Active Optical Cable (AOC) the correct media type is "Fibre", not "Direct Attach Copper". Fixes: d749d4d89969 ("i40e/base: add AOC PHY types") Fixes: aa153cc89ff0 ("net/i40e/base: add new PHY types for 25G AOC and ACC") Cc: sta...@dpdk.org Signed-off-by: Dawid Lukwinski Signed-off-by: Robin

[dpdk-dev] [PATCH 08/14] net/i40e/base: fix update link data for X722

2021-06-17 Thread Robin Zhang
The X722 card has 'Link Type' information elsewhere than the X710. Previously, for all cards, the 'Link Type' information was retrieved by opcode 0x0607 and this value was wrong for all X722 cards. Now this information for X722 only is taken by opcode 0x0600 (function: i40e_aq_get_phy_capabilities)

[dpdk-dev] [PATCH 07/14] net/i40e/base: fix PF reset failed

2021-06-17 Thread Robin Zhang
PF has to delete all the filters during reset. If it is fully loaded with filters then it is possible that it will take more than 200 ms to finish the reset resulting in timeout during pf_reset and PF reset failed, -15 error indication. Increasing the timeout value for PF reset from 200 to 1000 to

[dpdk-dev] [PATCH 06/14] net/i40e/base: fix PHY type identifiers for 2.5G and 5G adapters

2021-06-17 Thread Robin Zhang
Unlike other supported adapters, 2.5G and 5G use different PHY type identifiers for reading/writing PHY settings and for reading link status. This commit intruduces separate PHY identifiers for these two operation types. Fixes: 988ed63c7441 ("net/i40e/base: add support for Carlsville device") Cc:

[dpdk-dev] [PATCH 05/14] net/i40e/base: define new Shadow RAM pointers

2021-06-17 Thread Robin Zhang
Add definitions for Shadow RAM pointers: 6th FPA module, 5th FPA module in FortPark and Preservation Rules Module. Signed-off-by: Stanislaw Grzeszczak Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_type.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/i40e/base/i4

[dpdk-dev] [PATCH 04/14] net/i40e/base: set TSA table values when parsing CEE configuration

2021-06-17 Thread Robin Zhang
Driver did not Set TSA table values when parsing CEE configuration obtained from FW. Signed-off-by: Pawel Malinowski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_dcb.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/i40e_dcb.c b/driv

[dpdk-dev] [PATCH 03/14] net/i40e/base: add support for Min Rollback Revision for 4 more FPK modules

2021-06-17 Thread Robin Zhang
This change increments FPK API version and adds new constants related to the extended implementation of Security Version Opt-In. Signed-off-by: Stanislaw Grzeszczak Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 16 ++-- 1 file changed, 10 insertions(+), 6

[dpdk-dev] [PATCH 02/14] net/i40e/base: update FVL FW API version to 1.14

2021-06-17 Thread Robin Zhang
Update FVL FW increment API version to 1.14 Signed-off-by: Sylwester Dziedziuch Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq

[dpdk-dev] [PATCH 01/14] net/i40e/base: add new versions of send ASQ command functions

2021-06-17 Thread Robin Zhang
ASQ send command functions are returning only i40e status codes yet some calling functions also need Admin Queue status that is stored in hw->aq.asq_last_status. Since hw object is stored on a heap it introduces a possibility for a race condition in access to hw if calling function is not fast enou

[dpdk-dev] [PATCH 00/14] i40e base code update

2021-06-17 Thread Robin Zhang
update i40e base code. source code of i40e driver: cid-i40e.2021.04.29.tar.gz changelog in ND share repo: >From 59a080f4fafe ("i40e-shared: Add opcode 0x0406 and 0x0416 to Linux support") To bedcbea1063 ("i40e-shared: Fix potentially uninitialized variables in NVM code") The following commits ar

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-17 Thread Jerin Jacob
On Thu, Jun 17, 2021 at 2:46 PM Bruce Richardson wrote: > > On Wed, Jun 16, 2021 at 08:07:26PM +0530, Jerin Jacob wrote: > > On Wed, Jun 16, 2021 at 3:47 PM fengchengwen > > wrote: > > > > > > On 2021/6/16 15:09, Morten Brørup wrote: > > > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-17 Thread Jerin Jacob
On Thu, Jun 17, 2021 at 1:30 PM Bruce Richardson wrote: > > On Thu, Jun 17, 2021 at 01:12:22PM +0530, Jerin Jacob wrote: > > On Thu, Jun 17, 2021 at 12:43 AM Bruce Richardson > > wrote: > > > > > > On Wed, Jun 16, 2021 at 11:38:08PM +0530, Jerin Jacob wrote: > > > > On Wed, Jun 16, 2021 at 11:01

Re: [dpdk-dev] [PATCH] fix Marvell maintainer email for atlantic

2021-06-17 Thread Jerin Jacob
On Thu, Jun 17, 2021 at 12:40 PM Thomas Monjalon wrote: > > 25/05/2021 11:57, Igor Russkikh: > > Fixing ex-Aquantia email - it is now part of Marvell. > > Removing Pavel Belous email - he is not in company now. > > > > Also adding Marvell company prefix to the driver names for > > both atlantic an

Re: [dpdk-dev] [PATCH v4 5/7] vhost: improve NUMA reallocation

2021-06-17 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, June 17, 2021 11:38 PM > To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo > > Cc: Maxime Coquelin > Subject: [PATCH v4 5/7] vhost: improve NUMA reallocation > > This patch improves the numa_realloc() fun

Re: [dpdk-dev] [PATCH v4 4/7] vhost: fix NUMA reallocation with multiqueue

2021-06-17 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, June 17, 2021 11:38 PM > To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo > > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH v4 4/7] vhost: fix NUMA reallocation with multiqueue > > Since the Vho

Re: [dpdk-dev] [PATCH v4 1/7] vhost: fix missing memory table NUMA realloc

2021-06-17 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, June 17, 2021 11:38 PM > To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo > > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH v4 1/7] vhost: fix missing memory table NUMA realloc > > When the gues

Re: [dpdk-dev] [PATCH v2 0/3] net/ice: support FDIR ESP and NATT to match outer IP

2021-06-17 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Wednesday, June 9, 2021 10:50 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Guo, Junfeng ; Cao, Yahui > ; Su, Simei > Subject: [PATCH v2 0/3] net/ice: support FDIR ESP and NATT to match outer IP > > [PATCH v2 1/3] enable FDIR ESP to match out

Re: [dpdk-dev] [PATCH V6] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Ruifeng Wang
> -Original Message- > From: Thierry Herbelot > Sent: Thursday, June 17, 2021 11:13 PM > To: dev@dpdk.org > Cc: Thierry Herbelot ; tho...@monjalon.net; > jer...@marvell.com; Ruifeng Wang ; Honnappa > Nagarahalli ; Juraj Linkeš > > Subject: [PATCH V6] config/arm: add Qualcomm Centriq 2400

Re: [dpdk-dev] [PATCH v8 1/2] config/arm: select most suitable -march for kunpeng soc

2021-06-17 Thread Honnappa Nagarahalli
> > 24/05/2021 15:23, Chengwen Feng: > > Currently, the soc_kunpeng930 declares '-march=armv8.2-a+crypto+sve', > > but some compiler doesn't recognize the march because it doesn't > > support sve. > > > > To solve this bug we use the following scheme: > > 1. Define 'march_base' tuple which defin

Re: [dpdk-dev] [PATCH v2 0/8] use GCC's C11 atomic builtins for test

2021-06-17 Thread Honnappa Nagarahalli
> > On Tue, Jun 15, 2021 at 09:54:51PM -0500, Joyce Kong wrote: > > Since C11 memory model is adopted in DPDK now[1], use GCC's atomic > > builtins in test cases. > > as previously discussed these atomics are not "C11" they are direct use of gcc > builtins. please don't incorporate C11 into the

[dpdk-dev] [Bug 743] Building DPDK with gcc 11.1.1 Generates Multiple Warning Messages in the i40e PMD

2021-06-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=743 Bug ID: 743 Summary: Building DPDK with gcc 11.1.1 Generates Multiple Warning Messages in the i40e PMD Product: DPDK Version: unspecified Hardware: POWER OS: Linux

Re: [dpdk-dev] 19.11.9 patches review and test

2021-06-17 Thread Stokes, Ian
> Hi all, > > Here is a list of patches targeted for stable release 19.11.9. > > The planned date for the final release is 2nd July. > > Please help with testing and validation of your use cases and report > any issues/results with reply-all to this mail. For the final release > the fixes and re

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-17 Thread Ananyev, Konstantin
> On 6/17/2021 4:17 PM, Morten Brørup wrote: > >> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > >> Sent: Thursday, 17 June 2021 16.59 > >> > >> > >> 14/06/2021 15:15, Bruce Richardson: > >>> On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: >

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-17 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, 17 June 2021 18.13 > > On 6/17/2021 4:17 PM, Morten Brørup wrote: > >> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > >> Sent: Thursday, 17 June 2021 16.59 > >> > >> > >> 14/06/2021 15:

Re: [dpdk-dev] [PATCH v2] vhost/vhost_crypto: do not use possibly NULL Pointers

2021-06-17 Thread Maxime Coquelin
On 5/24/21 11:08 AM, Thierry Herbelot wrote: > Use vc_req only after it was checked not to be NULL. > > Fixes: 2d962bb736521 ("vhost/crypto: fix possible TOCTOU attack") > Cc: sta...@dpdk.org > Cc: Maxime Coquelin > Cc: Chenbo Xia > > Signed-off-by: Thierry Herbelot > -- > V2: fix copy/past

Re: [dpdk-dev] [PATCH] net/virtio: fix kernel set features for multi-queue devices

2021-06-17 Thread Maxime Coquelin
On 5/28/21 3:20 PM, Thierry Herbelot wrote: > Restore the original code, where VHOST_SET_FEATURES is applied to > all vhostfds of the device. > > Fixes: cc0151b34dee ("net/virtio: add virtio-user features ops") > Cc: sta...@dpdk.org > Cc: Maxime Coquelin > Cc: Chenbo Xia > > Signed-off-by: T

Re: [dpdk-dev] [PATCH v4] vhost: allocate and free packets in bulk in Tx split

2021-06-17 Thread Maxime Coquelin
On 6/8/21 1:41 PM, Balazs Nemeth wrote: > Same idea as commit a287ac28919d ("vhost: allocate and free packets > in bulk in Tx packed"), allocate and free packets in bulk. Also remove > the unused function virtio_dev_pktmbuf_alloc. > > Signed-off-by: Balazs Nemeth > Reviewed-by: Maxime Coquelin

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-06-17 Thread Ferruh Yigit
On 6/14/2021 5:36 PM, Andrew Rybchenko wrote: > On 6/10/21 12:22 PM, Olivier Matz wrote: >> Hi Gregory, >> >> On Thu, Jun 10, 2021 at 04:10:25AM +, Gregory Etelson wrote: >>> Hello, >>> >>> There was no activity that patch for a long time. >>> The patch is marked as failed, but we verified fail

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-17 Thread Ferruh Yigit
On 6/17/2021 4:17 PM, Morten Brørup wrote: >> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] >> Sent: Thursday, 17 June 2021 16.59 >> >> >> 14/06/2021 15:15, Bruce Richardson: >>> On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: > From: dev [mailto

[dpdk-dev] [PATCH v2 2/2] doc: description of new steering rules support in Windows

2021-06-17 Thread Tal Shnaiderman
Added description of new rules support in Windows kernel driver WINOF2 2.70 Signed-off-by: Tal Shnaiderman --- doc/guides/nics/mlx5.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 83299646dd..eb44a070b1 100644 --- a/doc/guides/

[dpdk-dev] [PATCH v2 0/2] Add types to supported flow items in Windows

2021-06-17 Thread Tal Shnaiderman
--- v2: Added a docu patch. --- Tal Shnaiderman (2): net/mlx5: add TCP and IPv6 to supported flow items list in Windows doc: description of new steering rules support in Windows doc/guides/nics/mlx5.rst| 3 +++ drivers/net/mlx5/windows/mlx5_flow_os.h | 2 ++ 2 files changed,

[dpdk-dev] [PATCH v2 1/2] net/mlx5: add TCP and IPv6 to supported flow items list in Windows

2021-06-17 Thread Tal Shnaiderman
WINOF2 2.70 Windows kernel driver allows DevX rule creation of types TCP and IPv6. Added the types to the supported items in mlx5_flow_os_item_supported to allow them to be created in the PMD. --- v2: Added a docu patch. --- Signed-off-by: Tal Shnaiderman --- drivers/net/mlx5/windows/mlx5_flow

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-17 Thread Ferruh Yigit
On 6/17/2021 3:58 PM, Ananyev, Konstantin wrote: > > > > 14/06/2021 15:15, Bruce Richardson: >> On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon Sent: Monday, 14 June 2021 12.59 >>

Re: [dpdk-dev] [PATCH v2] vfio: fix stdbool usage without include

2021-06-17 Thread Thomas Monjalon
02/06/2021 13:06, Burakov, Anatoly: > On 01-Jun-21 9:28 AM, Christian Ehrhardt wrote: > > This became visible by backporting the following for the 19.11 stable tree: > > c13ca4e8 "vfio: fix DMA mapping granularity for IOVA as VA" > > > > The usage of type bool in the vfio code would require "#in

[dpdk-dev] [PATCH v4 7/7] vhost: convert inflight data to DPDK allocation API

2021-06-17 Thread Maxime Coquelin
Inflight metadata are allocated using glibc's calloc. This patch converts them to rte_zmalloc_socket to take care of the NUMA affinity. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 4 +-- lib/vhost/vhost_user.c | 67 +++--- 2 files changed, 58

[dpdk-dev] [PATCH v4 6/7] vhost: allocate all data on same node as virtqueue

2021-06-17 Thread Maxime Coquelin
This patch saves the NUMA node the virtqueue is allocated on at init time, in order to allocate all other data on the same node. While most of the data are allocated before numa_realloc() is called and so the data will be reallocated properly, some data like the log cache are most likely allocated

[dpdk-dev] [PATCH v4 5/7] vhost: improve NUMA reallocation

2021-06-17 Thread Maxime Coquelin
This patch improves the numa_realloc() function by making use of rte_realloc_socket(), which takes care of the memory copy and freeing of the old data. Suggested-by: David Marchand Signed-off-by: Maxime Coquelin --- lib/vhost/vhost_user.c | 195 ++--- 1 file

[dpdk-dev] [PATCH v4 4/7] vhost: fix NUMA reallocation with multiqueue

2021-06-17 Thread Maxime Coquelin
Since the Vhost-user device initialization has been reworked, enabling the application to start using the device as soon as the first queue pair is ready, NUMA reallocation no more happened on queue pairs other than the first one since numa_realloc() was returning early if the device was running.

[dpdk-dev] [PATCH v4 3/7] vhost: fix missing cache logging NUMA realloc

2021-06-17 Thread Maxime Coquelin
When the guest allocates virtqueues on a different NUMA node than the one the Vhost metadata are allocated, both the Vhost device struct and the virtqueues struct are reallocated. However, reallocating the log cache on the new NUMA node was not done. This patch fixes this by reallocating it if it

[dpdk-dev] [PATCH v4 2/7] vhost: fix missing guest pages table NUMA realloc

2021-06-17 Thread Maxime Coquelin
When the guest allocates virtqueues on a different NUMA node than the one the Vhost metadata are allocated, both the Vhost device struct and the virtqueues struct are reallocated. However, reallocating the guest pages table was missing, which likely causes at least one cross-NUMA accesses for ever

[dpdk-dev] [PATCH v4 1/7] vhost: fix missing memory table NUMA realloc

2021-06-17 Thread Maxime Coquelin
When the guest allocates virtqueues on a different NUMA node than the one the Vhost metadata are allocated, both the Vhost device struct and the virtqueues struct are reallocated. However, reallocating the Vhost memory table was missing, which likely causes iat least one cross-NUMA accesses for ev

[dpdk-dev] [PATCH v4 0/7] vhost: Fix and improve NUMA reallocation

2021-06-17 Thread Maxime Coquelin
This patch series first fixes missing reallocations of some Virtqueue and device metadata. Then, it improves the numa_realloc function by using rte_realloc_socket API that takes care of the memcpy & freeing. The VQs NUMA IDs are also saved in the VQ metadata and used for every allocations so that

Re: [dpdk-dev] [PATCH v2 0/8] use GCC's C11 atomic builtins for test

2021-06-17 Thread Tyler Retzlaff
On Tue, Jun 15, 2021 at 09:54:51PM -0500, Joyce Kong wrote: > Since C11 memory model is adopted in DPDK now[1], use GCC's > atomic builtins in test cases. as previously discussed these atomics are not "C11" they are direct use of gcc builtins. please don't incorporate C11 into the title of the pa

Re: [dpdk-dev] [PATCH v2] net/hns3: support Tx push quick doorbell to improve perf

2021-06-17 Thread Andrew Rybchenko
On 6/15/21 4:34 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > Kunpeng 930 support Tx push mode which could improve performance, It > works like below: > 1. Add PCIe bar45 which support driver direct write the Tx descriptor > or tail reg to it. > 2. Support three operations: a) direct write

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-17 Thread Morten Brørup
> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Thursday, 17 June 2021 16.59 > > > >>> > > >>> 14/06/2021 15:15, Bruce Richardson: > > On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: > > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thoma

[dpdk-dev] [PATCH V6] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
0xc00 is for "SoC 2.0" Qualcomm Centriq servers. 0x800 is for "SoC 1.1". Cc: Jerin Jacob Cc: Ruifeng Wang Cc: Honnappa Nagarahalli Cc: Juraj Linkeš Signed-off-by: Thierry Herbelot -- V2: add maintainers as Cc V3: fix meson syntax for the SoC v1.1 machine description V4: add new soc_centriq24

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-06-17 Thread Tyler Retzlaff
On Thu, May 27, 2021 at 06:28:58PM +0300, Gregory Etelson wrote: > diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h > index 4b728969c1..684bb028b2 100644 > --- a/lib/net/rte_ip.h > +++ b/lib/net/rte_ip.h > @@ -38,7 +38,21 @@ extern "C" { > * IPv4 Header > */ > struct rte_ipv4_hdr { > - uin

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-17 Thread Ananyev, Konstantin
> >>> > >>> 14/06/2021 15:15, Bruce Richardson: > On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > >> Sent: Monday, 14 June 2021 12.59 > >> > >> Performance of access in a fixed-size arr

Re: [dpdk-dev] [PATCH 0/6] bugfixes for hns3 PMD

2021-06-17 Thread Andrew Rybchenko
On 6/15/21 3:47 AM, Min Hu (Connor) wrote: > > > 在 2021/6/14 22:43, Andrew Rybchenko 写道: >> On 6/13/21 5:31 AM, Min Hu (Connor) wrote: >>> This patch set contains 6 bugfixes for hns3 PMD. >>> >>> Chengchang Tang (1): >>>    net/hns3: fix VLAN strip log >>> >>> HongBo Zheng (2): >>>    net/hns3: m

Re: [dpdk-dev] [PATCH V3] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Ruifeng Wang
> -Original Message- > From: Thierry Herbelot > Sent: Thursday, June 17, 2021 7:25 PM > To: Ruifeng Wang ; dev@dpdk.org > Cc: tho...@monjalon.net; jer...@marvell.com; Honnappa Nagarahalli > ; Juraj Linkeš > ; nd > Subject: Re: [PATCH V3] config/arm: add Qualcomm Centriq 2400 part > number

Re: [dpdk-dev] [EXT] [PATCH v3] doc: announce API changes for Windows compatibility

2021-06-17 Thread Tyler Retzlaff
On Thu, May 20, 2021 at 08:17:54PM +, Akhil Goyal wrote: > > > > Yes it makes more sense now. But ideally it should be fixed in windows. they won't be fixed in windows. it is extremely rare to withdraw something from a platform headers namespace and is avoided to maintain API compatibility

Re: [dpdk-dev] [PATCH v2] app/testpmd: send failure logs to stderr

2021-06-17 Thread Andrew Rybchenko
Hi On 6/17/21 6:29 AM, Li, Xiaoyun wrote: > Hi > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Thursday, June 17, 2021 00:32 >> To: Li, Xiaoyun ; Ori Kam >> Cc: dev@dpdk.org; Richardson, Bruce ; Yigit, >> Ferruh ; Singh, Aman Deep >> >> Subject: [PATCH v2] app/testpmd: send

Re: [dpdk-dev] [PATCH] raw/ioat: fix missing ring pointer reset

2021-06-17 Thread Bruce Richardson
On Thu, Jun 17, 2021 at 02:18:15PM +, Kevin Laatz wrote: > In the event of a device reconfigure, "hdls_avail" is not being reset. This > can lead to miscalculations in rte_ioat_completed_ops(), causing the > function to report an incorrect amount of completed operations. This patch > fixes the

Re: [dpdk-dev] [PATCH] raw/ioat: fix memory leak in device configure

2021-06-17 Thread Bruce Richardson
On Thu, Jun 17, 2021 at 02:17:52PM +, Kevin Laatz wrote: > During device configure, memory is allocated for "hdl_ring_flags". In the > event of another call to the device configure function (reconfigure), a > memory leak would occur. This patch fixes the memory leak by free'ing the > memory bef

[dpdk-dev] [PATCH] raw/ioat: fix missing ring pointer reset

2021-06-17 Thread Kevin Laatz
In the event of a device reconfigure, "hdls_avail" is not being reset. This can lead to miscalculations in rte_ioat_completed_ops(), causing the function to report an incorrect amount of completed operations. This patch fixes the issue by resetting "hdls_avail" during the device configure. Fixes:

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-17 Thread Bruce Richardson
On Thu, Jun 17, 2021 at 12:02:00PM +0100, Bruce Richardson wrote: > On Thu, Jun 17, 2021 at 05:48:05PM +0800, fengchengwen wrote: > > On 2021/6/17 1:31, Bruce Richardson wrote: > > > On Wed, Jun 16, 2021 at 05:41:45PM +0800, fengchengwen wrote: > > >> On 2021/6/16 0:38, Bruce Richardson wrote: > >

[dpdk-dev] [PATCH] raw/ioat: fix memory leak in device configure

2021-06-17 Thread Kevin Laatz
During device configure, memory is allocated for "hdl_ring_flags". In the event of another call to the device configure function (reconfigure), a memory leak would occur. This patch fixes the memory leak by free'ing the memory before reallocating it. Fixes: 245efe544d8e ("raw/ioat: report status o

[dpdk-dev] [PATCH v2 3/3] net/virtio: add MAC device config getter and setter

2021-06-17 Thread Maxime Coquelin
This patch uses the new device config ops to get and set the MAC address if supported. If a valid MAC address is passed as devarg of the Virtio-user PMD, the driver will try to store it in the device config space. Otherwise the one provided in the device config space will be used, if available. S

[dpdk-dev] [PATCH v2 2/3] net/virtio: add device config support to vDPA

2021-06-17 Thread Maxime Coquelin
This patch introduces two virtio-user callbacks to get and set device's config, and implements it for vDPA backends. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h | 3 + drivers/net/virtio/virtio_user/vhost_vdpa.c | 69 + 2 files changed, 72

[dpdk-dev] [PATCH v2 1/3] net/virtio: keep device and frontend features separated

2021-06-17 Thread Maxime Coquelin
This patch is preliminary rework to add support for getting and setting device's config space. In order to get or set a device config such as its MAC address, we need to know whether the device itself support the feature, or if it is emulated by the frontend. Signed-off-by: Maxime Coquelin Revie

[dpdk-dev] [PATCH v2 0/3] net/virtio: add vdpa device config support

2021-06-17 Thread Maxime Coquelin
This patch adds vDPA device config space requests support. For now, it only adds MAC address get and set. It may be extended in next revision to support other configs like link state. Regarding the MAC selection strategy, if devargs MAC address is set by the user and valid, the driver tries to sto

[dpdk-dev] [Bug 742] intermittent func_reentrancy_autotest failures

2021-06-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=742 Bug ID: 742 Summary: intermittent func_reentrancy_autotest failures Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-17 Thread Ferruh Yigit
On 6/14/2021 4:54 PM, Ananyev, Konstantin wrote: > > >>> >>> 14/06/2021 15:15, Bruce Richardson: On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon >> Sent: Monday, 14 June 2021 12.59 >> >> Pe

Re: [dpdk-dev] [PATCH 2/3] net/virtio: add device config support to vDPA

2021-06-17 Thread Maxime Coquelin
On 6/16/21 2:26 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Tuesday, June 8, 2021 10:14 PM >> To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; >> david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject: [PATCH 2/3] net/virtio:

[dpdk-dev] [PATCH V5] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
0xc00 is for "SoC 2.0" Qualcomm Centriq servers. 0x800 is for "SoC 1.1". Cc: Jerin Jacob Cc: Ruifeng Wang Cc: Honnappa Nagarahalli Cc: Juraj Linkeš Signed-off-by: Thierry Herbelot -- V2: add maintainers as Cc V3: fix meson syntax for the SoC v1.1 machine description V4: add new soc_centriq24

Re: [dpdk-dev] [PATCH] net/mlx5: convert meta register to big-endian

2021-06-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 16, 2021 5:46 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH] net/mlx5: convert meta register to big-endian > > Metadata is stored in the CPU order (little-endian

Re: [dpdk-dev] [PATCH] net/mlx5: fix modify field action order for MAC

2021-06-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 16, 2021 5:43 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: fix modify field action order for MAC > > MAC addresses are split into 2 p

[dpdk-dev] [PATCH V4] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
0xc00 is for "SoC 2.0" Qualcomm Centriq servers. 0x800 is for "SoC 1.1". Cc: Jerin Jacob Cc: Ruifeng Wang Cc: Honnappa Nagarahalli Cc: Juraj Linkeš Signed-off-by: Thierry Herbelot -- V2: add maintainers as Cc V3: fix meson syntax for the SoC v1.1 machine description V4: add new soc_centriq24

Re: [dpdk-dev] [PATCH V3] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
On 6/17/21 12:03 PM, Ruifeng Wang wrote: -Original Message- From: Thierry Herbelot Sent: Thursday, June 17, 2021 4:16 PM To: dev@dpdk.org Cc: Thierry Herbelot ; tho...@monjalon.net; jer...@marvell.com; Ruifeng Wang ; Honnappa Nagarahalli ; Juraj Linkeš Subject: [PATCH V3] config/arm: ad

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-17 Thread Bruce Richardson
On Thu, Jun 17, 2021 at 05:48:05PM +0800, fengchengwen wrote: > On 2021/6/17 1:31, Bruce Richardson wrote: > > On Wed, Jun 16, 2021 at 05:41:45PM +0800, fengchengwen wrote: > >> On 2021/6/16 0:38, Bruce Richardson wrote: > >>> On Tue, Jun 15, 2021 at 09:22:07PM +0800, Chengwen Feng wrote: > Th

[dpdk-dev] [PATCH 7/7] vhost: convert inflight data to DPDK allocation API

2021-06-17 Thread Maxime Coquelin
Inflight metadata are allocated using glibc's calloc. This patch converts them to rte_zmalloc_socket to take care of the NUMA affinity. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 4 +-- lib/vhost/vhost_user.c | 67 +++--- 2 files changed, 58

[dpdk-dev] [PATCH 6/7] vhost: allocate all data on same node as virtqueue

2021-06-17 Thread Maxime Coquelin
This patch saves the NUMA node the virtqueue is allocated on at init time, in order to allocate all other data on the same node. While most of the data are allocated before numa_realloc() is called and so the data will be reallocated properly, some data like the log cache are most likely allocated

[dpdk-dev] [PATCH 5/7] vhost: improve NUMA reallocation

2021-06-17 Thread Maxime Coquelin
This patch improves the numa_realloc() function by making use of rte_realloc_socket(), which takes care of the memory copy and freeing of the old data. Suggested-by: David Marchand Signed-off-by: Maxime Coquelin --- lib/vhost/vhost_user.c | 190 + 1 file

[dpdk-dev] [PATCH 4/7] vhost: fix NUMA reallocation with multiqueue

2021-06-17 Thread Maxime Coquelin
Since the Vhost-user device initialization has been reworked, enabling the application to start using the device as soon as the first queue pair is ready, NUMA reallocation no more happened on queue pairs other than the first one since numa_realloc() was returning early if the device was running.

[dpdk-dev] [PATCH 3/7] vhost: fix missing cache logging NUMA realloc

2021-06-17 Thread Maxime Coquelin
When the guest allocates virtqueues on a different NUMA node than the one the Vhost metadata are allocated, both the Vhost device struct and the virtqueues struct are reallocated. However, reallocating the log cache on the new NUMA node was not done. This patch fixes this by reallocating it if it

[dpdk-dev] [PATCH 1/7] vhost: fix missing memory table NUMA realloc

2021-06-17 Thread Maxime Coquelin
When the guest allocates virtqueues on a different NUMA node than the one the Vhost metadata are allocated, both the Vhost device struct and the virtqueues struct are reallocated. However, reallocating the Vhost memory table was missing, which likely causes iat least one cross-NUMA accesses for ev

[dpdk-dev] [PATCH 2/7] vhost: fix missing guest pages table NUMA realloc

2021-06-17 Thread Maxime Coquelin
When the guest allocates virtqueues on a different NUMA node than the one the Vhost metadata are allocated, both the Vhost device struct and the virtqueues struct are reallocated. However, reallocating the guest pages table was missing, which likely causes at least one cross-NUMA accesses for ever

[dpdk-dev] [PATCH 0/7] vhost: Fix and improve NUMA reallocation

2021-06-17 Thread Maxime Coquelin
This patch series first fixes missing reallocations of some Virtqueue and device metadata. Then, it improves the numa_realloc function by using rte_realloc_socket API that takes care of the memcpy & freeing. The VQs NUMA IDs are also saved in the VQ metadata and used for every allocations so that

[dpdk-dev] [PATCH v6 19/19] net/ngbe: support to close and reset device

2021-06-17 Thread Jiawen Wu
Support to close and reset device. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 61 -- drivers/net/ngbe/ngbe_ethdev.h | 2 ++ drivers/net/ngbe/ngbe_rxtx.c | 20 +++ 3 files changed, 81 insertions(+), 2 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v6 18/19] net/ngbe: add Rx queue start and stop

2021-06-17 Thread Jiawen Wu
Initializes receive unit, support to start and stop receive unit for specified queues. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_dummy.h | 15 ++ drivers/net/ngbe/base/ngbe_hw.c| 105 ++ drivers/net/ngbe/base/ngbe_hw.h| 4 + drivers/net/ngbe/base/ngbe_type.h

[dpdk-dev] [PATCH v6 16/19] net/ngbe: add device start and stop operations

2021-06-17 Thread Jiawen Wu
Setup MSI-X interrupt, complete PHY configuration and set device link speed to start device. Disable interrupt, stop hardware and clear queues to stop device. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_dummy.h | 16 + drivers/net/ngbe/base/ngbe_hw.c | 49 +++ drivers/net/ng

[dpdk-dev] [PATCH v6 17/19] net/ngbe: add Tx queue start and stop

2021-06-17 Thread Jiawen Wu
Initializes transmit unit, support to start and stop transmit unit for specified queues. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 1 + drivers/net/ngbe/base/ngbe_type.h | 1 + drivers/net/ngbe/ngbe_ethdev.c| 3 + drivers/net/ngbe/ngbe_ethdev.h| 7 ++ drive

[dpdk-dev] [PATCH v6 14/19] net/ngbe: add simple Rx flow

2021-06-17 Thread Jiawen Wu
Initialize device with the simplest receive function. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 1 + drivers/net/ngbe/ngbe_ethdev.h | 3 + drivers/net/ngbe/ngbe_rxtx.c | 168 + drivers/net/ngbe/ngbe_rxtx.h | 81 4 file

[dpdk-dev] [PATCH v6 15/19] net/ngbe: add simple Tx flow

2021-06-17 Thread Jiawen Wu
Initialize device with the simplest transmit functions. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 1 + drivers/net/ngbe/ngbe_ethdev.h | 3 + drivers/net/ngbe/ngbe_rxtx.c | 228 + drivers/net/ngbe/ngbe_rxtx.h | 27 4 files changed,

[dpdk-dev] [PATCH v6 13/19] net/ngbe: add Tx queue setup and release

2021-06-17 Thread Jiawen Wu
Setup device Tx queue and release Tx queue. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 24 drivers/net/ngbe/ngbe_ethdev.h | 11 ++ drivers/net/ngbe/ngbe_rxtx.c | 206 + drivers/net/ngbe/ngbe_rxtx.h | 95 +++ 4 files chang

[dpdk-dev] [PATCH v6 12/19] net/ngbe: add Rx queue setup and release

2021-06-17 Thread Jiawen Wu
Setup device Rx queue and release Rx queue. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/meson.build | 1 + drivers/net/ngbe/ngbe_ethdev.c | 37 +++- drivers/net/ngbe/ngbe_ethdev.h | 16 ++ drivers/net/ngbe/ngbe_rxtx.c | 308 + drivers/net/ngbe/ngbe_rxtx.

[dpdk-dev] [PATCH v6 11/19] net/ngbe: setup the check PHY link

2021-06-17 Thread Jiawen Wu
Setup PHY, determine link and speed status from PHY. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_dummy.h | 18 +++ drivers/net/ngbe/base/ngbe_hw.c | 53 + drivers/net/ngbe/base/ngbe_hw.h | 6 + drivers/net/ngbe/base/ngbe_phy.c | 22 drivers/net/ngbe/

[dpdk-dev] [PATCH v6 10/19] net/ngbe: support link update

2021-06-17 Thread Jiawen Wu
Register to handle device interrupt. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 3 + doc/guides/nics/ngbe.rst | 5 + drivers/net/ngbe/base/ngbe_dummy.h | 6 + drivers/net/ngbe/base/ngbe_type.h | 11 + drivers/net/ngbe/ngbe_ethdev.c | 376 +

[dpdk-dev] [PATCH v6 09/19] net/ngbe: store MAC address

2021-06-17 Thread Jiawen Wu
Store MAC addresses and init receive address filters. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_dummy.h | 33 +++ drivers/net/ngbe/base/ngbe_hw.c| 323 + drivers/net/ngbe/base/ngbe_hw.h| 13 ++ drivers/net/ngbe/base/ngbe_type.h | 19 ++ drive

[dpdk-dev] [PATCH v6 08/19] net/ngbe: identify PHY and reset PHY

2021-06-17 Thread Jiawen Wu
Identify PHY to get the PHY type, and perform a PHY reset. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build| 4 + drivers/net/ngbe/base/ngbe_dummy.h | 40 +++ drivers/net/ngbe/base/ngbe_hw.c | 40 ++- drivers/net/ngbe/base/ngbe_hw.h | 2 + drivers/net/ngbe/bas

[dpdk-dev] [PATCH v6 07/19] net/ngbe: add HW initialization

2021-06-17 Thread Jiawen Wu
Initialize the hardware by resetting the hardware in base code. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_dummy.h | 21 +++ drivers/net/ngbe/base/ngbe_hw.c| 235 + drivers/net/ngbe/base/ngbe_hw.h| 9 ++ drivers/net/ngbe/base/ngbe_type.h | 30

[dpdk-dev] [PATCH v6 06/19] net/ngbe: init and validate EEPROM

2021-06-17 Thread Jiawen Wu
Reset swfw lock before NVM access, init EEPROM and validate the checksum. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 2 + drivers/net/ngbe/base/ngbe_dummy.h | 23 drivers/net/ngbe/base/ngbe_eeprom.c | 203 drivers/net/ngbe/base/ngbe_e

[dpdk-dev] [PATCH v6 05/19] net/ngbe: set MAC type and LAN ID with device initialization

2021-06-17 Thread Jiawen Wu
Add basic init and uninit function. Map device IDs and subsystem IDs to single ID for easy operation. Then initialize the shared code. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 4 +- drivers/net/ngbe/base/ngbe.h | 11 ++ drivers/net/ngbe/base/ngbe_dummy.h | 37 +

[dpdk-dev] [PATCH v6 04/19] net/ngbe: define registers

2021-06-17 Thread Jiawen Wu
Define all registers that will be used. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 1490 + 1 file changed, 1490 insertions(+) create mode 100644 drivers/net/ngbe/base/ngbe_regs.h diff --git a/drivers/net/ngbe/base/ngbe_regs.h b/drivers/net/ngb

[dpdk-dev] [PATCH v6 03/19] net/ngbe: add log type and error type

2021-06-17 Thread Jiawen Wu
Add log type and error type to trace functions. Signed-off-by: Jiawen Wu --- doc/guides/nics/ngbe.rst| 21 + drivers/net/ngbe/base/ngbe_status.h | 73 + drivers/net/ngbe/ngbe_ethdev.c | 14 ++ drivers/net/ngbe/ngbe_logs.h| 46 +

  1   2   >