[dpdk-dev] multiple dpdk instances problem in mlx5

Hi mlnx teams, I test the upstream dpdk with the mutiple dpdk instance with dpdk-testpmd I start two testpmd program and only receive the vxlan packets. # ./dpdk-testpmd -c 0x1f -n 4 -m 4096 --file-prefix=one -w ":19:00.0" --huge-dir=/mnt/dpdk1 -- -i --flow-isolate-all --forward-mod

[dpdk-dev] [PATCH v4 19/19] net/ena: update version to v2.3.0

This version update contains: * memcpy mapping to the dpdk-optimized version. * ena_com (HAL) update to the latest version (from 18.09.2020). * Bug fixes for the large LLQ headers and devargs parsing. * Mbuf RSS hash presence indication. * Bug fix for the default ring size. * Fix for th

[dpdk-dev] [PATCH v4 18/19] net/ena: report default ring size

From: Stanislaw Kardach Remove invalid ring size alignment logic and add default rx and tx port ring sizes to the device info spec. The logic in lines 1297 and 1371 is invalid. The RTE_ETH_DEV_FALLBACK_RX_RINGSIZE (and the TX counterpart) is a value that rte_eth_rx_queue_setup() will set if dev_

[dpdk-dev] [PATCH v4 17/19] net/ena: disable dev ops not supported in SMP

From: Stanislaw Kardach For dev_ops not supported in SMP, either return -EPERM or return without doing anything. In both cases log a warning. Signed-off-by: Stanislaw Kardach Reviewed-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shay Agroskin --- v4: * Fix commit heading style

[dpdk-dev] [PATCH v4 16/19] net/ena: make ethdev references SMP safe

From: Stanislaw Kardach rte_pci_device and rte_eth_dev are process-local structures. Therefore ena_adapter::pdev and ena_adapter::rte_dev cannot be used universally. Switch this to extracting those structures via rte_eth_devices indexing and remove pdev since it's not used outside of init. Signe

[dpdk-dev] [PATCH v4 15/19] net/ena: handle spurious wakeups in ENA wait event

From: Stanislaw Kardach pthread_cond_timedwait() may spuriously wakeup according to POSIX. Therefore it is required to check whether predicate is actually true before finishing the waiting loop. Signed-off-by: Stanislaw Kardach Reviewed-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-

[dpdk-dev] [PATCH v4 14/19] net/ena: remove endian swap functions

From: Stanislaw Kardach swap*_*_le() functions are not used anywhere and besides there are rte alternatives already present. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Signed-off-by: Stanislaw Kardach Reviewed-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shay Agroski

[dpdk-dev] [PATCH v4 13/19] net/ena: indicate Rx RSS hash presence

To make it possible to the app to determine if the hash was calculated for the packet or not, the PKT_RX_RSS_HASH should be set in the mbuf's ol_flags. As the PMD wasn't setting that, the application couldn't check if there is a hash in a proper way. The hash is valid only if it's UDP or TCP and

[dpdk-dev] [PATCH v4 12/19] net/ena: terminate devargs allowed keys with null

As the documentation of rte_kvargs_parse() states, the valid_keys argument must be NULL terminated. Lack of this feature may cause segmentation fault if the passed devarg will be different then the supported value. Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers") Cc: sta...@dpdk.org Sig

[dpdk-dev] [PATCH v4 11/19] net/ena: fix parsing of large LLQ header devarg

From: Igor Chauskin The code incorrectly checked the return value of comparison when parsing the argument key name. The return value of strcmp should be compared to 0 to identify a match. Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers") Cc: sta...@dpdk.org Signed-off-by: Igor Chauskin

[dpdk-dev] [PATCH v4 10/19] net/ena/base: adjust changes to lastest ena-com

From: Amit Bernstein 1. As memzone uses unique names, changed alloc coherent macro to use 64 bit size atomic variable to increase the memzone name space 2. "handle" param name change to be consistent with other macros 3. Variable definition displacement 4. Backslash alignment to column 80 Sig

[dpdk-dev] [PATCH v4 09/19] net/ena/base: use rte prefetch0 write

As in the v20.11 rte_prefetch0_write API was added, it should be used in the platform file for the definition of the macro prefetchw, instead of using simply prefetch0. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Amit Bernstein --- v4: * Fix commit heading style. dr

[dpdk-dev] [PATCH v4 08/19] net/ena/base: remove mutable RSS from the host info

This feature wasn't used by any of the drivers. Because of that, it was removed. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shay Agroskin --- drivers/net/ena/base/ena_defs/ena_admin_defs.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --g

[dpdk-dev] [PATCH v4 07/19] net/ena/base: remove indir table from ENA feat ctx

The RSS indirection table shouldn't be included as a part of the device features context. If the driver has to acquire it, it can be done using the separate API whenever the RSS configuration is needed. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Amit Bernstein ---

[dpdk-dev] [PATCH v4 06/19] net/ena/base: destroy multiple "wait events"

Although the ENA DPDK PMD doesn't have to perform any actions for destroying the wait event, some other platforms have to. The macro "ENA_WAIT_EVENT_DESTROY" was renamed to "ENA_WAIT_EVENTS_DESTROY" and also whole implementation responsible for that was moved to a separate function for better read

[dpdk-dev] [PATCH v4 05/19] net/ena/base: fix issues from the static code scan

To silence error messages from the static code analysis, make the type conversions explicit where they're intended. Also fix the type for the DMA width value. Fixes: 99ecfbf845b3 ("ena: import communication layer") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin R

[dpdk-dev] [PATCH v4 04/19] net/ena/base: style and comments improvements

List of changes: * Comment style was adjusted for the functions * The keys_num at "struct ena_admin_feature_rss_flow_hash_control" was renamed to the key_parts to better describe it's meaning * The RSS indirection table was called "REDIRECTION" -> changed to INDIRECTION * Change AEN

[dpdk-dev] [PATCH v4 03/19] net/ena/base: add dev arg to the logging macros

Some platforms may make use of the device argument to make the logs more verbose and specific for the appropriate device. As it's not used by the ENA DPDK PMD for the logging, the type is just defined, but never used. It may be reconsidered to change this in the future by adding port ID to the me

[dpdk-dev] [PATCH v4 02/19] net/ena/base: unify arg names for the functions

Instead of using 'queue' for struct ena_com_admin_queue and 'dev' for struct ena_com_dev variables, use more descriptive 'admin_queue' and 'ena_dev'. This also unifies the names of variables of the type struct ena_com_dev in the driver. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin

[dpdk-dev] [PATCH v4 01/19] net/ena: switch memcpy to dpdk-optimized version

From: Igor Chauskin memcpy is now mapped to rte_memcpy macro on x86 architectures. Fixes: 9ba7981ec992 ("ena: add communication layer for DPDK") Cc: sta...@dpdk.org Signed-off-by: Igor Chauskin Reviewed-by: Michal Krawczyk Reviewed-by: Artur Rojek --- v4: * Add release notes v2: * Fix neste

[dpdk-dev] [PATCH v4 00/19] net/ena: update ENA PMD to v2.3.0

Hi, this version updates the driver to version 2.3.0, which fixes multiple bugs, contains part of the work on making the ENA PMD fully MP aware, and also updates HAL to the latest version. More detailed list of changes: * memcpy mapping to the dpdk-optimized version. * ena_com (HAL) update to

[dpdk-dev] DTS improvement WG - Debate/triag inputs

Hello, We will continuing debating/triaging the inputs from [1]. It would be helpful if everyone can review and come prepared for the meeting. I will send out the MoM for the last meeting soon. Thank you, Honnappa [1] https://docs.google.com/document/d/1c5S0_mZzFvzZfYkq

[dpdk-dev] [PATCH 2/2] net/mlx5: fix ASO age null context issue

The flow context in the rte_flow_action_age structure was set by user, and reported by the MLX5 PMD while calling rte_flow_get_aged_flow API. If the flow context was NULL while create ASO age action, while flow aged, the PMD report the NULL context to user. This patch adds the checking if context

[dpdk-dev] [PATCH 1/2] net/mlx5: fix the checking for age action

Current the ASO age action was supported in the non-root table, and the counter based age action was be used in the root table. The FDB table skips group 0 on MLX5 PMD by adding implicit rule that jump to non-root table, but PMD code use the original group value for checking. This patch uses the

Re: [dpdk-dev] : nvgre inner rss problem in mlx5

Will do. Thanks BR wenxu 发件人：Asaf Penso 发送日期：2021-05-10 16:05:54 收件人：wenxu 抄送人："dev@dpdk.org" 主题：RE: Re:: [dpdk-dev] nvgre inner rss problem in mlx5 Hello Wenxu, Can you please create a new BZ ticket? Looks like this is not handled properly in our pmd and we’ll handle it and update.

Re: [dpdk-dev] [PATCH v3 2/3] common/iavf: fix V-channel status

> -Original Message- > From: Zhang, AlvinX > Sent: Tuesday, May 11, 2021 10:03 AM > To: Xing, Beilei ; Xu, Ting > Cc: dev@dpdk.org; Zhang, AlvinX ; > sta...@dpdk.org > Subject: [PATCH v3 2/3] common/iavf: fix V-channel status > > Add VIRTCHNL_STATUS_ERR_NOT_IMPLEMENTED to enum > virtc

[dpdk-dev] [PATCH v2] net/i40e: fix offload flag checking in simple Tx datapath

Tx offload flags 'PKT_TX_IPV6, PKT_TX_IPV4, PKT_TX_OUTER_IPV6, PKT_TX_OUTER_IPV4' are supported in simple datapath. This patch removes these offload flags from packet checking in simple Tx datapath and defines 2 macro I40E_TX_OFFLOAD_SIMPLE_SUP_MASK and I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK. Fixes:

Re: [dpdk-dev] [PATCH v3 2/2] eal: fix side effects in ptr align macros

> -Original Message- > From: pbhagavat...@marvell.com > Sent: Tuesday, May 11, 2021 03:40 > To: david.march...@redhat.com; Wang, Haiyue ; Matan > Azrad ; > Shahaf Shuler ; Viacheslav Ovsiienko > ; Jiawen Wu > ; Jian Wang ; Chautru, > Nicolas > ; Thomas Monjalon ; Yigit, > Ferruh > ; An

[dpdk-dev] [PATCH v2] net/iavf: fix error logs

Remove some useless logs which are duplicated of the lower-level function logs and may confuse users when running VF without some features that not supported by PF. Fixes: 5a038d19962d ("net/iavf: fix RSS configuration on i40e VF") Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS") Signed-off-

[dpdk-dev] [PATCH v3 3/3] net/iavf: fix V-channel message status

Add support of VIRTCHNL_STATUS_ERR_NOT_IMPLEMENTED for facilitating compatibility with PF. Change the error log-level from ERROR to WARNING when a V-channel message is not supported by PF, because the VF may still be able to run without certain features which not supported by PF. Fixes: 0c35eecfe

[dpdk-dev] [PATCH v3 2/3] common/iavf: fix V-channel status

Add VIRTCHNL_STATUS_ERR_NOT_IMPLEMENTED to enum virtchnl_status_code. Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/common/iavf/virtchnl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/common/iavf/virtchn

[dpdk-dev] [PATCH v3 1/3] net/i40e: fix return status for unsupported VF message

This patch modifies the return status for unsupported VF messages, in order to make it the same as the return status of the kernel driver. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/i40e/i40e_pf.c | 4 ++-- 1 file changed, 2

Re: [dpdk-dev] [PATCH 3/4] net/ice/base: fix build with gcc11

> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, May 11, 2021 01:28 > To: Wang, Haiyue ; Yang, Qiming > ; Zhang, Qi Z > ; Stillwell Jr, Paul M ; > Lu, Wenzhuo > ; Rong, Leyi ; Shukla, Shivanshu > > Cc: dev@dpdk.org; sta...@dpdk.org; Kevin Traynor ; Ajit > Khaparde > > Subje

[dpdk-dev] [PATCH v2 3/3] net/iavf: fix V-channel message status

Add support of VIRTCHNL_STATUS_ERR_NOT_IMPLEMENTED for facilitating compatibility with PF. Chang the error log-level from ERROR to WARNING when a V-channel message is not supported by PF, because the VF may still be able to run without certain features which not supported by PF. Fixes: 0c35eecfe8

[dpdk-dev] [PATCH v2 2/3] common/iavf: fix V-channel status

Add VIRTCHNL_STATUS_ERR_NOT_IMPLEMENTED to enum virtchnl_status_code. Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/common/iavf/virtchnl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/common/iavf/virtchn

[dpdk-dev] [PATCH v2 1/3] net/i40e: fix return status for unsupported VF message

This patch modifies the return status for unsupported VF messages, in order to make it the same as the return status of the kernel driver. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/i40e/i40e_pf.c | 4 ++-- 1 file changed, 2

Re: [dpdk-dev] [PATCH v2] test/timer: fix memzone reserve failure check

在 2021/5/10 22:13, Thomas Monjalon 写道: 04/05/2021 03:07, Min Hu (Connor): Segmentation fault may occur without checking if memzone reserves succeed or not. The sentence is confusing. Please try to make it more logical. Something like "It was potentially dereferencing a null pointer. It is f

[dpdk-dev] [PATCH v3] test/timer: fix memzone reserve failure check

Segmentation fault may occur without checking if memzone reserves succeed or not. This patch fixed it. Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- v3: * do not split error messages. v2: * use TEST_ASSERT_NOT_

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

> > > > > The patch still holds true for CRC though as it is listed separately > > below > > https://developer.arm.com/architectures/cpu-architecture/a- > > profile/exploration-tools/feature-names-for-a-profile CRC is mandatory starting in V8.1, refer to Arm-ARM document. > > > > Also, looks lik

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

> >> > >> >05/05/2021 14:14, pbhagavat...@marvell.com: > >> >> From: Pavan Nikhilesh > >> >> > >> >> The ARM architecture allows SoCs to have extensions in addition to > >> >> base profiles such as Large System Extension (LSE), CRC etc. > >> >> > >> >> Add ability to declare SoC specific extensio

[dpdk-dev] [PATCH] doc: fix build with Sphinx 4

Sphinx 4.0 became stricter with permalink configuration: " html_add_permalinks has been deprecated since v3.5.0. Please use html_permalinks and html_permalinks_icon instead. " The new variable is used while keeping compatibility with older Sphinx versions. Signed-off-by: Thomas Monjalon --- doc

Re: [dpdk-dev] [PATCH v3] eal: fix memory mapping for 32-bit targets

On Mon, May 10, 2021 at 11:55 AM Thomas Monjalon wrote: > 10/05/2021 17:31, Burakov, Anatoly: > > On 10-May-21 1:42 PM, Thomas Monjalon wrote: > > > +Cc Anatoly > > > > > > 08/05/2021 16:27, Lance Richardson: > > >> For 32-bit targets, size_t is normally a 32-bit type and > > >> does not have suf

[dpdk-dev] [PATCH v3 2/2] eal: fix side effects in ptr align macros

From: Pavan Nikhilesh Avoid expanding parameters inside RTE_*_ALIGN macros. Update common_autotest to detect macro side effects. Workaround static arrays relying on RTE_ALIGN macros. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh Signed-off-by:

[dpdk-dev] [PATCH v3 1/2] eal: fix side effects in align mul macros

From: Pavan Nikhilesh Avoid expanding parameters inside the macro multiple times. For example: RTE_ALIGN_MUL_NEAR(rte_rdtsc() - start, CYC_PER_10MHZ); Here rte_rdtsc() call is expanded multiple times in the macro causing it to return different values that leads to unintended side effects.

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

>-Original Message- >From: dev On Behalf Of Honnappa >Nagarahalli >Sent: Monday, May 10, 2021 10:51 PM >To: Pavan Nikhilesh Bhagavatula ; >tho...@monjalon.net >Cc: Jerin Jacob Kollanukkaran ; >juraj.lin...@pantheon.tech; Jan Viktorin ; >Ruifeng Wang ; Bruce Richardson >; dev@dpdk.org; n

Re: [dpdk-dev] [PATCH 3/4] net/ice/base: fix build with gcc11

On 5/10/2021 6:13 PM, Wang, Haiyue wrote: >> -Original Message- >> From: Wang, Haiyue >> Sent: Tuesday, May 11, 2021 01:05 >> To: Ferruh Yigit ; Yang, Qiming >> ; Zhang, Qi Z >> ; Stillwell Jr, Paul M >> ; Lu, Wenzhuo >> ; Rong, Leyi ; Shukla, Shivanshu >> >> Cc: Yigit, Ferruh ; dev@dpdk

Re: [dpdk-dev] [PATCH 3/4] net/ice/base: fix build with gcc11

On 5/10/2021 6:04 PM, Wang, Haiyue wrote: >> -Original Message- >> From: dev On Behalf Of Ferruh Yigit >> Sent: Monday, May 10, 2021 23:03 >> To: Yang, Qiming ; Zhang, Qi Z >> ; Stillwell Jr, Paul M >> ; Lu, Wenzhuo ; Rong, >> Leyi ; >> Shukla, Shivanshu >> Cc: Yigit, Ferruh ; dev@dpdk.

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

> > >05/05/2021 14:14, pbhagavat...@marvell.com: > >> From: Pavan Nikhilesh > >> > >> The ARM architecture allows SoCs to have extensions in addition to > >> base profiles such as Large System Extension (LSE), CRC etc. > >> > >> Add ability to declare SoC specific extensions. > >> > >> Signed-of

Re: [dpdk-dev] [PATCH 3/4] net/ice/base: fix build with gcc11

> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, May 11, 2021 01:05 > To: Ferruh Yigit ; Yang, Qiming > ; Zhang, Qi Z > ; Stillwell Jr, Paul M ; > Lu, Wenzhuo > ; Rong, Leyi ; Shukla, Shivanshu > > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org; > Kevin Traynor > ; Ajit Kha

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

>05/05/2021 14:14, pbhagavat...@marvell.com: >> From: Pavan Nikhilesh >> >> The ARM architecture allows SoCs to have extensions in addition >> to base profiles such as Large System Extension (LSE), CRC etc. >> >> Add ability to declare SoC specific extensions. >> >> Signed-off-by: Pavan Nikhilesh

Re: [dpdk-dev] [PATCH 3/4] net/ice/base: fix build with gcc11

> -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Monday, May 10, 2021 23:03 > To: Yang, Qiming ; Zhang, Qi Z ; > Stillwell Jr, Paul M > ; Lu, Wenzhuo ; Rong, > Leyi ; > Shukla, Shivanshu > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org; > Kevin Traynor > ; Ajit Kha

[dpdk-dev] [PATCH] examples/l3fwd: change mq-mode on single queue devices

From: "Chaoyong.He" Set the Rx multi-queue mode to NONE when configuring a port that is associated with hardware that only supports a single Rx queue. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- examples/l3fwd/main.c | 4 1 file changed, 4 ins

[dpdk-dev] [PATCH] net/nfp: fix reporting of RSS capabilities

Before this change the dev_infos callback always reported RSS capabilities regardless of whether the capability is supported by the device or not. First check the capabilities field in the BAR of the device and advertise RSS functionality accordingly. Fixes: 8b945a7f7d ("drivers/net: update Rx RSS

Re: [dpdk-dev] [PATCH 1/3] app/flow-perf: support meter policy API

Hi guys, I have some issues w/ this patch, please exclude my ack for now. Can you please check my comments on the this previous patch in ML? BRs, Wisam Jaddo Get Outlook for iOS From: Jiawei(Jonny) Wang Sent: Monday, May 10, 2021 7:17:21

[dpdk-dev] [PATCH 3/3] app/flow-perf: add the supports for meter PPS

The flow perf application used the srtcm_rfc2697 as meter profile while do the meter testing. This patch adds the support new configuration parameter '--packet-mode' to generate the meter flows with the packet mode. Signed-off-by: Jiawei Wang Acked-by: Wisam Jaddo --- app/test-flow-perf/main.c

[dpdk-dev] [PATCH 2/3] app/flow-perf: add new meter CIR Configuration

Add the new meter CIR configuration parameter, user can set the different value for committed information rate(CIR) parameter. The usage as below: --meter-cir=N, default count is 125. Signed-off-by: Jiawei Wang Acked-by: Wisam Jaddo --- app/test-flow-perf/main.c | 13 +++-- do

[dpdk-dev] [PATCH 1/3] app/flow-perf: support meter policy API

Add option "policy-mtr" to indicate if meter creation will include policy or not. Meter creation will keep same without it. With "policy-mtr", policy is introduced. API create_meter_policy is to create a policy. API create_meter_rule will use it to create meter. Signed-off-by: Haifei Luo Signed-

[dpdk-dev] [PATCH 0/3] app/flow-perf: support meter policy API

This patch set contains three updates for flow perf application: 1. Adds the option 'policy-mtr' to indicate if create a meter with policy; 2. Adds the option 'meter-cir' to configure the CIR parameter; 3. Adds the option 'packet-mode' to enable the meter PPS. Jiawei Wang (3): app/flow-perf: sup

Re: [dpdk-dev] [PATCH v4] net/mlx5: fix tunnel offload private items location

On 5/10/2021 1:29 PM, Gregory Etelson wrote: > Hello Ferruh, > > The patch has failed ci/Intel-compilation test. > (http://mails.dpdk.org/archives/test-report/2021-May/193327.html) > I've checked that with Thomas. He confirmed that was a known fault and > should not affect the current patch. > Ca

Re: [dpdk-dev] [PATCH v3] eal: fix memory mapping for 32-bit targets

10/05/2021 17:31, Burakov, Anatoly: > On 10-May-21 1:42 PM, Thomas Monjalon wrote: > > +Cc Anatoly > > > > 08/05/2021 16:27, Lance Richardson: > >> For 32-bit targets, size_t is normally a 32-bit type and > >> does not have sufficient range to represent 64-bit offsets > >> that can are needed when

Re: [dpdk-dev] [PATCH v3] eal: fix memory mapping for 32-bit targets

On 10-May-21 1:42 PM, Thomas Monjalon wrote: +Cc Anatoly 08/05/2021 16:27, Lance Richardson: For 32-bit targets, size_t is normally a 32-bit type and does not have sufficient range to represent 64-bit offsets that can are needed when mapping PCI addresses. Use uint64_t instead. Found when atte

[dpdk-dev] [PATCH 4/4] net/tap: fix build with gcc11

Reproduced with '--buildtype=debugoptimized' config, compiler version: gcc (GCC) 12.0.0 20210509 (experimental) There are multiple build errors, like: In file included from ../drivers/net/tap/tap_flow.c:13: In function ‘rte_jhash_2hashes’, inlined from ‘rte_jhash’ at ../lib/hash/rte_jhash.h:28

[dpdk-dev] [PATCH 3/4] net/ice/base: fix build with gcc11

Reproduced with '--buildtype=debugoptimized' config, compiler version: gcc (GCC) 12.0.0 20210509 (experimental) There are multiple build errors, like: ../drivers/net/ice/base/ice_switch.c: In function ‘ice_add_marker_act’: ../drivers/net/ice/base/ice_switch.c:3727:15: warning: array subscr

[dpdk-dev] [PATCH 2/4] net/bnx2x: fix build with gcc11

Reproduced with '--buildtype=debugoptimized' config, compiler version: gcc (GCC) 12.0.0 20210509 (experimental) Build error: In file included from ../drivers/net/bnx2x/bnx2x.c:16: ../drivers/net/bnx2x/bnx2x.c: In function ‘bnx2x_hc_ack_sb’: ../drivers/net/bnx2x/bnx2x.h:1528:35: warning: ‘

[dpdk-dev] [PATCH 1/4] net/bnx2x: fix build with gcc11

Reproduced with '--buildtype=debugoptimized' config, compiler version: gcc (GCC) 12.0.0 20210509 (experimental) Build error: In file included from ../drivers/net/bnx2x/bnx2x_rxtx.c:8: ../drivers/net/bnx2x/bnx2x_rxtx.c: In function ‘bnx2x_upd_rx_prod_fast’: ../drivers/net/bnx2x/bnx2x.h:1528:35:

Re: [dpdk-dev] [PATCH v2] raw/ioat: fix parameter shadow warning

On Mon, May 10, 2021 at 04:06:00PM +0200, David Marchand wrote: > On Mon, May 10, 2021 at 2:55 PM Kevin Laatz wrote: > > > > In the function __idxd_completed_ops() we have a parameter shadow warning > > due to a local variable having the same name as one of the function > > parameters. This issue

Re: [dpdk-dev] [PATCH v2] test/timer: fix memzone reserve failure check

04/05/2021 03:07, Min Hu (Connor): > Segmentation fault may occur without checking if memzone > reserves succeed or not. The sentence is confusing. Please try to make it more logical. Something like "It was potentially dereferencing a null pointer. It is fixed by checking the pointer before derefe

Re: [dpdk-dev] [PATCH v2] raw/ioat: fix parameter shadow warning

On Mon, May 10, 2021 at 2:55 PM Kevin Laatz wrote: > > In the function __idxd_completed_ops() we have a parameter shadow warning > due to a local variable having the same name as one of the function > parameters. This issue is fixed by simply renaming the local variable. > > This warning was disco

[dpdk-dev] [PATCH v2 2/2] eal: fix side effects in ptr align macros

From: Pavan Nikhilesh Avoid expanding parameters inside RTE_*_ALIGN macros. Update common_autotest to detect macro side effects. Workaround static arrays relying on RTE_ALIGN macros. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh Signed-off-by:

[dpdk-dev] [PATCH v2 1/2] eal: fix side effects in align mul macros

From: Pavan Nikhilesh Avoid expanding parameters inside the macro multiple times. For example: RTE_ALIGN_MUL_NEAR(rte_rdtsc() - start, CYC_PER_10MHZ); Here rte_rdtsc() call is expanded multiple times in the macro causing it to return different values that leads to unintended side effects.

[dpdk-dev] [RFC v2] bus/auxiliary: introduce auxiliary bus

Auxiliary [1] provides a way to split function into child-devices representing sub-domains of functionality. Each auxiliary_device represents a part of its parent functionality. Auxiliary device is identified by unique device name, sysfs path: /sys/bus/auxiliary/devices/ [1] kernel auxiliary bu

[dpdk-dev] [PATCH 1/4] net/hns3: fix unsupported mbx msg id log error

From: Chengwen Feng The mailbox message id is uint8_t, but the unsupported mailbox message id was logged by uint16. Fixes: 463e748964f5 ("net/hns3: support mailbox") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_mbx.c | 2 +- 1 file

[dpdk-dev] [PATCH 3/4] net/hns3: fix memory barrier incorrectly placed

From: Chengwen Feng The memory barrier is used to ensure that the response is returned only after the Tx/Rx function is set, it should place after the Rx/Tx function is set. Fixes: 23d4b61fee5d ("net/hns3: support multiple process") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-b

[dpdk-dev] [PATCH 2/4] net/hns3: fix secondary process request start/stop Rx/Tx

From: Chengwen Feng This secondary process should not send request to start/stop Rx/Tx, this patch fixes it. Fixes: 23d4b61fee5d ("net/hns3: support multiple process") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_mp.c | 2 +- 1 fil

[dpdk-dev] [PATCH 0/4] bugfix for hns3 PMD

This patch set contains four bugfix for hns3 PMD Chengwen Feng (4): net/hns3: fix unsupported mbx msg id log error net/hns3: fix secondary process request start/stop Rx/Tx net/hns3: fix memory barrier incorrectly placed net/hns3: return fail if FEC mode not support drivers/net/hns3/hns3_

[dpdk-dev] [PATCH 4/4] net/hns3: return fail if FEC mode not support

From: Chengwen Feng If the FEC mode was not supported, it should return error code. This patch also adds a space when log error info. Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethde

Re: [dpdk-dev] [PATCH v2] raw/ioat: fix parameter shadow warning

On Mon, May 10, 2021 at 12:55:14PM +, Kevin Laatz wrote: > In the function __idxd_completed_ops() we have a parameter shadow warning > due to a local variable having the same name as one of the function > parameters. This issue is fixed by simply renaming the local variable. > > This warning w

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] eal: fix side effects in ptr align macros

Hello Pavan, On Mon, May 10, 2021 at 11:50 AM Pavan Nikhilesh Bhagavatula wrote: > > >On Sun, 9 May 2021 22:48:02 +0530 > > wrote: > > > >> From: Pavan Nikhilesh > >> > >> Avoid expanding parameters inside RTE_*_ALIGN macros. > >> Update common_autotest to detect macro side effects. > >> Workaro

Re: [dpdk-dev] [dpdk-stable] [PATCH] bus/fslmc: remove unused macro

06/05/2021 10:41, David Marchand: > Fixes: ce9efbf5bb09 ("bus/fslmc: support dynamic logging") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Acked-by: Hemant Agrawal Applied, thanks

Re: [dpdk-dev] [PATCH v2 2/2] graph: fix dereferencing null pointer

On Thu, May 6, 2021 at 9:16 AM Min Hu (Connor) wrote: > > From: HongBo Zheng > > In function 'stats_mem_init', pointer 'stats' should > be confirmed not null before memset it. > > Fixes: af1ae8b6a32c ("graph: implement stats") > Cc: sta...@dpdk.org > > Signed-off-by: HongBo Zheng > Signed-off-by

Re: [dpdk-dev] [PATCH v2 1/2] graph: fix memory leak

On Thu, May 6, 2021 at 9:16 AM Min Hu (Connor) wrote: > > From: HongBo Zheng > > Fix function 'stats_mem_populate' return without > free dynamic memory referenced by 'stats'. > > Fixes: af1ae8b6a32c ("graph: implement stats") > Cc: sta...@dpdk.org > > Signed-off-by: HongBo Zheng > Signed-off-by:

Re: [dpdk-dev] [PATCH v3] hash: fix tuple adjustment

06/05/2021 13:40, Vladimir Medvedkin: > rte_thash_adjust_tuple() uses random to generate a new subtuple if > fn() callback reports about collision. In some cases random changes > the subtuple in a way that after complementary bits are applied the > original tuple is obtained. This patch replaces ra

Re: [dpdk-dev] [PATCH] eal: fix leak in shared lib mode detection

06/05/2021 12:40, Bruce Richardson: > On Thu, May 06, 2021 at 12:06:37PM +0200, David Marchand wrote: > > This is reported by our internal covscan: > > > > 1. dpdk-20.11/lib/librte_eal/common/eal_common_options.c:508: alloc_fn: > > Storage is returned from allocation function "dlopen". > > 6. dpdk

[dpdk-dev] [PATCH v2] net/mlx5: fix LAG representor probe on PF1 PCI

In case of bonding, orchestrator wants to use same devargs for LAG and non-LAG scenario to probe representor on PF1 using PF1 PCI address like ",representor=pf1vf[0-3]". This patch changes PCI address check policy to allow PF1 PCI address for representors on PF1. Note: detaching PF0 device can't

Re: [dpdk-dev] [PATCH] config/arm: add ability to express arch extensions

05/05/2021 14:14, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > The ARM architecture allows SoCs to have extensions in addition > to base profiles such as Large System Extension (LSE), CRC etc. > > Add ability to declare SoC specific extensions. > > Signed-off-by: Pavan Nikhilesh I do

[dpdk-dev] [PATCH v2] raw/ioat: fix parameter shadow warning

In the function __idxd_completed_ops() we have a parameter shadow warning due to a local variable having the same name as one of the function parameters. This issue is fixed by simply renaming the local variable. This warning was discovered during an OVS build with DPDK 21.05-rc2. The OVS build pa

Re: [dpdk-dev] [PATCH v3] eal: fix memory mapping for 32-bit targets

+Cc Anatoly 08/05/2021 16:27, Lance Richardson: > For 32-bit targets, size_t is normally a 32-bit type and > does not have sufficient range to represent 64-bit offsets > that can are needed when mapping PCI addresses. Use uint64_t > instead. > > Found when attempting to run 32-bit Linux dpdk-test

Re: [dpdk-dev] [PATCH v4] net/mlx5: fix tunnel offload private items location

Hello Ferruh, The patch has failed ci/Intel-compilation test. (http://mails.dpdk.org/archives/test-report/2021-May/193327.html) I've checked that with Thomas. He confirmed that was a known fault and should not affect the current patch. Can we proceed with the patch integration ? Thank you. Rega

Re: [dpdk-dev] [PATCH v3 00/22] net/ena: update ENA PMD to v2.3.0

On 5/10/2021 1:02 PM, Michał Krawczyk wrote: > pt., 7 maj 2021 o 16:59 Ferruh Yigit napisał(a): >> >> On 5/6/2021 3:25 PM, Michal Krawczyk wrote: >>> Hi, >>> >>> this version updates the driver to version 2.3.0, which fixes multiple >>> bugs, contains part of the work on making the ENA PMD fully M

[dpdk-dev] [PATCH 3/3] net/iavf: fix V-channel status

Add support of VIRTCHNL_STATUS_ERR_NOT_IMPLEMENTED for facilitating compatibility with PF. Chang the error log-level from ERROR to WARNING when a V-channel message is not supported by PF, because the VF may still be able to run without certain features which not supported by PF. Fixes: 0c35eecfe8

Re: [dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version copying

Hi, > -Original Message- > From: dev On Behalf Of Kamil Vojanec > Sent: Friday, February 5, 2021 11:01 AM > To: dev@dpdk.org > Cc: vikto...@cesnet.cz; Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Subject: [dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version > copying > >

[dpdk-dev] [PATCH 2/3] common/iavf: fix V-channel status

Add VIRTCHNL_STATUS_ERR_NOT_IMPLEMENTED to enum virtchnl_status_code. Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/common/iavf/virtchnl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/common/iavf/virtchn

[dpdk-dev] [PATCH] net/iavf: fix error logs

Remove some useless logs which are duplicated of the lower-level function logs and may confuse users when running VF without some features supportted by PF. Fixes: 5a038d19962d ("net/iavf: fix RSS configuration on i40e VF") Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS") Signed-off-by: Alvi

[dpdk-dev] [PATCH 1/3] net/i40e: fix return status for unsupported VF message

This patch modifies the return status for unsupported VF messages, in order to make it the same as the return status of the kernel driver. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/i40e/i40e_pf.c | 4 ++-- 1 file changed, 2

Re: [dpdk-dev] [PATCH 0/2] bugfix for mlx4 and mlx5

10/05/2021 14:06, Chengwen Feng: > This patch set contains two bugfixes for mlx4 and mlx5. > > Chengwen Feng (2): > net/mlx4: fix memory barrier incorrectly placed > net/mlx5: fix memory barrier incorrectly placed Please could you use the option "--cc-cmd devtools/get-maintainer.sh" when send

[dpdk-dev] [PATCH 1/2] net/mlx4: fix memory barrier incorrectly placed

The memory barrier is used to ensure that the response is returned only after the Tx/Rx function is set, it should place after the Rx/Tx function is set. Fixes: 0203d33a1059 ("net/mlx4: support secondary process") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/mlx4/mlx4_mp.c |

[dpdk-dev] [PATCH 2/2] net/mlx5: fix memory barrier incorrectly placed

The memory barrier is used to ensure that the response is returned only after the Tx/Rx function is set, it should place after the Rx/Tx function is set. Fixes: 2aac5b5d119f ("net/mlx5: sync stop/start with secondary process") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/mlx

[dpdk-dev] [PATCH 0/2] bugfix for mlx4 and mlx5

This patch set contains two bugfixes for mlx4 and mlx5. Chengwen Feng (2): net/mlx4: fix memory barrier incorrectly placed net/mlx5: fix memory barrier incorrectly placed drivers/net/mlx4/mlx4_mp.c | 2 +- drivers/net/mlx5/linux/mlx5_mp_os.c | 2 +- 2 files changed, 2 insertions(+),

Re: [dpdk-dev] [PATCH] raw/ioat: fix bus requiring virtual addressing when no devs

10/05/2021 13:20, Bruce Richardson: > On Mon, May 10, 2021 at 12:18:50PM +0200, Thomas Monjalon wrote: > > 06/05/2021 17:34, Bruce Richardson: > > > On Thu, May 06, 2021 at 04:27:03PM +0100, Burakov, Anatoly wrote: > > > > On 06-May-21 4:09 PM, Bruce Richardson wrote: > > > > > If after a bus scan,

Re: [dpdk-dev] [PATCH v3 00/22] net/ena: update ENA PMD to v2.3.0

pt., 7 maj 2021 o 16:59 Ferruh Yigit napisał(a): > > On 5/6/2021 3:25 PM, Michal Krawczyk wrote: > > Hi, > > > > this version updates the driver to version 2.3.0, which fixes multiple > > bugs, contains part of the work on making the ENA PMD fully MP aware, and > > also updates HAL to the latest v

  1   2   >