Re: [dpdk-dev] [PATCH] doc: add sampling and mirroring in testpmd guide

2021-03-30 Thread Jiawei(Jonny) Wang
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Friday, March 26, 2021 1:16 AM > To: Jiawei(Jonny) Wang ; Slava Ovsiienko > ; Ori Kam ; Ferruh Yigit > > Cc: xiaoyun...@intel.com; dev@dpdk.org; Andrew Rybchenko > > Subject: Re: [PATCH] doc: add sampling and mirroring in t

Re: [dpdk-dev] [PATCH] examples/vhost: fix unchecked return value

2021-03-30 Thread Xia, Chenbo
> -Original Message- > From: dev On Behalf Of Chenbo Xia > Sent: Friday, February 19, 2021 10:40 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] examples/vhost: fix unchecked return value > > This patch fixes unchecked return value for

Re: [dpdk-dev] [dpdk-dev v21.11] [PATCH v9 8/8] eventdev: simplify Rx adapter event vector config

2021-03-30 Thread Jayatheerthan, Jay
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Tuesday, March 30, 2021 1:52 PM > To: jer...@marvell.com; Jayatheerthan, Jay ; > Carrillo, Erik G ; Gujjar, > Abhinandan S ; McDaniel, Timothy > ; hemant.agra...@nxp.com; Van > Haaren, Harry ; mattias.ronnblom > ; Ma, Liang J

Re: [dpdk-dev] [PATCH v9 4/8] eventdev: add Rx adapter event vector support

2021-03-30 Thread Jayatheerthan, Jay
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, March 31, 2021 12:10 PM > To: Jayatheerthan, Jay ; Jerin Jacob > Kollanukkaran ; Carrillo, Erik G > ; Gujjar, Abhinandan S > ; McDaniel, Timothy > ; hemant.agra...@nxp.com; Van Haaren, Harry > ; mattias.ronnblom

Re: [dpdk-dev] [PATCH] vdpa/ifc: check return value for PCI config read

2021-03-30 Thread Xia, Chenbo
> -Original Message- > From: Wang, Xiao W > Sent: Tuesday, March 9, 2021 4:43 PM > To: Xia, Chenbo > Cc: dev@dpdk.org; Wang, Xiao W ; sta...@dpdk.org > Subject: [PATCH] vdpa/ifc: check return value for PCI config read > > The return value of rte_pci_read_config should be checked. > > Co

[dpdk-dev] [PATCH 3/3] vhost: fix potential buffer overflow when batch dequeue

2021-03-30 Thread Marvin Liu
Similar as single dequeue, the multiple accesses of descriptor length will lead to potential risk. One-time access of descriptor length can eliminate this risk. Fixes: 75ed51697820 ("vhost: add packed ring batch dequeue") Cc: sta...@dpdk.org Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin

[dpdk-dev] [PATCH 2/3] vhost: fix packed ring potential buffer overflow

2021-03-30 Thread Marvin Liu
Similar as split ring, the multiple accesses of descriptor length will lead to potential risk. One-time access of descriptor length can eliminate this risk. Fixes: 2f3225a7d69b ("vhost: add vector filling support for packed ring") Cc: sta...@dpdk.org Signed-off-by: Marvin Liu Reviewed-by: Maxime

[dpdk-dev] [PATCH 1/3] vhost: fix split ring potential buffer overflow

2021-03-30 Thread Marvin Liu
In vhost datapath, descriptor's length are mostly used in two coherent operations. First step is used for address translation, second step is used for memory transaction from guest to host. But the iterval between two steps will give a window for malicious guest, in which can change descriptor leng

Re: [dpdk-dev] [PATCH v2 0/2] vhost: Add API to get negotiated protocol features

2021-03-30 Thread Xia, Chenbo
> -Original Message- > From: dev On Behalf Of Keiichi Watanabe > Sent: Monday, March 22, 2021 3:23 PM > To: dev@dpdk.org > Cc: dgr...@chromium.org; chiran...@chromium.org; Keiichi Watanabe > > Subject: [dpdk-dev] [PATCH v2 0/2] vhost: Add API to get negotiated protocol > features > > Thi

Re: [dpdk-dev] [PATCH v9 4/8] eventdev: add Rx adapter event vector support

2021-03-30 Thread Pavan Nikhilesh Bhagavatula
>> -Original Message- >> From: pbhagavat...@marvell.com >> Sent: Tuesday, March 30, 2021 1:52 PM >> To: jer...@marvell.com; Jayatheerthan, Jay >; Carrillo, Erik G >; Gujjar, >> Abhinandan S ; McDaniel, Timothy >; hemant.agra...@nxp.com; Van >> Haaren, Harry ; mattias.ronnblom >; Ma, Liang

Re: [dpdk-dev] [PATCH] doc: add sampling and mirroring in testpmd guide

2021-03-30 Thread Jiawei(Jonny) Wang
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Friday, March 26, 2021 1:11 AM > To: Jiawei(Jonny) Wang ; Slava Ovsiienko > ; xiaoyun...@intel.com; Ori Kam > > Cc: dev@dpdk.org; Andrew Rybchenko ; NBU- > Contact-Thomas Monjalon > Subject: Re: [PATCH] doc: add sampling and m

Re: [dpdk-dev] [PATCH v9 4/8] eventdev: add Rx adapter event vector support

2021-03-30 Thread Jayatheerthan, Jay
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Tuesday, March 30, 2021 1:52 PM > To: jer...@marvell.com; Jayatheerthan, Jay ; > Carrillo, Erik G ; Gujjar, > Abhinandan S ; McDaniel, Timothy > ; hemant.agra...@nxp.com; Van > Haaren, Harry ; mattias.ronnblom > ; Ma, Liang J

Re: [dpdk-dev] [PATCH v4 0/3] vhost: make virtqueue cache-friendly

2021-03-30 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, March 23, 2021 5:02 PM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; > david.march...@redhat.com; olivier.m...@6wind.com; bnem...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v4 0/3] vhost: make virtqueue cache-f

Re: [dpdk-dev] [PATCH v6 0/9] ethdev: support SubFunction representor

2021-03-30 Thread Wang, Haiyue
> -Original Message- > From: Xueming(Steven) Li > Sent: Wednesday, March 31, 2021 13:49 > To: Wang, Haiyue ; Stephen Hemminger > > Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf Penso > > Subject: RE: [dpdk-dev] [PATCH v6 0/9] ethdev: support SubFunction representor > > > > >-Original

Re: [dpdk-dev] [PATCH v6 0/9] ethdev: support SubFunction representor

2021-03-30 Thread Xueming(Steven) Li
>-Original Message- >From: Wang, Haiyue >Sent: Tuesday, February 23, 2021 7:46 PM >To: Stephen Hemminger ; Xueming(Steven) Li > >Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf Penso > >Subject: RE: [dpdk-dev] [PATCH v6 0/9] ethdev: support SubFunction representor > >> -Original Message-

Re: [dpdk-dev] [PATCH v4 0/4] net/virtio: make virtqueue struct cache-friendly

2021-03-30 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, March 16, 2021 5:38 PM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; > david.march...@redhat.com; olivier.m...@6wind.com; bnem...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v4 0/4] net/virtio: make virtqueue st

[dpdk-dev] [Bug 669] Integrity check failure occurs when ciphering and integrity both enabled with snow3g algorithm

2021-03-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=669 Bug ID: 669 Summary: Integrity check failure occurs when ciphering and integrity both enabled with snow3g algorithm Product: DPDK Version: 20.02 Hardware: x86 OS: Li

Re: [dpdk-dev] [PATCH v4] pflock: add phase-fair reader writer locks

2021-03-30 Thread Honnappa Nagarahalli
Few minor comments, overall looks good. Tested on few Arm platforms. > > This is a new type of reader-writer lock that provides better fairness > guarantees which better suited for typical DPDK applications. > A pflock has two ticket pools, one for readers and one for writers. > > Phase fair r

Re: [dpdk-dev] [PATCH 2/2] net/hns3: support IEEE 1588 PTP

2021-03-30 Thread Min Hu (Connor)
在 2021/3/30 22:12, Ferruh Yigit 写道: On 3/26/2021 8:56 AM, Min Hu (Connor) wrote: Add hns3 support for new ethdev APIs to enable and read IEEE1588/ 802.1AS PTP timestamps. Signed-off-by: Min Hu (Connor) ---   doc/guides/nics/features/hns3.ini |   2 +   doc/guides/nics/hns3.rst  |   1

Re: [dpdk-dev] [PATCH 2/2] net/hns3: support IEEE 1588 PTP

2021-03-30 Thread Min Hu (Connor)
在 2021/3/30 21:59, Ferruh Yigit 写道: On 3/26/2021 8:56 AM, Min Hu (Connor) wrote: Add hns3 support for new ethdev APIs to enable and read IEEE1588/ 802.1AS PTP timestamps. Signed-off-by: Min Hu (Connor) ---   doc/guides/nics/features/hns3.ini |   2 +   doc/guides/nics/hns3.rst  |   1

[dpdk-dev] [PATCH] mbuf: Fix illegal pointer access to mempool members

2021-03-30 Thread Wenwu Ma
Before accessing the private data of mempool in function rte_pktmbuf_priv_size() and rte_pktmbuf_data_room_size(), it is necessary to determine whether the private data exists, otherwise it will cause null pointer access. Signed-off-by: Wenwu Ma --- lib/librte_mbuf/rte_mbuf.h | 6 ++ 1 file

Re: [dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm

2021-03-30 Thread Min Hu (Connor)
在 2021/3/30 0:10, Ferruh Yigit 写道: On 3/23/2021 1:45 PM, Min Hu (Connor) wrote: From: Huisong Li The 'queue_full_cnt' stats have been encapsulated in 'dfx_stats'. However, the modification in the SVE algorithm is omitted. As a result, the driver fails to be compiled when the SVE algorithm i

[dpdk-dev] Minutes of Technical Board Meeting, 2021-03-10

2021-03-30 Thread Honnappa Nagarahalli
Minutes of Technical Board Meeting, 2021-03-10 Members Attending: - Aaron Conole - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Honnappa Nagarahalli (Chair) - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Stephen Hemminge

Re: [dpdk-dev] [PATCH v5 02/10] eal: add thread attributes

2021-03-30 Thread Stephen Hemminger
On Mon, 29 Mar 2021 15:40:32 -0700 Narcisa Ana Maria Vasile wrote: > + > +int > +rte_thread_attr_set_priority(rte_thread_attr_t *thread_attr, > + enum rte_thread_priority priority) > +{ > + if (thread_attr == NULL) { > + RTE_LOG(DEBUG, EAL, > +

Re: [dpdk-dev] [PATCH v5 09/10] eal: add EAL argument for setting thread priority

2021-03-30 Thread Stephen Hemminger
On Mon, 29 Mar 2021 15:40:39 -0700 Narcisa Ana Maria Vasile wrote: > From: Narcisa Vasile > > Allow the user to choose the thread priority through an EAL > command line argument. > > The user can select the thread priority to be either 'normal' > or 'critical': > --thread-prio normal > --threa

Re: [dpdk-dev] rte_flow ageing

2021-03-30 Thread David Bouyeure
Thanks a lot Asaf, for your answer, so fast. depending on the feature we want, the table you mentioned in the doc may give different combinations. Mine, DPDK-20.08/OFED 5.1-2, is part of the list. Anyway, my question is more about the API design. Please, find my comments below. On 3/29/21

[dpdk-dev] [PATCH v2 26/27] doc/dlb2: update documentation for v2.5

2021-03-30 Thread Timothy McDaniel
Update the dlb documentation for v2.5. Notable differences include the new cobined credit scheme. Also cleaned up a couple of sections, and removed a duplicate section. Signed-off-by: Timothy McDaniel --- doc/guides/eventdevs/dlb2.rst | 75 +-- 1 file changed, 27

[dpdk-dev] [PATCH v2 25/27] event/dlb2: update xstats for v2.5

2021-03-30 Thread Timothy McDaniel
Add DLB v2.5 specific information to xstats, such as metrics for the new credit scheme. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2_xstats.c | 41 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/drivers/event/dlb2/dlb2_xstats.c b/dr

[dpdk-dev] [PATCH v2 24/27] event/dlb2: rename dlb2_regs_new.h to dlb2_regs.h

2021-03-30 Thread Timothy McDaniel
All references to the old register map have been removed, so it is safe to rename the new combined file that supports both DLB v2.0 and DLB v2.5. Also fixed all places where this file is included. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_hw_types.h | 2

[dpdk-dev] [PATCH v2 27/27] event/dlb2: Change device name to dlb_event

2021-03-30 Thread Timothy McDaniel
Updated eventdev device name to be dlb_event instead of dlb2_event. The new name will be used for all versions of the DLB hardware. This change required corresponding changes to the the directory name that contains the PMD, as well as the documentation files, build infrastructure, and PMD specific

[dpdk-dev] [PATCH v2 20/27] event/dlb2: move dlb_resource_new.c to dlb_resource.c

2021-03-30 Thread Timothy McDaniel
The file dlb_resource_new.c now contains all of the low level functions required to support both DLB v2.0 and DLB v2.5, and the original file (dlb_resource.c) was removed in the previous commit, so rename dlb_resource_new.c to dlb_resource.c, and update the meson build file so that the new file is

[dpdk-dev] [PATCH v2 23/27] event/dlb2: delete old register map file, dlb2_regs.h

2021-03-30 Thread Timothy McDaniel
All dependencies on the old register map have been removed, so it can now be deleted. The next commit will rename dlb2_regs_new.h to dlb2_regs.h. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_regs.h | 2527 1 file changed, 2527 deletions(-) delete

[dpdk-dev] [PATCH v2 18/27] event/dlb2: consolidate resource header files into one file

2021-03-30 Thread Timothy McDaniel
A temporary version of dlb_resource.h (dlb_resource_new.h) was used by the previous commits in this patch series. Merge the two files now that DLB v2.5 support has been fully added to dlb_resource.c. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_osdep.h | 1 - driver

[dpdk-dev] [PATCH v2 21/27] event/dlb2: remove temporary file, dlb_hw_types.h

2021-03-30 Thread Timothy McDaniel
As support for DLB v2.5 was added, modifications were made to dlb_hw_types_new.h, but the old file needed to be preserved during the port in order to meet the requirement that individual patches in a series each compile successfully. Since the DLB v2.5 support is completely integrated, it is now sa

[dpdk-dev] [PATCH v2 16/27] event/dlb2: add v2.5 sparse cq mode

2021-03-30 Thread Timothy McDaniel
Update sparse cq mode mode functions for DLB v2.5, accounting for new combined register map and hardware access macros. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_resource.c| 22 --- .../event/dlb2/pf/base/dlb2_resource_new.c| 39 +++ 2 fi

[dpdk-dev] [PATCH v2 22/27] event/dlb2: move dlb2_hw_type_new.h to dlb2_hw_types.h

2021-03-30 Thread Timothy McDaniel
The original and a "new" file were maintained during the early portions of the patch series in order to ensure that all individual patches compiled cleanly. It is now safe to rename the new file, and use it unconditionally in all DLB source files. Signed-off-by: Timothy McDaniel --- .../event/dl

[dpdk-dev] [PATCH v2 15/27] event/dlb2: add v2.5 finish map/unmap

2021-03-30 Thread Timothy McDaniel
Update low level hardware funcs with map/unmap interfaces, accounting for new combined register file and hardware access macros. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_resource.c| 1054 - .../event/dlb2/pf/base/dlb2_resource_new.c| 50 + 2 f

[dpdk-dev] [PATCH v2 19/27] event/dlb2: delete old dlb2_resource.c file

2021-03-30 Thread Timothy McDaniel
The file dlb_resource_new.c now contains all of the low level functions required to support both DLB v2.0 and DLB v2.5, so delete the temporary "old" file, and stop building it. The new file (dlb_resource_new.c) will be renamed to dlb_resource.c in the next commit. Signed-off-by: Timothy McDaniel

[dpdk-dev] [PATCH v2 13/27] event/dlb2: add v2.5 credit scheme

2021-03-30 Thread Timothy McDaniel
DLB v2.5 uses a different credit scheme than was used in DLB v2.0 . Specifically, there is a single credit pool for both load balanced and directed traffic, instead of a separate pool for each as is found with DLB v2.0. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 311

[dpdk-dev] [PATCH v2 17/27] event/dlb2: add v2.5 sequence number management

2021-03-30 Thread Timothy McDaniel
Update sequence number management functions for DLB v2.5, accounting for new combined register map and hardware access macros. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_resource.c| 67 --- drivers/event/dlb2/pf/base/dlb2_resource.h| 4 +- .../event/dl

[dpdk-dev] [PATCH v2 11/27] event/dlb2: add v2.5 unmap queue

2021-03-30 Thread Timothy McDaniel
Update low level functions to account for new register map and hardware access macros. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_resource.c| 331 -- .../event/dlb2/pf/base/dlb2_resource_new.c| 298 2 files changed, 298 insertions

[dpdk-dev] [PATCH v2 10/27] event/dlb2: add v2.5 map qid

2021-03-30 Thread Timothy McDaniel
Update low level hardware functions to account for new register map and hardware access macros. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_resource.c| 355 --- .../event/dlb2/pf/base/dlb2_resource_new.c| 418 ++ 2 files changed, 418 in

[dpdk-dev] [PATCH v2 14/27] event/dlb2: add v2.5 queue depth functions

2021-03-30 Thread Timothy McDaniel
Update get queue depth functions for DLB v2.5, accounting for combined register map and new hardware access macros. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_resource.c| 160 -- .../event/dlb2/pf/base/dlb2_resource_new.c| 135 +++ 2 f

[dpdk-dev] [PATCH v2 12/27] event/dlb2: add v2.5 start domain

2021-03-30 Thread Timothy McDaniel
Update low level functions to account for new register map and hardware access macros. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_resource.c| 123 - .../event/dlb2/pf/base/dlb2_resource_new.c| 130 ++ 2 files changed, 130 insertion

[dpdk-dev] [PATCH v2 07/27] event/dlb2: add v2.5 create ldb port

2021-03-30 Thread Timothy McDaniel
Update create ldb port low level code to account for new register map and hardware access macros. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_resource.c| 490 -- .../event/dlb2/pf/base/dlb2_resource_new.c| 471 + 2 files changed, 47

[dpdk-dev] [PATCH v2 09/27] event/dlb2: add v2.5 create dir queue

2021-03-30 Thread Timothy McDaniel
Updated low level hardware functions to account for new register map and hardware access macros. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_resource.c| 213 -- .../event/dlb2/pf/base/dlb2_resource_new.c| 201 + 2 files changed, 201

[dpdk-dev] [PATCH v2 08/27] event/dlb2: add v2.5 create dir port

2021-03-30 Thread Timothy McDaniel
Updated low level hardware functions to account for new register map and access macros. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_resource.c| 426 -- .../event/dlb2/pf/base/dlb2_resource_new.c| 414 + 2 files changed, 414 insertio

[dpdk-dev] [PATCH v2 05/27] event/dlb2: add v2.5 domain reset

2021-03-30 Thread Timothy McDaniel
Convert to new register map and new register access macros. Signed-off-by: Timothy McDaniel --- .../event/dlb2/pf/base/dlb2_hw_types_new.h|1 + drivers/event/dlb2/pf/base/dlb2_resource.c| 1494 -- .../event/dlb2/pf/base/dlb2_resource_new.c| 2562 + 3 files

[dpdk-dev] [PATCH v2 04/27] event/dlb2: add v2.5 create sched domain

2021-03-30 Thread Timothy McDaniel
Update domain creation logic to account for DLB v2.5 credit scheme, new register map, and new register access macros. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2_user.h| 13 +- drivers/event/dlb2/pf/base/dlb2_resource.c| 645 .../event/dlb2/p

[dpdk-dev] [PATCH v2 06/27] event/dlb2: add V2.5 create ldb queue

2021-03-30 Thread Timothy McDaniel
Updated low level hardware functions to add DLB 2.5 support for creating load balanced queues. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/base/dlb2_resource.c| 397 -- .../event/dlb2/pf/base/dlb2_resource_new.c| 391 + 2 files changed, 391 i

[dpdk-dev] [PATCH v2 03/27] event/dlb2: add v2.5 get_resources

2021-03-30 Thread Timothy McDaniel
DLB v2.5 uses a new credit scheme, where directed and load balanced credits are unified, instead of having separate directed and load balanced credit pools. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 20 -- drivers/event/dlb2/dlb2_user.h

[dpdk-dev] [PATCH v2 00/27] Add DLB V2.5

2021-03-30 Thread Timothy McDaniel
This patch series adds support for DLB v2.5 to the current DLB V2.0 PMD. The resulting PMD supports both hardware versions. The main differences between the DLB v2.5 and v2.0 hardware are: - Number of queues/ports - DLB v2.5 uses a combined credit pool, whereas DLB v2.0 splits credits into 2 poo

[dpdk-dev] [PATCH v2 01/27] event/dlb2: add v2.5 probe

2021-03-30 Thread Timothy McDaniel
This commit adds dlb v2.5 probe support, and updates parameter parsing. The dlb v2.5 device differs from dlb v2, in that the number of resources (ports, queues, ...) is different, so macros have been added to take the device version into account. This commit also cleans up a few issues in the ori

[dpdk-dev] [PATCH 1/1] app/test: fix TCP header initialization

2021-03-30 Thread Lance Richardson
Initialize TCP data offset field with TCP header length, this field is used to derive L4 header length and by hardware to validate a TCP header. Fixes: 41f72ec94074 ("test: add packet burst generator functions") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson --- app/test/packet_burst_gener

Re: [dpdk-dev] [PATCH 3/3] power: do not skip saving original pstate governor

2021-03-30 Thread Burakov, Anatoly
On 30-Mar-21 3:15 PM, Anatoly Burakov wrote: Currently, when we set the pstate governor to "performance", we check if it is already set to this value, and if it is, we skip setting it. However, we never save this value anywhere, so that next time we come back and request the governor to be set t

Re: [dpdk-dev] [PATCH v2 3/3] power: do not skip saving original pstate governor

2021-03-30 Thread Burakov, Anatoly
On 30-Mar-21 3:25 PM, Anatoly Burakov wrote: Currently, when we set the pstate governor to "performance", we check if it is already set to this value, and if it is, we skip setting it. However, we never save this value anywhere, so that next time we come back and request the governor to be set t

Re: [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test framework

2021-03-30 Thread Doherty, Declan
Hey Aaron, based on the work you've been doing on the unit test documentation we would appreciate if you could take a look over this patchset and get your thoughts. The primary drive here is to make it easier to get a clear picture of what is being executed in the cryptodev testsuite, as at t

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

2021-03-30 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 06:58:56PM +0100, Ilya Maximets wrote: > On 3/25/21 5:43 PM, Stefan Hajnoczi wrote: > > On Thu, Mar 25, 2021 at 12:00:11PM +0100, Ilya Maximets wrote: > >> On 3/25/21 10:35 AM, Stefan Hajnoczi wrote: > >>> On Wed, Mar 24, 2021 at 02:11:31PM +0100, Ilya Maximets wrote: >

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log

2021-03-30 Thread Ferruh Yigit
On 3/29/2021 8:07 AM, Li, Xiaoyun wrote: Hi -Original Message- From: Min Hu (Connor) Sent: Monday, March 29, 2021 14:47 To: dev@dpdk.org Cc: Yigit, Ferruh ; Li, Xiaoyun Subject: [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log From: Hongbo Zheng This patch adds more err

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log

2021-03-30 Thread Ferruh Yigit
On 3/29/2021 7:46 AM, Min Hu (Connor) wrote: From: Hongbo Zheng This patch adds more err info for Tx/Rx descriptor query command. Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status") Cc: sta...@dpdk.org Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) Off the

[dpdk-dev] [PATCH v2 3/3] power: do not skip saving original pstate governor

2021-03-30 Thread Anatoly Burakov
Currently, when we set the pstate governor to "performance", we check if it is already set to this value, and if it is, we skip setting it. However, we never save this value anywhere, so that next time we come back and request the governor to be set to its original value, the original value is emp

[dpdk-dev] [PATCH v2 2/3] power: refactor pstate sysfs handling

2021-03-30 Thread Anatoly Burakov
Make use of new sysfs handling functions in other pstate code. Signed-off-by: Anatoly Burakov --- lib/librte_power/power_pstate_cpufreq.c | 177 +++- 1 file changed, 80 insertions(+), 97 deletions(-) diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/po

[dpdk-dev] [PATCH v2 1/3] power: refactor base frequency detection

2021-03-30 Thread Anatoly Burakov
Currently, base frequency detection code is a bit of an unmaintainable mess that has a couple of Coverity issues (dead code, and a resource leak). Rather than just fixing the issues and leaving the rest in place, refactor the code in a way that makes it more maintainable and less prone to such Cove

[dpdk-dev] [PATCH 3/3] power: do not skip saving original pstate governor

2021-03-30 Thread Anatoly Burakov
Currently, when we set the pstate governor to "performance", we check if it is already set to this value, and if it is, we skip setting it. However, we never save this value anywhere, so that next time we come back and request the governor to be set to its original value, the original value is emp

[dpdk-dev] [PATCH 2/3] power: refactor pstate sysfs handling

2021-03-30 Thread Anatoly Burakov
Make use of new sysfs handling functions in other pstate code. Signed-off-by: Anatoly Burakov --- lib/librte_power/power_pstate_cpufreq.c | 177 +++- 1 file changed, 80 insertions(+), 97 deletions(-) diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/po

[dpdk-dev] [PATCH 1/3] power: refactor base frequency detection

2021-03-30 Thread Anatoly Burakov
Currently, base frequency detection code is a bit of an unmaintainable mess that has a couple of Coverity issues (dead code, and a resource leak). Rather than just fixing the issues and leaving the rest in place, refactor the code in a way that makes it more maintainable and less prone to such Cove

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix error path inconsistency

2021-03-30 Thread Ferruh Yigit
On 3/26/2021 9:39 AM, Ivan Malov wrote: At the fail label, there's a statement to set general errno and error message. However, before the label is reached, a custom error message can be set by the code which parses actions. This custom (action-specific) message, when present, must not be replace

Re: [dpdk-dev] [PATCH 2/2] net/hns3: support IEEE 1588 PTP

2021-03-30 Thread Ferruh Yigit
On 3/26/2021 8:56 AM, Min Hu (Connor) wrote: Add hns3 support for new ethdev APIs to enable and read IEEE1588/ 802.1AS PTP timestamps. Signed-off-by: Min Hu (Connor) --- doc/guides/nics/features/hns3.ini | 2 + doc/guides/nics/hns3.rst | 1 + drivers/net/hns3/hns3_cmd.h |

Re: [dpdk-dev] [PATCH v5 8/8] net/igc: refine debug build option

2021-03-30 Thread Ferruh Yigit
On 3/25/2021 3:43 PM, Ferruh Yigit wrote: On 3/24/2021 8:31 PM, David Marchand wrote: On Wed, Mar 24, 2021 at 8:27 PM Ferruh Yigit wrote: On 3/23/2021 11:07 AM, Qi Zhang wrote: 1. replace RTE_LIBRTE_IGC_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IGC_DEBUG_TX whth RTE_ETHDEV_DEB

Re: [dpdk-dev] [PATCH] net/i40e: fix inappropriate config during flow validate

2021-03-30 Thread Xing, Beilei
> -Original Message- > From: Yang, MurphyX > Sent: Friday, March 19, 2021 10:44 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Xing, Beilei ; Yang, SteveX ; > Zhang, RobinX ; Yang, MurphyX > > Subject: [PATCH] net/i40e: fix inappropriate config during flow validate > > The co

Re: [dpdk-dev] [PATCH 2/2] net/hns3: support IEEE 1588 PTP

2021-03-30 Thread Ferruh Yigit
On 3/26/2021 8:56 AM, Min Hu (Connor) wrote: Add hns3 support for new ethdev APIs to enable and read IEEE1588/ 802.1AS PTP timestamps. Signed-off-by: Min Hu (Connor) --- doc/guides/nics/features/hns3.ini | 2 + doc/guides/nics/hns3.rst | 1 + drivers/net/hns3/hns3_cmd.h |

Re: [dpdk-dev] [PATCH] net/af_xdp: fix unchecked return of recvfrom()

2021-03-30 Thread Ferruh Yigit
On 3/25/2021 8:22 AM, Ciara Loftus wrote: Coverity complains that the return value of recvfrom() in the AF_XDP datapath is not checked. We don't care about the return value because in the case of an error we still return 0 from the receive function to indicate no packets were received. So to make

[dpdk-dev] [PATCH] net/mlx5: fix redundant flow after RSS expansion

2021-03-30 Thread Xiaoyu Min
When RSS expand, if there is no expansion happened but completion happened because user only input next protocol field instead of item i.e, ether type == 0x8100 instead of VLAN, an extra flow is created with missing item in order to filter traffic strictly. However, after [1] and [2] the rte_flow_

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/1] net/hinic: fix coredump when in secondary process

2021-03-30 Thread Ferruh Yigit
On 3/23/2021 1:17 PM, Guoyang Zhou wrote: Some apps, such as fstack, will use secondary process to access the memory of eth_dev_ops, and they want to get the info of dev, but hinic driver does not initialized it when in secondary process. Fixes: 66f64dd6dc86 ("net/hinic: fix secondary process")

[dpdk-dev] [PATCH] net/hns3: support wait to complete in link update API

2021-03-30 Thread Min Hu (Connor)
From: Huisong Li There are two APIs in ethdev layer to get link status of device, namely, "rte_eth_link_get" and "rte_eth_link_get_nowait". When the device link is unstable or auto-negotiation is in progress, the first API supports the function of waiting for the NIC to link up, and the maximum w

Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-30 Thread Ferruh Yigit
On 3/24/2021 11:27 AM, Ferruh Yigit wrote: On 3/24/2021 4:32 AM, Tyler Retzlaff wrote: On Tue, Mar 23, 2021 at 05:04:08PM +, Ferruh Yigit wrote: diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build index c37b2e377..4353fa6b7 100644 --- a/lib/librte_ethdev/meson.build +

[dpdk-dev] [PATCH v3 5/5] devargs: parse global device syntax

2021-03-30 Thread Xueming Li
When parsing a devargs, try to parse using the global device syntax first. Fallback on legacy syntax on error. Example of new global device syntax: -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,dv_flow_en=1 Signed-off-by: Xueming Li --- lib/librte_eal/common/eal_common_devargs.c | 7 ++- 1

[dpdk-dev] [PATCH v3 4/5] bus: add device arguments name parsing API

2021-03-30 Thread Xueming Li
To use Global Device Syntax as devargs, name is required for device management. In legacy parsing API, devargs name was extracted after bus name: bus:name,kv_params,,, To parse new Global Device Syntax, this patch introduces new bus API to parse devargs and update name, different bus driver mig

[dpdk-dev] [PATCH v3 3/5] kvargs: add get by key function

2021-03-30 Thread Xueming Li
Adds a new function to get value of a specific key from kvargs list. Signed-off-by: Xueming Li --- lib/librte_kvargs/rte_kvargs.c | 20 lib/librte_kvargs/rte_kvargs.h | 21 + lib/librte_kvargs/version.map | 1 + 3 files changed, 42 insertions(+) diff -

[dpdk-dev] [PATCH v3 2/5] devargs: fix memory leak on parsing error

2021-03-30 Thread Xueming Li
This patch fixes memory leak in parsing error handling. Fixes: 338327d731e6 ("devargs: add function to parse device layers") Cc: gaetan.ri...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- lib/librte_eal/common/eal_common_devargs.c | 10 +- 1 file changed, 9 insertions(+),

[dpdk-dev] [PATCH v3 1/5] devargs: unify scratch buffer storage

2021-03-30 Thread Xueming Li
In current design, legacy parser rte_devargs_parse() saved scratch buffer to devargs.args while new parser rte_devargs_layers_parse() saved to devargs.data. Code using devargs had to know the difference and cleaned up memory accordingly - error prone. This patch unifies scratch buffer to data fiel

[dpdk-dev] [PATCH v3 0/5] eal: enable global device syntax by default

2021-03-30 Thread Xueming Li
The new Global Device Syntax [1] is used to identify a device with full bus, class and driver description, example: -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,... This patchset fixes bugs and enable global device syntax with backward compatibility by: - unify devargs memory buffer cleanup - pa

Re: [dpdk-dev] [PATCH v8] app/testpmd: support multi-process

2021-03-30 Thread Min Hu (Connor)
在 2021/3/30 18:19, Ferruh Yigit 写道: On 3/30/2021 7:41 AM, Min Hu (Connor) wrote: 在 2021/3/30 11:11, Ajit Khaparde 写道: On Mon, Mar 29, 2021 at 6:48 PM Min Hu (Connor) wrote: From: Lijun Ou This patch adds multi-process support for testpmd. The test cmd example as follows: the primary c

Re: [dpdk-dev] [PATCH 0/6] bugfixes for hns3

2021-03-30 Thread Ferruh Yigit
On 3/23/2021 1:45 PM, Min Hu (Connor) wrote: This series added six bugfix patches. Chengchang Tang (3): net/hns3: fix TCP SEG and TCP CKSUM flag set net/hns3: fix Tx checksum for UDP packets with special port net/hns3: fix the long taskqueue pairs reset time Huisong Li (3): net/hns3

[dpdk-dev] [Bug 600] Windows DPDK real-time priority threads causing thread starvation

2021-03-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=600 o...@nvidia.com (o...@nvidia.com) changed: What|Removed |Added Ever confirmed|0 |1 Status|RESOLVED

Re: [dpdk-dev] [PATCH v8] app/testpmd: support multi-process

2021-03-30 Thread Ferruh Yigit
On 3/30/2021 7:41 AM, Min Hu (Connor) wrote: 在 2021/3/30 11:11, Ajit Khaparde 写道: On Mon, Mar 29, 2021 at 6:48 PM Min Hu (Connor) wrote: From: Lijun Ou This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=au

[dpdk-dev] [PATCH] pipeline: adjust error code for internal function

2021-03-30 Thread Cristian Dumitrescu
Adjusting the error code for the internal function instruction_config to match the rest of the code which is returning a negative value on error. Cosmetic change. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletion

[dpdk-dev] [PATCH v2] net/ice: support GTPU TEID pattern for switch filter

2021-03-30 Thread Yuying Zhang
Enable GTPU pattern for CVL switch filter. Support teid and qfi field of GTPU pattern. Patterns without inner l3/l4 field support outer dst/src ip. Patterns with inner l3/l4 field only support inner dst/src ip and inner dst/src port. +---+---

Re: [dpdk-dev] [PATCH v3 2/4] regex/mlx5: add data path scattered mbuf process

2021-03-30 Thread Suanming Mou
Hi Slava, > -Original Message- > From: Slava Ovsiienko > Sent: Tuesday, March 30, 2021 4:05 PM > To: Suanming Mou ; Ori Kam > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > > Subject: RE: [PATCH v3 2/4] regex/mlx5: add data path scattered mbuf process > > > -Original Message---

[dpdk-dev] [PATCH] doc: update recommended matching list for i40e

2021-03-30 Thread Robin Zhang
As kernel driver 2.13.10 is removed by EPG, so update recommended matching list for i40e. Signed-off-by: Robin Zhang --- doc/guides/nics/i40e.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index d86212db1a..07841dca24 1

[dpdk-dev] [PATCH v2] net/iavf: deprecate i40evf pmd

2021-03-30 Thread Robin Zhang
Avf PMD was introduced from DPDK 18.02 to promote Intel Adaptive Virtual Function with device ID is 0x1889 aligned with AVF public spec. At the meanwhile, i40evf PMD was co-existed to support other existing device IDs of i40e devices. So on i40e devices, iavf PMD can only run in the VM whose hyperv

[dpdk-dev] [dpdk-dev v21.11] [PATCH v9 8/8] eventdev: simplify Rx adapter event vector config

2021-03-30 Thread pbhagavatula
From: Pavan Nikhilesh Include vector configuration into the structure ``rte_event_eth_rx_adapter_queue_conf`` used when configuring rest of the Rx adapter ethernet device Rx queue parameters. This simplifies event vector configuration as it avoids splitting configuration per Rx queue. Signed-off

[dpdk-dev] [PATCH v9 7/8] doc: announce event Rx adapter config changes

2021-03-30 Thread pbhagavatula
From: Pavan Nikhilesh The Rx adapter event vector configuration will be merged into Rx adapter queue configuration to simplify enabling event vectorization. Signed-off-by: Pavan Nikhilesh Acked-by: Ray Kinsella Acked-by: Jerin Jacob Acked-by: Jay Jayatheerthan --- doc/guides/rel_notes/depre

[dpdk-dev] [PATCH v9 6/8] app/eventdev: add event vector mode in pipeline test

2021-03-30 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support in pipeline tests. By default this mode is disabled, it can be enabled by using the option --enable_vector. example: dpdk-test-eventdev -l 7-23 -s 0xff00 -- --prod_type_ethdev --nb_pkts=0 --verbose 2 --test=pipeline_atq --stlist=a

[dpdk-dev] [PATCH v9 5/8] eventdev: add Tx adapter event vector support

2021-03-30 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for event eth Tx adapter, the implementation receives events from the single linked queue and based on rte_event_vector::attr_valid transmits the vector of mbufs to a given port, queue pair. Signed-off-by: Pavan Nikhilesh Acked-by: Jay Jayatheertha

[dpdk-dev] [PATCH v9 4/8] eventdev: add Rx adapter event vector support

2021-03-30 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for event eth Rx adapter, the implementation creates vector flows based on port and queue identifier of the received mbufs. The flow id for SW Rx event vectorization will use 12-bits of queue identifier and 8-bits port identifier when custom flow id

[dpdk-dev] [PATCH v9 3/8] eventdev: introduce event vector Tx capability

2021-03-30 Thread pbhagavatula
From: Pavan Nikhilesh Introduce event vector transmit capability for event eth tx adapter. The capability indicates that the Tx adapter is capable of transmitting event vectors. When rte_event_vector::union_valid is set, the Tx adapter should transmit all the packets to the rte_event_vector::por

[dpdk-dev] [PATCH v9 2/8] eventdev: introduce event vector Rx capability

2021-03-30 Thread pbhagavatula
From: Pavan Nikhilesh Introduce event ethernet Rx adapter event vector capability. If an event eth Rx adapter has the capability of RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx queue can be configured to enable event vectorization by passing the flag RTE_EVENT_ETH_RX_ADAPTER_QUEUE_E

[dpdk-dev] [PATCH v9 1/8] eventdev: introduce event vector capability

2021-03-30 Thread pbhagavatula
From: Pavan Nikhilesh Introduce rte_event_vector datastructure which is capable of holding multiple uintptr_t of the same flow thereby allowing applications to vectorize their pipeline and reducing the complexity of pipelining the events across multiple stages. This approach also reduces the sche

[dpdk-dev] [PATCH v9 0/8] Introduce event vectorization

2021-03-30 Thread pbhagavatula
From: Pavan Nikhilesh In traditional event programming model, events are identified by a flow-id and a uintptr_t. The flow-id uniquely identifies a given event and determines the order of scheduling based on schedule type, the uintptr_t holds a single object. Event devices also support burst mod

  1   2   >