Re: [dpdk-dev] [PATCH] librte_eal/common: fix return type of rte_bsf64

2021-03-12 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tyler Retzlaff > Sent: Saturday, March 13, 2021 2:10 AM > > On Fri, Mar 12, 2021 at 10:13:30PM +0100, Morten Brørup wrote: > > > > > > > > Please also update the similar math functions in rte_common.h, so the > > > return type is consistent ac

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-12 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Saturday, March 13, 2021 01:47 > To: dev@dpdk.org > Cc: Ori Kam ; Ajit Khaparde ; > Somnath Kotur > ; Chas Williams ; Min Hu (Connor) > ; > Rahul Lakkireddy ; Hemant Agrawal > ; Sachin > Saxena ; Guo, Jia ; Wang, > Haiyue ; > Daley,

[dpdk-dev] [PATCH v2 4/4] net: replace Windows networking shim

2021-03-12 Thread Dmitry Kozlyuk
Remove networking shim from Windows EAL. Replace it with system headers with two workarounds: 1. Windows Sockets headers contain `#define s_addr S_un.S_addr`, which conflicts with `s_addr` field of `struct rte_ether_hdr`. Undefining this macro in had been breaking some usages of DPDK an

[dpdk-dev] [PATCH v2 3/4] net/mlx5: remove POSIX dependency

2021-03-12 Thread Dmitry Kozlyuk
Use for IP-related defines instead of POSIX headers. Keep , because it is incorporated into DPDK. Signed-off-by: Dmitry Kozlyuk --- drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_flow.c | 4 ++-- drivers/net/mlx5/mlx5_flow.h | 4 ++-- drivers/net/mlx5/mlx5_mac.c | 1 - 4 files chan

[dpdk-dev] [PATCH v2 2/4] ethdev: remove POSIX dependency

2021-03-12 Thread Dmitry Kozlyuk
Use for IP-related defines instead of POSIX headers. Keep , because it is incorporated into DPDK. Cleanup, group, and sort remaining includes per coding style. Signed-off-by: Dmitry Kozlyuk --- lib/librte_ethdev/rte_ethdev.c | 13 + lib/librte_ethdev/rte_ethdev_core.h | 1 - 2

[dpdk-dev] [PATCH v2 1/4] cmdline: remove POSIX dependency

2021-03-12 Thread Dmitry Kozlyuk
Use for IP-related defines instead of POSIX headers. Signed-off-by: Dmitry Kozlyuk --- examples/cmdline/commands.c | 1 - examples/cmdline/parse_obj_list.c| 2 -- lib/librte_cmdline/cmdline.c | 1 - lib/librte_cmdline/cmdline_parse.c | 2 --

[dpdk-dev] [PATCH v2 0/4] net: replace Windows networking shim

2021-03-12 Thread Dmitry Kozlyuk
Networking header shim in Windows EAL conflicts with system headers and tries to provide POSIX compatibility out of scope for DPDK. Remove dependency on POSIX headers from libraries supported on Windows, then replace shim with librte_net with workarounds. A proposed deprecation notice is assumed:

Re: [dpdk-dev] [PATCH v4 1/2] eal: error number enhancement for thread TLS API

2021-03-12 Thread Dmitry Kozlyuk
2021-03-10 14:48 (UTC+0200), Tal Shnaiderman: > add error number reporting to rte_errno in all > functions in the rte_thread_tls_* API. > > Suggested-by: Anatoly Burakov > Signed-off-by: Tal Shnaiderman Acked-by: Dmitry Kozlyuk

[dpdk-dev] [PATCH 4/4] net: replace Windows networking shim

2021-03-12 Thread Dmitry Kozlyuk
Remove networking shim from Windows EAL. Replace it with system headers with two workarounds: 1. Windows Sockets headers contain `#define s_addr S_un.S_addr`, which conflicts with `s_addr` field of `struct rte_ether_hdr`. Undefining this macro in had been breaking some usages of DPDK an

[dpdk-dev] [PATCH 3/4] net/mlx5: remove POSIX dependency

2021-03-12 Thread Dmitry Kozlyuk
Use for IP-related defines instead of POSIX headers. Keep , because it is incorporated into DPDK. Signed-off-by: Dmitry Kozlyuk --- drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_flow.c | 4 ++-- drivers/net/mlx5/mlx5_flow.h | 4 ++-- drivers/net/mlx5/mlx5_mac.c | 1 - 4 files chan

[dpdk-dev] [PATCH 2/4] ethdev: remove POSIX dependency

2021-03-12 Thread Dmitry Kozlyuk
Use for IP-related defines instead of POSIX headers. Keep , because it is incorporated into DPDK. Cleanup, group, and sort remaining includes per coding style. Signed-off-by: Dmitry Kozlyuk --- lib/librte_ethdev/rte_ethdev.c | 13 + lib/librte_ethdev/rte_ethdev_core.h | 1 - 2

[dpdk-dev] [PATCH 1/4] cmdline: remove POSIX dependency

2021-03-12 Thread Dmitry Kozlyuk
Use for IP-related defines instead of POSIX headers. Signed-off-by: Dmitry Kozlyuk --- examples/cmdline/commands.c | 1 - examples/cmdline/parse_obj_list.c| 2 -- lib/librte_cmdline/cmdline.c | 1 - lib/librte_cmdline/cmdline_parse.c | 2 --

[dpdk-dev] [PATCH 0/4] net: replace Windows networking shim

2021-03-12 Thread Dmitry Kozlyuk
Networking header shim in Windows EAL conflicts with system headers and tries to provide POSIX compatibility out of scope for DPDK. Remove dependency on POSIX headers from libraries supported on Windows, then replace shim with librte_net with workarounds. A proposed deprecation notice is assumed:

Re: [dpdk-dev] [PATCH] librte_eal/common: fix return type of rte_bsf64

2021-03-12 Thread Tyler Retzlaff
On Fri, Mar 12, 2021 at 10:13:30PM +0100, Morten Brørup wrote: > > > > > > Please also update the similar math functions in rte_common.h, so the > > return type is consistent across these functions: > > > - rte_bsf32() > > > - rte_bsf32_safe() > > > - rte_fls_u32() > > > - rte_bsf64() > > > - rte_f

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-12 Thread Ajit Khaparde
On Fri, Mar 12, 2021 at 9:47 AM Thomas Monjalon wrote: > > Since rte_flow is the only API for filtering operations, > the legacy driver interface filter_ctrl was too much complicated > for the simple task of getting the struct rte_flow_ops. > > The filter type RTE_ETH_FILTER_GENERIC and > the filt

Re: [dpdk-dev] [PATCH 11/11] app/testpmd: fix usage text

2021-03-12 Thread Ajit Khaparde
On Tue, Mar 9, 2021 at 3:32 PM Thomas Monjalon wrote: > > The options help text was including an incomplete and redundant > summary of the options before explaining each. The summary is dropped. > > The details of the option --hairpin-mode had an extra space, > breaking the alignment with the next

[dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-12 Thread Tyler Retzlaff
Introduce a meson option enable_driver_sdk when true installs internal driver headers for ethdev. this allows drivers that do not depend on stable api/abi to be built external to the dpdk source tree. Signed-off-by: Tyler Retzlaff --- lib/librte_ethdev/meson.build | 6 ++ lib/meson.build

Re: [dpdk-dev] [PATCH] librte_eal/common: fix return type of rte_bsf64

2021-03-12 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tyler Retzlaff > Sent: Friday, March 12, 2021 7:24 PM > > On Fri, Mar 12, 2021 at 08:34:50AM +0100, Morten Brørup wrote: > > CC: ABI Policy maintainers. You might have an opinion. Or not. :-) > > > > > > Please also update the similar math fun

Re: [dpdk-dev] [PATCH 0/2] bnxt patches

2021-03-12 Thread Ajit Khaparde
On Thu, Mar 11, 2021 at 9:21 PM Somnath Kotur wrote: > > Please apply the following fixes > > Somnath Kotur (2): > net/bnxt: fix to return count in xstats get op in all cases > net/bnxt: fix Rx and Tx timestamp assignment Patchset applied to dpdk-next-net-brcm. Thanks > > drivers/net/bnxt/bn

Re: [dpdk-dev] [PATCH] net/bnxt: optimizations for Tx completion handling

2021-03-12 Thread Ajit Khaparde
On Sat, Mar 6, 2021 at 7:19 AM Lance Richardson wrote: > > Avoid copying mbuf pointers to separate array for bulk > mbuf free when handling transmit completions for vector > mode transmit. > > Signed-off-by: Lance Richardson > Reviewed-by: Ajit Kumar Khaparde Patch applied to dpdk-next-net-brcm.

Re: [dpdk-dev] [PATCH] net/bnxt: address unused variable warning

2021-03-12 Thread Ajit Khaparde
On Thu, Mar 11, 2021 at 3:30 PM Ajit Khaparde wrote: > > Fix a potential unused variable warning when compiling on PPC. > > Signed-off-by: Ajit Khaparde Squashed with previous patch "net/bnxt: fix Rx descriptor status" https://inbox.dpdk.org/dev/20210311200458.40432-1-ajit.khapa...@broadcom.com/

Re: [dpdk-dev] [PATCH v3 00/12] bnxt fixes

2021-03-12 Thread Ajit Khaparde
On Thu, Mar 11, 2021 at 9:58 PM Ajit Khaparde wrote: > > This patchset contain bnxt bug fixes and enhancements. > > Please apply. > > v1->v2: > - Updated word list as per recommendation to include VNIC, Thor. > - Fixed checkpatch errors pointed in 2/11. > - Updated release notes to indicate HWR

Re: [dpdk-dev] [PATCH v4 4/5] examples/l3fwd: implement FIB lookup method

2021-03-12 Thread Medvedkin, Vladimir
Hi Conor, see comment inlined On 11/03/2021 12:01, Conor Walsh wrote: This patch implements the Forwarding Information Base (FIB) library in l3fwd using the function calls and infrastructure introduced in the previous patch. Signed-off-by: Conor Walsh Acked-by: Konstantin Ananyev --- examp

Re: [dpdk-dev] [PATCH] eal: avoid side effects in RTE_ALIGN_MUL_NEAR(v, mul) for v and mul

2021-03-12 Thread Tyler Retzlaff
On Fri, Mar 12, 2021 at 09:07:22AM +0100, David Marchand wrote: > On Thu, Mar 11, 2021 at 10:08 PM Tyler Retzlaff > wrote: > > > > Avoid expanding v and mul parameters multiple times in the macro. based > > on usage of the macro it seems like side effects were not intended. > > > > For example: >

Re: [dpdk-dev] [PATCH] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-12 Thread Tyler Retzlaff
On Fri, Mar 12, 2021 at 04:52:05PM +0100, Thomas Monjalon wrote: > 12/03/2021 16:34, Bruce Richardson: > > > > > > > > Instead of adding the "get_option('enable_driver_sdk')" checks to the > > > > modules, > > > > what about a more generic solution, like: > > > > > > > > modules assign relevant he

Re: [dpdk-dev] [PATCH] eal, power: don't use '-' sign with unsigned literals

2021-03-12 Thread Tyler Retzlaff
On Fri, Mar 12, 2021 at 10:36:15AM -0800, Tyler Retzlaff wrote: > On Fri, Mar 12, 2021 at 05:37:41PM +, Bruce Richardson wrote: > > On Fri, Mar 12, 2021 at 09:05:58AM -0800, Tyler Retzlaff wrote: > > > > Not sure i agree. It's a very common pattern and is widely used and > > > > understood. I m

Re: [dpdk-dev] [PATCH] eal, power: don't use '-' sign with unsigned literals

2021-03-12 Thread Tyler Retzlaff
On Fri, Mar 12, 2021 at 05:37:41PM +, Bruce Richardson wrote: > On Fri, Mar 12, 2021 at 09:05:58AM -0800, Tyler Retzlaff wrote: > > > Not sure i agree. It's a very common pattern and is widely used and > > > understood. I mean, if anything, seeing `~0` would have me stop and > > > think as i've

Re: [dpdk-dev] [PATCH] librte_eal/common: fix return type of rte_bsf64

2021-03-12 Thread Tyler Retzlaff
On Fri, Mar 12, 2021 at 08:34:50AM +0100, Morten Brørup wrote: > CC: ABI Policy maintainers. You might have an opinion. Or not. :-) > > > Please also update the similar math functions in rte_common.h, so the return > type is consistent across these functions: > - rte_bsf32() > - rte_bsf32_safe()

[dpdk-dev] [PATCH v3 11/11] app/testpmd: fix usage text

2021-03-12 Thread Thomas Monjalon
The options help text was including an incomplete and redundant summary of the options before explaining each. The summary is dropped. The details of the option --hairpin-mode had an extra space, breaking the alignment with the next line. Signed-off-by: Thomas Monjalon --- app/test-pmd/paramete

[dpdk-dev] [PATCH v3 10/11] app/regex: fix usage text

2021-03-12 Thread Thomas Monjalon
The usage syntax help includes the program name which was fake. It is replaced with the real name from argv. Signed-off-by: Thomas Monjalon Acked-by: Ori Kam --- app/test-regex/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-regex/main.c b/app/test-regex/

[dpdk-dev] [PATCH v3 08/11] app: fix exit messages

2021-03-12 Thread Thomas Monjalon
Some applications were printing useless messages with rte_exit() after showing the help. Using exit() is enough in this case. Some applications were using a redundant printf or fprintf() before calling rte_exit(). The messages are unified in a single rte_exit(). Some rte_exit() calls were missing

[dpdk-dev] [PATCH v3 09/11] app: hook in EAL usage help

2021-03-12 Thread Thomas Monjalon
Use rte_set_application_usage_hook() in the test applications, so the full help including EAL options can be printed in one go with the EAL option -h or --help. Signed-off-by: Thomas Monjalon Acked-by: Wisam Jaddo --- app/pdump/main.c | 2 ++ app/proc-info/main.c

[dpdk-dev] [PATCH v3 07/11] eal: add log level help

2021-03-12 Thread Thomas Monjalon
The option --log-level was not completely described in the usage text, and it was difficult to guess the names of the log types and levels. A new value "help" is accepted after --log-level to give more details about the syntax and listing the log types and levels. The array "levels" used for leve

[dpdk-dev] [PATCH v3 06/11] eal: catch invalid log level number

2021-03-12 Thread Thomas Monjalon
The parsing check for invalid log level was not trying to catch irrelevant numeric values. A log level 0 is now a failure in options parsing so it can be caught early. A log level higher than the max (8) is accepted with a warning message. Signed-off-by: Thomas Monjalon --- lib/librte_eal/common

[dpdk-dev] [PATCH v3 05/11] eal: introduce maximum log level macro

2021-03-12 Thread Thomas Monjalon
RTE_DIM(...) and RTE_LOG_DEBUG were used to get the highest log level. For better clarity a new constant RTE_LOG_MAX is introduced and mapped to RTE_LOG_DEBUG. Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/eal_common_log.c | 8 lib/librte_eal/common/eal_common_options.c |

[dpdk-dev] [PATCH v3 04/11] eal: move private log functions

2021-03-12 Thread Thomas Monjalon
Some private log functions had a wrong "rte_" prefix. All private log functions are moved from eal_private.h to the new file eal_log.h: rte_eal_log_init -> eal_log_init rte_log_save_regexp -> eal_log_save_regexp rte_log_save_pattern -> eal_log_save_pattern eal_log_s

[dpdk-dev] [PATCH v3 03/11] eal: use macros for help option

2021-03-12 Thread Thomas Monjalon
The macros OPT_HELP and OPT_HELP_NUM were not used where appropriate. Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/eal_common_options.c | 2 +- lib/librte_eal/freebsd/eal.c | 2 +- lib/librte_eal/linux/eal.c | 2 +- lib/librte_eal/windows/eal.c

[dpdk-dev] [PATCH v3 02/11] eal: improve options usage text

2021-03-12 Thread Thomas Monjalon
The description of the EAL options was printed before the application description provided via the hook. It is better to let the application print the global syntax and describes the detail of the EAL options below. Also, some useless lines are removed, and the alignment of few options is fixed.

[dpdk-dev] [PATCH v3 01/11] eal: explain argv behaviour during init

2021-03-12 Thread Thomas Monjalon
After argument parsing done by rte_eal_init(), the remaining arguments are to be parsed by the application by progressing in the argv array. In this context, the first string represented by argv[0] is still the same program name as the original argv[0], while the next strings are the application ar

[dpdk-dev] [PATCH v3 00/11] improve options help

2021-03-12 Thread Thomas Monjalon
The main intent of this series is to provide a nice help for the --log-level option. More patches are added to improve options help in general. v3: - fix use of RTE_LOG_MAX - accept (with warning) log level higher than RTE_LOG_MAX v2: - fix use of the new macro RTE_LOG_MAX in level pa

Re: [dpdk-dev] [PATCH] librte_eal/common: fix return type of rte_bsf64

2021-03-12 Thread Tyler Retzlaff
On Fri, Mar 12, 2021 at 11:46:39AM +, Kinsella, Ray wrote: > > > On 12/03/2021 07:34, Morten Brørup wrote: > > CC: ABI Policy maintainers. You might have an opinion. Or not. :-) > > My 2c is that this is affecting inlined functions from include/rte_common.h. > Although not ideal, the practic

[dpdk-dev] [PATCH v2 2/2] drivers/net: remove explicit include of legacy filtering

2021-03-12 Thread Thomas Monjalon
The header file rte_eth_ctrl.h should not be needed because this legacy filtering API is completely replaced with the rte_flow API. However some definitions from this file are still used by some drivers, but such usage is already covered by an implicit include via rte_ethdev.h. Signed-off-by: Thom

[dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-12 Thread Thomas Monjalon
Since rte_flow is the only API for filtering operations, the legacy driver interface filter_ctrl was too much complicated for the simple task of getting the struct rte_flow_ops. The filter type RTE_ETH_FILTER_GENERIC and the filter operarion RTE_ETH_FILTER_GET are removed. The new driver callback

[dpdk-dev] [PATCH v2 0/2] ethdev: remove some use of legacy filtering interface

2021-03-12 Thread Thomas Monjalon
The ultimate goal is to remove all traces of the legacy filtering API from ethdev_driver.h and rte_eth_ctrl.h (whole file). This is just one more step of cleanup in progress. The next steps will require the involvement of some driver maintainers. v2: - remove changes in release notes - f

Re: [dpdk-dev] [PATCH] eal, power: don't use '-' sign with unsigned literals

2021-03-12 Thread Bruce Richardson
On Fri, Mar 12, 2021 at 09:05:58AM -0800, Tyler Retzlaff wrote: > On Fri, Mar 12, 2021 at 12:51:46PM +, Burakov, Anatoly wrote: > > On 09-Mar-21 11:44 PM, Tyler Retzlaff wrote: > > >use ~0ULL instead of -1ULL to avoid contridctory application of '-' sign > > >to integer literal where the desire

Re: [dpdk-dev] [PATCH] eal, power: don't use '-' sign with unsigned literals

2021-03-12 Thread Tyler Retzlaff
On Fri, Mar 12, 2021 at 12:51:46PM +, Burakov, Anatoly wrote: > On 09-Mar-21 11:44 PM, Tyler Retzlaff wrote: > >use ~0ULL instead of -1ULL to avoid contridctory application of '-' sign > >to integer literal where the desired type is unsigned. > > > >Signed-off-by: Tyler Retzlaff > >--- > > No

Re: [dpdk-dev] [PATCH 1/2] common/sfc_efx: update copyright year

2021-03-12 Thread Thomas Monjalon
12/03/2021 15:57, Ferruh Yigit: > On 3/11/2021 10:00 AM, Andrew Rybchenko wrote: > > Bump copyright year to 2021. > > > > Signed-off-by: Andrew Rybchenko > > Series applied to dpdk-next-net/main, thanks. > > > Not really it is a trouble for me but do we really need these year updates, > what h

Re: [dpdk-dev] [PATCH] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-12 Thread Thomas Monjalon
12/03/2021 16:34, Bruce Richardson: > On Fri, Mar 12, 2021 at 04:25:09PM +0100, David Marchand wrote: > > On Fri, Mar 12, 2021 at 4:20 PM Ferruh Yigit wrote: > > > > > > On 3/11/2021 7:27 PM, Tyler Retzlaff wrote: > > > > Introduce a meson option enable_driver_sdk when true installs internal > > >

Re: [dpdk-dev] [PATCH] doc: update sample actions support in mlx5 guide

2021-03-12 Thread Thomas Monjalon
12/03/2021 10:44, Jiawei(Jonny) Wang: > From: Thomas Monjalon > > 09/03/2021 14:09, Jiawei Wang: > > > + - Supports ``MARK``, ``COUNT``, ``QUEUE``, ``RSS`` as sample actions > > > for > > NIC Rx sampling/mirroring flow. > > > > "sample actions for NIC Rx sampling" is redundant. > > I suggest "S

Re: [dpdk-dev] [PATCH] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-12 Thread Bruce Richardson
On Fri, Mar 12, 2021 at 04:25:09PM +0100, David Marchand wrote: > On Fri, Mar 12, 2021 at 4:20 PM Ferruh Yigit wrote: > > > > On 3/11/2021 7:27 PM, Tyler Retzlaff wrote: > > > Introduce a meson option enable_driver_sdk when true installs internal > > > driver headers for ethdev. this allows driver

Re: [dpdk-dev] [PATCH 1/3] eventdev: introduce adapter flags for periodic mode

2021-03-12 Thread Carrillo, Erik G
Hi Shijith, Some comments in-line: > -Original Message- > From: Shijith Thotton > Sent: Monday, March 8, 2021 2:46 PM > To: Carrillo, Erik G > Cc: Shijith Thotton ; Pavan Nikhilesh > ; Jerin Jacob ; > dev@dpdk.org > Subject: [PATCH 1/3] eventdev: introduce adapter flags for periodic mod

Re: [dpdk-dev] [PATCH] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-12 Thread David Marchand
On Fri, Mar 12, 2021 at 4:20 PM Ferruh Yigit wrote: > > On 3/11/2021 7:27 PM, Tyler Retzlaff wrote: > > Introduce a meson option enable_driver_sdk when true installs internal > > driver headers for ethdev. this allows drivers that do not depend on > > stable api/abi to be built external to the dpd

Re: [dpdk-dev] [PATCH] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-12 Thread Ferruh Yigit
On 3/11/2021 7:27 PM, Tyler Retzlaff wrote: Introduce a meson option enable_driver_sdk when true installs internal driver headers for ethdev. this allows drivers that do not depend on stable api/abi to be built external to the dpdk source tree. Signed-off-by: Tyler Retzlaff --- it's still uncl

Re: [dpdk-dev] [PATCH] vhost: add header check in dequeue offload

2021-03-12 Thread Wang, Xiao W
Hi Konstantin, Comments inline. BRs, Xiao > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, March 11, 2021 6:38 PM > To: Wang, Xiao W ; Xia, Chenbo > ; maxime.coque...@redhat.com > Cc: Liu, Yong ; dev@dpdk.org; Wang, Xiao W > ; sta...@dpdk.org > Subject: RE: [dpdk-dev]

Re: [dpdk-dev] [PATCH 1/2] common/sfc_efx: update copyright year

2021-03-12 Thread Ferruh Yigit
On 3/11/2021 10:00 AM, Andrew Rybchenko wrote: Bump copyright year to 2021. Signed-off-by: Andrew Rybchenko Series applied to dpdk-next-net/main, thanks. Not really it is a trouble for me but do we really need these year updates, what happens if we update the year only when we touch that fi

[dpdk-dev] [PATCH] build: skip copying meson files for examples installation

2021-03-12 Thread Bruce Richardson
The meson.build files in each example directory is simply to support building the example as part of the main SDK build, and these should not be installed with the example's source code and makefile. The exclude of "meson.build" only filters out the top-level examples/meson.build file, not the file

Re: [dpdk-dev] [PATCH] app/testpmd: log reason of port start failure

2021-03-12 Thread Ferruh Yigit
On 3/12/2021 1:49 AM, Li, Xiaoyun wrote: -Original Message- From: Andrew Rybchenko Sent: Thursday, March 11, 2021 18:49 To: Li, Xiaoyun Cc: dev@dpdk.org Subject: [PATCH] app/testpmd: log reason of port start failure Provide a bit more diagnostics information when port start fails.

Re: [dpdk-dev] [PATCH v11 0/2] support both PIO and MMIO BAR for legacy virito device

2021-03-12 Thread David Marchand
Hello, On Thu, Mar 11, 2021 at 12:55 PM Wang, Yinan wrote: > > Tested-by: Wang, Yinan > > Tested PVP case with virtio PMD assumes legacy device, VM with below kernel > LTS versions, all pass except vfio-pci test blocked with kernel v4.4. > 5.10.0-051000-generic virtio-pmd te

Re: [dpdk-dev] [PATCH 7/7] eventdev: fix ABI breakage due to event vector

2021-03-12 Thread David Marchand
On Mon, Mar 8, 2021 at 7:44 PM Jerin Jacob wrote: > Summary: > 1) Ideal way of adding this feature is to add elements in the > existing structure as mentioned > in ("eventdev: introduce event vector Rx capability") in this series. > 2) Since this breaking ABI, Introducing a new structure to fix

Re: [dpdk-dev] [dpdk-stable] [PATCH] net: fix comment in IPv6 header

2021-03-12 Thread Ferruh Yigit
On 3/8/2021 6:51 AM, Ivan Malov wrote: The comment got it wrong. The payload length field does not include the fixed IPv6 header size. Fixes: 7eca7f7fd09d ("net: add missing endianness annotations") Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Revi

Re: [dpdk-dev] [PATCH] fix maintainers for qede driver

2021-03-12 Thread Ferruh Yigit
On 3/11/2021 8:53 AM, Devendra Singh Rawat wrote: -Original Message- From: Igor Russkikh Sent: Wednesday, March 10, 2021 1:47 PM To: dev@dpdk.org Cc: Rasesh Mody ; Devendra Singh Rawat ; Jerin Jacob ; Igor Russkikh Subject: [PATCH] fix maintainers for qede driver Removing Shahed, add

Re: [dpdk-dev] [PATCH] eal, power: don't use '-' sign with unsigned literals

2021-03-12 Thread Burakov, Anatoly
On 09-Mar-21 11:44 PM, Tyler Retzlaff wrote: use ~0ULL instead of -1ULL to avoid contridctory application of '-' sign to integer literal where the desired type is unsigned. Signed-off-by: Tyler Retzlaff --- Not sure i agree. It's a very common pattern and is widely used and understood. I mea

Re: [dpdk-dev] [PATCH] eal: allow user to override DPDK runtime path

2021-03-12 Thread Burakov, Anatoly
On 12-Mar-21 12:05 PM, Bruce Richardson wrote: On Fri, Mar 12, 2021 at 10:56:20AM +, Burakov, Anatoly wrote: On 11-Mar-21 12:13 PM, Bruce Richardson wrote: On Wed, Mar 10, 2021 at 10:33:50AM -0800, Stephen Hemminger wrote: On Wed, 10 Mar 2021 17:27:17 + Bruce Richardson wrote: On We

[dpdk-dev] [PATCH v2 8/8] net/igc: refine debug compile option

2021-03-12 Thread Qi Zhang
1. replace RTE_LIBRTE_IGC_DEBUG_RX with RTE_LIBRTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IGC_DEBUG_TX whth RTE_LIBRTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_ETHDEV_DEBUG into RTE_LIBRTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/igc/igc_logs.h | 4 ++-- drivers/net/igc/igc_txrx.c | 2

[dpdk-dev] [PATCH v2 7/8] net/ixgbe: refine debug compile option

2021-03-12 Thread Qi Zhang
1. replace RTE_LIBRTE_IXGBE_DEBUG_RX with RTE_LIBRTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IXGBE_DEBUG_TX whth RTE_LIBRTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_IXGBE_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_LIBRTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_e

[dpdk-dev] [PATCH v2 6/8] net/ice: refine debug compile option

2021-03-12 Thread Qi Zhang
1. replace RTE_LIBRTE_ICE_DEBUG_RX with RTE_LIBRTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_ICE_DEBUG_TX whth RTE_LIBRTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_ICE_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_LIBRTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c |

[dpdk-dev] [PATCH v2 5/8] net/iavf: refine debug compile option

2021-03-12 Thread Qi Zhang
1. replace RTE_LIBRTE_IAVF_DEBUG_RX with RTE_LIBRTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IAVF_DEBUG_TX whth RTE_LIBRTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_IAVF_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_LIBRTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/iavf/iavf_ethdev

[dpdk-dev] [PATCH v2 4/8] net/i40e: refine debug compile option

2021-03-12 Thread Qi Zhang
1. replace RTE_LIBRTE_I40E_DEBUG_RX with RTE_LIBRTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_I40E_DEBUG_TX whth RTE_LIBRTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_I40E_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_LIBRTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev

[dpdk-dev] [PATCH v2 3/8] net/e1000: refine debug compile option

2021-03-12 Thread Qi Zhang
1. replace RTE_LIBRTE_E1000_DEBUG_RX with RTE_LIBRTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_E1000_DEBUG_TX whth RTE_LIBRTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_E1000_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_LIBRTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/e1000/e1000_l

[dpdk-dev] [PATCH v2 2/8] net/fm10k: refine debug compile option

2021-03-12 Thread Qi Zhang
1. replace RTE_LIBRTE_FM10K_DEBUG_RX with RTE_LIBRTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_FM10K_DEBUG_TX whth RTE_LIBRTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_FM10K_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_LIBRTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/fm10k/fm10k_e

[dpdk-dev] [PATCH v2 1/8] ether: refine debug compile option

2021-03-12 Thread Qi Zhang
PMDs use RTE_LIBRTE__DEBUG_RX|TX as compile option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. The patch introduces below compile options for specific Rx/Tx data path debug, so PMD can choose

[dpdk-dev] [PATCH v2 0/8] ether: refine debug compile option

2021-03-12 Thread Qi Zhang
PMDs use RTE_LIBRTE__DEBUG_RX|TX as compile option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. Patch 1/8: introduces new compile options for specific Rx/Tx data path debug in ether layer, so P

Re: [dpdk-dev] [PATCH] eal: allow user to override DPDK runtime path

2021-03-12 Thread Bruce Richardson
On Fri, Mar 12, 2021 at 10:56:20AM +, Burakov, Anatoly wrote: > On 11-Mar-21 12:13 PM, Bruce Richardson wrote: > > On Wed, Mar 10, 2021 at 10:33:50AM -0800, Stephen Hemminger wrote: > > > On Wed, 10 Mar 2021 17:27:17 + > > > Bruce Richardson wrote: > > > > > > > On Wed, Mar 10, 2021 at 09

[dpdk-dev] [PATCH v3 3/8] net/hns3: adjust the format of RAS related structures

2021-03-12 Thread Min Hu (Connor)
From: Hongbo Zheng Adjust the format of hns3 RAS related structures to resolve the static check warnings. Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_intr.c | 2126 -- 1 file changed, 1224 insertions(+), 902 dele

[dpdk-dev] [PATCH v3 1/8] net/hns3: support runtime config to select IO burst func

2021-03-12 Thread Min Hu (Connor)
From: Chengwen Feng Currently, the driver support multiple IO burst function and auto selection of the most appropriate function based on offload configuration. Most applications such as l2fwd/l3fwd don't provide the means to change offload configuration, so it will use the auto selection's io b

[dpdk-dev] [PATCH v3 2/8] net/hns3: support for outer UDP cksum

2021-03-12 Thread Min Hu (Connor)
From: Chengchang Tang Kunpeng930 support outer UDP cksum, this patch add support for it. Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- doc/guides/rel_notes/release_21_05.rst | 1 + drivers/net/hns3/hns3_cmd.c| 3 ++ drivers/net/hns3/hns3_ethdev.c | 3

[dpdk-dev] [PATCH v3 4/8] net/hns3: delete redundant xstats RAS statistics

2021-03-12 Thread Min Hu (Connor)
From: Hongbo Zheng The current RAS code stores the reported RAS statistics in xstats. This part of statistics is of little use in practice, and because of the change of RAS scheme on Kunpeng930, the driver can not obtain the RAS information any more, so this patch delete these redundant RAS stati

[dpdk-dev] [PATCH v3 5/8] net/hns3: support imissed stats for PF/VF

2021-03-12 Thread Min Hu (Connor)
This patch added function level imissed stats for PF and VF. In kunpeng920, imissed is supported, only including RPU drop stats in PF. In kunpeng930, imissed is supported,including RPU drop stats and SSU drop stats in PF. Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_cmd.h | 14

[dpdk-dev] [PATCH v3 8/8] net/hns3: support query Rx descriptor status

2021-03-12 Thread Min Hu (Connor)
From: Hongbo Zheng Add support for query Rx descriptor status in hns3 driver. Check the descriptor specified and provide the status information of the corresponding descriptor. Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- doc/guides/nics/features/hns3.ini | 1 + doc/gu

[dpdk-dev] [PATCH v3 6/8] net/hns3: support oerrors stats in PF

2021-03-12 Thread Min Hu (Connor)
This patch added oerrors stats for PF in kunpeng930. Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.h | 1 + drivers/net/hns3/hns3_stats.c | 61 ++ 2 files changed, 62 insertions(+) diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/

[dpdk-dev] [PATCH v3 7/8] net/hns3: support query Tx descriptor status

2021-03-12 Thread Min Hu (Connor)
From: Hongbo Zheng Add support for query Tx descriptor status in hns3 driver. Check the descriptor specified and provide the status information of the corresponding descriptor. Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- doc/guides/nics/features/hns3.ini | 1 + doc/gu

[dpdk-dev] [PATCH v3 0/8] features and bugfixes for hns3

2021-03-12 Thread Min Hu (Connor)
This series add four features according to the 21.05 roadmap, and also two cleanups added. Chengchang Tang (1): net/hns3: support for outer UDP cksum Chengwen Feng (1): net/hns3: support runtime config to select IO burst func Hongbo Zheng (4): net/hns3: adjust the format of RAS related str

Re: [dpdk-dev] [PATCH] librte_eal/common: fix return type of rte_bsf64

2021-03-12 Thread Kinsella, Ray
On 12/03/2021 07:34, Morten Brørup wrote: > CC: ABI Policy maintainers. You might have an opinion. Or not. :-) My 2c is that this is affecting inlined functions from include/rte_common.h. Although not ideal, the practical effect on Binary Compatibility is therefore likely to be _nil_. Just a

Re: [dpdk-dev] [Linuxarm] Re: [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-12 Thread Thomas Monjalon
12/03/2021 11:29, oulijun: > 2021/3/10 15:59, Thomas Monjalon: > > 10/03/2021 02:48, oulijun: > >> Can we add an API such as rte_eth_get_device(pord_id) > >> > >> for example: > >> struct rte_eth_dev * > >> rte_eth_get_device(uint16_t port_id) > >> { > >> return &rte_eth_devices[port_id];

[dpdk-dev] [PATCH v2 10/10] net/sfc: support action VXLAN DECAP in transfer rules

2021-03-12 Thread Ivan Malov
If there is no VXLAN among pattern items, the action will be turned down. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mae.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_mae.

[dpdk-dev] [PATCH v2 09/10] common/sfc_efx/base: support adding action DECAP to a set

2021-03-12 Thread Ivan Malov
The action has no arguments. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 5 +++ drivers/common/sfc_efx/base/efx_impl.h | 1 + drivers/common/sfc_efx/base/efx_mae.c | 48 ++ drivers/com

[dpdk-dev] [PATCH v2 08/10] net/sfc: support action VXLAN ENCAP in MAE backend

2021-03-12 Thread Ivan Malov
Provide necessary facilities for handling this action. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mae.c | 550 +- drivers/net/sfc/sfc_mae.h | 29 ++ 2 files changed, 572 insertions(+), 7 deletio

[dpdk-dev] [PATCH v2 07/10] net/sfc: change MAE rule actions parse API

2021-03-12 Thread Ivan Malov
From: Igor Romanov Current API signature makes it hard to add other entities that belong to a flow specification. Pass the flow specification so that additional members can be accessed through the spec. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Revi

[dpdk-dev] [PATCH v2 06/10] common/sfc_efx/base: support adding action ENCAP to a set

2021-03-12 Thread Ivan Malov
For convenience, there are two separate APIs provided, one for adding the action and one for setting the encap. header ID. This design allows the client driver to first build the action set specification (which validates the order of the actions) and, if everything is correct, proceed with allocati

[dpdk-dev] [PATCH v2 05/10] common/sfc_efx/base: support encap. header provisioning

2021-03-12 Thread Ivan Malov
Let the client allocate / free encap. headers. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 21 drivers/common/sfc_efx/base/efx_mae.c | 155 ++ drivers/common/sfc_efx/version.map|

[dpdk-dev] [PATCH v2 04/10] ethdev: reuse header definition in flow pattern item VXLAN

2021-03-12 Thread Ivan Malov
One ought to reuse existing header structs in flow items. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- lib/librte_ethdev/rte_flow.h | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/lib/librte_ethdev/rte_flow.h b

[dpdk-dev] [PATCH v2 03/10] net: clarify endianness of 32-bit fields in VXLAN headers

2021-03-12 Thread Ivan Malov
These fields have network byte order. Highlight it using dedicated type. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- lib/librte_net/rte_vxlan.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/librte_net/rte_vxlan.h b/lib/

[dpdk-dev] [PATCH v2 02/10] ethdev: reuse header definition in flow pattern item VLAN

2021-03-12 Thread Ivan Malov
One ought to reuse existing header structs in flow items. This particular item contains non-header fields, so it's important to keep the header fields in a separate struct. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- lib/librte_ethdev/rte_flow.h | 22 +

[dpdk-dev] [PATCH v2 01/10] ethdev: reuse header definition in flow pattern item ETH

2021-03-12 Thread Ivan Malov
One ought to reuse existing header structs in flow items. This particular item contains non-header fields, so it's important to keep the header fields in a separate struct. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- lib/librte_ethdev/rte_flow.h | 44 +

Re: [dpdk-dev] [PATCH v2 2/9] net/hns3: support Tx push quick doorbell to improve perf

2021-03-12 Thread Min Hu (Connor)
在 2021/3/12 2:05, Ferruh Yigit 写道: On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: From: Chengwen Feng Kunpeng 930 support Tx push mode which could improve performance, It works like below: 1. Add pcie bar45 which support driver direct write the Tx descriptor or tail reg to it. 2. Support thre

Re: [dpdk-dev] [PATCH] eal: allow user to override DPDK runtime path

2021-03-12 Thread Burakov, Anatoly
On 11-Mar-21 12:13 PM, Bruce Richardson wrote: On Wed, Mar 10, 2021 at 10:33:50AM -0800, Stephen Hemminger wrote: On Wed, 10 Mar 2021 17:27:17 + Bruce Richardson wrote: On Wed, Mar 10, 2021 at 09:21:37AM -0800, Stephen Hemminger wrote: There can be cases such as containers or other runti

Re: [dpdk-dev] [PATCH v2 4/9] net/hns3: adjust the format of RAS related structures

2021-03-12 Thread Min Hu (Connor)
在 2021/3/12 18:02, Ferruh Yigit 写道: On 3/12/2021 1:51 AM, Min Hu (Connor) wrote: 在 2021/3/12 2:25, Ferruh Yigit 写道: On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: From: Hongbo Zheng Adjust the format of hns3 RAS related structures to resolve the static check warnings of reviewbot_c.This p

Re: [dpdk-dev] [Linuxarm] Re: [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-12 Thread oulijun
在 2021/3/10 15:59, Thomas Monjalon 写道: 10/03/2021 02:48, oulijun: Can we add an API such as rte_eth_get_device(pord_id) for example: struct rte_eth_dev * rte_eth_get_device(uint16_t port_id) { return &rte_eth_devices[port_id]; } An application is not supposed to access the struct r

Re: [dpdk-dev] [PATCH v2 4/9] net/hns3: adjust the format of RAS related structures

2021-03-12 Thread Ferruh Yigit
On 3/12/2021 1:51 AM, Min Hu (Connor) wrote: 在 2021/3/12 2:25, Ferruh Yigit 写道: On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: From: Hongbo Zheng Adjust the format of hns3 RAS related structures to resolve the static check warnings of reviewbot_c.This patch has no impact on function. The cor

[dpdk-dev] [PATCH v3 12/12] net/bnxt: fix PTP support for Thor

2021-03-12 Thread Ajit Khaparde
From: Kalesh AP On Thor, Rx timestamp is present in the Rx completion record. Only 32 bits of the timestamp is present in the completion. The driver needs to periodically poll the current 48 bit free running timer using the HWRM_PORT_TS_QUERY command. It can combine the upper 16 bits from the HWR

  1   2   >