Re: [dpdk-dev] [PATCH v2 0/9] Introduce vfio-user library

Hello Chenbo, On Thu, Jan 14, 2021 at 7:19 AM Chenbo Xia wrote: > > This series enables DPDK to be an alternative I/O device emulation library of > building virtualized devices in separate processes outside QEMU. It introduces > a new library for device emulation (librte_vfio_user). > > *librte_v

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix configuration of max frame size

Tested-by: Xie,WeiX < weix@intel.com> Regards, Xie Wei > -Original Message- > From: Zhang,Alvin [mailto:alvinx.zh...@intel.com] > Sent: Friday, January 15, 2021 3:00 PM > To: Guo, Jia ; Wang, Haiyue ; > Xie, WeiX > Cc: dev@dpdk.org; Zhang, AlvinX ; > sta...@dpdk.org > Subject: [PAT

[dpdk-dev] [PATCH v8 3/3] test: change external memory test to use system page sz

Currently external memory test uses 4K page size. VFIO DMA mapping works only with system page granularity. Earlier it was working because all the contiguous mappings were coalesced and mapped in one-go which ended up becoming a lot bigger page. Now that VFIO DMA mappings both in IOVA as VA and IO

[dpdk-dev] [PATCH v8 2/3] vfio: fix DMA mapping granularity for type1 IOVA as VA

Partial unmapping is not supported for VFIO IOMMU type1 by kernel. Though kernel gives return as zero, the unmapped size returned will not be same as expected. So check for returned unmap size and return error. For IOVA as PA, DMA mapping is already at memseg size granularity. Do the same even for

[dpdk-dev] [PATCH v8 1/3] vfio: revert changes for map contiguous areas in one go

In order to save DMA entries limited by kernel both for externel memory and hugepage memory, an attempt was made to map physically contiguous memory in one go. This cannot be done as VFIO IOMMU type1 does not support partially unmapping a previously mapped memory region while Heap can request for m

[dpdk-dev] [PATCH v8 0/3] fix issue with partial DMA unmap

Partial DMA unmap is not supported by VFIO type1 IOMMU in Linux. Though the return value is zero, the returned DMA unmap size is not same as expected size. So add test case and fix to both heap triggered DMA mapping and user triggered DMA mapping/unmapping. Refer vfio_dma_do_unmap() in drivers/vfi

[dpdk-dev] [PATCH v1] net/iavf: adjust the CRC statistics calculation

The AVF can support to enable / disable CRC strip, so it needs to adjust the statistics calculation for ibytes according to offload setting. Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_ethdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf

Re: [dpdk-dev] [PATCH v3 0/5] lpm lookup with sve support

> -Original Message- > From: David Marchand > Sent: Thursday, January 14, 2021 11:40 PM > To: Ruifeng Wang ; Honnappa Nagarahalli > > Cc: dev ; Vladimir Medvedkin > ; Pavan Nikhilesh > ; jer...@marvell.com; > hemant.agra...@nxp.com; nd > Subject: Re: [dpdk-dev] [PATCH v3 0/5] lpm lookup

[dpdk-dev] [PATCH v3] net/ixgbe: fix configuration of max frame size

From: Alvin Zhang For 82599 NIC, jumbo frame feature is not supported in IOV mode, but if a VF requests to configure the frame size to that not bigger than RTE_ETHER_MAX_LEN, the PMD should not return -1. This patch keeps ixgbe PMD's handling mode consistent with kernel driver in above situation.

Re: [dpdk-dev] [PATCH v7 3/3] test: change external memory test to use system page sz

On Thu, Jan 14, 2021 at 05:30:05PM +0100, David Marchand wrote: > On Tue, Jan 12, 2021 at 6:39 PM Nithin Dabilpuram > wrote: > > > > Currently external memory test uses 4K page size. > > VFIO DMA mapping works only with system page granularity. > > > > Earlier it was working because all the contig

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix configuration of max frame size

Tested-by: Xie,WeiX < weix@intel.com> Regards, Xie Wei > -Original Message- > From: Zhang,Alvin [mailto:alvinx.zh...@intel.com] > Sent: Friday, January 15, 2021 10:31 AM > To: Guo, Jia ; Wang, Haiyue ; > Xie, WeiX > Cc: dev@dpdk.org; Zhang, AlvinX ; > sta...@dpdk.org > Subject: [PA

[dpdk-dev] [PATCH v2] net/ice: enable QinQ filter for switch

Enable the double VLAN support for switch QinQ filtering. Signed-off-by: Wei Zhao Signed-off-by: Haiyue Wang Signed-off-by: Junfeng Guo --- doc/guides/rel_notes/release_21_02.rst | 4 + drivers/net/ice/ice_generic_flow.c | 15 drivers/net/ice/ice_generic_flow.h | 1 + drivers

Re: [dpdk-dev] [PATCH] net/ice: fix GTPU header incorrectly parsed

> -Original Message- > From: Ding, Xuan > Sent: Thursday, January 14, 2021 4:01 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Su, Simei ; Yan, Zhirun > ; Ding, Xuan > Subject: [PATCH] net/ice: fix GTPU header incorrectly parsed > > Refine the GTPU template

[dpdk-dev] [PATCH] net/ice: enable QinQ filter for switch

Enable the double VLAN support for switch QinQ filtering. Signed-off-by: Wei Zhao Signed-off-by: Haiyue Wang Signed-off-by: Junfeng Guo --- drivers/net/ice/ice_generic_flow.c | 15 drivers/net/ice/ice_generic_flow.h | 1 + drivers/net/ice/ice_switch_filter.c | 104 +++

Re: [dpdk-dev] [PATCH] app/testpmd: avoid exit without resource release

Hi Beilei, Thanks for your comments, I will prepare patch v2. -Original Message- From: Xing, Beilei Sent: Friday, January 15, 2021 1:50 PM To: Yu, DapengX ; Lu, Wenzhuo ; Iremonger, Bernard Cc: Stephen Hemminger ; dev@dpdk.org; sta...@dpdk.org Subject: RE: [dpdk-dev] [PATCH] app/testp

Re: [dpdk-dev] [PATCH] app/testpmd: avoid exit without resource release

> -Original Message- > From: Yu, DapengX > Sent: Friday, January 15, 2021 11:29 AM > To: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > Cc: Yu, DapengX ; Stephen Hemminger > ; dev@dpdk.org; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: avoid exit without resource > r

Re: [dpdk-dev] [PATCH v3] crypto/octeontx2: add CN98xx support

> > CN98xx SoC comes up with two CPT blocks wrt CN96xx, CN93xx, to achieve > higher performance. > > Adding support to allocate all LFs of VF with even BDF from CPT0 and all LFs > of > VF with odd BDF from CPT1. > If LFs are not available in one block then they will be allocated from > alternat

Re: [dpdk-dev] [PATCH v3] pci/windows: fix build with SDK >= 10.0.20253

On Thu, Jan 14, 2021 at 02:59:44PM -0800, Ranjit Menon wrote: > Quick q: Do you know when this new SDK will be available publicly? there are periodic release of the sdk [2] that match the versions of windows available through the windows insider program [1]. i can see the latest available appear

Re: [dpdk-dev] [PATCH 0/2] add lookaside IPsec ESN and anti-replay support

> > This series adds lookaside IPsec ESN and anti-replay support to OCTEON TX2 > crypto PMD. > The functionality has been tested with ipsec-secgw application running in > lookaside protocol offload mode. > > Tejasree Kondoj (2): > crypto/octeontx2: make anti-replay routine generic > crypto/oc

Re: [dpdk-dev] [PATCH 0/2] support SSL/TLS way of cipher-auth operations

> > This series adds SSL/TLS way of cipher-auth operations support i.e. auth > generation followed by encryption and decryption followed by auth verify in > OCTEON TX, OCTEON TX2 PMDs and sample unit test application. > > Tejasree Kondoj (2): > common/cpt: support SSL/TLS way of cipher-auth ope

[dpdk-dev] [dpdk-dev v5 2/2] app/testpmd: add new UDP tunnel port for eCPRI

Add new UDP tunnel port params for eCPRI configuration, the command as below: testpmd> port config 0 udp_tunnel_port add ecpri 6789 testpmd> port config 0 udp_tunnel_port rm ecpri 6789 Signed-off-by: Jeff Guo --- app/test-pmd/cmdline.c | 9 ++--- doc/guides/testpmd_app_

[dpdk-dev] [dpdk-dev v5 1/2] ethdev: add new tunnel type for eCPRI

Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel type. Signed-off-by: Jeff Guo Reviewed-by: Qi Zhang Reviewed-by: Ferruh Yigit --- doc/guides/rel_notes/release_21_02.rst | 15 ++- lib/librte_ethdev/rte_ethdev.h | 1 + 2 files changed, 15 insertions(+), 1 de

[dpdk-dev] [dpdk-dev v5 0/2] add new UDP tunnel port configure for eCPRI

Add new UDP tunnel port configure for eCPRI protocol features v5: fix a coding style issue. v4: add doc in release note for all related eCPRI features. v3: seperate the patch set and add some document Jeff Guo (2): ethdev: add new tunnel type for eCPRI app/testpmd: add new UDP tunnel port f

[dpdk-dev] [dpdk-dev v4 2/2] app/testpmd: add new UDP tunnel port for eCPRI

Add new UDP tunnel port params for eCPRI configuration, the command as below: testpmd> port config 0 udp_tunnel_port add ecpri 6789 testpmd> port config 0 udp_tunnel_port rm ecpri 6789 Signed-off-by: Jeff Guo --- app/test-pmd/cmdline.c | 9 ++--- doc/guides/testpmd_app_

[dpdk-dev] [dpdk-dev v4 1/2] ethdev: add new tunnel type for eCPRI

Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel type. Signed-off-by: Jeff Guo Reviewed-by: Qi Zhang Reviewed-by: Ferruh Yigit --- doc/guides/rel_notes/release_21_02.rst | 15 ++- lib/librte_ethdev/rte_ethdev.h | 1 + 2 files changed, 15 insertions(+), 1 de

[dpdk-dev] [dpdk-dev v4 0/2] add new UDP tunnel port configure for eCPRI

Add new UDP tunnel port configure for eCPRI protocol features v4: add doc in release note for all related eCPRI features. v3: seperate the patch set and add some document Jeff Guo (2): ethdev: add new tunnel type for eCPRI app/testpmd: add new UDP tunnel port for eCPRI app/test-pmd/cmdline

Re: [dpdk-dev] [PATCH v4] gso: add VXLAN UDP/IPv4 support

At 2020-11-19 14:49:23, "Hu, Jiayu" wrote: >Acked-by: Jiayu Hu Hi, Thomas This patch has been acked very long, but it isn't merged into master, what's wrong? > >> -Original Message- >> From: yang_y...@163.com >> Sent: Thursday, November 19, 2020 2:44 PM >> To: dev@dpdk.org >> Cc: H

Re: [dpdk-dev] [PATCH] app/testpmd: avoid exit without resource release

Hi Wenzhuo, Beilei, Bernard I need testpmd app maintainers' comment : Do you prefer the simple solution in this patch or Stephen's comprehensive and generic solution(which will modify librte_cmdline, testpmd (and maybe rte_exit()))? So I can continue resolving the defect. Thanks! -Orig

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix testpmd sample qinq flow rules

Hi There are two other mistakes in this section "Sample QinQ flow rules". Can you help to correct those too? 1. testpmd> vlan set qinq_strip on 0 Creating QinQ rule(s) command line should be "vlan set extend on 0". Qinq_strip is not relevant to qinq flow rules. 2. The sentence "The above co

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

> -Original Message- > From: Ferruh Yigit > Sent: Thursday, January 14, 2021 10:35 PM > To: Guo, Jia ; Zhang, Qi Z ; Wu, > Jingjing ; Yang, Qiming ; > Wang, Haiyue > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for > ecpri > > On 12/24/2020 6:

[dpdk-dev] [dpdk-dev v3 2/2] app/testpmd: add new UDP tunnel port for ecpri

Add new UDP tunnel port params for ecpri configuration, the command as below: testpmd> port config 0 udp_tunnel_port add ecpri 6789 testpmd> port config 0 udp_tunnel_port rm ecpri 6789 Signed-off-by: Jeff Guo --- app/test-pmd/cmdline.c | 9 ++--- doc/guides/testpmd_app_

[dpdk-dev] [dpdk-dev v3 1/2] ethdev: add new tunnel type for ecpri

Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel type. Signed-off-by: Jeff Guo Reviewed-by: Qi Zhang Reviewed-by: Ferruh Yigit --- doc/guides/rel_notes/release_21_02.rst | 3 ++- lib/librte_ethdev/rte_ethdev.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff

[dpdk-dev] [dpdk-dev v3 0/2] add new UDP tunnel port for ecpri

v3: seperate the patch set and add some document Jeff Guo (2): ethdev: add new tunnel type for ecpri app/testpmd: add new UDP tunnel port for ecpri app/test-pmd/cmdline.c | 9 ++--- doc/guides/rel_notes/release_21_02.rst | 3 ++- doc/guides/testpmd_app_ug/testpm

Re: [dpdk-dev] [PATCH] fbarray: fix incorrect overlap check

Tested-by: Peng, ZhihongX Regards, Peng,Zhihong -Original Message- From: dev On Behalf Of Anatoly Burakov Sent: Thursday, January 14, 2021 11:03 PM To: dev@dpdk.org Cc: sta...@dpdk.org Subject: [dpdk-dev] [PATCH] fbarray: fix incorrect overlap check When we're attaching fbarrays in sec

[dpdk-dev] [PATCH v2] net/ixgbe: fix configuration of max frame size

From: Alvin Zhang For 82599 NIC, jumbo frame feature is not supported in IOV mode, but if a VF requests to configure the frame size to that not bigger than RTE_ETHER_MAX_LEN, the PMD should not return -1. This patch keeps ixgbe PMD's handling mode consistent with kernel driver in above situation.

Re: [dpdk-dev] [dpdk-dev v2 2/2] app/testpmd: add new UDP tunnel port for ecpri

> -Original Message- > From: Ferruh Yigit > Sent: Thursday, January 14, 2021 10:34 PM > To: Guo, Jia ; Zhang, Qi Z ; Wu, > Jingjing ; Yang, Qiming ; > Wang, Haiyue > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-dev v2 2/2] app/testpmd: add new UDP > tunnel port for ecpri > > On 12/2

Re: [dpdk-dev] [PATCH v6 0/9] ethdev: introduce GENEVE header TLV option item

On 1/14/2021 7:07 AM, Shiri Kuzin wrote: The Geneve tunneling protocol is designed to allow the user to specify some data context on the packet. The GENEVE TLV (Type-Length-Variable) Option is the mean intended to present the user data. In order to support GENEVE TLV Option the new rte_flow item

Re: [dpdk-dev] [PATCH v2 0/6] add GTP PSC extension header support

On 1/11/2021 6:21 PM, Shiri Kuzin wrote: In this patch we add the support for GTP PSC in net/mlx5. This will enable matching on "rte_flow_item_gtp_psc" item. The support in testpmd is extended to support raw encap\decap of GTP PSC. v2: - update documentation. - fix PDU type shift. Shiri Kuzin

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: update GTP headers

On 1/11/2021 6:21 PM, Shiri Kuzin wrote: From: Viacheslav Ovsiienko This patch introduces the GTP header individual flag bit fields and the header optional word with N-PDU number, Sequence Number and Next Extension Header type. Signed-off-by: Viacheslav Ovsiienko Acked-by: Ori Kam Reviewed

Re: [dpdk-dev] [RFC v3 2/8] app/testpmd: add GENEVE option item support

On Wed, Dec 16, 2020 at 5:03 AM Shiri Kuzin wrote: > > From: Viacheslav Ovsiienko > > The patch adds the GENEVE option rte flow item support to > command line interpreter. The flow command with GENEVE > option items looks like: > > flow create 0 ingress pattern eth / ipv4 / udp / geneve vni is

Re: [dpdk-dev] [PATCH v2 0/6] some bugfixes for hns3

On 1/6/2021 3:46 AM, Lijun Ou wrote: Here series fix some hns3 PMD bugs. Change frome V1: 1. remove the fixes patch[6/7] from V1 2. fix ferruh Yigit's comments. Huisong Li (3): net/hns3: fix xstats statistics with id and names net/hns3: fix abnormal return value in xstats net/hns3: fix

Re: [dpdk-dev] [PATCH v3 0/2] Support i40e PMD on Windows

On 1/14/2021 2:55 PM, Thomas Monjalon wrote: 22/12/2020 01:45, Pallavi Kadam: Pallavi Kadam (2): eal: add rte_random.c file on windows build: i40e PMD on Windows Applied, thanks For info, I've fixed an additional warning in i40e compilation on Windows: drivers/net/i40e/i40e_has

Re: [dpdk-dev] [PATCH v3] pci/windows: fix build with SDK >= 10.0.20253

On 1/14/2021 1:22 PM, Tyler Retzlaff wrote: NetUIO device class and interface GUIDs are defined in system headers starting from platform SDK v10.0.20253. Inspect SDK version to avoid redefinition. Pre-release SDKs do not promise compatibility and a narrow subset of SDKs may still be subject to

Re: [dpdk-dev] [PATCH v3 0/2] Support i40e PMD on Windows

22/12/2020 01:45, Pallavi Kadam: > Pallavi Kadam (2): > eal: add rte_random.c file on windows > build: i40e PMD on Windows Applied, thanks For info, I've fixed an additional warning in i40e compilation on Windows: drivers/net/i40e/i40e_hash.c:357:22: warning: comparison of int

Re: [dpdk-dev] [PATCH v3] pci/windows: fix build with SDK >= 10.0.20253

On Thu, 14 Jan 2021 13:22:35 -0800, Tyler Retzlaff wrote: > NetUIO device class and interface GUIDs are defined in system > headers starting from platform SDK v10.0.20253. Inspect SDK > version to avoid redefinition. > > Pre-release SDKs do not promise compatibility and a narrow > subset of SDKs m

[dpdk-dev] [PATCH] net/mlx5: fix wrong Flow Tag decompression

Packets can get a wrong Flow Tag on x86 architecture with the Flow Tag compression format (rxq_cqe_comp_en=2) enabled inside the SSE Rx burst. The shuffle mask that extracts a Flow Tag from the pair of compressed CQEs is reversed. This leads to the wrong Flow Tag assignment. Correct the shuffle mas

[dpdk-dev] [PATCH v3] pci/windows: fix build with SDK >= 10.0.20253

NetUIO device class and interface GUIDs are defined in system headers starting from platform SDK v10.0.20253. Inspect SDK version to avoid redefinition. Pre-release SDKs do not promise compatibility and a narrow subset of SDKs may still be subject to redefinition. Fixes: c76ec01b4591 (bus/pci: su

Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

On 1/14/2021 5:29 PM, Andrew Boyer wrote: On Jan 14, 2021, at 12:13 PM, Ferruh Yigit > wrote: On 1/14/2021 4:36 PM, Ferruh Yigit wrote: On 1/14/2021 9:45 AM, Steve Yang wrote: Ethdev is using default Ethernet overhead to decide if provided 'max_rx_pkt_len' val

Re: [dpdk-dev] [PATCH v2 8/9] test/vfio_user: introduce functional test

On 1/13/21 10:14 PM, Chenbo Xia wrote: This patch introduces functional test for vfio_user client and server. Note that the test can only be run with server and client both started and server should be started first. Receiving a build warning on RHEL 8.3 (gcc 8.3.1) for POWER with this patch

Re: [dpdk-dev] [PATCH] eal/headers: explicitly cast void * to type *

14/01/2021 19:27, Dmitry Kozlyuk: > > > If it's a public header then maybe it's missing a @file? > > > > > My 2c on this in general... > > > > The use of public vs private headers is not always clear, sadly, in DPDK, > > for historical reasons. With the make builds, libraries picked up headers

Re: [dpdk-dev] [PATCH v2 3/9] vfio_user: implement device and region related APIs

On 1/13/21 10:14 PM, Chenbo Xia wrote: This patch introduces device and region related APIs, which are rte_vfio_user_set_dev_info() and rte_vfio_user_set_reg_info(). The corresponding vfio-user command handling is also added with the definition of all vfio-user command identity. Receiving a

Re: [dpdk-dev] [PATCH] eal/headers: explicitly cast void * to type *

> > If it's a public header then maybe it's missing a @file? > > > My 2c on this in general... > > The use of public vs private headers is not always clear, sadly, in DPDK, > for historical reasons. With the make builds, libraries picked up headers > from other libraries via the "include" fold

Re: [dpdk-dev] [PATCH v5 1/3] PCI: use PCI standard sysfs entry to get PIO address

On 2021/1/12 16:07, Maxime Coquelin wrote: Hi Huawei, The title should be under the form: "bus/pci: use PCI standard sysfs entry to get PIO address" On 10/22/20 5:51 PM, 谢华伟(此时此刻） wrote: From: "huawei.xhw" Previously with igb_uio we get PIO address from igb_uio sysfs entry, with uio_pci_ge

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

On 2021/1/13 1:37, Maxime Coquelin wrote: On 10/22/20 5:51 PM, 谢华伟(此时此刻） wrote: From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel supports both PIO and MMIO B

[dpdk-dev] [PATCH v1] eal: add ticket based reader writer lock

This patch implements a reader/writer ticket lock. This lock type acts like rte_rwlock() but uses a ticket algorithm and are fair for multiple writers and readers. Writers have priority over readers. The tests are just a clone of existing rte_rwlock with test and function names changed. So the ne

Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

> On Jan 14, 2021, at 12:13 PM, Ferruh Yigit wrote: > > On 1/14/2021 4:36 PM, Ferruh Yigit wrote: >> On 1/14/2021 9:45 AM, Steve Yang wrote: >>> Ethdev is using default Ethernet overhead to decide if provided >>> 'max_rx_pkt_len' value is bigger than max (non jumbo) MTU value, >>> and limits i

Re: [dpdk-dev] [PATCH 07/40] net/virtio: move MSIX detection to PCI ethdev

On 1/6/21 9:22 AM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin > wrote: >> >> There is no point it detecting whether we can use MSIX >> every time the interrupt is enabled/disabled/masked. >> >> Let's do it once for all at PCI device init time. >> >> Signed-off-by:

Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

On 1/14/2021 4:36 PM, Ferruh Yigit wrote: On 1/14/2021 9:45 AM, Steve Yang wrote: Ethdev is using default Ethernet overhead to decide if provided 'max_rx_pkt_len' value is bigger than max (non jumbo) MTU value, and limits it to MAX if it is. Since the application/driver used Ethernet overhead i

Re: [dpdk-dev] [PATCH] test: don't break terminal settings when running tests

> From: Stephen Hemminger > Sent: Thursday, January 14, 2021 4:46 PM > To: Richardson, Bruce ; Van Haaren, Harry > ; De Lara Guarch, Pablo > > Cc: sta...@dpdk.org; dev@dpdk.org; Stephen Hemminger > > Subject: [PATCH] test: don't break terminal settings when running tests > > When running one te

[dpdk-dev] [PATCH] test: add missing ticketlock test to fast tests

The ticketlock test is fast and should be run all the time. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test/meson.build b/app/test/meson.build index 94fd39fecb82..90c4d05814f1 100644 --- a/app/test/meson.build +++ b/app/test/

[dpdk-dev] [PATCH v2] eal/rwlock: add note about writer starvation

The implementation of reader/writer locks in DPDK (from first release) is simple and fast. But it can lead to writer starvation issues. It is not easy to fix this without changing ABI and potentially breaking customer applications that are expect the unfair behavior. The wikipedia page on reader-

Re: [dpdk-dev] [dpdk-stable] 18.11.11 (LTS) patches review and test

On 14/01/2021 15:11, Ali Alnubani wrote: > Hi, > Hi Ali, >> -Original Message- >> From: stable On Behalf Of Kevin Traynor >> Sent: Thursday, December 17, 2020 2:03 PM >> To: sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Akhil Goyal ; Ali Alnubani ; >> benjamin.wal...@intel.

Re: [dpdk-dev] 18.11.11 (LTS) patches review and test

On 14/01/2021 14:32, Govindharajan, Hariprasad wrote: > >> -Original Message- >> From: Kevin Traynor >> Sent: Thursday, December 17, 2020 12:03 PM >> To: sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Akhil Goyal ; Ali Alnubani ; >> Walker, Benjamin ; David Christensen >> ; He

[dpdk-dev] [PATCH] test/rwlock: fix spelling and missing whitespace

Trivial fix to for spelling errors and incorrect spacing. No change to any built code. Signed-off-by: Stephen Hemminger --- app/test/test_rwlock.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/app/test/test_rwlock.c b/app/test/test_rwlock.c index 701187f39884..c487

[dpdk-dev] [PATCH] test: don't break terminal settings when running tests

When running one test (via DPDK_TEST) the test program would leave the terminal in raw mode. This was because it was setting up cmdline to do interactive input. The fix is to use cmdline_new() for the interactive case. This also fixes a memory leak because the test runner was never calling cmdli

Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

On 1/14/2021 9:45 AM, Steve Yang wrote: Ethdev is using default Ethernet overhead to decide if provided 'max_rx_pkt_len' value is bigger than max (non jumbo) MTU value, and limits it to MAX if it is. Since the application/driver used Ethernet overhead is different than the ethdev one, check resu

Re: [dpdk-dev] [PATCH v7 3/3] test: change external memory test to use system page sz

On Tue, Jan 12, 2021 at 6:39 PM Nithin Dabilpuram wrote: > > Currently external memory test uses 4K page size. > VFIO DMA mapping works only with system page granularity. > > Earlier it was working because all the contiguous mappings > were coalesced and mapped in one-go which ended up becoming >

Re: [dpdk-dev] [PATCH 17/20] app/chkincs: add chkincs app to verify headers

On Thu, Jan 14, 2021 at 05:04:11PM +0100, David Marchand wrote: > On Thu, Jan 14, 2021 at 12:09 PM Bruce Richardson > wrote: > > > > To verify that all DPDK headers are ok for inclusion directly in a C > > file, and are not missing any other pre-requisite headers, we can > > auto-generate for each

Re: [dpdk-dev] [PATCH 05/40] net/virtio: move PCI device init in dedicated file

On Thu, Jan 14, 2021 at 5:04 PM Maxime Coquelin wrote: > On 1/5/21 10:19 PM, David Marchand wrote: > >> static bool > >> rx_offload_enabled(struct virtio_hw *hw) > >> @@ -2521,7 +2419,7 @@ static void virtio_dev_free_mbufs(struct rte_eth_dev > >> *dev) > >> /* > >> * Stop device: disable int

Re: [dpdk-dev] [PATCH 17/20] app/chkincs: add chkincs app to verify headers

On Thu, Jan 14, 2021 at 12:09 PM Bruce Richardson wrote: > > To verify that all DPDK headers are ok for inclusion directly in a C > file, and are not missing any other pre-requisite headers, we can > auto-generate for each header an empty C file that includes that header. > Compiling these files w

Re: [dpdk-dev] [PATCH 05/40] net/virtio: move PCI device init in dedicated file

On 1/5/21 10:19 PM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin > wrote: >> diff --git a/drivers/net/virtio/virtio_ethdev.c >> b/drivers/net/virtio/virtio_ethdev.c >> index 99a5a1bb88..ca21a019e5 100644 >> --- a/drivers/net/virtio/virtio_ethdev.c >> +++ b/drivers/n

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal: fix errno on service cores init failure

On Wed, Jan 13, 2021 at 9:29 AM Olivier Matz wrote: > > Currently, when rte_service_init() fails at initialization, we > see the following message: > > Cannot init EAL: Exec format error > > This error code does describe the real issue. Instead, use the error > code returned by the function. > >

Re: [dpdk-dev] [PATCH v3 0/5] lpm lookup with sve support

On Thu, Jan 14, 2021 at 4:18 PM David Marchand wrote: > > Ruifeng, Honnappa, > > On Tue, Jan 12, 2021 at 3:57 AM Ruifeng Wang wrote: > > > > Added lpm4 lookupx4 implementation by using Arm SVE extension. > > The SVE is Scalable Vector Extension which is exposed to the > > user with a vector lengt

Re: [dpdk-dev] [PATCH v2 0/4] lpm lookupx4 fixes

On Thu, Jan 14, 2021 at 7:59 AM Ruifeng Wang wrote: > > This series fixed bug in lpm4 vector lookup implementations. > When more than 256 tbl8 groups are created, lookupx4 could > retrieve next hop data from wrong group. > The bug is there since next_hop field was expanded from > 8-bit to 24-bit,

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

From: Maxime Coquelin > On 1/14/21 2:09 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin > >> Hi Matan, > >> > >> On 1/14/21 12:49 PM, Matan Azrad wrote: > >>> Hi Maxime and David > >>> > >>> Thank you for Review. > >>> > >>> From: David Marchand > On Fri, Jan 8, 2021 at 9:48 AM Davi

Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: add support for generic copy rte flow action

Hi > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, January 13, 2021 7:08 PM > Subject: [PATCH v4 2/2] app/testpmd: add support for generic copy rte flow > action > > Add support for the RTE_FLOW_ACTION_COPY_FIELD to the testpmd. > Implement CLI to create the copy_field

Re: [dpdk-dev] [PATCH v3 0/5] lpm lookup with sve support

Ruifeng, Honnappa, On Tue, Jan 12, 2021 at 3:57 AM Ruifeng Wang wrote: > > Added lpm4 lookupx4 implementation by using Arm SVE extension. > The SVE is Scalable Vector Extension which is exposed to the > user with a vector length agnostic interface. > Refer to [1] for more information about SVE. >

Re: [dpdk-dev] [PATCH 2/2] fips_validation: fix gcm test

Hi Fan, > This patch fixes FIPS GCM test of the redundant plaintext string > write and insufficient test case support check for some corner > cases. > > Fixes: d09abf2d1007 ("examples/fips_validation: update GCM test") > Cc: roy.fan.zh...@intel.com > > Signed-off-by: Fan Zhang > --- I believe p

Re: [dpdk-dev] [dpdk-stable] 18.11.11 (LTS) patches review and test

Hi, > -Original Message- > From: stable On Behalf Of Kevin Traynor > Sent: Thursday, December 17, 2020 2:03 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > benjamin.wal...@intel.com; David Christensen ; > Hemant Agrawal ; Ian Stokes > ; Jer

Re: [dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status

Hi Bruce, >-Original Message- >From: Richardson, Bruce >Sent: Thursday 14 January 2021 12:18 >To: dev@dpdk.org >Cc: Richardson, Bruce ; sta...@dpdk.org; >Thomas Monjalon ; Yigit, Ferruh >; Andrew Rybchenko >; Power, Ciara ; >Wiles, Keith >Subject: [PATCH] ethdev: avoid blocking telemetry

[dpdk-dev] [PATCH] fbarray: fix incorrect overlap check

When we're attaching fbarrays in secondary processes, we check for whether the intended memory address for the fbarray is already in use by some other, local fbarray. However, the check for end-overlap (i.e. to see if our memory area's end overlaps with some other fbarray) is incorrectly counting e

Re: [dpdk-dev] [PATCH] ethdev: introduce generic copy rte flow action

Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Thursday, January 14, 2021 4:00 PM > Subject: Re: [dpdk-dev] [PATCH] ethdev: introduce generic copy rte flow action > > On Fri, Jan 8, 2021 at 12:02 PM Alexander Kozyrev > wrote: > > > > Implement a generic copy flow API to allo

[dpdk-dev] [PATCH v17 11/11] examples/l3fwd-power: enable PMD power mgmt

From: Liang Ma Add PMD power management feature support to l3fwd-power sample app. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov --- Notes: v12: - Allow selecting PMD power management scheme from command-line - Enforce 1 core 1 queue rule .../sample_app_ug/l3_forward_po

[dpdk-dev] [PATCH v17 10/11] net/ice: implement power management API

From: Liang Ma Implement support for the power management API by implementing a `get_monitor_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- drivers/net/ice/ice_ethdev.c | 1 + dri

[dpdk-dev] [PATCH v17 09/11] net/i40e: implement power management API

From: Liang Ma Implement support for the power management API by implementing a `get_monitor_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev Acked-by: Jeff Guo --- drivers/net/i40e/i40

[dpdk-dev] [PATCH v17 08/11] net/ixgbe: implement power management API

From: Liang Ma Implement support for the power management API by implementing a `get_monitor_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Anatoly Burakov Signed-off-by: Liang Ma Acked-by: Konstantin Ananyev --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 +

[dpdk-dev] [PATCH v17 07/11] power: add PMD power management API and callback

From: Liang Ma Add a simple on/off switch that will enable saving power when no packets are arriving. It is based on counting the number of empty polls and, when the number reaches a certain threshold, entering an architecture-defined optimized power state that will either wait until a TSC timest

[dpdk-dev] [PATCH v17 04/11] eal: remove sync version of power monitor

Currently, the "sync" version of power monitor intrinsic is supposed to be used for purposes of waking up a sleeping core. However, there are better ways to achieve the same result, so remove the unneeded function. Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- lib/librte_eal/a

[dpdk-dev] [PATCH v17 06/11] ethdev: add simple power management API

From: Liang Ma Add a simple API to allow getting the monitor conditions for power-optimized monitoring of the Rx queues from the PMD, as well as release notes information. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Andrew Rybchenko --- Notes: v17: - Added libabi

[dpdk-dev] [PATCH v17 05/11] eal: add monitor wakeup function

Now that we have everything in a C file, we can store the information about our sleep, and have a native mechanism to wake up the sleeping core. This mechanism would however only wake up a core that's sleeping while monitoring - waking up from `rte_power_pause` won't work. Signed-off-by: Anatoly B

[dpdk-dev] [PATCH v17 03/11] eal: change API of power intrinsics

Instead of passing around pointers and integers, collect everything into struct. This makes API design around these intrinsics much easier. Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v16: - Add error handling drivers/event/dlb/dlb.c |

[dpdk-dev] [PATCH v17 02/11] eal: avoid invalid API usage in power intrinsics

Currently, the API documentation mandates that if the user wants to use the power management intrinsics, they need to call the `rte_cpu_get_intrinsics_support` API and check support for specific intrinsics. However, if the user does not do that, it is possible to get illegal instruction error beca

[dpdk-dev] [PATCH v17 01/11] eal: uninline power intrinsics

Currently, power intrinsics are inline functions. Make them part of the ABI so that we can have various internal data associated with them without exposing said data to the outside world. Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v14: - Fix compile issues on

[dpdk-dev] [PATCH v17 00/11] Add PMD power management

This patchset proposes a simple API for Ethernet drivers to cause the CPU to enter a power-optimized state while waiting for packets to arrive. There are multiple proposed mechanisms to achieve said power savings: simple frequency scaling, idle loop, and monitoring the Rx queue for incoming pac

Re: [dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata

On 1/14/21 3:40 PM, David Marchand wrote: > On Thu, Jan 14, 2021 at 12:05 PM Maxime Coquelin > wrote: >> On 1/5/21 10:16 PM, David Marchand wrote: >>> On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin >>> wrote: This patch initiate refactoring of Virtio PCI, by introducing a new

Re: [dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata

On Thu, Jan 14, 2021 at 12:05 PM Maxime Coquelin wrote: > On 1/5/21 10:16 PM, David Marchand wrote: > > On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin > > wrote: > >> > >> This patch initiate refactoring of Virtio PCI, by introducing > >> a new device structure for PCI-specific metadata. > > >

Re: [dpdk-dev] [PATCH v6 3/9] app/testpmd: add GENEVE header option length support

> -Original Message- > From: Shiri Kuzin > Sent: Thursday, January 14, 2021 9:08 AM > To: dev@dpdk.org > Subject: [PATCH v6 3/9] app/testpmd: add GENEVE header option length > support > > From: Viacheslav Ovsiienko > > The patch adds the GENEVE rte flow option length support to > com

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

On 12/24/2020 6:59 AM, Jeff Guo wrote: Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel type. Signed-off-by: Jeff Guo Reviewed-by: Qi Zhang Reviewed-by: Ferruh Yigit But since you will be sending a new version of the set, can you please include a short release notes update

Re: [dpdk-dev] [dpdk-dev v2 2/2] app/testpmd: add new UDP tunnel port for ecpri

On 12/24/2020 6:59 AM, Jeff Guo wrote: Add new UDP tunnel port params for ecpri configuration, the command as below: testpmd> port config 0 udp_tunnel_port add ecpri 6789 testpmd> port config 0 udp_tunnel_port rm ecpri 6789 Signed-off-by: Jeff Guo --- app/test-pmd/cmdline.c | 7 +-- 1 f

Re: [dpdk-dev] 18.11.11 (LTS) patches review and test

> -Original Message- > From: Kevin Traynor > Sent: Thursday, December 17, 2020 12:03 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > Walker, Benjamin ; David Christensen > ; Hemant Agrawal ; > Stokes, Ian ; Jerin Jacob ; > Mcnamara, John ;

  1   2   3   >