On Thu, Jan 14, 2021 at 12:05 PM Maxime Coquelin <maxime.coque...@redhat.com> wrote: > On 1/5/21 10:16 PM, David Marchand wrote: > > On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin > > <maxime.coque...@redhat.com> wrote: > >> > >> This patch initiate refactoring of Virtio PCI, by introducing > >> a new device structure for PCI-specific metadata. > > > > This works, but this patch seems artificial. > > > > The eth_virtio_dev_init expects dev->data->dev_private to be a virtio_hw > > object. > > You can introduce this later in the series when really needed. > > > > > I propose to squash it into patch 5, which moves PCI specific init to a > dedicated file. > > Is that OK for you?
Or leave this commit like this but add a check on the virtio_hw field being the first field of the bus specific objects. Something like: RTE_BUILD_BUG_ON(offsetof(struct virtio_pci_dev, hw) != 0); + the same with virtio_user in the relevant patch. -- David Marchand
