[dpdk-dev] [PATCH v4 4/4] examples/ifpga: add example for opae ifpga API

2020-12-29 Thread Wei Huang
An example application shows how to use opae ifpga APIs. You can test each API by running corresponding command. Signed-off-by: Wei Huang --- examples/ifpga/Makefile| 45 ++ examples/ifpga/commands.c | 1321 examples/ifpga/commands.h | 16 + example

[dpdk-dev] [PATCH v4 3/4] raw/ifpga: add opae API for Cyborg

2020-12-29 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE type APIs to manage PACs (Programmable Acceleration Card) with Intel FPGA. Below major functions are added to meets Cyborg requirements. 1. opae_init_eal() set up EAL environment. 2. opae_cleanup_eal() clean up EAL environment. 3. opae_enumerate() sea

[dpdk-dev] [PATCH v4 1/4] raw/ifpga: add fpga rsu function

2020-12-29 Thread Wei Huang
RSU (Remote System Update) depends on secure manager which may be different on various implementations, so a new secure manager device is implemented for adapting such difference. There are three major functions added: 1. ifpga_rawdev_update_flash() updates flash with specific image file. 2. ifpga_

[dpdk-dev] [PATCH v4 2/4] raw/ifpga: add fpga property get function

2020-12-29 Thread Wei Huang
There are three types of property can be got from FPGA, they are implemented in below functions: 1. ifpga_rawdev_get_fme_property() get property of FME (FPGA Management Engine). 2. ifpga_rawdev_get_port_property() get property of FPGA port. 3. ifpga_rawdev_get_bmc_property() get property of BMC

[dpdk-dev] [PATCH v4 0/4] raw/ifpga: add extra OPAE APIs

2020-12-29 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE APIs to manage devices with Intel FPGA. The first three patches implement extra APIs to meet Cyborg requirement. The last patch add an example to show how to use these APIs. Main changes from v3: - Enclose macro PCI_EXT_CAP_ID in parentheses Wei Hua

Re: [dpdk-dev] [PATCH] net/iavf: fix vector id assignment

2020-12-29 Thread Xie, WeiX
Tested-by: Xie,WeiX < weix@intel.com> Regards, Xie Wei > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of > dapengx...@intel.com > Sent: Wednesday, December 30, 2020 2:54 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org

[dpdk-dev] [Bug 581] iavf_fdir: wrongly use rte_flow_item_* for copy to build protocol hdr

2020-12-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=581 murphy (murphyx.y...@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC|

[dpdk-dev] [PATCH] net/iavf: fix vector id assignment

2020-12-29 Thread dapengx . yu
From: YU DAPENG When the interrupt handle instance allows none packet I/O interrupts, the max value of vector_id is set to be less than the number of msix interrupts, but not equal to it. Which may cause same vector_id is sent to PF with opcode VIRTCHNL_OP_CONFIG_IRQ_MAP to setup the cause of int

[dpdk-dev] [PATCH v3 4/4] examples/ifpga: add example for opae ifpga API

2020-12-29 Thread Wei Huang
An example application shows how to use opae ifpga APIs. You can test each API by running corresponding command. Signed-off-by: Wei Huang --- examples/ifpga/Makefile| 45 ++ examples/ifpga/commands.c | 1321 examples/ifpga/commands.h | 16 + example

[dpdk-dev] [PATCH v3 3/4] raw/ifpga: add opae API for Cyborg

2020-12-29 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE type APIs to manage PACs (Programmable Acceleration Card) with Intel FPGA. Below major functions are added to meets Cyborg requirements. 1. opae_init_eal() set up EAL environment. 2. opae_cleanup_eal() clean up EAL environment. 3. opae_enumerate() sea

[dpdk-dev] [PATCH v3 2/4] raw/ifpga: add fpga property get function

2020-12-29 Thread Wei Huang
There are three types of property can be got from FPGA, they are implemented in below functions: 1. ifpga_rawdev_get_fme_property() get property of FME (FPGA Management Engine). 2. ifpga_rawdev_get_port_property() get property of FPGA port. 3. ifpga_rawdev_get_bmc_property() get property of BMC

[dpdk-dev] [PATCH v3 1/4] raw/ifpga: add fpga rsu function

2020-12-29 Thread Wei Huang
RSU (Remote System Update) depends on secure manager which may be different on various implementations, so a new secure manager device is implemented for adapting such difference. There are three major functions added: 1. ifpga_rawdev_update_flash() updates flash with specific image file. 2. ifpga_

[dpdk-dev] [PATCH v3 0/4] raw/ifpga: add extra OPAE APIs

2020-12-29 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE APIs to manage devices with Intel FPGA. The first three patches implement extra APIs to meet Cyborg requirement. The last patch add an example to show how to use these APIs. Main changes from v2: - Fix coding style issue Wei Huang (4): raw/ifpga:

[dpdk-dev] [Bug 449] Fortville X710 FDIR with flow APIs broken

2020-12-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=449 Steve Yang (stevex.y...@intel.com) changed: What|Removed |Added CC||stevex.y...@intel.com

[dpdk-dev] [PATCH] app/testpmd: fix RSS key

2020-12-29 Thread Zhang,Alvin
From: Alvin Zhang Since the patch '1848b117' has set the value of key in 'struct rte_flow_action_rss' to NULL, the PMD cannot get the RSS key now. This patch sets offset and size of the key pointer as the first parameter of the token 'key' and copies the start address of the 'HEX' data to the lo

Re: [dpdk-dev] [PATCH 22/40] net/virtio: remove last PCI refs in non-PCI code

2020-12-29 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 22/40] net/virtio: remove last PCI refs in

Re: [dpdk-dev] [PATCH 21/40] net/virtio: move vring alignment to generic header

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 21/40] net/virtio: move vring alignment to generic head

Re: [dpdk-dev] [PATCH 20/40] net/virtio: make interrupt handling more generic

2020-12-29 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 20/40] net/virtio: make interrupt handling

Re: [dpdk-dev] [PATCH 19/40] net/virtio: move config definitions to generic header

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 19/40] net/virtio: move config definitions to generic h

Re: [dpdk-dev] [PATCH 18/40] net/virtio: move virtqueue defines in generic header

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 18/40] net/virtio: move virtqueue defines in generic he

Re: [dpdk-dev] [PATCH 17/40] net/virtio: move features definition to generic header

2020-12-29 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 17/40] net/virtio: move features definition

Re: [dpdk-dev] [PATCH 16/40] net/virtio: introduce generic virtio header

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 16/40] net/virtio: introduce generic virtio header > >

Re: [dpdk-dev] [PATCH 15/40] net/virtio: move legacy IO to Virtio PCI

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 15/40] net/virtio: move legacy IO to Virtio PCI > > Th

Re: [dpdk-dev] [PATCH 14/40] net/virtio: pack virtio HW struct

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 14/40] net/virtio: pack virtio HW struct > > This patc

Re: [dpdk-dev] [PATCH 13/40] net/virtio: move PCI-specific fields to PCI device

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 13/40] net/virtio: move PCI-specific fields to PCI devi

Re: [dpdk-dev] [PATCH 12/40] net/virtio: remove bus type enum

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 12/40] net/virtio: remove bus type enum > > Bus type a

Re: [dpdk-dev] [PATCH 11/40] net/virtio: validate features at bus level

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 11/40] net/virtio: validate features at bus level > >

Re: [dpdk-dev] [PATCH 10/40] net/virtio: add callback for device closing

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 10/40] net/virtio: add callback for device closing > >

Re: [dpdk-dev] [PATCH 09/40] net/virtio: store PCI type in Virtio device metadata

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 09/40] net/virtio: store PCI type in Virtio device meta

Re: [dpdk-dev] [PATCH 08/40] net/virtio: force IOVA as VA mode for Virtio-user

2020-12-29 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 08/40] net/virtio: force IOVA as VA mode fo

Re: [dpdk-dev] [PATCH 07/40] net/virtio: move MSIX detection to PCI ethdev

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 07/40] net/virtio: move MSIX detection to PCI ethdev >

Re: [dpdk-dev] [PATCH 06/40] net/virtio: move PCI specific dev init to PCI ethdev init

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 06/40] net/virtio: move PCI specific dev init to PCI et

Re: [dpdk-dev] [PATCH v1 1/4] raw/ifpga: add fpga rsu function

2020-12-29 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: 2020年12月30日 9:54 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Huang, Wei > > Subject: [PATCH v1 1/4] raw/ifpga: add fpga rsu function > > RSU (Remote System Update) depends on secure manager whic

Re: [dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:13 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 04/40] net/virtio: introduce PCI device metadata > > T

Re: [dpdk-dev] [PATCH 01/40] bus/vdev: add helper to get vdev from eth dev

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:13 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 01/40] bus/vdev: add helper to get vdev from eth dev >

Re: [dpdk-dev] [PATCH 03/40] net/virtio: refactor virtio-user device

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:13 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 03/40] net/virtio: refactor virtio-user device > > Thi

Re: [dpdk-dev] [PATCH 02/40] net/virtio: Introduce Virtio bus type

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:13 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 02/40] net/virtio: Introduce Virtio bus type > > This

Re: [dpdk-dev] [PATCH 05/40] net/virtio: move PCI device init in dedicated file

2020-12-29 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 05/40] net/virtio: move PCI device init in

[dpdk-dev] [PATCH v2 4/4] examples/ifpga: add example for opae ifpga API

2020-12-29 Thread Wei Huang
An example application shows how to use opae ifpga APIs. You can test each API by running corresponding command. Signed-off-by: Wei Huang --- examples/ifpga/Makefile| 45 ++ examples/ifpga/commands.c | 1321 examples/ifpga/commands.h | 16 + example

[dpdk-dev] [PATCH v2 3/4] raw/ifpga: add opae API for Cyborg

2020-12-29 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE type APIs to manage PACs (Programmable Acceleration Card) with Intel FPGA. Below major functions are added to meets Cyborg requirements. 1. opae_init_eal() set up EAL environment. 2. opae_cleanup_eal() clean up EAL environment. 3. opae_enumerate() sea

[dpdk-dev] [PATCH v2 2/4] raw/ifpga: add fpga property get function

2020-12-29 Thread Wei Huang
There are three types of property can be got from FPGA, they are implemented in below functions: 1. ifpga_rawdev_get_fme_property() get property of FME (FPGA Management Engine). 2. ifpga_rawdev_get_port_property() get property of FPGA port. 3. ifpga_rawdev_get_bmc_property() get property of BMC

[dpdk-dev] [PATCH v2 1/4] raw/ifpga: add fpga rsu function

2020-12-29 Thread Wei Huang
RSU (Remote System Update) depends on secure manager which may be different on various implementations, so a new secure manager device is implemented for adapting such difference. There are three major functions added: 1. ifpga_rawdev_update_flash() updates flash with specific image file. 2. ifpga_

[dpdk-dev] [PATCH v2 0/4] raw/ifpga: add extra OPAE APIs

2020-12-29 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE APIs to manage devices with Intel FPGA. The first three patches implement extra APIs to meet Cyborg requirement. The last patch add an example to show how to use these APIs. Main changes from v1: - Fix coding style issue Wei Huang (4): raw/ifpga:

Re: [dpdk-dev] [PATCH 5/9] vfio_user: implement interrupt related APIs

2020-12-29 Thread Xia, Chenbo
Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Wednesday, December 30, 2020 9:05 AM > To: Xia, Chenbo ; dev@dpdk.org; tho...@monjalon.net; > david.march...@redhat.com > Cc: step...@networkplumber.org; Liang, Cunming ; Lu, > Xiuchun ; Li, Miao > Subject: RE: [PATCH 5/9] vf

Re: [dpdk-dev] [PATCH v2 5/8] emu/iavf: add resource management and internal logic of iavf

2020-12-29 Thread Xia, Chenbo
Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Tuesday, December 29, 2020 2:05 PM > To: Xia, Chenbo ; dev@dpdk.org; tho...@monjalon.net; > david.march...@redhat.com > Cc: step...@networkplumber.org; Liang, Cunming ; Lu, > Xiuchun ; Li, Miao > Subject: RE: [PATCH v2 5/8] e

[dpdk-dev] [PATCH v1 4/4] examples/ifpga: add example for opae ifpga API

2020-12-29 Thread Wei Huang
An example application shows how to use opae ifpga APIs. You can test each API by running corresponding command. Signed-off-by: Wei Huang --- examples/ifpga/Makefile| 45 ++ examples/ifpga/commands.c | 1321 examples/ifpga/commands.h | 16 + example

[dpdk-dev] [PATCH v1 3/4] raw/ifpga: add opae API for Cyborg

2020-12-29 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE type APIs to manage PACs (Programmable Acceleration Card) with Intel FPGA. Below major functions are added to meets Cyborg requirments. 1. opae_init_eal() set up EAL environment. 2. opae_cleanup_eal() clean up EAL environment. 3. opae_enumerate() sear

[dpdk-dev] [PATCH v1 2/4] raw/ifpga: add fpga property get function

2020-12-29 Thread Wei Huang
There are three types of property can be got from FPGA, they are implemented in below functions: 1. ifpga_rawdev_get_fme_property() get property of FME (FPGA Management Engine). 2. ifpga_rawdev_get_port_property() get property of FPGA port. 3. ifpga_rawdev_get_bmc_property() get property of BMC

[dpdk-dev] [PATCH v1 1/4] raw/ifpga: add fpga rsu function

2020-12-29 Thread Wei Huang
RSU (Remote System Update) depends on secure manager which may be different on various implementations, so a new secure manager device is implemented for adapting such difference. There are three major functions added: 1. ifpga_rawdev_update_flash() updates flash with specific image file. 2. ifpga_

[dpdk-dev] [PATCH v1 0/4] raw/ifpga: add extra OPAE APIs

2020-12-29 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE APIs to manage devices with Intel FPGA. The first three patches implement extra APIs to meet Cyborg requirement. The last patch add an example to show how to use these APIs. Wei Huang (4): raw/ifpga: add fpga rsu function raw/ifpga: add fpga prop

Re: [dpdk-dev] [PATCH 5/9] vfio_user: implement interrupt related APIs

2020-12-29 Thread Wu, Jingjing
> if ((cmd == VFIO_USER_DMA_MAP || cmd == VFIO_USER_DMA_UNMAP > || > + cmd == VFIO_USER_DEVICE_SET_IRQS || > cmd == VFIO_USER_DEVICE_RESET) > && dev->ops->lock_dp) { > dev->ops->lock_dp(dev_id, 1); About cmd "VFIO_USER_REGION_WRITE", irq

Re: [dpdk-dev] [PATCH v5] eal: add generic thread-local-storage functions

2020-12-29 Thread Dmitry Kozlyuk
On Sat, 26 Dec 2020 18:08:48 +0200, Tal Shnaiderman wrote: > diff --git a/lib/librte_eal/windows/meson.build > b/lib/librte_eal/windows/meson.build > index 3b2faf29eb..f4c3e2f12c 100644 > --- a/lib/librte_eal/windows/meson.build > +++ b/lib/librte_eal/windows/meson.build > @@ -21,4 +21,10 @@ sourc

Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2020-12-29 Thread Ashish Sadanandan
Hi Stephen, Should I reference the commit that created rte_mbuf_dyn.h for the Fixes tag? PS: this is my first time submitting a patch to DPDK, so forgive me if this is covered in the contributing doc, but I couldn't find anything that applied to this situation On Tue, Dec 29, 2020 at 1:10 PM Step

Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2020-12-29 Thread Stephen Hemminger
On Tue, 29 Dec 2020 12:41:44 -0700 Ashish Sadanandan wrote: > The header was missing the extern "C" directive which causes name > mangling of functions by C++ compilers, leading to linker errors > complaining of undefined references to these functions. > > Signed-off-by: Ashish Sadanandan Coul

[dpdk-dev] [PATCH v2 3/3] pdump: cleanup checkpatch warnings

2020-12-29 Thread Stephen Hemminger
Checkpatch prefers 'unsigned int' over bare 'unsigned'. Reword the error messages for brevity and clarity so they don't have to be split across multiple lines. Signed-off-by: Stephen Hemminger --- lib/librte_pdump/rte_pdump.c | 28 ++-- 1 file changed, 14 insertions(+), 1

[dpdk-dev] [PATCH v2 2/3] pdump: replace DEVICE_ID_SIZE with RTE_DEV_NAME_MAX_LEN

2020-12-29 Thread Stephen Hemminger
The device string has an existing size in rte_dev.h use that instead of defining our own. Signed-off-by: Stephen Hemminger --- lib/librte_pdump/rte_pdump.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.

[dpdk-dev] [PATCH v2 1/3] pdump: use rte_pktmbuf_free bulk

2020-12-29 Thread Stephen Hemminger
Use rte_pktmbuf_free_bulk instead of loop when freeing packets. Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 8 lib/librte_pdump/rte_pdump.c | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index b34bf3

[dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2020-12-29 Thread Ashish Sadanandan
The header was missing the extern "C" directive which causes name mangling of functions by C++ compilers, leading to linker errors complaining of undefined references to these functions. Signed-off-by: Ashish Sadanandan --- lib/librte_mbuf/rte_mbuf_dyn.h | 9 + 1 file changed, 9 insertio

Re: [dpdk-dev] Potential regression introduced by commit b10231aed1edb9

2020-12-29 Thread Igor Russkikh
Hi Balazs, This could be a regression for your specific usecase. The commit itself tried to fix promisc as is. Adding more people to comment/investigate here. Devendra, could it be that we don't consider subsequent calls of promisc_enabled + allmulti_enable ? On 18/12/2020 2:34 pm, Balazs Neme

Re: [dpdk-dev] [PATCH 2/6] app/testpmd: add GTP PSC option support in raw sets

2020-12-29 Thread Ori Kam
Hi > -Original Message- > From: Shiri Kuzin > Sent: Monday, December 28, 2020 9:44 PM > From: Viacheslav Ovsiienko > > This patch add support for generating GTP PDU container > session option for the raw encap and raw decap sets. > The generated options is single 32-bit word with > min

Re: [dpdk-dev] [PATCH 1/6] ethdev: update GTP headers

2020-12-29 Thread Ori Kam
> -Original Message- > From: Shiri Kuzin > > From: Viacheslav Ovsiienko > > This patch introduces the GTP header individual flag bit fields > and the header optional word with N-PDU number, Sequence Number > and Next Extension Header type. > > Signed-off-by: Viacheslav Ovsiienko >

Re: [dpdk-dev] [PATCH 1/8] lib/librte_ethdev: introduce GENEVE header TLV option item

2020-12-29 Thread Ori Kam
> -Original Message- > From: Stephen Hemminger > > On Sun, 27 Dec 2020 18:06:16 +0200 > Shiri Kuzin wrote: > > > +#ifdef PEDANTIC > > +#pragma GCC diagnostic ignored "-Wpedantic" > > +#endif > > Please do not introduce pragma's for pedantic in standard headers. > It just clutters th

Re: [dpdk-dev] 18.11.11 (LTS) patches review and test

2020-12-29 Thread Chen, BoX C
Hi Kevin, Update DPDK 18.11.11 (LTS) test result for Intel part. All passed except the known issues. * Intel(R) Testing # Basic Intel(R) NIC testing * PF(i40e):Passed known issue: create rule for set hash key, but rule create failed. * PF(ixgbe):Passed * VF(i40e):Passed * VF(ixgbe):Passe

[dpdk-dev] [PATCH v2 00/17] common/mlx5: share DevX resources creations

2020-12-29 Thread Michael Baum
Due to many instances of creating CQ SQ and RQ on DevX, they move to common. v1: Initial release v2: Bug fix (sending wrong umem id to FW). Michael Baum (17): net/mlx5: fix ASO SQ creation error flow common/mlx5: share DevX CQ creation regex/mlx5: move DevX CQ creation to common vdpa/mlx5

[dpdk-dev] [PATCH v2 15/17] common/mlx5: share DevX RQ creation

2020-12-29 Thread Michael Baum
The RQ object in DevX is used currently only in net driver, but it share for future. Add a structure that contains all the resources, and provide creation and release functions for it. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_devx.c | 116 ++

[dpdk-dev] [PATCH v2 13/17] net/mlx5: move Tx SQ creation to common

2020-12-29 Thread Michael Baum
Using common function for Tx SQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 8 +-- drivers/net/mlx5/mlx5_devx.c | 160 ++- 2 files changed, 40 insertions(+), 128 deletions(-) diff --git a/drivers/net/m

[dpdk-dev] [PATCH v2 12/17] net/mlx5: move rearm and clock queue SQ creation to common

2020-12-29 Thread Michael Baum
Using common function for DevX SQ creation for rearm and clock queue. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 8 +-- drivers/net/mlx5/mlx5_txpp.c | 147 +++ 2 files changed, 36 insertions(+), 119 deletions(-)

[dpdk-dev] [PATCH v2 17/17] common/mlx5: remove doorbell allocation API

2020-12-29 Thread Michael Baum
The mlx5_devx_dbr_page structure was used to allocate and release the umem of the doorbells. Since doorbell and buffer have used same umem, this structure is useless. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 122 --

[dpdk-dev] [PATCH v2 16/17] net/mlx5: move Rx RQ creation to common

2020-12-29 Thread Michael Baum
Using common function for Rx RQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 4 +- drivers/net/mlx5/mlx5_devx.c | 178 +-- drivers/net/mlx5/mlx5_rxtx.h | 4 - 3 files changed, 37 insertions(+), 149 del

[dpdk-dev] [PATCH v2 14/17] net/mlx5: move ASO SQ creation to common

2020-12-29 Thread Michael Baum
Using common function for ASO SQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_devx.h | 1 + drivers/net/mlx5/mlx5.h| 8 +-- drivers/net/mlx5/mlx5_flow_age.c | 94 ++ 3 files changed, 30 in

[dpdk-dev] [PATCH v2 10/17] common/mlx5: share DevX SQ creation

2020-12-29 Thread Michael Baum
The SQ object in DevX is created in several places and in several different drivers. In all places almost all the details are the same, and in particular the allocations of the required resources. Add a structure that contains all the resources, and provide creation and release functions for it.

[dpdk-dev] [PATCH v2 09/17] common/mlx5: enhance page size configuration

2020-12-29 Thread Michael Baum
The PRM calculates page size in 4K, so need to reduce the log_wq_pg_sz attribute. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 53 drivers/net/mlx5/mlx5_devx.c | 13 + 2 files changed, 30 insert

[dpdk-dev] [PATCH v2 07/17] net/mlx5: move Tx CQ creation to common

2020-12-29 Thread Michael Baum
Using common function for Tx CQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 6 +- drivers/net/mlx5/mlx5_devx.c | 182 +++ 2 files changed, 31 insertions(+), 157 deletions(-) diff --git a/drivers/net/ml

[dpdk-dev] [PATCH v2 05/17] net/mlx5: move rearm and clock queue CQ creation to common

2020-12-29 Thread Michael Baum
Using common function for CQ creation at rearm queue and clock queue. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 9 +-- drivers/net/mlx5/mlx5_rxtx.c | 2 +- drivers/net/mlx5/mlx5_txpp.c | 147 +++ 3 files chan

[dpdk-dev] [PATCH v2 03/17] regex/mlx5: move DevX CQ creation to common

2020-12-29 Thread Michael Baum
Using common function for DevX CQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/regex/mlx5/mlx5_regex.c | 6 --- drivers/regex/mlx5/mlx5_regex.h | 9 +--- drivers/regex/mlx5/mlx5_regex_control.c | 91 ++-- drivers/regex/

[dpdk-dev] [PATCH v2 08/17] net/mlx5: move Rx CQ creation to common

2020-12-29 Thread Michael Baum
Using common function for Rx CQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c | 8 --- drivers/net/mlx5/mlx5.h | 3 +- drivers/net/mlx5/mlx5_devx.c | 142 +-- drivers/net/mlx5/mlx5_rxtx.h | 4 -- 4

[dpdk-dev] [PATCH v2 04/17] vdpa/mlx5: move DevX CQ creation to common

2020-12-29 Thread Michael Baum
Using common function for DevX CQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa.h | 10 + drivers/vdpa/mlx5/mlx5_vdpa_event.c | 81 +++-- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 2 +- 3 files changed, 26 inse

[dpdk-dev] [PATCH v2 02/17] common/mlx5: share DevX CQ creation

2020-12-29 Thread Michael Baum
The CQ object in DevX is created in several places and in several different drivers. In all places almost all the details are the same, and in particular the allocations of the required resources. Add a structure that contains all the resources, and provide creation and release functions for it.

[dpdk-dev] [PATCH v2 01/17] net/mlx5: fix ASO SQ creation error flow

2020-12-29 Thread Michael Baum
In ASO SQ creation, the PMD allocates umem buffer for SQ. When umem buffer allocation is fails, the MR and CQ memory are not freed what caused a memory leak. Free it. Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: M

[dpdk-dev] [PATCH v2 06/17] net/mlx5: move ASO CQ creation to common

2020-12-29 Thread Michael Baum
Use common function for ASO CQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 8 +--- drivers/net/mlx5/mlx5_flow_age.c | 81 +--- 2 files changed, 19 insertions(+), 70 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH v2 11/17] regex/mlx5: move DevX SQ creation to common

2020-12-29 Thread Michael Baum
Using common function for DevX SQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/regex/mlx5/mlx5_regex.h | 8 +- drivers/regex/mlx5/mlx5_regex_control.c | 153 ++- drivers/regex/mlx5/mlx5_regex_fastpath.c | 14 +-- 3 files change