[dpdk-dev] [PATCH 2/2] net/netvsc: support VF device hot add/remove

2020-11-30 Thread Long Li
From: Long Li When a VF device is present, netvsc can send or receive packets over the VF device. The VF device driver communicates directly with the PCI device via the PF from the host hypervisor. This is faster than exchanging data with netvsp via vmbus, i.e. syntheic path. In Azure and Hyper-

[dpdk-dev] [PATCH 1/2] eal/hotplug: allow monitor to be setup by multiple places

2020-11-30 Thread Long Li
From: Stephen Hemminger In some cases, a device or infrastructure may want to enable hotplug but application may also try and start hotplug as well. Therefore change the monitor_started from a boolean into a reference count. Signed-off-by: Stephen Hemminger Signed-off-by: Long Li --- lib/libr

[dpdk-dev] [PATCH] common/sfc_efx/base: support alternative MAE match fields

2020-11-30 Thread Ivan Malov
If MAE slice is configured without conntrack support, outer rules must match on IP SRC/DST. This isn't reported clearly by the FW because IPv4 and IPv6 have separate SRC/DST pairs. The FW reports status ALWAYS for all these four fields, and having an all-zeros mask for either field prevents the spe

[dpdk-dev] [PATCH v2 2/2] common/sfc_efx/base: fix signed/unsigned mismatch warnings

2020-11-30 Thread Ivan Malov
Fix signed/unsigned mismatch issues found by Windows build. Fixes: 34285fd0891d ("common/sfc_efx/base: add match spec validate API") Fixes: bb71f7e0a35a ("common/sfc_efx/base: add match specs class comparison API") Fixes: e9d5c5fb6872 ("common/sfc_efx/base: avoid reading past buffer") Cc: sta...@

[dpdk-dev] [PATCH v2 1/2] common/sfc_efx/base: remove warnings about inline specifiers

2020-11-30 Thread Ivan Malov
Windows build of the current libefx rejects these specifiers. They're unneeded anyway; the compiler should decide inlining. Fixes: 34285fd0891d ("common/sfc_efx/base: add match spec validate API") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy More

[dpdk-dev] Basic question about where to write config for optional feature

2020-11-30 Thread Hideyuki Yamashita
Hello, I am planning to propose patch for optional feature. Question: Where should I write compile switch for optional features? I was planning to add flag to enable optional festures into config/common_base like following: +# +# Compile the api statistics library +# +CONFIG_RTE_LIBRTE_APIST

[dpdk-dev] [PATCH] net/bnxt: fix memory leak when mapping failure

2020-11-30 Thread wangyunjian
From: Yunjian Wang We allocated memory for the 'buf' when sending message to HWRM, but we don't free it when mapping the address to IO address fails. It will lead to memory leak. Fixes: 19e6af01bb36 ("net/bnxt: support get/set EEPROM") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drive

Re: [dpdk-dev] NTT TechnoCross roadmap for 21.02

2020-11-30 Thread Hideyuki Yamashita
Hello Baruch, Thanks for your feedback to our roadmap. And thanks for your sharing your thought. As you pointed out, I agree that there are different ways to measure/estimate cpu usage. I think my proposal is "roughly way". I understand that there are some interests on this enhancement. (measur

[dpdk-dev] [PATCH 1/2] common/sfc_efx/base: remove warnings about inline specifiers

2020-11-30 Thread Ivan Malov
Windows build of the current libefx rejects these specifiers. They're unneeded anyway; the compiler should decide inlining. Fixes: 34285fd0891d ("common/sfc_efx/base: add match spec validate API") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy More

[dpdk-dev] [PATCH 2/2] common/sfc_efx/base: fix signed/unsigned mismatch warnings

2020-11-30 Thread Ivan Malov
Fix signed/unsigned mismatch issues found by Windows build. Fixes: 34285fd0891d ("common/sfc_efx/base: add match spec validate API") Fixes: bb71f7e0a35a ("common/sfc_efx/base: add match specs class comparison API") Fixes: e9d5c5fb6872 ("common/sfc_efx/base: avoid reading past buffer") Cc: sta...@

Re: [dpdk-dev] [EXT] [PATCH v2 1/1] librte_eal: rte_intr_callback_unregister_sync() - wrapper around rte_intr_callback_unregister().

2020-11-30 Thread Renata Saiakhova
Hi Harman, sorry for late reply... Yes, indeed, this is a race between an application which calls rte_dev_remove() and a kernel event which is sent as a result of unbinding the device from vfio_pci driver. (dpdk-devbind.py -u :05:00.0) rte_intr_callback_unregister() may fail and return -EA

[dpdk-dev] [PATCH] net/virtio-user: fix error run close(0)

2020-11-30 Thread Jiawei Zhu
From: Jiawei Zhu When i < VIRTIO_MAX_VIRTQUEUES and j == i, dev->callfds[i] and dev->kickfds[i] are default 0. So it will close(0), close the standard input (stdin). Fixes: e6e7ad8b3024 ("net/virtio-user: move eventfd open/close into init/uninit") Cc: sta...@dpdk.org Signed-off-by: Jiawei Zhu

Re: [dpdk-dev] [PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size

2020-11-30 Thread Stephen Hemminger
On Mon, 30 Nov 2020 17:47:19 +0500 Sarosh Arif wrote: > -sys.exit('{} is not a valid system huge page size'.format(size)) > - > +print('{} is not a valid system huge page size'.format(size)) > +show_valid_page_sizes(path) > +sys.exit() This is not the same. You sh

Re: [dpdk-dev] [PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size

2020-11-30 Thread Stephen Hemminger
On Mon, 30 Nov 2020 17:47:19 +0500 Sarosh Arif wrote: > If user requests a hugepage size which is not supported by the system, > currently user gets an error message saying that the requested size > is not a valid system huge page size. In addition to this if we display > the valid hugepage sizes

Re: [dpdk-dev] [PATCH] usertools: show an error message if unable to reserve requested hugepages

2020-11-30 Thread Stephen Hemminger
On Mon, 30 Nov 2020 17:45:33 +0500 Sarosh Arif wrote: > Sometimes the system is unable to reserve the requested hugepages because > enough space is not available in the RAM. In that case, currently the > script displays no error message hence the user can be under the delusion > that the hugepage

[dpdk-dev] [Bug 585] Direct PCI access violation with VFIO and lockdown mode

2020-11-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=585 Bug ID: 585 Summary: Direct PCI access violation with VFIO and lockdown mode Product: DPDK Version: 19.11 Hardware: ARM OS: Linux Status: UNCONFIRMED

Re: [dpdk-dev] [PATCH v10 0/5] aarch64 -> aarch32 cross compilation support

2020-11-30 Thread Aaron Conole
Juraj Linkeš writes: > Add support for aarch32 cross build in meson > and add aarch64 -> aarch32 cross build to Travis. > > Aarch32 is an execution state that allows execution of 32-bit code on > armv8 machines. This execution state contains a superset of previous > armv7 32-bit instructions and

[dpdk-dev] [PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size

2020-11-30 Thread Sarosh Arif
If user requests a hugepage size which is not supported by the system, currently user gets an error message saying that the requested size is not a valid system huge page size. In addition to this if we display the valid hugepage sizes it will be convenient for the user to request the right size ne

[dpdk-dev] [PATCH] usertools: show an error message if unable to reserve requested hugepages

2020-11-30 Thread Sarosh Arif
Sometimes the system is unable to reserve the requested hugepages because enough space is not available in the RAM. In that case, currently the script displays no error message hence the user can be under the delusion that the hugepages he requested are all successfully reserved. This patch display

Re: [dpdk-dev] [PATCH] version: 21.02-rc0

2020-11-30 Thread David Marchand
On Mon, Nov 30, 2020 at 10:48 AM Thomas Monjalon wrote: > > 30/11/2020 10:23, David Marchand: > > Start a new release cycle with empty release notes. > > > > Signed-off-by: David Marchand > > --- > [...] > > + Build the docs and view the output file to ensure the changes are > > correct:: > >

Re: [dpdk-dev] [PATCH] version: 21.02-rc0

2020-11-30 Thread Thomas Monjalon
30/11/2020 10:23, David Marchand: > Start a new release cycle with empty release notes. > > Signed-off-by: David Marchand > --- [...] > + Build the docs and view the output file to ensure the changes are > correct:: > + > + make doc-guides-html > + > + xdg-open build/doc/html/guides/

[dpdk-dev] [PATCH] version: 21.02-rc0

2020-11-30 Thread David Marchand
Start a new release cycle with empty release notes. Signed-off-by: David Marchand --- Here we go again! Patches have been archived in patchwork, all deferred patches are back in the NEW state. I'll send a separate patch to re-enable the ABI checks in the CI. Please maintainers, rebase your tre

Re: [dpdk-dev] [RFC V4] app/testpmd: fix queue stats mapping configuration

2020-11-30 Thread Min Hu (Connor)
Hi, Ferruh, and all, are there any comments about this set of patch? 在 2020/11/23 17:51, Ferruh Yigit 写道: On 11/21/2020 4:29 AM, Stephen Hemminger wrote: On Fri, 20 Nov 2020 23:33:40 + Ferruh Yigit wrote: On 11/20/2020 11:21 PM, Stephen Hemminger wrote: On Fri, 20 Nov 2020 17:26