[dpdk-dev] [PATCH v4] net/i40e: fix incorrect FDIR flex configuration

2020-11-09 Thread Chenxu Di
The configuration of FDIR flex mask and flex pit should not be set during flow validate. It should be set when flow create. Fixes: 6ced3dd72f5f ("net/i40e: support flexible payload parsing for FDIR") Cc: sta...@dpdk.org Signed-off-by: Chenxu Di Tested-by: Zhou, Jun Acked-by: Jeff Guo --- v4: -

Re: [dpdk-dev] [dpdk-techboard] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, November 9, 2020 7:05 PM > > On Mon, 9 Nov 2020 11:21:02 +0100 > Morten Brørup wrote: > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce > Richardson > > > Sent: Monday, November 9, 2020 11:06 AM > > >

Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect FDIR flex configuration

2020-11-09 Thread Guo, Jia
> -Original Message- > From: Chenxu Di > Sent: Tuesday, November 10, 2020 1:43 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Wang, > Haiyue ; Zhou, JunX W ; > Di, ChenxuX ; sta...@dpdk.org > Subject: [PATCH v3] net/i40e: fix incorrect FDIR flex configuration > > The configuration

[dpdk-dev] [PATCH] net/iavf: fix missed pointer check

2020-11-09 Thread Wenzhuo Lu
The return value of rte_mempool_default_cache should be checked as it can be NULL. Fixes: 9ab9514c150e ("net/iavf: enable AVX512 for Tx") Reported-by: Konstantin Ananyev Signed-off-by: Wenzhuo Lu --- drivers/net/iavf/iavf_rxtx_vec_avx512.c | 8 +++- 1 file changed, 7 insertions(+), 1 delet

[dpdk-dev] [PATCH] net/ice: fix missed pointer check

2020-11-09 Thread Wenzhuo Lu
The return value of rte_mempool_default_cache should be checked as it can be NULL. Fixes: a4e480de268e ("net/ice: optimize Tx by using AVX512") Reported-by: Konstantin Ananyev Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx_vec_avx512.c | 8 +++- 1 file changed, 7 insertions(+), 1 d

Re: [dpdk-dev] [PATCH 1/8] examples/fips_validation: enhance getopt_long usage

2020-11-09 Thread Ibtisam Tariq
Hello David, IMHO, it cannot be moved to read_uint16 parser. If we do, we can't verify that the user input value is greater than UINT16 MAX or not on the overflow data. > > + if (data_room_size == 0 || > > + data_room_size > UINT16_MAX) {

[dpdk-dev] [PATCH v3] net/i40e: fix incorrect FDIR flex configuration

2020-11-09 Thread Chenxu Di
The configuration of FDIR flex mask and flex pit should not be set during flow validate. It should be set when flow create. Fixes: 6ced3dd72f5f ("net/i40e: support flexible payload parsing for FDIR") Cc: sta...@dpdk.org Signed-off-by: Chenxu Di Tested-by: Zhou, Jun --- v3: -rebased the patch, f

Re: [dpdk-dev] [PATCH v2 1/2] net/iavf: fix reset VF doesn't notify PF to reset

2020-11-09 Thread Xing, Beilei
> -Original Message- > From: Steve Yang > Sent: Monday, November 9, 2020 2:52 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Xing, Beilei > ; Wu, Jingjing ; Yang, SteveX > > Subject: [PATCH v2 1/2] net/iavf: fix reset VF doesn't notify PF to reset > > When VF closed, the VF should notify

[dpdk-dev] [PATCH v2] net/mlx5: fix shared RSS action release

2020-11-09 Thread Suanming Mou
As shared RSS action will be shared by multiple flows, the action is created as global standalone action and managed only by the relevant shared action management functions. Currently, hrxqs will be created by shared RSS action or general queue action. For hrxqs created by shared RSS action, they

Re: [dpdk-dev] [PATCH v10 0/4] add async data path in vhost sample

2020-11-09 Thread Jiang, Cheng1
Hi, The replies are inline. > -Original Message- > From: David Marchand > Sent: Monday, November 9, 2020 8:40 PM > To: Maxime Coquelin ; Jiang, Cheng1 > > Cc: Xia, Chenbo ; dev ; Fu, Patrick > ; Yang, YvonneX ; > Thomas Monjalon ; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH v10 0/4

Re: [dpdk-dev] [PATCH] net/ice: fix core dump when device reset

2020-11-09 Thread Xie, WeiX
Tested-by: Xie,WeiX < weix@intel.com> Regards, Xie Wei > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Simei Su > Sent: Tuesday, November 10, 2020 10:02 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Wang, Haiyue ; Ding, Xuan > ; Su, Simei > Subject: [dpdk-de

Re: [dpdk-dev] [PATCH] net/ice: fix core dump when device reset

2020-11-09 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Tuesday, November 10, 2020 10:02 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Wang, Haiyue ; Ding, Xuan > ; Su, Simei > Subject: [PATCH] net/ice: fix core dump when device reset > > When device resets, it should not implememt ACL initializat

Re: [dpdk-dev] [PATCH v1] net/iavf: fix rxdid configure

2020-11-09 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Monday, November 9, 2020 2:05 PM > To: Wu, Jingjing ; Zhang, Qi Z ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH v1] net/iavf: fix rxdid configure > > When configure rx queue by virtchnnl, the rxdid should be configured o

Re: [dpdk-dev] [PATCH v2] doc: fix missing release note for large VF

2020-11-09 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Tuesday, November 10, 2020 9:56 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Xing, Beilei ; > Wu, Jingjing ; Xu, Ting ; > sta...@dpdk.org > Subject: [PATCH v2] doc: fix missing release note for large VF > > Update release note for large VF, suppo

[dpdk-dev] [PATCH v2] gso: add VXLAN UDP GSO support

2020-11-09 Thread yang_y_yi
From: Yi Yang Many NICs can't offload VXLAN UFO, so it is very important to do VXLAN UDP GSO by software to improve VM-to-VM UDP performance, especially for the case that VM MTU is just 1500 but not 9000. With this enabled in DPDK, OVS DPDK can leverage it to improve VM-to-VM UDP performance, pe

[dpdk-dev] [PATCH] net/ice: fix core dump when device reset

2020-11-09 Thread Simei Su
When device resets, it should not implememt ACL initialization which is only executed in DCF. This patch disable ACL init and uninit when in DPDK PF only mode. Fixes: 40d466fa9f76 ("net/ice: support ACL filter in DCF") Signed-off-by: Simei Su --- drivers/net/ice/ice_acl_filter.c | 12 --

Re: [dpdk-dev] [PATCH] net/txgbe: remove direct use of compiler attribute

2020-11-09 Thread Jiawen Wu
On Tuesday, November 10, 2020 3:19 AM, Ferruh Yigit wrote: > On 11/9/2020 7:43 AM, Jiawen Wu wrote: > > Remove direct use of compiler attribute. > > > > Signed-off-by: Jiawen Wu > > --- > > drivers/net/txgbe/base/txgbe_dummy.h | 2 +- > > drivers/net/txgbe/base/txgbe_osdep.h | 6 ++ > > 2

[dpdk-dev] [PATCH v2] doc: fix missing release note for large VF

2020-11-09 Thread Ting Xu
Update release note for large VF, supporting up to 256 queue pairs per VF. Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more queues") Cc: sta...@dpdk.org Signed-off-by: Ting Xu --- doc/guides/rel_notes/release_20_11.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/g

Re: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS action release

2020-11-09 Thread Suanming Mou
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, November 10, 2020 2:17 AM > To: Suanming Mou ; Slava Ovsiienko > ; Matan Azrad > Cc: Raslan Darawsheh ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS action release > > On 11/6/2020 3:08 AM, Suanming M

Re: [dpdk-dev] [PATCH v3 2/3] vhost: fix fd leak in dirty logging setup

2020-11-09 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, November 9, 2020 8:16 PM > To: dev@dpdk.org; Ding, Xuan ; > step...@networkplumber.org; tho...@monjalon.net; sta...@dpdk.org; Xia, > Chenbo > Cc: Maxime Coquelin > Subject: [PATCH v3 2/3] vhost: fix fd leak in dirty logging set

[dpdk-dev] [PATCH] maintainers: Update for OcteonTx2 DMA and EP

2020-11-09 Thread Radha Mohan Chintakuntla
Replace the maintainers for OcteonTx2 DMA and EP drivers. Signed-off-by: Radha Mohan Chintakuntla --- MAINTAINERS | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index a720cf672e..214515060a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1258,1

Re: [dpdk-dev] [PATCH v8 04/14] build: reformat and move Arm config and comments

2020-11-09 Thread Honnappa Nagarahalli
> > > Change formatting so that it's more consistent and readable, > > > add/modify comments/stdout messages, move configuration options to > > > more appropriate places and make the order consistent according to > > > these > > rules: > > > 1. First list generic configuration options, then list

Re: [dpdk-dev] [PATCH v8 14/14] build: add Arm SoC meson option

2020-11-09 Thread Honnappa Nagarahalli
> > > > > > > > Add Arm SoC configuration to Arm meson.build and add a meson option > > > to enable those options for native builds. This is preferable to > > > specifying a cross file when doing aarch64 -> aarch64 builds, since > > > the cross file specifies the toolchain as well. > > > > > > Si

Re: [dpdk-dev] [PATCH v8 13/14] build: disable libnuma in cross builds

2020-11-09 Thread Honnappa Nagarahalli
> > > > > > > > Some Arm SoCs are not NUMA systems. Add the capability to disable > > > NUMA for cross build and disabled NUMA in Arm cross files. > > > > > > Signed-off-by: Juraj Linkeš > > > --- > > > config/arm/arm64_armada_linux_gcc| 1 + > > > config/arm/arm64_armv8_linux_gcc | 1

Re: [dpdk-dev] [PATCH v8 12/14] build: disable Arm drivers

2020-11-09 Thread Honnappa Nagarahalli
> > > > > > > > A few options that disabled drivers in the old makefiles were > > > improperly ported to the meson build system. Fix this by adding a to > > > the list of disabled > > The fixes need to be separated into a different commit as they need to > > be backported. > > It would be good to

Re: [dpdk-dev] [PATCH v8 06/14] build: organize Arm config into dict

2020-11-09 Thread Honnappa Nagarahalli
> > > > > > > > Use dictionary lookup instead of checking for existing variables, > > > iterating over all elements in the list or checking lists for > > > optional configuration. Move variable contents into the dictionary > > > for variables that would be referenced only once. > > > Fallback to

[dpdk-dev] [PATCH] net/mlx5: fix nested flow creation error

2020-11-09 Thread Xueming Li
If xmedata mode 1 enabled and create a flow with RSS and mark action, there was an error that rdma-core failed to create RQT due to wrong queue definition. This was due to mixed flow creation in thread specific flow workspace. This patch introduces nested flow workspace(context data), each flow us

Re: [dpdk-dev] [PATCH v8 01/14] build: alias default build as generic

2020-11-09 Thread Honnappa Nagarahalli
> > > > > > The current machine='default' build name is not descriptive. The > > > actual default build is machine='native'. Add an alternative string > > > which does the same build and better describes what we're building: > > > machine='generic'. Leave machine='default' for backwards compatibi

Re: [dpdk-dev] [PATCH v8 10/14] build: optional NUMA and cpu counts detection

2020-11-09 Thread Honnappa Nagarahalli
> > Add an option to automatically discover the host's numa and cpu counts and > use those values for a non cross-build. > Give users the option to override the per-arch default values or values from > cross files by specifying them on the command line with -Dmax_lcores and - > Dmax_numa_nodes.

Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error

2020-11-09 Thread Honnappa Nagarahalli
> > > > > > > > [2339/2407] Compiling C object app/test/dpdk- > > > test.p/test_ring_mt_peek_stress_zc.c.o > > > FAILED: app/test/dpdk-test.p/test_ring_mt_peek_stress_zc.c.o > > > gcc -Iapp/test/dpdk-test.p -Iapp/test -I../app/test -Ilib/librte_acl > > > - I../lib/librte_acl -I. -I.. -Iconfig -I.

[dpdk-dev] [PATCH v2 2/2] mbuf: move pool pointer in first half

2020-11-09 Thread Thomas Monjalon
According to the Technical Board decision (http://mails.dpdk.org/archives/dev/2020-November/191859.html), the mempool pointer in the mbuf struct is moved from the second to the first half. It may increase performance in some cases on systems having 64-byte cache line, i.e. mbuf split in two cache l

[dpdk-dev] [PATCH v2 1/2] drivers: disable OCTEON TX2 in 32-bit build

2020-11-09 Thread Thomas Monjalon
The drivers for OCTEON TX2 are not supported in 32-bit mode. Suggested-by: Jerin Jacob Signed-off-by: Thomas Monjalon --- drivers/common/octeontx2/meson.build | 18 ++ drivers/crypto/octeontx2/meson.build | 17 +++-- drivers/event/octeontx2/meson.build | 18 +

[dpdk-dev] [PATCH v2 0/2] move mbuf pool pointer

2020-11-09 Thread Thomas Monjalon
After some discussions, it seems the best option is still to use the remaining space in the first half to move the pool pointer. The fields move has an impact on octeontx2 in 32-bit build. v2: disable octeontx2 drivers in 32-bit build. Thomas Monjalon (2): drivers: disable OCTEON TX2 in 32-bit

Re: [dpdk-dev] [PATCH v6 1/1] vfio: modify spapr iommu support to use static window sizing

2020-11-09 Thread Thomas Monjalon
09/11/2020 21:35, David Christensen: > The SPAPR IOMMU requires that a DMA window size be defined before memory > can be mapped for DMA. Current code dynamically modifies the DMA window > size in response to every new memory allocation which is potentially > dangerous because all existing mappings

Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build

2020-11-09 Thread Thomas Monjalon
09/11/2020 18:44, Thomas Monjalon: > 09/11/2020 18:20, Thomas Monjalon: > > 09/11/2020 18:15, Ferruh Yigit: > > > On 11/9/2020 5:01 PM, Thomas Monjalon wrote: > > > > 09/11/2020 17:48, Ferruh Yigit: > > > >> I can send a new version to reset 'CUSTOM_PKG_CONFIG_PATH', > > > >> what is the intention/

[dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env

2020-11-09 Thread Thomas Monjalon
PKG_CONFIG_PATH is specific to each target, so it must be empty before configuring each build from the file according to DPDK_TARGET. Inheriting a default PKG_CONFIG_PATH for all targets does not make sense and is prone to confusion. DPDK_MESON_OPTIONS might take a global initial value from enviro

[dpdk-dev] [PATCH v5 0/1] vfio: modify spapr iommu support to use static window sizing

2020-11-09 Thread David Christensen
The SPAPR v2 IOMMU used on bare-metal PowerNV systems requires that a DMA window be defined before mapping/unmapping memory. The current VFIO code dynamically resizes this DMA window every time a new memory request is made, which requires that all existing memory be unmapped/remapped. While this s

[dpdk-dev] [PATCH v6 1/1] vfio: modify spapr iommu support to use static window sizing

2020-11-09 Thread David Christensen
The SPAPR IOMMU requires that a DMA window size be defined before memory can be mapped for DMA. Current code dynamically modifies the DMA window size in response to every new memory allocation which is potentially dangerous because all existing mappings need to be unmapped/remapped in order to resi

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples

2020-11-09 Thread Thomas Monjalon
09/11/2020 19:02, Bruce Richardson: > On Mon, Nov 09, 2020 at 06:09:51PM +0100, Thomas Monjalon wrote: > > 27/10/2020 18:38, Bruce Richardson: > > > To test the installation process of DPDK using "ninja install" > > > test-meson-builds.sh builds a subset of the examples using "make". To > > > allo

Re: [dpdk-dev] [PATCH v3] doc: add reference to bbdev companion configuration tool

2020-11-09 Thread Chautru, Nicolas
Hi Akhil, Heads up on this doc update still to be applied. > -Original Message- > From: Tom Rix > Sent: Tuesday, November 3, 2020 12:00 PM > To: Chautru, Nicolas ; dev@dpdk.org; > akhil.go...@nxp.com; tho...@monjalon.net > Cc: Mcnamara, John ; > david.march...@redhat.com; Richardson, Br

Re: [dpdk-dev] [PATCH 00/37] net: add txgbe PMD part 2

2020-11-09 Thread Ferruh Yigit
On 11/3/2020 10:07 AM, Jiawen Wu wrote: Add the remaining part of txgbe PMD. Support include flow API, traffic manager, macsec and ipsec. Jiawen Wu (37): net/txgbe: add ntuple filter init and uninit net/txgbe: support ntuple filter add and delete net/txgbe: add ntuple parse rule net/

Re: [dpdk-dev] [PATCH] net/txgbe: remove direct use of compiler attribute

2020-11-09 Thread Ferruh Yigit
On 11/9/2020 7:43 AM, Jiawen Wu wrote: Remove direct use of compiler attribute. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_dummy.h | 2 +- drivers/net/txgbe/base/txgbe_osdep.h | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/txgbe/base/tx

Re: [dpdk-dev] [dpdk-stable] [PATCH] vhost: fix virtqueue initialization

2020-11-09 Thread Ferruh Yigit
On 11/9/2020 6:37 PM, Ferruh Yigit wrote: On 11/6/2020 2:47 PM, Maxime Coquelin wrote: This patches fixes virtqueue initialization issue causing segfault or file descriptor being closed unexpectedly. The wrong index was passed to init_vring_queue() by alloc_vring_queue() when a hole in the virt

Re: [dpdk-dev] [PATCH] vhost: fix virtqueue initialization

2020-11-09 Thread Maxime Coquelin
On 11/9/20 7:37 PM, Ferruh Yigit wrote: > On 11/6/2020 2:47 PM, Maxime Coquelin wrote: >> This patches fixes virtqueue initialization issue causing >> segfault or file descriptor being closed unexpectedly. >> >> The wrong index was passed to init_vring_queue() by >> alloc_vring_queue() when a ho

Re: [dpdk-dev] [PATCH] vhost: fix virtqueue initialization

2020-11-09 Thread Ferruh Yigit
On 11/9/2020 5:09 AM, Jiang, YuX wrote: Tested-by: JiangYuX Please don't top post. Also tag should be: "Tested-by: Yu Jiang " -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Friday, November 6, 2020 10:48 PM To: dev@dpdk.org; Xia, Chenbo ; amore

Re: [dpdk-dev] [PATCH] vhost: fix virtqueue initialization

2020-11-09 Thread Ferruh Yigit
On 11/6/2020 2:47 PM, Maxime Coquelin wrote: This patches fixes virtqueue initialization issue causing segfault or file descriptor being closed unexpectedly. The wrong index was passed to init_vring_queue() by alloc_vring_queue() when a hole in the virtqueue array was met. Fixes: 8acd7c213353 (

Re: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS action release

2020-11-09 Thread Ferruh Yigit
On 11/6/2020 3:08 AM, Suanming Mou wrote: As shared RSS action is global standalone action, the shared action should be maintained only by the shared action management functions. Currently, the shared RSS action hrxq uses the same fate action type with existed general queues, and implicitly uses

Re: [dpdk-dev] [dpdk-techboard] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Stephen Hemminger
On Mon, 9 Nov 2020 11:21:02 +0100 Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Monday, November 9, 2020 11:06 AM > > > > On Mon, Nov 09, 2020 at 09:16:27AM +0100, Morten Brørup wrote: > > > +CC techboard > > > > > > > From: Jerin Ja

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples

2020-11-09 Thread Bruce Richardson
On Mon, Nov 09, 2020 at 06:09:51PM +0100, Thomas Monjalon wrote: > 27/10/2020 18:38, Bruce Richardson: > > To test the installation process of DPDK using "ninja install" > > test-meson-builds.sh builds a subset of the examples using "make". To allow > > more flexibility for people testing, allow th

Re: [dpdk-dev] [PATCH] net/af_xdp: do not use fixed size storage for pointer

2020-11-09 Thread Loftus, Ciara
> > 'uint64_t' is used to hold the pointer, for 32-bits build this > assumption is wrong and giving following build error: > > rte_eth_af_xdp.c: In function ‘xdp_umem_configure’: > rte_eth_af_xdp.c:970:15: > error: cast to pointer from integer of different size >[-Werror=int-to-po

Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build

2020-11-09 Thread Thomas Monjalon
09/11/2020 18:20, Thomas Monjalon: > 09/11/2020 18:15, Ferruh Yigit: > > On 11/9/2020 5:01 PM, Thomas Monjalon wrote: > > > 09/11/2020 17:48, Ferruh Yigit: > > >> I can send a new version to reset 'CUSTOM_PKG_CONFIG_PATH', > > >> what is the intention/plan with the config file? > > > > > > You sho

Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not h

2020-11-09 Thread Ferruh Yigit
On 11/9/2020 9:49 AM, Zhang, Qi Z wrote: -Original Message- From: dev On Behalf Of Guo, Jia Sent: Monday, November 9, 2020 2:24 PM To: Prateek Agarwal Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cp

Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error

2020-11-09 Thread Walsh, Conor
> From: Honnappa Nagarahalli > Sent: Monday 9 November 2020 17:24 > To: Walsh, Conor ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Chen, LingliX ; nd > ; Honnappa Nagarahalli ; > nd > Subject: RE: [PATCH v1] app/test: zcd needs to be initialised to fix gcc > compile > error > > > > > > > > > >

Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error

2020-11-09 Thread Honnappa Nagarahalli
> > > > > > Hi Honnappa, > > > > > > Sorry about the delayed reply. > > No problem, thank you. > > > > > The build error trace is below, the build command used was: CC=gcc > > > meson > > -- > > > optimization=1 --werror build1; ninja -C build1 I am not sure how I > > > could fix this issue witho

Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build

2020-11-09 Thread Thomas Monjalon
09/11/2020 18:15, Ferruh Yigit: > On 11/9/2020 5:01 PM, Thomas Monjalon wrote: > > 09/11/2020 17:48, Ferruh Yigit: > >> On 11/9/2020 4:19 PM, Bruce Richardson wrote: > >>> On Mon, Nov 09, 2020 at 05:14:24PM +0100, Thomas Monjalon wrote: > 09/11/2020 16:44, Bruce Richardson: > > On Mon, Nov

Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build

2020-11-09 Thread Ferruh Yigit
On 11/9/2020 5:01 PM, Thomas Monjalon wrote: 09/11/2020 17:48, Ferruh Yigit: On 11/9/2020 4:19 PM, Bruce Richardson wrote: On Mon, Nov 09, 2020 at 05:14:24PM +0100, Thomas Monjalon wrote: 09/11/2020 16:44, Bruce Richardson: On Mon, Nov 09, 2020 at 04:28:16PM +0100, Thomas Monjalon wrote: 09/

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples

2020-11-09 Thread Thomas Monjalon
27/10/2020 18:38, Bruce Richardson: > To test the installation process of DPDK using "ninja install" > test-meson-builds.sh builds a subset of the examples using "make". To allow > more flexibility for people testing, allow the set of examples chosen for > this make test to be overridden using vari

Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error

2020-11-09 Thread Walsh, Conor
Hi Honnappa, > From: Honnappa Nagarahalli > Sent: Monday 9 November 2020 16:45 > To: Walsh, Conor ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Chen, LingliX ; nd > ; Honnappa Nagarahalli ; > nd > Subject: RE: [PATCH v1] app/test: zcd needs to be initialised to fix gcc > compile > error > > >

Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build

2020-11-09 Thread Thomas Monjalon
09/11/2020 17:48, Ferruh Yigit: > On 11/9/2020 4:19 PM, Bruce Richardson wrote: > > On Mon, Nov 09, 2020 at 05:14:24PM +0100, Thomas Monjalon wrote: > >> 09/11/2020 16:44, Bruce Richardson: > >>> On Mon, Nov 09, 2020 at 04:28:16PM +0100, Thomas Monjalon wrote: > 09/11/2020 15:55, Ferruh Yigit:

Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build

2020-11-09 Thread Ferruh Yigit
On 11/9/2020 4:19 PM, Bruce Richardson wrote: On Mon, Nov 09, 2020 at 05:14:24PM +0100, Thomas Monjalon wrote: 09/11/2020 16:44, Bruce Richardson: On Mon, Nov 09, 2020 at 04:28:16PM +0100, Thomas Monjalon wrote: 09/11/2020 15:55, Ferruh Yigit: If the 'PKG_CONFIG_PATH' is set in the environmen

Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error

2020-11-09 Thread Honnappa Nagarahalli
> > Hi Honnappa, > > Sorry about the delayed reply. No problem, thank you. > The build error trace is below, the build command used was: CC=gcc meson -- > optimization=1 --werror build1; ninja -C build1 I am not sure how I could fix > this issue without initialising zcd. > > [2339/2407] Compi

Re: [dpdk-dev] [PATCH v1] vhost: fix async inflight packet counter

2020-11-09 Thread Maxime Coquelin
On 11/3/20 6:35 AM, Patrick Fu wrote: > Async inflight packet counter should take failed packets into account. > Failed packets will be deducted in the error handling logic. > > Fixes: 6b3c81db8bb7 ("vhost: simplify async copy completion") > Fixes: cd6760da1076 ("vhost: introduce async enqueue

Re: [dpdk-dev] [PATCH] example/vhost_crypto: add new line character in usage

2020-11-09 Thread Maxime Coquelin
On 11/2/20 12:38 PM, Ibtisam Tariq wrote: > Add new line character(\n) in the usage of vhost_crypto example for > better readability > > Fixes: 709521f4c2c ("examples/vhost_crypto: support multi-core") > Cc: roy.fan.zh...@intel.com > > Signed-off-by: Ibtisam Tariq > --- > examples/vhost_cryp

Re: [dpdk-dev] [PATCH] vhost: fix virtqueue initialization

2020-11-09 Thread Maxime Coquelin
On 11/6/20 3:47 PM, Maxime Coquelin wrote: > This patches fixes virtqueue initialization issue causing > segfault or file descriptor being closed unexpectedly. > > The wrong index was passed to init_vring_queue() by > alloc_vring_queue() when a hole in the virtqueue array was > met. > > Fixes:

Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum

2020-11-09 Thread Stephen Hemminger
On Mon, 9 Nov 2020 16:10:45 + Bruce Richardson wrote: > On Mon, Nov 09, 2020 at 05:07:16PM +0100, David Marchand wrote: > > On Mon, Nov 9, 2020 at 5:06 PM Bruce Richardson > > wrote: > > > > > > On Mon, Nov 09, 2020 at 05:03:06PM +0100, David Marchand wrote: > > > > On Mon, Nov 9, 2020 a

Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error

2020-11-09 Thread Walsh, Conor
Hi Honnappa, Sorry about the delayed reply. The build error trace is below, the build command used was: CC=gcc meson --optimization=1 --werror build1; ninja -C build1 I am not sure how I could fix this issue without initialising zcd. [2339/2407] Compiling C object app/test/dpdk-test.p/test_ring

Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build

2020-11-09 Thread Bruce Richardson
On Mon, Nov 09, 2020 at 05:14:24PM +0100, Thomas Monjalon wrote: > 09/11/2020 16:44, Bruce Richardson: > > On Mon, Nov 09, 2020 at 04:28:16PM +0100, Thomas Monjalon wrote: > > > 09/11/2020 15:55, Ferruh Yigit: > > > > If the 'PKG_CONFIG_PATH' is set in the environment before script run, > > > > 32

Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build

2020-11-09 Thread Thomas Monjalon
09/11/2020 16:44, Bruce Richardson: > On Mon, Nov 09, 2020 at 04:28:16PM +0100, Thomas Monjalon wrote: > > 09/11/2020 15:55, Ferruh Yigit: > > > If the 'PKG_CONFIG_PATH' is set in the environment before script run, > > > 32 bit still uses that value for 64-bits libraries. > > > > > > From the buil

Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum

2020-11-09 Thread Bruce Richardson
On Mon, Nov 09, 2020 at 05:07:16PM +0100, David Marchand wrote: > On Mon, Nov 9, 2020 at 5:06 PM Bruce Richardson > wrote: > > > > On Mon, Nov 09, 2020 at 05:03:06PM +0100, David Marchand wrote: > > > On Mon, Nov 9, 2020 at 4:55 PM Stephen Hemminger > > > wrote: > > > > > This patch causes build

Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum

2020-11-09 Thread David Marchand
On Mon, Nov 9, 2020 at 5:06 PM Bruce Richardson wrote: > > On Mon, Nov 09, 2020 at 05:03:06PM +0100, David Marchand wrote: > > On Mon, Nov 9, 2020 at 4:55 PM Stephen Hemminger > > wrote: > > > > This patch causes build failures which persist until patch 3, because of > > > > these deprecations. I

Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum

2020-11-09 Thread Bruce Richardson
On Mon, Nov 09, 2020 at 05:03:06PM +0100, David Marchand wrote: > On Mon, Nov 9, 2020 at 4:55 PM Stephen Hemminger > wrote: > > > This patch causes build failures which persist until patch 3, because of > > > these deprecations. I think you need to define the backward-compatibility > > > macros he

Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum

2020-11-09 Thread Bruce Richardson
On Mon, Nov 09, 2020 at 07:54:40AM -0800, Stephen Hemminger wrote: > On Mon, 9 Nov 2020 13:49:31 + > Bruce Richardson wrote: > > > On Thu, Nov 05, 2020 at 02:35:57PM -0800, Stephen Hemminger wrote: > > > This patch renames the enum values in the EAL include files. > > > As a backward compatib

Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum

2020-11-09 Thread David Marchand
On Mon, Nov 9, 2020 at 4:55 PM Stephen Hemminger wrote: > > This patch causes build failures which persist until patch 3, because of > > these deprecations. I think you need to define the backward-compatibility > > macros here, but only mark them deprecated at the end of the set. > > > > /Bruce >

Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum

2020-11-09 Thread Stephen Hemminger
On Mon, 9 Nov 2020 13:49:31 + Bruce Richardson wrote: > On Thu, Nov 05, 2020 at 02:35:57PM -0800, Stephen Hemminger wrote: > > This patch renames the enum values in the EAL include files. > > As a backward compatible temporary migration tool, define > > a replacement mapping for old values. >

[dpdk-dev] [PATCH 21.02 v2] mem: don't warn about base addr if not requested

2020-11-09 Thread Anatoly Burakov
Any EAL memory allocation often goes through eal_get_virtual_area() function, which will print a warning whenever the resulting allocation didn't match the specified address requirements. This is useful for when we have requested a specific base virtual address, to let the user know that the mappin

Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build

2020-11-09 Thread Bruce Richardson
On Mon, Nov 09, 2020 at 04:28:16PM +0100, Thomas Monjalon wrote: > 09/11/2020 15:55, Ferruh Yigit: > > If the 'PKG_CONFIG_PATH' is set in the environment before script run, > > 32 bit still uses that value for 64-bits libraries. > > > > From the build log: > > > > " > > Using DPDK_TARGET i386-pc-

Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue completions on stop

2020-11-09 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Friday, November 6, 2020 6:58 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Alexander Kozyrev > ; Matan Azrad ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix Tx queue completions on stop > > The Tx queue completion produ

Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build

2020-11-09 Thread Thomas Monjalon
09/11/2020 15:55, Ferruh Yigit: > If the 'PKG_CONFIG_PATH' is set in the environment before script run, > 32 bit still uses that value for 64-bits libraries. > > From the build log: > > " > Using DPDK_TARGET i386-pc-linux-gnu > meson -Dexamples=l3fwd --buildtype=debugoptimized --werror > -Dc_arg

[dpdk-dev] [PATCH 21.02] mem: don't warn about base addr if not requested

2020-11-09 Thread Anatoly Burakov
Any EAL memory allocation often goes through eal_get_virtual_area() function, which will print a warning whenever the resulting allocation didn't match the specified address requirements. This is useful for when we have requested a specific base virtual address, to let the user know that the mappin

[dpdk-dev] [PATCH v2] devtools: fix 32-bits build

2020-11-09 Thread Ferruh Yigit
If the 'PKG_CONFIG_PATH' is set in the environment before script run, 32 bit still uses that value for 64-bits libraries. >From the build log: " Using DPDK_TARGET i386-pc-linux-gnu meson -Dexamples=l3fwd --buildtype=debugoptimized --werror -Dc_args=-m32 -Dc_link_args=-m32 /tmp/dpdk_maintain/self

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Jerin Jacob
On Mon, Nov 9, 2020 at 8:12 PM Thomas Monjalon wrote: > > 09/11/2020 15:08, Jerin Jacob: > > On Mon, Nov 9, 2020 at 7:32 PM Thomas Monjalon wrote: > > > 09/11/2020 14:35, Jerin Jacob: > > > > Are you facing the issue with 32bit? Could you share the steps to > > > > reproduce and gcc version? > >

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Thomas Monjalon
09/11/2020 15:08, Jerin Jacob: > On Mon, Nov 9, 2020 at 7:32 PM Thomas Monjalon wrote: > > 09/11/2020 14:35, Jerin Jacob: > > > Are you facing the issue with 32bit? Could you share the steps to > > > reproduce and gcc version? > > > > Oh you're right, the issue was with 32-bit build, > > Thanks >

Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx queues completion index consistency

2020-11-09 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Friday, November 6, 2020 7:16 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Alexander Kozyrev > ; Matan Azrad ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix Rx queues completion index consistency > > The Rx queue comple

[dpdk-dev] [PATCH V3 1/6] net/hns3: use correct logging format symbol

2020-11-09 Thread Lijun Ou
From: Hongbo Zheng In current driver print log function, some print format symbols does not match with the actual variable types. Signed-off-by: Hongbo Zheng Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_dcb.c | 10 +- drivers/net/hns3/hns3_ethdev.c| 32 -

[dpdk-dev] [PATCH V3 6/6] net/hns3: remove some unnecessary blank lines

2020-11-09 Thread Lijun Ou
According to the rule of the static check tools that arrange blank lines properly to keep the code compact, here remove some unncessary blank line to fix the above rule warning. Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_cmd.c| 1 - drivers/net/hns3/hns3_ethdev.c | 6 +- drivers

[dpdk-dev] [PATCH V3 5/6] net/hns3: fix queue enabling state not store after FLR

2020-11-09 Thread Lijun Ou
From: Chengchang Tang FLR operation will reset the queue enabling state and the driver needs to restore the state after reset. As a result, it will result in unpredictable behavior with reseted when user start or stop queue by calling the relatived function if the driver does not do this. This p

[dpdk-dev] [PATCH V3 3/6] net/hns3: adjust code style for initial struct

2020-11-09 Thread Lijun Ou
From: Hongbo Zheng According to the rule of the used static check tool, each member is initialized on a separate lines when struct and union members are initialized, here is tempting to adjust some code lines in order to remove the warning. Signed-off-by: Hongbo Zheng Signed-off-by: Lijun Ou -

[dpdk-dev] [PATCH V3 0/6] bugfix and cleanups for hns3

2020-11-09 Thread Lijun Ou
Here series include four coverity tool warnings fixes and a bug fixes. V2->V3: 1. fix some checkpatch warnings for patch[3] 2. split patch[3/6] into two independent patchse[3/6] and patch[6/6] according to Ferruh Yigit's advice 3. rewrite commit log for patch[5/5] 4. rewrite the patch title for

[dpdk-dev] [PATCH V3 2/6] net/hns3: use unsigned types for bit operator

2020-11-09 Thread Lijun Ou
From: Hongbo Zheng According to bit operator reliability style, variables in the right expression participating int bit operation must be an unsigned type. Signed-off-by: Hongbo Zheng Signed-off-by: Lijun Ou --- V2->V3: - fix commit log for correct descriptions - fix unnecessary variable decla

[dpdk-dev] [PATCH V3 4/6] net/hns3: check PCI config space writes

2020-11-09 Thread Lijun Ou
Here adds a check for the return value when calling rte_pci_write_config. Coverity issue: 363714 Fixes: cea37e513329 ("net/hns3: fix FLR reset") Cc: sta...@dpdk.org Signed-off-by: Lijun Ou --- V2->V3: - drop the un-related change V1->V2: - no fix --- drivers/net/hns3/hns3_ethdev_vf.c | 8 +

Re: [dpdk-dev] [PATCH v2 5/5] net/hns3: fix queue enabling status not store after FLR

2020-11-09 Thread oulijun
在 2020/11/7 0:57, Ferruh Yigit 写道: On 11/6/2020 3:51 AM, Lijun Ou wrote: From: Chengchang Tang The FLR will resets the queue enabling status. In the current code, the queue enabling status is not restored after the reset. Therefore, if upper layer users have called queue start/stop function

[dpdk-dev] [PATCH] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-09 Thread Michael Pfeiffer
Unlike TCP, UDP checksums are optional and may be zero to indicate "not set" [RFC 768] (except for IPv6, where this prohibited [RFC 8200]). Add this special case to the checksum offload emulation in net/tap. Signed-off-by: Michael Pfeiffer --- drivers/net/tap/rte_eth_tap.c | 13 +++-- 1

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Jerin Jacob
On Mon, Nov 9, 2020 at 7:32 PM Thomas Monjalon wrote: > > 09/11/2020 14:35, Jerin Jacob: > > On Mon, Nov 9, 2020 at 6:29 PM Thomas Monjalon wrote: > > > > > > 09/11/2020 13:01, Jerin Jacob: > > > > Hi @Thomas Monjalon > > > > > > > > Any specific reason why you removed the static assert from octe

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Thomas Monjalon
09/11/2020 14:35, Jerin Jacob: > On Mon, Nov 9, 2020 at 6:29 PM Thomas Monjalon wrote: > > > > 09/11/2020 13:01, Jerin Jacob: > > > Hi @Thomas Monjalon > > > > > > Any specific reason why you removed the static assert from octeontx2. > > > > I have a build failure when cross-compiling for octeontx

Re: [dpdk-dev] [PATCH] devtools: fix 32-bits build

2020-11-09 Thread Thomas Monjalon
09/11/2020 14:35, Bruce Richardson: > On Mon, Nov 09, 2020 at 01:24:28PM +, Ferruh Yigit wrote: > > On 11/9/2020 1:19 PM, Thomas Monjalon wrote: > > > 09/11/2020 14:00, Ferruh Yigit: > > > > 32 bit still uses the pkgconfig file for 64-bits libraries, from the > > > > build log: > > > > > > > >

Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum

2020-11-09 Thread Bruce Richardson
On Thu, Nov 05, 2020 at 02:35:57PM -0800, Stephen Hemminger wrote: > This patch renames the enum values in the EAL include files. > As a backward compatible temporary migration tool, define > a replacement mapping for old values. > > The old names relating to blacklist and whitelist are replaced >

Re: [dpdk-dev] [PATCH v2 4/5] net/hns3: check PCI config space writes

2020-11-09 Thread oulijun
在 2020/11/7 0:45, Ferruh Yigit 写道: On 11/6/2020 3:51 AM, Lijun Ou wrote: Here adds a check for the return value when calling rte_pci_write_config. Coverity issue: 363714 Fixes: cea37e513329 ("net/hns3: fix FLR reset") Cc: sta...@dpdk.org Signed-off-by: Lijun Ou --- V1->V2: - rte_pci_wirte_

[dpdk-dev] [PATCH v2] bus/dpaa: optimize device name parsing

2020-11-09 Thread Gaetan Rivet
Device name parsing is done on all buses during device iterations at either EAL or ethdev levels. When a bus implements device name parsing slowly, all iterations are impacted. Efficient implementation is important. The DPAA bus device name parsing has two issues: it allocates dynamic memory and

Re: [dpdk-dev] [PATCH] bus/dpaa: optimize device name parsing

2020-11-09 Thread Gaëtan Rivet
On 09/11/20 12:58 +0100, David Marchand wrote: > On Mon, Nov 9, 2020 at 12:32 PM Gaetan Rivet wrote: > > + delta = 0; > > + if (strncmp(name, "dpaa_bus:", 9) == 0) { > > + delta = 9; > > + } else if (strncmp(name, "name=", 5) == 0) { > > + delta = 5; >

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Jerin Jacob
On Mon, Nov 9, 2020 at 6:29 PM Thomas Monjalon wrote: > > 09/11/2020 13:01, Jerin Jacob: > > Hi @Thomas Monjalon > > > > Any specific reason why you removed the static assert from octeontx2. > > I have a build failure when cross-compiling for octeontx2. I am trying the below command, I am not abl

  1   2   >