27/10/2020 18:38, Bruce Richardson: > To test the installation process of DPDK using "ninja install" > test-meson-builds.sh builds a subset of the examples using "make". To allow > more flexibility for people testing, allow the set of examples chosen for > this make test to be overridden using variable "DPDK_BUILD_TEST_EXAMPLES" > in the environment. > > Since a number of example apps link against drivers directly even for > shared builds, we need to ensure that LD_LIBRARY_PATH points to the main > DPDK lib folder so any dependencies of those drivers can be found e.g. that > the PCI/vdev bus driver .so is found. [All drivers are symlinked from > drivers dir back to lib dir on install, so only one dir rather than two is > needed in the path.] [...] > +libdir=$(dirname $(find $DESTDIR -name librte_eal.so)) > +export LD_LIBRARY_PATH=$libdir:$LD_LIBRARY_PATH
I don't get why libdir is required for some examples, and not for others? The pkg-config file is not enough? > +examples_to_test=${DPDK_BUILD_TEST_EXAMPLES:-"cmdline helloworld l2fwd l3fwd > skeleton timer"} It makes me think that we should rename TEST_MESON_BUILD_VERY_VERBOSE to DPDK_BUILD_TEST_VERY_VERBOSE for consistency.