[dpdk-dev] [PATCH v3] net/mlx5: fix incorrect group value of sample suffix flow

2020-10-31 Thread Jiawei Wang
mlx5 PMD splited the sampling flow into prefix flow and suffix flow. On the sample action translation function, the scaled group value of suffix flow be attached into sample object and saved into sample resource. mlx5 PMD fetched the group value from the sample resource to create the suffix flow.

Re: [dpdk-dev] [PATCH v6 00/15] remove mbuf userdata

2020-10-31 Thread Ferruh Yigit
On 10/31/2020 3:07 PM, Thomas Monjalon wrote: 30/10/2020 18:44, Thomas Monjalon: The mbuf field userdata (aliased as udata64) was announced to be removed for two reasons: - applications, libraries and drivers used the same field for different purposes, with a risk of usage conflict. -

Re: [dpdk-dev] [PATCH v14 00/23] Add DLB PMD

2020-10-31 Thread McDaniel, Timothy
> -Original Message- > From: David Marchand > Sent: Saturday, October 31, 2020 5:16 PM > To: McDaniel, Timothy > Cc: dev ; Carrillo, Erik G ; Eads, > Gage ; Van Haaren, Harry > ; Jerin Jacob Kollanukkaran > ; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH v14 00/23] Add DLB PMD > >

Re: [dpdk-dev] [PATCH v14 00/23] Add DLB PMD

2020-10-31 Thread David Marchand
On Sat, Oct 31, 2020 at 7:16 PM Timothy McDaniel wrote: > > The following patch series adds support for a new eventdev PMD. The DLB > PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. > The DLB is a PCIe device that provides load-balanced, prioritized > scheduling of core-to-cor

Re: [dpdk-dev] [PATCH v14 21/23] event/dlb: add PMD self-tests

2020-10-31 Thread David Marchand
On Sat, Oct 31, 2020 at 7:24 PM Timothy McDaniel wrote: > +static inline int > +create_ports(int num_ports) > +{ > + int i; > + > + if (num_ports > MAX_PORTS) > + return -1; > + > + for (i = 0; i < num_ports; i++) { > + struct rte_event_port_conf conf;

Re: [dpdk-dev] [PATCH v14 20/23] event/dlb: add PMD's token pop public interface

2020-10-31 Thread David Marchand
On Sat, Oct 31, 2020 at 7:23 PM Timothy McDaniel wrote: > > The PMD uses a public interface to allow applications to > control the token pop mode. Supported token pop modes are > as follows, and they impact core scheduling affinity for > ldb ports. > > AUTO_POP: Pop the CQ tokens immediately after

Re: [dpdk-dev] [PATCH v14 13/23] event/dlb: add port setup

2020-10-31 Thread David Marchand
On Sat, Oct 31, 2020 at 7:20 PM Timothy McDaniel wrote: > > Configure the load balanced (ldb) or directed (dir) port. > The consumer queue (CQ) and producer port (PP) are also > set up here. > > Signed-off-by: Timothy McDaniel > --- > doc/guides/eventdevs/dlb.rst | 40 + > drivers/

Re: [dpdk-dev] [PATCH v14 12/23] event/dlb: add queue setup

2020-10-31 Thread David Marchand
On Sat, Oct 31, 2020 at 7:20 PM Timothy McDaniel wrote: > + if (i == DLB_NUM_SN_GROUPS) { > + printf("[%s()] No groups with %d sequence_numbers are > available or have free slots\n", > + __func__, sequence_numbers); No printf in a driver. > +

Re: [dpdk-dev] [PATCH v14 09/23] event/dlb: add xstats

2020-10-31 Thread David Marchand
On Sat, Oct 31, 2020 at 7:21 PM Timothy McDaniel wrote: > +void > +dlb_eventdev_dump(struct rte_eventdev *dev, FILE *f) > +{ > + struct dlb_eventdev *dlb; > + struct dlb_hw_dev *handle; > + int i; > + > + if (f == NULL) { > + printf("Invalid file pointer\n");

Re: [dpdk-dev] [PATCH v14 05/23] event/dlb: add inline functions

2020-10-31 Thread David Marchand
On Sat, Oct 31, 2020 at 7:17 PM Timothy McDaniel wrote: > > Add miscellaneous inline functions that may be called > from multiple files. These functions include inline > assembly of new x86 instructions, such as movdir64b, > since they are not available as builtin functions in > the minimum suppo

Re: [dpdk-dev] [PATCH v14 01/23] event/dlb: add documentation and meson infrastructure

2020-10-31 Thread David Marchand
On Sat, Oct 31, 2020 at 7:16 PM Timothy McDaniel wrote: > > Note that config/rte_config.h contains several configuration > switches, providing for fine control of the PMD's > runtime behaviour. > > The meson infrastructure is expanded as additional files are > added to this patchset. > > Adds anno

Re: [dpdk-dev] [PATCH v8 20/23] event/dlb2: add PMD's token pop public interface

2020-10-31 Thread McDaniel, Timothy
> -Original Message- > From: David Marchand > Sent: Saturday, October 31, 2020 4:39 PM > To: McDaniel, Timothy > Cc: Ray Kinsella ; Neil Horman ; > dev ; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > Jerin Jacob Kollanukkaran ; Thomas Monjalon > > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v8 20/23] event/dlb2: add PMD's token pop public interface

2020-10-31 Thread David Marchand
On Sat, Oct 31, 2020 at 8:19 PM McDaniel, Timothy wrote: > I have made the requested changes to doc/api/doxy-api-index.md in DLB and > DLB2 repos, but I still see this error: > /home/travis/build/ovsrobot/dpdk/doc/api/doxy-api-index.md:54: error: unable > to resolve reference to `rte_pmd_dlb.h'

Re: [dpdk-dev] [PATCH v2 0/9] remove mbuf seqn

2020-10-31 Thread Thomas Monjalon
28/10/2020 13:20, David Marchand: > Followup on the work started by Thomas to free some space in the mbuf > structure. > This series applies on top of Thomas v4 series [1] and drops the seqn > field that had been deprecated. Thanks for the follow-up. Applied, thanks. Next step: removing timestam

Re: [dpdk-dev] [PATCH v2 9/9] mbuf: remove seqn field

2020-10-31 Thread Thomas Monjalon
28/10/2020 13:20, David Marchand: > As announced in the deprecation note, the field seqn is removed to give > more space to the dynamic fields. > > This is how the mbuf layout looks like (pahole-style): > > word type namebyte size > 0void *

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotterfirst half

2020-10-31 Thread Thomas Monjalon
Thanks for the thoughts Morten. I believe we need benchmarks of different scenarios with different drivers. 31/10/2020 19:20, Morten Brørup: > Thomas, > > Adding my thoughts to the already detailed feedback on this important patch... > > The first cache line is not inherently "hotter" than the

Re: [dpdk-dev] [PATCH v8 20/23] event/dlb2: add PMD's token pop public interface

2020-10-31 Thread McDaniel, Timothy
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 31, 2020 11:38 AM > To: David Marchand > Cc: Ray Kinsella ; Neil Horman ; > dev ; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > Jerin Jacob Kollanukkaran ; Thomas Monjalon > > Subject: RE: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v2 1/9] event/dpaa2: remove dead code

2020-10-31 Thread Nipun Gupta
Acked-by: Nipun Gupta > -Original Message- > From: David Marchand > Sent: Wednesday, October 28, 2020 5:50 PM > To: dev@dpdk.org > Cc: Hemant Agrawal ; Nipun Gupta > > Subject: [PATCH v2 1/9] event/dpaa2: remove dead code > > This code has never been used since introduction. > > Fixes

Re: [dpdk-dev] [PATCH v10 06/23] event/dlb: add eventdev probe

2020-10-31 Thread McDaniel, Timothy
> -Original Message- > From: Eads, Gage > Sent: Friday, October 30, 2020 2:51 PM > To: McDaniel, Timothy ; Burakov, Anatoly > > Cc: dev@dpdk.org; Carrillo, Erik G ; Van Haaren, > Harry ; jer...@marvell.com; > tho...@monjalon.net > Subject: RE: [PATCH v10 06/23] event/dlb: add eventdev p

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotterfirst half

2020-10-31 Thread Morten Brørup
Thomas, Adding my thoughts to the already detailed feedback on this important patch... The first cache line is not inherently "hotter" than the second. The hotness depends on their usage. The mbuf cacheline1 marker has the following comment: /* second cache line - fields only used in slow path

Re: [dpdk-dev] [PATCH v10 13/23] event/dlb: add port setup

2020-10-31 Thread McDaniel, Timothy
> -Original Message- > From: Eads, Gage > Sent: Friday, October 30, 2020 2:51 PM > To: McDaniel, Timothy > Cc: dev@dpdk.org; Carrillo, Erik G ; Van Haaren, > Harry ; jer...@marvell.com; > tho...@monjalon.net > Subject: RE: [PATCH v10 13/23] event/dlb: add port setup > > > > > -O

Re: [dpdk-dev] [PATCH v13 00/23] Add DLB PMD

2020-10-31 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Saturday, October 31, 2020 7:50 AM > To: McDaniel, Timothy > Cc: dpdk-dev ; Carrillo, Erik G ; > Eads, Gage ; Van Haaren, Harry > ; Jerin Jacob ; Thomas > Monjalon > Subject: Re: [dpdk-dev] [PATCH v13 00/23] Add DLB PMD > > On Sat, Oct

[dpdk-dev] [PATCH v14 23/23] event/dlb: add timeout ticks entry point

2020-10-31 Thread Timothy McDaniel
Adds the timeout ticks conversion function. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 713b1e6..0f688bf 100644 --- a/drivers/event/d

Re: [dpdk-dev] [PATCH 3/3 v4] app/testpmd: support hardware offload to drop error packets

2020-10-31 Thread Nipun Gupta
> -Original Message- > From: Dharmik Thakkar > Sent: Thursday, October 29, 2020 10:52 PM > To: Nipun Gupta > Cc: dev ; tho...@monjalon.net; Ferruh Yigit > ; arybche...@solarflare.com; Hemant Agrawal > ; Sachin Saxena ; Rohit > Raj ; Jerin Jacob ; Stephen > Hemminger ; as...@nvidia.com;

[dpdk-dev] [PATCH v14 21/23] event/dlb: add PMD self-tests

2020-10-31 Thread Timothy McDaniel
Add a variety of self-tests for both ldb and directed ports/queues, as well as configure, start, stop, link, etc... Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- app/test/test_eventdev.c |7 + drivers/event/dlb/dlb.c |1 + drivers/event/dlb/dlb_selftest.c |

[dpdk-dev] [PATCH v14 22/23] event/dlb: add queue and port release

2020-10-31 Thread Timothy McDaniel
These entry points are NO-OPS. DLB does not support reconfiguring individual queues or ports. The entire device must be reconfigured. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/event/dlb/dlb

[dpdk-dev] [PATCH v14 20/23] event/dlb: add PMD's token pop public interface

2020-10-31 Thread Timothy McDaniel
The PMD uses a public interface to allow applications to control the token pop mode. Supported token pop modes are as follows, and they impact core scheduling affinity for ldb ports. AUTO_POP: Pop the CQ tokens immediately after dequeueing. DELAYED_POP: Pop CQ tokens after (dequeue_depth - 1) even

[dpdk-dev] [PATCH v14 19/23] event/dlb: add eventdev stop and close

2020-10-31 Thread Timothy McDaniel
Add support for eventdev stop and close entry points. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb.c | 256 +-- drivers/event/dlb/dlb_iface.c| 6 + drivers/event/dlb/dlb_iface.h| 6 + dr

[dpdk-dev] [PATCH v14 17/23] event/dlb: add enqueue and its burst variants

2020-10-31 Thread Timothy McDaniel
Add support for enqueue and its variants. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- doc/guides/eventdevs/dlb.rst | 163 - drivers/event/dlb/dlb.c | 567 +++ 2 files changed, 729 insertions(+), 1 deletion(-) diff --git a/

[dpdk-dev] [PATCH v14 18/23] event/dlb: add dequeue and its burst variants

2020-10-31 Thread Timothy McDaniel
Add support for dequeue, dequeue_burst, ... DLB does not currently support interrupts, but instead uses umonitor/umwait if supported by the processor. This allows the software to monitor and wait on writes to a cache-line. DLB supports normal and sparse cq mode. In normal mode the hardware will p

[dpdk-dev] [PATCH v14 16/23] event/dlb: add eventdev start

2020-10-31 Thread Timothy McDaniel
Add support for the eventdev start entry point. DLB delays setting up single link resources until eventdev start, because it is only then that it can ascertain which ports have just one linked queue. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb.c

[dpdk-dev] [PATCH v14 14/23] event/dlb: add port link

2020-10-31 Thread Timothy McDaniel
Add port link entry point. Directed queues are identified and created at this stage. Their setup deferred until link-time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-b

[dpdk-dev] [PATCH v14 15/23] event/dlb: add port unlink and port unlinks in progress

2020-10-31 Thread Timothy McDaniel
Add supports for the port unlink(s) eventdev entry points. The unlink operation is an asynchronous operation executed by a control thread, and the unlinks-in-progress function reads a counter shared with the control thread. Port QE and memzone memory is freed here. Signed-off-by: Timothy McDaniel

[dpdk-dev] [PATCH v14 13/23] event/dlb: add port setup

2020-10-31 Thread Timothy McDaniel
Configure the load balanced (ldb) or directed (dir) port. The consumer queue (CQ) and producer port (PP) are also set up here. Signed-off-by: Timothy McDaniel --- doc/guides/eventdevs/dlb.rst | 40 + drivers/event/dlb/dlb.c | 516 ++- drivers/event/dlb/dlb

[dpdk-dev] [PATCH v14 09/23] event/dlb: add xstats

2020-10-31 Thread Timothy McDaniel
Add support for DLB xstats. Perform initialization and add standard xstats entry points Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb.c| 23 + drivers/event/dlb/dlb_xstats.c | 1222 drivers/event/dlb/meson.bu

[dpdk-dev] [PATCH v14 10/23] event/dlb: add infos get and configure

2020-10-31 Thread Timothy McDaniel
Add support for configuring the DLB hardware. In particular, this patch configures the DLB hardware's scheduling domain, such that it is provisioned with the requested number of ports and queues, provided sufficient resources are available. Individual queues and ports are configured later in port s

[dpdk-dev] [PATCH v14 12/23] event/dlb: add queue setup

2020-10-31 Thread Timothy McDaniel
Load balanced (ldb) queues are setup here. Directed queues are not set up until link time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-by: Timothy McDaniel Reviewed-by

[dpdk-dev] [PATCH v14 11/23] event/dlb: add queue and port default conf

2020-10-31 Thread Timothy McDaniel
Add support for getting the queue and port default configuration. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index c038794

[dpdk-dev] [PATCH v14 08/23] event/dlb: add probe-time hardware init

2020-10-31 Thread Timothy McDaniel
This commit adds probe-time low level hardware initialization. It also adds probe-time init for both primary and secondary DPDK processes. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 158 +++- drivers/event/dlb/meson.build| 3 +- driv

[dpdk-dev] [PATCH v14 07/23] event/dlb: add flexible interface

2020-10-31 Thread Timothy McDaniel
This commit introduces the flexible interface. This interface allows the core code to operate in PF mode (direct hardware access) or bifurcated mode (hardware configured via kernel driver). This driver currently only supports PF modei, but bifurcated mode will be added in a future patch-set. Note t

[dpdk-dev] [PATCH v14 06/23] event/dlb: add eventdev probe

2020-10-31 Thread Timothy McDaniel
Add the eventdev portion of probe, and parse command line options, but do not initialize hardware. Changes since v5 patch-set probe: Primary and secondary probe-time init has been removed, and will be introduced in subsequent patches contained in this patch-set. Hardware init has been moved to a

[dpdk-dev] [PATCH v14 04/23] event/dlb: add definitions shared with LKM or shared code

2020-10-31 Thread Timothy McDaniel
Add headers containing structs and constants shared between the PMD and the shared code. The term shared code refers to the code that implements the hardware interface. The shared code is introduced in the probe patch, and then is extended as additional eventdev PMD entry points are added to the p

[dpdk-dev] [PATCH v14 05/23] event/dlb: add inline functions

2020-10-31 Thread Timothy McDaniel
Add miscellaneous inline functions that may be called from multiple files. These functions include inline assembly of new x86 instructions, such as movdir64b, since they are not available as builtin functions in the minimum supported GCC version. Signed-off-by: Timothy McDaniel Reviewed-by: Gage

[dpdk-dev] [PATCH v14 03/23] event/dlb: add private data structures and constants

2020-10-31 Thread Timothy McDaniel
Add headers used internally by the PMD. They include constants, macros for device resources, structure definitions for hardware interfaces and software state, and various forward-declarations. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb_priv.h | 508 +++

[dpdk-dev] [PATCH v14 00/23] Add DLB PMD

2020-10-31 Thread Timothy McDaniel
The following patch series adds support for a new eventdev PMD. The DLB PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. The DLB is a PCIe device that provides load-balanced, prioritized scheduling of core-to-core communication. The device consists of queues and arbiters that co

[dpdk-dev] [PATCH v14 02/23] event/dlb: add dynamic logging

2020-10-31 Thread Timothy McDaniel
This commit adds base support for dynamic logging. The default log level is NOTICE. Dynamic logging is used exclusively throughout this patchset. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb.c | 7 +++ drivers/event/dlb/dlb_log.h | 25 +++

[dpdk-dev] [PATCH v14 01/23] event/dlb: add documentation and meson infrastructure

2020-10-31 Thread Timothy McDaniel
Note that config/rte_config.h contains several configuration switches, providing for fine control of the PMD's runtime behaviour. The meson infrastructure is expanded as additional files are added to this patchset. Adds announcement of availabililty of the new driver for Intel Dynamic Load Balanc

[dpdk-dev] [PATCH v9 23/23] event/dlb2: add timeout ticks entry point

2020-10-31 Thread Timothy McDaniel
Adds the timeout ticks conversion function. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index d9b13a1..d12cbf7 100644 --- a/drivers/e

[dpdk-dev] [PATCH v9 21/23] event/dlb2: add PMD self-tests

2020-10-31 Thread Timothy McDaniel
Add a variety of self-tests for both ldb and directed ports/queues, as well as configure, start, stop, link, etc... Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- app/test/test_eventdev.c |7 + drivers/event/dlb2/dlb2.c |1 + drivers/event/dlb2/dlb2_selfte

[dpdk-dev] [PATCH v9 20/23] event/dlb2: add PMD's token pop public interface

2020-10-31 Thread Timothy McDaniel
The PMD uses a public interface to allow applications to control the token pop mode. Supported token pop modes are as follows, and they impact core scheduling affinity for ldb ports. AUTO_POP: Pop the CQ tokens immediately after dequeueing. DELAYED_POP: Pop CQ tokens after (dequeue_depth - 1) even

[dpdk-dev] [PATCH v9 22/23] event/dlb2: add queue and port release

2020-10-31 Thread Timothy McDaniel
DLB does not support reconfiguring individual queues or ports on the fly. The entire device must be reconfigured. Previously allocated port QE and memzone memory is freed in this patch. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 24 +++

[dpdk-dev] [PATCH v9 19/23] event/dlb2: add eventdev stop and close

2020-10-31 Thread Timothy McDaniel
Add support for eventdev stop and close entry points. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 257 +++-- drivers/event/dlb2/dlb2_iface.c| 6 + drivers/event/dlb2/dlb2_iface.h| 6 +

[dpdk-dev] [PATCH v9 18/23] event/dlb2: add dequeue and its burst variants

2020-10-31 Thread Timothy McDaniel
Add support for dequeue, dequeue_burst, ... DLB2 does not currently support interrupts, but instead use umonitor/umwait if supported by the processor. This allows the software to monitor and wait on writes to a cache-line. DLB2 supports normal and sparse cq mode. In normal mode the hardware will

[dpdk-dev] [PATCH v9 16/23] event/dlb2: add eventdev start

2020-10-31 Thread Timothy McDaniel
Add support for the eventdev start entry point. We delay initializing some resources until eventdev start, since the number of linked queues can be used to determine if we are dealing with a ldb or dir resource. If this is a device restart, then the previous configuration will be reapplied. Signed

[dpdk-dev] [PATCH v9 14/23] event/dlb2: add port link

2020-10-31 Thread Timothy McDaniel
Add port link entry point. Directed queues are identified and created at this stage. Their setup deferred until link-time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-b

[dpdk-dev] [PATCH v9 17/23] event/dlb2: add enqueue and its burst variants

2020-10-31 Thread Timothy McDaniel
Add support for enqueue and its variants. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- doc/guides/eventdevs/dlb2.rst | 118 + drivers/event/dlb2/dlb2.c | 540 ++ 2 files changed, 658 insertions(+) diff --git a/doc/guides/eventde

[dpdk-dev] [PATCH v9 15/23] event/dlb2: add port unlink and port unlinks in progress

2020-10-31 Thread Timothy McDaniel
Add supports for the port unlink(s) eventdev entry points. The unlink operation is an asynchronous operation executed by a control thread, and the unlinks-in-progress function reads a counter shared with the control thread. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/even

[dpdk-dev] [PATCH v9 13/23] event/dlb2: add port setup

2020-10-31 Thread Timothy McDaniel
Configure the load balanced (ldb) or directed (dir) port. The consumer queue (CQ) and producer port (PP) are also set up here. Signed-off-by: Timothy McDaniel --- doc/guides/eventdevs/dlb2.rst | 75 +++ drivers/event/dlb2/dlb2.c | 498 drivers/even

[dpdk-dev] [PATCH v9 12/23] event/dlb2: add queue setup

2020-10-31 Thread Timothy McDaniel
Load balanced (ldb) queues are setup here. Directed queues are not set up until link time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-by: Timothy McDaniel Reviewed-by

[dpdk-dev] [PATCH v9 10/23] event/dlb2: add infos get and configure

2020-10-31 Thread Timothy McDaniel
Add support for configuring the DLB2 hardware. In particular, this patch configures the DLB2 hardware's scheduling domain, such that it is provisioned with the requested number of ports and queues, provided sufficient resources are available. Individual queues and ports are configured later in port

[dpdk-dev] [PATCH v9 11/23] event/dlb2: add queue and port default conf

2020-10-31 Thread Timothy McDaniel
Add support for getting the queue and port default configuration. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index

[dpdk-dev] [PATCH v9 08/23] event/dlb2: add probe-time hardware init

2020-10-31 Thread Timothy McDaniel
This commit adds probe-time low level hardware initialization. It also adds probe-time init for both primary and secondary DPDK processes. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 188 +++- drivers/event/dlb2/meson.build | 3

[dpdk-dev] [PATCH v9 09/23] event/dlb2: add xstats

2020-10-31 Thread Timothy McDaniel
Add support for DLB2 xstats. Perform initialization and add standard xstats entry points. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads Reviewed-by: Chen, Mike Ximing --- drivers/event/dlb2/dlb2.c| 35 +- drivers/event/dlb2/dlb2_xstats.c | 1240 +

[dpdk-dev] [PATCH v9 07/23] event/dlb2: add flexible interface

2020-10-31 Thread Timothy McDaniel
This commit introduces the flexible interface. This interface allows the core code to operate in PF mode (direct hardware access) or bifurcated mode (hardware configured via kernel driver). This driver currently only supports PF mode but bifurcated mode will be added in a future DPDK patch-set. Not

[dpdk-dev] [PATCH v9 04/23] event/dlb2: add definitions shared with LKM or shared code

2020-10-31 Thread Timothy McDaniel
Add headers containing structs and constants shared between the PMD and the shared code. The term shared code refers to the code that implements the hardware interface. The shared code is introduced in the probe patch, and then is extended as additional eventdev PMD entry points are added to the p

[dpdk-dev] [PATCH v9 03/23] event/dlb2: add private data structures and constants

2020-10-31 Thread Timothy McDaniel
The header file dlb2_priv.h is used internally by the PMD. It include constants, macros for device resources, structure definitions for hardware interfaces and software state, and various forward-declarations. The header file rte_pmd_dlb2.h will be exported in a subsequent patch, but is included he

[dpdk-dev] [PATCH v9 05/23] event/dlb2: add inline functions

2020-10-31 Thread Timothy McDaniel
Add miscellaneous inline functions that may be called from multiple files. These functions include inline assembly of new x86 instructions, such as movdir64b, since they are not available as builtin functions in the minimum supported GCC version. Signed-off-by: Timothy McDaniel Reviewed-by: Gage

[dpdk-dev] [PATCH v9 01/23] event/dlb2: add documentation and meson build infrastructure

2020-10-31 Thread Timothy McDaniel
Adds the meson build infrastructure, which includes compile-time constants in rte_config.h. DLB2 is only supported on Linux 64 bit X86 platforms at this time. Adds announcement of availabililty for the new driver for Intel Dynamic Load Balancer 2.0 hardware. Signed-off-by: Timothy McDaniel Revie

[dpdk-dev] [PATCH v9 02/23] event/dlb2: add dynamic logging

2020-10-31 Thread Timothy McDaniel
This commit adds base support for dynamic logging. The default log level is NOTICE. Dynamic logging is used exclusively throughout this patchset. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 7 +++ drivers/event/dlb2/dlb2_log.h | 25 +

[dpdk-dev] [PATCH v9 00/23] Add DLB2 PMD

2020-10-31 Thread Timothy McDaniel
The following patch series adds support for a new eventdev PMD. The DLB2 PMD adds support for the Intel Dynamic Load Balancer 2.0 (DLB2) hardware. The DLB2 is a PCIe device that provides load-balanced, prioritized scheduling of core-to-core communication. The device consists of queues and arbiters

Re: [dpdk-dev] [PATCH v8 17/23] event/dlb2: add enqueue and its burst variants

2020-10-31 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Saturday, October 31, 2020 4:52 AM > To: McDaniel, Timothy > Cc: dpdk-dev ; Carrillo, Erik G ; > Eads, Gage ; Van Haaren, Harry > ; Jerin Jacob ; Thomas > Monjalon > Subject: Re: [dpdk-dev] [PATCH v8 17/23] event/dlb2: add enqueue and it

Re: [dpdk-dev] [PATCH v2] examples/fips_validation: fix resource leak on failure

2020-10-31 Thread David Marchand
On Fri, Oct 30, 2020 at 6:36 PM Ciara Power wrote: > > The wb_data variable went out of scope on failure in the > get_writeback_data function. This is now freed before returning -1. > > Coverity issue: 363453 > Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list") > > Signe

Re: [dpdk-dev] [PATCH v2] examples/fips_validation: fix checking return value

2020-10-31 Thread David Marchand
On Fri, Oct 30, 2020 at 4:37 PM Ciara Power wrote: > > The return value was not being checked when calling the > get_writeback_data function in the AES test case. On failure, this led > to a NULL dereference when using memcpy later. The return value is now > checked to avoid this NULL dereference.

Re: [dpdk-dev] [PATCH v8 20/23] event/dlb2: add PMD's token pop public interface

2020-10-31 Thread McDaniel, Timothy
> -Original Message- > From: David Marchand > Sent: Saturday, October 31, 2020 5:52 AM > To: McDaniel, Timothy > Cc: Ray Kinsella ; Neil Horman ; > dev ; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > Jerin Jacob Kollanukkaran ; Thomas Monjalon > > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v6 00/15] remove mbuf userdata

2020-10-31 Thread Thomas Monjalon
30/10/2020 18:44, Thomas Monjalon: > The mbuf field userdata (aliased as udata64) > was announced to be removed for two reasons: > - applications, libraries and drivers used the same field > for different purposes, with a risk of usage conflict. > - this field always used 8 bytes even if un

Re: [dpdk-dev] [PATCH] test/mbuf: skip field registration at busy offset

2020-10-31 Thread Thomas Monjalon
31/10/2020 15:57, David Marchand: > On Sat, Oct 31, 2020 at 3:37 PM Thomas Monjalon wrote: > > > > There is a test for dynamic field registration at a specific offset. > > Depending on which driver is probed, some dynamic fields may be > > already registered at this offset. > > This failure is ski

Re: [dpdk-dev] [PATCH] test/mbuf: skip field registration at busy offset

2020-10-31 Thread David Marchand
On Sat, Oct 31, 2020 at 3:37 PM Thomas Monjalon wrote: > > There is a test for dynamic field registration at a specific offset. > Depending on which driver is probed, some dynamic fields may be > already registered at this offset. > This failure is skipped with a warning. > > Fixes: 4958ca3a443a (

Re: [dpdk-dev] [PATCH v6 05/15] security: switch metadata to dynamic mbuf field

2020-10-31 Thread Thomas Monjalon
31/10/2020 09:56, David Marchand: > On Fri, Oct 30, 2020 at 6:45 PM Thomas Monjalon wrote: > > > > The device-specific metadata was stored in the deprecated field udata64. > > It is moved to a dynamic mbuf field in order to allow removal of udata64. > > > > The name rte_security_dynfield is not ve

[dpdk-dev] [PATCH] test/mbuf: skip field registration at busy offset

2020-10-31 Thread Thomas Monjalon
There is a test for dynamic field registration at a specific offset. Depending on which driver is probed, some dynamic fields may be already registered at this offset. This failure is skipped with a warning. Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") Cc: sta...@dpdk.org Report

Re: [dpdk-dev] [PATCH v2] net/octeontx2: avoid per-pkt barrier with multi seg

2020-10-31 Thread Jerin Jacob
On Wed, Oct 28, 2020 at 5:17 PM Nithin Dabilpuram wrote: > > Avoid per-pkt barrier with multi-seg with fast free > and remove mbuf update to NULL. > > Fixes: ce8628c66a22 ("net/octeontx2: fix jumbo frame crash") > Cc: hka...@marvell.com > Cc: sta...@dpdk.org > > Signed-off-by: Nithin Dabilpuram >

Re: [dpdk-dev] [PATCH] net/octeontx2: support for VF base steering rule

2020-10-31 Thread Jerin Jacob
On Wed, Oct 21, 2020 at 9:01 AM wrote: > > From: Satheesh Paul > > Adds support for merging a base steering rule with > all flow rules created on a VF. > > Signed-off-by: Satheesh Paul Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-main. Thanks > --- > drivers/net/octeontx2/otx2_flo

Re: [dpdk-dev] [PATCH] net/thunderx: fix memory leak when allocate rbdr desc ring fails

2020-10-31 Thread Jerin Jacob
On Tue, Oct 20, 2020 at 8:33 PM wangyunjian wrote: > > From: Yunjian Wang > > In nicvf_qset_rbdr_alloc(), we allocate memory for the 'rbdr' > structure but not released when allocate 'rbdr desc ring' fails. > > Fixes: 7413feee662d ("net/thunderx: add device start/stop and close") > Cc: sta...@dpd

Re: [dpdk-dev] [PATCH v13 00/23] Add DLB PMD

2020-10-31 Thread Jerin Jacob
On Sat, Oct 31, 2020 at 7:41 AM Timothy McDaniel wrote: > > The following patch series adds support for a new eventdev PMD. The DLB > PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. > The DLB is a PCIe device that provides load-balanced, prioritized > scheduling of core-to-cor

Re: [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255

2020-10-31 Thread Jerin Jacob
On Sat, Oct 31, 2020 at 1:34 AM Eads, Gage wrote: > > > > > -Original Message- > > From: McDaniel, Timothy > > Sent: Monday, October 26, 2020 11:01 AM > > To: Richardson, Bruce > > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > > ; Van Haaren, Harry ; > > jer...@marvell.com > > Subjec

Re: [dpdk-dev] [PATCH v8 20/23] event/dlb2: add PMD's token pop public interface

2020-10-31 Thread David Marchand
On Sat, Oct 31, 2020 at 3:07 AM Timothy McDaniel wrote: > diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md > index a9c12d1..00f13e2 100644 > --- a/doc/api/doxy-api-index.md > +++ b/doc/api/doxy-api-index.md > @@ -52,6 +52,7 @@ The public API headers are grouped by topics: >[d

[dpdk-dev] [v4]net/hinic: fix coredump when the scondary process using the hinic port.

2020-10-31 Thread Qingqing Li
fix coredump when secondary process using the hinic port. the reason is that during the stage of secondary process port initialization, it lack the initialization of "eth_dev->dev_ops". --- v4: adapt to the latest version. --- v3: update the signed-off information. --- v2: solve the coding s

[dpdk-dev] [v4]net/hinic: fix coredump when the scondary process using the hinic port.

2020-10-31 Thread Qingqing Li
fix coredump when secondary process using the hinic port. the reason is that during the stage of secondary process port initialization, it lack the initialization of "eth_dev->dev_ops". Signed-off-by: Qingqing Li --- v4: adapt to the latest version. --- v3: update the signed-off information. -

[dpdk-dev] [v4]net/hinic: fix coredump when the scondary process using the hinic port.

2020-10-31 Thread Qingqing Li
From adb560f53b1a1585dc32adfb0e44e404e1198c96 Mon Sep 17 00:00:00 2001 From: liqingqing Date: Sat, 31 Oct 2020 06:02:57 -0400 Subject: [v4] net/hinic: fix coredump when the scondary process using the hinic port. fix coredump when secondary process using the hinic port. the reason is that duri

Re: [dpdk-dev] [PATCH V2 1/2] net/netvsc: allow setting rx and tx copy break

2020-10-31 Thread Long Li
> Subject: Re: [dpdk-dev] [PATCH V2 1/2] net/netvsc: allow setting rx and tx > copy break > > On 10/23/2020 10:54 PM, Long Li wrote: > > From: Stephen Hemminger > > > > The values for Rx and Tx copy break should be tunable rather than hard > > coded constants. > > > > The rx_copybreak sets the th

Re: [dpdk-dev] [PATCH v8 17/23] event/dlb2: add enqueue and its burst variants

2020-10-31 Thread Jerin Jacob
On Sat, Oct 31, 2020 at 7:36 AM Timothy McDaniel wrote: > > Add support for enqueue and its variants. > > Signed-off-by: Timothy McDaniel > Reviewed-by: Gage Eads > --- > doc/guides/eventdevs/dlb2.rst | 118 + > drivers/event/dlb2/dlb2.c | 578 >

[dpdk-dev] [v3]net/hinic: fix coredump when the scondary process using the hinic port.

2020-10-31 Thread Qingqing Li
fix coredump when secondary process using the hinic port. the reason is that during the stage of secondary process port initialization, it lack the initialization of "eth_dev->dev_ops". Signed-off-by: Qingqing Li --- v3: update the signed-off information. --- v2: solve the coding style issue. -

Re: [dpdk-dev] [PATCH v6 05/15] security: switch metadata to dynamic mbuf field

2020-10-31 Thread David Marchand
On Sat, Oct 31, 2020 at 9:56 AM David Marchand wrote: > A lazy fix is to simply ask for registering a field at offset > sizeof(dynfield) - 1 .. what do you think? I meant sizeof(struct rte_mbuf) - 1. -- David Marchand

Re: [dpdk-dev] [PATCH v6 05/15] security: switch metadata to dynamic mbuf field

2020-10-31 Thread David Marchand
On Fri, Oct 30, 2020 at 6:45 PM Thomas Monjalon wrote: > > The device-specific metadata was stored in the deprecated field udata64. > It is moved to a dynamic mbuf field in order to allow removal of udata64. > > The name rte_security_dynfield is not very descriptive > but it should be replaced lat

Re: [dpdk-dev] [PATCH v2] windows: minor build fixes

2020-10-31 Thread Nick Connolly
Missing / incorrect '--in-reply-to'. Please ignore - still learning the process! On 31/10/2020 06:43, Nick Connolly wrote: Meson versions >= 0.54.0 include support for handling /implib with msvc link. Specifying it explicitly causes failures when linking against the dll. Tested using Link 14.27