[dpdk-dev] [PATCH] net/octeontx2: fix rss flow create

From: Kiran Kumar K While creating flow with action type RSS, action type is not being set to RSS, and action type is being set to unicast. Therefore it breaks RSS functionality. This patch add changes to program the RSS action properly. Fixes: 4092e4845d ("net/octeontx2: add flow operations")

[dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

From: Yi Yang rte_gso_segment decreased refcnt of pkt by one, but it is wrong if pkt is external mbuf, pkt won't be freed because of incorrect refcnt, the result is application can't allocate mbuf from mempool because mbufs in mempool are run out of. One correct way is application should call rt

Re: [dpdk-dev] [PATCH v4] RSS key use with testpmd

Ferruh Yigit wrote: > Sent: Saturday, October 10, 2020 2:53 AM > To: oulijun ; wenzhuo...@intel.com; > beilei.x...@intel.com; adrien.mazarg...@6wind.com; Phil Yang > > Cc: dev@dpdk.org; linux...@huawei.com > Subject: Re: [PATCH v4] RSS key use with testpmd > > On 10/9/2020 1:09 PM, oulijun wrot

Re: [dpdk-dev] [PATCH v9 1/3] ethdev: introduce sample action for rte flow

On Fri, Oct 9, 2020 at 6:47 AM Jiawei Wang wrote: > > When using full offload, all traffic will be handled by the HW, and > forwarded to the requested VF or wire and the control application does > not see this traffic anymore. So there's a need for an action that > enables the control application

Re: [dpdk-dev] [PATCH v3 04/18] net/i40e: add checks for max SIMD bitwidth

Hi, power > -Original Message- > From: Power, Ciara > Sent: Friday, October 9, 2020 10:03 PM > To: Guo, Jia ; dev@dpdk.org > Cc: Xing, Beilei > Subject: RE: [PATCH v3 04/18] net/i40e: add checks for max SIMD bitwidth > > Hi Jeff, > > >-Original Message- > >From: Guo, Jia > >Se

Re: [dpdk-dev] [PATCH V1 2/3] mbuf: change free_cb interface to adapt to GSO case

Olivier, thank you so much for helping figure out this, it does work as the code you changed, so we can fix the issue without this patch series. My question is can it also work for normal mbuf or indirect mbuf? (I mean pkt is direct mbuf or indirect mbuf) At 2020-10-09 19:55:25, "Olivier Matz"

Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

> With DPDK 20.11 release, the igb_uio module is no more part of DPDK. > There are use cases where this module is required, for example while > testing the virtual ports in OvS, the virtual ports are bound to igb_uio > module inside a VM. So, this patch provides a Makefile which can be used to > bu

Re: [dpdk-dev] [PATCH] net/failsafe: check correct error code while handling sub-device add

>Subject: Re: [dpdk-dev] [PATCH] net/failsafe: check correct error code while >handling sub-device add > >On 05/10/20 11:42 +0200, Gaëtan Rivet wrote: >> Hi, >> >> On 02/10/20 17:01 -0700, Long Li wrote: >> > From: Long Li >> > >> > When adding a sub-device, it's possible that the sub-device is >>

Re: [dpdk-dev] [PATCH] net/bnxt: fix non-vector fast mbuf free offload

On Fri, Oct 9, 2020 at 9:36 AM Lance Richardson wrote: > > The fast mbuf free offload for non-vector mode requires > additional checks in order to handle long tx buffer > descriptors, so dedicated functions are needed for > vector- and non-vector-modes. > > Fixes: 103169df2880 ("net/bnxt: support

Re: [dpdk-dev] [PATCH v5 00/15] fix distributor synchronization issues

W dniu 09.10.2020 o 23:41, Lukasz Wojciechowski pisze: > > Hi David, > > W dniu 09.10.2020 o 14:53, David Marchand pisze: >> Hello Lukasz, >> >> On Thu, Oct 8, 2020 at 11:17 PM Lukasz Wojciechowski >> wrote: >>> I'm here if you have any questions or suggestions >> Unfortunately, I can see a tim

Re: [dpdk-dev] [RFC v2 1/1] lib/ring: add scatter gather APIs

> > > > Hi Honnappa, > > > > > > > > From a quick walkthrough, I have some questions/comments, please > > > > see below. > > > Hi Olivier, appreciate your input. > > > > > > > > > > > On Tue, Oct 06, 2020 at 08:29:05AM -0500, Honnappa Nagarahalli wrote: > > > > > Add scatter gather APIs to avoid

[dpdk-dev] [PATCH v6 15/15] distributor: fix clearing returns buffer

The patch clears distributors returns buffer in clear_returns() by setting start and count to 0. Fixes: 775003ad2f96 ("distributor: add new burst-capable library") Cc: david.h...@intel.com Cc: sta...@dpdk.org Signed-off-by: Lukasz Wojciechowski Acked-by: David Hunt --- lib/librte_distributor/r

[dpdk-dev] [PATCH v6 14/15] distributor: fix flushing in flight packets

rte_distributor_flush() is using total_outstanding() function to calculate if it should still wait for processing packets. However in burst mode only backlog packets were counted. This patch fixes that issue by counting also in flight packets. There are also sum fixes to properly keep count of in

[dpdk-dev] [PATCH v6 13/15] test/distributor: add test with packets marking

All of the former tests analyzed only statistics of packets processed by all workers. The new test verifies also if packets are processed on workers as expected. Every packets processed by the worker is marked and analyzed after it is returned to distributor. This test allows finding issues in mat

[dpdk-dev] [PATCH v6 10/15] distributor: align API documentation with code

After introducing burst API there were some artefacts in the API documentation from legacy single API. Also the rte_distributor_poll_pkt() function return values mismatched the implementation. Fixes: c0de0eb82e40 ("distributor: switch over to new API") Cc: david.h...@intel.com Cc: sta...@dpdk.org

[dpdk-dev] [PATCH v6 12/15] distributor: fix scalar matching

Fix improper indexes while comparing tags. In the find_match_scalar() function: * j iterates over flow tags of following packets; * w iterates over backlog or in flight tags positions. Fixes: 775003ad2f96 ("distributor: add new burst-capable library") Cc: david.h...@intel.com Cc: sta...@dpdk.org

[dpdk-dev] [PATCH v6 09/15] test/distributor: collect return mbufs

During quit_workers function distributor's main core processes some packets to wake up pending worker cores so they can quit. As quit_workers acts also as a cleanup procedure for next test case it should also collect these packages returned by workers' handlers, so the cyclic buffer with returned p

[dpdk-dev] [PATCH v6 08/15] test/distributor: fix freeing mbufs

Sanity tests with mbuf alloc and shutdown tests assume that mbufs passed to worker cores are freed in handlers. Such packets should not be returned to the distributor's main core. The only packets that should be returned are the packets send after completion of the tests in quit_workers function.

[dpdk-dev] [PATCH v6 11/15] test/distributor: replace delays with spin locks

Instead of making delays in test code and waiting for worker hopefully to reach proper states, synchronize worker shutdown test cases with spin lock on atomic variable. Fixes: c0de0eb82e40 ("distributor: switch over to new API") Cc: david.h...@intel.com Cc: sta...@dpdk.org Signed-off-by: Lukasz W

[dpdk-dev] [PATCH v6 07/15] distributor: fix return pkt calls in single mode

In the single legacy version of the distributor synchronization requires continues exchange of buffers between distributor and workers. Empty buffers are sent if only handshake synchronization is required. However calls to the rte_distributor_return_pkt() with 0 buffers in single mode were ignored

[dpdk-dev] [PATCH v6 06/15] test/distributor: synchronize lcores statistics

Statistics of handled packets are cleared and read on main lcore, while they are increased in workers handlers on different lcores. Without synchronization occasionally showed invalid values. This patch uses atomic acquire/release mechanisms to synchronize. Fixes: c3eabff124e6 ("distributor: add

[dpdk-dev] [PATCH v6 05/15] test/distributor: fix shutdown of busy worker

The sanity test with worker shutdown delegates all bufs to be processed by a single lcore worker, then it freezes one of the lcore workers and continues to send more bufs. The freezed core shuts down first by calling rte_distributor_return_pkt(). The test intention is to verify if packets assigned

[dpdk-dev] [PATCH v6 04/15] distributor: handle worker shutdown in burst mode

The burst version of distributor implementation was missing proper handling of worker shutdown. A worker processing packets received from distributor can call rte_distributor_return_pkt() function informing distributor that it want no more packets. Further calls to rte_distributor_request_pkt() or

[dpdk-dev] [PATCH v6 03/15] distributor: do not use oldpkt when not needed

rte_distributor_request_pkt and rte_distributor_get_pkt dereferenced oldpkt parameter when in RTE_DIST_ALG_SINGLE even if number of returned buffers from worker to distributor was 0. This patch passes NULL to the legacy API when number of returned buffers is 0. This allows passing NULL as oldpkt p

[dpdk-dev] [PATCH v6 01/15] distributor: fix missing handshake synchronization

rte_distributor_return_pkt function which is run on worker cores must wait for distributor core to clear handshake on retptr64 before using those buffers. While the handshake is set distributor core controls buffers and any operations on worker side might overwrite buffers which are unread yet. Sam

[dpdk-dev] [PATCH v6 02/15] distributor: fix handshake deadlock

Synchronization of data exchange between distributor and worker cores is based on 2 handshakes: retptr64 for returning mbufs from workers to distributor and bufptr64 for passing mbufs to workers. Without proper order of verifying those 2 handshakes a deadlock may occur. This can happen when worker

[dpdk-dev] [PATCH v6 00/15] fix distributor synchronization issues

During review and verification of the patch created by Sarosh Arif: "test_distributor: prevent memory leakages from the pool" I found out that running distributor unit tests multiple times in a row causes fails. So I investigated all the issues I found. There are few synchronization issues that mi

Re: [dpdk-dev] [PATCH v4 00/17] Replace terms master/slave

On Fri, 9 Oct 2020 14:38:38 -0700 Stephen Hemminger wrote: > As announced in 20.08 release notes, the terms for lcore role > will change in 20.11 release. > > This is a project wide patchset to terminolgy used for DPDK lcore. > The term "master" referring to lcore is replaced with "main" and >

Re: [dpdk-dev] [PATCH v5 00/15] fix distributor synchronization issues

Hi David, W dniu 09.10.2020 o 14:53, David Marchand pisze: > Hello Lukasz, > > On Thu, Oct 8, 2020 at 11:17 PM Lukasz Wojciechowski > wrote: >> I'm here if you have any questions or suggestions > Unfortunately, I can see a timeout on the distributor autotest in Travis: > https://travis-ci.com/git

[dpdk-dev] [PATCH v4 17/17] examples: replace master lcore with main lcore

Replace use of the term master lcore with main lcore in the example programs. Signed-off-by: Stephen Hemminger --- examples/bbdev_app/main.c | 14 +-- examples/bond/main.c| 32 - examples/distributor/main.c | 10 --

[dpdk-dev] [PATCH v4 16/17] examples/ipsec-secgw: replace master lcore with main lcore

Simple replacement. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/event_helper.c | 6 +++--- examples/ipsec-secgw/ipsec-secgw.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ipsec-secgw/event_helper.c b/examples/ipsec-s

[dpdk-dev] [PATCH v4 12/17] examples: replace use of master with main

Change references to master/slave lcore to main/worker. For l2fwd, l3fwd and link_status examples. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 2 +- examples/ip_pipeline/thread.c| 14 +++--- examp

[dpdk-dev] [PATCH v4 13/17] examples/multi_process: replace references to master/slave

Replace master with main and slave with worker. Fix the wording in comments. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- .../multi_process/client_server_mp/mp_server/main.c| 10 +- examples/multi_process/simple_mp/main.c| 4 ++-- examples/multi_pr

[dpdk-dev] [PATCH v4 15/17] examples/qos: replace references to master

Use main instead of master in the QoS examples. Replace the "mst" command line argument with "mnc" Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- examples/qos_meter/main.c| 4 ++-- examples/qos_sched/args.c| 26 +- examples/qos_sched/cmdline.c |

[dpdk-dev] [PATCH v4 14/17] examples/performance-thread: replace reference to master lcore

Replace term master with main here. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- examples/performance-thread/l3fwd-thread/main.c | 16 examples/performance-thread/pthread_shim/main.c | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/e

[dpdk-dev] [PATCH v4 11/17] app: replace references to master/slave

For the miscellaneous tests. Replace references to master lcore with main lcore and slave lcore with worker lcore. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- app/test-acl/main.c | 2 +- app/test-bbdev/test_bbdev_perf.c | 16 app/test-compress-

[dpdk-dev] [PATCH v4 10/17] app/test-eventdev: replace use of master lcore with main lcore

Replace master with main lcore. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- app/test-eventdev/evt_options.c | 2 +- app/test-eventdev/test_order_common.c| 12 ++-- app/test-eventdev/test_perf_common.c | 16 app/test-eventdev/test_pip

[dpdk-dev] [PATCH v4 08/17] app/test: replace uses of master/slave

Replace master lcore with main lcore and slave lcore with worker lcore. Mostly automatic replacement. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- app/test/autotest_test_funcs.py | 2 +- app/test/meson.build| 2 +- app/test/test.c

[dpdk-dev] [PATCH v4 06/17] net/memif: replace master/slave arguments with server/client

Replace master/slave terms in this driver. The memory interface drivers uses a client/server architecture so change the variable names and device arguments to that. The previous devargs are maintained for compatiablity, but if used cause a notice in the log. Signed-off-by: Stephen Hemminger ---

[dpdk-dev] [PATCH v4 07/17] doc: replace master lcore with main lcore

Make sure that master lcore is not used in documentation. Signed-off-by: Stephen Hemminger --- doc/guides/contributing/coding_style.rst | 2 +- doc/guides/faq/faq.rst | 6 +++--- doc/guides/howto/debug_troubleshoot.rst | 2 +- doc/guides/linux_gsg/ea

[dpdk-dev] [PATCH v4 09/17] app/test-pmd: replace master lcore with main lcore

Replace wording around main lcore. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c| 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/parameters.c | 2 +- app/test-pmd/testpmd.c| 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --

[dpdk-dev] [PATCH v4 04/17] rte_power: replace rte_master_lcore with rte_main_lcore

The old rte_master_lcore is now replaced by rte_main_lcore. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- lib/librte_power/rte_power_empty_poll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_power/rte_power_empty_poll.c b/lib/librte_power/rte_

[dpdk-dev] [PATCH v4 05/17] drivers: replace master lcore with main lcore

Replace use of deprecated rte_master_lcore with rte_main_lcore. Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- drivers/bus/dpaa/dpaa_bus.c | 2 +- drivers/bus/pci/pci_common_uio.c| 3 ++- drivers/bus/vmbus/vmbus_common_uio.c| 2

[dpdk-dev] [PATCH v4 01/17] doc/coding_style: add policy about master/slave

Update the coding style document to include a policy against introducing new master/slave usage. This is taken from the similar place in the Linux kernel coding style. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- doc/guides/contributing/coding_style.rst | 23 ++

[dpdk-dev] [PATCH v4 02/17] eal: add macro to mark macros as deprecated

Add a macro that causes GCC and CLANG to emit a warning when a deprecated macro is used. Acked-by: Anatoly Burakov Acked-by: Bruce Richardson Signed-off-by: Stephen Hemminger --- lib/librte_eal/include/rte_common.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH v4 03/17] eal: rename lcore word choices

Replace master lcore with main lcore and replace slave lcore with worker lcore. Keep the old functions and macros but mark them as deprecated for this release. The "--master-lcore" command line option is also deprecated and any usage will print a warning and use "--main-lcore" as replacement. Ac

[dpdk-dev] [PATCH v4 00/17] Replace terms master/slave

As announced in 20.08 release notes, the terms for lcore role will change in 20.11 release. This is a project wide patchset to terminolgy used for DPDK lcore. The term "master" referring to lcore is replaced with "main" and "slave" lcore is replaced with "worker" lcore. This is most visible in AP

Re: [dpdk-dev] [PATCH v5 13/15] test/distributor: add test with packets marking

Hi David, W dniu 09.10.2020 o 14:50, David Hunt pisze: > Hi Lukasz, > > On 8/10/2020 6:23 AM, Lukasz Wojciechowski wrote: >> All of the former tests analyzed only statistics >> of packets processed by all workers. >> The new test verifies also if packets are processed >> on workers as expected. >>

[dpdk-dev] [dpdk-dev v11 2/4] cryptodev: add raw crypto data-path APIs

This patch adds raw data-path APIs for enqueue and dequeue operations to cryptodev. The APIs support flexible user-define enqueue and dequeue behaviors. Signed-off-by: Fan Zhang Signed-off-by: Piotr Bronowski Acked-by: Adam Dybkowski --- doc/guides/cryptodevs/features/default.ini| 1 + d

[dpdk-dev] [dpdk-dev v11 1/4] cryptodev: change crypto symmetric vector structure

This patch updates ``rte_crypto_sym_vec`` structure to add support for both cpu_crypto synchrounous operation and asynchronous raw data-path APIs. The patch also includes AESNI-MB and AESNI-GCM PMD changes, unit test changes and documentation updates. Signed-off-by: Fan Zhang Acked-by: Adam Dybko

[dpdk-dev] [dpdk-dev v11 4/4] test/crypto: add unit-test for cryptodev raw API test

This patch adds the cryptodev raw API test support to unit test. In addtion a new test-case for QAT PMD for the test type is enabled. Signed-off-by: Fan Zhang Acked-by: Adam Dybkowski --- app/test/test_cryptodev.c | 780 -- app/test/test_cryptodev.h

[dpdk-dev] [dpdk-dev v11 3/4] crypto/qat: add raw crypto data-path API support

This patch updates QAT PMD to add raw data-path API support. Signed-off-by: Fan Zhang Acked-by: Adam Dybkowski --- drivers/crypto/qat/meson.build | 1 + drivers/crypto/qat/qat_sym.h | 11 + drivers/crypto/qat/qat_sym_hw_dp.c | 959 + drivers/crypto/qat/q

[dpdk-dev] [dpdk-dev v11 0/4] cryptodev: add raw data-path APIs

The Crypto Raw data-path APIs are a set of APIs designed to enable external libraries/applications to leverage the cryptographic processing provided by DPDK crypto PMDs through the cryptodev API but in a manner that is not dependent on native DPDK data structures (eg. rte_mbuf, rte_crypto_op, ... e

Re: [dpdk-dev] [PATCH v5 12/15] distributor: fix scalar matching

W dniu 09.10.2020 o 14:35, David Hunt pisze: > Hi Lukasz, > > On 9/10/2020 1:31 PM, David Hunt wrote: >> >> On 8/10/2020 6:23 AM, Lukasz Wojciechowski wrote: >>> Fix improper indexes while comparing tags. >>> In the find_match_scalar() function: >>> * j iterates over flow tags of following packet

Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue

On 10/8/2020 10:10 AM, Kevin Traynor wrote: On 07/10/2020 22:48, Thomas Monjalon wrote: As described in doc/guides/prog_guide/poll_mode_drv.rst, the naming scheme for the xstats is parts separated with underscore: * direction * detail 1 * detail 2 * detail n

Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue

On 10/8/2020 11:29 AM, Asaf Penso wrote: -Original Message- From: dev On Behalf Of Kevin Traynor Sent: Thursday, October 8, 2020 12:10 PM To: NBU-Contact-Thomas Monjalon ; dev@dpdk.org Cc: ferruh.yi...@intel.com; arybche...@solarflare.com Subject: Re: [dpdk-dev] [PATCH] ethdev: fix xstat

Re: [dpdk-dev] [PATCH v5 04/15] distributor: handle worker shutdown in burst mode

W dniu 09.10.2020 o 14:13, David Hunt pisze: > > On 8/10/2020 10:07 PM, Lukasz Wojciechowski wrote: >> W dniu 08.10.2020 o 16:26, David Hunt pisze: >>> On 8/10/2020 6:23 AM, Lukasz Wojciechowski wrote: The burst version of distributor implementation was missing proper handling of worker

[dpdk-dev] [PATCH] net/bnxt: fix non-vector fast mbuf free offload

The fast mbuf free offload for non-vector mode requires additional checks in order to handle long tx buffer descriptors, so dedicated functions are needed for vector- and non-vector-modes. Fixes: 103169df2880 ("net/bnxt: support fast mbuf free") Signed-off-by: Lance Richardson Reviewed-by: Ajit K

Re: [dpdk-dev] [dpdk-techboard] [PATCH V5 1/2] dpdk: resolve compiling errors for per-queue stats

On 10/6/2020 9:33 AM, Olivier Matz wrote: Hi, On Mon, Oct 05, 2020 at 01:23:08PM +0100, Ferruh Yigit wrote: On 9/28/2020 4:43 PM, Stephen Hemminger wrote: On Mon, 28 Sep 2020 17:24:26 +0200 Thomas Monjalon wrote: 28/09/2020 15:53, Ferruh Yigit: On 9/28/2020 10:16 AM, Thomas Monjalon wrote:

[dpdk-dev] [EXT] RE: [PATCH] crypto/mvsam: remove crypto end enumerators

Thanks! --- Sent from Workspace ONE Boxer On 9 October 2020 at 22:51:52 GMT+3, Akhil Goyal wrote: External Email -- > From: Michael Shamis > > Remove enumerators RTE_CRYPTO_CIPHER_LIST_EN

[dpdk-dev] [dpdk-dev v3 2/2] fips_validation: update GCM test

This patch updates fips validation GCM test capabilities: - In NIST GCMVS spec GMAC test vectors are the GCM ones with plaintext length as 0 and uses AAD as input data. Originally fips_validation tests treats them both as GCM test vectors. This patch introduce automatic test type recognition betwe

[dpdk-dev] [dpdk-dev v3 0/2] fips_validation: add SGL and GMAC support

This patchset adds SGL and GMAC support to fips_validation sample application. The added cmdline option allows user to split the input data into multiple mbuf segments to test SGL feature of the target cryptodev PMD; The NIST GCMVS compliant GMAC test method support is also added in this patchset.

[dpdk-dev] [dpdk-dev v3 1/2] fips_validation: add SGL support

This patch adds SGL support to FIPS sample application. Originally the application allocates single mbuf of 64KB - 1 bytes data room. With the change the user may reduce the mbuf dataroom size by using the add cmdline option. If the input test data is longer than the user provided data room size th

Re: [dpdk-dev] [PATCH] crypto/armv8: remove crypto enum list end references

> Removed references to RTE_CRYPTO_CIPHER_LIST_END and > RTE_CRYPTO_AUTH_LIST_END. > > Signed-off-by: Ruifeng Wang > Reviewed-by: Phil Yang > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] crypto/mvsam: remove crypto end enumerators

> From: Michael Shamis > > Remove enumerators RTE_CRYPTO_CIPHER_LIST_END, > RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent > some problems that may arise when adding new crypto algorithms. > > Signed-off-by: Michael Shamis > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] doc: remove aes-gcm addition of j0 deprecation notice

Hi Arek, > This patch removes information about deprecation of AES-GCM/GMAC > API for IV without J0. > > Signed-off-by: Arek Kusztal > --- > doc/guides/rel_notes/deprecation.rst | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel

Re: [dpdk-dev] [PATCH v2] crypto/aesni_mb: fix incorrect clearing of security session

> When destroying a security session, the AESNI-MB PMD attempted to clear > the private aesni_mb session object to remove any key material. However, > the function aesni_mb_pmd_sec_sess_destroy() cleared the security session > object instead of the private session object. > > This patch fixes this

Re: [dpdk-dev] [PATCH 1/2] crypto/dpaa2_sec: increase supported anti replay win sz

> From: Akhil Goyal > > In case of LX2160 or SEC ERA >= 10, max anti replay window > size supported is 1024. For all other versions of SEC, the > maximum value is capped at 128 even if application gives > more than that. > > Signed-off-by: Akhil Goyal > Signed-off-by: Yi Liu > --- Series appli

Re: [dpdk-dev] [PATCH 1/2] crypto/dpaa2_sec: support DES-CBC

> From: Akhil Goyal > > add DES-CBC support for cipher_only, chain and ipsec protocol. > > Signed-off-by: Hemant Agrawal > Signed-off-by: Akhil Goyal > --- Added release notes while applying the series. Applied to dpdk-next-crypto.

Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue

On 10/9/2020 5:53 PM, Kevin Laatz wrote: On 08/10/2020 16:41, Ferruh Yigit wrote: On 10/7/2020 10:48 PM, Thomas Monjalon wrote: As described in doc/guides/prog_guide/poll_mode_drv.rst, the naming scheme for the xstats is parts separated with underscore: * direction * detail 1 * det

Re: [dpdk-dev] [PATCH 1/2] crypto/dpaa2_sec: fix to check queue pair array for null

> dpdk-procinfo calls the crypto stats API, which results segmentation > fault on DPAA2_SEC. > The queue pair array will be NULL, when it is used without > configuring the SEC device. > > Fixes: 02f35eee264b ("crypto/dpaa2_sec: support statistics") > Cc: sta...@dpdk.org > > Signed-off-by: Hemant

Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue

Hi Abhinandan, > Hi Akhil, > > If the patch is ok, could you please ack it? > Could you please send the Fixes tag for the original patch which introduced this Issue? I will add it while applying the patch. Acked-by: Akhil Goyal > > > > Hi Akhil, > > > > Recently, I observed that test was fai

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix the default RSS key configuration

On 10/9/2020 7:27 PM, Ferruh Yigit wrote: On 10/9/2020 12:55 PM, oulijun wrote: 在 2020/9/30 20:57, Ferruh Yigit 写道: On 9/24/2020 2:45 PM, Lijun Ou wrote: It use the NIC valid default RSS key instead of the testpmd dummy RSS key in the flow configuration when the RSS key is not specified in t

Re: [dpdk-dev] [PATCH v2 0/2] add anti replay support in OCTEON TX2 security

> > > >> >Hi Akhil, > >> > > >> >Please let me know if you have any review comments on this patch series. > >> > > > > >I am working on the crypto tree. These patches are in my back log and will > >let > >you know if I face some issues. > >These patches are PMD patches and are 2nd on my priority l

Re: [dpdk-dev] [PATCH v4] RSS key use with testpmd

On 10/9/2020 1:09 PM, oulijun wrote: 在 2020/9/30 21:17, Ferruh Yigit 写道: On 9/24/2020 2:45 PM, Lijun Ou wrote: Consider the follow usage with testpmd: 1. first, startup testpmd: testpmd> show port 0 rss-hash key RSS functions:   all ipv4-frag ipv4-other ipv6-frag ipv6-other ip RSS key: 6D5A56

Re: [dpdk-dev] [PATCH v2 3/3] crypto/aesni_mb: support Chacha20-Poly1305

> > You are right, sorry. I got this from QAT PMD and I forgot to remove these > line > breaks. > Can you remove them when applying it? > Ok will do that.

Re: [dpdk-dev] [dpdk-dev v2 0/2] fips_validation: add SGL and GMAC support

Hi, NP. Regards, Fan > -Original Message- > From: Akhil Goyal > Sent: Friday, October 9, 2020 7:24 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: Trahe, Fiona ; Kusztal, ArkadiuszX > ; Dybkowski, AdamX > > Subject: RE: [dpdk-dev v2 0/2] fips_validation: add SGL and GMAC support > > Hi F

[dpdk-dev] [Bug 551] LACP failover with 802.3ad bond mode 4 takes long time

https://bugs.dpdk.org/show_bug.cgi?id=551 Bug ID: 551 Summary: LACP failover with 802.3ad bond mode 4 takes long time Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED Severity: major

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix the default RSS key configuration

On 10/9/2020 12:59 PM, oulijun wrote: 在 2020/9/30 21:36, Ferruh Yigit 写道: On 9/24/2020 2:45 PM, Lijun Ou wrote: It use the NIC valid default RSS key instead of the testpmd dummy RSS key in the flow configuration when the RSS key is not specified in the flow rule. If the NIC RSS key is invalid

Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: add GMAC SGL tests

Hi Pablo, > Hi Akhil, > > > > diff --git a/app/test/test_cryptodev.h b/app/test/test_cryptodev.h > > > index 41542e055..57003733b 100644 > > > --- a/app/test/test_cryptodev.h > > > +++ b/app/test/test_cryptodev.h > > > @@ -17,9 +17,9 @@ > > > #define DEFAULT_NUM_QPS_PER_QAT_DEVICE (2) > > > #d

Re: [dpdk-dev] [PATCH v5 0/2] net: add CRC run-time checks and AVX512/VPCLMULQDQ based CRC

> -Original Message- > From: O'loingsigh, Mairtin > Sent: Friday, October 9, 2020 2:51 PM > To: Singh, Jasvinder ; Richardson, Bruce > ; De Lara Guarch, Pablo > ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Ryan, Brendan ; O'loingsigh, > Mairtin ; Coyle, David > Subject: [PATCH v5 0/2]

Re: [dpdk-dev] [PATCH v2 3/3] crypto/aesni_mb: support Chacha20-Poly1305

Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Friday, October 9, 2020 2:33 PM > To: De Lara Guarch, Pablo ; Doherty, Declan > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 3/3] crypto/aesni_mb: support Chacha20- > Poly1305 > > > +#if IMB_VERSION(0, 54, 3) <= IMB_VE

[dpdk-dev] [Bug 550] Only one bond link is usable with 802.3ad LACP (mode 4)

https://bugs.dpdk.org/show_bug.cgi?id=550 Bug ID: 550 Summary: Only one bond link is usable with 802.3ad LACP (mode 4) Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED

Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: add GMAC SGL tests

Hi Akhil, > -Original Message- > From: dev On Behalf Of Akhil Goyal > Sent: Friday, October 9, 2020 3:10 PM > To: De Lara Guarch, Pablo ; Doherty, Declan > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: add GMAC SGL tests > > Hi Pablo, > > > diff --git a/app/t

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix the default RSS key configuration

On 10/9/2020 12:55 PM, oulijun wrote: 在 2020/9/30 20:57, Ferruh Yigit 写道: On 9/24/2020 2:45 PM, Lijun Ou wrote: It use the NIC valid default RSS key instead of the testpmd dummy RSS key in the flow configuration when the RSS key is not specified in the flow rule. If the NIC RSS key is invalid

Re: [dpdk-dev] [dpdk-dev v2 0/2] fips_validation: add SGL and GMAC support

Hi Fan, > > This patchset adds SGL and GMAC support to fips_validation sample > application. The added cmdline option allows user to split the input > data into multiple mbuf segments to test SGL feature of the target > cryptodev PMD; The NIST GCMVS compliant GMAC test method support is also > add

[dpdk-dev] [Bug 549] With offloads, bond device initialization fails with command-line bond arguments

https://bugs.dpdk.org/show_bug.cgi?id=549 Bug ID: 549 Summary: With offloads, bond device initialization fails with command-line bond arguments Product: DPDK Version: 20.11 Hardware: All OS: All

Re: [dpdk-dev] [PATCH] examples/fips_validation: bypass the unsupported test vectors

> Bypass the test vectors of unsupported crypto transform > for SHA. > > Signed-off-by: Archana Muniganti > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH 2/3] examples/fips_validation: ignore \r in input files

> > > > So if we cannot know which version removed the \r, I suggest to just > > drop this patch. I thought it was a bug in the parser, but if it does > > not happen with files matching the supported CAVS version, there is > > nothing to fix. > > Applied the series to dpdk-next-crypto As suggested

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix req file version incompatibility

> > > > > > Separate out CAVS request file version 21.4 code to support lower > > > versions. > > > > > > Fixes: 32440cdf2af9 ("examples/fips_validation: fix parsing of TDES > > > vectors") > > > Fixes: 2b84d2bd47df ("examples/fips_validation: fix count overwrite for > > > TDES") > > > > > Acked

Re: [dpdk-dev] [PATCH RESEND 1/2] raw/octeontx2_dma: Assign pem_id as lport for non-internal DMA

On Wed, Oct 7, 2020 at 10:33 AM Satha Koteswara Rao Kottidi wrote: > > > > -Original Message- > From: Radha Mohan Chintakuntla > Sent: Tuesday, October 6, 2020 11:00 AM > To: dev@dpdk.org; Satha Koteswara Rao Kottidi > Cc: Jerin Jacob Kollanukkaran ; Radha Chintakuntla > ; Satananda Bur

Re: [dpdk-dev] [PATCH] cryptodev: fix cryptodev parameter parsing

> The rte_cryptodev_pmd_parse_input_args function crashes with a > segmentation fault when passing a non-empty argument string. > > The function passes cryptodev_pmd_valid_params to rte_kvargs_parse, > which accepts a NULL-terminated list of valid keys, yet > cryptodev_pmd_valid_params does not en

Re: [dpdk-dev] [PATCH v2 1/1] cryptodev: remove v20 ABI compatibility

> This reverts commit a0f0de06d457753c94688d551a6e8659b4d4e041 as the > rte_cryptodev_info_get function versioning was a temporary solution > to maintain ABI compatibility for ChaCha20-Poly1305 and is not > needed in 20.11. > > Fixes: a0f0de06d457 ("cryptodev: fix ABI compatibility for ChaCha20-Po

Re: [dpdk-dev] DPDK Release Status Meeting 8/10/2020

09/10/2020 18:56, Stephen Hemminger: > On Thu, 8 Oct 2020 13:54:50 +0100 > Ferruh Yigit wrote: > > >* The series to update the terms/language are still in the backlog > > * They are not passing the CI, needs attention > > Who is addressing this? > I don't see any failures listed in the

Re: [dpdk-dev] [PATCH v3] net/memif: use abstract socket address

On 10/9/2020 5:58 PM, Jakub Grajciar wrote: Abstract socket address has no connection with filesystem pathnames and the socket disappears once all open references are closed. Memif pmd will use abstract socket address by default. For backwards compatibility use new argument 'socket-abstract=no'

Re: [dpdk-dev] [PATCH v5 01/10] eal: add new x86 cpuid support for WAITPKG

On 09-Oct-20 5:02 PM, Anatoly Burakov wrote: From: Liang Ma Add new x86 cpuid support for WAITPKG. This flag indicate processor support umwait/umonitor/tpause instruction. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev The work on this patchset is clea

[dpdk-dev] [PATCH v3] net/memif: use abstract socket address

Abstract socket address has no connection with filesystem pathnames and the socket disappears once all open references are closed. Memif pmd will use abstract socket address by default. For backwards compatibility use new argument 'socket-abstract=no' Signed-off-by: Jakub Grajciar --- doc/guide

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

On 09-Oct-20 5:56 PM, Ananyev, Konstantin wrote: On 09-Oct-20 4:39 PM, Ananyev, Konstantin wrote: On 08-Oct-20 6:15 PM, Ananyev, Konstantin wrote: Add two new power management intrinsics, and provide an implementation in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions are

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

> > On 09-Oct-20 4:39 PM, Ananyev, Konstantin wrote: > > > >> On 08-Oct-20 6:15 PM, Ananyev, Konstantin wrote: > > Add two new power management intrinsics, and provide an implementation > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > are implemented as r

Re: [dpdk-dev] DPDK Release Status Meeting 8/10/2020

On Thu, 8 Oct 2020 13:54:50 +0100 Ferruh Yigit wrote: >* The series to update the terms/language are still in the backlog > * They are not passing the CI, needs attention Who is addressing this? I don't see any failures listed in the patchwork CI results.

  1   2   3   4   >