Adding Khoa
-Original Message-
From: Dmitry Kozlyuk
Sent: Thursday, July 30, 2020 2:07 PM
To: dev@dpdk.org
Cc: Dmitry Malloy (MESHCHANINOV) ; Narcisa Ana Maria
Vasile ; Fady Bader ; Tal
Shnaiderman ; Kadam, Pallavi ;
Dmitry Kozlyuk ; Olivier Matz
Subject: [EXTERNAL] [PATCH v2 7/7] ex
> -Original Message-
> From: Dmitry Kozlyuk
> Sent: Thursday, September 24, 2020 4:17 PM
> To: dev@dpdk.org
> Cc: Dmitry Kozlyuk ; sta...@dpdk.org; Khoa To
> ; Tal Shnaiderman ; Narcisa Ana
> Maria Vasile ; Dmitry Malloy
> (MESHCHANINOV) ; Pallavi Kadam
>
> Subject: [EXTERNAL] [PATCH] e
On Fri, Sep 25, 2020 at 2:40 PM Lance Richardson
wrote:
>
> Descriptor valid mask should be 64-bit all ones, use
> appropriate initializer type (unsigned long long) to
> obtain correct value in 32-bit mode.
>
> Fixes: deae85145c64 ("net/bnxt: handle multiple packets per loop in vector
> Rx")
> Si
Descriptor valid mask should be 64-bit all ones, use
appropriate initializer type (unsigned long long) to
obtain correct value in 32-bit mode.
Fixes: deae85145c64 ("net/bnxt: handle multiple packets per loop in vector Rx")
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
---
dri
HI Matan,
While troubleshooting a failure in DPDK on device removal when VF device
briefly disappears and comes back, I notice the failsafe driver is trying
repeatedly to start a sub device (after this sub device has been successfully
configured, but later hot removed from the kernel). This is
On Sat, Sep 26, 2020 at 02:32:42AM +0300, Dmitry Kozlyuk wrote:
> Windows interrupt support is based on IO completion ports (IOCP).
> Interrupt thread would send the devices requests to notify about
> interrupts and then wait for any request completion. Add skeleton code
> of this model without any
On Sat, Sep 26, 2020 at 02:32:43AM +0300, Dmitry Kozlyuk wrote:
> Implementation is based on waitable timers Win32 API. When timer is set,
> a callback and its argument are supplied to the OS, while timer handle
> is stored in EAL alarm list. When timer expires, OS wakes up the
> interrupt thread a
Implementation is based on waitable timers Win32 API. When timer is set,
a callback and its argument are supplied to the OS, while timer handle
is stored in EAL alarm list. When timer expires, OS wakes up the
interrupt thread and runs the callback. Upon completion it removes the
alarm.
Waitable ti
Windows interrupt support is based on IO completion ports (IOCP).
Interrupt thread would send the devices requests to notify about
interrupts and then wait for any request completion. Add skeleton code
of this model without any hardware support.
Another way to wake up the interrupt thread is APC (
This patchset provides EAL alarm support for Windows. Basic interrupt
thread code is added to monitor alarm events. It doesn't include
callback management, because Windows alarms, unlike Unix EALs, rely on
the OS for callback execution scheduling.
v2: rebase on ToT to resolve conflicts.
Dmitry Ko
Hello David,
Thank you for your review.
W dniu 25.09.2020 o 14:31, David Marchand pisze:
> Hello Lukasz,
>
> On Wed, Sep 23, 2020 at 3:25 PM Lukasz Wojciechowski
> wrote:
>> During review and verification of the patch created by Sarosh Arif:
>> "test_distributor: prevent memory leakages from the
Synchronization of data exchange between distributor and worker cores
is based on 2 handshakes: retptr64 for returning mbufs from workers
to distributor and bufptr64 for passing mbufs to workers.
Without proper order of verifying those 2 handshakes a deadlock may
occur. This can happen when worker
rte_distributor_return_pkt function which is run on worker cores
must wait for distributor core to clear handshake on retptr64
before using those buffers. While the handshake is set distributor
core controls buffers and any operations on worker side might overwrite
buffers which are unread yet.
Sam
After introducing burst API there were some artefacts in the
API documentation from legacy single API.
Also the rte_distributor_poll_pkt() function return values
mismatched the implementation.
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Sanity tests with mbuf alloc and shutdown tests assume that
mbufs passed to worker cores are freed in handlers.
Such packets should not be returned to the distributor's main
core. The only packets that should be returned are the packets
send after completion of the tests in quit_workers function.
rte_distributor_request_pkt and rte_distributor_get_pkt dereferenced
oldpkt parameter when in RTE_DIST_ALG_SINGLE even if number
of returned buffers from worker to distributor was 0.
This patch passes NULL to the legacy API when number of returned
buffers is 0. This allows passing NULL as oldpkt p
During quit_workers function distributor's main core processes
some packets to wake up pending worker cores so they can quit.
As quit_workers acts also as a cleanup procedure for next test
case it should also collect these packages returned by workers'
handlers, so the cyclic buffer with returned p
Statistics of handled packets are cleared and read on main lcore,
while they are increased in workers handlers on different lcores.
Without synchronization occasionally showed invalid values.
This patch uses atomic acquire/release mechanisms to synchronize.
Fixes: c3eabff124e6 ("distributor: add
During review and verification of the patch created by Sarosh Arif:
"test_distributor: prevent memory leakages from the pool" I found out
that running distributor unit tests multiple times in a row causes fails.
So I investigated all the issues I found.
There are few synchronization issues that mi
The sanity test with worker shutdown delegates all bufs
to be processed by a single lcore worker, then it freezes
one of the lcore workers and continues to send more bufs.
Problem occurred if freezed lcore is the same as the one
that is processing the mbufs. The lcore processing mbufs
might be dif
On Fri, Sep 25, 2020 at 1:47 AM Min Hu (Connor) wrote:
>
> HI，Andrew，
> I fix it in V13 according to your advice.
> Thanks for your patient review. Please check it out again.
>
> By the way, there is always a coding check warning, like this:
>
> WARNING:PREFER_FALLTHROUGH: Prefer
Hi Thomas,
>From: Thomas Monjalon
>Sent: Friday, September 25, 2020 12:11 AM
>
>25/09/2020 06:17, Rasesh Mody:
>> Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources
>> for the port can be freed by rte_eth_dev_close(). With this change the
>> private port resources are released i
On Fri, Sep 25, 2020 at 9:44 AM Bruce Richardson
wrote:
>
> On Fri, Sep 25, 2020 at 09:27:25AM -0400, Lance Richardson wrote:
> > On Fri, Sep 25, 2020 at 5:13 AM Bruce Richardson
> > wrote:
> > >
> > > On Thu, Sep 24, 2020 at 12:37:42PM -0400, Lance Richardson wrote:
> > > > Add meson cross files
> -Original Message-
> From: Steven Lariau
> Sent: Friday, September 25, 2020 12:44 PM
> To: Eads, Gage ; Olivier Matz
> Cc: dev@dpdk.org; n...@arm.com; Steven Lariau
> Subject: [PATCH v2 5/5] lib/stack: remove pop cas release ordering
>
> Replace the store-release by relaxed for the
List head must be loaded right before continue (when failed to
find the new head).
Without this, one thread might keep trying and failing to pop items
without ever loading the new correct head.
Fixes: 7e6e609939a8 ("stack: add C11 atomic implementation")
Cc: gage.e...@intel.com
Cc: sta...@dpdk.org
Replace the store-release by relaxed for the CAS success at the end of
pop. Release isn't needed, because there is not write to data that need
to be synchronized.
The only preceding write is when the length is decreased, but the length
CAS loop already ensures the right synchronization.
The situati
Fix cmpexchange usage of weak / strong.
The generated code is the same on x86 and ARM (there is no weak
cmpexchange), but the old usage was inconsistent.
For push and pop update size, weak is used because cmpexchange is inside
a loop.
For pop update root, strong is used even though cmpexchange is i
An acquire fence is used to make sure loads after the fence can observe
all store operations before a specific store-release.
But push doesn't read any data, except for the head which is part of a
CAS operation (the items on the list are not read).
So there is no need for the acquire barrier.
Sign
The load-acquire of list->len on pop function is redundant.
Only the CAS success needs to be load-acquire.
It synchronizes with the store release in push, to ensure that the
updated head is visible when the new length is visible.
Without this, one thread in pop could see the increased length but th
One implementation of the DPDK stack library is lockfree,
based on C11 memory model for atomics.
Some of these atomic operations use unnecessary memory orders,
that can be relaxed.
This patch relax some of these operations in order to improve
the performance of the stack library.
The patch was tes
On Fri, Sep 25, 2020 at 5:13 AM Bruce Richardson
wrote:
>
> On Thu, Sep 24, 2020 at 12:37:42PM -0400, Lance Richardson wrote:
> > Add meson cross files for building i686 targets using gcc on x86_64
> > linux hosts.
> >
> > Uusage example:
> >
> > meson --cross-file config/x86/cross-i686-linux-
On Fri, 25 Sep 2020 18:41:40 +0200
David Marchand wrote:
> On Fri, Sep 25, 2020 at 6:14 PM Stephen Hemminger
> wrote:
> >
> > The DPDK does not have (or want to use) the same fallthrough
> > wrapper as the Linux kernel. Therefore silence the warning.
> >
> > Signed-off-by: Stephen Hemminger
N
> From: Dmitry Kozlyuk
> On Wed, 23 Sep 2020 17:15:38 +0300, Tal Shnaiderman wrote:
> > In the Windows getopt_internal function the condition freeing the
> > memory allocated by _dupenv_s is correct only for the first call to
> > the function.
>
> Hi Tal,
>
> a few days back Khoa To and me priva
On Fri, Sep 25, 2020 at 6:14 PM Stephen Hemminger
wrote:
>
> The DPDK does not have (or want to use) the same fallthrough
> wrapper as the Linux kernel. Therefore silence the warning.
>
> Signed-off-by: Stephen Hemminger
> ---
> devtools/checkpatches.sh | 2 +-
> 1 file changed, 1 insertion(+),
On 9/25/2020 5:12 PM, Stephen Hemminger wrote:
On Fri, 25 Sep 2020 08:36:06 -0700
Ajit Khaparde wrote:
WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#264: FILE: drivers/net/hns3/hns3_ethdev.c:5601:
+ /* fallthrough */
Try /* FALLTHROUGH */
That won't work
The DPDK does not have (or want to use) the same fallthrough
wrapper as the Linux kernel. Therefore silence the warning.
Signed-off-by: Stephen Hemminger
---
devtools/checkpatches.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpat
On Fri, 25 Sep 2020 08:36:06 -0700
Ajit Khaparde wrote:
> >
> > WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
> > #264: FILE: drivers/net/hns3/hns3_ethdev.c:5601:
> > + /* fallthrough */
> Try /* FALLTHROUGH */
That won't work either.
This is a new warning f
Hi David,
On 25/9/2020 3:22 PM, David Marchand wrote:
On Tue, Sep 8, 2020 at 12:22 PM Sarosh Arif wrote:
rte_mempool_get_bulk is used to get bufs/many_bufs from the pool,
but at some locations when test fails the bufs/many_bufs are
not returned back to the pool.
Due to this, multiple execution
On 8/9/2020 11:22 AM, Sarosh Arif wrote:
rte_mempool_get_bulk is used to get bufs/many_bufs from the pool,
but at some locations when test fails the bufs/many_bufs are
not returned back to the pool.
Due to this, multiple executions of distributor_autotest gives the
following error message: Erro
On 02-Jul-20 3:49 AM, 陈毅强 wrote:
Hi,ALL
We fail to start dpdk in a newly deployed machine.Failed progress works in
proc-type=secondary mode. (DPDK version 16.04).Some logs are shown below
=
Primary prog
Hi Kevin, all,
2020-09-21, Kevin Laatz:
> Changed script to explicitly use python3 only to avoid
> maintaining python 2 and removed deprecation notice.
>
> Cc: Dmitry Kozlyuk
> Cc: Narcisa Ana Maria Vasile
> Cc: Dmitry Malloy
> Cc: Pallavi Kadam
>
> Signed-off-by: Kevin Laatz
Acked-by: Rob
Hi Kevin, all,
2020-09-21, Kevin Laatz:
> From: Louise Kilheeney
>
> Changed script to explicitly use python3 only to avoid
> maintaining python 2 and removed deprecation notice.
>
> Cc: Nicolas Chautru
>
> Signed-off-by: Louise Kilheeney
Acked-by: Robin Jarry
Hi Kevin, all,
2020-09-21, Kevin Laatz:
> From: Louise Kilheeney
>
> Changed script to explicitly use python3 only to avoid
> maintaining python 2.
>
> Cc: Thomas Monjalon
>
> Signed-off-by: Louise Kilheeney
Acked-by: Robin Jarry
Hi Kevin, all,
2020-09-21, Kevin Laatz:
> Changed script to explicitly use python3 only to avoid
> maintaining python 2 and removed deprecation notice.
>
> Signed-off-by: Louise Kilheeney
> Signed-off-by: Kevin Laatz
Acked-by: Robin Jarry
Hi Kevin, all,
2020-09-21, Kevin Laatz:
> From: Louise Kilheeney
>
> Changed script to explicitly use python3 only to avoid
> maintaining python 2 and removed deprecation notice.
>
> Cc: Neil Horman
> Cc: Ray Kinsella
>
> Signed-off-by: Louise Kilheeney
> Acked-by: Ray Kinsella
> Acked-by:
Hi Kevin, all,
2020-09-21, Kevin Laatz:
> Changed script to explicitly use python3 only to avoid
> maintaining python 2 and removed deprecation notice.
>
> Cc: Olivier Matz
>
> Signed-off-by: Louise Kilheeney
> Signed-off-by: Kevin Laatz
> Reviewed-by: Bruce Richardson
[snip]
> @@ -43,7 +38,
Hi Kevin, all,
2020-09-21, Kevin Laatz:
> From: Louise Kilheeney
>
> Changed script to explicitly use python3 only to avoid
> maintaining python 2 and removed deprecation notice.
>
> Signed-off-by: Louise Kilheeney
> Reviewed-by: Bruce Richardson
Acked-by: Robin Jarry
Hi Kevin, all,
2020-09-21, Kevin Laatz:
> From: Louise Kilheeney
>
> Changed script to explicitly use python3 only to avoid
> maintaining python 2 and removed deprecation notice.
>
> Cc: Neil Horman
>
> Signed-off-by: Louise Kilheeney
> Reviewed-by: Bruce Richardson
> Acked-by: Neil Horman
On Fri, Sep 25, 2020 at 4:16 PM Somnath Kotur
wrote:
>
> On Fri, Sep 25, 2020 at 2:12 PM Ferruh Yigit wrote:
> >
> > On 9/25/2020 3:04 AM, Somnath Kotur wrote:
> > > On Thu, Sep 24, 2020 at 8:17 PM Ferruh Yigit
> > > wrote:
> > >>
> > >> On 9/22/2020 8:06 AM, Somnath Kotur wrote:
> > >>> Check
Hi Kevin, all,
2020-09-21, Kevin Laatz:
> From: Louise Kilheeney
>
> Changed script to explicitly use python3 only to avoid
> maintaining python 2 and removed deprecation notice.
>
> Signed-off-by: Louise Kilheeney
> Reviewed-by: Bruce Richardson
Acked-by: Robin Jarry
On 9/25/2020 3:28 PM, Bruce Richardson wrote:
On Fri, Sep 25, 2020 at 10:08:35AM -0400, Lance Richardson wrote:
On Fri, Sep 25, 2020 at 9:44 AM Bruce Richardson
wrote:
On Fri, Sep 25, 2020 at 09:27:25AM -0400, Lance Richardson wrote:
On Fri, Sep 25, 2020 at 5:13 AM Bruce Richardson
wrote:
On Fri, Sep 25, 2020 at 4:36 PM Maxime Coquelin
wrote:
> On 9/22/20 11:18 PM, Ivan Dyukov wrote:
> > rte_ethdev states new rule for NICs: they should return UNKNOWN
> > speed if speed is unknown and interface is up, in case of down
> > interface, NONE speed should be returned.
> >
> > Signed-off-b
Check for num_rep before invoking rep port probe.
Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
Signed-off-by: Somnath Kotur
Reviewed-by: Venkat Duvvuru
---
v2: Check against num_rep instead of devargs ptr
drivers/net/bnxt/bnxt_ethdev.c | 4
1 file changed, 4 insert
On Fri, Sep 25, 2020 at 2:12 PM Ferruh Yigit wrote:
>
> On 9/25/2020 3:04 AM, Somnath Kotur wrote:
> > On Thu, Sep 24, 2020 at 8:17 PM Ferruh Yigit wrote:
> >>
> >> On 9/22/2020 8:06 AM, Somnath Kotur wrote:
> >>> Check for devargs before invoking rep port probe.
> >>>
> >>> Fixes: 6dc83230b43b (
Check for num_rep before invoking rep port probe.
Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
Signed-off-by: Somnath Kotur
Reviewed-by: Venkat Duvvuru
---
v2: Check against num_rep instead of devargs ptr
drivers/net/bnxt/bnxt_ethdev.c | 4
1 file changed, 4 insert
Hi Ivan,
On 9/22/20 11:18 PM, Ivan Dyukov wrote:
> rte_ethdev states new rule for NICs: they should return UNKNOWN
> speed if speed is unknown and interface is up, in case of down
> interface, NONE speed should be returned.
>
> Signed-off-by: Ivan Dyukov
> ---
> doc/guides/nics/virtio.rst
On 9/22/20 11:18 PM, Ivan Dyukov wrote:
> ethdev library was updated with new speed 200G
>
> Add 200G speed capa to virtio device
>
> Signed-off-by: Ivan Dyukov
> ---
> drivers/net/virtio/virtio_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/virtio/virtio_et
Hi Kevin, all,
2020-09-21, Kevin Laatz:
> From: Louise Kilheeney
>
> Changed script to explicitly use python3 only to avoid
> maintaining python 2 and removed deprecation notice.
>
> Cc: Kevin Laatz
>
> Signed-off-by: Louise Kilheeney
> Acked-by: Bruce Richardson
[snip]
> -s
Hello Honnappa,
On Sun, May 3, 2020 at 11:32 PM Honnappa Nagarahalli
wrote:
>
>
>
> > Subject: Re: [PATCH v2 0/2] Use WFE for spinlock and ring
> >
> > On Sun, Apr 26, 2020 at 10:39 AM Gavin Hu wrote:
> > >
> > > The rte_wait_until_equal_xxx APIs abstract the functionality of
> > > 'polling for
On Fri, Sep 25, 2020 at 10:08:35AM -0400, Lance Richardson wrote:
> On Fri, Sep 25, 2020 at 9:44 AM Bruce Richardson
> wrote:
> >
> > On Fri, Sep 25, 2020 at 09:27:25AM -0400, Lance Richardson wrote:
> > > On Fri, Sep 25, 2020 at 5:13 AM Bruce Richardson
> > > wrote:
> > > >
> > > > On Thu, Sep 2
Hello Steven,
On Mon, Sep 21, 2020 at 7:17 PM Eads, Gage wrote:
> > -Original Message-
> > From: Steven Lariau
> > Sent: Friday, September 11, 2020 10:30 AM
> > To: Eads, Gage ; Olivier Matz
> > Cc: dev@dpdk.org; n...@arm.com; dharmik.thak...@arm.com; Steven Lariau
> >
> > Subject: [PA
On Tue, Sep 8, 2020 at 12:22 PM Sarosh Arif wrote:
>
> rte_mempool_get_bulk is used to get bufs/many_bufs from the pool,
> but at some locations when test fails the bufs/many_bufs are
> not returned back to the pool.
> Due to this, multiple executions of distributor_autotest gives the
> following
> On Wed, Sep 16, 2020 at 7:09 PM David Marchand
> wrote:
> >
> > On Fri, Sep 11, 2020 at 7:46 AM Joyce Kong wrote:
> > >
> > > Experimental tags can be removed from APIs in module: ticket lock,
> > > MCS lock, pause (wait until equal APIs), and RCU (except for defer
> > > queue APIs) as they ha
On Wed, Sep 16, 2020 at 7:09 PM David Marchand
wrote:
>
> On Fri, Sep 11, 2020 at 7:46 AM Joyce Kong wrote:
> >
> > Experimental tags can be removed from APIs in module: ticket lock,
> > MCS lock, pause (wait until equal APIs), and RCU (except for defer
> > queue APIs) as they have been aroud fou
On Thu, Sep 24, 2020 at 7:40 AM Phil Yang wrote:
>
> Since rte_atomicXX APIs are not allowed to be used[1][2], use C11 atomic
> builtins instead in eal, bbdev, power, and ethdev libs.
>
> [1]
> http://code.dpdk.org/dpdk/latest/source/doc/guides/rel_notes/deprecation.rst#L87
> [2] http://code.dpdk
On Fri, Sep 25, 2020 at 09:27:25AM -0400, Lance Richardson wrote:
> On Fri, Sep 25, 2020 at 5:13 AM Bruce Richardson
> wrote:
> >
> > On Thu, Sep 24, 2020 at 12:37:42PM -0400, Lance Richardson wrote:
> > > Add meson cross files for building i686 targets using gcc on x86_64
> > > linux hosts.
> > >
On 9/25/2020 1:51 PM, Min Hu (Connor) wrote:
From: Huisong Li
This series change data type in TC rxq and TC txq,
fix compiling errors for per-queue statistics.
Huisong Li (2):
dpdk: resolve compiling errors for per-queue stats
ethdev: change data type in TC rxq and TC txq
app/proc-inf
25/09/2020 10:52, Ferruh Yigit:
> On 9/24/2020 10:58 PM, Thomas Monjalon wrote:
> > 23/09/2020 22:47, Thomas Monjalon:
> >> 23/09/2020 18:44, Ferruh Yigit:
> >>> On 9/13/2020 11:07 PM, Thomas Monjalon wrote:
> The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources
> can be freed b
From: Huisong Li
This series change data type in TC rxq and TC txq,
fix compiling errors for per-queue statistics.
Huisong Li (2):
dpdk: resolve compiling errors for per-queue stats
ethdev: change data type in TC rxq and TC txq
app/proc-info/main.c | 2 +-
app/test-pmd/cm
From: Huisong Li
Currently, base and nb_queue in the tc_rxq and tc_txq information
of queue and TC mapping on both TX and RX paths are uint8_t.
However, these data will be truncated when queue number under a TC
is greater than 256. So it is necessary for base and nb_queue to
change from uint8_t t
From: Huisong Li
Currently, only statistics of rx/tx queues with queue_id less than
RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain
application scenario that it needs to use 256 or more than 256 queues
and display all statistics of rx/tx queue. At this moment, we have to
chang
From: Huisong Li
Currently, the information of Rx/Tx queues from PMD driver is not displayed
exactly in the rxtx_config_display function. Because "ports[pid].rx_conf"
and "ports[pid].tx_conf" maintained in testpmd application may be not the
value actually used by PMD driver. For instance, user do
From: Chengchang Tang
Currently, if nb_txd is not set, the txpkts is not allowed to be set
because the nb_txd is used to avoid the numer of segments exceed the Tx
ring size and the default value of nb_txd is 0. And there is a bug that
nb_txd is the global configuration for Tx ring size and the ri
This series are minor fixes for testpmd application.
Chengchang Tang (5):
app/testpmd: fix missing verification of port id
app/testpmd: fix VLAN offload configuration when config fail
app/testpmd: remove restriction on txpkts set
app/testpmd: fix packet header in txonly mode
app/testpmd:
From: Chengchang Tang
To set Tx vlan offloads, it is required to stop port firstly. But before
checking whether the port is stopped, the port id entered by the user
is not checked for validity. When the port id is illegal, it would lead
to a segmentation fault since it attempts to access a member
From: Chengchang Tang
In txonly forward mode, the packet header is fixed by the initial
setting, including the packet length and checksum. So when the packets
varies, this may cause a packet header error. Currently, there are two
methods in txonly mode to randomly change the packets.
1. Set txspl
From: Chengchang Tang
When failing to configure VLAN offloads after the port was started, there
is no need to update the port configuration. Currently, when user
configure an unsupported VLAN offloads and fails, and then restart the
port, it will fails since the configuration has been refreshed.
From: Chengchang Tang
The number of desc is a per queue configuration. But in the check function,
nb_txd & nb_rxd are used to check whether the desc_id is valid. nb_txd &
nb_rxd are the global configuration of number of desc. If the queue
configuration is changed by cmdline liks: "port config xx
On 9/22/2020 6:20 PM, Kevin Laatz wrote:
Add a check for the return value of the sscanf call in
parse_internal_args(), returning an error if we don't get the expected
result.
Coverity issue: 362049
Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API")
Cc: sta...@dpdk.org
Signed-off
Move feature bit settings in device start out as an standalone
function, so that feature bit could be negotiated at device
feature_ok status.
Signed-off-by: Maxime Coquelin
---
.../net/virtio/virtio_user/virtio_user_dev.c | 50 ---
.../net/virtio/virtio_user/virtio_user_dev.h |
Set proper payload size for set/get status message. The payload
size varies according to backend types.
Signed-off-by: Maxime Coquelin
Signed-off-by: Patrick Fu
---
.../net/virtio/virtio_user/virtio_user_dev.c | 34 +--
1 file changed, 23 insertions(+), 11 deletions(-)
diff --
vhost-vDPA is a new virtio backend type introduced by vDPA kernel
framework, which provides abstruction to the vDPA devices and
exposes an unified control interface through a char dev.
This patch adds support to the vhost-vDPA backend. As similar to
the existing vhost kernel backend, a set of virt
Hello Lukasz,
On Wed, Sep 23, 2020 at 3:25 PM Lukasz Wojciechowski
wrote:
>
> During review and verification of the patch created by Sarosh Arif:
> "test_distributor: prevent memory leakages from the pool" I found out
> that running distributor unit tests multiple times in a row causes fails.
> S
When sending set status message, move protocol feature check
to vhost_user to be compatible with different backend types.
Signed-off-by: Maxime Coquelin
---
drivers/net/virtio/virtio_user/vhost_user.c | 6 +-
drivers/net/virtio/virtio_user/virtio_user_dev.c | 6 --
2 files changed,
Backend type is determined by checking char-device major numbers
Signed-off-by: Maxime Coquelin
Signed-off-by: Adrian Moreno
---
.../net/virtio/virtio_user/virtio_user_dev.h | 1 +
drivers/net/virtio/virtio_user_ethdev.c | 48 +--
2 files changed, 45 insertions(+), 4 del
vhost-vDPA is a new vhost backend type introduced by vDPA kernel
framework, which provides abstruction to the vDPA devices and
exposes to userspace a unified control interface through char devs.
This patch set adds vhost-vdpa backend type to the virtio_user.
A set of vhost-vdpa specific ops callba
From: Adrian Moreno
This is a preparation patch with no functional change.
Use an enum instead of a boolean for the backend type.
Move the detection logic to the ethdev layer (where it is needed for the
first time).
The virtio_user_dev stores the backend type in the virtio_user_dev
struct so the
Add DMA map/unmap callbacks to the virtio_user pmd, which could
be leveraged by vdev bus driver to map memory for backend
devices with DMA capability.
Signed-off-by: Maxime Coquelin
---
drivers/net/virtio/virtio_user/vhost.h | 4 ++
drivers/net/virtio/virtio_user_ethdev.c | 54
Add DMA map/unmap operation callbacks to the vdev bus, which
could be used by DMA capable vdev drivers.
Signed-off-by: Maxime Coquelin
---
drivers/bus/vdev/rte_bus_vdev.h | 46 +++--
drivers/bus/vdev/vdev.c | 52 +
2 files changed,
HI Guys ,
I am trying to use a DPDK based *ipsec-secgw application*. Can anyone
please provide me with all the configurations, setup/topology and about the
NIC drivers.
I already went through the documentation of dpdk, but I am seeing several
issues regarding ipsec-secgw applications.
Thanks,
Ro
This patch adds required bit to handle VF FLR
indication from Management FW (MFW) of the device
With that VFs were able to load in VM (VF attached as PCI
passthrough to the guest VM) followed by FLR successfully
Updated the docs/guides with the feature support
Signed-off-by: Manish Chopra
Signe
This patch adds necessary infrastructure support (required to handle
messages from VF and sending ramrod on behalf of VF's configuration
request from alarm handler context) to start/load the VF-PMD driver
instance on top of PF-PMD driver instance.
Signed-off-by: Manish Chopra
Signed-off-by: Igor
This patch configures VFs with random mac if no MAC is
provided by the PF/bulletin. This also adds required bulletin
APIs by PF-PMD driver to communicate LINK properties/changes to
the VFs through bulletin update mechanism.
With these changes, VF-PMD instance is able to run
fastpath over PF-PMD dr
This patch defines various PCI config space access APIs
in order to read and find IOV specific PCI capabilities.
With these definitions implemented, it enables the base
driver to do SR-IOV specific initialization and HW specific
configuration required from PF-PMD driver instance.
Signed-off-by: M
On 9/25/2020 11:40 AM, Somnath Kotur wrote:
Check for num_rep before invoking rep port probe.
Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
Signed-off-by: Somnath Kotur
Reviewed-by: Venkat Duvvuru
Reviewed-by: Ferruh Yigit
Applied to dpdk-next-net/main, thanks.
By adding generic API, this patch removes individual
functions/defines implemented by drivers to find extended
PCI capabilities.
Signed-off-by: Manish Chopra
Signed-off-by: Igor Russkikh
Reviewed-by: Gaetan Rivet
---
drivers/bus/pci/pci_common.c | 43 ++
drivers/b
Based on number of VFs enabled at PCI, PF-PMD driver instance
enables/configures those VFs from hardware perspective, such
that in later patches they could get required HW access to
communicate with PFs for slowpath configuration and run the
fastpath themsleves.
This patch also add two new qede IO
Hi,
This series adds SR-IOV PF pmd driver support to have VF pmd
driver work over PF pmd driver instances in order to run the
adapter completely under DPDK environment for one of the use
cases like ovs-dpdk.
This is very initial bring-up with following testing covered -
* Enable/Disable SR-IOV V
On 25-Sep-20 3:14 AM, Hyong Youb Kim wrote:
When the BAR contains MSI-X table, pci_vfio_mmap_bar() tries to skip
the table and map the rest. "map around it" is the phrase used in the
source. The function splits the BAR into two regions: the region
before the table (first part or memreg[0]) and th
From: Yunjian Wang
This checks the return value from the function
rte_vhost_driver_start.
Coverity issue: 362027
Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
examples/vhost_blk/vhost_blk.c | 6 +-
1 file cha
1 - 100 of 164 matches
Mail list logo
