On Fri, 25 Sep 2020 08:36:06 -0700 Ajit Khaparde <ajit.khapa...@broadcom.com> wrote:
> > > > WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment > > #264: FILE: drivers/net/hns3/hns3_ethdev.c:5601: > > + /* fallthrough */ > Try /* FALLTHROUGH */ That won't work either. This is a new warning from upstream Linux kernel checkpatch. The Linux kernel has converted code to use a new macro. The warning should be silenced by the DPDK checkpatch script. diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 78a408ef9823..923ff6f7d9ee 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\ SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\ LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ -NEW_TYPEDEFS,COMPARISON_TO_NULL" +NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH" options="$options $DPDK_CHECKPATCH_OPTIONS"
