Re: [dpdk-dev] [PATCH] net/bnxt: fix variable size of port id

2020-09-02 Thread Xiao, QimaiX
Tested-by: Xiao, Qimai Regards, Xiao Qimai > -Original Message- > From: dev On Behalf Of Chenbo Xia > Sent: Wednesday, August 5, 2020 1:42 AM > To: dev@dpdk.org > Cc: ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; > kishore.padmana...@broadcom.com; > venkatkumar.duvv...@broadco

Re: [dpdk-dev] [RFC v1 0/2] Add device emulation support in DPDK

2020-09-02 Thread Xia, Chenbo
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, September 3, 2020 5:11 AM > To: Xia, Chenbo > Cc: dev@dpdk.org; Ding, Xuan ; Lu, Xiuchun > ; Liang, Cunming ; Liu, > Changpeng ; Wang, Zhihong > ; Stephen Hemminger ; > Richardson, Bruce ; Burakov, Anatoly > ; davi

Re: [dpdk-dev] [PATCH 2/2] build: find max lcore programmatically

2020-09-02 Thread Juraj Linkeš
> -Original Message- > From: dev On Behalf Of Dharmik Thakkar > Sent: Wednesday, August 26, 2020 6:56 AM > To: Jerin Jacob > Cc: tho...@monjalon.net; dpdk-dev ; nd > Subject: Re: [dpdk-dev] [PATCH 2/2] build: find max lcore programmatically > > > > > On Aug 25, 2020, at 11:47 PM, Je

[dpdk-dev] [PATCH] security: allow application to specify UDP ports to PMD

2020-09-02 Thread Tejasree Kondoj
Add UDP source and destination ports in ipsec_xform to allow application to specify ports to be used for IPsec UDP encapsulation as they are dynamically changed by NAT in between. Also adding an extra flag to indicate whether PMD needs to perform encapsulation header verification in case of inbound

[dpdk-dev] [PATCH v3 15/15] net/i40e/base: update version

2020-09-02 Thread Guinan Sun
Update base code version in readme. Signed-off-by: Guinan Sun Acked-by: Jeff Guo --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 6baca4360..6af299311 100644 --- a/drivers/net/i

[dpdk-dev] [PATCH v3 14/15] net/i40e/base: fix PHY config param when enabling EEE

2020-09-02 Thread Guinan Sun
The i40e_enable_eee function did not copy phy_type_ext field from current PHY configuration retrieved with Get PHY Abilities AQ. It caused a misconfiguration of the PHY on devices supporting 2.5 and 5G speeds and prevented establishing link when only those speeds were selected for advertisement. F

[dpdk-dev] [PATCH v3 11/15] net/i40e/base: add support for Minimum Rollback Revision

2020-09-02 Thread Guinan Sun
add support for Minimum Rollback Revision. Signed-off-by: Przemyslaw Ciesielski Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_adminq_cmd.h | 18 +++ drivers/net/i40e/base/i40e_common.c | 29 + drivers/net/i40e/base/i40e_prototype.h | 4

[dpdk-dev] [PATCH v3 13/15] net/i40e/base: add EEE LPI status check for X722 adapters

2020-09-02 Thread Guinan Sun
Add reading LPI (low power idle) status for supported X722 devices. If adapter's PHY supports EEE in current mode (device ID + link speed), LPI status is read from PHY Clause 45 PCS status register. Signed-off-by: Dawid Lukwinski Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_common.c

[dpdk-dev] [PATCH v3 12/15] net/i40e/base: fix Rx only mode for unicast promisc on VLAN

2020-09-02 Thread Guinan Sun
Set promiscuous mode to rx traffic only if VSI has VLANs configured. Rename misleading PROMISC_TX bit to proper name. Added I40E_AQC_SET_VSI_PROMISC_RX_ONLY during VSI unicast promiscuous mode configuration with port VLAN. Aligned unicast promiscuous with VLAN to the one without VLAN. Previously ot

[dpdk-dev] [PATCH v3 09/15] net/i40e/base: enable pipe monitor thresholds

2020-09-02 Thread Guinan Sun
Enable several registers and defines for software controlled DCB, particularly around the receive pipe monitor configuration which is necessary to help ports achieve the right throughput under load in several different configurations. Signed-off-by: Jesse Brandeburg Signed-off-by: Guinan Sun ---

[dpdk-dev] [PATCH v3 08/15] net/i40e/base: add VLAN field for input set

2020-09-02 Thread Guinan Sun
Add VLAN bit used during flow director programming, as a part of input set for HW. Signed-off-by: Przemyslaw Patynowski Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_type.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/bas

[dpdk-dev] [PATCH v3 10/15] net/i40e/base: fix missing function header arguments

2020-09-02 Thread Guinan Sun
Some arguments in function headers were forgotten, and found by automated testing. Fix them by adding the argument descriptions. Fixes: 0d9d27bb8684 ("i40e/base: prepare local LLDP MIB in TLV") Cc: sta...@dpdk.org Signed-off-by: Jesse Brandeburg Signed-off-by: Guinan Sun --- drivers/net/i40e/b

[dpdk-dev] [PATCH v3 07/15] net/i40e/base: replace AQ command for NVM update

2020-09-02 Thread Guinan Sun
Add AQ command "NVM update in process" to replace the original AQ command "NVM progress". Signed-off-by: Jaroslaw Ilgiewicz Signed-off-by: Guinan Sun Acked-by: Jeff Guo --- drivers/net/i40e/base/i40e_adminq_cmd.h | 12 +- drivers/net/i40e/base/i40e_common.c | 53 +++

[dpdk-dev] [PATCH v3 05/15] net/i40e/base: fix possible uninitialized variable

2020-09-02 Thread Guinan Sun
Fix possible uninitialized variable in i40e in the i40e_get_lpi_counters function. Fixes: 429bdc0cd967 ("net/i40e/base: add function to read LPI counters") Cc: sta...@dpdk.org Signed-off-by: Adam Ludkiewicz Signed-off-by: Guinan Sun Acked-by: Jeff Guo --- drivers/net/i40e/base/i40e_common.c |

[dpdk-dev] [PATCH v3 06/15] net/i40e/base: support unused ports disabling

2020-09-02 Thread Guinan Sun
This patch adds support for disabling unused ports. Signed-off-by: Damian Milosek Signed-off-by: Guinan Sun Acked-by: Jeff Guo --- drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + drivers/net/i40e/base/i40e_common.c | 6 ++ drivers/net/i40e/base/i40e_type.h | 1 + 3 files changed,

[dpdk-dev] [PATCH v3 04/15] net/i40e/base: update FW API version to 1.12

2020-09-02 Thread Guinan Sun
Upcoming FW increment API version to 1.12 due to new bit and new fields in the Replace Cloud Filters AQ command. Signed-off-by: Jacek Naczyk Signed-off-by: Guinan Sun Acked-by: Jeff Guo --- drivers/net/i40e/base/i40e_adminq_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH v3 03/15] net/i40e/base: add new custom cloud filter types

2020-09-02 Thread Guinan Sun
This patch adds the new filter types needed for custom cloud filters. These custom cloud filters will route traffic to VFs based on the dst IP for both tunneled and non-tunneled packets. Signed-off-by: Harshitha Ramamurthy Signed-off-by: Guinan Sun Acked-by: Jeff Guo --- drivers/net/i40e/base/

[dpdk-dev] [PATCH v3 00/15] update i40e base code

2020-09-02 Thread Guinan Sun
update i40e base code. source code of i40e driver: cid-i40e.2020.08.27.tar.gz dropped by the team which develop basic drivers for any i40e NIC. changelog in ND share repo: >From fc99a1143d3f ("i40e-shared: FEC on/off support flag for X722") To 1a82d59f0797 ("i40e-shared: Fix PHY configuration par

[dpdk-dev] [PATCH v3 01/15] net/i40e/base: enable FEC on/off flag setting for X722

2020-09-02 Thread Guinan Sun
Starting with API version 1.10 firmware for X722 devices has ability to change FEC settings in PHY. Code added in this patch checks API version and sets appropriate capability flag. Signed-off-by: Dawid Lukwinski Signed-off-by: Guinan Sun Acked-by: Jeff Guo --- drivers/net/i40e/base/i40e_admin

[dpdk-dev] [PATCH v3 02/15] net/i40e/base: add PTYPE definition

2020-09-02 Thread Guinan Sun
Add I40E_RX_PTYPE_PARSER_ABORTED definition, so i40e driver will know opcode for parser aborted packets. Without this definition driver would have to rely on magic numbers. Signed-off-by: Przemyslaw Patynowski Signed-off-by: Guinan Sun Acked-by: Jeff Guo --- drivers/net/i40e/base/i40e_type.h |

[dpdk-dev] [RFC] ethdev: make rte flow API thread safe

2020-09-02 Thread Suanming Mou
Currently, the rte flow functions are not defined as thread safety. DPDK applications either call the functions in single thread or add locks around the functions for the critical section. For PMDs support the flow operations thread safe natively, the redundant protection in application hurts the

Re: [dpdk-dev] [PATCH v4 0/3] fixes for device event

2020-09-02 Thread wangyunjian
Hi, Ferruh Yigit & David Marchand Could you please give any suggestion? Thanks, Yunjian > -Original Message- > From: wangyunjian > Sent: Friday, July 3, 2020 5:44 PM > To: dev@dpdk.org > Cc: jia@intel.com; Lilijun (Jerry) ; xudingke > ; wangyunjian > Subject: [dpdk-dev] [PATCH v4 0/

Re: [dpdk-dev] [PATCH v6 1/8] net/dpaa: add support for fmlib in dpdk

2020-09-02 Thread Hemant Agrawal
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, September 2, 2020 7:02 PM > >> On 9/1/2020 1:36 PM, Hemant Agrawal wrote: > >>> DPAA platorm MAC interface is known as FMAN i.e. Frame Manager. > >>> There are two ways to control it. > >>> 1. Statically configure the

Re: [dpdk-dev] [PATCH v2 0/4] minor fixes for testpmd

2020-09-02 Thread Wei Hu (Xavier)
Hi, all   Are there any comment? Thanks Xavier On 2020/8/20 9:42, Wei Hu (Xavier) wrote: This series are minor fixes for testpmd application. Chengchang Tang (3): app/testpmd: fix missing verification of port id app/testpmd: fix VLAN offload configuration when config fail app/testpm

Re: [dpdk-dev] [PATCH v6 0/2] update CPU flags for arm64 platform

2020-09-02 Thread Wei Hu (Xavier)
Hi, all   Are there any other comments? Thanks Xavier On 2020/8/19 18:56, Wei Hu (Xavier) wrote: This series updates CPU flags for arm64 platform. Wei Hu (Xavier) (2): eal/arm64: update CPU flags test/cpuflag: add new flags for ARM64 platform app/test/test_cpuflags.c

Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-09-02 Thread Phil Yang
> > > > > > > > > > > > > > > > @@ -1790,9 +1792,9 @@ mlx5_rx_burst_mprq(void > > *dpdk_rxq, > > > > > > struct > > > > > > > > > > rte_mbuf **pkts, uint16_t pkts_n) void *buf_addr; > > > > > > > > > > > > > > > > > > > > /* Increment the refcnt of the whole chunk. */ > > > > > > > > > > -rte_at

[dpdk-dev] [PATCH v4] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-09-02 Thread Phil Yang
Use c11 atomics with RELAXED ordering instead of the rte_atomic ops which enforce unnecessary barriers on aarch64. Signed-off-by: Phil Yang --- v4: Remove the unnecessary ACQUIRE barrier in rx burst path. (Honnappa) v3: Split from the patchset: http://patchwork.dpdk.org/cover/68159/ drivers/ne

Re: [dpdk-dev] [PATCH v3 05/11] baseband/acc100: add LDPC processing functions

2020-09-02 Thread Xu, Rosen
Hi, > -Original Message- > From: Chautru, Nicolas > Sent: Sunday, August 30, 2020 2:01 > To: Xu, Rosen ; dev@dpdk.org; akhil.go...@nxp.com > Cc: Richardson, Bruce > Subject: RE: [dpdk-dev] [PATCH v3 05/11] baseband/acc100: add LDPC > processing functions > > Hi Rosen, > > > From: Xu, R

Re: [dpdk-dev] [PATCH v3 04/11] baseband/acc100: add queue configuration

2020-09-02 Thread Xu, Rosen
Hi, > -Original Message- > From: Chautru, Nicolas > Sent: Sunday, August 30, 2020 1:48 > To: Xu, Rosen ; dev@dpdk.org; akhil.go...@nxp.com > Cc: Richardson, Bruce > Subject: RE: [dpdk-dev] [PATCH v3 04/11] baseband/acc100: add queue > configuration > > Hi, > > > From: Xu, Rosen > > >

Re: [dpdk-dev] [PATCH] net/ixgbe: fix vf reset hw error handling

2020-09-02 Thread Yang, Qiming
Hi, > -Original Message- > From: Yang, SteveX > Sent: 2020年9月2日 8:44 > To: dev@dpdk.org > Cc: Zhao1, Wei ; Guo, Jia ; Yang, > Qiming ; Yang, SteveX > Subject: [PATCH] net/ixgbe: fix vf reset hw error handling > > The PF control message will interrupt the assigning MAC address for VF whe

Re: [dpdk-dev] [PATCH v3 02/11] baseband/acc100: add register definition file

2020-09-02 Thread Xu, Rosen
Hi, > -Original Message- > From: Chautru, Nicolas > Sent: Sunday, August 30, 2020 1:40 > To: Xu, Rosen ; dev@dpdk.org; akhil.go...@nxp.com > Cc: Richardson, Bruce > Subject: RE: [dpdk-dev] [PATCH v3 02/11] baseband/acc100: add register > definition file > > Hi Rosen, > > > From: Xu, Ro

Re: [dpdk-dev] [PATCH] net/iavf: fix mismatch command

2020-09-02 Thread Yang, Qiming
> -Original Message- > From: Jiang, JunyuX > Sent: 2020年9月1日 16:15 > To: dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing > ; > Yang, Qiming ; Jiang, JunyuX > ; sta...@dpdk.org > Subject: [PATCH] net/iavf: fix mismatch command > > The "command mismatch" warning shouldn't be triggered by

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure

2020-09-02 Thread Chengchang Tang
Hi, Matan On 2020/9/2 18:30, Matan Azrad wrote: > Hi Chengchang > > From: Chengchang Tang >> Hi, Matan >> >> On 2020/9/2 15:19, Matan Azrad wrote: >>> >>> Hi Chengchang >>> >>> From: Chengchang Tang Hi, Matan On 2020/9/1 23:33, Matan Azrad wrote: > > Hi Chengchang > >>>

Re: [dpdk-dev] [PATCH 00/11] updates for hns3 PMD driver

2020-09-02 Thread Wei Hu (Xavier)
Hi, all    Are there any comments? Thanks Xavier On 2020/8/25 19:52, Wei Hu (Xavier) wrote: This series are features and fixes for hns3 PMD driver. Huisong Li (3): net/hns3: replace private macro with RTE MAX net/hns3: fix default MAC addr from firmware net/hns3: fix some incomplete

Re: [dpdk-dev] [PATCH v3 0/4] bnxt patches

2020-09-02 Thread Ajit Khaparde
On Tue, Sep 1, 2020 at 10:31 PM Ajit Khaparde wrote: > fixes and cleanups in bnxt TRUFlow > > v1->v2: updated signed-off tags in commit logs. > v2->v3: update commit logs based on review comments. > Patchset applied to dpdk-next-net-brcm. > > Kishore Padmanabha (2): > net/bnxt: configure loop

Re: [dpdk-dev] [PATCH 0/6] bnxt bug fixes

2020-09-02 Thread Ajit Khaparde
On Thu, Aug 27, 2020 at 9:46 PM Kalesh A P < kalesh-anakkur.pura...@broadcom.com> wrote: > From: Kalesh AP > > This patchset contains bnxt bug fixes. > Patchset applied to dpdk-next-net-brcm. Thanks > > Kalesh AP (5): > net/bnxt: fix endianness while setting L4 destination port > net/bnxt:

Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-09-02 Thread Alexander Kozyrev
> > > > > > > > > > > > > > @@ -1790,9 +1792,9 @@ mlx5_rx_burst_mprq(void > *dpdk_rxq, > > > > > struct > > > > > > > > > rte_mbuf **pkts, uint16_t pkts_n) void *buf_addr; > > > > > > > > > > > > > > > > > > /* Increment the refcnt of the whole chunk. */ > > > > > > > > > -rte_atomic16_add_retu

Re: [dpdk-dev] [RFC v1 0/2] Add device emulation support in DPDK

2020-09-02 Thread Thomas Monjalon
14/08/2020 21:16, Chenbo Xia: > Background & Motivation > --- > In order to reduce the attack surface, QEMU community is disaggregating QEMU > by > removing part of device emulation from it. The disaggregated/multi-process > QEMU > is using VFIO-over-socket/vfio-user as the ma

Re: [dpdk-dev] [EXTERNAL] 19.11.4 patches review and test

2020-09-02 Thread Abhishek Marathe
Hi Luca, We have tested 19.11.4 and no issues found except known issues. 1. Issue with CX-3/MLX-4 driver with ibquery_pkey() failed. 2. Issue with hot-removal of VF driver. we are tracking both the issues. Report: DPDK https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.o

Re: [dpdk-dev] [PATCH] ethdev: fix RSS flow expansion in case of mismatch

2020-09-02 Thread Ferruh Yigit
On 7/27/2020 1:57 PM, Dekel Peled wrote: > Function rte_flow_expand_rss() is used to expand a flow rule with > partial pattern into several rules, to ensure all relevant packets > are matched. > It uses utility function rte_flow_expand_rss_item_complete(), to check > if the last valid item in the f

[dpdk-dev] [PATCH] net/vhost: fix xstats wrong after clearing stats

2020-09-02 Thread David Christensen
The PMD API allows stats and xstats values to be cleared separately. This is a problem for the vhost PMD since some of the xstats values are derived from existing stats values. For example: testpmd> show port xstats all ... tx_unicast_packets: 17562959 ... testpmd> clear port stats all ... show p

Re: [dpdk-dev] [PATCH v1 0/4] Remove RTE_MACHINE_CPUFLAG_ macros

2020-09-02 Thread David Christensen
On 9/2/20 3:43 AM, Radu Nicolau wrote: Remove RTE_MACHINE_CPUFLAG_ macros from the build. Deprecation notice sent, pasted here for reference: build macros: The macros defining RTE_MACHINE_CPUFLAG_* will be removed from the build. The information provided by these macros is available thr

[dpdk-dev] [PATCH v2] app/testpmd: fix name of bitrate library in meson build

2020-09-02 Thread Bruce Richardson
The bitrate library in DPDK is actually in a "bitratestats" directory, so that is used by meson for the macro and library name. Therefore, we need to update references to RTE_LIBRTE_BITRATE to RTE_LIBRTE_BITRATESTATS in testpmd to have it found. Rather than supporting both defines, since make is be

[dpdk-dev] [PATCH] app/testpmd: fix name of bitrate library in meson build

2020-09-02 Thread Bruce Richardson
The bitrate library in DPDK is actually in a "bitratestats" directory, so that is used by meson for the macro and library name. Therefore, we need to update references to RTE_LIBRTE_BITRATE to RTE_LIBRTE_BITRATESTATS in testpmd to have it found. Rather than supporting both defines, since make is be

Re: [dpdk-dev] [[PATCH v3 3/4] pdump: convert timestamp to nanoseconds on Rx path

2020-09-02 Thread Pattan, Reshma
> -Original Message- > + rte_eth_read_clock(port, &start_cycles); > + rte_eth_get_clock_freq(port, &hz); Do you need to check return value of these calls to handle -ENOTSUP? And avoid timestamping marking. If -ENOTSUP, then hz value is 0 and usi

Re: [dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators

2020-09-02 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, September 2, 2020 4:02 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX > > Subject: [PATCH] cryptodev: remove crypto list end enumerators > > This patch removes enumerators RTE_C

Re: [dpdk-dev] [PATCH v2] avoid libfdt checks adding full paths to pkg-config

2020-09-02 Thread David Marchand
On Wed, Sep 2, 2020 at 2:39 PM Christian Ehrhardt wrote: > > The checks for libfdt try dependency() first which would only work if > a pkg-config would be present but libfdt has none. > Then it probes for the lib path itself via cc.find_library. > > But later it adds the result of either probe to

[dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators

2020-09-02 Thread Arek Kusztal
This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END, RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent some problems that may arise when adding new crypto algorithms. Signed-off-by: Arek Kusztal --- lib/librte_cryptodev/rte_crypto_sym.h | 12 +++- 1 file changed, 3 inse

Re: [dpdk-dev] [PATCH] usertools: add huge page setup script

2020-09-02 Thread Stephen Hemminger
On Wed, 2 Sep 2020 10:55:07 +0100 Bruce Richardson wrote: > On Tue, Sep 01, 2020 at 09:56:43AM -0700, Stephen Hemminger wrote: > > This is an improved version of the setup of huge pages > > bases on earlier DPDK setup. Differences are: > >* it autodetects NUMA vs non NUMA > >* it allows s

Re: [dpdk-dev] [PATCH] rte_log: make rte_logs private

2020-09-02 Thread Stephen Hemminger
On Wed, 2 Sep 2020 10:40:19 +0200 David Marchand wrote: > On Fri, Aug 28, 2020 at 12:54 AM Stephen Hemminger > wrote: > > > > As announced in earlier releases, rte_logs can now be made > > internal to eal_common_log. > > I had prepared this cleanup before my PTO and was about to send it. > Ju

Re: [dpdk-dev] [PATCH] drivers/common: mark symbols as internal

2020-09-02 Thread Ferruh Yigit
On 9/2/2020 10:59 AM, David Marchand wrote: > Now that we have the internal tag, let's avoid confusion with exported > symbols in common drivers that were using the experimental tag as a > workaround. > There is also no need to put internal API symbols in the public stable > ABI. > > Signed-off-by

Re: [dpdk-dev] [PATCH v4 2/2] Add l2reflect measurement application

2020-09-02 Thread Henning Schild
Am Wed, 02 Sep 2020 10:30:22 +0200 schrieb Thomas Monjalon : > 02/09/2020 09:56, Henning Schild: > > Am Tue, 01 Sep 2020 17:07:38 +0200 > > schrieb Thomas Monjalon : > > > > > 28/08/2020 16:22, Henning Schild: > > > > Thomas, > > > > > > > > what is the state on this one? Any more steps to t

Re: [dpdk-dev] [PATCH v4 2/2] Add l2reflect measurement application

2020-09-02 Thread Henning Schild
Am Tue, 01 Sep 2020 17:07:38 +0200 schrieb Thomas Monjalon : > 28/08/2020 16:22, Henning Schild: > > Thomas, > > > > what is the state on this one? Any more steps to take or people to > > involve? > > I can try adding some key people in Cc list, > while doing a quick review. > > > > I first sh

Re: [dpdk-dev] [PATCH v2] avoid libfdt checks adding full paths to pkg-config

2020-09-02 Thread Luca Boccassi
On Wed, 2020-09-02 at 14:39 +0200, Christian Ehrhardt wrote: > The checks for libfdt try dependency() first which would only work if > a pkg-config would be present but libfdt has none. > Then it probes for the lib path itself via cc.find_library. > > But later it adds the result of either probe t

Re: [dpdk-dev] [PATCH v6 1/8] net/dpaa: add support for fmlib in dpdk

2020-09-02 Thread Ferruh Yigit
On 9/2/2020 6:15 AM, Hemant Agrawal wrote: > Hi Ferruh, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, September 1, 2020 9:19 PM >> To: Hemant Agrawal ; dev@dpdk.org >> Subject: Re: [PATCH v6 1/8] net/dpaa: add support for fmlib in dpdk >> >> On 9/1/2020 1:36 PM, Hemant A

Re: [dpdk-dev] [PATCH] avoid libfdt checks adding full paths to pkg-config

2020-09-02 Thread Christian Ehrhardt
On Wed, Sep 2, 2020 at 1:25 PM Bruce Richardson wrote: > > On Wed, Sep 02, 2020 at 01:10:30PM +0200, Christian Ehrhardt wrote: > > The checks for libfdt try dependency() first which would only work if > > a pkg-config would be present but libfdt has none. > > Then it probes for the lib path itself

[dpdk-dev] [PATCH v2] avoid libfdt checks adding full paths to pkg-config

2020-09-02 Thread Christian Ehrhardt
The checks for libfdt try dependency() first which would only work if a pkg-config would be present but libfdt has none. Then it probes for the lib path itself via cc.find_library. But later it adds the result of either probe to ext_deps which ends up in build and also the resulting pkg-config to

[dpdk-dev] [PATCH] net/nfp: expand dev_infos_get callback function

2020-09-02 Thread Heinrich Kuhn
Report Rx and Tx descriptor related limitations in the nfp dev_info_get callback function. This commit also adds NFP_ALIGN_RING_DESC to replace a static integer value used during rx/tx queue setups to validate descriptor alignment. Cc: sta...@dpdk.org Signed-off-by: Heinrich Kuhn Signed-off-by:

Re: [dpdk-dev] [PATCH] doc: update pdump documentation

2020-09-02 Thread Pattan, Reshma
> -Original Message- > From: Pattan, Reshma > Sent: Monday, July 13, 2020 3:25 PM > To: dev@dpdk.org > Cc: Pattan, Reshma > Subject: [PATCH] doc: update pdump documentation > > Update the pdump library programmers guide and Howto doc with the use of > multi process channel replacing s

[dpdk-dev] [PATCH v2] regex/mlx5: add teardown flow to fastpath buffers

2020-09-02 Thread Yuval Avnery
From: Yuval Avnery Added missing code to free Input/Output buffers and memory registration. Also added calls to this code in case of error in the qp setup procedure. The rollback code itself did not handle rollback properly and did not check return value from the fastpath setup. Signed-off-by: Y

Re: [dpdk-dev] [PATCH] avoid libfdt checks adding full paths to pkg-config

2020-09-02 Thread Bruce Richardson
On Wed, Sep 02, 2020 at 01:10:30PM +0200, Christian Ehrhardt wrote: > The checks for libfdt try dependency() first which would only work if > a pkg-config would be present but libfdt has none. > Then it probes for the lib path itself via cc.find_library. > > But later it adds the result of either

Re: [dpdk-dev] [PATCH v1 4/4] doc: remove reference to RTE_MACHINE_CPUFLAG

2020-09-02 Thread Bruce Richardson
On Wed, Sep 02, 2020 at 10:43:43AM +, Radu Nicolau wrote: > RTE_MACHINE_CPUFLAG macros are replaced with predefined > compiler defines. > > Signed-off-by: Sean Morrissey > Signed-off-by: Radu Nicolau > --- > doc/guides/prog_guide/writing_efficient_code.rst | 2 +- > 1 file changed, 1 insert

Re: [dpdk-dev] [PATCH v2 0/7] Enhance rawdev APIs

2020-09-02 Thread Nipun Gupta
Series Acked-by: Nipun Gupta > -Original Message- > From: Bruce Richardson > Sent: Thursday, August 13, 2020 4:58 PM > To: Nipun Gupta ; Hemant Agrawal > > Cc: dev@dpdk.org; Bruce Richardson > Subject: [PATCH v2 0/7] Enhance rawdev APIs > > This patchset proposes some internal and ext

Re: [dpdk-dev] [PATCH v1 1/4] x86: change cpuflag macros to compiler macros

2020-09-02 Thread Bruce Richardson
On Wed, Sep 02, 2020 at 10:43:40AM +, Radu Nicolau wrote: > Replace use of RTE_MACHINE_CPUFLAG macros with regular compiler > macros. > I think it's worth noting in the commit log that the set of macros provided by the compilers are more complete than those provided by DPDK, and by not having

[dpdk-dev] [PATCH] avoid libfdt checks adding full paths to pkg-config

2020-09-02 Thread Christian Ehrhardt
The checks for libfdt try dependency() first which would only work if a pkg-config would be present but libfdt has none. Then it probes for the lib path itself via cc.find_library. But later it adds the result of either probe to ext_deps which ends up in build and also the resulting pkg-config to

Re: [dpdk-dev] [RFC] avoid libfdt checks adding full paths to pkg-config

2020-09-02 Thread Christian Ehrhardt
On Tue, Sep 1, 2020 at 6:16 PM Luca Boccassi wrote: > > On Tue, 2020-09-01 at 17:58 +0200, Christian Ehrhardt wrote: > > The checks for libfdt try dependency() first which would only work if > > a pkg-config would be present but libfdt has none. > > Then it probes for the lib path itself via cc.fi

Re: [dpdk-dev] [PATCH v2 37/37] doc: update quick build doc to remove make references

2020-09-02 Thread Laatz, Kevin
On 20/08/2020 13:41, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/build-sdk-quick.txt | 55 - 1 file changed, 21 insertions(+), 34 deletions(-)

Re: [dpdk-dev] [PATCH v2 36/37] doc: remove references to make in testpmd guides

2020-09-02 Thread Laatz, Kevin
On 20/08/2020 13:41, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/testpmd_app_ug/run_app.rst | 6 +++--- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 + 2 files

Re: [dpdk-dev] [PATCH v2 35/37] doc: remove reference to make in tools guides

2020-09-02 Thread Laatz, Kevin
On 20/08/2020 13:41, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/tools/comp_perf.rst| 10 ++--- doc/guides/tools/cryptoperf.rst | 20 +++-- doc/guides/tool

Re: [dpdk-dev] [PATCH v2 17/17] net: add checks for max SIMD bitwidth

2020-09-02 Thread Singh, Jasvinder
> -Original Message- > From: Power, Ciara > Sent: Thursday, August 27, 2020 5:13 PM > To: dev@dpdk.org > Cc: Power, Ciara ; Singh, Jasvinder > ; Olivier Matz > Subject: [PATCH v2 17/17] net: add checks for max SIMD bitwidth > > When choosing a vector path to take, an extra condition m

Re: [dpdk-dev] [EXTERNAL] 19.11.4 patches review and test

2020-09-02 Thread Luca Boccassi
On Tue, 2020-09-01 at 18:04 +, Abhishek Marathe wrote: > Hi Luca, > > We have tested 19.11.4 and no issues found except known issues. > 1. Issue with CX-3/MLX-4 driver with ibquery_pkey() failed. > 2. Issue with hot-removal of VF driver. > we are tracking both the issues. Thank you! Are thes

Re: [dpdk-dev] [PATCH v1 1/4] example/qos_sched: subport bandwidth dynmaic conf

2020-09-02 Thread Dharmappa, Savinay
Self NACK the patch. As I would like to merge the application series changes of patch with previous sent library changes patches series and have single patch series. Regards savinay -Original Message- From: Dharmappa, Savinay Sent: Wednesday, September 2, 2020 2:37 PM To: Dumitrescu,

[dpdk-dev] [PATCH v1 1/4] x86: change cpuflag macros to compiler macros

2020-09-02 Thread Radu Nicolau
Replace use of RTE_MACHINE_CPUFLAG macros with regular compiler macros. Signed-off-by: Sean Morrissey Signed-off-by: Radu Nicolau --- app/test/test_memcpy_perf.c | 8 config/x86/meson.build | 2 -- drivers/net/enic/Makefile | 2 +- drivers/

[dpdk-dev] [PATCH v1 3/4] ppc: change cpuflag macros to compiler macros

2020-09-02 Thread Radu Nicolau
Replace use of RTE_MACHINE_CPUFLAG macros with regular compiler macros. Signed-off-by: Sean Morrissey Signed-off-by: Radu Nicolau --- config/ppc/meson.build | 2 -- 1 file changed, 2 deletions(-) diff --git a/config/ppc/meson.build b/config/ppc/meson.build index aa7d73d11..0d8da87e6 100644 ---

[dpdk-dev] [PATCH v1 0/4] Remove RTE_MACHINE_CPUFLAG_ macros

2020-09-02 Thread Radu Nicolau
Remove RTE_MACHINE_CPUFLAG_ macros from the build. Deprecation notice sent, pasted here for reference: build macros: The macros defining RTE_MACHINE_CPUFLAG_* will be removed from the build. The information provided by these macros is available through standard compiler macros. For example,

[dpdk-dev] [PATCH v1 4/4] doc: remove reference to RTE_MACHINE_CPUFLAG

2020-09-02 Thread Radu Nicolau
RTE_MACHINE_CPUFLAG macros are replaced with predefined compiler defines. Signed-off-by: Sean Morrissey Signed-off-by: Radu Nicolau --- doc/guides/prog_guide/writing_efficient_code.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/writing_efficient_co

[dpdk-dev] [PATCH v1 2/4] arm: change cpuflag macros to compiler macros

2020-09-02 Thread Radu Nicolau
Replace use of RTE_MACHINE_CPUFLAG macros with regular compiler macros. Signed-off-by: Sean Morrissey Signed-off-by: Radu Nicolau --- app/test-pmd/macswap.c | 2 +- config/arm/meson.build | 6 -- drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- e

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure

2020-09-02 Thread Matan Azrad
Hi Chengchang From: Chengchang Tang > Hi, Matan > > On 2020/9/2 15:19, Matan Azrad wrote: > > > > Hi Chengchang > > > > From: Chengchang Tang > >> Hi, Matan > >> > >> On 2020/9/1 23:33, Matan Azrad wrote: > >>> > >>> Hi Chengchang > >>> > >>> Please see some question below. > >>> > >>> From: Chen

[dpdk-dev] [PATCH] net/ice: enable QINQ filter in switch

2020-09-02 Thread Qiming Yang
This patch enabled QINQ filter in switch filter. This code depend on base code update. Signed-off-by: Wei Zhao Signed-off-by: Qiming Yang --- drivers/net/ice/ice_generic_flow.c | 8 +++ drivers/net/ice/ice_generic_flow.h | 1 + drivers/net/ice/ice_switch_filter.c | 106 +++

Re: [dpdk-dev] [EXT] [PATCH] drivers/common: mark symbols as internal

2020-09-02 Thread Anoob Joseph
> -- > Now that we have the internal tag, let's avoid confusion with exported > symbols in common drivers that were using the experimental tag as a > workaround. > There is also no need to put internal API symbols in the public sta

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure

2020-09-02 Thread Chengchang Tang
Hi, Matan On 2020/9/2 15:19, Matan Azrad wrote: > > Hi Chengchang > > From: Chengchang Tang >> Hi, Matan >> >> On 2020/9/1 23:33, Matan Azrad wrote: >>> >>> Hi Chengchang >>> >>> Please see some question below. >>> >>> From: Chengchang Tang Add a field named rx_buf_size in rte_eth_rxq_info

Re: [dpdk-dev] [PATCH V1] testpmd: add eeprom/module eeprom display

2020-09-02 Thread Ferruh Yigit
On 9/1/2020 8:07 PM, David Liu wrote: > Change display message. > Add EEPROM dump command > "show port eeprom" > Add module EEPROM dump command > "show port module_eeprom" > Commands will dump the content of the > EEPROM/module EEPROM for the selected port. > > Signed-off-by: David Liu

[dpdk-dev] [PATCH] drivers/common: mark symbols as internal

2020-09-02 Thread David Marchand
Now that we have the internal tag, let's avoid confusion with exported symbols in common drivers that were using the experimental tag as a workaround. There is also no need to put internal API symbols in the public stable ABI. Signed-off-by: David Marchand --- Note: I noticed a patch from Haiyue

Re: [dpdk-dev] [PATCH] usertools: add huge page setup script

2020-09-02 Thread Bruce Richardson
On Tue, Sep 01, 2020 at 09:56:43AM -0700, Stephen Hemminger wrote: > This is an improved version of the setup of huge pages > bases on earlier DPDK setup. Differences are: >* it autodetects NUMA vs non NUMA >* it allows setting different page sizes > recent kernels support multiple siz

Re: [dpdk-dev] [PATCH] usertools: add huge page setup script

2020-09-02 Thread Ferruh Yigit
On 9/1/2020 5:56 PM, Stephen Hemminger wrote: > This is an improved version of the setup of huge pages > bases on earlier DPDK setup. Differences are: >* it autodetects NUMA vs non NUMA >* it allows setting different page sizes > recent kernels support multiple sizes. >* it accepts

[dpdk-dev] [PATCH v3 4/4] net/bnxt: fix VF representor port add

2020-09-02 Thread Ajit Khaparde
From: Venkat Duvvuru Fix VF representor port add when it's endpoint interface is down. While adding vf representor port to a bridge, vnic & svif information of vf representors endpoint(VF) would be needed to program default flow rules. However, if the endpoint interface is down when vf represento

[dpdk-dev] [PATCH v3 1/4] net/bnxt: configure loopback parif for egress flows

2020-09-02 Thread Ajit Khaparde
From: Kishore Padmanabha Configure loopback parif for full offload egress flows. PARIF is handler to a partition of the physical port. The full offload egress flows for the VF rep interface must use loopback parif to offload missed flows. The miss flow path for the VF rep interface has to be loop

[dpdk-dev] [PATCH v3 3/4] net/bnxt: cleanups and checks ULP context allocation

2020-09-02 Thread Ajit Khaparde
From: Somnath Kotur Set ulp_ctx explicitly to NULL in ulp_ctx_deinit() so that representor init is aborted if parent ulp context is not initialized. Also check for the same before creation of port default rules. Additional checks added in VF rep dev ops for proper parent dev initialization, to av

[dpdk-dev] [PATCH v3 0/4] bnxt patches

2020-09-02 Thread Ajit Khaparde
fixes and cleanups in bnxt TRUFlow v1->v2: updated signed-off tags in commit logs. v2->v3: update commit logs based on review comments. Kishore Padmanabha (2): net/bnxt: configure loopback parif for egress flows net/bnxt: lookup default action record parif Somnath Kotur (1): net/bnxt: clea

[dpdk-dev] [PATCH v3 2/4] net/bnxt: lookup default action record parif

2020-09-02 Thread Ajit Khaparde
From: Kishore Padmanabha The lookup default action record parif table is updated to catch the miss path for the entries in the exact match table. PARIF is handler to a partition of the physical port. The lookup parif table contains entries for each incoming interface the default action for the mi

Re: [dpdk-dev] [PATCH] gro: add UDP GRO and VXLAN UDP GRO support

2020-09-02 Thread yang_y_yi
Thanks Jiayu, I have removed it and sent out v3, please help ack if no more comments. At 2020-09-02 14:26:37, "Hu, Jiayu" wrote: GRO lib requires users to provide correct mbuf->l2_len/packet_type etc.. This is for avoiding parsing packet headers. If we believe users give correct packet_type,

[dpdk-dev] [PATCH V3 2/2] gro: add VXLAN UDP GRO support

2020-09-02 Thread yang_y_yi
From: Yi Yang VXLAN UDP GRO can help improve VM-to-VM UDP performance when VM is enabled UFO or GSO, GRO must be supported if GSO or UFO is enabled, otherwise, performance gain will be hurt. With this enabled in DPDK, OVS DPDK can leverage it to improve VM-to-VM UDP performance, this will make s

[dpdk-dev] [PATCH V3 0/2] gro: add UDP GRO and VXLAN UDP GRO support

2020-09-02 Thread yang_y_yi
From: Yi Yang In case that UFO or GSO is enabled, GRO is very necessary, especially for UDP, it is more so. Many NICs can't support VXLAN UDP UFO/USO and VLAN UFO/USO, so UDP performance improvement depends on GSO and GRO to a great extent. This patch series added VLAN UDP GRO and VXLAN UDP GRO

[dpdk-dev] [PATCH V3 1/2] gro: add UDP GRO support

2020-09-02 Thread yang_y_yi
From: Yi Yang UDP GRO can help improve VM-to-VM UDP performance when VM is enabled UFO or GSO, GRO must be supported if GSO or UFO is enabled, otherwise, performance gain will be hurt. With this enabled in DPDK, OVS DPDK can leverage it to improve VM-to-VM UDP performance, this will make sure IP

[dpdk-dev] [PATCH v1 1/4] example/qos_sched: subport bandwidth dynmaic conf

2020-09-02 Thread Savinay Dharmappa
qos sched application uses the new apis introduced as part of dynamic configuration of subport bandwidth to configure the deafult subport bandwidth profile while buidling the hirerachical scheduler. Signed-off-by: Savinay Dharmappa --- examples/qos_sched/cfg_file.c | 158 +++

[dpdk-dev] [PATCH v1 3/4] drivers/softnic: subport bandwidth profile config

2020-09-02 Thread Savinay Dharmappa
softnic driver uses the new apis introduced as part of dynamic configuration of subport bandwidth to configure the deafult subport bandwidth profile while buidling the hirerachical scheduler. Signed-off-by: Savinay Dharmappa --- drivers/net/softnic/rte_eth_softnic_internals.h | 9 + drivers/ne

[dpdk-dev] [PATCH v1 4/4] app/test_sched: subport bandwidth profile config

2020-09-02 Thread Savinay Dharmappa
test_sched application uses the new apis introduced as part of dynamic configuration of subport bandwidth to configure the deafult subport bandwidth profile while buidling the hirerachical scheduler Signed-off-by: Savinay Dharmappa --- app/test/test_sched.c | 16 ++-- 1 file changed,

[dpdk-dev] [PATCH v1 2/4] example/ip_pipeline: subport bandwidth dynmaic conf

2020-09-02 Thread Savinay Dharmappa
ip_pipeline application uses the new apis introduced as part of dynamic configuration of subport bandwidth to configure the deafult subport bandwidth profile while buidling the hirerachical scheduler Signed-off-by: Savinay Dharmappa --- examples/ip_pipeline/cli.c | 10 ++ examples/ip_pi

[dpdk-dev] [PATCH v1 2/4] sched: add dynamic config of subport bandwidth profile

2020-09-02 Thread Savinay Dharmappa
This patch builds the subport profile table during port configuration. Since the tb_period,tb_size,tc_period, tb_credits_per_period and tc_credits_per_period are updated in subport profile table, references to them are removed from subport configuration. Signed-off-by: Savinay Dharmappa Signed-of

[dpdk-dev] [PATCH v1 4/4] sched: add dynamic config of subport bandwidth profile

2020-09-02 Thread Savinay Dharmappa
This patch modifies the way credits are updated. Credits are updated by fetching parameters from subport profile table. Signed-off-by: Savinay Dharmappa Signed-off-by: Jasvinder Singh --- lib/librte_sched/rte_sched.c | 62 ++ lib/librte_sched/rte_sched_

  1   2   >