Re: [dpdk-dev] i40e_rxtx_vec_avx2 code review

2020-08-30 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jeff Guo > Sent: Monday, August 31, 2020 8:30 AM > > hi, mb > > Seems that there are a referring issue here which you have found, i > think we need to fix it, if there are on objection i will add that fix > into the prior burst fixing patch,

[dpdk-dev] [PATCH v2] net/iavf: support outer IP hash for GTPU

2020-08-30 Thread alvinx . zhang
From: Alvin Zhang Add patterns for GTPU, now outer IP hash can be configured as input set for GTPU packet. Signed-off-by: Alvin Zhang --- v2: - Remove VLAN as input sets. drivers/net/iavf/iavf_hash.c | 66 1 file changed, 66 insertions(+) diff --g

Re: [dpdk-dev] [PATCH v2 0/3] Add GENEVE protocol parsing to testpmd

2020-08-30 Thread Ophir Munk
Hello Wenzhou, Beilei, Bernard, I saw no comments regarding v1 or v2 of this patch set. Please let me know if you have any question. Otherwise - can it be merged? Regards, Ophir > -Original Message- > From: Ophir Munk > Sent: Thursday, August 27, 2020 10:03 AM > To: dev@dpdk.org; Wenzhuo

[dpdk-dev] [PATCH 1/2] common/iavf: add GTPC support

2020-08-30 Thread alvinx . zhang
From: Alvin Zhang Add GTPC header and its field selector. Signed-off-by: Alvin Zhang --- drivers/common/iavf/virtchnl.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index 79515ee..0042cc0 100644 --- a/drivers/common/iav

[dpdk-dev] [PATCH 2/2] net/iavf: support outer IP hash for GTPC

2020-08-30 Thread alvinx . zhang
From: Alvin Zhang Add patterns for GTPC, now outer IP hash can be configured as input set for GTPC packet. Signed-off-by: Alvin Zhang --- v2: - Remove VLAN as input sets. drivers/net/iavf/iavf_generic_flow.c | 18 + drivers/net/iavf/iavf_generic_flow.h | 6 +++ drivers/net/iavf/iavf_

Re: [dpdk-dev] [PATCH] doc: announce changes to ethdev rxconf structure

2020-08-30 Thread Andrew Rybchenko
Hi Stephen, On 8/30/20 9:26 PM, Stephen Hemminger wrote: > On Sun, 30 Aug 2020 15:58:57 +0300 > Andrew Rybchenko wrote: > >>> >>> The non-zero value of rx_split_num field configures the receiving >>> queue to split ingress packets into multiple segments to the mbufs >>> allocated

Re: [dpdk-dev] [PATCH v2] doc: announce move of aes gmac algorithm to aead

2020-08-30 Thread Kusztal, ArkadiuszX
Hi Thomas, -Original Message- From: Thomas Monjalon Sent: piątek, 7 sierpnia 2020 23:49 To: Kusztal, ArkadiuszX Cc: dev@dpdk.org; akhil.go...@nxp.com; ano...@marvell.com; Doherty, Declan ; Trahe, Fiona ; asoma...@amd.com; rnagadhee...@marvell.com; hemant.agra...@nxp.com; De Lara Guar

Re: [dpdk-dev] i40e_rxtx_vec_avx2 code review

2020-08-30 Thread Jeff Guo
hi, mb Seems that there are a referring issue here which you have found, i think we need to fix it, if there are on objection i will add that fix into the prior burst fixing patch, thanks very much. On 8/29/2020 3:21 PM, Morten Brørup wrote: Jeff, Beilei, Looking closer at i40e_rxtx_vec_avx

Re: [dpdk-dev] [dpdk-dev v7 1/4] cryptodev: add crypto data-path service APIs

2020-08-30 Thread Kusztal, ArkadiuszX
Hi Fan, Piotrek, -Original Message- From: Zhang, Roy Fan Sent: piątek, 28 sierpnia 2020 14:58 To: dev@dpdk.org Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, ArkadiuszX ; Dybkowski, AdamX ; Zhang, Roy Fan ; Bronowski, PiotrX Subject: [dpdk-dev v7 1/4] cryptodev: add crypto data-pat

[dpdk-dev] [PATCH] common/octeontx2: upgrade mbox definition to version 8

2020-08-30 Thread Nithin Dabilpuram
Sync mail box data structures to version 0x0008 to that of kernel AF driver. Cc: sta...@dpdk.org Signed-off-by: Nithin Dabilpuram --- drivers/common/octeontx2/otx2_mbox.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/common/octeontx2/otx2_mbox.h b/drivers/common

Re: [dpdk-dev] [PATCH v1] doc: update ice production information

2020-08-30 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Wednesday, August 26, 2020 8:56 AM > To: dev@dpdk.org > Cc: Wang, Haiyue ; Yang, Qiming > ; Zhang, Qi Z ; Mcnamara, > John ; Kovacevic, Marko > > Subject: [PATCH v1] doc: update ice production information > > The E810 (ice) has been sh

[dpdk-dev] [PATCH v2] net/ice: fix the hash parser

2020-08-30 Thread Jeff Guo
GTPU TEID hash should only be enabled when ETH_RSS_GTPU is required. And the hash parser should not restrict the combined usage of protocol. Fixes: e7cc68c70736 ("net/ice: fix GTPU TEID hash") Signed-off-by: Jeff Guo --- drivers/net/ice/ice_hash.c | 7 +-- 1 file changed, 5 insertions(+), 2

Re: [dpdk-dev] [PATCH] net/ice: add support for Auxiliary IP Offset Rx descriptor

2020-08-30 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Monday, August 31, 2020 1:34 PM > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/ice: add support for Auxiliary IP Offset Rx > descriptor > > > -Original Message-

Re: [dpdk-dev] [PATCH] net/ice: add support for Auxiliary IP Offset Rx descriptor

2020-08-30 Thread Wang, Haiyue
> -Original Message- > From: Guo, Junfeng > Sent: Wednesday, August 26, 2020 11:22 > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > > Cc: dev@dpdk.org; Wang, Haiyue ; Guo, Junfeng > > Subject: [PATCH] net/ice: add support for Auxiliary IP Offset Rx descriptor > > Add RXDID #25 to s

Re: [dpdk-dev] [PATCH v2 3/5] net/ice: maximize vector rx burst for ice

2020-08-30 Thread Jeff Guo
hi, qi On 8/31/2020 12:41 PM, Zhang, Qi Z wrote: -Original Message- From: Guo, Jia Sent: Thursday, August 27, 2020 6:10 PM To: Yang, Qiming ; Xing, Beilei ; Zhao1, Wei ; Zhang, Qi Z ; Wu, Jingjing Cc: Richardson, Bruce ; dev@dpdk.org; Guo, Jia ; Zhang, Helin ; m...@smartsharesystems.

Re: [dpdk-dev] [EXT] Re: Ipsec-secgw packet processing

2020-08-30 Thread Anoob Joseph
Hi Satya, What you are attempting is lookaside crypto offload. So in that case the mbuf->ol_flags fields won’t be used. Also, I’m not sure what all algos are available in ‘crypto_null’. In lookaside crypto offload model, packets are received in ipsec-secgw and lookup happens in ipsec-secgw. The

[dpdk-dev] [PATCH] raw/ntb: add Icelake support for Intel NTB

2020-08-30 Thread Xiaoyun Li
Add NTB device support (4th generation) for Intel Icelake platform. Signed-off-by: Xiaoyun Li --- doc/guides/rawdevs/ntb.rst | 11 +- doc/guides/rel_notes/release_20_11.rst | 3 + drivers/raw/ntb/ntb.c | 2 + drivers/raw/ntb/ntb.h | 1 + drive

Re: [dpdk-dev] [PATCH v2 3/5] net/ice: maximize vector rx burst for ice

2020-08-30 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Thursday, August 27, 2020 6:10 PM > To: Yang, Qiming ; Xing, Beilei > ; Zhao1, Wei ; Zhang, Qi Z > ; Wu, Jingjing > Cc: Richardson, Bruce ; dev@dpdk.org; Guo, Jia > ; Zhang, Helin ; > m...@smartsharesystems.com; Yigit, Ferruh ; > barbe...@k

Re: [dpdk-dev] [PATCH] net/ice: fix flow validation for unsupported patterns

2020-08-30 Thread Zhang, Qi Z
> -Original Message- > From: Sun, GuinanX > Sent: Friday, August 28, 2020 10:33 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Sun, GuinanX ; > sta...@dpdk.org > Subject: [PATCH] net/ice: fix flow validation for unsupported patterns > > When loading the OS default package a

Re: [dpdk-dev] [PATCH v2] common/iavf: mark internal symbols

2020-08-30 Thread Zhang, Qi Z
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, August 18, 2020 11:48 PM > To: Xing, Beilei ; Wang, Haiyue > ; dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Wu, Jingjing ; Ray Kinsella > ; Neil Horman > Subject: Re: [dpdk-dev] [PATCH v2] common/iavf: mark internal symbols

Re: [dpdk-dev] [PATCH v4] net/ice: fix VF index check for DCF

2020-08-30 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Thursday, August 13, 2020 10:15 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Lu, Nannan > ; Zhao1, Wei > Subject: [PATCH v4] net/ice: fix VF index check for DCF > > The vf index in rte_flow command need to check in order th

Re: [dpdk-dev] [PATCH v2 0/8] update i40e base code

2020-08-30 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Jeff Guo > Sent: Tuesday, July 28, 2020 9:33 AM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Xing, Beilei > Subject: Re: [dpdk-dev] [PATCH v2 0/8] update i40e base code > > Acked-by: Jeff Guo > > On 7/27/2020 1:34 PM, Guinan Sun wrote: > > upd

Re: [dpdk-dev] [PATCH v2] net/ice: optimize the FlexiMD hardware check

2020-08-30 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Wednesday, August 12, 2020 8:58 AM > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Cc: Guo, Junfeng ; Wang, Haiyue > > Subject: [PATCH v2] net/ice: optimize the FlexiMD hardware check > > The Flexible Metadata #4 and #5 in the Rx F

Re: [dpdk-dev] [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW

2020-08-30 Thread Zhang, Qi Z
> -Original Message- > From: Pawel Wodkowski > Sent: Tuesday, August 11, 2020 4:31 AM > To: dev@dpdk.org > Cc: Pawel Wodkowski ; Zhang, Qi Z > ; Zhao1, Wei ; Guo, Jia > > Subject: [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW > > Flows like IP4 / UDP / RAW are not work

[dpdk-dev] [RFC 2/2] Description: dpdk: fix compiling errors for more than 256 per-queue statistics

2020-08-30 Thread Min Hu(Connor)
From: Huisong Li Currently, only statistics of rx/tx queues with queue_id less than RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain application scenario that it needs to use 256 or more than 256 queues and display all statistics of rx/tx queue. At this moment, we have to chang

[dpdk-dev] [RFC 1/2] Description: lib/ethdev: change data type in tc_rxq and tc_txq

2020-08-30 Thread Min Hu(Connor)
From: Huisong Li Currently, base and nb_queue in the tc_rxq and tc_txq information of queue and TC mapping on both TX and RX paths are uint8_t. However, these datas will be truncated when queue number under a TC is greater than 256. So it is necessay for base and nb_queue to change from uint8_t t

Re: [dpdk-dev] Using valgrind with DPDK app

2020-08-30 Thread Stephen Hemminger
On Sat, 29 Aug 2020 19:54:08 +0200 Victor Huertas wrote: > Hello, > > I have exactly the same problem as you. I have also downloaded, compiled > and installed the very last version of valgrind (v3.17). > As soon as the mempool is created, the program gets stuck. > > If valgrind cannot be used w

Re: [dpdk-dev] [PATCH v2 13/17] net/virtio: add checks for max SIMD bitwidth

2020-08-30 Thread Xia, Chenbo
Hi Ciara, Sorry for late response and thanks for working on this! Currently virtio driver puts all vector-related conditions in dev_configure (virtio_dev_configure). Do you think it's ok to put all below code logic to dev_configure? Thanks! Chenbo > -Original Message- > From: Power, Cia

Re: [dpdk-dev] [PATCH] net/i40e: i40evf exposes LSC flag to application.

2020-08-30 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of SteveX Yang > Sent: Tuesday, August 11, 2020 5:11 PM > To: Yang, Qiming ; Xing, Beilei > ; Guo, Jia ; dev@dpdk.org > Cc: Yang, SteveX > Subject: [dpdk-dev] [PATCH] net/i40e: i40evf exposes LSC flag to application. > > When PF event VIRTCHN

Re: [dpdk-dev] [PATCH v3] net/i40e: fix link status

2020-08-30 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Xing, Beilei > Sent: Thursday, August 6, 2020 6:08 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Guo, Jia ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix link status > > > > > -Original Message- > > From: Sun, Gu

Re: [dpdk-dev] [PATCH] net/iavf: add support for multicast configuration

2020-08-30 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Monday, July 13, 2020 3:48 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH] net/iavf: add support for multicast configuration > > This patch enable add multicast address for iavf. > > Signed-off-by: Wei Zhao Ack

Re: [dpdk-dev] [PATCH] doc: announce changes to ethdev rxconf structure

2020-08-30 Thread Stephen Hemminger
On Sun, 30 Aug 2020 15:58:57 +0300 Andrew Rybchenko wrote: > > > > The non-zero value of rx_split_num field configures the receiving > > queue to split ingress packets into multiple segments to the mbufs > > allocated from various memory pools according to the specified > > le

Re: [dpdk-dev] 19.11.4 patches review and test

2020-08-30 Thread Ali Alnubani
Hi, > -Original Message- > From: dev On Behalf Of Luca Boccassi > Sent: Tuesday, August 18, 2020 9:12 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > benjamin.wal...@intel.com; David Christensen ; > Hemant Agrawal ; Ian Stokes > ; Jerin Jac

Re: [dpdk-dev] [PATCH] doc: announce changes to ethdev rxconf structure

2020-08-30 Thread Andrew Rybchenko
On 8/3/20 7:51 PM, Slava Ovsiienko wrote: >> -Original Message- >> From: Andrew Rybchenko >> Sent: Monday, August 3, 2020 18:31 >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: Matan Azrad ; Raslan Darawsheh >> ; Thomas Monjalon ; >> ferruh.yi...@intel.com; jerinjac...@gmail.com; >> step...@ne

Re: [dpdk-dev] [RFC] ethdev: add Forward Error Correction support

2020-08-30 Thread Andrew Rybchenko
On 8/28/20 2:32 PM, Min Hu(Connor) wrote: > Hi All, > > I would like to add FEC support of ethdev for DPDK. > I am planning to add this support in v20.11 release. > > This RFC attempts to get feedback from the community. > > In current DPDK version, Forward Error Correction(FEC) is not > support

[dpdk-dev] [PATCH 13/13] app/flow-perf: allow fixed values for actions

2020-08-30 Thread Wisam Jaddo
Sometime the user want to have fixed values of encap/decap or header modify for all flows. This will introduce the ability to choose from fixed or dynamic values by setting the flag in config.h To use different value for each flow: config.h: #define FIXED_VALUES 0 To use single value for all flo

[dpdk-dev] [PATCH 12/13] app/flow-perf: add icmp matching support

2020-08-30 Thread Wisam Jaddo
Start support matching on icmpv4 and icmpv6. Usage: --icmpv4: add icmp item to match on. --icmpv6: add icmpv6 item to match on. Signed-off-by: Wisam Jaddo Acked-by: Alexander Kozyrev --- app/test-flow-perf/items_gen.c | 41 +- app/test-flow-perf/main.c

[dpdk-dev] [PATCH 10/13] app/flow-perf: add random mark id values

2020-08-30 Thread Wisam Jaddo
Instead of having single id value, use up to 256 values, thus we make sure that all flows will not use same mark action. Signed-off-by: Wisam Jaddo Acked-by: Alexander Kozyrev --- app/test-flow-perf/actions_gen.c | 6 -- app/test-flow-perf/config.h | 1 - 2 files changed, 4 insertions(

[dpdk-dev] [PATCH 09/13] app/flow-perf: fix source ipv4 matching

2020-08-30 Thread Wisam Jaddo
All value must be converted into intended endianness. Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") Cc: wis...@mellanox.com Signed-off-by: Wisam Jaddo Acked-by: Alexander Kozyrev --- app/test-flow-perf/items_gen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[dpdk-dev] [PATCH 11/13] app/flow-perf: add set port mask to options

2020-08-30 Thread Wisam Jaddo
Sometimes you need to check flow performance for certain port and not all ports. Thus a portmask option is needed. Usage: --portmask=N Where N represent the hexadecimal bitmask of ports used. Signed-off-by: Wisam Jaddo Acked-by: Alexander Kozyrev --- app/test-flow-perf/main.c | 2

[dpdk-dev] [PATCH 07/13] app/flow-perf: add raw encap/decap actions support

2020-08-30 Thread Wisam Jaddo
Introduce raw-encap and raw-decap actions. The two actions are added in command line options, and for the data to encap or decap the user need to parse it within the command line. All values of raw-encap data is set to be fixed values. Usage example: --raw-encap=ether,ipv4,udp,vxlan Signed-off-

[dpdk-dev] [PATCH 08/13] app/flow-perf: add VXLAN encap/decap actions support

2020-08-30 Thread Wisam Jaddo
Introduce vxlan-encap and vxlan-decap actions. vxlan-encap have fixed pattern and values for encap data. Usage example: --vxlan-encap --vxlan-decap Signed-off-by: Wisam Jaddo Acked-by: Alexander Kozyrev --- app/test-flow-perf/actions_gen.c | 64 ++ app/test-flow-

[dpdk-dev] [PATCH 06/13] app/flow-perf: fix memory leak from RSS action

2020-08-30 Thread Wisam Jaddo
Currently, each call for add_rss_action will allocate extra memory for rss_data, which will reflect bad results on memory consumption for all flows, and will leads into memory leak. In this fix, it will check if it's allocated before reallocating it. Fixes: bf3688f1e816 ("app/flow-perf: add inser

[dpdk-dev] [PATCH 05/13] app/flow-perf: add flag action support

2020-08-30 Thread Wisam Jaddo
Introudce flag action support to flow perf application. Signed-off-by: Wisam Jaddo Acked-by: Alexander Kozyrev --- app/test-flow-perf/actions_gen.c | 14 ++ app/test-flow-perf/main.c | 10 ++ doc/guides/rel_notes/release_20_08.rst | 1 + doc/guides/tools/

[dpdk-dev] [PATCH 04/13] app/flow-perf: add header modify actions support

2020-08-30 Thread Wisam Jaddo
Introduce headers modify actions in the app. All header modify actions will add different value for each flow, to make sure each flow will create and use it's own actions. Signed-off-by: Wisam Jaddo Acked-by: Alexander Kozyrev --- app/test-flow-perf/actions_gen.c | 344 +++

[dpdk-dev] [PATCH 03/13] app/flow-perf: start supporting user order

2020-08-30 Thread Wisam Jaddo
The old design was using the bit mask to identify items, action and attributes. So it was all based on the order of the code itself, to place the order of the actions, items & attributes inside the flows. Such design will lead into many failures when some PMD support order different than other PMD

[dpdk-dev] [PATCH 02/13] doc/flow-perf: fix app sections

2020-08-30 Thread Wisam Jaddo
Currently all the sections are considered as main title under DPDK Tools User Guides. This fix will collect all flow perf sections under one title which is Flow Performance Tool Fixes: 3344cf2e3001 ("app/flow-perf: add flow performance skeleton") Cc: wis...@mellanox.com Signed-off-by: Wisam Jadd

[dpdk-dev] [PATCH 01/13] app/flow-perf: fix actions mask macro usage

2020-08-30 Thread Wisam Jaddo
Actions have it's own macro which is FLOW_ACTION_MASK Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") Cc: wis...@mellanox.com Signed-off-by: Wisam Jaddo Acked-by: Alexander Kozyrev --- app/test-flow-perf/actions_gen.c | 18 +- 1 file changed, 9 insertions(

[dpdk-dev] [PATCH 00/13] app/flow-perf: add support for new items/actions

2020-08-30 Thread Wisam Jaddo
* Some fixes. * Add headers modify actions support. * Add flag action support. * Add raw-encap & raw-decap actions support. * Add VXLAN encap & VXLAN decap actions support. * Add set portmask option. * Add icmp and icmp6 matching items support. * Allow installing rte flows with different modify hea

Re: [dpdk-dev] [v1] vdpa/mlx5: fix event channel setup

2020-08-30 Thread Matan Azrad
From: Xueming Li > During vdap device setup, if some error happens, event channel release > stuck at polling event channel. > > Event channel fd is set to nonblocking in cqe setup, so if any error happens > before this function and after event channel created, the pooling before > releasing re

Re: [dpdk-dev] [PATCH 2/2] trace: add size_t as a generic trace point

2020-08-30 Thread Sunil Kumar Kori
>-Original Message- >From: pbhagavat...@marvell.com >Sent: Wednesday, August 26, 2020 4:54 AM >To: Jerin Jacob Kollanukkaran ; Sunil Kumar Kori >; Ray Kinsella ; Neil Horman > >Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > >Subject: [dpdk-dev] [PATCH 2/2] trace: add size_t as a generic t

Re: [dpdk-dev] [PATCH 1/2] trace: fix size_t field emitter

2020-08-30 Thread Sunil Kumar Kori
>-Original Message- >From: pbhagavat...@marvell.com >Sent: Wednesday, August 26, 2020 4:54 AM >To: Jerin Jacob Kollanukkaran ; Sunil Kumar Kori > >Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > >Subject: [dpdk-dev] [PATCH 1/2] trace: fix size_t field emitter > >From: Pavan Nikhilesh > >A