> -----Original Message----- > From: Guo, Junfeng <junfeng....@intel.com> > Sent: Wednesday, August 26, 2020 11:22 > To: Zhang, Qi Z <qi.z.zh...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; > Xing, Beilei > <beilei.x...@intel.com> > Cc: dev@dpdk.org; Wang, Haiyue <haiyue.w...@intel.com>; Guo, Junfeng > <junfeng....@intel.com> > Subject: [PATCH] net/ice: add support for Auxiliary IP Offset Rx descriptor > > Add RXDID #25 to support Auxiliary IP Offset Rx descriptor, including > FlexiMD.4: Outer/Single IPv4 Header offset > FlexiMD.5: Outer/Single IPv6 Header offset > And parse the valid IP Offset into mbuf by flexible descriptor > section via devargs "proto_xtr" with "proto_xtr=ip_offset". > > This patch depends on: > commit e0c8ed904083 (net/ice: optimize the FlexiMD hardware check) > > Signed-off-by: Junfeng Guo <junfeng....@intel.com> > --- > doc/guides/nics/ice.rst | 14 ++++- > drivers/net/ice/base/ice_lan_tx_rx.h | 1 + > drivers/net/ice/ice_ethdev.c | 10 +++- > drivers/net/ice/ice_ethdev.h | 1 + > drivers/net/ice/ice_rxtx.c | 77 +++++++++++++++++-------- > drivers/net/ice/rte_pmd_ice.h | 13 +++++ > drivers/net/ice/rte_pmd_ice_version.map | 1 + > 7 files changed, 90 insertions(+), 27 deletions(-) >
[...] > + /** > + * No need to check XTR_MD.#_VLD bit in Status/Error fields for > + * Protocol Offset according to CPK HAS 7.9.8. > + */ These comments are no need, since HAS doc session is internal information, and the code is clean enough: if (chk_valid) ... else... > + if (rte_le_to_cpu_16(desc->flex_ts.flex.aux0) != 0xFFFF) > + metadata = rte_le_to_cpu_16(desc->flex_ts.flex.aux0); > + else if (rte_le_to_cpu_16(desc->flex_ts.flex.aux1) != 0xFFFF) > + metadata = rte_le_to_cpu_16(desc->flex_ts.flex.aux1); Others, Acked-by: Haiyue Wang <haiyue.w...@intel.com> > 2.25.1
