Re: [dpdk-dev] [PATCH 1/1] vhost: fix iotlb mempool single-consumer flag

2020-08-25 Thread Xia, Chenbo
Hi Eugenio, > -Original Message- > From: Eugenio Pérez > Sent: Monday, August 10, 2020 10:11 PM > To: dev@dpdk.org > Cc: Adrian Moreno Zapata ; Maxime Coquelin > ; sta...@dpdk.org; Wang, Zhihong > ; Xia, Chenbo > Subject: [PATCH 1/1] vhost: fix iotlb mempool single-consumer flag > > Bug

Re: [dpdk-dev] [PATCH v8 4/5] ci: add aarch64 -> aarch32 cross compiling jobs

2020-08-25 Thread Juraj Linkeš
> -Original Message- > From: Aaron Conole > Sent: Tuesday, August 25, 2020 4:16 PM > To: Juraj Linkeš > Cc: bruce.richard...@intel.com; maicolgabr...@hotmail.com; dev@dpdk.org > Subject: Re: [PATCH v8 4/5] ci: add aarch64 -> aarch32 cross compiling jobs > > Juraj Linkeš writes: > > >

Re: [dpdk-dev] [PATCH] ci: enable vm env for aarch64 builds

2020-08-25 Thread Juraj Linkeš
> -Original Message- > From: Aaron Conole > Sent: Tuesday, August 25, 2020 4:18 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; david.march...@redhat.com; > maicolgabr...@hotmail.com; dev@dpdk.org; Kevin Laatz > > Subject: Re: [PATCH] ci: enable vm env for aarch64 builds > > Juraj Li

[dpdk-dev] [PATCH v3 1/3] eal: add API for bus close

2020-08-25 Thread rohit . raj
From: Rohit Raj As per the current code we have API for bus probe, but the bus close API is missing. This breaks the multi process scenarios as objects are not cleaned while terminating the secondary processes. This patch adds a new API rte_bus_close() for cleanup of bus objects which were acqui

[dpdk-dev] [PATCH v3 3/3] bus/fslmc: support bus close API

2020-08-25 Thread rohit . raj
From: Rohit Raj This patch add support for closing the bus objects which were acquired In the bus probe. Some devices need to be cleaned while in both primary and secondary process and while some need to be cleaned only in case of primary process. The devices are closed as per the white list us

[dpdk-dev] [PATCH v3 2/3] examples/multi_process: cleanup bus objects while terminating app

2020-08-25 Thread rohit . raj
From: Rohit Raj Certain bus objects may need to be closed and re-acquired while terminating and rerunning the client application. Hence a signal handler is required to catch the termination of the App and hence closing the bus objects. This patch adds the missing signal handler in the client app

Re: [dpdk-dev] [PATCH v2] net/dpaa: fix public API port ID type

2020-08-25 Thread Hemant Agrawal
Acked-by: Hemant Agrawal > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, August 25, 2020 11:21 PM > To: dev@dpdk.org; Ray Kinsella ; Neil Horman > ; John McNamara ; > Marko Kovacevic ; Hemant Agrawal > ; Sachin Saxena > Cc: Ferruh Yigit ; sta...@dpdk.org > Subject: [PATCH v2]

Re: [dpdk-dev] [PATCH 2/2] build: find max lcore programmatically

2020-08-25 Thread Dharmik Thakkar
> On Aug 25, 2020, at 11:47 PM, Jerin Jacob wrote: > > On Wed, Aug 26, 2020 at 2:44 AM Dharmik Thakkar > wrote: >> >> For Arm, RTE_MAX_LCORE is hard-coded into the config. It leads to incorrect >> RTE_MAX_LCORE when machines have same Implemener and part number >> but different number of CPU

Re: [dpdk-dev] [PATCH 2/2] build: find max lcore programmatically

2020-08-25 Thread Jerin Jacob
On Wed, Aug 26, 2020 at 2:44 AM Dharmik Thakkar wrote: > > For Arm, RTE_MAX_LCORE is hard-coded into the config. It leads to incorrect > RTE_MAX_LCORE when machines have same Implemener and part number > but different number of CPUs. > For x86, RTE_MAX_LCORE is always set to 128 (using the value >

[dpdk-dev] [PATCH] net/ice: add support for Auxiliary IP Offset Rx descriptor

2020-08-25 Thread Junfeng Guo
Add RXDID #25 to support Auxiliary IP Offset Rx descriptor, including FlexiMD.4: Outer/Single IPv4 Header offset FlexiMD.5: Outer/Single IPv6 Header offset And parse the valid IP Offset into mbuf by flexible descriptor section via devargs "proto_xtr" with "proto_xtr=ip_offset". Thi

Re: [dpdk-dev] [PATCH v8 5/5] doc: add aarch32 build guidance

2020-08-25 Thread Phil Yang
Aaron Conole writes: > Subject: Re: [PATCH v8 5/5] doc: add aarch32 build guidance > > Juraj Linkeš writes: > > > From: Phil Yang > > > > Add cross-compiling guidance for 32-bit aarch32 DPDK on aarch64 host. > > > > Signed-off-by: Phil Yang > > --- > > .../linux_gsg/cross_build_dpdk_for_arm

[dpdk-dev] [PATCH] gso: fix pyld_unit_size issue for udp gso

2020-08-25 Thread yang_y_yi
From: Yi Yang IP fragment offset in IP header must be multiple of 8, if pyld_unit_size isn't multiple of 8, IP total length will be wrong after reassemble, IP payload also will be wrong because some data is lost on reassembling. This has been verified in OVS DPDK by VLAN TSO iperf3 UDP case. Fi

Re: [dpdk-dev] 19.11.4 patches review and test

2020-08-25 Thread Chen, BoX C
Hi Luca, Update LTS 19.11.4 test result for Intel part. No new issue is found except known issues. * Intel(R) Testing # Basic Intel(R) NIC testing * PF(i40e):Passed - Exception message when starting testpmd for testing external memory. It has been fixed on 20.05.patch link: http://patche

[dpdk-dev] Recall: 19.11.3 patches review and test

2020-08-25 Thread Chen, BoX C
Chen, BoX C would like to recall the message, "19.11.3 patches review and test".

Re: [dpdk-dev] 19.11.3 patches review and test

2020-08-25 Thread Chen, BoX C
Hi Luca, Update LTS 19.11.4 test result for Intel part. No new issue is found except known issues. * Intel(R) Testing # Basic Intel(R) NIC testing * PF(i40e):Passed - Exception message when starting testpmd for testing external memory. It has been fixed on 20.05.patch link: http://patche

[dpdk-dev] [PATCH 0/3] add RX buffer size for rte_eth_rxq_info

2020-08-25 Thread Chengchang Tang
In common practice, PMD configure the RX buffer size which indicate the buffer length could be used for HW in receiving packets according to the data room size of the object in mempool. But in fact, the final value is related to the specifications of HW, and its values will affect the number of fra

[dpdk-dev] [PATCH 3/3] net/hns3: add RX buffer size to rx qinfo querry

2020-08-25 Thread Chengchang Tang
Report hns3 PMD configured RX buffer size in RX qinfo querry. Signed-off-by: Chengchang Tang --- drivers/net/hns3/hns3_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index fc1a256..50881d4 100644 --- a/drivers/net/hns3/hns

[dpdk-dev] [PATCH 1/3] ethdev: add a field for rte_eth_rxq_info

2020-08-25 Thread Chengchang Tang
Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer size used in receiving packets for HW. In this way, upper-layer users can get this information by calling rte_eth_rx_queue_info_get. Signed-off-by: Chengchang Tang Acked-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethd

[dpdk-dev] [PATCH 2/3] app/testpmd: Add RX buffer size display in queue info querry

2020-08-25 Thread Chengchang Tang
Add RX buffer size to queue info querry cmd so that the user can get the buffer length used by HW queue for receiving packets. Signed-off-by: Chengchang Tang --- app/test-pmd/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 30bee33.

[dpdk-dev] [PATCH v1] doc: update ice production information

2020-08-25 Thread Haiyue Wang
The E810 (ice) has been shipping to customers, not just for evaluation any more. Signed-off-by: Haiyue Wang --- doc/guides/nics/ice.rst | 8 1 file changed, 8 deletions(-) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 9a9f4a6bb..6ac657c13 100644 --- a/doc/guides/

[dpdk-dev] [PATCH 1/2] trace: fix size_t field emitter

2020-08-25 Thread pbhagavatula
From: Pavan Nikhilesh Add size_t CTF format metadata, this is needed by CTF analyzers to parse the emitted CTF trace. Fixes: 262c4ee791c6 ("trace: add size_t field emitter") Signed-off-by: Pavan Nikhilesh --- lib/librte_eal/common/eal_common_trace_ctf.c | 5 + 1 file changed, 5 insertions

[dpdk-dev] [PATCH 2/2] trace: add size_t as a generic trace point

2020-08-25 Thread pbhagavatula
From: Pavan Nikhilesh Add size_t as a generic trace point. Also, update test_generic_trace_point() to validate size_t emitter. Signed-off-by: Pavan Nikhilesh --- app/test/test_trace.c | 1 + lib/librte_eal/common/eal_common_trace_points.c | 2 ++ lib/librte_eal/includ

Re: [dpdk-dev] [PATCH v8 1/5] net/bnxt: add support for aarch32

2020-08-25 Thread Ajit Khaparde
On Tue, Aug 25, 2020 at 6:04 AM Juraj Linkeš wrote: > From: Ruifeng Wang > > Expand vector PMD support to aarch32. > > Signed-off-by: Ruifeng Wang > Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_rxq.h | 2 +- > drivers/net/bnxt/bnxt_rxr.h | 2 +- > drivers/net/bnxt/bnxt_txr.h | 2 +-

[dpdk-dev] [PATCH 1/2] config/arm: avoid variable reuse

2020-08-25 Thread Dharmik Thakkar
Rename 'machine' to 'machine_properties' in config/arm/meson.build since 'machine' is previously being used in config/meson.build Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- config/arm/meson.build | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --

[dpdk-dev] [PATCH 2/2] build: find max lcore programmatically

2020-08-25 Thread Dharmik Thakkar
For Arm, RTE_MAX_LCORE is hard-coded into the config. It leads to incorrect RTE_MAX_LCORE when machines have same Implemener and part number but different number of CPUs. For x86, RTE_MAX_LCORE is always set to 128 (using the value set in meson_options.txt) Use python script to find max lcore when

Re: [dpdk-dev] [RFC v2] lib/hash: integrate RCU QSBR

2020-08-25 Thread Dharmik Thakkar
CI has reported some compilation issues for this patch. I will resolve these issues once the RFC patch is approved. Thank you! > On Aug 18, 2020, at 11:05 PM, Dharmik Thakkar wrote: > > Integrate RCU QSBR to make it easier for the applications to use lock > free algorithm. > > Resource reclam

Re: [dpdk-dev] [PATCH] net/tap: avoid using SIGIO

2020-08-25 Thread Ferruh Yigit
On 8/17/2020 4:26 PM, Ferruh Yigit wrote: > On 7/28/2020 11:48 AM, Morten Brørup wrote: >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger >>> Sent: Monday, July 27, 2020 9:44 PM >>> >>> On Mon, 27 Jul 2020 15:19:32 +0200 >>> Morten Brørup wrote: >>> > From: dev [mailto

Re: [dpdk-dev] question regarding rx checksum offload flags

2020-08-25 Thread Lance Richardson
On Mon, Aug 24, 2020 at 4:11 PM Lance Richardson wrote: > The IP header checksum status for the outer IP header should determine > whether this flag is set in ol_flags: > PKT_RX_EIP_CKSUM_BAD A simpler question might be simply "how is PKT_RX_EIP_CKSUM_BAD" intended to be used? It seems to be

[dpdk-dev] [PATCH v2] net/dpaa: fix public API port ID type

2020-08-25 Thread Ferruh Yigit
Updating the type for 'port' variable from 'uint8_t' to 'uint16_t'. Fixes: 8c3495f5d2dd ("net/dpaa: support loopback API") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- v2: * Remove deprecation notice --- doc/guides/rel_notes/deprecation.rst | 3 --- drivers/net/dpaa/dpaa_ethdev.c |

Re: [dpdk-dev] [PATCH] net: rte_ether minor optimizations

2020-08-25 Thread Ferruh Yigit
On 7/27/2020 8:34 AM, Olivier Matz wrote: > On Fri, Jun 26, 2020 at 06:51:35PM +0200, Morten Brørup wrote: >> * rte_is_broadcast_ether_addr(): >> Use binary logic instead of comparisons and boolean logic, thus reducing >> the number of branches. >> It now resembles rte_is_zero_ether_addr(). >> >> *

Re: [dpdk-dev] [EXT] Re: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode

2020-08-25 Thread Ferruh Yigit
On 5/1/2020 2:16 PM, Nithin Dabilpuram wrote: > On Fri, May 01, 2020 at 11:27:02AM +0100, Ferruh Yigit wrote: >> External Email >> >> -- >> On 4/29/2020 10:03 AM, Bruce Richardson wrote: >>> On Wed, Apr 29, 2020 at 09:45:44AM +0100

Re: [dpdk-dev] [PATCH] app/testpmd: fix flow rules list after port stop

2020-08-25 Thread Ferruh Yigit
On 8/20/2020 9:40 AM, Gregory Etelson wrote: > Hello, > > Is this patch scheduled for merge with dpdk.org ? > Please update me. > > Regards, > Gregory > >> -Original Message- >> From: Gregory Etelson >> Sent: Monday, August 10, 2020 19:15 >> To: dev@dpdk.org >> Cc: Gregory Etelson ; Mat

Re: [dpdk-dev] [PATCH v2 08/18] raw/ioat: create rawdev instances on idxd PCI probe

2020-08-25 Thread Laatz, Kevin
On 21/08/2020 17:29, Bruce Richardson wrote: When a matching device is found via PCI probe create a rawdev instance for each queue on the hardware. Use empty self-test function for these devices so that the overall rawdev_autotest does not report failures. Signed-off-by: Bruce Richardson ---

Re: [dpdk-dev] [PATCH v2 13/18] raw/ioat: add data path for idxd devices

2020-08-25 Thread Laatz, Kevin
On 21/08/2020 17:29, Bruce Richardson wrote: Add support for doing copies using DSA hardware. This is implemented by just switching on the device type field at the start of the inline functions. Since there is no hardware which will have both device types present this branch will always be predic

Re: [dpdk-dev] [PATCH v2 10/18] raw/ioat: add datapath data structures for idxd devices

2020-08-25 Thread Laatz, Kevin
On 21/08/2020 17:29, Bruce Richardson wrote: Add in the relevant data structures for the data path for DSA devices. Also include a device dump function to output the status of each device. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/idxd_pci.c| 3 +- drivers/raw/ioat/id

Re: [dpdk-dev] [PATCH v2 02/18] raw/ioat: split header for readability

2020-08-25 Thread Laatz, Kevin
On 21/08/2020 17:29, Bruce Richardson wrote: Rather than having a single long complicated header file for general use we can split things so that there is one header with all the publically needed information - data structs and function prototypes - while the rest of the internal details are put

Re: [dpdk-dev] [PATCH] ci: enable vm env for aarch64 builds

2020-08-25 Thread Aaron Conole
Juraj Linkeš writes: > Tests requiring hugepages do not work outside of VM environment because > of security limitations. Enable aarch64 builds which run tests to run in > a VM to avoid these limitations. > > Signed-off-by: Juraj Linkeš > --- Cool! Globally we have dist: set to 'bionic'. Does

Re: [dpdk-dev] [PATCH v8 4/5] ci: add aarch64 -> aarch32 cross compiling jobs

2020-08-25 Thread Aaron Conole
Juraj Linkeš writes: > Add two jobs (static and shared libs), both building on aarch64 and > producing 32-bit arm binaries executable on armv8-a, but not armv7. > Do not run tests in these jobs. > > Signed-off-by: Juraj Linkeš > --- > .ci/linux-build.sh | 7 ++- > .travis.yml| 19 +

Re: [dpdk-dev] [PATCH RFC 1/1] net/af_xdp: shared UMEM support

2020-08-25 Thread Ferruh Yigit
On 8/11/2020 10:50 AM, Ciara Loftus wrote: > A future kernel will introduce the ability to efficiently share a UMEM > between AF_XDP sockets bound to different queue ids on the same or > different devices. This patch integrates that functionality into the AF_XDP > PMD. > > A PMD will attempt to sh

Re: [dpdk-dev] [PATCH v8 5/5] doc: add aarch32 build guidance

2020-08-25 Thread Aaron Conole
Juraj Linkeš writes: > From: Phil Yang > > Add cross-compiling guidance for 32-bit aarch32 DPDK on aarch64 host. > > Signed-off-by: Phil Yang > --- > .../linux_gsg/cross_build_dpdk_for_arm64.rst | 30 ++- > 1 file changed, 23 insertions(+), 7 deletions(-) > > diff --git a/doc/

[dpdk-dev] [PATCH v3 2/2] doc/linux_gsg: update information on using hugepages

2020-08-25 Thread Anatoly Burakov
Current information regarding hugepage usage is a little out of date. Update it to include information on in-memory mode, as well as on default mountpoints provided by systemd. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- Notes: v3: - Clarified word

[dpdk-dev] [PATCH v3 1/2] doc/linux_gsg: clarify instructions on running as non-root

2020-08-25 Thread Anatoly Burakov
The current instructions are slightly out of date when it comes to providing information about setting up the system for using DPDK as non-root, so update them. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov Reviewed-by: Ferruh Yigit Acked-by: Bruce Richardson --- Notes: v2: - Mov

Re: [dpdk-dev] [PATCH] lib/telemetry: fix passing full params string to command

2020-08-25 Thread Bruce Richardson
On Tue, Aug 25, 2020 at 01:01:33PM +0100, Ciara Power wrote: > Telemetry only passed the first param to the command handler if multiple > were entered by the user, separated by commas. Telemetry is required to > pass the full params string to the command, by splitting by a comma > delimiter only on

Re: [dpdk-dev] [PATCH v2 2/2] doc/linux_gsg: update information on using hugepages

2020-08-25 Thread Bruce Richardson
On Tue, Aug 25, 2020 at 01:17:49PM +0100, Anatoly Burakov wrote: > Current information regarding hugepage usage is a little out of date. > Update it to include information on in-memory mode, as well as on > default mountpoints provided by systemd. > > Cc: sta...@dpdk.org > > Signed-off-by: Anatol

Re: [dpdk-dev] [PATCH v2 1/2] doc/linux_gsg: clarify instructions on running as non-root

2020-08-25 Thread Bruce Richardson
On Tue, Aug 25, 2020 at 01:17:48PM +0100, Anatoly Burakov wrote: > The current instructions are slightly out of date when it comes to > providing information about setting up the system for using DPDK as > non-root, so update them. > > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly Burakov > Rev

[dpdk-dev] [PATCH v8 5/5] doc: add aarch32 build guidance

2020-08-25 Thread Juraj Linkeš
From: Phil Yang Add cross-compiling guidance for 32-bit aarch32 DPDK on aarch64 host. Signed-off-by: Phil Yang --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 30 ++- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_ar

[dpdk-dev] [PATCH v8 4/5] ci: add aarch64 -> aarch32 cross compiling jobs

2020-08-25 Thread Juraj Linkeš
Add two jobs (static and shared libs), both building on aarch64 and producing 32-bit arm binaries executable on armv8-a, but not armv7. Do not run tests in these jobs. Signed-off-by: Juraj Linkeš --- .ci/linux-build.sh | 7 ++- .travis.yml| 19 +++ 2 files changed, 2

[dpdk-dev] [PATCH v8 3/5] build: add aarch32 to meson cross-compilation

2020-08-25 Thread Juraj Linkeš
Create meson cross file arm32_armv8a_linux_gcc. Use arm-linux-gnueabihf- toolset which comes with standard packages on most used systems, such as Ubuntu and CentOS. Signed-off-by: Juraj Linkeš --- config/arm/arm32_armv8a_linux_gcc | 17 + 1 file changed, 17 insertions(+) create

[dpdk-dev] [PATCH v8 2/5] build: add aarch32 meson build flags

2020-08-25 Thread Juraj Linkeš
Add aarch32 extra build flags and aarch32 machine flags to generic machine args. Also modify how arm flags are updated in meson build - for 32-bit build, update only if cross-compiling. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 20 ++-- 1 file changed, 18 insertion

[dpdk-dev] [PATCH v8 0/5] aarch64 -> aarch32 cross compilation support

2020-08-25 Thread Juraj Linkeš
Add support for aarch32 cross build in meson and add aarch64 -> aarch32 cross build to Travis. Aarch32 is an execution state that allows execution of 32-bit code on armv8 machines. This execution state contains a superset of previous armv7 32-bit instructions and features. Thus the aarch32 build i

[dpdk-dev] [PATCH v8 1/5] net/bnxt: add support for aarch32

2020-08-25 Thread Juraj Linkeš
From: Ruifeng Wang Expand vector PMD support to aarch32. Signed-off-by: Ruifeng Wang --- drivers/net/bnxt/bnxt_rxq.h | 2 +- drivers/net/bnxt/bnxt_rxr.h | 2 +- drivers/net/bnxt/bnxt_txr.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxq.h b/driv

[dpdk-dev] [PATCH v2 2/2] doc/linux_gsg: update information on using hugepages

2020-08-25 Thread Anatoly Burakov
Current information regarding hugepage usage is a little out of date. Update it to include information on in-memory mode, as well as on default mountpoints provided by systemd. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v2: - Reworked the description - Put runtime

[dpdk-dev] [PATCH v2 1/2] doc/linux_gsg: clarify instructions on running as non-root

2020-08-25 Thread Anatoly Burakov
The current instructions are slightly out of date when it comes to providing information about setting up the system for using DPDK as non-root, so update them. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov Reviewed-by: Ferruh Yigit --- Notes: v2: - Moved VFIO description to be fi

Re: [dpdk-dev] [PATCH RFC 0/1] net/af_xdp: shared UMEM support

2020-08-25 Thread Ferruh Yigit
On 8/11/2020 10:50 AM, Ciara Loftus wrote: > This RFC integrates shared UMEM support into the AF_XDP PMD. It is based on > the > WIP kernel series [1] by Magnus Karlsson. > > Detailed information on the shared UMEM feature can be found in the final > patch > in the aforementioned series. > > Su

[dpdk-dev] [PATCH] lib/telemetry: fix passing full params string to command

2020-08-25 Thread Ciara Power
Telemetry only passed the first param to the command handler if multiple were entered by the user, separated by commas. Telemetry is required to pass the full params string to the command, by splitting by a comma delimiter only once to remove the command part of the string. This will enable future

[dpdk-dev] [PATCH 09/11] net/hns3: fix default MAC addr from firmware

2020-08-25 Thread Wei Hu (Xavier)
From: Huisong Li Currently, default MAC address obtained from firmware in hns3 PF PMD driver is directly used by .mac_addr_set ops implementation function when the rte_eth_dev_start API function is executed. At this moment, if the default MAC addr isn't an unicast address, it will fail to set def

[dpdk-dev] [PATCH 10/11] net/hns3: fix Rx/Tx queue offload capability

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" According to rte_eth_rx_queue_setup and rte_eth_tx_queue_setup API function, rx_queue_offload_capa and rx_offload_capa, tx_queue_offload_capa and tx_offload_capa must be mutually exclusive in the '.dev_infos_get' ops implementation function. Otherwise, rte_eth_rx_queue_set

[dpdk-dev] [PATCH 11/11] net/hns3: fix some incomplete command structures

2020-08-25 Thread Wei Hu (Xavier)
From: Huisong Li The descriptor of the command between firmware and hns3 PMD driver consists of 8-byte header and 24-byte data field. The contents sent to firmware are packaged into a command structure as the data field of command descriptor. There are some command structures in hns3_dcb.h file

[dpdk-dev] [PATCH 08/11] net/hns3: change the log level to INFO

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch changes the log level from NOTICE to INFO. Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index fca035d4

[dpdk-dev] [PATCH 06/11] net/hns3: support a maximun 256 FDIR counter

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" The FDIR counter was used to count the number of FDIR hit, the maximum number of the counter is 128 based on kunpeng 920, and it was 256 based on kunpeng 930. The firmware is responsible to allocate counters for diffent PF devices, so the available counter number of one P

[dpdk-dev] [PATCH 07/11] net/hns3: replace private macro with RTE MAX

2020-08-25 Thread Wei Hu (Xavier)
From: Huisong Li This patch uses RTE_MAX function in DPDK lib to replace the private macro named max_t in hns3 PMD driver. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 5 ++--- drivers/net/hns3/hns3_ethdev.h | 5 - 2 files changed, 2 insert

[dpdk-dev] [PATCH 04/11] net/hns3: compatibility issues about Tx padding short frame

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" There are differece about padding ultra-short frame in Tx procession for different versions of hardware network engine. If packet length is less than minimum packet length supported by hardware in Tx direction, driver need to pad it to avoid error. The minimum packet leng

[dpdk-dev] [PATCH 05/11] net/hns3: add more hardware error types

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" The new firmware adds the hardware error types reported by MSI-x mode. These errors are defined as RAS errors in hardware and belong to a different type from the MSI-x errors processed by the driver. When hardware detects an hardware errors, which need to be handled with

[dpdk-dev] [PATCH 03/11] net/hns3: compatibility issues about Rx interrupts

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" There are difference about queue's interrupt configurations for different versions of hardware network engine, such as queue's interrupt mapping mode, coalesce configuration, etc. The following uses the configuration differences of the interrupt mapping mode as an example

[dpdk-dev] [PATCH 00/11] updates for hns3 PMD driver

2020-08-25 Thread Wei Hu (Xavier)
This series are features and fixes for hns3 PMD driver. Huisong Li (3): net/hns3: replace private macro with RTE MAX net/hns3: fix default MAC addr from firmware net/hns3: fix some incomplete command structures Wei Hu (Xavier) (8): net/hns3: get device capability from firmware net/hns3:

[dpdk-dev] [PATCH 01/11] net/hns3: get device capability from firmware

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds getting device capabilities from firmware, so driver can supply differnet cpabilities and specifications to upper level applications base on differnet versions of hardware network engine. Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_cmd.c

[dpdk-dev] [PATCH 02/11] net/hns3: get dev specifications from firmware

2020-08-25 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds getting PF/VF device specifications from firmware. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Hongbo Zheng --- drivers/net/hns3/hns3_cmd.h | 15 drivers/net/hns3/hns3_dcb.c | 1 - drivers/net/hns3/hns3_dcb.h | 2 + driver

[dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults

2020-08-25 Thread Bruce Richardson
In case a developer uses CFLAGS to set different default values for the defines in the rte_config.h file, use #ifndef / #endif guards around the setting of those values. For those lines just "defining" a macro without assigning it a value to be used by code, drop the value argument (where possible)

[dpdk-dev] [PATCH 1/2] config: remove explicit undefinition of unset values

2020-08-25 Thread Bruce Richardson
Rather than explicitly clearing any setting of undefined values in our rte_config.h file, it's better to instead just add a comment that the value is not set. Using a comment allows the user to set the value using CFLAGS or similar mechanism without the config file clearing the value again. The te

[dpdk-dev] [PATCH] bus/pci: support segment value as address domain on Windows

2020-08-25 Thread Tal Shnaiderman
Set the domain value for rte_pci_addr probing on Windows to the value of the PCI segment returned by SPDRP_BUSNUMBER. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/windows/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bus/pci/windows/pci.c b/drivers/b

Re: [dpdk-dev] 19.11.4 patches review and test

2020-08-25 Thread Luca Boccassi
On Tue, 2020-08-25 at 05:13 -0400, Pei Zhang wrote: > Hello Luca, > > Testing with dpdk 19.11.4-rc1 from Red Hat looks good. > > We cover below 16 scenarios and and all get PASS on RHEL8 testing: > > (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS > (2)Guest with d

[dpdk-dev] [PATCH v2 10/13] net/mlx5: remove more DV dependencies

2020-08-25 Thread Ophir Munk
From: Ophir Munk Several DV-based structs of type 'struct mlx5dv_devx_XXX' are replaced with 'void *' to enable compilation under non-Linux operating systems. New getter functions were added to retrieve the specific fields that were previously accessed directly. Replaced structs: 'struct mlx5dv_

[dpdk-dev] [PATCH v2 12/13] net/mlx5: separate VLAN strip modification

2020-08-25 Thread Ophir Munk
From: Ophir Munk When updating a queue vlan stripping offload - either the WQ is modified in Verbs or the RQ is modified in DevX. Add a vlan stripping modify callback to 'struct mlx5_obj_ops' and assign it with the specific Verbs and DevX implementations: 'rxq_obj_modify_wq_vlan_strip' and 'rxq_

[dpdk-dev] [PATCH v2 13/13] linux/mlx5: refactor VLAN

2020-08-25 Thread Ophir Munk
From: Ophir Munk File mlx5_vlan.c contains Netlink APIs (Linux dependent) as part of VM workaround implementation. Move this implementation to file linux/mlx5_vlan_os.c. To remove Netlink dependency in header files change pointer of type 'struct mlx5_nl_vlan_vmwa_context *' to 'void *'. Signed-

[dpdk-dev] [PATCH v2 11/13] net/mlx5: remove ibv_* dependency in Rx/Tx objects

2020-08-25 Thread Ophir Munk
From: Ophir Munk Replace pointers to ibv structs with pointers to void (file mlx5_rxtx.h). Specifically the following pointers were replaced: 'struct ibv_cq *', 'struct ibv_wq *', 'struct ibv_comp_channel *', 'struct ibv_rwq_ind_table *a', 'struct ibv_qp *'. Signed-off-by: Ophir Munk Acked-by:

[dpdk-dev] [PATCH v2 07/13] net/mlx5: fix unused utility macros

2020-08-25 Thread Ophir Munk
From: Ophir Munk Remove utility macros INFO, WARN, ERROR. They are not in use and conflict with identical definitions when compiled under Windows. Fixes: 80f2d0ed7ff9 ("net/mlx5: add hardware flow debug dump") Cc: sta...@dpdk.org Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/ne

[dpdk-dev] [PATCH v2 09/13] net/mlx5: add ICMP protocol number definition

2020-08-25 Thread Ophir Munk
From: Ophir Munk Some Windows distributions do not include ICMP protocol definitions IPPROTO_ICMP and IPPROTO_ICMPV6. This commit defines them if needed. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a

[dpdk-dev] [PATCH v2 08/13] net/mlx5: call meter detach only if DR is supported

2020-08-25 Thread Ophir Munk
From: Ophir Munk Flow metering is supported only in direct rules (DR). Currently the APIs of meter actions create and modify are under #ifdef HAVE_MLX5_DR_CREATE_ACTION_FLOW_METER, while detaching the meter action is executed unconditionally. This commit adds the same ifdef to API mlx5_flow_meter

[dpdk-dev] [PATCH v2 04/13] net/mlx5: move mlx5_get_ifname prototype under Linux

2020-08-25 Thread Ophir Munk
From: Ophir Munk mlx5_get_ifname() prototype includes 'IF_NAMESIZE' definition from Linux file net/if.h. Since this API is only used under Linux and to enable compilation under non-Linux OS - move this prototype from shared file mlx5.h to file linux/mlx5_os.h. Signed-off-by: Ophir Munk Acked-by

[dpdk-dev] [PATCH v2 01/13] common/mlx5: replace strsep with strtok_r

2020-08-25 Thread Ophir Munk
From: Ophir Munk strsep() is a non-standardized API (by C or POSIX) and thus it is non-portable between different operating systems. Replace it with strtok_r() which is standardized by the C standard, and hence also by POSIX. The replacement occurs in the code that extracts individual PCI class n

[dpdk-dev] [PATCH v2 05/13] net/mlx5: fix removal of unused inclusion files

2020-08-25 Thread Ophir Munk
From: Ophir Munk Remove unused Linux included files: , from file net/mlx5/mlx5_mac.c from file net/mlx5/mlx5.c Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters") Cc: sta...@dpdk.org Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH v2 00/13] mlx5 PMD multi OS support - part #4

2020-08-25 Thread Ophir Munk
This patch series is part of preparing mlx5 PMD to compile and run under multiple OSs. Part #4 v1: initial version v2: checkpatch fixes Ophir Munk (13): common/mlx5: replace strsep with strtok_r common/mlx5: replace Linux __bexx types with rte net/mlx5: rename mlx5 enumeration REG_NONE n

[dpdk-dev] [PATCH v2 03/13] net/mlx5: rename mlx5 enumeration REG_NONE

2020-08-25 Thread Ophir Munk
From: Ophir Munk Enumerated variable REG_NONE (defined in mlx5_prm.h) is in conflict with Windows definition (winnt.h): #define REG_NONE ( 0ul ) // No value type To enable mlx5 PMD Windows compilation - rename REG_NONE as REG_NON. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/co

[dpdk-dev] [PATCH v2 02/13] common/mlx5: replace Linux __bexx types with rte

2020-08-25 Thread Ophir Munk
From: Ophir Munk Replace Linux specific int types with their corresponding rte typedefs. __be16 ==> rte_be16_t __be32 ==> rte_be32_t __be64 ==> rte_be64_t Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 14 +++--- 1 file changed, 7 insertions(+), 7

[dpdk-dev] [PATCH v2 06/13] net/mlx5: remove Netlink dependency in shared code

2020-08-25 Thread Ophir Munk
From: Ophir Munk This commit adds Linux implementation of routine mlx5_os_mac_addr_flush as wrapper to Netlink API to avoid direct calls under non-Linux operating systems. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 18 ++ drivers/net

Re: [dpdk-dev] [PATCH 1/2] doc/linux_gsg: clarify instructions on running as non-root

2020-08-25 Thread Burakov, Anatoly
On 24-Aug-20 6:08 PM, Bruce Richardson wrote: On Mon, Aug 24, 2020 at 04:45:00PM +0100, Anatoly Burakov wrote: The current instructions are slightly out of date when it comes to providing information about setting up the system for using DPDK as non-root, so update them. Cc: sta...@dpdk.org Si

Re: [dpdk-dev] [PATCH 2/2] doc/linux_gsg: update information on using hugepages

2020-08-25 Thread Burakov, Anatoly
On 24-Aug-20 6:13 PM, Bruce Richardson wrote: On Mon, Aug 24, 2020 at 04:45:01PM +0100, Anatoly Burakov wrote: Current information regarding hugepage usage is a little out of date. Update it to include information on in-memory mode, as well as on default mountpoints provided by systemd. Cc: sta

Re: [dpdk-dev] [PATCH 1/1] vhost: fix iotlb mempool single-consumer flag

2020-08-25 Thread Kevin Traynor
On 10/08/2020 15:11, Eugenio Pérez wrote: > Bugzilla bug: 523 > > Using testpmd as a vhost-user with iommu: > > /home/dpdk/build/app/dpdk-testpmd -l 1,3 \ > --vdev net_vhost0,iface=/tmp/vhost-user1,queues=1,iommu-support=1 \ > -- --auto-start --stats-period 5 --forward-mode=txonly

[dpdk-dev] [v1] vdpa/mlx5: fix event channel setup

2020-08-25 Thread Xueming Li
During vdap device setup, if some error happens, event channel release stuck at polling event channel. Event channel fd is set to nonblocking in cqe setup, so if any error happens before this function and after event channel created, the pooling before releasing resources will stuck. This patch m

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/hinic: fix negative array index read

2020-08-25 Thread Ferruh Yigit
On 8/24/2020 1:54 PM, Ferruh Yigit wrote: > On 8/24/2020 1:43 PM, wangyunjian wrote: >> From: Yunjian Wang >> >> Negative array index read using variable 'i' as an index to array >> 'filter_info->pkt_filters'. Fixed by add return value check. >> >> Coverity issue: 350364 >> Fixes: f4ca3fd54c4d ("n

Re: [dpdk-dev] 19.11.4 patches review and test

2020-08-25 Thread Pei Zhang
Hello Luca, Testing with dpdk 19.11.4-rc1 from Red Hat looks good. We cover below 16 scenarios and and all get PASS on RHEL8 testing: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)

Re: [dpdk-dev] [PATCH 1/2] drivers: replace RTE CIO barriers with RTE IO barriers

2020-08-25 Thread Phil Yang
Hi Honnappa, > Hi Phil, > Can you please add a statement in release notes indicating that these > APIs are removed. Sure. I will add it to the 2/2 patch in the new version. Thanks, Phil > > Thank you, > Honnappa > > > -Original Message- > > From: Phil Yang > > Sent: Monday, A

Re: [dpdk-dev] [PATCH v4 0/3] minor updates for getting queue info

2020-08-25 Thread Ferruh Yigit
On 8/24/2020 12:01 PM, Wei Hu (Xavier) wrote: > This series include 3 patches. > One patch is a minor update to add checking whether the related Tx or Rx > queue has been setuped in the rte_eth_rx_queue_info_get and > rte_eth_tx_queue_info_get API function to avoid illegal address access. > > And

Re: [dpdk-dev] [PATCH v4 3/3] ethdev: check if queue setupped when getting queue info

2020-08-25 Thread Ferruh Yigit
On 8/24/2020 12:01 PM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" > > This patch adds checking whether the related Tx or Rx queue has been > setuped in the rte_eth_rx_queue_info_get and rte_eth_tx_queue_info_get > API function to avoid illegal address access. > > Signed-off-by: Wei Hu (Xav

Re: [dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305

2020-08-25 Thread Kusztal, ArkadiuszX
-Original Message- From: Dybkowski, AdamX Sent: piątek, 14 sierpnia 2020 12:00 To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com Cc: Dybkowski, AdamX ; Kusztal, ArkadiuszX Subject: [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305 This reverts commit a0f0de06d4577

Re: [dpdk-dev] [PATCH 1/2] doc/linux_gsg: clarify instructions on running as non-root

2020-08-25 Thread Ferruh Yigit
On 8/24/2020 4:45 PM, Anatoly Burakov wrote: > The current instructions are slightly out of date when it comes to > providing information about setting up the system for using DPDK as > non-root, so update them. > > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly Burakov Thanks for the doc updat

Re: [dpdk-dev] [PATCH 1/2] net/ark: remove compile time log macros in favor of run time log control

2020-08-25 Thread Ferruh Yigit
On 8/24/2020 10:40 PM, Ed Czeck wrote: > On Mon, Aug 24, 2020 at 11:09 AM Ferruh Yigit wrote: >> >> On 8/24/2020 3:40 PM, Bruce Richardson wrote: >>> On Mon, Aug 24, 2020 at 03:37:53PM +0100, Ferruh Yigit wrote: On 8/24/2020 2:36 PM, Ed Czeck wrote: > Use ARK_PMD_LOG in place of PMD_DRV_L

Re: [dpdk-dev] [PATCH 2/2] net/ark: remove RTE_LIBRTE_ARK_PAD_TX configuration macro

2020-08-25 Thread Ferruh Yigit
On 8/24/2020 10:51 PM, Ed Czeck wrote: > On Mon, Aug 24, 2020 at 10:55 AM Ferruh Yigit wrote: >> >> On 8/24/2020 2:36 PM, Ed Czeck wrote: >>> Replace behavior with RTE_LIBRTE_ARK_MIN_TX_PKTLEN >>> with a default value of 0. >>> Update documentation as needed. >>> >>> Signed-off-by: Ed Czeck >>> -

[dpdk-dev] [PATCH] ci: enable vm env for aarch64 builds

2020-08-25 Thread Juraj Linkeš
Tests requiring hugepages do not work outside of VM environment because of security limitations. Enable aarch64 builds which run tests to run in a VM to avoid these limitations. Signed-off-by: Juraj Linkeš --- .travis.yml | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --g

[dpdk-dev] [PATCH] ci: enable vm env for aarch64 builds

2020-08-25 Thread Juraj Linkeš
Tests requiring hugepages do not work outside of VM environment because of security limitations. Enable aarch64 builds which run tests to run in a VM to avoid these limitations. Signed-off-by: Juraj Linkeš --- .travis.yml | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --g

  1   2   >