[dpdk-dev] [PATCH] librte_metrics: fix memory leak

2020-07-31 Thread Gaurav Singh
Fix memory leak issue Signed-off-by: Gaurav Singh --- lib/librte_metrics/rte_metrics_telemetry.c | 24 +++--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/lib/librte_metrics/rte_metrics_telemetry.c b/lib/librte_metrics/rte_metrics_telemetry.c index 289ebae0b..9

[dpdk-dev] DPDK with -fsanitize=thread failure

2020-07-31 Thread Stephen Hemminger
Tried running DPDK under Address Sanitizer with the thread data race option, and ran into something that needs some discussion. Is this just an ASAN bug? The fatal log is: == WARNING: ThreadSanitizer: data race (pid=28275) Write of size 1 at 0xf5000580 by main thread: #0

[dpdk-dev] [PATCH] net/rte_pmd_i40e: remove duplicate check

2020-07-31 Thread Gaurav Singh
remove duplicate check Signed-off-by: Gaurav Singh --- drivers/net/i40e/rte_pmd_i40e.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index e216e6783..17938e7d3 100644 --- a/drivers/net/i40e/rte_pmd_i40e.c +++ b/drivers/net/i4

[dpdk-dev] [PATCH] librte_metrics: fix memory leak

2020-07-31 Thread Gaurav Singh
Fix memory leak for sequential allocations. Signed-off-by: Gaurav Singh --- lib/librte_metrics/rte_metrics_telemetry.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/lib/librte_metrics/rte_metrics_telemetry.c b/lib/librte_metrics/rte_metrics_telemetry.c i

[dpdk-dev] [PATCH v2 4/4] net/bnxt: fix vfrep add when VF interface is down

2020-07-31 Thread Ajit Khaparde
From: Venkat Duvvuru While adding vfrep port to OVS bridge, vnic & svif information of vfrep's endpoint(VF) would be needed to program default flow rules. However, if the endpoint interface is down when vfrep port is added, firmware will return invalid vnic & svif information. This patch fixes t

[dpdk-dev] [PATCH v2 3/4] net/bnxt: fix cleanup and check for ulp context alloc

2020-07-31 Thread Ajit Khaparde
From: Somnath Kotur Set ulp_ctx explicitly to NULL in ulp_ctx_deinit() so that representor init is aborted if parent ulp context is not initialized. Also check for the same before creation of port default rules. Additional checks in VF rep dev ops for proper parent dev initialization Fixes: 322b

[dpdk-dev] [PATCH v2 1/4] net/bnxt: fix loopback parif for egress flows

2020-07-31 Thread Ajit Khaparde
From: Kishore Padmanabha The full offload egress flows for the VF rep interface should use loopback parif to offload missed flows. Fixes: fe82f3e02701 ("net/bnxt: support exact match templates") Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle Reviewed-by: Ajit Khaparde --- dri

[dpdk-dev] [PATCH v2 2/4] net/bnxt: fix lookup for default parif action record

2020-07-31 Thread Ajit Khaparde
From: Kishore Padmanabha The lookup default action record parif table is updated to catch the miss path for the entries in the exact match table. Fixes: fe82f3e02701 ("net/bnxt: support exact match templates") Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle Reviewed-by: Mike Bau

[dpdk-dev] [PATCH v2 0/4] bnxt patches

2020-07-31 Thread Ajit Khaparde
fixes and cleanups in bnxt TRUFlow v1->v2: updated signed-off tags in commit logs. Kishore Padmanabha (2): net/bnxt: fix loopback parif for egress flows net/bnxt: fix lookup for default parif action record Somnath Kotur (1): net/bnxt: fix cleanup and check for ulp context alloc Venkat Duv

[dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

2020-07-31 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- doc/guides/rel_notes/deprecation.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 99c9806..b9682a7 100644 --- a/doc/guides/rel_

Re: [dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

2020-07-31 Thread Jerin Jacob
On Sat, Aug 1, 2020 at 12:24 AM McDaniel, Timothy wrote: > > From: "McDaniel, Timothy" > > Signed-off-by: McDaniel, Timothy > --- > doc/guides/rel_notes/deprecation.rst | 37 > +- > 1 file changed, 10 insertions(+), 27 deletions(-) > > diff --git a/doc/guides/

[dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

2020-07-31 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- doc/guides/rel_notes/deprecation.rst | 37 +- 1 file changed, 10 insertions(+), 27 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index ecb1b

[dpdk-dev] [PATCH] doc: announce API change in mbuf

2020-07-31 Thread Thomas Monjalon
In order to prepare for adding more features requiring more space in mbuf, some static fields must become dynamic. Some small layout changes may have performance benefits as well. The deprecation notice for atomic refcount is moved and reworded to fit below the layout deprecation. Signed-off-by:

Re: [dpdk-dev] [PATCH v3] cmdline: increase maximum line length

2020-07-31 Thread Stephen Hemminger
On Fri, 31 Jul 2020 14:55:16 +0200 Olivier Matz wrote: > Hi, > > Ressurecting this old thread. > > On Sat, Feb 22, 2020 at 04:28:15PM +0100, David Marchand wrote: > > This patch is flagged as an ABI breakage: > > https://travis-ci.com/ovsrobot/dpdk/jobs/289313318#L2273 > > > > In case we wa

Re: [dpdk-dev] The mbuf API needs some cleaning up

2020-07-31 Thread Olivier Matz
Hi Morten, Thanks for the feedback. On Mon, Jul 13, 2020 at 11:57:38AM +0200, Morten Brørup wrote: > The MBUF library exposes some macros and constants without the RTE_ prefix. I > propose cleaning up these, so better names get into the coming LTS release. Yes, Thomas talked about it some time

Re: [dpdk-dev] [20.11, PATCH v2] baseband/fpga_5gnr_fec: add companion PF config App

2020-07-31 Thread Chautru, Nicolas
Hi Maxime, > > Hi Nicolas, > > On 7/16/20 10:20 PM, Nicolas Chautru wrote: > > Adding companion application to configure HW Device from the PF. > > Then the device can be accessed through BBDEV from VF (or PF). > > > > Signed-off-by: Nicolas Chautru > > --- > > doc/guides/bbdevs/fpga_5gnr_fec

Re: [dpdk-dev] [PATCH V1 2/3] mbuf: change free_cb interface to adapt to GSO case

2020-07-31 Thread Olivier Matz
Hi, On Thu, Jul 30, 2020 at 08:08:59PM +0800, yang_y...@163.com wrote: > From: Yi Yang > > In GSO case, segmented mbufs are attached to original > mbuf which can't be freed when it is external. The issue > is free_cb doesn't know original mbuf and doesn't free > it when refcnt of shinfo is 0. >

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-07-31 Thread Doherty, Declan
On 29/07/2020 3:22 PM, Arek Kusztal wrote: This is proposal to move AES-GMAC algorithm to AEAD set of algorithms. It is however not 100% conformant GMAC as instead of aad pointer data to be authenticated is passed normally and aead.data.length field is used to specify length of data to be authen

[dpdk-dev] [PATCH 2/2] crypto/octeontx2: add cpt kernel driver version check

2020-07-31 Thread Ankur Dwivedi
From: Tejasree Kondoj This patch checks if cpt pmd is compatible with kernel cpt driver. Signed-off-by: Ankur Dwivedi Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev.h | 1 + drivers/crypto/octeontx2/otx2_cryptodev_mbox.c | 7 +++ 2 files changed, 8 inserti

[dpdk-dev] [PATCH 1/2] common/octeontx2: sync cpt mailbox

2020-07-31 Thread Ankur Dwivedi
From: Tejasree Kondoj This patch syncs the pmd mailbox with the cpt pf driver. Signed-off-by: Ankur Dwivedi Signed-off-by: Tejasree Kondoj --- drivers/common/octeontx2/otx2_mbox.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/common/octeontx2/otx2_mbox.h b

Re: [dpdk-dev] [PATCH v3] cmdline: increase maximum line length

2020-07-31 Thread David Marchand
On Fri, Jul 31, 2020 at 2:55 PM Olivier Matz wrote: > Ressurecting this old thread. > > On Sat, Feb 22, 2020 at 04:28:15PM +0100, David Marchand wrote: > > This patch is flagged as an ABI breakage: > > https://travis-ci.com/ovsrobot/dpdk/jobs/289313318#L2273 > > > > In case we want this fix for 20

Re: [dpdk-dev] [PATCH] mempool: enhance dump function to print ops name

2020-07-31 Thread Olivier Matz
Hi Hemant, Thank you for submitting this improvement. Minor comments below. On Sat, Jul 11, 2020 at 03:29:36PM +0530, Hemant Agrawal wrote: > Enhance the dump function to also print the ops index > and associated mempool ops name > > Signed-off-by: Hemant Agrawal > --- > lib/librte_mempool/rte

Re: [dpdk-dev] [PATCH v3] cmdline: increase maximum line length

2020-07-31 Thread Olivier Matz
Hi, Ressurecting this old thread. On Sat, Feb 22, 2020 at 04:28:15PM +0100, David Marchand wrote: > This patch is flagged as an ABI breakage: > https://travis-ci.com/ovsrobot/dpdk/jobs/289313318#L2273 > In case we want this fix for 20.11, should we do a deprecation notice in 20.08? Olivier

[dpdk-dev] [PATCH 2/2] net/bnxt: add memory allocation check in vf_info init

2020-07-31 Thread wangyunjian
From: Yunjian Wang The function rte_malloc() could return NULL, the return value need to be checked. Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/bnxt/bnxt_hwrm.c | 6 +- 1 file changed

[dpdk-dev] [PATCH 1/2] net/bnxt: fix memory leak when freeing vf_info

2020-07-31 Thread wangyunjian
From: Yunjian Wang When freeing a vf_info, we should free the 'vlan_as_table' and 'vlan_table' for the vf_info. Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/bnxt/bnxt_ethdev.c | 3 +-- dri

[dpdk-dev] [PATCH 0/2] fixes for bnxt driver

2020-07-31 Thread wangyunjian
From: Yunjian Wang This series include two fixes patches for bnxt driver. Yunjian Wang (2): net/bnxt: fix memory leak when freeing vf_info net/bnxt: add memory allocation check in vf_info init drivers/net/bnxt/bnxt_ethdev.c | 3 +-- drivers/net/bnxt/bnxt_hwrm.c | 22

Re: [dpdk-dev] [PATCH v2] eal/linux: do not create user mem map repeatedly when it exists

2020-07-31 Thread Burakov, Anatoly
On 30-Jul-20 2:16 PM, wangyunjian wrote: -Original Message- From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] Sent: Monday, July 27, 2020 5:24 PM To: wangyunjian ; dev@dpdk.org; david.march...@redhat.com Cc: Lilijun (Jerry) ; xudingke ; sta...@dpdk.org Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [RFC] lib: introduce traffic mirroring API

2020-07-31 Thread Fu, Patrick
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Friday, July 31, 2020 5:32 PM > To: Fu, Patrick > Cc: dev@dpdk.org; Yigit, Ferruh ; > maxime.coque...@redhat.com; Richardson, Bruce > ; Wang, Zhihong ; > Wang, Liang-min ; Ananyev, Konstantin > ; Miskell, Timothy > ; Liang,

Re: [dpdk-dev] [20.11, PATCH v2] baseband/fpga_5gnr_fec: add companion PF config App

2020-07-31 Thread Maxime Coquelin
Hi Nicolas, On 7/16/20 10:20 PM, Nicolas Chautru wrote: > Adding companion application to configure HW Device from the PF. > Then the device can be accessed through BBDEV from VF (or PF). > > Signed-off-by: Nicolas Chautru > --- > doc/guides/bbdevs/fpga_5gnr_fec.rst| 80 +++-- >

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API

2020-07-31 Thread Ananyev, Konstantin
> -Original Message- > From: Akhil Goyal > Sent: Thursday, July 30, 2020 8:14 PM > To: dev@dpdk.org; ano...@marvell.com; Nicolau, Radu ; > Ananyev, Konstantin > ; Doherty, Declan ; > Zhang, Roy Fan > Cc: tho...@monjalon.net; Trahe, Fiona ; > adwiv...@marvell.com; hemant.agra...@nxp.

Re: [dpdk-dev] [PATCH v2 1/2] doc: announce rte_dev_probe() API change

2020-07-31 Thread Maxime Coquelin
On 7/31/20 11:44 AM, Gaëtan Rivet wrote: > On 31/07/20 10:26 +0100, Bruce Richardson wrote: >> On Thu, Jun 25, 2020 at 10:04:29AM +0200, Maxime Coquelin wrote: >>> In order to simplify the use of rte_dev_probe() and >>> rte_dev_remove() by applications, rte_dev_probe() will >>> return a referenc

Re: [dpdk-dev] [PATCH v2 1/2] doc: announce rte_dev_probe() API change

2020-07-31 Thread Gaëtan Rivet
On 31/07/20 10:26 +0100, Bruce Richardson wrote: > On Thu, Jun 25, 2020 at 10:04:29AM +0200, Maxime Coquelin wrote: > > In order to simplify the use of rte_dev_probe() and > > rte_dev_remove() by applications, rte_dev_probe() will > > return a reference on the rte_device stating DPDK v20.11. > > >

Re: [dpdk-dev] [PATCH] [RFC] doc: announce removal of crypto list end enumerators

2020-07-31 Thread Akhil Goyal
Hi David, > Hi David, > > > > > On Wed, Jul 29, 2020 at 4:47 PM Arek Kusztal > > wrote: > > > > > > Enumerators RTE_CRYPTO_CIPHER_LIST_END, > RTE_CRYPTO_AUTH_LIST_END, > > > RTE_CRYPTO_AEAD_LIST_END will be removed to prevent some problems > > > that may arise when adding new algorithms. > > > >

Re: [dpdk-dev] [PATCH] power: fix current frequency index

2020-07-31 Thread Liang, Ma
Hi Reshma, I'm OK with the change. That's the missing part about init process. Reviewed-by Liang Ma Regards Liang On 29 Jul 14:58, Reshma Pattan wrote: > 1) > During power initialization the pstate cpufreq api is > not setting the initial curr_idx of pstate_power_info > to corresponding cu

Re: [dpdk-dev] [RFC] lib: introduce traffic mirroring API

2020-07-31 Thread Thomas Monjalon
31/07/2020 04:34, Fu, Patrick: > Hi Thomas, > > From: Thomas Monjalon > > > > I assume you consider deprecating rte_eth_mirror_rule_set() > > http://doc.dpdk.org/api/rte__ethdev_8h.html#a1c88c5e86f0358981443600f > > 05069091 > > > Not exactly. > The rte_eth_mirror_rule_set() is vendor-dependen

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API

2020-07-31 Thread Coyle, David
> The API ``rte_security_session_create`` takes only single mempool for > session and session private data. So the application need to create mempool > for twice the number of sessions needed and will also lead to wastage of > memory as session private data need more memory compared to session. > H

Re: [dpdk-dev] [PATCH v2 1/2] doc: announce rte_dev_probe() API change

2020-07-31 Thread Bruce Richardson
On Thu, Jun 25, 2020 at 10:04:29AM +0200, Maxime Coquelin wrote: > In order to simplify the use of rte_dev_probe() and > rte_dev_remove() by applications, rte_dev_probe() will > return a reference on the rte_device stating DPDK v20.11. > > Signed-off-by: Maxime Coquelin > --- Acked-by: Bruce Rich

Re: [dpdk-dev] Userspace testing

2020-07-31 Thread Burakov, Anatoly
On 30-Jul-20 5:54 PM, Owen Hilyard wrote: Thanks for the advice. I was wondering about the state of the "Setup VFIO permissions" option in the setup script. It seems to just modify the character device's permissions and then check their memory limit. Should this option also handle the hugepag

Re: [dpdk-dev] [PATCH] net/bxnt: remove redundant null check

2020-07-31 Thread Ajit Khaparde
On Thu, Jul 30, 2020 at 7:35 PM Gaurav Singh wrote: > vxlan_mask cannot be NULL since its already being accessed > before. Remove the redundant NULL check. > > Signed-off-by: Gaurav Singh > Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_flow.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [dpdk-dev] [PATCH v1] net/ice: revert the TSO fake fix

2020-07-31 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Friday, July 31, 2020 2:00 PM > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Cc: Xu, Ting ; Sun, Chenmin ; > Wang, Yinan ; Wang, Haiyue > ; sta...@dpdk.org > Subject: [PATCH v1] net/ice: revert the TSO fake fix > > The two fixes ar

Re: [dpdk-dev] Userspace testing

2020-07-31 Thread David Marchand
On Wed, Jul 29, 2020 at 4:35 PM Owen Hilyard wrote: > I was wondering what everyone's thoughts on doing both userspace testing > and unprivileged testing of dpdk applications is. DTS currently runs all > commands on the tester and the dut as the root user. Please correct me if > I'm wrong, but I w

Re: [dpdk-dev] [PATCH v2 1/2] doc: announce rte_dev_probe() API change

2020-07-31 Thread Maxime Coquelin
Hi Thomas, Davis, On 6/25/20 10:04 AM, Maxime Coquelin wrote: > In order to simplify the use of rte_dev_probe() and > rte_dev_remove() by applications, rte_dev_probe() will > return a reference on the rte_device stating DPDK v20.11. > > Signed-off-by: Maxime Coquelin > --- > doc/guides/rel_note

Re: [dpdk-dev] [PATCH] maintainers: add Chenbo for Vhost/Virtio/vDPA

2020-07-31 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Thursday, July 30, 2020 9:47 PM > To: dev@dpdk.org; Xia, Chenbo ; Wang, Zhihong > ; Yigit, Ferruh ; > david.march...@redhat.com; tho...@monjalon.net > Cc: Maxime Coquelin > Subject: [PATCH] maintainers: add Chenbo for Vhost/Virtio/vDP