On Fri, 31 Jul 2020 14:55:16 +0200 Olivier Matz <olivier.m...@6wind.com> wrote:
> Hi, > > Ressurecting this old thread. > > On Sat, Feb 22, 2020 at 04:28:15PM +0100, David Marchand wrote: > > This patch is flagged as an ABI breakage: > > https://travis-ci.com/ovsrobot/dpdk/jobs/289313318#L2273 > > > > In case we want this fix for 20.11, should we do a deprecation notice > in 20.08? > > > Olivier > > > > > > On Thu, Feb 20, 2020 at 3:53 PM Wisam Jaddo <wis...@mellanox.com> wrote: > > > > > > This increase due to the usage of cmdline in dpdk applications > > > as config commands such as testpmd do for rte_flow rules creation. > > > > > > The current size of buffer is not enough to fill > > > many cases of rte_flow commands validation/creation. > > > > > > rte_flow now can have outer items, inner items, modify > > > actions, meta data actions, duplicate action, fate action and > > > more in one single rte flow, thus 512 char will not be enough > > > to validate such rte flow rules. > > > > > > Such change shouldn't affect the memory since the cmdline > > > reading again using the same buffer. > > > > I don't get your point here. The cmdline is a awkward user API. Thomas wanted to replace it but it seems to have gotten nowhere. Agree that having something dynamic would be best, Something based of getline() or editline (readline).
