Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

> -Original Message- > From: David Marchand > Sent: Friday, July 10, 2020 5:54 PM > To: Zhang, AlvinX > Cc: dev ; Xing, Beilei ; Guo, Jia > > Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource > > On Wed, Jul 8, 2020 at 11:26 AM wrote: > > > > From: Alvin Zhang > > > > Whe

Re: [dpdk-dev] [PATCH v5 1/2] rte_flow: add eCPRI key fields to flow API

Hi Olivier, Many thanks for your comments. > -Original Message- > From: Olivier Matz > Sent: Friday, July 10, 2020 10:31 PM > To: Bing Zhao > Cc: Ori Kam ; john.mcnam...@intel.com; > marko.kovace...@intel.com; Thomas Monjalon > ; ferruh.yi...@intel.com; > arybche...@solarflare.com; akhil

Re: [dpdk-dev] [PATCH v2] pci: keep API compatibility with mmap values

Tested-by:ma,lhong Regards, Ma,lihong -Original Message- From: dev On Behalf Of Thomas Monjalon Sent: Saturday, July 11, 2020 4:41 AM To: dev@dpdk.org Cc: david.march...@redhat.com; Yigit, Ferruh ; gr...@u256.net; Zhang, AlvinX ; Xing, Beilei ; Guo, Jia ; Burakov, Anatoly ; Richardson

Re: [dpdk-dev] [PATCH] pci: keep API compatibility with mmap values

tested-by:ma,Lihong Regards, Ma,lihong -Original Message- From: dev On Behalf Of Thomas Monjalon Sent: Friday, July 10, 2020 7:53 PM To: dev@dpdk.org Cc: david.march...@redhat.com; Yigit, Ferruh ; gr...@u256.net; Zhang, AlvinX ; Xing, Beilei ; Guo, Jia ; Burakov, Anatoly ; Richardson,

Re: [dpdk-dev] [PATCHv2 1/2] bitratestats: add support for free

Missed it. I will send v3 Get BlueMail for Android On 11 Jul 2020, at 4:00 AM, Thomas Monjalon mailto:tho...@monjalon.net>> wrote: 19/05/2020 17:19, Stephen Hemminger: On Thu, 14 May 2020 15:00:00 +0530 Hemant Agrawal wrote: +int +rte_stats_bitrate_free(st

Re: [dpdk-dev] [PATCH V2] net/bonding: fix lacp negotiation failed

On 7/11/2020 2:20 AM, Wei Hu (Xavier) wrote: > > On 2020/7/10 11:29, luyicai wrote: >> From: Yicai Lu >> >> When two host is connected directly without any devices like switch, >> rx_machine_update would recieving partner lacp negotiation packets, >> and partner's port mac is filled with zeros i

Re: [dpdk-dev] [PATCH v1] app/testpmd: add 5tswap forwarding engine

On 7/2/2020 4:16 PM, Shiri Kuzin wrote: > The new 5-tuple swap engine swaps: > source and destination mac address, > source and destination address in ipv4/ipv6, > source and destination port in UDP/TCP. > > The forwarding engine will parse each layer > and swap it, and will stop when the next > l

Re: [dpdk-dev] [PATCH v2] net/pcap: support snaplen option to truncate packet

On 7/3/2020 7:47 AM, Zhike Wang wrote: > Introduced "snaplen=" option. It is convenient to truncate > large packets to only capture necessary headers. > > Signed-off-by: Zhike Wang > --- > app/pdump/main.c| 32 +++- > drivers/net/pcap/rte_eth_pcap.c |

Re: [dpdk-dev] [PATCH] drivers/net/bonding: fix bug for lacp negotiation failed

Hi, Thomas Monjalon The patch V2 has been sent by luyicai, and V2 is good to me. Thanks, Xavier On 2020/7/11 5:07, Thomas Monjalon wrote: Still no review. Please give your real name in the Signed-off so it can be merged. 24/06/2020 12:43, Thomas Monjalon: Any review please? 19/05/202

Re: [dpdk-dev] [PATCH V2] net/bonding: fix lacp negotiation failed

Reviewed-by: Wei Hu (Xavier) On 2020/7/10 11:29, luyicai wrote: From: Yicai Lu When two host is connected directly without any devices like switch, rx_machine_update would recieving partner lacp negotiation packets, and partner's port mac is filled with zeros in this packet, which is differe

Re: [dpdk-dev] [PATCH v7 1/3] drivers/net: fix build with internal API usage

On 7/11/2020 12:17 AM, Ferruh Yigit wrote: > On 7/10/2020 11:07 PM, Thomas Monjalon wrote: >> 10/07/2020 23:43, Ferruh Yigit: >>> Using '__rte_internal' tag in 'rte_ethdev_driver.h' causing build error >>> for applications and examples. Because they don't define >>> 'ALLOW_INTERNAL_API' flag and '_

Re: [dpdk-dev] [PATCH v6 1/4] doc: add generic atomic deprecation section

> Subject: Re: [dpdk-dev] [PATCH v6 1/4] doc: add generic atomic deprecation > section > > Interestingly, John, our doc maintainer is not Cc'ed. > I add him. > Please use --cc-cmd devtools/get-maintainer.sh I am expecting a review from > an x86 maintainer as well. > If no maintainer replies, pin

Re: [dpdk-dev] [PATCH v6 2/4] maintainers: claim maintainers of C11 atomics

> > 07/07/2020 11:50, Phil Yang: > > Add the maintainership of C11 atomics code. Different maintainers > > focus on different platforms C11 atomics. > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > +C11 Atomics Code Maintainer > > +M: Honnappa Nagarahalli > > +M: David Christensen > > I rememb

Re: [dpdk-dev] [PATCH v7 1/3] drivers/net: fix build with internal API usage

On 7/10/2020 11:07 PM, Thomas Monjalon wrote: > 10/07/2020 23:43, Ferruh Yigit: >> Using '__rte_internal' tag in 'rte_ethdev_driver.h' causing build error >> for applications and examples. Because they don't define >> 'ALLOW_INTERNAL_API' flag and '__rte_internal' causes the error. >> This patch is

Re: [dpdk-dev] [PATCH] net/nfp: fix RSS hash configuration reporting

On 7/10/2020 3:28 PM, Heinrich Kuhn wrote: > Prior to this fix the NFP PMD implementation of the .rss_hash_conf_get > callback did not propagate the current hardware state of rss_hf back up > to the caller. Users of the hash_conf_get callback would receive an > incorrect representation of what the

Re: [dpdk-dev] [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function

> From: Thomas Monjalon > 26/06/2020 03:14, Chautru, Nicolas: > > > From: Thomas Monjalon > > > 25/06/2020 02:30, Chautru, Nicolas: > > > > > From: Thomas Monjalon : > > > > > 02/05/2020 01:15, Chautru, Nicolas: > > > > > > Hi Akhil, Thomas, > > > > > > > > > > > > Following up on that previous di

Re: [dpdk-dev] [PATCH v3] mempool/ring: add support for new ring sync modes

10/07/2020 18:21, Konstantin Ananyev: > Two new sync modes were introduced into rte_ring: > relaxed tail sync (RTS) and head/tail sync (HTS). > This change provides user with ability to select these > modes for ring based mempool via mempool ops API. No, the user cannot use these modes because the

Re: [dpdk-dev] [PATCHv2 1/2] bitratestats: add support for free

19/05/2020 17:19, Stephen Hemminger: > On Thu, 14 May 2020 15:00:00 +0530 > Hemant Agrawal wrote: > > > > +int > > +rte_stats_bitrate_free(struct rte_stats_bitrates *bitrate_data) > > +{ > > + if (bitrate_data) > > + rte_free(bitrate_data); > > + return 0; > > +} > > rte_free of N

[dpdk-dev] [PATCH v1] BBDEV FPGA PF Config app

Addition of an stand alone application in PMD driver to be able to configure the HW from PF. Then the VF can be used from container/VM running BBDEV/DPDK. The history of the previous discussions can be tracked on this previous patch https://patches.dpdk.org/patch/67379/ PMD documentation is upd

[dpdk-dev] [PATCH v1] baseband/fpga_5gnr_fec: add companion PF config App

Adding companion application to configure HW Device from the PF. Then the device can be accessed through BBDEV from VF (or PF). Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/fpga_5gnr_fec.rst| 81 +++-- .../baseband/fpga_5gnr_fec/pf_config_app/Makefile | 36 ++ .../fpga

Re: [dpdk-dev] [PATCH v7 1/3] drivers/net: fix build with internal API usage

10/07/2020 23:43, Ferruh Yigit: > Using '__rte_internal' tag in 'rte_ethdev_driver.h' causing build error > for applications and examples. Because they don't define > 'ALLOW_INTERNAL_API' flag and '__rte_internal' causes the error. > This patch is preparation for future '__rte_internal' usage. > >

Re: [dpdk-dev] [PATCH v7 1/2] mbuf: introduce accurate packet Tx scheduling

On 7/10/2020 4:46 PM, Slava Ovsiienko wrote: > > >> -Original Message- >> From: dev On Behalf Of Viacheslav Ovsiienko >> Sent: Friday, July 10, 2020 15:40 >> To: dev@dpdk.org >> Cc: Matan Azrad ; Raslan Darawsheh >> ; olivier.m...@6wind.com; >> arybche...@solarflare.com; Thomas Monjalon

[dpdk-dev] [PATCH v20.11] net/dpaa: fix public API port ID type

Signed-off-by: Ferruh Yigit --- Hi Hemant, Can you please send a deprecation notice to be able to fix in 20.11? btw, is this API still used, if it is not used should it be deprecated? --- drivers/net/dpaa/rte_pmd_dpaa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [dpdk-dev] [PATCH v5 1/8] eal/x86: introduce AVX 512-bit type

Please Cc those who participated in the review previously. Adding Ray, Jerin, David. 10/07/2020 16:46, Vladimir Medvedkin: > New data type to manipulate 512 bit AVX values. [...] > +#ifdef __AVX512F__ > + > +#define RTE_X86_ZMM_SIZE(sizeof(__m512i)) > +#define RTE_X86_ZMM_MASK

[dpdk-dev] [PATCH v7 2/3] ethdev: add function to release HW rings

From: Renata Saiakhova Free previously allocated memzone for HW rings Signed-off-by: Renata Saiakhova Reviewed-by: Ferruh Yigit Acked-by: Andrew Rybchenko --- v6: * Converted macro to static inline function * Updated API return error value v7: * Application build fixed for __rte_internal usa

[dpdk-dev] [PATCH v7 1/3] drivers/net: fix build with internal API usage

Using '__rte_internal' tag in 'rte_ethdev_driver.h' causing build error for applications and examples. Because they don't define 'ALLOW_INTERNAL_API' flag and '__rte_internal' causes the error. This patch is preparation for future '__rte_internal' usage. At first place, applications/examples shoul

[dpdk-dev] [PATCH v7 3/3] drivers/net: delete HW rings while freeing queues

From: Renata Saiakhova Delete memzones for HW rings in igb and ixgbe while freeing queues Updated igb, ixgbe, i40e, ice & em drivers. Signed-off-by: Renata Saiakhova Reviewed-by: Ferruh Yigit --- drivers/net/e1000/em_rxtx.c| 2 ++ drivers/net/e1000/igb_rxtx.c | 2 ++ drivers/net/i40e/i

Re: [dpdk-dev] [PATCH v2] doc: add rib and fib into the API doxygen index

08/07/2020 20:31, Vladimir Medvedkin: > Add RIB/FIB library into the API doxygen index. RIB and FIB should be uppercased also in the title. > Move LPM/LPM6 under separate section "Longest prefix match" You didn't update this sentence. > Fixes: 5a5793a5ffa2 ("rib: add RIB library") > Fixes: f7e8

Re: [dpdk-dev] [EXTERNAL] 18.11.9 (LTS) patches review and test

Hi Kevin, We validated DPDK 18.11.9-rc2 release. We found out there was an issue in our test framework with RHEL/CentOS images which was resolved and we didn't find any issues in this release. Regards, Abhishek Test details: DPDK v18.11.9-rc2 was validated on Azure for Canonical UbuntuServe

Re: [dpdk-dev] [PATCH v2] eal/windows: detect insufficient privileges for hugepages

09/07/2020 00:27, Ranjit Menon: > On 7/8/2020 2:48 PM, Dmitry Kozlyuk wrote: > > AdjustTokenPrivileges() succeeds even if no requested privileges have > > been granted; this behavior is documented. Check last error code in > > addition to return value to detect such case. > > > > Make error message

Re: [dpdk-dev] [dpdk-stable] [PATCH] net: fix checksum on big endian CPUs

10/07/2020 14:37, Olivier Matz: > On Fri, Jul 10, 2020 at 02:20:08PM +0200, Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hongzhi Guo > > > Sent: Friday, July 10, 2020 1:43 PM > > > > > > With current code, the checksum of odd-length buffers is wrong on > > > big

Re: [dpdk-dev] [PATCH v2] pci: keep API compatibility with mmap values

On Fri, 10 Jul 2020 22:40:34 +0200, Thomas Monjalon wrote: > The function pci_map_resource() returns MAP_FAILED in case of error. > When replacing the call to mmap() by rte_mem_map(), > the error code became NULL, breaking the API. > This function is probably not used outside of DPDK, > but it is s

Re: [dpdk-dev] [PATCH] drivers/net/bonding: fix bug for lacp negotiation failed

Still no review. Please give your real name in the Signed-off so it can be merged. 24/06/2020 12:43, Thomas Monjalon: > Any review please? > > 19/05/2020 13:18, luyicai: > > When two host is connected directly without any devices like switch, > > and also enable dedicated tx/rx queues on bonding

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

10/07/2020 16:40, Olivier Matz: > > > > > > > On Fri, Jul 10, 2020 at 02:55:51PM +0800, Hongzhi Guo wrote: > > > > > > > > Per RFC768: > > > > > > > > If the computed checksum is zero, it is transmitted as all > > > ones. > > > > > > > > An all zero transmitted checksum value means that the > > > t

Re: [dpdk-dev] [PATCH 20.08] telemetry: add upper limit on connections

19/05/2020 02:07, Stephen Hemminger: > On Mon, 18 May 2020 17:12:32 +0100 > Ciara Power wrote: > > > This patch limits the number of client connections to the new telemetry > > socket. The limit is set at 10. > > > > Signed-off-by: Ciara Power > > The upper limit is fine, but using System V se

Re: [dpdk-dev] [PATCH 14/27] event/dlb: add PMD self-tests

Hi Tim, > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Minor nit: I did a test build, looks like rte_ethdev.h, rte_per_lcore.h, and rte_pause.h are not required, but rte_mbuf.h and rte_mempool.h are.

[dpdk-dev] [PATCH v2] pci: keep API compatibility with mmap values

The function pci_map_resource() returns MAP_FAILED in case of error. When replacing the call to mmap() by rte_mem_map(), the error code became NULL, breaking the API. This function is probably not used outside of DPDK, but it is still a problem for two reasons: - the deprecation process was

Re: [dpdk-dev] [PATCH] pci: keep API compatibility with mmap values

10/07/2020 20:31, Dmitry Kozlyuk: > On Fri, 10 Jul 2020 13:53:24 +0200, Thomas Monjalon wrote: > > --- /dev/null > > +++ b/lib/librte_eal/windows/include/sys/mman.h > > @@ -0,0 +1,9 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright 2020 Mellanox Technologies, Ltd > > + */ > > + > >

Re: [dpdk-dev] [RFC PATCH 3/3] net/pcap: support hardware Tx timestamps

Hello Olivier and Slava, On Tue, Jul 7, 2020 at 10:47 AM Olivier Matz wrote: > For the pmd pcap part, the dynamic Tx timestamp flag that is being > introduced by Slava [1] may fit your needs: ie. when the flag is set, it > uses the provided timestamp which should be in nanosecs. > > [1] https://p

Re: [dpdk-dev] [PATCH v7 0/25] ethdev: allow unknown link speed

10.07.2020 18:02, Thomas Monjalon пишет: > There are still comments in this patchset which is doing two things: > 1/ declare unknown speed > 2/ format link infos 3/ update drivers with unknown speed. this patchset contains only Intel drivers. remaining drivers will be provided later.

Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add a link status text representation

> Subject: Re: [PATCH v7 02/25] ethdev: add a link status text representation > > 10.07.2020 16:06, Yigit, Ferruh пишет: > > On 7/10/2020 8:02 AM, Ivan Dyukov wrote: > >> This commit add function which treat link status structure and format > >> it to text representation. > >> > >> Signed-off-by:

Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add a link status text representation

10.07.2020 18:22, Stephen Hemminger пишет: > On Fri, 10 Jul 2020 13:06:02 + > "Yigit, Ferruh" wrote: > >>> + /* ignore unknown specifier */ >>> + default: >>> + *str_cur = '%'; >>> + offset++; >>> +

Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add a link status text representation

10.07.2020 16:06, Yigit, Ferruh пишет: > On 7/10/2020 8:02 AM, Ivan Dyukov wrote: >> This commit add function which treat link status structure >> and format it to text representation. >> >> Signed-off-by: Ivan Dyukov > <...> > >> +static int >> +rte_eth_link_strf_parser(char *str, size_t len, con

Re: [dpdk-dev] [PATCH] pci: keep API compatibility with mmap values

My apologies for not examining mmap() usage thoroughly enough when designing these internal APIs. I support your suggestion to move PCI mapping functions to bus driver after proper deprecation. On Fri, 10 Jul 2020 13:53:24 +0200, Thomas Monjalon wrote: [snip] > diff --git a/lib/librte_eal/include/

Re: [dpdk-dev] [PATCH] app/procinfo: enhance port and mempool info

On Fri, 10 Jul 2020 21:36:10 +0530 Hemant Agrawal wrote: > + printf("\t MAC: %02" PRIx8 ":%02" PRIx8 ":%02" PRIx8 > + ":%02" PRIx8 ":%02" PRIx8 ":%02" PRIx8"\n", > + ethaddr.addr_bytes[0], ethaddr.addr_bytes[1], > +

Re: [dpdk-dev] [PATCH 0/5] bnxt bug fixes

On Thu, Jul 9, 2020 at 2:23 AM Kalesh A P < kalesh-anakkur.pura...@broadcom.com> wrote: > From: Kalesh AP > > This patchset contains few bug fixes in bnxt PMD. > > Please apply. > > Kalesh AP (5): > net/bnxt: fix to avoid unnecessary memory allocation > net/bnxt: remove unused enum declaratio

Re: [dpdk-dev] [PATCH] net/bnxt: fix build issue

On Thu, Jul 9, 2020 at 7:34 AM Ajit Khaparde wrote: > > > On Thu, Jul 9, 2020 at 1:15 AM David Marchand > wrote: > >> In existing build env, RTE_LIBRTE_BNXT_PMD_SYSTEM is unset. >> Testing against a n value does not work and we end up with a link issue: >> >> /usr/bin/ld: tf_core/tf_em_common.o:

Re: [dpdk-dev] [EXTERNAL] 18.11.9 (LTS) patches review and test

On 10/07/2020 18:28, Abhishek Marathe wrote: > Hi Kevin, > Hi Abhishek, > We validated DPDK 18.11.9-rc2 release. We found out there was an issue in our > test framework with RHEL/CentOS images which was resolved and we didn't find > any issues in this release. > That's good to hear. I made t

Re: [dpdk-dev] [PATCH v6 2/4] maintainers: claim maintainers of C11 atomics

07/07/2020 11:50, Phil Yang: > Add the maintainership of C11 atomics code. Different maintainers focus > on different platforms C11 atomics. > --- a/MAINTAINERS > +++ b/MAINTAINERS > +C11 Atomics Code Maintainer > +M: Honnappa Nagarahalli > +M: David Christensen I remember we discussed the need

Re: [dpdk-dev] [PATCH] ether: use named constants for deprecated QinQ TPIDs

On 6/19/2020 10:21 AM, Andrew Rybchenko wrote: > From: Ivan Malov > > Add named constants for deprecated QinQ TPIDs. > Update drivers which have already been using existing > TPID named constants from librte_net to use the > new named constants rather than magic numbers. > > Signed-off-by: Ivan

[dpdk-dev] Idem with Multicast Packets Feature

Hi all, The Idem with Multicast Packets test will first create three groups of port combinations. The first group will have both ports be capable of receiving a packet. The second group will have one port be open to receive a packet and one be closed. The third group will have both ports be closed

[dpdk-dev] [PATCH v2 9/9] net/dpaa: add RSS update func with FMCless

From: Sachin Saxena With fmlib (FMCLESS) mode now RSS can be modified on runtime. This patch add support for RSS update functions Signed-off-by: Hemant Agrawal Signed-off-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethdev.c | 37 ++ 1 file changed, 37 insertion

[dpdk-dev] [PATCH v2 5/9] bus/dpaa: add shared MAC support

From: Radu Bulie A shared MAC interface is an interface which can be used by both kernel and userspace based on classification configuration It is defined in dts with the compatible string "fsl,dpa-ethernet-shared" which bpool will be seeded by the dpdk partition and configured as a netdev by the

[dpdk-dev] [PATCH v2 7/9] net/dpaa: add support for Virtual Storage Profile

From: Jun Yang This patch adds support for Virtual Storage profile (VSP) feature. With VSP support when memory pool is created, the hw buffer pool id i.e. bpid is not allocated; thhe bpid is identified by dpaa flow create API. The memory pool of RX queue is attached to specific BMan pool accordin

[dpdk-dev] [PATCH v2 8/9] net/dpaa: add fmc parser support for VSP

From: Jun Yang Parse the fmc.bin generated by fmc to setup RXQs for each port on fmc mode. The parser gets the fqids and vspids from fmc.bin. Signed-off-by: Jun Yang --- drivers/net/dpaa/Makefile | 1 + drivers/net/dpaa/dpaa_ethdev.c | 26 +- drivers/net/dpaa/dpaa_ethdev.h | 10 +- dr

[dpdk-dev] [PATCH v2 4/9] net/dpaa: add support for fmcless mode

From: Sachin Saxena This patch uses fmlib to configure the FMAN HW for flow and distribution configuration, thus avoiding the need for static FMC tool execution optionally. Signed-off-by: Sachin Saxena Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/Makefile | 1 + drivers/net/dpaa/

[dpdk-dev] [PATCH v2 3/9] net/dpaa: add VSP support in FMLIB

From: Jun Yang This patch adds support for VSP (Virtual Storage Profile) in fmlib routines. VSP allow a network interface to be divided into physical and virtual instance(s). The concept is very similar to SRIOV. Signed-off-by: Jun Yang --- drivers/net/dpaa/Makefile | 1 + drivers/

[dpdk-dev] [PATCH v2 1/9] net/dpaa: support Rxq and Txq info routines

This patch add support for rxq_info_get and txq_info_get Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/include/fsl_qman.h | 3 ++ drivers/net/dpaa/dpaa_ethdev.c | 51 +++-- 2 files changed, 52 insertions(+), 2 deletions(-) diff --git a/drivers/bus/dpaa/include

[dpdk-dev] [PATCH v2 6/9] bus/dpaa: add Virtual Storage Profile port init

This patch add support to initialize the VSP ports in the FMAN library. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 57 +++ drivers/bus/dpaa/include/fman.h | 3 ++ 2 files changed, 60 insertions(+) diff --git a/drivers/bus/dpaa/base/fman/

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix CPU cycles per pkt stats on transmit modes

On 6/22/2020 10:04 AM, Phil Yang wrote: > In txonly and flowgen forwarding mode, calculating CPU per packets with > total received packets is not accurate. Use total transmitted packets > for these cases. > > The error output under txonly mode: > testpmd> show fwd stats all > > --

Re: [dpdk-dev] [PATCH] pci: keep API compatibility with mmap values

10/07/2020 13:53, Thomas Monjalon: > The function pci_map_resource() returns MAP_FAILED in case of error. > When replacing the call to mmap() by rte_mem_map(), > the error code became NULL, breaking the API. > This function is probably not used outside of DPDK, > but it is still a problem for two r

Re: [dpdk-dev] [PATCH v3 03/10] check_maintainers: change variable names

13/06/2020 02:00, Stephen Hemminger: > Use blocklist where blacklist was used and allowlist > where whitelist was used. This is a mechanical, not accurate, replacement. > Signed-off-by: Stephen Hemminger > Acked-by: Luca Boccassi > --- > --- a/devtools/check-maintainers.sh > +++ b/devtools/chec

Re: [dpdk-dev] [PATCH v2] app/testpmd: remove softnic forward mode

On 6/23/2020 10:32 AM, Jasvinder Singh wrote: > Softnic can be used like other virtual devices without > needing any special mode. Therefore, remove softnic mode > from testpmd app. Documentation is updated as well. > > Signed-off-by: Jasvinder Singh > Acked-by: Cristian Dumitrescu Applied to d

Re: [dpdk-dev] [PATCH v6 1/4] doc: add generic atomic deprecation section

Interestingly, John, our doc maintainer is not Cc'ed. I add him. Please use --cc-cmd devtools/get-maintainer.sh I am expecting a review from an x86 maintainer as well. If no maintainer replies, ping them. 07/07/2020 11:50, Phil Yang: > Add deprecating the generic rte_atomic_xx APIs to c11 atomic b

[dpdk-dev] [PATCH] Add RSS Key Update Feature

This is test case use Toeplitz hash function to check for RSS Key Update. Signed-off-by: David Liu --- test_plans/rss_key_update_test_plan.rst | 121 +++ tests/TestSuite_rss_key_update.py | 412 2 files changed, 533 insertions(+) create mode 100644 test_plans/

Re: [dpdk-dev] [PATCH] net/enic: support burst mode info

On 7/2/2020 4:14 AM, Hyong Youb Kim wrote: > Add Rx/Tx burst mode getter handlers. > > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH 9/9] net/dpaa: support Rxq and Txq info routines

This patch add support for rxq_info_get and txq_info_get Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/include/fsl_qman.h | 3 ++ drivers/net/dpaa/dpaa_ethdev.c | 51 +++-- 2 files changed, 52 insertions(+), 2 deletions(-) diff --git a/drivers/bus/dpaa/include

[dpdk-dev] [PATCH 7/9] net/dpaa2: add support to use Tx Queue desc size

Add support to use Tx queue desc size to configure congestion notification on TX queue Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c

[dpdk-dev] [PATCH 8/9] net/dpaa2: support Rxq and Txq info routines

This patch add support for rxq_info_get and txq_info_get Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 7 ++-- drivers/net/dpaa2/dpaa2_ethdev.c| 48 - 2 files changed, 52 insertions(+), 3 deletions(-) diff --git a/drivers/bus/fslmc/

[dpdk-dev] [PATCH 5/9] net/dpaa: report error on using deferred start

This patch add support to report on error for rx and tx deferred start config Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c inde

[dpdk-dev] [PATCH 6/9] net/dpaa2: report error on queue deferred start

This patch add support to reports errors on configuring deferred start for rx or tx queues. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dp

[dpdk-dev] [PATCH 3/9] net/dpaa: add Tx/Rx burst mode info

From: Apeksha Gupta Retrieve burst mode information according to the selected Rx/Tx mode and offloads. Signed-off-by: Apeksha Gupta --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 70 ++- 2 files changed, 70 insertions(+), 1 deletio

[dpdk-dev] [PATCH 2/9] net/dpaa2: support per port Rx mbuf timestamp

DEV_RX_OFFLOAD_TIMESTAMP is per port, so the internal implementation shall enable it on per port basis only. Signed-off-by: Hemant Agrawal --- doc/guides/nics/features/dpaa2.ini | 2 ++ drivers/net/dpaa2/dpaa2_ethdev.c | 4 ++-- drivers/net/dpaa2/dpaa2_ethdev.h | 2 +- drivers/net/dpaa2/dpaa

[dpdk-dev] [PATCH 1/9] net/dpaa2: remove Rx timestamp enable PMD API

This experimental API is no longer required as the same purpose can be solved with standard DEV_RX_OFFLOAD_TIMESTAMP Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 8 +--- drivers/net/dpaa2/dpaa2_ethdev.h | 2 +- drivers/net/dpaa2/dpaa2_rxtx.c| 2 +- drivers/ne

[dpdk-dev] [PATCH 4/9] net/dpaa2: add Tx/Rx burst mode info

From: Apeksha Gupta Retrieve burst mode information according to the selected Tx/Rx mode and offloads. Signed-off-by: Apeksha Gupta --- doc/guides/nics/features/dpaa2.ini | 2 + drivers/net/dpaa2/dpaa2_ethdev.c | 73 ++ 2 files changed, 75 insertions(+) diff --g

[dpdk-dev] [PATCH v3] mempool/ring: add support for new ring sync modes

Two new sync modes were introduced into rte_ring: relaxed tail sync (RTS) and head/tail sync (HTS). This change provides user with ability to select these modes for ring based mempool via mempool ops API. Signed-off-by: Konstantin Ananyev Acked-by: Gage Eads --- v3: silently ignore F_SP_PUT/F_S

Re: [dpdk-dev] [PATCH] doc: mark internal symbols in ethdev

On 7/10/2020 3:20 PM, Thomas Monjalon wrote: > 26/06/2020 10:49, Kinsella, Ray: >> On 23/06/2020 14:49, Ferruh Yigit wrote: >>> The APIs are marked in the doxygen comment but better to mark the >>> symbols too. This is planned for v20.11 release. >>> >>> Signed-off-by: Ferruh Yigit >>> --- >>> +*

Re: [dpdk-dev] [PATCH] pci: keep API compatibility with mmap values

10/07/2020 17:39, Burakov, Anatoly: > On 10-Jul-20 12:53 PM, Thomas Monjalon wrote: > > The function pci_map_resource() returns MAP_FAILED in case of error. > > When replacing the call to mmap() by rte_mem_map(), > > the error code became NULL, breaking the API. > > This function is probably not us

[dpdk-dev] [PATCH] app/procinfo: enhance port and mempool info

This patch enhances the port info for more details about the port and queues. This patch also add support to get info about the mempool ops. Signed-off-by: Hemant Agrawal --- app/proc-info/main.c | 63 1 file changed, 52 insertions(+), 11 deletions(-)

Re: [dpdk-dev] [PATCH v7 0/25] ethdev: allow unknown link speed

10/07/2020 17:47, Yigit, Ferruh: > > Subject: Re: [dpdk-dev] [PATCH v7 0/25] ethdev: allow unknown link speed > > > > There are still comments in this patchset which is doing two things: > > 1/ declare unknown speed > > 2/ format link infos > > > > Could we merge the first part in 20.08-r

Re: [dpdk-dev] [PATCH 9/9] app/test-bbdev: add python2 deprecation notice

> From: Kilheeney, Louise > > Cc: Nicolas Chautru > > Signed-off-by: Louise Kilheeney > --- > app/test-bbdev/test-bbdev.py | 4 > 1 file changed, 4 insertions(+) > > diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py > index e127fb2eb..5ae2dc6c4 100755 > --- a/app/

Re: [dpdk-dev] [PATCH v6 1/3] ethdev: add new RSS types for IPv6 prefix

On 7/9/2020 3:06 AM, Qi Zhang wrote: > From: Junfeng Guo > > This patch defines new RSS offload types for IPv6 prefix with 32, 40, 48, > 56, 64, 96 bits of both SRC and DST IPv6 address. > Ref https://tools.ietf.org/html/rfc6052. > > Signed-off-by: Junfeng Guo > Signed-off-by: Qi Zhang Review

Re: [dpdk-dev] [PATCH v6 2/3] app/testpmd: support extended RSS offload types

On 7/9/2020 3:06 AM, Qi Zhang wrote: > From: Junfeng Guo > > This patch adds testpmd cmdline support for IPv6 prefix. > > Signed-off-by: Junfeng Guo > Signed-off-by: Qi Zhang Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v7 0/25] ethdev: allow unknown link speed

> Subject: Re: [dpdk-dev] [PATCH v7 0/25] ethdev: allow unknown link speed > > There are still comments in this patchset which is doing two things: > 1/ declare unknown speed > 2/ format link infos > > Could we merge the first part in 20.08-rc1, while waiting to complete the > second

Re: [dpdk-dev] [PATCH v7 1/2] mbuf: introduce accurate packet Tx scheduling

> -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Friday, July 10, 2020 15:40 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; olivier.m...@6wind.com; > arybche...@solarflare.com; Thomas Monjalon ; > ferruh.yi...@intel.com > Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] DPDK hugepage memory fragmentation

On 10-Jul-20 11:28 AM, Bruce Richardson wrote: On Fri, Jul 10, 2020 at 02:52:16PM +0530, Kamaraj P wrote: Hello All, We are running to run DPDK based application in a container mode, When we do multiple start/stop of our container application, the DPDK initialization seems to be failing. This i

Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add a link status text representation

> On Fri, 10 Jul 2020 13:06:02 + > "Yigit, Ferruh" wrote: > > > > + /* ignore unknown specifier */ > > > + default: > > > + *str_cur = '%'; > > > + offset++; > > > + fmt_cur--; > > > +

Re: [dpdk-dev] [PATCH] pci: keep API compatibility with mmap values

On 10-Jul-20 12:53 PM, Thomas Monjalon wrote: The function pci_map_resource() returns MAP_FAILED in case of error. When replacing the call to mmap() by rte_mem_map(), the error code became NULL, breaking the API. This function is probably not used outside of DPDK, but it is still a problem for tw

[dpdk-dev] Minutes of Technical Board Meeting, 2020-07-01

Meeting notes for the DPDK technical board meeting held on 2020-07-01 Members Attending - - Bruce - Ferruh - Hemant - Honnappa - Jerin - Kevin - Konstantin - Olivier (chair) - Stephen - Thomas The technical board meetings takes place every second Wednesday on IRC channel #dpdk-bo

Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add a link status text representation

On Fri, 10 Jul 2020 13:06:02 + "Yigit, Ferruh" wrote: > > + /* ignore unknown specifier */ > > + default: > > + *str_cur = '%'; > > + offset++; > > + fmt_cur--; > > +

Re: [dpdk-dev] [PATCH v2] mempool/ring: add support for new ring sync modes

> > Hi Olivier, > > > Hi Konstantin, > > > > On Thu, Jul 09, 2020 at 05:55:30PM +, Ananyev, Konstantin wrote: > > > Hi Olivier, > > > > > > > Hi Konstantin, > > > > > > > > On Mon, Jun 29, 2020 at 05:10:24PM +0100, Konstantin Ananyev wrote: > > > > > v2: > > > > > - update Release Notes (

Re: [dpdk-dev] [PATCH v3] lib/librte_timer:fix corruption with reset

On Fri, 10 Jul 2020 11:59:54 +0500 Sarosh Arif wrote: > If the user tries to reset/stop some other timer in it's callback > function, which is also about to expire, using > rte_timer_reset_sync/rte_timer_stop_sync the application goes into > an infinite loop. This happens because > rte_timer_re

Re: [dpdk-dev] [PATCH v2] mempool/ring: add support for new ring sync modes

Hi Olivier, > Hi Konstantin, > > On Thu, Jul 09, 2020 at 05:55:30PM +, Ananyev, Konstantin wrote: > > Hi Olivier, > > > > > Hi Konstantin, > > > > > > On Mon, Jun 29, 2020 at 05:10:24PM +0100, Konstantin Ananyev wrote: > > > > v2: > > > > - update Release Notes (as per comments) > > > > > >

Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add a link status text representation

10/07/2020 09:02, Ivan Dyukov: > This commit add function which treat link status structure > and format it to text representation. It is missing an explanation about why it is required. Which problem is it solving? > Signed-off-by: Ivan Dyukov I'm surprised there is not so much review on this

Re: [dpdk-dev] [PATCH v3 00/10] rename blacklist/whitelist to block/allow

On Sat, Jun 13, 2020 at 2:01 AM Stephen Hemminger wrote: > > The terms blacklist and whitelist are often seen as reminders > of the divisions in society. Instead, use more exact terms for > handling of which devices are used in DPDK. > > This is a proposed change for DPDK 20.08 to replace the name

Re: [dpdk-dev] [PATCH v7 0/25] ethdev: allow unknown link speed

There are still comments in this patchset which is doing two things: 1/ declare unknown speed 2/ format link infos Could we merge the first part in 20.08-rc1, while waiting to complete the second part in -rc2 or 20.11? How much both parts are related?

[dpdk-dev] Using valgrind with DPDK app

Hi all, I would like to know if it's possible to run my DPDK application (I'm using DPDK 19.11) under Valgrind. I tried but it gets stuck apparently while accessing hugepages: AL: Detected memory type: socket_id:0 hugepage_sz:1073741824 EAL: Detected memory type: socket_id:1 hugepage_sz:1073

Re: [dpdk-dev] [PATCH v7 04/25] doc: update sample app with unknown speed

10/07/2020 09:02, Ivan Dyukov: > Add usage of rte_eth_link_strf function to example > applications > > Signed-off-by: Ivan Dyukov > --- > doc/guides/sample_app_ug/link_status_intr.rst | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) This one reason why I don't like code in doc

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

On Fri, Jul 10, 2020 at 04:40:59PM +0200, Olivier Matz wrote: > On Fri, Jul 10, 2020 at 03:56:11PM +0200, Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > > > Sent: Friday, July 10, 2020 3:41 PM > > > > > > On Fri, Jul 10, 2020 at 03:29:36PM +0200, Mor

[dpdk-dev] [PATCH v5 8/8] app/testfib: add support for different lookup functions

Added -v option to switch between different lookup implementations to measure their performance and correctness. Signed-off-by: Vladimir Medvedkin --- app/test-fib/main.c | 58 ++--- 1 file changed, 55 insertions(+), 3 deletions(-) diff --git a/app/test-f

  1   2   3   >