Re: [dpdk-dev] [PATCH] dedicated queues: delete redundant check valid_bonded_port_id has include check_for_bonded_ethdev, no need to check again.

2020-07-03 Thread ??????????
Ok, I will fix it in the next patch, thank you. -- Original -- From: "xavier.huwei"

Re: [dpdk-dev] [PATCH V2] net/bonding: delete redundant code

2020-07-03 Thread Wei Hu (Xavier)
On 2020/7/4 9:15, 197020...@qq.com wrote: From: pandongyang <197020...@qq.com> The function valid_bonded_port_id() has already contains function rte_eth_dev_is_valid_port(), so delete redundant check. Fixes: 588ae95e7983 ("net/bonding: fix port ID check") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH V2] net/bonding: delete redundant code

2020-07-03 Thread 197020236
From: pandongyang <197020...@qq.com> The function valid_bonded_port_id() has already contains function rte_eth_dev_is_valid_port(), so delete redundant check. Fixes: 588ae95e7983 ("net/bonding: fix port ID check") Cc: sta...@dpdk.org Signed-off-by: pandongyang <197020...@qq.com> --- v1 -> v2: Ad

[dpdk-dev] [PATCH v5 48/51] net/bnxt: fill cfa action in the Tx descriptor

2020-07-03 Thread Ajit Khaparde
From: Venkat Duvvuru Currently, only vfrep transmit requires cfa_action to be filled in the tx buffer descriptor. However with truflow, dpdk(non vfrep) to port also requires cfa_action to be filled in the tx buffer descriptor. This patch uses the correct cfa_action pointer while transmitting the

[dpdk-dev] [PATCH v5 51/51] doc: update release notes

2020-07-03 Thread Ajit Khaparde
Update release notes with enhancements in Broadcom PMD. Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_20_08.rst | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst index f

[dpdk-dev] [PATCH v5 49/51] net/bnxt: add ULP Flow counter Manager

2020-07-03 Thread Ajit Khaparde
From: Somnath Kotur The Flow counter manager allocates memory to hold the software view of the counters where the on-chip counter data will be accumulated along with another memory block that will be shadowing the on-chip counter data i.e where the raw counter data will be DMAed into from the chi

[dpdk-dev] [PATCH v5 50/51] net/bnxt: add support for count action in flow query

2020-07-03 Thread Ajit Khaparde
From: Somnath Kotur Use the flow counter manager to fetch the accumulated stats for a flow. Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c | 45 +++- drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c| 141

[dpdk-dev] [PATCH v5 44/51] net/bnxt: fill mapper parameters with default rules

2020-07-03 Thread Ajit Khaparde
From: Venkat Duvvuru Default rules are needed for the packets to be punted between the following entities in the non-offloaded path 1. Device PORT to DPDK App 2. DPDK App to Device PORT 3. VF Representor to VF 4. VF to VF Representor This patch fills all the relevant information in the computed

[dpdk-dev] [PATCH v5 46/51] net/bnxt: create default flow rules for the VF-rep

2020-07-03 Thread Ajit Khaparde
From: Somnath Kotur Invoked 3 new APIs for the default flow create/destroy and to get the action ptr for a default flow. Changed ulp_intf_update() to accept rte_eth_dev as input and invoke the same from the VF rep start function. ULP Mark Manager will indicate if the cfa_code returned in the Rx c

[dpdk-dev] [PATCH v5 41/51] net/bnxt: enhancements for port db

2020-07-03 Thread Ajit Khaparde
From: Venkat Duvvuru 1. Add "enum bnxt_ulp_intf_type” as the second parameter for the port & func helper functions 2. Return vfrep related port & func information in the helper functions 3. Allocate phy_port_list dynamically based on port count 4. Introduce ulp_func_id_tbl array for book keepi

[dpdk-dev] [PATCH v5 47/51] net/bnxt: add port default rules for ingress and egress

2020-07-03 Thread Ajit Khaparde
From: Venkat Duvvuru ingress & egress port default rules are needed to send the packet from port_to_dpdk & dpdk_to_port respectively. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 76 +-

[dpdk-dev] [PATCH v5 37/51] net/bnxt: add support for global resource templates

2020-07-03 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for the global resource templates, so that they can be reused by the other regular templates. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c

[dpdk-dev] [PATCH v5 42/51] net/bnxt: manage VF to VFR conduit

2020-07-03 Thread Ajit Khaparde
From: Venkat Duvvuru When VF-VFR conduits are created, a mark is added to the mark database. mark_flag indicates whether the mark is valid and has VFR information (VFR_ID bit in mark_flag). Rx path was checking for this VFR_ID bit. However, while adding the mark to the mark database, VFR_ID bit i

[dpdk-dev] [PATCH v5 36/51] net/bnxt: add index opcode and operand to mapper table

2020-07-03 Thread Ajit Khaparde
From: Kishore Padmanabha Extended the regfile and computed field operations to a common index opcode operation and added globlal resource operations are also part of the index opcode operation. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed

[dpdk-dev] [PATCH v5 39/51] net/bnxt: add conditional execution of mapper tables

2020-07-03 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for conditional execution of the mapper tables so that actions like count will have table processed only if action count is configured. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde

[dpdk-dev] [PATCH v5 43/51] net/bnxt: parse reps along with other dev-args

2020-07-03 Thread Ajit Khaparde
From: Somnath Kotur Representor dev-args need to be parsed during pci probe as they determine subsequent probe of VF representor ports as well. Signed-off-by: Venkat Duvvuru Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 i

[dpdk-dev] [PATCH v5 38/51] net/bnxt: add support for internal exact match

2020-07-03 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for the internal exact match entries. Prior to this patch only external entries were supported. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c

[dpdk-dev] [PATCH v5 40/51] net/bnxt: allow port MAC qcfg command for trusted VF

2020-07-03 Thread Ajit Khaparde
From: Venkat Duvvuru Issue HWRM_PORT_MAC_QCFG command on trusted vf to fetch the port count. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v5 35/51] net/bnxt: disable Tx vector mode if truflow is set

2020-07-03 Thread Ajit Khaparde
From: Kishore Padmanabha The vector mode in the tx handler is disabled when truflow is enabled since truflow now requires bd action record support. Signed-off-by: Kishore Padmanabha Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bn

[dpdk-dev] [PATCH v5 32/51] net/bnxt: integrate with the latest tf core changes

2020-07-03 Thread Ajit Khaparde
From: Kishore Padmanabha ULP changes to integrate with the latest session open interface in tf_core Signed-off-by: Kishore Padmanabha Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 46 +++

[dpdk-dev] [PATCH v5 34/51] net/bnxt: add support for if table processing

2020-07-03 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for if table processing in the ulp mapper layer. This enables support for the default partition action record pointer interface table. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde

[dpdk-dev] [PATCH v5 31/51] net/bnxt: add support for EEM System memory

2020-07-03 Thread Ajit Khaparde
From: Peter Spreadborough - Select EEM Host or System memory via config parameter - Add EEM system memory support for kernel memory - Dependent on DPDK changes that add support for the HWRM_OEM_CMD. Signed-off-by: Peter Spreadborough Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru -

[dpdk-dev] [PATCH v5 30/51] net/bnxt: add global config set and get APIs

2020-07-03 Thread Ajit Khaparde
From: Jay Ding - Add support to update global configuration for ACT_TECT and ACT_ABCR. - Add support to allow Tunnel and Action global configuration. - Remove register read and write operations. - Remove the register read and write support. Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvur

[dpdk-dev] [PATCH v5 29/51] net/bnxt: add TF register and unregister

2020-07-03 Thread Ajit Khaparde
From: Michael Wildt - Add TF register/unregister support. Session got session clients to keep track of the ctrl-channels/function. - Add support code to tfp layer Signed-off-by: Michael Wildt Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/

[dpdk-dev] [PATCH v5 33/51] net/bnxt: add support for internal encap records

2020-07-03 Thread Ajit Khaparde
From: Mike Baucom Modifications to allow internal encap records to be supported: - Modified the mapper index table processing to handle encap without an action record - Modified the session open code to reserve some 64 Byte internal encap records on tx - Modified the blob encap swap to suppor

[dpdk-dev] [PATCH v5 28/51] net/bnxt: implement IF tables set and get

2020-07-03 Thread Ajit Khaparde
From: Jay Ding - Implement set/get for PROF_SPIF_CTXT, LKUP_PF_DFLT_ARP, PROF_PF_ERR_ARP with tunneled HWRM messages - Add IF table for PROF_PARIF_DFLT_ARP - Fix page size offset in the HCAPI code - Fix Entry offset calculation Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-b

[dpdk-dev] [PATCH v5 27/51] net/bnxt: align CFA resources with RM

2020-07-03 Thread Ajit Khaparde
From: Randy Schacher - HCAPI resources need to align for Resource Manager - Clean up unnecessary debug messages Signed-off-by: Randy Schacher Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/cfa_resource_types.h | 250 +- drivers/net/bnxt/

[dpdk-dev] [PATCH v5 26/51] net/bnxt: add external action alloc and free

2020-07-03 Thread Ajit Khaparde
From: Jay Ding - Link external action alloc and free to new hcapi interface - Add parameter range checking - Fix issues with index allocation check Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_co

[dpdk-dev] [PATCH v5 20/51] net/bnxt: update RM with residual checker

2020-07-03 Thread Ajit Khaparde
From: Michael Wildt - Add residual checker to the TF Host RM as well as new RM APIs. On close it will scan the DB and check of any remaining elements. If found they will be logged and FW msg sent for FW to scrub that specific type of resources. - Update the module bind to be aware of the mo

[dpdk-dev] [PATCH v5 25/51] net/bnxt: remove table scope from session

2020-07-03 Thread Ajit Khaparde
From: Peter Spreadborough - Remove table scope data from session. Added to EEM. - Complete move to RM of table scope base and range. - Fix some err messaging strings. - Fix the tcam logging message. Signed-off-by: Peter Spreadborough Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru R

[dpdk-dev] [PATCH v5 18/51] net/bnxt: multiple device implementation

2020-07-03 Thread Ajit Khaparde
From: Michael Wildt Implement the Identifier, Table Type and the Resource Manager modules. Integrate Resource Manager with HCAPI. Update open/close session. Move to direct msgs for qcaps and resv messages. Signed-off-by: Michael Wildt Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher

[dpdk-dev] [PATCH v5 24/51] net/bnxt: update RM to support HCAPI only

2020-07-03 Thread Ajit Khaparde
From: Peter Spreadborough - For the EM Module there is a need to only allocate the EM Records in HCAPI RM but the storage control is requested to be outside of the RM DB. - Add TF_RM_ELEM_CFG_HCAPI_BA. - Return error when the number of reserved entries for wc tcam is odd number in tf_tcam_bin

[dpdk-dev] [PATCH v5 21/51] net/bnxt: support two level priority for TCAMs

2020-07-03 Thread Ajit Khaparde
From: Jay Ding Allow TCAM indexes to be allocated from top or bottom. If the priority is set to 0, allocate from the lowest tcam indexes i.e. from top. Any other value, allocate it from the highest tcam indexes i.e. from bottom. Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-by

[dpdk-dev] [PATCH v5 13/51] net/bnxt: update multi device design support

2020-07-03 Thread Ajit Khaparde
From: Michael Wildt - Implement the modules RM, Device (WH+), Identifier. - Update Session module. - Implement new HWRMs for RM direct messaging. - Add new parameter check macro's and clean up the header includes for i.e. tfp such that bnxt.h is not directly included in the new modules. - Add c

[dpdk-dev] [PATCH v5 15/51] net/bnxt: add HCAPI interface support

2020-07-03 Thread Ajit Khaparde
From: Peter Spreadborough Add new hardware shim APIs to support multiple device generations Signed-off-by: Peter Spreadborough Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/hcapi/Makefile | 10 + drivers/net/bnxt/hcapi/h

[dpdk-dev] [PATCH v5 19/51] net/bnxt: update identifier with remap support

2020-07-03 Thread Ajit Khaparde
From: Michael Wildt - Add Identifier L2 CTXT Remap to the P4 device and updated the cfa_resource_types.h to get the type support. Signed-off-by: Michael Wildt Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/cfa_resource_typ

[dpdk-dev] [PATCH v5 17/51] net/bnxt: implement support for TCAM access

2020-07-03 Thread Ajit Khaparde
From: Jay Ding Implement TCAM alloc, free, bind, and unbind functions Update tf_core, tf_msg, etc. Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_core.c | 258 ++--- drivers/ne

[dpdk-dev] [PATCH v5 16/51] net/bnxt: add core changes for EM and EEM lookups

2020-07-03 Thread Ajit Khaparde
From: Randy Schacher - Move External Exact and Exact Match to device module using HCAPI to add and delete entries - Make EM active through the device interface. Signed-off-by: Randy Schacher Signed-off-by: Venkat Duvvuru Reviewed-by: Shahaji Bhosle Reviewed-by: Ajit Khaparde --- drivers/n

[dpdk-dev] [PATCH v5 14/51] net/bnxt: support two-level priority for TCAMs

2020-07-03 Thread Ajit Khaparde
From: Shahaji Bhosle Allow TCAM indexes to be allocated from top or bottom. If the priority is set to 0, allocate from the lowest tcam indexes i.e. from top. Any other value, allocate it from the highest tcam indexes i.e. from bottom. Signed-off-by: Shahaji Bhosle Signed-off-by: Venkat Duvvuru

[dpdk-dev] [PATCH v5 11/51] net/bnxt: add multi device support

2020-07-03 Thread Ajit Khaparde
From: Michael Wildt Introduce new modules for Device, Resource Manager, Identifier, Table Types, and TCAM for multi device support. Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/meson.build

[dpdk-dev] [PATCH v5 12/51] net/bnxt: support bulk table get and mirror

2020-07-03 Thread Ajit Khaparde
From: Shahaji Bhosle - Add new bulk table type get using FW to DMA the data back to host. - Add flag to allow records to be cleared if possible - Set mirror using tf_alloc_tbl_entry Signed-off-by: Shahaji Bhosle Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/

[dpdk-dev] [PATCH v5 10/51] net/bnxt: use HWRM direct for EM insert and delete

2020-07-03 Thread Ajit Khaparde
From: Peter Spreadborough Modify Exact Match insert and delete to use the HWRM messages directly. Remove tunneled EM insert and delete message types. Signed-off-by: Peter Spreadborough Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/

[dpdk-dev] [PATCH v5 06/51] net/bnxt: get port and function info

2020-07-03 Thread Ajit Khaparde
From: Venkat Duvvuru add helper functions to get port & function related information like parif, physical port id & vport id. Signed-off-by: Venkat Duvvuru Signed-off-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bn

[dpdk-dev] [PATCH v5 07/51] net/bnxt: add support for hwrm port phy qcaps

2020-07-03 Thread Ajit Khaparde
From: Venkat Duvvuru Issue HWRM_PORT_PHY_QCAPS to the firmware to get the physical port count of the device. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 1 +

[dpdk-dev] [PATCH v5 04/51] net/bnxt: initialize parent PF information

2020-07-03 Thread Ajit Khaparde
From: Lance Richardson Add support to query parent PF information (MAC address, function ID, port ID and default VNIC) from firmware. Current firmware returns zero for parent default vnic, a temporary Wh+-specific workaround is included until that can be fixed. Signed-off-by: Lance Richardson

[dpdk-dev] [PATCH v5 03/51] net/bnxt: get IDs for VF-Rep endpoint

2020-07-03 Thread Ajit Khaparde
From: Somnath Kotur Use 'first_vf_id' and the 'vf_id' that is input as part of adding a representor to obtain the PCI function ID(FID) of the VF(VFR endpoint). Use the FID as an input to FUNC_QCFG HWRM cmd to obtain the default vnic ID of the VF. Along with getting the default vNIC ID by supplyin

[dpdk-dev] [PATCH v5 02/51] net/bnxt: add support for VF-reps data path

2020-07-03 Thread Ajit Khaparde
From: Somnath Kotur Added code to support Tx/Rx from a VF representor port. The VF-reps use the RX/TX rings of the Trusted VF/PF. For each VF-rep, the Trusted VF/PF driver issues a VFR_ALLOC FW cmd that returns "cfa_code" and "cfa_action" values. The FW sets up the filter tables in such a way tha

[dpdk-dev] [PATCH v5 08/51] net/bnxt: modify port db to handle more info

2020-07-03 Thread Ajit Khaparde
From: Venkat Duvvuru Apart from func_svif, func_id & vnic, port_db now stores and retrieves func_spif, func_parif, phy_port_id, port_svif, port_spif, port_parif, port_vport. New helper functions have been added to support the same. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Revie

[dpdk-dev] [PATCH v5 01/51] net/bnxt: add basic infrastructure for VF reps

2020-07-03 Thread Ajit Khaparde
From: Somnath Kotur Defines data structures and code to init/uninit VF representors during pci_probe and pci_remove respectively. Most of the dev_ops for the VF representor are just stubs for now and will be will be filled out in next patch. To create a representor using testpmd: testpmd -c 0xff

[dpdk-dev] [PATCH v5 05/51] net/bnxt: modify port db dev interface

2020-07-03 Thread Ajit Khaparde
From: Venkat Duvvuru Modify ulp_port_db_dev_port_intf_update prototype to take "struct rte_eth_dev *" as the second parameter. Signed-off-by: Venkat Duvvuru Signed-off-by: Somnath Kotur Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c| 4

[dpdk-dev] [PATCH v5 00/51] net/bnxt: add features for host-based flow management

2020-07-03 Thread Ajit Khaparde
v1->v2: - update commit message - rebase patches against latest changes in the tree - fix signed-off-by tags - update release notes v2->v3: - fix compilation issues v3->v4: - rebase against latest dpdk-next-net v4->v5: - fix uninitlalized variable in patch [29/51] - rebase against latest

[dpdk-dev] [PATCH v3 3/3] doc: update deprecation of CIO barrier APIs

2020-07-03 Thread Honnappa Nagarahalli
rte_cio_*mb APIs will be deprecated in 20.11 release. Signed-off-by: Honnappa Nagarahalli --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index d1034f60f..59656da3d 100

[dpdk-dev] [PATCH v3 2/3] doc: update armv8-a IO barrier changes

2020-07-03 Thread Honnappa Nagarahalli
Updated the use of DMB instruction in rte_*mb APIs for Armv8-a. Signed-off-by: Honnappa Nagarahalli --- doc/guides/rel_notes/release_20_08.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst index 5cbc4ce

[dpdk-dev] [PATCH v3 1/3] eal: adjust barriers for IO on Armv8-a

2020-07-03 Thread Honnappa Nagarahalli
Change the barrier APIs for IO to reflect that Armv8-a is other-multi-copy atomicity memory model. Armv8-a memory model has been strengthened to require other-multi-copy atomicity. This property requires memory accesses from an observer to become visible to all other observers simultaneously [3].

Re: [dpdk-dev] [PATCH 1/3] ring: remove experimental tag for ring reset API

2020-07-03 Thread Honnappa Nagarahalli
> > On 03/07/2020 11:26, Feifei Wang wrote: > > Remove the experimental tag for rte_ring_reset API that have been > > around for 4 releases. > > > > Signed-off-by: Feifei Wang > > Reviewed-by: Honnappa Nagarahalli > > Reviewed-by: Ruifeng Wang > > --- > > lib/librte_ring/rte_ring.h

Re: [dpdk-dev] [PATCH v4 3/7] crypto/aesni_mb: add support for DOCSIS protocol

2020-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: Coyle, David > Sent: Friday, July 3, 2020 1:39 PM > To: akhil.go...@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > ; Zhang, Roy Fan ; > Ananyev, Konstantin > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Ryan, Brendan ; > hem

Re: [dpdk-dev] [PATCH v4 2/7] cryptodev: add a note regarding DOCSIS protocol support

2020-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: Coyle, David > Sent: Friday, July 3, 2020 1:39 PM > To: akhil.go...@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > ; Zhang, Roy Fan ; > Ananyev, Konstantin > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Ryan, Brendan ; > hem

Re: [dpdk-dev] [PATCH v4 7/7] app/crypto-perf: add support for DOCSIS protocol

2020-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: Coyle, David > Sent: Friday, July 3, 2020 1:40 PM > To: akhil.go...@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > ; Zhang, Roy Fan ; > Ananyev, Konstantin > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Ryan, Brendan ; > hem

Re: [dpdk-dev] [PATCH v4 5/7] test/crypto: add DOCSIS security test cases

2020-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: Coyle, David > Sent: Friday, July 3, 2020 1:40 PM > To: akhil.go...@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > ; Zhang, Roy Fan ; > Ananyev, Konstantin > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Ryan, Brendan ; > hem

Re: [dpdk-dev] [PATCH v4 1/7] security: add support for DOCSIS protocol

2020-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: Coyle, David > Sent: Friday, July 3, 2020 1:39 PM > To: akhil.go...@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > ; Zhang, Roy Fan ; > Ananyev, Konstantin > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Ryan, Brendan ; > hema

Re: [dpdk-dev] 18.11.9 (LTS) patches review and test

2020-07-03 Thread Kevin Traynor
Hi Abhishek, Do you have any results from Microsoft testing? There is a few remaining items to be re-validated elsewhere, but we should be ok for release early next week. thanks, Kevin. On 26/06/2020 13:53, Kevin Traynor wrote: > Hi all, > > Here is a list of patches targeted for LTS release

[dpdk-dev] [PATCH] doc: add sample for ABI checks in contribution guide

2020-07-03 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- doc/guides/contributing/patches.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst index 25d97b85b..39ec64ec8 100644 --- a/doc/guides/contributing/patches.rst +++ b/doc/guides/contr

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-07-03 Thread Ananyev, Konstantin
> > > If the final users finally hit the situation you describe, it means > > > that the multiprocess had been in use so far and was known to be in > > > use (*hopefully*). > > > > Yes. > > > > > So is it not a problem of design/non-regression testing when > > > integrating the new API in the fir

Re: [dpdk-dev] [PATCH v1 0/5] fix promisc and tcam problem

2020-07-03 Thread Ferruh Yigit
On 6/27/2020 4:55 AM, Xiaoyun wang wrote: > This patch adds multi-thread resource protection when > setting promiscuous or allmulticast mode, adds bufout > and out size parameter for mgmt sync channel and removes > unused parameters for mgmt channel with no ack, adds TCAM > filter switch for FDIR,

Re: [dpdk-dev] [PATCH 2/3] ring: remove experimental tag for ring element APIs

2020-07-03 Thread Kinsella, Ray
On 03/07/2020 11:26, Feifei Wang wrote: > Remove the experimental tag for rte_ring_xxx_elem APIs that have been > around for 2 releases. > > Signed-off-by: Feifei Wang > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang > --- > lib/librte_ring/rte_ring.h | 5 + > l

Re: [dpdk-dev] [PATCH 1/3] ring: remove experimental tag for ring reset API

2020-07-03 Thread Kinsella, Ray
On 03/07/2020 11:26, Feifei Wang wrote: > Remove the experimental tag for rte_ring_reset API that have been around > for 4 releases. > > Signed-off-by: Feifei Wang > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang > --- > lib/librte_ring/rte_ring.h | 3 --- > lib/lib

Re: [dpdk-dev] [RFC PATCH 0/3] librte_ethdev: error recovery support

2020-07-03 Thread Ferruh Yigit
On 3/12/2020 7:34 AM, Thomas Monjalon wrote: > 12/03/2020 04:25, Kalesh Anakkur Purayil: >> Hi Thomas, >> >> On Wed, Mar 11, 2020 at 6:49 PM Thomas Monjalon wrote: >> >>> 22/01/2020 11:16, Kalesh A P: From: Kalesh AP This patch adds support for recovery event in rte_eth_event frame

Re: [dpdk-dev] [RFC PATCH 0/1] Add l2reflect measurement application

2020-07-03 Thread Moessbauer, Felix
> 03/07/2020 17:18, Felix Moessbauer: > > Dear Maintainers, > > > > this patch adds a measurement application to benchmark the latency of > > transmitting l2 packets via DPDK. > > Are you using a real time system to reduce latency? Yes, we use a Debian buster with preempt-rt patched kernel. Addit

[dpdk-dev] [PATCH v4 0/2] net/virtio: add vhost-user protocol features support

2020-07-03 Thread Adrian Moreno
This series adds Vhost-user protocol features support to Virtio-user PMD's Vhost-user backend. The first patch introduces protocol features negotiation, and the second one reply-ack feature. --- Changes since v3: - [Chenbo] Do not process MQ if VHOST_USER_F_PROTOCOL_FEATURES is unsupported Cha

[dpdk-dev] [PATCH v4 2/2] net/virtio: add reply-ack support to Virtio-user

2020-07-03 Thread Adrian Moreno
From: Maxime Coquelin This patch adds support reply-ack vhost-user protocol feature, which is for now only used to ensure VHOST_USER_SET_MEM_TABLE requests are handled by the slave, but later will be used for VHOST_USER_SET_STATUS. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_u

[dpdk-dev] [PATCH v4 1/2] net/virtio: add vhost-user protocol features support

2020-07-03 Thread Adrian Moreno
From: Maxime Coquelin This patch adds support for Vhost-user protocol features. It is required to support protocol features that were not in initial Vhost-user specification, such as reply-ack, MTU... Also, this patch prevents Virtio multiqueue feature negotiation if the slave does not support M

Re: [dpdk-dev] [PATCH v3 1/2] net/virtio: add vhost-user protocol features support

2020-07-03 Thread Adrian Moreno
On 7/3/20 10:40 AM, Xia, Chenbo wrote: > Hi Adrian, > >> -Original Message- >> From: Adrian Moreno >> Sent: Thursday, July 2, 2020 3:44 PM >> To: dev@dpdk.org >> Cc: Xia, Chenbo ; Wang, Zhihong >> ; Wang, Xiao W ; Yigit, >> Ferruh ; maxime.coque...@redhat.com >> Subject: [PATCH v3 1/2]

Re: [dpdk-dev] [RFC PATCH 0/1] Add l2reflect measurement application

2020-07-03 Thread Thomas Monjalon
03/07/2020 17:18, Felix Moessbauer: > Dear Maintainers, > > this patch adds a measurement application to benchmark the latency > of transmitting l2 packets via DPDK. Are you using a real time system to reduce latency? > We add this application to the examples folder, as similar tools > were plac

Re: [dpdk-dev] [PATCH] mbuf: use c11 atomics for refcnt operations

2020-07-03 Thread David Marchand
On Thu, Jun 11, 2020 at 12:26 PM Phil Yang wrote: > > Use c11 atomics with explicit ordering instead of rte_atomic ops which > enforce unnecessary barriers on aarch64. > > Signed-off-by: Phil Yang > Reviewed-by: Ruifeng Wang I did not look at the details, but this patch is refused by the ABI ch

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-03 Thread Jerin Jacob
On Fri, Jul 3, 2020 at 8:57 PM Thomas Monjalon wrote: > > 03/07/2020 17:08, Jerin Jacob: > > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad wrote: > > > From: Jerin Jacob: > > > > When adding overlapping API(rte_eth_mirror_rule_set()) in the same > > > > library(ethdev). > > > > Please depreciate the

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-03 Thread Matan Azrad
From: Jerin Jacob > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad wrote: > > > > > > Hi Jerin > > Hi Matan, > > > > > From: Jerin Jacob: > > > On Fri, Jul 3, 2020 at 12:13 AM Jiawei Wang > wrote: > > > > > > > > When using full offload, all traffic will be handled by the HW, > > > > and directed

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-03 Thread Thomas Monjalon
03/07/2020 17:08, Jerin Jacob: > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad wrote: > > From: Jerin Jacob: > > > When adding overlapping API(rte_eth_mirror_rule_set()) in the same > > > library(ethdev). > > > Please depreciate the old API. > > > We should not have two separate paths for the same fu

Re: [dpdk-dev] [PATCH] add flow shared action API

2020-07-03 Thread Thomas Monjalon
03/07/2020 17:02, Jerin Jacob: > On Fri, Jul 3, 2020 at 8:07 PM Andrey Vesnovaty wrote: > > Signed-off-by: Andrey Vesnovaty > > Signed-off-by: Andrey Vesnovaty > > Signed-off-by: Andrey Vesnovaty > > Duplicate Signoffs. > > # Request to CC all the people who are already giving comments to thi

Re: [dpdk-dev] [PATCH v4 1/2] eal: add WC store functions

2020-07-03 Thread David Marchand
On Thu, Jul 2, 2020 at 11:24 AM Radu Nicolau wrote: > > Add rte_write32_wc and rte_write32_wc_relaxed functions > that implement 32bit stores using write combining memory protocol. > Provided generic stubs and x86 implementation. > > Signed-off-by: Radu Nicolau > Acked-by: Bruce Richardson > ---

[dpdk-dev] [RFC PATCH 1/1] Add l2reflect measurement application

2020-07-03 Thread Felix Moessbauer
The l2reflect application implements a ping-pong benchmark to measure the latency between two instances. For communication, we use raw ethernet and send one packet at a time. The timing data is collected locally and min/max/avg values are displayed in a TUI. Finally, a histogram of the latencies is

[dpdk-dev] [RFC PATCH 0/1] Add l2reflect measurement application

2020-07-03 Thread Felix Moessbauer
Dear Maintainers, this patch adds a measurement application to benchmark the latency of transmitting l2 packets via DPDK. We add this application to the examples folder, as similar tools were placed there as well. Note: the example has an optional dependency to cjson for creating a json represent

Re: [dpdk-dev] [PATCH v2] examples: add multi process crypto application

2020-07-03 Thread Trahe, Fiona
Hi Akhil, Arek, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, July 3, 2020 8:48 AM > To: Akhil Goyal ; dev@dpdk.org; Trahe, Fiona > ; Burakov, > Anatoly > Subject: RE: [PATCH v2] examples: add multi process crypto application > > Shouldn't this be part of examp

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-07-03 Thread Thomas Monjalon
02/07/2020 15:06, David Marchand: > On Wed, Jul 1, 2020 at 1:58 PM Ananyev, Konstantin > wrote: > > > If the final users finally hit the situation you describe, it means > > > that the multiprocess had been in use so far and was known to be in > > > use (*hopefully*). > > > > Yes. > > > > > So is

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-03 Thread Jerin Jacob
On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad wrote: > > > Hi Jerin Hi Matan, > > From: Jerin Jacob: > > On Fri, Jul 3, 2020 at 12:13 AM Jiawei Wang wrote: > > > > > > When using full offload, all traffic will be handled by the HW, and > > > directed to the requested vf or wire, the control applic

[dpdk-dev] [PATCH v17 2/2] eal: support for VFIO-PCI VF token

2020-07-03 Thread Haiyue Wang
The kernel module vfio-pci introduces the VF token to enable SR-IOV support since 5.7. The VF token can be set by a vfio-pci based PF driver and must be known by the vfio-pci based VF driver in order to gain access to the device. Since the vfio-pci module uses the VF token as internal data to pro

[dpdk-dev] [PATCH v17 0/2] support for VFIO-PCI VF token interface

2020-07-03 Thread Haiyue Wang
v17: Rebase for new EAL config API, update the commit message and doc. v16: Rebase the patch for 20.08 release note. v15: Add the missed EXPERIMENTAL warning for API doxgen. v14: Rebase the patch for 20.08 release note. v13: Rename the EAL get VF token function, and leave the freebsd type as em

[dpdk-dev] [PATCH v17 1/2] eal: add uuid dependent header files explicitly

2020-07-03 Thread Haiyue Wang
Add the dependent header files explicitly, so that the user just needs to include the 'rte_uuid.h' header file directly to avoid compile error: (1). rte_uuid.h:97:55: error: unknown type name ‘size_t’ (2). rte_uuid.h:58:2: error: implicit declaration of function ‘memcpy’ Fixes: 6bc67c497a51 ("ea

Re: [dpdk-dev] [PATCH] add flow shared action API

2020-07-03 Thread Jerin Jacob
On Fri, Jul 3, 2020 at 8:07 PM Andrey Vesnovaty wrote: > > From: Andrey Vesnovaty > > This commit introduces extension of DPDK flow action API enabling > sharing of single rte_flow_action in multiple flows. The API intended for > PMDs where multiple HW offloaded flows can reuse the same HW > esse

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-03 Thread Matan Azrad
Hi Jerin From: Jerin Jacob: > On Fri, Jul 3, 2020 at 12:13 AM Jiawei Wang wrote: > > > > When using full offload, all traffic will be handled by the HW, and > > directed to the requested vf or wire, the control application loses > > visibility on the traffic. > > So there's a need for an action

[dpdk-dev] [PATCH RFC 7/8] Update/Add support for RSS on 5 Tuple Flows for GTPU encapsulated packets (AVF)

2020-07-03 Thread Gordon
From: gordonno --- drivers/net/iavf/iavf_generic_flow.c | 39 + drivers/net/iavf/iavf_generic_flow.h |4 + drivers/net/iavf/iavf_hash.c | 1952 +++--- 3 files changed, 1478 insertions(+), 517 deletions(-) diff --git a/drivers/net/iavf/iavf_generic_flow.c b/dri

[dpdk-dev] [PATCH RFC 8/8] net/iavf: fix gtpu ip udp issue

2020-07-03 Thread Gordon
From: Jeff Guo Signed-off-by: Jeff Guo --- drivers/net/iavf/iavf_hash.c | 136 ++- 1 file changed, 103 insertions(+), 33 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index 62dd29889..f17b119e2 100644 --- a/drivers/net/iav

[dpdk-dev] [PATCH RFC 6/8] ICE: Enable advanced RSS for PPPoE

2020-07-03 Thread Gordon
From: gordonno --- app/test-pmd/cmdline.c | 6 -- app/test-pmd/config.c | 1 + drivers/net/ice/ice_hash.c | 31 ++- lib/librte_ethdev/rte_ethdev.h | 2 +- 4 files changed, 36 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.

[dpdk-dev] [PATCH RFC 1/8] common/iavf: add large queue VC ops

2020-07-03 Thread Gordon
From: Qi Zhang Add VC ops to support 64 queue VIRTCHNL_OP_ENABLE_LARGE_QUEUES VIRTCHNL_OP_DISABLE_LARGE_QUEUES VIRTCHNL_OP_CONFIG_LARGE_IRQ_MAP Signed-off-by: Qi Zhang --- drivers/common/iavf/virtchnl.h | 59 ++ 1 file changed, 59 insertions(+) diff --git a/dr

[dpdk-dev] [PATCH RFC 5/8] Support dst ip only for RSS

2020-07-03 Thread Gordon
From: gordonno --- drivers/net/iavf/iavf_hash.c | 476 +-- 1 file changed, 281 insertions(+), 195 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index af528863b..a7691ef0c 100644 --- a/drivers/net/iavf/iavf_hash.c +++ b/driv

[dpdk-dev] [PATCH RFC 3/8] common/iavf: add large vsi queue config

2020-07-03 Thread Gordon
From: Qi Zhang Signed-off-by: Qi Zhang --- drivers/common/iavf/virtchnl.h | 54 ++ drivers/net/iavf/iavf_vchnl.c | 6 ++-- 2 files changed, 57 insertions(+), 3 deletions(-) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index 5b04

[dpdk-dev] [PATCH RFC 0/8] net/iavf: Enable 256 queues

2020-07-03 Thread Gordon
From: gordonno Enable 256 queues per VF. Allow RSS across queue groups of up to 64 Queues(AVF). Enable advanced RSS for PPPoE(AVF). Enable support for RSS on 5 Tuple Flows for GTPU encapsulated packets (AVF) Jeff Guo (1): net/iavf: fix gtpu ip udp issue Qi Zhang (4): common/iavf: add large

[dpdk-dev] [PATCH RFC 4/8] net/iavf: support > 256 lut table size

2020-07-03 Thread Gordon
From: Qi Zhang Signed-off-by: Qi Zhang --- drivers/net/iavf/iavf_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index e09efffd1..5c7ace8bd 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/

[dpdk-dev] [PATCH RFC 2/8] net/iavf: support 64 queues

2020-07-03 Thread Gordon
From: Qi Zhang Enlarge max queue number from 16 to 64 by using "large" vc ops. Signed-off-by: Qi Zhang --- drivers/net/iavf/iavf.h | 4 ++-- drivers/net/iavf/iavf_vchnl.c | 35 ++- 2 files changed, 20 insertions(+), 19 deletions(-) diff --git a/drivers/n

[dpdk-dev] [PATCH RFC 8/8] net/iavf: fix gtpu ip udp issue

2020-07-03 Thread Gordon
From: Jeff Guo Signed-off-by: Jeff Guo --- drivers/net/iavf/iavf_hash.c | 136 ++- 1 file changed, 103 insertions(+), 33 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index 62dd29889..f17b119e2 100644 --- a/drivers/net/iav

[dpdk-dev] [PATCH RFC 5/8] Support dst ip only for RSS

2020-07-03 Thread Gordon
From: gordonno --- drivers/net/iavf/iavf_hash.c | 476 +-- 1 file changed, 281 insertions(+), 195 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index af528863b..a7691ef0c 100644 --- a/drivers/net/iavf/iavf_hash.c +++ b/driv

  1   2   3   >