[dpdk-dev] [PATCH v2] rte_flow: add eCPRI key fields to flow API

2020-07-01 Thread Bing Zhao
Add a new item "rte_flow_item_ecpri" in order to match eCRPI header. eCPRI is a packet based protocol used in the fronthaul interface of 5G networks. Header format definition could be found in the specification via the link below: https://www.gigalight.com/downloads/standards/ecpri-specification.p

Re: [dpdk-dev] [PATCH] cryptodev: add support for user callback functions

2020-07-01 Thread Gujjar, Abhinandan S
Hi Akhil, We can target this for 20.11. Thanks Abhinandan > -Original Message- > From: Akhil Goyal > Sent: Wednesday, July 1, 2020 12:43 AM > To: Gujjar, Abhinandan S ; Ananyev, > Konstantin ; Doherty, Declan > ; jer...@marvell.com; dev@dpdk.org > Cc: Vangati, Narender > Subject: RE: [

[dpdk-dev] [PATCH (v20.11) 2/2] eventdev: reserve space in timer structs for extension

2020-07-01 Thread pbhagavatula
From: Pavan Nikhilesh The struct rte_event_timer_adapter and rte_event_timer_adapter_data are supposed to be used internally only, but there is a chance that increasing their size would break ABI for some applications. In order to allow smooth addition of features without breaking ABI compatibili

[dpdk-dev] [PATCH (v20.11) 1/2] eventdev: reserve space in config structs for extension

2020-07-01 Thread pbhagavatula
From: Pavan Nikhilesh Reserve space in event device configuration structures as increasing their size would break ABI for some applications. In order to allow smooth addition of features without breaking ABI compatibility, reserve some space. Signed-off-by: Pavan Nikhilesh --- lib/librte_event

Re: [dpdk-dev] [PATCH 2/2] doc: add aarch32 build guidance

2020-07-01 Thread Phil Yang
Hi Jerin, Your insight would be much appreciated. Thanks, Phil > -Original Message- > From: Ruifeng Wang > Sent: Wednesday, May 27, 2020 4:29 PM > To: Phil Yang ; dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > jer...@marvell.com; Honnappa Nagarahalli > ; Joyce Kong

[dpdk-dev] [PATCH v2 3/4] eventdev: remove redundant code

2020-07-01 Thread Phil Yang
There is no thread will access these impl_opaque data after timer canceled. When new timer armed, it got refilled. So the cleanup process is unnecessary. Signed-off-by: Phil Yang --- lib/librte_eventdev/rte_event_timer_adapter.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_eve

[dpdk-dev] [PATCH v2 2/4] eventdev: use c11 atomics for lcore timer armed flag

2020-07-01 Thread Phil Yang
The in_use flag is a per core variable which is not shared between lcores in the normal case and the access of this variable should be ordered on the same core. However, if non-EAL thread pick the highest lcore to insert timers into, there is the possibility of conflicts on this flag between thread

[dpdk-dev] [PATCH v2 4/4] eventdev: relax smp barriers with c11 atomics

2020-07-01 Thread Phil Yang
The implementation-specific opaque data is shared between arm and cancel operations. The state flag acts as a guard variable to make sure the update of opaque data is synchronized. This patch uses c11 atomics with explicit one way memory barrier instead of full barriers rte_smp_w/rmb() to synchroni

[dpdk-dev] [PATCH v2 1/4] eventdev: fix race condition on timer list counter

2020-07-01 Thread Phil Yang
The n_poll_lcores counter and poll_lcore array are shared between lcores and the update of these variables are out of the protection of spinlock on each lcore timer list. The read-modify-write operations of the counter are not atomic, so it has the potential of race condition between lcores. Use c

[dpdk-dev] [PATCH v2 0/3] net/ice: enable advanced RSS for PPPoE

2020-07-01 Thread Simei Su
[PATCH v2 1/3] ethdev: add rss offload types. [PATCH v2 2/3] app/testpmd: add cmdline support fo rss types. [PATCH v2 3/3] net/ice: add RSS support for PPPoE control packets and data packets in rte_flow. v2: * Refine commit log. Simei Su (3): ethdev: add new RSS offload types a

[dpdk-dev] [PATCH v2 2/3] app/testpmd: support extended RSS offload types

2020-07-01 Thread Simei Su
This patch adds testpmd cmdline support for PPPoE. Signed-off-by: Simei Su --- app/test-pmd/cmdline.c | 6 -- app/test-pmd/config.c | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 996a498..1ac0b89 100644 --- a/app/t

[dpdk-dev] [PATCH v2 1/3] ethdev: add new RSS offload types

2020-07-01 Thread Simei Su
This patch defines new RSS offload types for PPPoE. Typically, session id would be the RSS input set for a PPPoE packet, but as a hint, each driver may have different default behaviors. Signed-off-by: Simei Su --- lib/librte_ethdev/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[dpdk-dev] [PATCH v2 3/3] net/ice: add RSS support for PPPoE

2020-07-01 Thread Simei Su
This patch enables PPPoE control packets with src mac and session id and PPPoE data packets with ip address and L4 port in rte_flow. Signed-off-by: Simei Su --- drivers/net/ice/ice_hash.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/

Re: [dpdk-dev] [PATCH v2 0/8] update base code batch 3

2020-07-01 Thread Yang, Qiming
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, July 1, 2020 13:50 > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v2 0/8] update base code batch 3 > > The patchset include couple bug fixes and code clean also update the version > number. > > v2: > -

Re: [dpdk-dev] [PATCH v2 4/8] net/ice/base: code clean in FDIR module

2020-07-01 Thread Yang, Qiming
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, July 1, 2020 13:50 > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z ; Stillwell Jr, Paul M > > Subject: [PATCH v2 4/8] net/ice/base: code clean in FDIR module > > Remove unused macro and funciton. This error spell still e

Re: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter

2020-07-01 Thread Honnappa Nagarahalli
> > > > > > > > Hi Phil, > > > > > > Good catch - thanks for the fix. I've commented in-line: > > > > > > > -Original Message- > > > > From: Phil Yang > > > > Sent: Friday, June 12, 2020 6:20 AM > > > > To: dev@dpdk.org; Carrillo, Erik G > > > > Cc: d...@linux.vnet.ibm.com; honnappa.na

[dpdk-dev] [PATCH v2 19/20] net/ixgbe/base: cleanup pre-processor tags

2020-07-01 Thread Guinan Sun
The codes has been exposed correctly, so remove pre-processor tags. Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_common.c | 8 drivers/net/ixgbe/base/ixgbe_phy.h| 2 -- drivers/net/ixgbe/base/ixgbe_type.h | 10 -- drivers/net/ixgbe/base/ixgbe_vf.c | 4

[dpdk-dev] [PATCH v2 17/20] net/ixgbe/base: remove default advertising for x550 2.5G/5G

2020-07-01 Thread Guinan Sun
We are seeing interoperability issues with switches when 2.5G and 5G in x550 are advertised by default, so default to off. Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_phy.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ixgbe/base/

[dpdk-dev] [PATCH v2 18/20] net/ixgbe/base: check host interface return status

2020-07-01 Thread Guinan Sun
Writing to read-only fields returns a non-OK Return Status for shadow RAM write command for X550. This information was previously discarded. Signed-off-by: Stanislaw Grzeszczak Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_x550.c | 13 - 1 file changed, 12 insertions(+)

[dpdk-dev] [PATCH v2 20/20] net/ixgbe/base: update version

2020-07-01 Thread Guinan Sun
Update base code version in readme. Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/README b/drivers/net/ixgbe/base/README index a48b14ed2..2c7469392 100644 --- a/drivers/net/ixgbe/base/README

[dpdk-dev] [PATCH v2 11/20] net/ixgbe/base: create dedicated func to restart auto nego

2020-07-01 Thread Guinan Sun
This patch is for restarting auto negotiation on PHY. Signed-off-by: Jakub Chylkowski Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_phy.c | 48 ++ drivers/net/ixgbe/base/ixgbe_phy.h | 1 + 2 files changed, 23 insertions(+), 26 deletions(-) diff --git a

[dpdk-dev] [PATCH v2 15/20] net/ixgbe/base: improve log about autonego being disabled

2020-07-01 Thread Guinan Sun
On ESXi OS, when user disables auto negotiation, the following log appears: "(unsupported) Flow control autoneg is disabled". It is true that auto negotiation is disabled but it is not necessarily true that it is not supported. Signed-off-by: Jakub Chylkowski Signed-off-by: Guinan Sun --- drive

[dpdk-dev] [PATCH v2 16/20] net/ixgbe/base: add ipv6 mask for FDIR feature

2020-07-01 Thread Guinan Sun
Write FDIRIP6M register to allow flow director filter to set ipv6 rules without setting ipv6 source/destination address. Signed-off-by: Piotr Skajewski Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_82599.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/base/i

[dpdk-dev] [PATCH v2 13/20] net/ixgbe/base: remove unnecessary log message FC autonego

2020-07-01 Thread Guinan Sun
The function ixgbe_device_supports_autoneg_fc is checking whether a particular device and medium configuration is supporting Flow Control Autonegotiation. In case of non-support, the message is always logged which is confusing. The fix is removing unnecessary log entry. Signed-off-by: Zalfresso-Ju

[dpdk-dev] [PATCH v2 12/20] net/ixgbe/base: modify coding style

2020-07-01 Thread Guinan Sun
Fix unchecked return value. Add cast for type mismatch. Signed-off-by: Jakub Chylkowski Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_82599.c | 12 +--- drivers/net/ixgbe/base/ixgbe_common.c| 6 ++ drivers/net/ixgbe/base/ixgbe_common.h| 2 +- drivers/net/i

[dpdk-dev] [PATCH v2 10/20] net/ixgbe/base: move increments after evaluations

2020-07-01 Thread Guinan Sun
The retry variable was being incremented before it was evaluated by the subsequent conditional against the maximum retries to figure out which message to print. So we'll move the increment op to the end. Signed-off-by: Jeb Cramer Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_phy.c

[dpdk-dev] [PATCH v2 14/20] net/ixgbe/base: initialize data field in struct buffer

2020-07-01 Thread Guinan Sun
While sending request using ixgbe_hic_unlocked() the data field in buffer struct is not used. It is set when the struct is overwritten by FW to deliver the response. To not pass random data to FW the whole structure should be zeroed before use. Signed-off-by: Krzysztof Galazka Signed-off-by: Piot

[dpdk-dev] [PATCH v2 05/20] net/ixgbe/base: fix x550em 10G NIC link status report

2020-07-01 Thread Guinan Sun
With the NVM image for x550em XFI will not report the auto-negotiation feature correctly. The auto-negotiation should be "No" for supports and advertised items. At the same time update speed makes it support 1G and 10G. Fixes: 833df43399e7 ("net/ixgbe/base: add SGMII link for X550") Cc: sta...@dpd

[dpdk-dev] [PATCH v2 06/20] net/ixgbe/base: resolve infinite recursion on PCIe link down

2020-07-01 Thread Guinan Sun
In some corner cases the functions ixgbe_clear_rar_generic and ixgbe_clear_vmdq_generic may call one another leading to infinite recursion. When ixgbe_clear_vmdq_generic is called with IXGBE_CLEAR_VMDQ_ALL flag, it's going to clear MPSAR registers, and proceed to call ixgbe_clear_rar_generic, whic

[dpdk-dev] [PATCH v2 08/20] net/ixgbe/base: cleanup spelling mistakes in comments

2020-07-01 Thread Guinan Sun
Several functions in the driver code have a weird function comment formatting which uses two spaces instead of only one space for the main function body. This formatting will be mechanically fixed by sed in a future patch, but doing so leads to some checkpatch.pl warnings on that patch. Cleanup th

[dpdk-dev] [PATCH v2 04/20] net/ixgbe/base: change flow for "Apply Update" command

2020-07-01 Thread Guinan Sun
For the "Apply Update" command the firmware does not given an response. For this command, success should be return. Signed-off-by: Mateusz Kowalski Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_common.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/dri

[dpdk-dev] [PATCH v2 03/20] net/ixgbe/base: fix host interface shadow RAM read

2020-07-01 Thread Guinan Sun
Host interface Shadow RAM Read (0x31) command response buffer length should be stored in two bytes, instead of one byte. This patch fixes it. Fixes: e6102361b1d4 ("net/ixgbe/base: use 2 bytes for flash read command") Cc: sta...@dpdk.org Signed-off-by: Mateusz Kowalski Signed-off-by: Guinan Sun

[dpdk-dev] [PATCH v2 07/20] net/ixgbe/base: added register definitions for NVM update

2020-07-01 Thread Guinan Sun
Added additional register for X550 and above device family. Signed-off-by: Piotr Skajewski Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_type.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_type.h b/drivers/net/ixgbe/base/ixgbe_type.h index 33c

[dpdk-dev] [PATCH v2 01/20] net/ixgbe/base: toggle VF's Tx queues

2020-07-01 Thread Guinan Sun
Add method to toggle VF's TX queues needed as workaround for silicon errata. Signed-off-by: Piotr Pietruszewski Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_api.c| 13 +++ drivers/net/ixgbe/base/ixgbe_api.h| 1 + drivers/net/ixgbe/base/ixgbe_common.c | 56

[dpdk-dev] [PATCH v2 00/20] update ixgbe base code

2020-07-01 Thread Guinan Sun
source code of ixgbe driver: not-released-cid-ixgbe.2020.06.09.tar.gz released by the team which develop basic drivers for any ixgbe NIC. changelog in ND share repo: >From 66d7da32d8e8 ("ixgbe-shared: Add support to clear VFMBMEM and toggle VF's >TX queues") To 7f2d73c9742b ("ixgbe-shared: check

[dpdk-dev] [PATCH v2 02/20] net/ixgbe/base: add support to clear VFMBMEM

2020-07-01 Thread Guinan Sun
Add method to clear VFMBMEM memory.  Clearing VFMBMEM memory is required from PF after receiving Virtual Function Level Reset request (VFLR). Signed-off-by: Piotr Pietruszewski Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_mbx.c | 43 + drivers/net/ixgb

[dpdk-dev] [PATCH v2] net/i40e: fix modify the number of qps in VF

2020-07-01 Thread alvinx . zhang
From: Alvin Zhang For a VF, if the number of request queue pairs is greater than that has been allocated by the kernel driver, the app may fail to start. This patch modify the request queue process. Fixes: c48eb308ed13 ("net/i40e: support VF request more queues") Fixes: dbda2092deb5 ("net/i40e:

Re: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter

2020-07-01 Thread Phil Yang
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, July 1, 2020 7:22 PM > To: Phil Yang > Cc: Honnappa Nagarahalli ; Carrillo, Erik G > ; dev@dpdk.org; d...@linux.vnet.ibm.com; > Ruifeng Wang ; Dharmik Thakkar > ; nd ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] eventde

Re: [dpdk-dev] [PATCH 6/6] app/test-eventdev: fix eventdev queues

2020-07-01 Thread Pavan Nikhilesh Bhagavatula
>Subject: [dpdk-dev] [PATCH 6/6] app/test-eventdev: fix eventdev >queues > >In pipeline_queue test case, if event queues are greater than the >max event queues it will fail. Nak, it should fail. If sufficient queues are not available how would the pipeline work? /* * The pipeli

Re: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter

2020-07-01 Thread Phil Yang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Friday, June 19, 2020 2:26 AM > To: Carrillo, Erik G ; Phil Yang > ; dev@dpdk.org > Cc: d...@linux.vnet.ibm.com; Ruifeng Wang ; > Dharmik Thakkar ; nd ; > sta...@dpdk.org; Honnappa Nagarahalli ; > nd > Subject: RE: [PATCH 1/3] even

Re: [dpdk-dev] [PATCH 5/6] app/test-eventdev: Enhancing perf-atq packet flow

2020-07-01 Thread Pavan Nikhilesh Bhagavatula
>Subject: [dpdk-dev] [PATCH 5/6] app/test-eventdev: Enhancing perf-atq >packet flow > >The event ethernet Tx adapter provides data path for the ethernet >transmit >stage. Enqueue a burst of events objects supplied on an event device. NAK, same as 1/6 use pipeline_atq/queue to test Rx->Tx performac

Re: [dpdk-dev] [PATCH 1/6] app/test-eventdev: Enhancing perf-queue packet flow

2020-07-01 Thread Pavan Nikhilesh Bhagavatula
>Subject: [dpdk-dev] [PATCH 1/6] app/test-eventdev: Enhancing perf- >queue packet flow > >The event ethernet Tx adapter provides data path for the ethernet >transmit >stage. Enqueue a burst of events objects supplied on an event device. > NAK, please use pipeline_atq/queue to test Rx->Tx performan

[dpdk-dev] [PATCH] net/enic: support burst mode info

2020-07-01 Thread Hyong Youb Kim
Add Rx/Tx burst mode getter handlers. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/nics/features/enic.ini | 1 + drivers/net/enic/enic.h | 1 + drivers/net/enic/enic_ethdev.c| 45 +++ drivers/net/enic/enic_rxtx_vec_avx2

[dpdk-dev] [PATCH] cfgfile: avoid stack buffer underflow

2020-07-01 Thread Stephen Hemminger
If cfgfile is give a line with comment character at the start of the line, it will dereference outside of the buffer. Detected with address sanitizer: SUMMARY: AddressSanitizer: stack-buffer-underflow lib/librte_cfgfile/rte_cfgfile.c:194 in rte_cfgfile_load_with_params Shadow bytes around the bu

Re: [dpdk-dev] [PATCH 1/3] ethdev: add new RSS offload types

2020-07-01 Thread Su, Simei
Hi, Qi > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, July 1, 2020 9:28 PM > To: Su, Simei ; Ye, Xiaolong ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Jia ; Guo, Junfeng > > Subject: RE: [PATCH 1/3] ethdev: add new RSS offload types > > > > > -Original Message- > >

Re: [dpdk-dev] [PATCH] dedicated queues: delete redundant check valid_bonded_port_id has include check_for_bonded_ethdev, no need to check again.

2020-07-01 Thread Wei Hu (Xavier)
Hi, pandongyang The title is too long, and lack of the commit log. You can use this script to check your commit when making patch ./devtools/check-git-log.sh -[num] On 2020/6/21 21:34, 197020...@qq.com wrote: From: pandongyang <197020...@qq.com> Signed-off-by: pandongyang <197020...

Re: [dpdk-dev] [PATCH v2 1/4] lib: introduce IF Proxy library

2020-07-01 Thread Stephen Hemminger
I had great hopes for this library, because such code exists in almost every real world application. But the current version falls short. So what this library does is turn a message based protocol (netlink) into a set of callbacks. Not sure if that is all that useful processing messages is often

Re: [dpdk-dev] [RFC v2 1/1] add flow shared action API

2020-07-01 Thread Stephen Hemminger
On Sat, 20 Jun 2020 16:32:57 +0300 Andrey Vesnovaty wrote: > + > +void * > +rte_flow_shared_action_create(uint16_t port_id, > + const struct rte_flow_action *action, > + struct rte_flow_error *error) > +{ NAK API's that return void * (opaque pointer) are dangerous and sh

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-07-01 Thread Stephen Hemminger
On Sun, 28 Jun 2020 15:52:27 + "Jiawei(Jonny) Wang" wrote: > > -Original Message- > > From: Jerin Jacob > > Sent: Sunday, June 28, 2020 9:38 PM > > To: Jiawei(Jonny) Wang > > Cc: Thomas Monjalon ; Ori Kam > > ; Slava Ovsiienko ; > > Matan Azrad ; dpdk-dev ; Raslan > > Darawsheh ; ia

Re: [dpdk-dev] [RFC PATCH 0/2] pmdinfogen: rewrite in Python

2020-07-01 Thread Dmitry Kozlyuk
On Tue, 23 Jun 2020 07:28:06 -0400 Neil Horman wrote: > On Mon, Jun 22, 2020 at 10:39:46PM +0300, Dmitry Kozlyuk wrote: > > On Mon, 22 Jun 2020 08:41:17 -0400, Neil Horman wrote: > > > On Mon, Jun 22, 2020 at 03:45:01AM +0300, Dmitry Kozlyuk wrote: [snip] > > I was talking about these fields

Re: [dpdk-dev] [PATCH 2/2] net/netvsc: detach external buffer on failure

2020-07-01 Thread Stephen Hemminger
On Tue, 23 Jun 2020 18:11:46 -0700 lon...@linuxonhyperv.com wrote: > From: Long Li > > When external buffer is used, driver should detach it if it doesn't make it > successfully to the queue. > > Signed-off-by: Long Li Good catch Acked-by: Stephen Hemminger

Re: [dpdk-dev] [PATCH 1/2] net/netvsc: fix underflow error when external mbuf are used in the receive path

2020-07-01 Thread Stephen Hemminger
On Tue, 23 Jun 2020 18:11:45 -0700 lon...@linuxonhyperv.com wrote: > From: Long Li > > When rte_pktmbuf_attach_extbuf() is used, the driver should not decrease the > reference count in its callback function hn_rx_buf_free_cb, because the > reference count is already decreased by rte_pktmbuf. Doi

Re: [dpdk-dev] [PATCH] maintainers: update for vmbus

2020-07-01 Thread Stephen Hemminger
On Thu, 25 Jun 2020 16:52:16 -0700 Long Li wrote: > From: Long Li > > Add Long Li as additional maintainer. > > Signed-off-by: Long Li Acked-by: Stephen Hemminger

[dpdk-dev] [RFC PATCH v2 2/3] build: use Python pmdinfogen

2020-07-01 Thread Dmitry Kozlyuk
Also don't suppress stderr from ar and pmdinfogen. Signed-off-by: Dmitry Kozlyuk --- GNUmakefile | 2 +- buildtools/Makefile | 9 - buildtools/gen-pmdinfo-cfile.sh | 3 +-- buildtools/meson.build | 3 +-- drivers/meson.build | 2 +- mk

[dpdk-dev] [RFC PATCH v2 3/3] doc/linux_gsg: require pyelftools for pmdinfogen

2020-07-01 Thread Dmitry Kozlyuk
The package is available on all major distributions. FreeBSD has no system requirements section in its GSG, Windows currently neither uses pmdinfogen not is supported by it. Signed-off-by: Dmitry Kozlyuk --- doc/guides/linux_gsg/sys_reqs.rst | 6 ++ 1 file changed, 6 insertions(+) diff --gi

[dpdk-dev] [RFC PATCH v2 0/2] pmdinfogen: rewrite in Python

2020-07-01 Thread Dmitry Kozlyuk
The goals are: * easier maintenance by using a more high-level language, * simpler build process without host application and libelf. Changes in v2: 1. pyelftools is used instead of hand-written ELF parser. 2. Makefiles are adjusted. 3. f-strings replaced with % formatting to support Python 3.5.

[dpdk-dev] [RFC PATCH v2 1/3] pmdinfogen: prototype in Python

2020-07-01 Thread Dmitry Kozlyuk
Requires pyelfutils, but no docs yet. Signed-off-by: Dmitry Kozlyuk --- buildtools/pmdinfogen.py | 191 +++ 1 file changed, 191 insertions(+) create mode 100755 buildtools/pmdinfogen.py diff --git a/buildtools/pmdinfogen.py b/buildtools/pmdinfogen.py new fil

Re: [dpdk-dev] [PATCH v3 7/8] app/crypto-perf: add support for DOCSIS protocol

2020-07-01 Thread Akhil Goyal
> > Update test-crypto-perf app to calculate DOCSIS throughput numbers. > > 1 new parameter is added for DOCSIS: > --docsis-hdr-sz > > ./dpdk-test-crypto-perf -l 3,4 --socket-mem 2048,0 > --vdev crypto_aesni_mb_pmd_1 -n 1 -- --devtype crypto_aesni_mb > --optype docsis --cipher-algo aes-docsisbp

Re: [dpdk-dev] [PATCH v3 5/8] test/crypto: add DOCSIS security test cases

2020-07-01 Thread Akhil Goyal
> > Add uplink and downlink DOCSIS unit test cases and vectors, to test > the combined DOCSIS Crypto-CRC support that has been added to the > rte_security library. > > Signed-off-by: David Coyle > Signed-off-by: Mairtin o Loingsigh > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v3 2/8] cryptodev: add a note regarding DOCSIS protocol support

2020-07-01 Thread Akhil Goyal
> > Add a note to the rte_crypto_sym_op->auth.data fields to state that > for DOCSIS security protocol, these are used to specify the CRC offset > and length. > > Signed-off-by: David Coyle > Signed-off-by: Mairtin o Loingsigh > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v3 1/8] security: add support for DOCSIS protocol

2020-07-01 Thread Akhil Goyal
> > Add support for DOCSIS protocol to rte_security library. This support > currently comprises the combination of Crypto and CRC operations. > > Signed-off-by: David Coyle > Signed-off-by: Mairtin o Loingsigh > --- With the documentation comments in the last patch. Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH 0/2] update to docs

2020-07-01 Thread Ferruh Yigit
On 7/1/2020 4:09 PM, Ajit Khaparde wrote: > Update documentation to indicate vector mode support ARM CPUs. Hi Ajit, I guess these are documenting the changes in the "net/bnxt: vector mode enhancements" patchset [1], if so can you please move document updates to that patchset and distribute the do

Re: [dpdk-dev] [PATCH v2 00/51] add features for host-based flow management

2020-07-01 Thread Ferruh Yigit
On 7/1/2020 3:26 PM, Ajit Khaparde wrote: > On Tue, Jun 30, 2020 at 11:52 PM Ajit Khaparde > wrote: > >> This patchset introduces support for VF representors, flow >> counters and on-chip exact match flows. >> Also implements the driver hook for the rte_flow_query API. >> >> v1->v2: >> - update

Re: [dpdk-dev] [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities

2020-07-01 Thread Akhil Goyal
> +static const struct rte_cryptodev_capabilities * > +otx2_cpt_sec_caps_get(union cpt_eng_caps *hw_caps) > +{ > + SEC_CAPS_ADD(hw_caps, aes); > + > + sec_caps_add(caps_end, RTE_DIM(caps_end)); > + > + return otx2_cpt_sec_caps; > +} SEC_CAPS_ADD should be called earlier when the securit

Re: [dpdk-dev] [PATCH 3/8] crypto/octeontx2: add cryptodev sec registration

2020-07-01 Thread Akhil Goyal
> > Signed-off-by: Vamsi Attunuru > Signed-off-by: Tejasree Kondoj > --- Patch description? > -#endif /* __OTX2_CRYPTODEV_SEC_H__ */ > +int otx2_crypto_sec_ctx_create(struct rte_cryptodev *crypto_dev); > + > +void otx2_crypto_sec_ctx_destroy(struct rte_cryptodev *crypto_dev); > + > +#endif /

Re: [dpdk-dev] [PATCH 0/8] add OCTEON TX2 lookaside IPsec support

2020-07-01 Thread Akhil Goyal
Hi Tejasree, > Subject: [PATCH 0/8] add OCTEON TX2 lookaside IPsec support > > This series adds lookaside IPsec support in OCTEON TX2 PMD. > > Features supported: > * IPv4 > * ESP > * Tunnel mode > * AES-128/192/256-GCM > > This series is on top of > http://patches.dpdk.org/patch/71638/ > I b

Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions

2020-07-01 Thread Akhil Goyal
> Subject: [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions > > Signed-off-by: Vamsi Attunuru > Signed-off-by: Tejasree Kondoj > --- Please add appropriate description in all the patches. > drivers/crypto/octeontx2/otx2_cryptodev_sec.h | 52 > drivers/crypto/octe

Re: [dpdk-dev] [PATCH 5/7] crypto/octeontx: remove unsupported feature

2020-07-01 Thread Akhil Goyal
Hi, > Subject: [PATCH 5/7] crypto/octeontx: remove unsupported feature > > For SNOW and ZUC algos the offset value for enryption and decryption > is converted to bytes. Hence RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA > feature is not supported by the octeontx crypto pmd. > > Fixes: 32b8f26adf8b ("c

[dpdk-dev] [PATCH v4 26/27] memif: replace master/slave with server/client

2020-07-01 Thread Stephen Hemminger
The names master and slave have no place inside this driver. It is really a traditional client server model, so use those names. Signed-off-by: Stephen Hemminger --- doc/guides/nics/memif.rst | 78 +- drivers/net/memif/memif.h | 40 +- drivers/net/memif/

[dpdk-dev] [PATCH v4 27/27] vhost: rename SLAVE to CLIENT

2020-07-01 Thread Stephen Hemminger
The vhost is a client server architecture so replace the term slave with client. Signed-off-by: Stephen Hemminger --- drivers/vdpa/ifc/ifcvf_vdpa.c | 4 +- drivers/vdpa/mlx5/mlx5_vdpa.c | 4 +- lib/librte_vhost/rte_vhost.h | 16 ++--- lib/librte_vhost/rte_vhost_vers

[dpdk-dev] [PATCH v4 23/27] app/pdump: replace references to master/slave lcore

2020-07-01 Thread Stephen Hemminger
Use initial and worker lcore instead. Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index c38c53719e7d..1590a716a31d 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -947,7 +947,

[dpdk-dev] [PATCH v4 20/27] app/test: replace refernces to master/slave

2020-07-01 Thread Stephen Hemminger
Use initial and worker when referring to lcores Signed-off-by: Stephen Hemminger --- app/test/autotest_test_funcs.py | 2 +- app/test/test.c | 2 +- app/test/test_atomic.c | 26 app/test/test_barrier.c | 2 +- app/test/test_cryptodev.c

[dpdk-dev] [PATCH v4 22/27] doc: update references to master/slave lcore in documentation

2020-07-01 Thread Stephen Hemminger
New terms are initial and worker lcores. Signed-off-by: Stephen Hemminger --- doc/guides/contributing/coding_style.rst| 2 +- doc/guides/faq/faq.rst | 6 +++--- doc/guides/howto/debug_troubleshoot.rst | 2 +- doc/guides/linux_gsg/eal_args.i

[dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated

2020-07-01 Thread Stephen Hemminger
Use of old RTE_LCORE_FOREACH_SLAVE and rte_get_master_lcore_id() are marked as deprecated. All uses of these in DPDK itself is gone. This will cause warnings for applications still using them. Signed-off-by: Stephen Hemminger --- lib/librte_eal/include/rte_launch.h | 4 ++-- lib/librte_eal/incl

[dpdk-dev] [PATCH v4 24/27] app/test-XXX: replace reference to master/slave

2020-07-01 Thread Stephen Hemminger
Use new terminology for lcore's Signed-off-by: Stephen Hemminger --- app/test-acl/main.c | 2 +- app/test-bbdev/test_bbdev_perf.c | 16 app/test-compress-perf/main.c| 8 app/test-crypto-perf/main.c | 14 +++--- app/test-flow-perf/main.c

[dpdk-dev] [PATCH v4 21/27] doc: fix incorrect reference to master process

2020-07-01 Thread Stephen Hemminger
Correct terminolgy here is primary process. This is a bug in original doc. Fixes: fc1f2750a3ec ("doc: programmers guide") Cc: bernard.iremon...@intel.com Signed-off-by: Stephen Hemminger --- doc/guides/prog_guide/thread_safety_dpdk_functions.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[dpdk-dev] [PATCH v4 19/27] test-eventdev: replace references to slave with worker lcores

2020-07-01 Thread Stephen Hemminger
Use new API terminolgy Signed-off-by: Stephen Hemminger --- app/test-eventdev/evt_options.c | 2 +- app/test-eventdev/test_order_common.c| 12 ++-- app/test-eventdev/test_perf_common.c | 16 app/test-eventdev/test_pipeline_common.c | 8 4 files

[dpdk-dev] [PATCH v4 16/27] examples/ipcsec-secgw: replace references to master lcore

2020-07-01 Thread Stephen Hemminger
Use initial lcore instead. Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/event_helper.c | 6 +++--- examples/ipsec-secgw/ipsec-secgw.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ipsec-secgw/event_helper.c b/examples/ipsec-secgw/event_helper.c i

[dpdk-dev] [PATCH v4 18/27] app/test-pmd: change references to master/slave

2020-07-01 Thread Stephen Hemminger
Use new API and naming convention Signed-off-by: Stephen Hemminger --- app/test-pmd/config.c | 4 ++-- app/test-pmd/parameters.c | 2 +- app/test-pmd/softnicfwd.c | 2 +- app/test-pmd/testpmd.c| 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/config.c

[dpdk-dev] [PATCH v4 13/27] examples/multi_process: replace references to master lcore

2020-07-01 Thread Stephen Hemminger
Use initial lcore instead. Signed-off-by: Stephen Hemminger --- .../multi_process/client_server_mp/mp_server/main.c| 10 +- examples/multi_process/simple_mp/main.c| 6 +++--- examples/multi_process/symmetric_mp/main.c | 2 +- 3 files changed, 9 insertion

[dpdk-dev] [PATCH v4 14/27] examples/performance-thread: replace reference to master lcore

2020-07-01 Thread Stephen Hemminger
Use initial lcore instead. Signed-off-by: Stephen Hemminger --- examples/performance-thread/l3fwd-thread/main.c | 12 ++-- examples/performance-thread/pthread_shim/main.c | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/mai

[dpdk-dev] [PATCH v4 17/27] examples: replace reference to master lcore

2020-07-01 Thread Stephen Hemminger
Small changes in several examples to replace master_lcore with initial_lcore across multiple small examples. Signed-off-by: Stephen Hemminger --- examples/eventdev_pipeline/main.c | 2 +- examples/flow_classify/flow_classify.c | 2 +- examples/helloworld/main.c | 6 +++--- ex

[dpdk-dev] [PATCH v4 12/27] examples/l2fwd: replace references to master lcore

2020-07-01 Thread Stephen Hemminger
Use term initial lcore instead. Signed-off-by: Stephen Hemminger --- examples/l2fwd-cat/l2fwd-cat.c | 2 +- examples/l2fwd-crypto/main.c | 8 examples/l2fwd-event/l2fwd_event_generic.c | 2 +- examples/l2fwd-event/l2fwd_event_internal_port.c |

[dpdk-dev] [PATCH v4 15/27] examples/ptpclient: replace references to master lcore

2020-07-01 Thread Stephen Hemminger
Replace master lcore with initial lcore. This API still has issue with use of term master clock. Signed-off-by: Stephen Hemminger --- examples/ptpclient/ptpclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c

[dpdk-dev] [PATCH v4 07/27] examples/bond: replace references to master lcore

2020-07-01 Thread Stephen Hemminger
Change the references to master lcore. For now, ok to keep 'slave' for bonding since that is part of the API not addressed yet. Signed-off-by: Stephen Hemminger --- examples/bond/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/bond/main.c b/examples/bo

[dpdk-dev] [PATCH v4 10/27] examples/qos_{meter/sched}: replace references to master lcore

2020-07-01 Thread Stephen Hemminger
Use initial lcore instead. Signed-off-by: Stephen Hemminger --- examples/qos_meter/main.c| 4 ++-- examples/qos_sched/args.c| 22 +++--- examples/qos_sched/cmdline.c | 2 +- examples/qos_sched/main.c| 2 +- 4 files changed, 15 insertions(+), 15 deletions(-) diff -

[dpdk-dev] [PATCH v4 08/27] examples/ethtool-app: replace references to slave with worker

2020-07-01 Thread Stephen Hemminger
Conforms to new API naming conventions. Signed-off-by: Stephen Hemminger --- examples/ethtool/ethtool-app/main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool-app/main.c index 7383413215d6..a55d31d891

[dpdk-dev] [PATCH v4 11/27] examples/l3fwd: replace references to master lcore

2020-07-01 Thread Stephen Hemminger
Use initial lcore instead. Signed-off-by: Stephen Hemminger --- examples/l3fwd-acl/main.c | 4 ++-- examples/l3fwd-graph/main.c | 14 +++--- examples/l3fwd-power/main.c | 20 ++-- examples/l3fwd/main.c | 2 +- 4 files changed, 20 insertions(+), 20 deletions(-) d

[dpdk-dev] [PATCH v4 09/27] examples/ip_pipeline: replace references to master_lcore

2020-07-01 Thread Stephen Hemminger
Use initial lcore instead of primary lcore Signed-off-by: Stephen Hemminger --- examples/ip_pipeline/main.c | 2 +- examples/ip_pipeline/thread.c | 16 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/examples/ip_pipeline/main.c b/examples/ip_pipeline/main.c ind

[dpdk-dev] [PATCH v4 06/27] examples/distributor: rename master to initial

2020-07-01 Thread Stephen Hemminger
Conform to new API Signed-off-by: Stephen Hemminger --- examples/distributor/main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index 567c5e98919d..d3906bede6fc 100644 --- a/examples/distributor/main.c +

[dpdk-dev] [PATCH v4 04/27] librte_power: change reference to rte_master_lcore

2020-07-01 Thread Stephen Hemminger
New API name is rte_get_initial_lcore() Signed-off-by: Stephen Hemminger --- lib/librte_power/rte_power_empty_poll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_power/rte_power_empty_poll.c b/lib/librte_power/rte_power_empty_poll.c index 70c07b1533f3..d54a09b9

[dpdk-dev] [PATCH v4 02/27] kni: fix reference to master/slave process

2020-07-01 Thread Stephen Hemminger
In DPDK, the correct terms for process are primary/secondary. This is bugfix, not a change in terms for new release. Fixes: f2e7592c474c ("kni: fix multi-process support") Signed-off-by: Stephen Hemminger --- lib/librte_kni/rte_kni.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[dpdk-dev] [PATCH v4 01/27] eal: rename terms used for DPDK lcores

2020-07-01 Thread Stephen Hemminger
Replace the old use of master/slave lcore with more inclusive name of initial/secondary lcore. The old visible API will stay for now. Change master2slave to new init2worker and vice-versa. This patch breaks the expected practice for new API's. The new rte_get_initial_lcore() will not go through

[dpdk-dev] [PATCH v4 05/27] drivers: replace master/slave terminology

2020-07-01 Thread Stephen Hemminger
Replace rte_get_master_lcore() with rte_get_initial_lcore(). Replace RTE_LCORE_FOREACH_SLAVE with RTE_LCORE_FOREACH_WORKER Signed-off-by: Stephen Hemminger --- drivers/bus/dpaa/dpaa_bus.c | 2 +- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 6 +++--- drivers/net/bnxt/bnxt_ring

[dpdk-dev] [PATCH v4 03/27] bbdev: rename master to initial lcore

2020-07-01 Thread Stephen Hemminger
Conform to new API. Signed-off-by: Stephen Hemminger --- examples/bbdev_app/main.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 68a46050c048..d1db739d4e2f 100644 --- a/examples/bbdev_app/main.c +++

[dpdk-dev] [PATCH v4 00/27] Replace references to master and slave

2020-07-01 Thread Stephen Hemminger
This set of patches changes the API and conventions around referring to DPDK lcores. The first patch changes rte_get_master_lcore_id and related calls. The rest fix the DPDK to use the new naming. Buried in the documentation set are a couple of patches where we were using incorrect naming around p

Re: [dpdk-dev] [PATCH 1/7] common/cpt: fix encryption offset

2020-07-01 Thread Akhil Goyal
> > In case of gmac auth the encryption offset should be set to zero. > > Fixes: b74652f3a91f ("common/cpt: add microcode interface for encryption") > Fixes: 177b41ceee61 ("common/cpt: add microcode interface for decryption") > > Signed-off-by: Ankur Dwivedi I believe this should be backported

Re: [dpdk-dev] [PATCH 7/7] test/crypto: use generic cryptotests for OCTEON TX PMDs

2020-07-01 Thread Akhil Goyal
Hi Anoob/Ankur, > From: Anoob Joseph > > This patch enables the generic crypto tests for OCTEON TX PMDs. > Reomves the PMD specific tests. Spell check. > > Signed-off-by: Ankur Dwivedi > Signed-off-by: Anoob Joseph > --- > app/test/test_cryptodev.c | 769 > +

Re: [dpdk-dev] [PATCH] compress/qat: revert change in GEN3 marketing name

2020-07-01 Thread Akhil Goyal
Hi Fiona, > > Hi Akhil, > > Sorry about the confusion. > This was a simple internal miscommunication - there was a decision made to > change the name, so we did promptly. > The decision was reversed pretty soon after due to an impact on other > projects, > but I was out-of-the loop on it - I jus

Re: [dpdk-dev] [PATCH 2/3] cryptodev: verify session mempool element size

2020-07-01 Thread Akhil Goyal
> > Subject: [PATCH 2/3] cryptodev: verify session mempool element size > > > > This patch adds the verification of the element size of the > > mempool provided for the session creation. Returns the error > > if the element size is too small to hold the session object. > > > > Signed-off-by: Adam D

  1   2   3   4   >