Hi Vladimir,
Few comments inline.
> -Original Message-
> From: dev On Behalf Of Vladimir Medvedkin
> Sent: Friday, May 8, 2020 2:59 PM
> To: dev@dpdk.org
> Cc: konstantin.anan...@intel.com; yipeng1.w...@intel.com;
> sameh.gobr...@intel.com; bruce.richard...@intel.com
> Subject: [d
> -Original Message-
> From: David Marchand
> Sent: Thursday, June 25, 2020 04:01
> To: Wang, Haiyue
> Cc: dev ; Burakov, Anatoly ; dpdk
> stable ;
> Maxime Coquelin
> Subject: Re: [dpdk-dev] [PATCH v3] bus/pci: fix VF bus error for memory access
>
> On Mon, Jun 22, 2020 at 1:23 PM Hai
To fix CVE-2020-12888, the linux vfio-pci module will invalidate mmaps
and block MMIO access on disabled memory, it will send a SIGBUS to the
application:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=abafbc551fddede3e0a08dee1dcde08fc0eb8476
When the application ope
DPDK team,
I have a use-case for multicast and wanted to know the current behavior of
ixgbe pf and vf driver so my understanding is correct.
use-case: 2 VF's (vf1 and vf2 ) from ixgbe is assigned to 2 VM's (vm1 and
vm2)
vf1 -- registers to mcast 01:00:5e:00:00:01, 01:00:5e:00:00:0a
vf2 -- regist
Hi, Tasnim...
On 6/24/2020 4:10 PM, Tasnim Bashar wrote:
Casting thread ID to handle is not accurate way to get thread handle.
Need to use OpenThread function to get thread handle from thread ID.
pthread_setaffinity_np and pthread_getaffinity_np functions
for Windows are affected because of it.
> From: Thomas Monjalon :
> 02/05/2020 01:15, Chautru, Nicolas:
> > Hi Akhil, Thomas,
> >
> > Following up on that previous discussion below so that to confirm whether
> there is an available option to handle this usecase within DPDK repo.
> >
> > Basically traditional deployment for VRAN relies on
> > Caught by code review, bitops test name is incorrect.
> >
> > Fixes: 7660614c11e2 ("test/bitops: add bit operations test case")
> >
> > Signed-off-by: David Marchand
> > ---
> Acked-by: Phil Yang
Applied, thanks
10/06/2020 16:40, Ferruh Yigit:
> On 6/10/2020 3:30 PM, David Marchand wrote:
> > rte_eal_init_alert() already appends a newline.
> >
> > Fixes: 0a529578f162 ("eal: clean up unused files on initialization")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: David Marchand
>
> Reviewed-by: Ferruh Yi
Casting thread ID to handle is not accurate way to get thread handle.
Need to use OpenThread function to get thread handle from thread ID.
pthread_setaffinity_np and pthread_getaffinity_np functions
for Windows are affected because of it.
Signed-off-by: Tasnim Bashar
---
v3: WA to remove warning
10/06/2020 15:38, Bruce Richardson:
> On Wed, Jun 10, 2020 at 02:30:33PM +0100, Ciara Power wrote:
> > The path to the socket when running the script as a regular user needed
> > to be updated to match the logic in EAL.
> >
> > Fixes: 6a2967c112a3 ("usertools: add new telemetry script")
+Cc: sta.
12/06/2020 18:06, Stephen Hemminger:
> On Thu, 11 Jun 2020 17:48:25 -0700
> lon...@linuxonhyperv.com wrote:
>
> > From: Long Li
> >
> > vmbus_map_addr is used as the next start virutal address for mapping ring
> > buffer. However it's updated based on ring_buf, which is a pointer to an
> > addre
> > 64-bit support was missing from the functions pipe_profile_check and
> > rte_sched_subport_config_pipe_profile_table.
> >
> > Fixes: 68c1f26d4236 ("sched: support 64-bit values")
> > Cc: jasvinder.si...@intel.com
> >
> > Signed-off-by: Archit Pandey
>
> + CC sta...@dpdk.org
>
> Acked-by: J
Is this old patch still relevant?
25/07/2018 11:02, Alan Dewar:
> Hi Stephen,
>
> Sorry about the delay in responding to your comment.
>
> Maybe I'm missing something but I don't consider 64-bit counter
> rollover to be a problem.
> The DPDK QoS stats are just 32-bits wide and are zeroed when r
Jasvinder, what is the conclusion of this patch?
21/04/2020 10:21, Dewar, Alan:
> From: Singh, Jasvinder
> > > > From: Alan Dewar
> > > >
> > > > The QoS scheduler works off port time that is computed from the
> > > > number of CPU cycles that have elapsed since the last time the port was
> >
30/05/2020 10:05, Hrvoje Habjanic:
> On 27. 05. 2020. 13:48, Singh, Jasvinder wrote:
> >>
> >> In function rte_sched_subport_free (lib/librte_sched/rte_sched.c, line
> >> 865),
> >> there is code to free all allocated stuff related to scheduler subport.
> >> First
> >> there are some checks, and
28/04/2020 15:27, Andrew Rybchenko:
> From: Georgiy Levashov
>
> When printf()'s stdout is line-buffered for terminal, it is fully
> buffered for pipes. So, stdout listener can only get the output
> when it is flushed (on program termination, when buffer is filled or
> manual flush).
>
> stdout
24/06/2020 13:46, jer...@marvell.com:
> From: Jerin Jacob
>
> In order to optimize the PCI management, RTE_KDRV_NONE based
> device driver probing removed by not adding them to list in
> the scan phase.
>
> The legacy virtio is the only consumer of RTE_KDRV_NONE based device
> driver probe schem
27/05/2020 16:16, Konstantin Ananyev:
> To fill the gap with linux kernel eBPF implementation,
> add support for two non-generic instructions:
> (BPF_ABS | | BPF_LD) and (BPF_IND | | BPF_LD)
> which are used to access packet data in a safe manner.
> Make necessary changes in BPF verifier, interpr
18/05/2020 17:52, Konstantin Ananyev:
> Address for few small issues:
> - unreachable return statement
> - failed test-case can finish with 'success' status
>
> Also use unified cmp_res() function to check return value.
>
> Fixes: a9de470cc7c0 ("test: move to app directory")
Looks like you don
Hello,
24/06/2020 17:14, Owen Hilyard:
> Hello,
>
> To my understanding, this feature is the ability of the driver to
> offload checksum verification on received packets to the hardware
> level. If that is incorrect, then please let me know.
Yes, you're right.
You can find some pointers in the d
24/06/2020 22:01, Lincoln Lavoie:
> Inline.
>
> On Wed, Jun 24, 2020 at 3:55 PM Thomas Monjalon wrote:
>
> > Hi,
> >
> > A bit of context: Daniel is going to implement a test in DTS
> > for ethdev speed capability:
> > http://doc.dpdk.org/guides/nics/features.html#speed-capabilities
> >
> > 24/0
Hi,
A bit of context: David is going to implement a test in DTS
for promiscuous mode:
http://doc.dpdk.org/guides/nics/features.html#promiscuous-mode
24/06/2020 18:18, David Liu:
> Hi all,
>
> From my understanding, the promiscuous mode feature will verify the
> functionality of promiscuous mode
Inline.
On Wed, Jun 24, 2020 at 3:55 PM Thomas Monjalon wrote:
> Hi,
>
> A bit of context: Daniel is going to implement a test in DTS
> for ethdev speed capability:
> http://doc.dpdk.org/guides/nics/features.html#speed-capabilities
>
> 24/06/2020 21:32, Daniel Kirichok:
> > The Speed Capabilitie
On Mon, Jun 22, 2020 at 1:23 PM Haiyue Wang wrote:
>
> To fix CVE-2020-12888, the linux vfio-pci module will invalidate mmaps
> and block MMIO access on disabled memory, it will send a SIGBUS to the
> application:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=abaf
Hi,
A bit of context: Daniel is going to implement a test in DTS
for ethdev speed capability:
http://doc.dpdk.org/guides/nics/features.html#speed-capabilities
24/06/2020 21:32, Daniel Kirichok:
> The Speed Capabilities test will first check the speed of each interface
> that the device lists thro
> Subject: [PATCH v1] net/virtio: simplify variable name
>
> Virtio_hw *hw has been pointed to vq->hw, it is better to use hw instead of
> vq->hw in later code.
>
> Signed-off-by: Joyce Kong
Reviewed-by: Honnappa Nagarahalli
> ---
> drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 ++--
> 1
Hi all,
The Speed Capabilities test will first check the speed of each interface
that the device lists through ethtool. Then it compares each interface
speed to a user-defined set of expected speeds set in a newly created
config file, `speed_capabilities.cfg`. The test fails if an interface is
fou
24/06/2020 20:09, Stephen Hemminger:
> > > +/**
> > > + * @warning
> > > + * @b EXPERIMENTAL: this structure may change without prior notice
> > > + *
> > > + * RTE_FLOW_ACTION_TYPE_SAMPLE
> > > + *
> > > + * Adds a sample action to a matched flow.
> > > + *
> > > + * The matching packets will be d
On 6/24/2020 9:52 AM, Ferruh Yigit wrote:
> On 6/24/2020 4:48 AM, Chengchang Tang wrote:
>>
>> On 2020/6/23 17:30, Andrew Rybchenko wrote:
>>> On 6/23/20 9:48 AM, Chengchang Tang wrote:
In common practice, PMD configure the rx_buf_size according to the data
room size of the object in memp
On Wed, Jun 24, 2020 at 9:13 PM Andrew Rybchenko
wrote:
>
> On 6/24/20 6:32 PM, Jerin Jacob wrote:
> > On Wed, Jun 24, 2020 at 8:56 PM Andrew Rybchenko
> > wrote:
> >>
> >> On 6/24/20 4:11 PM, Jerin Jacob wrote:
> >>> On Wed, Jun 17, 2020 at 3:51 PM Andrew Rybchenko
> >>> wrote:
>
> On
On Wed, 24 Jun 2020 19:07:49 +0200
Thomas Monjalon wrote:
> >
> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this structure may change without prior notice
> > + *
> > + * RTE_FLOW_ACTION_TYPE_SAMPLE
> > + *
> > + * Adds a sample action to a matched flow.
> > + *
> > + * The matching packet
Ping for review
09/06/2020 17:07, Oz Shlomo:
> Rte_flow API provides the building blocks for vendor agnostic flow
> classification offloads. The rte_flow match and action primitives are fine
> grained, thus enabling DPDK applications the flexibility to offload network
> stacks and complex pipelin
Ping for review
11/06/2020 15:19, Jiawei Wang:
> When using full offload, all traffic will be handled by the HW, and
> directed to the requested vf or wire, the control application loses
> visibility on the traffic.
> So there's a need for an action that will enable the control application
> some
+Cc Ian & Flavio who discussed flow mirroring in OvS meeting.
See below what Mellanox is submitting:
25/05/2020 15:30, Gal Cohen (Product):
> [2] Support flow-based traffic sampling or mirroring:
>
> Packets of a given classification, can be cloned at a given sampling rate and
> forwarded to a v
Hi all,
>From my understanding, the promiscuous mode feature will verify the
functionality of promiscuous mode when it is on or off. The plan for
testing this feature is as follows:
Sending over a packet to verify the ports are working properly before any
testing. First to verify the promiscuous
On 6/24/20 6:32 PM, Jerin Jacob wrote:
> On Wed, Jun 24, 2020 at 8:56 PM Andrew Rybchenko
> wrote:
>>
>> On 6/24/20 4:11 PM, Jerin Jacob wrote:
>>> On Wed, Jun 17, 2020 at 3:51 PM Andrew Rybchenko
>>> wrote:
On 6/17/20 1:02 PM, David Marchand wrote:
> On Wed, Jun 17, 2020 at 8:30 AM
On Wed, Jun 24, 2020 at 8:56 PM Andrew Rybchenko
wrote:
>
> On 6/24/20 4:11 PM, Jerin Jacob wrote:
> > On Wed, Jun 17, 2020 at 3:51 PM Andrew Rybchenko
> > wrote:
> >>
> >> On 6/17/20 1:02 PM, David Marchand wrote:
> >>> On Wed, Jun 17, 2020 at 8:30 AM wrote:
>
> From: Jerin Jacob
> >
On 6/24/20 4:11 PM, Jerin Jacob wrote:
> On Wed, Jun 17, 2020 at 3:51 PM Andrew Rybchenko
> wrote:
>>
>> On 6/17/20 1:02 PM, David Marchand wrote:
>>> On Wed, Jun 17, 2020 at 8:30 AM wrote:
From: Jerin Jacob
Introducing the RTE_LOG_REGISTER macro to avoid the code duplication
Hi Akhil,
Sorry about the confusion.
This was a simple internal miscommunication - there was a decision made to
change the name, so we did promptly.
The decision was reversed pretty soon after due to an impact on other projects,
but I was out-of-the loop on it - I just discovered it recently.
On Wed, Jun 24, 2020 at 02:48:24PM +0100, Ciara Power wrote:
> The ethdev library now registers a telemetry command for basic ethdev
> statistics.
>
> An example usage is shown below:
>
> Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2
> {"version": "DPDK 20.08.0-rc0", "pid": 14119, "max_output
On Wed, Jun 24, 2020 at 02:48:23PM +0100, Ciara Power wrote:
> Arrays and Dicts now support uint64_t, int and string
> array values. Only one level of recursion supported.
>
> Signed-off-by: Ciara Power
>
A number of comments inline below. Once fixed you can include my ack on V3.
Acked-by: Bru
Hello,
To my understanding, this feature is the ability of the driver to
offload checksum verification on received packets to the hardware
level. If that is incorrect, then please let me know. My plan for
testing this feature is as follows;
This feature will be verified by a series of test cases
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Wednesday, June 24, 2020 5:04 PM
>
> 24/06/2020 15:00, Morten Brørup:
> > > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > > Sent: Wednesday, June 24, 2020 2:22 PM
> > >
> > > 27/05/2020 15:40, guohongzhi:
> > >
On Wed, Jun 24, 2020 at 02:48:23PM +0100, Ciara Power wrote:
> Arrays and Dicts now support uint64_t, int and string
> array values. Only one level of recursion supported.
>
> Signed-off-by: Ciara Power
>
> ---
Approach seems good to me, but I think you need more detail in the commit
log for thi
>Subject: [dpdk-dev] [PATCH] eal: generic counter based loop for CPU
>freq calculation
>
>get_tsc_freq uses 'nanosleep' system call to calculate the CPU
>frequency. However, 'nanosleep' results in the process getting
>un-scheduled. The kernel saves and restores the PMU state. This
>ensures that the
> -Original Message-
> From: Dybkowski, AdamX
> Sent: Monday, June 8, 2020 2:15 PM
> To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com
> Cc: Dybkowski, AdamX
> Subject: [PATCH 3/3] crypto/qat: verify session IOVA
>
> This patch adds the verification of the crypto session IOVA
> tha
24/06/2020 15:00, Morten Brørup:
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > Sent: Wednesday, June 24, 2020 2:22 PM
> >
> > 27/05/2020 15:40, guohongzhi:
> > > From: Hongzhi Guo
> > >
> > > __rte_raw_cksum should consider Big Endian.
> >
> > We need to explain the logic in the com
From: Tal Shnaiderman
This patchset implements the EAL functions needed for probing PMDs using vdev
on Windows.
---
Depends-on: series-10579 ("Windows bus/pci support")
---
Tal Shnaiderman (2):
eal/windows: Add needed calls to detect vdev PMD
bus/vdev: Windows support
drivers/bus/vdev/me
From: Tal Shnaiderman
Add needed function calls in rte_eal_init to detect vdev PMD.
eal_option_device_parse()
rte_service_init()
rte_bus_probe()
Signed-off-by: Tal Shnaiderman
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/windows/eal.c | 19 +++
2 files cha
From: Tal Shnaiderman
current support will build vdev with empty MP functions
currently unsupported for Windows
Signed-off-by: Tal Shnaiderman
---
drivers/bus/vdev/meson.build | 6 --
lib/librte_eal/rte_eal_exports.def | 4
2 files changed, 4 insertions(+), 6 deletions(-)
diff
> -Original Message-
> From: Dybkowski, AdamX
> Sent: Monday, June 8, 2020 2:15 PM
> To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com
> Cc: Dybkowski, AdamX
> Subject: [PATCH 2/3] cryptodev: verify session mempool element size
>
> This patch adds the verification of the element siz
>
> Akhil,
>
> This doesn't have to be backported as the original patch was withdrawn from
> the stable before the release, thanks to Fiona's prompt action. That's why
> this
> commit revert patch affects only the dev branch.
>
Ok send a v2 with proper description why this need to be reverte
Akhil,
This doesn't have to be backported as the original patch was withdrawn from the
stable before the release, thanks to Fiona's prompt action. That's why this
commit revert patch affects only the dev branch.
Adam
> -Original Message-
> From: Akhil Goyal
> Sent: Wednesday, 24 June
The mlx5_check_vec_rx_support function in the mlx5_rxtx_vec.c file
passes the RX queues array in the loop. Similarly, the mlx5_mprq_enabled
function in the mlx5_rxq.c file passes the RX queues array in the loop.
In both cases, the iterator of the loop is called i and the variable
representing the
> -Original Message-
> From: Dybkowski, AdamX
> Sent: Monday, June 8, 2020 2:15 PM
> To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com
> Cc: Dybkowski, AdamX ; sta...@dpdk.org
> Subject: [PATCH 1/3] test/crypto: fix asym session mempool creation
>
> This patch fixes the element size
Hi Adam/Fiona,
Please mention a reason why this patch need to be reverted.
We cannot keep on changing a marketing name in every release.
If this patch is needed, then we should also queue it for stable backporting.
Regards,
Akhil
> > -Original Message-
> > From: Dybkowski, AdamX
> > Sent
> -Original Message-
> From: Dybkowski, AdamX
> Sent: Monday, June 8, 2020 3:42 PM
> To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com
> Cc: Dybkowski, AdamX
> Subject: [PATCH] compress/qat: revert change in GEN3 marketing name
>
> This reverts commit 9cd9d3e702fba4700539c1a2eddac1
From: Fiona Trahe
This patch adds function that can check if queue pair
was already setup. This may be useful when dealing with
multi process approach in cryptodev.
Signed-off-by: Fiona Trahe
---
v2:
- changed return values
- added function to map file
lib/librte_cryptodev/rte_cryptodev.c
Hi Akhil,
> -Original Message-
> From: Akhil Goyal
> Sent: Tuesday, June 23, 2020 7:07 PM
> >
> > +/**
> > + * DOCSIS operation parameters
> > + */
> > +struct rte_security_docsis_op {
> > + struct rte_crypto_sym_op crypto_sym;
> > + /**< Symmetric crypto operation parameters */
> > +
Due to increasing interest in multi process support for crypto PMDs
new sample app can be added so in overview we can say that:
The Multi-process Crypto application is a simple application that
allows to run crypto related operations in a multiple process environment. It
builds on the EAL primary/
This patch adds example application that can test
usage of cryptodev in multi process environment.
More can be found in mp_crypto.rst in sample app guides.
Signed-off-by: Arek Kusztal
---
doc/guides/sample_app_ug/index.rst |1 +
doc/guides/sample_app_ug/mp_crypto.rst | 153 +
exampl
This patch improves handling of multi process applications
using Intel QuickAssist Technology PMD.
Signed-off-by: Arek Kusztal
---
v2:
- fixed error caused by incorrect pointer due to information from other process
- fixed checkpack issues
drivers/common/qat/qat_device.c | 109 +
The mlx5_dev_spawn function defines an struct mlx5dv_ctx_allocators type
variable several hundred rows after it starts, with the only use it
being passed as a parameter to the mlx5_glue->dv_set_context_attr
function.
However, according to DPDK Coding Style Guidelines, variables should be
declared a
Flow tag action is supported only when the driver has DR or DV support.
The tag allocation is adjusted to the modes DV or DR.
In case both DR and DV are not supported in the system, the driver
handles static code for error report.
This error code, wrongly, was compiled when DV is supported while i
Using RTE_ETH_FOREACH_DEV_OF loop is not necessary when the driver wants
to find only the first match.
Use rte_eth_find_next_of to find it.
Signed-off-by: Michael Baum
Acked-by: Matan Azrad
---
drivers/net/mlx5/mlx5_mr.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
The mlx5_check_vec_rx_support function in the mlx5_rxtx_vec.c file
passes the RX queues array in the loop. Similarly, the mlx5_mprq_enabled
function in the mlx5_rxq.c file passes the RX queues array in the loop.
In both cases, the iterator of the loop is called i and the variable
representing the
The mlx5_check_vec_rx_support function in the mlx5_rxtx_vec.c file
passes the RX queues array in the loop. Similarly, the mlx5_mprq_enabled
function in the mlx5_rxq.c file passes the RX queues array in the loop.
In both cases, the iterator of the loop is called i and the variable
representing the
The mlx5_check_vec_rx_support function in the mlx5_rxtx_vec.c file
passes the RX queues array in the loop. Similarly, the mlx5_mprq_enabled
function in the mlx5_rxq.c file passes the RX queues array in the loop.
In both cases, the iterator of the loop is called i and the variable
representing the
The mlx5_check_vec_rx_support function in the mlx5_rxtx_vec.c file
passes the RX queues array in the loop. Similarly, the mlx5_mprq_enabled
function in the mlx5_rxq.c file passes the RX queues array in the loop.
In both cases, the iterator of the loop is called i and the variable
representing the
The mlx5_check_vec_rx_support function in the mlx5_rxtx_vec.c file
passes the RX queues array in the loop. Similarly, the mlx5_mprq_enabled
function in the mlx5_rxq.c file passes the RX queues array in the loop.
In both cases, the iterator of the loop is called i and the variable
representing the
The mlx4_ibv_device_to_pci_addr function defines a variable called ret
inside a loop and uses it.
During the loop, the function assigns a value within the variable and
breaks from the loop, so that this assigning has done nothing and is
actually unnecessary.
Remove the unnecessary assigning.
Sig
The mlx5_dev_spawn function defines an struct mlx5dv_ctx_allocators type
variable several hundred rows after it starts, with the only use it
being passed as a parameter to the mlx5_glue->dv_set_context_attr
function.
However, according to DPDK Coding Style Guidelines, variables should be
declared a
Hi Akhil
> -Original Message-
> From: Akhil Goyal
> Sent: Tuesday, June 23, 2020 7:38 PM
> > > >
> > > [DC] It's certainly an option and would work but I don't think it's
> > > a good idea to
> > be putting
> > > protocol specific structs like this in rte_cryptodev - that's what
> > > rte
Arrays and Dicts now support uint64_t, int and string
array values. Only one level of recursion supported.
Signed-off-by: Ciara Power
---
v2:
- Added support for arrays to have container values.
- Added support for int and string arrays within dict/array.
- Added APIs for internal containe
The ethdev library now registers a telemetry command for basic ethdev
statistics.
An example usage is shown below:
Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2
{"version": "DPDK 20.08.0-rc0", "pid": 14119, "max_output_len": 16384}
--> /ethdev/stats,0
{"/ethdev/stats": {"ipackets": 0, "opacke
This patchset adds support for basic ethdev statistics in Telemetry.
To do this, recursive data object support is needed to report the queue
statistics in a list. With this patch, an array or dictionary supports
uint64_t, int or string array types, which is used for the ethdev
queue stats.
Ciara P
The mlx5_dev_spawn function defines an struct mlx5dv_ctx_allocators type
variable several hundred rows after it starts, with the only use it
being passed as a parameter to the mlx5_glue->dv_set_context_attr
function.
However, according to DPDK Coding Style Guidelines, variables should be
declared a
The mlx4_ibv_device_to_pci_addr function defines a variable called ret
inside a loop and uses it.
During the loop, the function assigns a value within the variable and
breaks from the loop, so that this assigning has done nothing and is
actually unnecessary.
Remove the unnecessary assigning.
Sig
Sorry, this patch has been sent by mistake,
just discard it.
On 6/24/20 2:26 PM, Maxime Coquelin wrote:
> The VDPA example now uses the vDPA class iterator, so
> knowing the number of available devices beforehand is
> no longer needed.
>
> Signed-off-by: Maxime Coquelin
> ---
> examples/vdpa/ma
Sorry, this patch has been sent by mistake,
just discard it.
On 6/24/20 2:26 PM, Maxime Coquelin wrote:
> Now that wrappers to query number of queues, Virtio
> features and Vhost-user protocol features are available,
> let's make the vDPA example to use them.
>
> Signed-off-by: Maxime Coquelin
>
Sorry, this patch has been sent by mistake,
just discard it.
On 6/24/20 2:26 PM, Maxime Coquelin wrote:
> This API is no more useful, this patch removes it.
>
> Signed-off-by: Maxime Coquelin
> ---
> drivers/vdpa/ifc/ifcvf_vdpa.c | 1 +
> drivers/vdpa/mlx5/mlx5_vdpa.h | 1 +
> lib/librt
The mlx5_dev_to_pci_addr function defines a variable called ret inside a
loop and uses it.
During the loop, the function assigns a value within the variable and
breaks from the loop, so that this assigning has done nothing and is
actually unnecessary.
Remove the unnecessary assigning.
Signed-off
The mlx4_pci_probe function defines an struct mlx4dv_ctx_allocators type
variable several hundred rows after it starts, with the only use it
being passed as a parameter to the mlx4_glue->dv_set_context_attr
function.
However, according to DPDK Coding Style Guidelines, variables should be
declared a
Using RTE_ETH_FOREACH_DEV_OF loop is not necessary when the driver wants
to find only the first match.
Use rte_eth_find_next_of to find it.
Signed-off-by: Michael Baum
Acked-by: Matan Azrad
---
drivers/net/mlx5/mlx5_mr.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
Flow tag action is supported only when the driver has DR or DV support.
The tag allocation is adjusted to the modes DV or DR.
In case both DR and DV are not supported in the system, the driver
handles static code for error report.
This error code, wrongly, was compiled when DV is supported while i
> Add new lookup implementation for DIR24_8 algorithm using
> AVX512 instruction set
>
> Signed-off-by: Vladimir Medvedkin
> ---
> lib/librte_fib/Makefile | 14
> lib/librte_fib/dir24_8.c| 24 ++
> lib/librte_fib/dir24_8_avx512.c | 165
>
>
> New data type to manipulate 512 bit AVX values.
>
> Signed-off-by: Vladimir Medvedkin
> ---
> lib/librte_eal/x86/include/rte_vect.h | 20
> 1 file changed, 20 insertions(+)
>
> diff --git a/lib/librte_eal/x86/include/rte_vect.h
> b/lib/librte_eal/x86/include/rte_vect.
On Wed, Jun 17, 2020 at 3:51 PM Andrew Rybchenko
wrote:
>
> On 6/17/20 1:02 PM, David Marchand wrote:
> > On Wed, Jun 17, 2020 at 8:30 AM wrote:
> >>
> >> From: Jerin Jacob
> >>
> >> Introducing the RTE_LOG_REGISTER macro to avoid the code duplication
> >> in the log registration process.
> >>
>
On Wed, Jun 17, 2020 at 3:56 PM Andrew Rybchenko
wrote:
>
> On 6/17/20 1:00 PM, Thomas Monjalon wrote:
> > 17/06/2020 08:30, jer...@marvell.com:
> >> From: Jerin Jacob
> >>
> >> Introducing the RTE_LOG_REGISTER macro to avoid the code duplication
> >> in the log registration process.
> >>
> >> It
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, June 24, 2020 2:22 PM
>
> 27/05/2020 15:40, guohongzhi:
> > From: Hongzhi Guo
> >
> > __rte_raw_cksum should consider Big Endian.
>
> We need to explain the logic in the commit log.
Having grown up with big endian CPUs, rea
On Tue, Jun 9, 2020 at 3:04 AM Honnappa Nagarahalli
wrote:
>
> get_tsc_freq uses 'nanosleep' system call to calculate the CPU
> frequency. However, 'nanosleep' results in the process getting
> un-scheduled. The kernel saves and restores the PMU state. This
> ensures that the PMU cycles are not cou
New cn98xx SOC comes up with two NIX blocks wrt
cn96xx, cn93xx, to achieve higher performance.
Also the no of cores increased to 36 from 24.
Adding support for cn98xx where need a logic to
detect if the LF is attached to NIX0 or NIX1 and
then accordingly use the respective NIX block.
Signed-off-b
This patches fixes a null pointer derefencing that happens
when the device string passed to the iterator is NULL. This
situation can happen when iterating on a class type.
For example:
RTE_DEV_FOREACH(dev, "class=eth", &dev_iter) {
...
}
Fixes: e67a61614d0b ("bus/fslmc: support device iterati
This patch split the vDPA header file in two, making
rte_vdpa_device structure opaque to the application.
Applications should only include rte_vdpa.h, while drivers
should include both rte_vdpa.h and rte_vdpa_dev.h.
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/ifc/ifcvf_vdpa.c | 1 +
dri
Now that wrappers to query number of queues, Virtio
features and Vhost-user protocol features are available,
let's make the vDPA example to use them.
Signed-off-by: Maxime Coquelin
---
examples/vdpa/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/vdpa/main
This API is no more useful, this patch removes it.
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/ifc/ifcvf_vdpa.c | 1 +
drivers/vdpa/mlx5/mlx5_vdpa.h | 1 +
lib/librte_vhost/Makefile | 3 +-
lib/librte_vhost/meson.build| 3 +-
lib/librte_vhost/rte_vdpa.h | 155 --
This API is no more useful, this patch removes it.
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/rte_vdpa.h| 13 -
lib/librte_vhost/rte_vhost_version.map | 1 -
lib/librte_vhost/vdpa.c| 9 -
3 files changed, 23 deletions(-)
diff --git a/li
The VDPA example now uses the vDPA class iterator, so
knowing the number of available devices beforehand is
no longer needed.
Signed-off-by: Maxime Coquelin
---
examples/vdpa/main.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/examples/vdpa/main.c b/examples/vdpa/
The VDPA example now uses the vDPA class iterator, so
knowing the number of available devices beforehand is
no longer needed.
Signed-off-by: Maxime Coquelin
---
examples/vdpa/main.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/examples/vdpa/main.c b/examples/vdpa/
This patch is preliminary work to make the vDPA device
structure opaque to the user application. Some callbacks
of the vDPA devices are used to query capabilities before
attaching to a Vhost port. This patch introduces wrappers
for these ops.
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/r
1 - 100 of 204 matches
Mail list logo
