30/05/2020 10:05, Hrvoje Habjanic:
> On 27. 05. 2020. 13:48, Singh, Jasvinder wrote:
> >>
> >> In function rte_sched_subport_free (lib/librte_sched/rte_sched.c, line
> >> 865),
> >> there is code to free all allocated stuff related to scheduler subport.
> >> First
> >> there are some checks, and in the end, rte_bitmap_free is called.
> >>
> >> Now, rte_bitmap_free is a dummy function, and it just checks if provided
> >> pointer to bitmap is valid or not. So, actual memory for subport is not
> >> freed.
> >>
> >> This patch fixes this by removing call to rte_bitmap_free, and instead
> >> calling
> >> rte_free.
> >>
> >> Signed-off-by: Hrvoje Habjanic <hrvoje.habja...@zg.ht.hr>
> >> ---
> > Hi Hrvoje;
> >
> > I guess this is your first patch to dpdk.org, here are some suggestions
> > when you send bug fixes;
>
> Yes, it is.
>
> >
> > - When sending fixes, please use "fix" word in the subject line, e.g-
> > rte_sched: fix subport memory leak
> > - The commit message should include commit id corresponding to the line
> > that you fixes as shown below for this case.
> > Fixes: d9213b829a31 ("sched: remove pipe params config from port level")
>
> OK, noted, thank you.
>
> > Patch looks good to me.
>
> Great.
>
> As s side note, it would be nice if this could be backported to 19.11 LTS.
Added Cc: sta...@dpdk.org
> > Acked-by: Jasvinder Singh <jasvinder.si...@intel.com>
Applied, thanks
