Re: [dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites

2020-06-12 Thread Jerin Jacob
On Sat, Jun 13, 2020 at 2:56 AM McDaniel, Timothy wrote: > > The DLB hardware does not conform exactly to the eventdev interface. > 1) It has a limit on the number of queues that may be linked to a port. > 2) Some ports a further restricted to a maximum of 1 linked queue. > 3) It does not (current

[dpdk-dev] [PATCH v3 10/10] eal: mark old macros for blacklist/whitelist as deprecated

2020-06-12 Thread Stephen Hemminger
Use of these macros in applications should cause a deprecation warning. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- lib/librte_eal/include/rte_bus.h | 9 +++-- lib/librte_eal/include/rte_dev.h | 10 +++--- lib/librte_eal/include/rte_devargs.h | 10 +++--- 3

[dpdk-dev] [PATCH v3 08/10] app/test: use new allowlist and blocklist

2020-06-12 Thread Stephen Hemminger
Test the renamed pci-blocklist and pci-allowlist arguments. Use new terms in test variable names as well. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- app/test/autotest.py| 16 ++-- app/test/autotest_runner.py | 18 ++--- app/test/test.c | 2

[dpdk-dev] [PATCH v3 09/10] doc: add note about blacklist/whitelist changes

2020-06-12 Thread Stephen Hemminger
The blacklist/whitelist changes to API will not be a breaking change for applications in this release but worth adding a note to encourage migration. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- doc/guides/rel_notes/release_20_08.rst | 5 + 1 file changed, 5 insertions(+) d

[dpdk-dev] [PATCH v3 07/10] doc: replace references to blacklist/whitelist

2020-06-12 Thread Stephen Hemminger
The terms blacklist and whitelist are no longer used. Replace them in the documentation. Most of this was automatic replacement, but in a couple of places the language was awkward before and have tried to improve the readabilty. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- doc/

[dpdk-dev] [PATCH v3 06/10] eal: replace pci-whitelist/pci-blacklist options

2020-06-12 Thread Stephen Hemminger
Replace pci-whitelist with pci-allowlist and pci-blacklist with pci-blocklist. Allow the old options for now, but make sure help and all tests will use the new options. The short flags are more commonly used and changing them would impact more documentation and applications. The -b flag can be de

[dpdk-dev] [PATCH v3 02/10] mk: replace reference to blacklist/whitelist

2020-06-12 Thread Stephen Hemminger
Use BLOCKLIST and ALLOWLIST in the make variable names. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- mk/rte.sdktest.mk | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk index 803018ba3a70..6777e0c0f603 100644

[dpdk-dev] [PATCH v3 04/10] eal: replace usage of blacklist/whitelist in enum

2020-06-12 Thread Stephen Hemminger
This patch renames the enum values in the EAL include files. As a backward compatible temporary migration tool, define a replacement mapping for old values. The old names relating to blacklist and whitelist are replaced by block list and allow list, but applications may be using the older compatib

[dpdk-dev] [PATCH v3 03/10] check_maintainers: change variable names

2020-06-12 Thread Stephen Hemminger
Use blocklist where blacklist was used and allowlist where whitelist was used. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- devtools/check-maintainers.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/devtools/check-maintainers.sh b/devtools/check-ma

[dpdk-dev] [PATCH v3 00/10] rename blacklist/whitelist to block/allow

2020-06-12 Thread Stephen Hemminger
The terms blacklist and whitelist are often seen as reminders of the divisions in society. Instead, use more exact terms for handling of which devices are used in DPDK. This is a proposed change for DPDK 20.08 to replace the names blacklist and whitelist in API and command lines. The first three

[dpdk-dev] [PATCH v3 05/10] drivers: replace references to blacklist

2020-06-12 Thread Stephen Hemminger
Use the new terminology blocked to describe when devices are excluded from being used. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- drivers/bus/dpaa/dpaa_bus.c| 7 +++ drivers/bus/fslmc/fslmc_bus.c | 9 - drivers/bus/fslmc/fslmc_vfio.c | 8 ---

[dpdk-dev] [PATCH v3 01/10] rte_ethdev: change comment to rte_dev_eth_mac_addr_add

2020-06-12 Thread Stephen Hemminger
The comment used the term whitelist and was awkardly written. Replace it with simpler direct description of adding a new address. No code or API changes for this. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- lib/librte_ethdev/rte_ethdev.h | 3 +-- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH] net/cxgbe: always enable HASH filter support

2020-06-12 Thread Rahul Lakkireddy
From: Karra Satwik Disable all unused firmware resources during init time to give more resources for HASH (exact-match) filter region and always request firmware to enable HASH filter support when resources are available. Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy --- drivers

[dpdk-dev] [PATCH 4/5] net/cxgbe: fix SMT leak in filter error and free path

2020-06-12 Thread Rahul Lakkireddy
Free up Source MAC Table (SMT) entry properly during filter create failure and filter delete. Fixes: 993541b2fa4f ("net/cxgbe: support flow API for source MAC rewrite") Cc: sta...@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_filter.c | 28 ++-- dr

[dpdk-dev] [PATCH 0/5] net/cxgbe: fix rte_flow related hardware resource leaks

2020-06-12 Thread Rahul Lakkireddy
This series of patches fix various hardware resource leaks in flow create failure and flow destroy paths. Patch 1 fixes Compressed Local IP (CLIP) entry leaks. Patch 2 fixes Layer 2 Table (L2T) entry leaks. Patch 3 fixes double Multi Port Switch (MPS) entry allocations due to flow validate and c

[dpdk-dev] [PATCH 5/5] net/cxgbe: ignore flow default masks for unrequested fields

2020-06-12 Thread Rahul Lakkireddy
commit 536db938a444 ("net/cxgbe: add devargs to control filtermode and filtermask") allows configuring hardware to select specific combination of header fields to match in the incoming packets. However, the default mask is set for all fields in the requested pattern items, even if the field is not

[dpdk-dev] [PATCH 2/5] net/cxgbe: fix L2T leak in filter error and free path

2020-06-12 Thread Rahul Lakkireddy
Free up Layer 2 Table (L2T) entry properly during filter create failure and filter delete. Fixes: 1decc62b1cbe ("net/cxgbe: add flow operations to offload VLAN actions") Cc: sta...@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_filter.c | 30 --

[dpdk-dev] [PATCH 1/5] net/cxgbe: fix CLIP leak in filter error path

2020-06-12 Thread Rahul Lakkireddy
Free up Compressed Local IP (CLIP) entry properly during filter creation failure path. Also consolidate all various tables cleanup to a common function and invoke it from both wild-card and exact-match filter paths. Fixes: af44a577988b ("net/cxgbe: support to offload flows to HASH region") Cc: sta

[dpdk-dev] [PATCH 3/5] net/cxgbe: fix double MPS alloc due to flow validate and create

2020-06-12 Thread Rahul Lakkireddy
The Multi Port Switch (MPS) entry is allocated twice when both flow validate and create are invoked, but only freed once during flow destroy. Avoid double alloc by moving MPS entry allocation closer to when the filter create request is sent to hardware and will be ignored for filter validate reques

Re: [dpdk-dev] [PATCH v8 11/11] eal/windows: implement basic memory management

2020-06-12 Thread Thomas Monjalon
2 typos below found with checkpatch. 10/06/2020 16:27, Dmitry Kozlyuk: > + /* May occcur when committing regular memory. */ Typo: occcur > + /* No need to join reserved regions adjascent to the freed one: Typo: adjascent

Re: [dpdk-dev] [PATCH v8 09/11] eal/windows: improve CPU and NUMA node detection

2020-06-12 Thread Thomas Monjalon
10/06/2020 16:27, Dmitry Kozlyuk: > 1. Map CPU cores to their respective NUMA nodes as reported by system. > 2. Support systems with more than 64 cores (multiple processor groups). > 3. Fix magic constants, styling issues, and compiler warnings. > 4. Add EAL private function to map DPDK socket ID t

Re: [dpdk-dev] [PATCH v8 00/11] Windows basic memory management

2020-06-12 Thread Thomas Monjalon
11/06/2020 19:29, Thomas Monjalon: > 10/06/2020 16:27, Dmitry Kozlyuk: > > This patchset implements basic MM with the following features: > > There are some compilation issues on FreeBSD and 32-bit Linux: > http://mails.dpdk.org/archives/test-report/2020-June/135764.html I did more comments about

Re: [dpdk-dev] [PATCH v8 10/11] eal/windows: initialize hugepage info

2020-06-12 Thread Thomas Monjalon
10/06/2020 16:27, Dmitry Kozlyuk: > --- a/MAINTAINERS > +++ b/MAINTAINERS > +Windows memory allocation > +M: Dmitry Kozlyuk > +F: lib/librte_eal/eal_hugepages.c Is it a typo? You mean lib/librte_eal/windows/eal_hugepages.c ? [...] > --- a/doc/guides/windows_gsg/build_dpdk.rst > +++ b/doc/guides/

Re: [dpdk-dev] [PATCH v8 09/11] eal/windows: improve CPU and NUMA node detection

2020-06-12 Thread Thomas Monjalon
10/06/2020 16:27, Dmitry Kozlyuk: > 1. Map CPU cores to their respective NUMA nodes as reported by system. > 2. Support systems with more than 64 cores (multiple processor groups). > 3. Fix magic constants, styling issues, and compiler warnings. > 4. Add EAL private function to map DPDK socket ID t

Re: [dpdk-dev] [PATCH v8 03/11] eal: introduce memory management wrappers

2020-06-12 Thread Thomas Monjalon
12/06/2020 22:24, Dmitry Kozliuk: > > > > > +#include > > > > > > > > I think we should find a better file name for these wrappers. > > > > "EAL memory" means DPDK memory allocator in my mind. > > > > We need a file name which is about OS-independent wrappers, > > > > or libc wrappers. > > > > Wha

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-12 Thread Thomas Monjalon
12/06/2020 18:22, Tasnim Bashar: > From: Thomas Monjalon > > 02/06/2020 04:00, Tasnim Bashar: > > > --- a/lib/librte_eal/windows/include/rte_windows.h > > > +++ b/lib/librte_eal/windows/include/rte_windows.h > > > @@ -29,6 +29,7 @@ > > > #define INITGUID > > > #endif > > > #include > > > +#inc

[dpdk-dev] [PATCH 26/27] event/dlb: add dequeue, dequeue_burst, and variants

2020-06-12 Thread McDaniel, Timothy
Change-Id: I0c90ad10be82750dc4c7c4bcbeed9b12677a996d Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 879 1 file changed, 879 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 282d60f73..afdb18061 10

[dpdk-dev] [PATCH 27/27] event/dlb: add eventdev_stop and eventdev_close

2020-06-12 Thread McDaniel, Timothy
Change-Id: Iff64ba83ead496b3dedeaf323ee09bce1f631a6f Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 263 1 file changed, 263 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index afdb18061..d47325132 10

[dpdk-dev] [PATCH 23/27] event/dlb: add eventdev_start

2020-06-12 Thread McDaniel, Timothy
Change-Id: I9dcf8cf95c1001e09ab3e44e3fbd2ccbf0ddec72 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 142 1 file changed, 142 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 2d7f4479a..70bd2b4d6 10

[dpdk-dev] [PATCH 24/27] event/dlb: add timout_ticks, dump, xstats, and selftest

2020-06-12 Thread McDaniel, Timothy
Change-Id: I07517f651b7cf2326b6d3c62f0089595c9eb06a7 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 70bd2b4d6..eef7c4f43 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH 25/27] event/dlb: add enqueue and its burst variants

2020-06-12 Thread McDaniel, Timothy
Change-Id: I58cb02dc040aa6dcf30992ea57ff3f332b4946f2 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index eef7c4f43..282d60f73 100644 --- a/drivers/event/dlb/d

[dpdk-dev] [PATCH 20/27] event/dlb: add port_link

2020-06-12 Thread McDaniel, Timothy
Change-Id: Id86dbdd1070e8102bf602765654fe5afde0e0d6c Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 303 1 file changed, 303 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index deea474bf..7acf8b33d 10

[dpdk-dev] [PATCH 17/27] event/dlb: add queue_def_conf and port_def_conf

2020-06-12 Thread McDaniel, Timothy
Change-Id: Ifa154a041fa117776612efc027b128c1603b6396 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index c21ebe7e2..adaeafedc 100644 --- a/drivers/

[dpdk-dev] [PATCH 16/27] event/dlb: add infos_get and configure

2020-06-12 Thread McDaniel, Timothy
Change-Id: I749ae914852bc3516601301c2b1fb338ba7508f7 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 401 1 file changed, 401 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 124b86a1d..c21ebe7e2 10

[dpdk-dev] [PATCH 22/27] event/dlb: add port_unlink and port_unlinks_in_progress

2020-06-12 Thread McDaniel, Timothy
Change-Id: I06d4006786440a0454ce883dba0ce14640dfff92 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 166 1 file changed, 166 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index b1103ea95..2d7f4479a 10

[dpdk-dev] [PATCH 18/27] event/dlb: add queue setup

2020-06-12 Thread McDaniel, Timothy
Change-Id: I88389542d5dbb64b255ce06605ace9d3315f7b22 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 295 1 file changed, 295 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index adaeafedc..2e847 10

[dpdk-dev] [PATCH 21/27] event/dlb: add queue_release and port_release

2020-06-12 Thread McDaniel, Timothy
Change-Id: I7dc1b4c03a222b40d629705946d00f3800dbe63d Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 7acf8b33d..b1103ea95 100644 --- a/drivers/event/

[dpdk-dev] [PATCH 14/27] event/dlb: add PMD self-tests

2020-06-12 Thread McDaniel, Timothy
Change-Id: I1d0bc52b02ad21966c64736bc78e403f381e98ec Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_selftest.c | 1628 ++ 1 file changed, 1628 insertions(+) create mode 100644 drivers/event/dlb/dlb_selftest.c diff --git a/drivers/event/dlb/dlb_sel

[dpdk-dev] [PATCH 19/27] event/dlb: add port_setup

2020-06-12 Thread McDaniel, Timothy
Change-Id: Ibfa0ca4c9e19c0443e199e34eb989a5e959c2a0b Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 1241 +++ 1 file changed, 1241 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 2e847..deea474bf 1

[dpdk-dev] [PATCH 15/27] event/dlb: add probe

2020-06-12 Thread McDaniel, Timothy
Change-Id: I4b8d0ca2bd5eb01d4ea8c4c6c9487b4f7116d68e Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 519 1 file changed, 519 insertions(+) create mode 100644 drivers/event/dlb/dlb.c diff --git a/drivers/event/dlb/dlb.c b/drivers/e

[dpdk-dev] [PATCH 12/27] event/dlb: add the PMD's public interfaces

2020-06-12 Thread McDaniel, Timothy
Change-Id: I0237d00b8d27d84962be467c48de7c4d5137cc4c Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/rte_pmd_dlb.c | 39 ++ drivers/event/dlb/rte_pmd_dlb.h | 69 + drivers/event/dlb/rte_pmd_dlb_event_version.map | 6 +++

[dpdk-dev] [PATCH 10/27] event/dlb: add PFPMD-specific interface layer to shared code

2020-06-12 Thread McDaniel, Timothy
Change-Id: I8064d21dfa56df9a797e22f116fc7a3b15b1494c Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/pf/dlb_main.c | 670 drivers/event/dlb/pf/dlb_main.h | 90 + drivers/event/dlb/pf/dlb_pf.c | 839 3 files ch

[dpdk-dev] [PATCH 11/27] event/dlb: add flexible PMD to device interfaces

2020-06-12 Thread McDaniel, Timothy
The PMD uses function pointers so that it can be executed as a bifurcated PMD accessing hardware via a linux kernel mode driver, or as a PF PMD where it has complete control of the hardware device. Note that this interface is not used in the data path. Change-Id: I42a3f9d7370e9a7d89855ea1327cb31d

[dpdk-dev] [PATCH 13/27] event/dlb: add xstats support

2020-06-12 Thread McDaniel, Timothy
Change-Id: Ia7a000e12fcd035f66280fbbd4f17b4ccc95cc2c Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_xstats.c | 1251 1 file changed, 1251 insertions(+) create mode 100644 drivers/event/dlb/dlb_xstats.c diff --git a/drivers/event/dlb/dlb_xstat

[dpdk-dev] [PATCH 09/27] event/dlb: inline functions used in multiple files

2020-06-12 Thread McDaniel, Timothy
Change-Id: I61196d9c19cd2add26b6600fb42588ef523febac Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_inline_fns.h | 80 ++ 1 file changed, 80 insertions(+) create mode 100644 drivers/event/dlb/dlb_inline_fns.h diff --git a/drivers/event/dlb/dlb_inl

[dpdk-dev] [PATCH 08/27] event/dlb: add definitions shared with LKM or shared code

2020-06-12 Thread McDaniel, Timothy
Change-Id: Ie39013936676771d096c2166b2a4745cdeb772b0 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_user.h | 1351 ++ 1 file changed, 1351 insertions(+) create mode 100644 drivers/event/dlb/dlb_user.h diff --git a/drivers/event/dlb/dlb_user.h

[dpdk-dev] [PATCH 07/27] event/dlb: add private data structures and constants

2020-06-12 Thread McDaniel, Timothy
Change-Id: I6be9078848e25c19ce3b357491f7f616e1cf675d Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_priv.h | 595 +++ 1 file changed, 595 insertions(+) create mode 100644 drivers/event/dlb/dlb_priv.h diff --git a/drivers/event/dlb/dlb_priv.h b

[dpdk-dev] [PATCH 06/27] event/dlb: add dynamic logging

2020-06-12 Thread McDaniel, Timothy
Change-Id: I7698d9b8eea2e681ea6ff237d1f93b0ece7f4704 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_log.h | 24 1 file changed, 24 insertions(+) create mode 100644 drivers/event/dlb/dlb_log.h diff --git a/drivers/event/dlb/dlb_log.h b/drivers/event/dlb/dlb_l

[dpdk-dev] [PATCH 05/27] event/dlb: add DLB documentation

2020-06-12 Thread McDaniel, Timothy
Change-Id: I269bfe9fb4ac53a9f81d33718f3a808fd8216c74 Signed-off-by: McDaniel, Timothy --- doc/guides/eventdevs/dlb.rst | 497 +++ 1 file changed, 497 insertions(+) create mode 100644 doc/guides/eventdevs/dlb.rst diff --git a/doc/guides/eventdevs/dlb.rst b

[dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites

2020-06-12 Thread McDaniel, Timothy
The DLB hardware does not conform exactly to the eventdev interface. 1) It has a limit on the number of queues that may be linked to a port. 2) Some ports a further restricted to a maximum of 1 linked queue. 3) It does not (currently) have the ability to carry the flow_id as part of the event (QE)

[dpdk-dev] [PATCH 02/27] eventdev: do not pass disable_implicit_release bit to trace macro

2020-06-12 Thread McDaniel, Timothy
The disable implicit_release indicator is now a bitfield, so it must be converted to uint8_t when calling the tracepoint macro. Change-Id: Iab83bbc295de2431a936ce2a73ed6801366d392f Signed-off-by: McDaniel, Timothy --- lib/librte_eventdev/rte_event_crypto_adapter.c | 7 ++- lib/librt

[dpdk-dev] [PATCH 04/27] event/dlb: add make and meson build infrastructure

2020-06-12 Thread McDaniel, Timothy
Change-Id: I7fc0656b531dded6a95fbb0777c3b0dd5209ba61 Signed-off-by: McDaniel, Timothy --- config/common_base| 17 + config/rte_config.h | 6 ++ drivers/event/Makefile| 5 + drivers/event/dlb/Makefile| 36 +

[dpdk-dev] [PATCH 00/27] V1 event/dlb add Intel DLB PMD

2020-06-12 Thread McDaniel, Timothy
Hello Jerin and the DPDK community. The following patchset adds support for a new eventdev PMD. The DLB PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. The DLB is a PCIe device that provides load-balanced, prioritized scheduling of core-to-core communication. T

Re: [dpdk-dev] [PATCH v8 03/11] eal: introduce memory management wrappers

2020-06-12 Thread Dmitry Kozliuk
> > > Not sure if they are in DPDK scope, apart from rte_mem_lock, which > > generalizes rte_mem_lock_page already in rte_memory.h. What may be > typical > > use cases for data-plane apps? I can see testpmd using mmap for > allocating > > external memory (because of possible use of hugepages), doe

Re: [dpdk-dev] [PATCH] net/mlx5: do not select legacy MPW implicitly

2020-06-12 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Thursday, June 11, 2020 20:42 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: do not select legacy MPW implicitly > > The Legacy MPW (multi-packet write) should not be engag

[dpdk-dev] [PATCH] examples: add multi process crypto application

2020-06-12 Thread Arek Kusztal
This patch adds example application that can test usage of cryptodev in multi process environement. More can be found in mp_crypto.rst in sample app guides. Signed-off-by: Arek Kusztal --- doc/guides/sample_app_ug/index.rst | 1 + doc/guides/sample_app_ug/mp_crypto.rst | 151 + example

[dpdk-dev] [PATCH] examples: add multi process crypto application

2020-06-12 Thread Arek Kusztal
Due to increasing interest in multi process support for crypto PMDs new sample app can be added so in overview we can say that: The Multi-process Crypto application is a simple application that allows to run crypto related operations in a multiple process environment. It builds on the EAL primary/

[dpdk-dev] [PATCH 50/50] net/bnxt: Add support for flow query with action_type COUNT

2020-06-12 Thread Somnath Kotur
Use the flow counter manager to fetch the accumulated stats for a flow. Reviewed-by: Venkat Duvvuru Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c | 46 ++- drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c| 141 ++

[dpdk-dev] [PATCH 49/50] net/bnxt: support for ULP Flow counter Manager

2020-06-12 Thread Somnath Kotur
The Flow counter manager allocates memory to hold the software view of the counters where the on-chip counter data will be accumulated along with another memory block that will be shadowing the on-chip counter data i.e where the raw counter data will be DMAed into from the chip. It also keeps track

[dpdk-dev] [PATCH 48/50] net/bnxt: fill cfa_action in the tx buffer descriptor properly

2020-06-12 Thread Somnath Kotur
From: Venkat Duvvuru Currently, only vfrep transmit requires cfa_action to be filled in the tx buffer descriptor. However with truflow, dpdk(non vfrep) to port also requires cfa_action to be filled in the tx buffer descriptor. This patch uses the correct cfa_action pointer while transmitting the

[dpdk-dev] [PATCH 47/50] net/bnxt: add ingress & egress port default rules

2020-06-12 Thread Somnath Kotur
From: Venkat Duvvuru ingress & egress port default rules are needed to send the packet from port_to_dpdk & dpdk_to_port respectively. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 76

[dpdk-dev] [PATCH 46/50] net/bnxt: create default flow rules for the VF-rep conduit

2020-06-12 Thread Somnath Kotur
Invoked 3 new APIs for the default flow create/destroy and to get the action ptr for a default flow. Changed ulp_intf_update() to accept rte_eth_dev as input and invoke the same from the VF rep start function. ULP Mark Manager will indicate if the cfa_code returned in the Rx completion descriptor w

[dpdk-dev] [PATCH 44/50] net/bnxt: fill mapper parameters with default rules info

2020-06-12 Thread Somnath Kotur
From: Venkat Duvvuru Default rules are needed for the packets to be punted between the following entities in the non-offloaded path 1. Device PORT to DPDK App 2. DPDK App to Device PORT 3. VF Representor to VF 4. VF to VF Representor This patch fills all the relevant information in the computed

[dpdk-dev] [PATCH 42/50] net/bnxt: fix for VF to VFR conduit

2020-06-12 Thread Somnath Kotur
From: Venkat Duvvuru When VF-VFR conduits are created, a mark is added to the mark database. mark_flag indicates whether the mark is valid and has VFR information (VFR_ID bit in mark_flag). Rx path was checking for this VFR_ID bit. However, while adding the mark to the mark database, VFR_ID bit i

[dpdk-dev] [PATCH 43/50] net/bnxt: fix to parse representor along with other dev-args

2020-06-12 Thread Somnath Kotur
Representor dev-args need to be parsed during pci probe as they determine subsequent probe of VF representor ports as well. Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) di

[dpdk-dev] [PATCH 40/50] net/bnxt: enable HWRM_PORT_MAC_QCFG for trusted vf

2020-06-12 Thread Somnath Kotur
From: Venkat Duvvuru Issue HWRM_PORT_MAC_QCFG command on trusted vf to fetch the port count. Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/bnxt_hwrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/

[dpdk-dev] [PATCH 39/50] net/bnxt: add support for conditional execution of mapper tables

2020-06-12 Thread Somnath Kotur
From: Kishore Padmanabha Added support for conditional execution of the mapper tables so that actions like count will have table processed only if action count is configured. Signed-off-by: Kishore Padmanabha Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvur

[dpdk-dev] [PATCH 41/50] net/bnxt: enhancements for port db

2020-06-12 Thread Somnath Kotur
From: Venkat Duvvuru 1. Add "enum bnxt_ulp_intf_type” as the second parameter for the port & func helper functions 2. Return vfrep related port & func information in the helper functions 3. Allocate phy_port_list dynamically based on port count 4. Introduce ulp_func_id_tbl array for book keepi

[dpdk-dev] [PATCH 38/50] net/bnxt: add support for internal exact match entries

2020-06-12 Thread Somnath Kotur
From: Kishore Padmanabha Added support for the internal exact match entries. Signed-off-by: Kishore Padmanabha Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 38 + drivers/ne

[dpdk-dev] [PATCH 34/50] net/bnxt: add support for if table processing

2020-06-12 Thread Somnath Kotur
From: Kishore Padmanabha Added support for if table processing in the ulp mapper layer. This enables support for the default partition action record pointer interface table. Signed-off-by: Kishore Padmanabha Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru

[dpdk-dev] [PATCH 35/50] net/bnxt: disable vector mode in tx direction when truflow is enabled

2020-06-12 Thread Somnath Kotur
From: Kishore Padmanabha The vector mode in the tx handler is disabled when truflow is enabled since truflow now requires bd action record support. Signed-off-by: Kishore Padmanabha Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/bn

[dpdk-dev] [PATCH 36/50] net/bnxt: add index opcode and index operand mapper table

2020-06-12 Thread Somnath Kotur
From: Kishore Padmanabha Extended the regfile and computed field operations to a common index opcode operation and added globlal resource operations are also part of the index opcode operation. Signed-off-by: Kishore Padmanabha Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur Signed-of

[dpdk-dev] [PATCH 37/50] net/bnxt: add support for global resource templates

2020-06-12 Thread Somnath Kotur
From: Kishore Padmanabha Added support for the global resource templates, so that they can be reused by the other regular templates. Signed-off-by: Kishore Padmanabha Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/tf_ulp/ulp_mapper

[dpdk-dev] [PATCH 33/50] net/bnxt: add support for internal encap records

2020-06-12 Thread Somnath Kotur
From: Mike Baucom Modifications to allow internal encap records to be supported: - Modified the mapper index table processing to handle encap without an action record - Modified the session open code to reserve some 64 Byte internal encap records on tx - Modified the blob encap swap to suppor

[dpdk-dev] [PATCH 32/50] net/bnxt: integrate with the latest tf_core library

2020-06-12 Thread Somnath Kotur
From: Kishore Padmanabha ULP changes to integrate with the latest session open interface in tf_core Signed-off-by: Kishore Padmanabha Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 46 +++

[dpdk-dev] [PATCH 31/50] net/bnxt: add support for EEM System memory

2020-06-12 Thread Somnath Kotur
From: Peter Spreadborough - Select EEM Host or System memory via config parameter - Add EEM system memory support for kernel memory - Dependent on DPDK changes that add support for the HWRM_OEM_CMD. Signed-off-by: Peter Spreadborough Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru -

[dpdk-dev] [PATCH 30/50] net/bnxt: add global config set and get APIs

2020-06-12 Thread Somnath Kotur
From: Jay Ding - Add support to update global configuration for ACT_TECT and ACT_ABCR. - Add support to allow Tunnel and Action global configuration. - Remove register read and write operations. - Remove the register read and write support. Signed-off-by: Jay Ding Reviewed-by: Randy Schacher

[dpdk-dev] [PATCH 29/50] net/bnxt: add TF register and unregister

2020-06-12 Thread Somnath Kotur
From: Michael Wildt - Add TF register/unregister support. Session got session clients to keep track of the ctrl-channels/function. - Add support code to tfp layer Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Venkat Duvvuru --- dr

[dpdk-dev] [PATCH 28/50] net/bnxt: implement IF tables set and get

2020-06-12 Thread Somnath Kotur
From: Jay Ding - Implement set/get for PROF_SPIF_CTXT, LKUP_PF_DFLT_ARP, PROF_PF_ERR_ARP with tunneled HWRM messages - Add IF table for PROF_PARIF_DFLT_ARP - Fix page size offset in the HCAPI code - Fix Entry offset calculation Signed-off-by: Jay Ding Reviewed-by: Randy Schacher Reviewed-by:

[dpdk-dev] [PATCH 25/50] net/bnxt: remove table scope from session

2020-06-12 Thread Somnath Kotur
From: Pete Spreadborough - Remove table scope data from session. Added to EEM. - Complete move to RM of table scope base and range. - Fix some err messaging strings. - Fix the tcam logging message. Signed-off-by: Pete Spreadborough Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru ---

[dpdk-dev] [PATCH 27/50] net/bnxt: align CFA resources with RM

2020-06-12 Thread Somnath Kotur
From: Randy Schacher - HCAPI resources need to align for Resource Manager - Clean up unnecessary debug messages Signed-off-by: Randy Schacher Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/tf_core/cfa_resource_types.h | 250 ++

[dpdk-dev] [PATCH 24/50] net/bnxt: update RM to support HCAPI only

2020-06-12 Thread Somnath Kotur
From: Pete Spreadborough - For the EM Module there is a need to only allocate the EM Records in HCAPI RM but the storage control is requested to be outside of the RM DB. - Add TF_RM_ELEM_CFG_HCAPI_BA. - Return error when the number of reserved entries for wc tcam is odd number in tf_tcam_bind

[dpdk-dev] [PATCH 26/50] net/bnxt: add external action alloc and free

2020-06-12 Thread Somnath Kotur
From: Jay Ding - Link external action alloc and free to new hcapi interface - Add parameter range checking - Fix issues with index allocation check Signed-off-by: Jay Ding Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/tf_core/tf_core.c | 163 +++

[dpdk-dev] [PATCH 21/50] net/bnxt: support two level priority for TCAMs

2020-06-12 Thread Somnath Kotur
From: Jay Ding Allow TCAM indexes to be allocated from top or bottom. If the priority is set to 0, allocate from the lowest tcam indexes i.e. from top. Any other value, allocate it from the highest tcam indexes i.e. from bottom. Signed-off-by: Jay Ding Reviewed-by: Randy Schacher Signed-off-by

[dpdk-dev] [PATCH 20/50] net/bnxt: update RM with residual checker

2020-06-12 Thread Somnath Kotur
From: Michael Wildt - Add residual checker to the TF Host RM as well as new RM APIs. On close it will scan the DB and check of any remaining elements. If found they will be logged and FW msg sent for FW to scrub that specific type of resources. - Update the module bind to be aware of the mo

[dpdk-dev] [PATCH 19/50] net/bnxt: update identifier with remap support

2020-06-12 Thread Somnath Kotur
From: Michael Wildt - Add Identifier L2 CTXT Remap to the P4 device and updated the cfa_resource_types.h to get the type support. Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/tf_core/cfa_resour

[dpdk-dev] [PATCH 18/50] net/bnxt: multiple device implementation

2020-06-12 Thread Somnath Kotur
From: Michael Wildt Implement the Identifier, Table Type and the Resource Manager modules. Integrate Resource Manager with HCAPI. Update open/close session. Move to direct msgs for qcaps and resv messages. Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru

[dpdk-dev] [PATCH 17/50] net/bnxt: implement support for TCAM access

2020-06-12 Thread Somnath Kotur
From: Jay Ding Implement TCAM alloc, free, bind, and unbind functions Update tf_core, tf_msg, etc. Signed-off-by: Jay Ding Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/tf_core/tf_core.c | 258 +--

[dpdk-dev] [PATCH 14/50] net/bnxt: support two-level priority for TCAMs

2020-06-12 Thread Somnath Kotur
From: Shahaji Bhosle Allow TCAM indexes to be allocated from top or bottom. If the priority is set to 0, allocate from the lowest tcam indexes i.e. from top. Any other value, allocate it from the highest tcam indexes i.e. from bottom. Signed-off-by: Shahaji Bhosle Reviewed-by: Randy Schacher R

[dpdk-dev] [PATCH 15/50] net/bnxt: add HCAPI interface support

2020-06-12 Thread Somnath Kotur
From: Pete Spreadborough Add new hardware shim APIs to support multiple device generations Signed-off-by: Pete Spreadborough Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/hcapi/Makefile | 7 + drivers/net/bnxt/hca

[dpdk-dev] [PATCH 13/50] net/bnxt: update multi device design support

2020-06-12 Thread Somnath Kotur
From: Michael Wildt - Implement the modules RM, Device (WH+), Identifier. - Update Session module. - Implement new HWRMs for RM direct messaging. - Add new parameter check macro's and clean up the header includes for i.e. tfp such that bnxt.h is not directly included in the new modules. - Add c

[dpdk-dev] [PATCH 12/50] net/bnxt: support bulk table get and mirror

2020-06-12 Thread Somnath Kotur
From: Shahaji Bhosle - Add new bulk table type get using FW to DMA the data back to host. - Add flag to allow records to be cleared if possible - Set mirror using tf_alloc_tbl_entry Signed-off-by: Shahaji Bhosle Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Venkat Duvvuru --- drivers/net

[dpdk-dev] [PATCH 11/50] net/bnxt: add multi device support

2020-06-12 Thread Somnath Kotur
From: Michael Wildt Introduce new modules for Device, Resource Manager, Identifier, Table Types, and TCAM. Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/meson.build | 8 + drivers/net/bnxt/tf_core/Makefile

[dpdk-dev] [PATCH 10/50] net/bnxt: modify EM insert and delete to use HWRM direct

2020-06-12 Thread Somnath Kotur
From: Pete Spreadborough Modify Exact Match insert and delete to use the HWRM messages directly. Remove tunneled EM insert and delete message types. Signed-off-by: Pete Spreadborough Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/tf_core/hwrm_tf.h | 70 +++

[dpdk-dev] [PATCH 08/50] net/bnxt: modify port_db to store & retrieve more info

2020-06-12 Thread Somnath Kotur
From: Venkat Duvvuru Apart from func_svif, func_id & vnic, port_db now stores and retrieves func_spif, func_parif, phy_port_id, port_svif, port_spif, port_parif, port_vport. New helper functions have been added to support the same. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Revie

[dpdk-dev] [PATCH 07/50] net/bnxt: add support for bnxt_hwrm_port_phy_qcaps

2020-06-12 Thread Somnath Kotur
From: Venkat Duvvuru Issue HWRM_PORT_PHY_QCAPS to the firmware to get the physical port count of the device. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Kishore Padmanabha Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt.h

[dpdk-dev] [PATCH 06/50] net/bnxt: get port & function related information

2020-06-12 Thread Somnath Kotur
From: Venkat Duvvuru add helper functions to get port & function related information like parif, physical port id & vport id. Signed-off-by: Venkat Duvvuru Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Somnath Kotur Reviewed-by: Kishore Padmanabha Signed-off-by: Somnath Kotur --- driver

[dpdk-dev] [PATCH 05/50] net/bnxt: modify ulp_port_db_dev_port_intf_update prototype

2020-06-12 Thread Somnath Kotur
From: Venkat Duvvuru Modify ulp_port_db_dev_port_intf_update prototype to take "struct rte_eth_dev *" as the second parameter. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Kishore Padmanabha Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c| 4

[dpdk-dev] [PATCH 04/50] net/bnxt: initialize parent PF information

2020-06-12 Thread Somnath Kotur
From: Lance Richardson Add support to query parent PF information (MAC address, function ID, port ID and default VNIC) from firmware. Current firmware returns zero for parent default vnic, a temporary Wh+-specific workaround is included until that can be fixed. Signed-off-by: Lance Richardson

[dpdk-dev] [PATCH 03/50] net/bnxt: add support to get FID, default vnic ID and svif of VF-Rep Endpoint

2020-06-12 Thread Somnath Kotur
Use 'first_vf_id' and the 'vf_id' that is input as part of adding a representor to obtain the PCI function ID(FID) of the VF(VFR endpoint). Use the FID as an input to FUNC_QCFG HWRM cmd to obtain the default vnic ID of the VF. Along with getting the default vNIC ID by supplying the FW FID of the VF

  1   2   >