Re: [dpdk-dev] [PATCH 3/3] lib: remind experimental status in library headers

2020-05-27 Thread David Marchand
Hello Gage, On Tue, May 26, 2020 at 3:29 PM Eads, Gage wrote: > > The following libraries are experimental, all of their functions can change > > or > > disappear: > > > > - librte_bbdev > > - librte_bpf > > - librte_compressdev > > - librte_fib > > - librte_flow_classify > > - librte_ipsec > >

Re: [dpdk-dev] [PATCH 3/3] lib: remind experimental status in library headers

2020-05-27 Thread David Marchand
Hello Honnappa, On Fri, May 22, 2020 at 4:16 PM Honnappa Nagarahalli wrote: > > @@ -11,7 +11,8 @@ > > * Wireless base band device abstraction APIs. > > * > > * @warning > > - * @b EXPERIMENTAL: this API may change without prior notice > > + * @b EXPERIMENTAL: > > + * All functions in this f

[dpdk-dev] [PATCH v1] net/ice: fix PCI DSN to be lowercase values

2020-05-27 Thread Haiyue Wang
The PCI DSN (device serial number) to format package file name should be lowercase values. Fixes: d1c91179e952 ("net/ice: check DSN package file firstly") Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_dcf_parent.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driv

Re: [dpdk-dev] [PATCH] stack: remove experimental tag from API

2020-05-27 Thread Ray Kinsella
Hi Gage, Do you have any idea. If the change from experimental to stable symbol is likely to break anyone's application? (are folks actively using the api with shared libraries) If so, you _may_ consider offering a temporary alias to experimental until the v21 is declared at 20.11. This is enti

Re: [dpdk-dev] [PATCH] net/bnxt: fix missed unlock reported by coverity

2020-05-27 Thread Ajit Khaparde
On Wed, May 27, 2020 at 5:13 AM Somnath Kotur wrote: > On Wed, May 27, 2020 at 5:42 PM wangyunjian > wrote: > > > > From: Yunjian Wang > > > > Coverity issue: 357741 > > Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Yunjian Wan

Re: [dpdk-dev] [PATCH v3] net/ixgbe: include QPRDC in imissed stat

2020-05-27 Thread Zhao1, Wei
HI,Cody Harris > -Original Message- > From: dev On Behalf Of Cody Harris > Sent: Tuesday, May 19, 2020 1:08 PM > To: dev@dpdk.org > Cc: Cody Harris > Subject: [dpdk-dev] [PATCH v3] net/ixgbe: include QPRDC in imissed stat > > The ixgbe imissed statstic originally only contained dropped

Re: [dpdk-dev] net/iavf: fix flow uninit issue

2020-05-27 Thread Ye Xiaolong
On 05/27, Jeff Guo wrote: >When closing VF device, the process of shutdown adminq should be after of >the process of uninit the flow, since the VF might be still use the adminq >to uninit flow. > >Fixes: 9e03acd726cf ("net/iavf: fix flow access") >Fixes: ff2d0c345c3b ("net/iavf: support generic flo

Re: [dpdk-dev] [PATCH 0/5] misc updates for hns3 PMD driver

2020-05-27 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/5/27 23:36, Ferruh Yigit wrote: On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote: This series are improvement and bugfixes for hns3 PMD driver. Chengchang Tang (2): net/hns3: replace PF vport id zero with private macro net/hns3: fix promiscuous config not clear for

[dpdk-dev] [PATCH v14 2/2] eal: support for VFIO-PCI VF token

2020-05-27 Thread Haiyue Wang
The kernel module vfio-pci introduces the VF token to enable SR-IOV support since 5.7. The VF token can be set by a vfio-pci based PF driver and must be known by the vfio-pci based VF driver in order to gain access to the device. Signed-off-by: Haiyue Wang Acked-by: Anatoly Burakov Acked-by: An

[dpdk-dev] [PATCH v14 0/2] support for VFIO-PCI VF token interface

2020-05-27 Thread Haiyue Wang
v14: Rebase the patch for 20.08 release note. v13: Rename the EAL get VF token function, and leave the freebsd type as empty. v12: support to vfio devices with VF token and no token. v11: Use the eal parameter to pass the VF token, then not every PCI device needs to be specified with this t

[dpdk-dev] [PATCH v14 1/2] eal: add uuid dependent header files explicitly

2020-05-27 Thread Haiyue Wang
Add the dependent header files explicitly, so that the user just needs to include the 'rte_uuid.h' header file directly to avoid compile error: (1). rte_uuid.h:97:55: error: unknown type name ‘size_t’ (2). rte_uuid.h:58:2: error: implicit declaration of function ‘memcpy’ Fixes: 6bc67c497a51 ("ea

[dpdk-dev] [PATCH] stack: remove experimental tag from API

2020-05-27 Thread Gage Eads
The stack library was first released in 19.05, and its interfaces have been stable since their initial introduction. This commit promotes the full interface to stable, starting with the 20.08 ABI. Signed-off-by: Gage Eads --- lib/librte_stack/rte_stack.h | 29 --

Re: [dpdk-dev] [PATCH] net/bnxt: allow the mark to use a cfa code of zero

2020-05-27 Thread Ajit Khaparde
On Wed, May 27, 2020 at 8:47 AM Ferruh Yigit wrote: > On 5/23/2020 12:55 AM, Mike Baucom wrote: > > The mark code was too restrictive by disallowing a cfa_code of zero. > > This code loosens the requirement and allows zero. > > I can see "if (cfa_code)" check removed, but can you please give some

Re: [dpdk-dev] ABI versioning in Windows

2020-05-27 Thread Neil Horman
On Wed, May 27, 2020 at 11:43:49PM +0200, Thomas Monjalon wrote: > 27/05/2020 23:27, Thomas Monjalon: > > 27/05/2020 22:35, Neil Horman: > > > On Wed, May 27, 2020 at 02:50:07PM +0200, Thomas Monjalon wrote: > > > > +Cc more people > > > > > > > > 27/05/2020 12:41, Fady Bader: > > > > > What shoul

Re: [dpdk-dev] ABI versioning in Windows

2020-05-27 Thread Neil Horman
On Wed, May 27, 2020 at 11:27:12PM +0200, Thomas Monjalon wrote: > 27/05/2020 22:35, Neil Horman: > > On Wed, May 27, 2020 at 02:50:07PM +0200, Thomas Monjalon wrote: > > > +Cc more people > > > > > > 27/05/2020 12:41, Fady Bader: > > > > What should we do with the ABI versioning in Windows ? > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] test-pmd: fix memory leaks when mtr policer actions update fails

2020-05-27 Thread Ferruh Yigit
On 5/25/2020 2:46 AM, wangyunjian wrote: > From: Yunjian Wang > > This patch fixes the Huawei internal coverity reported > resource leak issue. > > Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands") > Cc: sta...@dpdk.org > > Signed-off-by: Yunjian Wang Reviewed-by: Ferr

Re: [dpdk-dev] [PATCH] net/failsafe: report valid RSS RETA size

2020-05-27 Thread Stephen Hemminger
On Wed, 27 May 2020 23:35:25 +0200 Gaëtan Rivet wrote: > On 27/05/20 18:30 +0300, Andrew Rybchenko wrote: > > On 5/27/20 6:07 PM, Gaëtan Rivet wrote: > > > On 27/05/20 15:34 +0100, Andrew Rybchenko wrote: > > >> From: Ian Dolzhansky > > >> > > >> Failsafe driver has been indicating zero for

Re: [dpdk-dev] ABI versioning in Windows

2020-05-27 Thread Thomas Monjalon
27/05/2020 23:27, Thomas Monjalon: > 27/05/2020 22:35, Neil Horman: > > On Wed, May 27, 2020 at 02:50:07PM +0200, Thomas Monjalon wrote: > > > +Cc more people > > > > > > 27/05/2020 12:41, Fady Bader: > > > > What should we do with the ABI versioning in Windows ? > > > > > > I think there are 2 q

Re: [dpdk-dev] [PATCH] net/failsafe: report valid RSS RETA size

2020-05-27 Thread Gaëtan Rivet
On 27/05/20 18:30 +0300, Andrew Rybchenko wrote: > On 5/27/20 6:07 PM, Gaëtan Rivet wrote: > > On 27/05/20 15:34 +0100, Andrew Rybchenko wrote: > >> From: Ian Dolzhansky > >> > >> Failsafe driver has been indicating zero for RSS redirection table size > >> after device info reporting had been rewo

Re: [dpdk-dev] ABI versioning in Windows

2020-05-27 Thread Thomas Monjalon
27/05/2020 22:35, Neil Horman: > On Wed, May 27, 2020 at 02:50:07PM +0200, Thomas Monjalon wrote: > > +Cc more people > > > > 27/05/2020 12:41, Fady Bader: > > > What should we do with the ABI versioning in Windows ? > > > > I think there are 2 questions here: > > > > 1/ Do we want to maintain A

Re: [dpdk-dev] [PATCH v3 2/7] net/netvsc: implement rx/tx descriptor status functions

2020-05-27 Thread Stephen Hemminger
On Wed, 27 May 2020 19:14:49 +0100 Ferruh Yigit wrote: > On 5/19/2020 5:52 PM, Stephen Hemminger wrote: > > These functions are useful for applications and debugging. > > The netvsc PMD also transparently handles the rx/tx descriptor > > functions for underlying VF device. > > > > Signed-off-by:

Re: [dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted

2020-05-27 Thread Stephen Hemminger
On Thu, 28 May 2020 01:13:27 +0500 Muhammad Bilal wrote: > Recently I have submitted patches and some tests were failing on patchwork. > My question is, which tests are compulsory to pass for a patch to be accepted. > As in the below mentioned patch, it is accepted while 1 test was still > faili

Re: [dpdk-dev] [PATCH v4] eal/windows: ring build on Windows

2020-05-27 Thread Ranjit Menon
On 5/27/2020 1:24 AM, Fady Bader wrote: Exported per_lcore__rte_errno function to compile ring for windows. compilation error logs: librte_ring_rte_ring.c.obj : error LNK2019: unresolved external symbol per_lcore__rte_errno referenced in function rte_ring_lookup The cause was that per_lcore__rt

Re: [dpdk-dev] [RFC 0/6] Power-optimized RX for Ethernet devices

2020-05-27 Thread Stephen Hemminger
On Wed, 27 May 2020 23:03:59 +0530 Jerin Jacob wrote: > On Wed, May 27, 2020 at 10:32 PM Anatoly Burakov > wrote: > > > > This patchset proposes a simple API for Ethernet drivers > > to cause the CPU to enter a power-optimized state while > > waiting for packets to arrive, along with a set of >

Re: [dpdk-dev] ABI versioning in Windows

2020-05-27 Thread Neil Horman
On Wed, May 27, 2020 at 02:50:07PM +0200, Thomas Monjalon wrote: > +Cc more people > > 27/05/2020 12:41, Fady Bader: > > What should we do with the ABI versioning in Windows ? > > I think there are 2 questions here: > > 1/ Do we want to maintain ABI compatibility on Windows like we do for Linux

[dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted

2020-05-27 Thread Muhammad Bilal
Recently I have submitted patches and some tests were failing on patchwork. My question is, which tests are compulsory to pass for a patch to be accepted. As in the below mentioned patch, it is accepted while 1 test was still failing. http://patches.dpdk.org/patch/70348/ kind regards. Muhammad Bil

Re: [dpdk-dev] [PATCH v3 0/7] net/netvsc: VF bug fix and diagnostic support

2020-05-27 Thread Ferruh Yigit
On 5/19/2020 5:52 PM, Stephen Hemminger wrote: > This set of patches includes bugfixes for races in VF handling > and implements the queue and descriptor status functions in netvsc PMD. > > This patch set is likely to cause merge warnings for the automated > tools because it is based on top of my

Re: [dpdk-dev] [PATCH v3 2/7] net/netvsc: implement rx/tx descriptor status functions

2020-05-27 Thread Ferruh Yigit
On 5/19/2020 5:52 PM, Stephen Hemminger wrote: > These functions are useful for applications and debugging. > The netvsc PMD also transparently handles the rx/tx descriptor > functions for underlying VF device. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/netvsc/hn_ethdev.c | 3 ++ >

Re: [dpdk-dev] [PATCH 12/37] drivers: optimize thread local storage for dpaa

2020-05-27 Thread Akhil Goyal
> From: Rohit Raj > > Minimize the number of different thread variables > > Add all the thread specific variables in dpaa_portal > structure to optimize TLS Usage. > > Signed-off-by: Rohit Raj > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH 02/37] net/dpaa: fix fd offset data type

2020-05-27 Thread Akhil Goyal
> From: Nipun Gupta > > On DPAA fd offset is 9 bits, but we are using uint8_t in the > SG case. This patch fixes the same. > Fixes: 8cffdcbe85aa ("net/dpaa: support scattered Rx") > Cc: sta...@dpdk.org > > Signed-off-by: Nipun Gupta > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH 01/37] bus/fslmc: fix getting the FD error

2020-05-27 Thread Akhil Goyal
> -Original Message- > From: dev On Behalf Of Hemant Agrawal > Sent: Wednesday, May 27, 2020 6:53 PM > To: dev@dpdk.org; ferruh.yi...@intel.com > Cc: sta...@dpdk.org; Nipun Gupta > Subject: [dpdk-dev] [PATCH 01/37] bus/fslmc: fix getting the FD error > > From: Nipun Gupta > > Fix th

Re: [dpdk-dev] [RFC 0/6] Power-optimized RX for Ethernet devices

2020-05-27 Thread Jerin Jacob
On Wed, May 27, 2020 at 10:32 PM Anatoly Burakov wrote: > > This patchset proposes a simple API for Ethernet drivers > to cause the CPU to enter a power-optimized state while > waiting for packets to arrive, along with a set of > (hopefully generic) intrinsics that facilitate that. This > is achie

Re: [dpdk-dev] [EXT] Re: [PATCH] eal: fix epoll fd list rebuild

2020-05-27 Thread Harman Kalra
On Wed, May 27, 2020 at 03:04:04PM +0200, Thomas Monjalon wrote: > 27/05/2020 14:44, Harman Kalra: > > On Wed, May 27, 2020 at 06:02:53PM +0530, Harman Kalra wrote: > > > On Mon, May 25, 2020 at 03:19:08PM +0530, Harman Kalra wrote: > > > > On Sun, May 24, 2020 at 05:30:26PM +0200, Thomas Monjalon

[dpdk-dev] [RFC 6/6] app/testpmd: add command for power management on a port

2020-05-27 Thread Anatoly Burakov
A quick-and-dirty testpmd command to enable power management on a specific port. Signed-off-by: Anatoly Burakov --- app/test-pmd/cmdline.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 996a498

[dpdk-dev] [RFC 4/6] net/i40e: implement power management API

2020-05-27 Thread Anatoly Burakov
Implement support for the power management API by implementing a `next_rx_desc` function that will return an address of an RX ring's status bit. Signed-off-by: Liang J. Ma Signed-off-by: Anatoly Burakov --- drivers/net/i40e/i40e_ethdev.c | 1 + drivers/net/i40e/i40e_rxtx.c | 23 +

[dpdk-dev] [RFC 1/6] eal: add power management intrinsics

2020-05-27 Thread Anatoly Burakov
Add two new power management intrinsics, and provide an implementation in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions are implemented as raw byte opcodes because there is not yet widespread compiler support for these instructions. The power management instructions provide an ar

[dpdk-dev] [RFC 3/6] net/ixgbe: implement power management API

2020-05-27 Thread Anatoly Burakov
Implement support for the power management API by implementing a `next_rx_desc` function that will return an address of an RX ring's status bit. Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/ixgbe/ixgbe_rxtx.c | 22 ++ drivers/net/i

[dpdk-dev] [RFC 2/6] ethdev: add simple power management API

2020-05-27 Thread Anatoly Burakov
Add a simple on/off switch that will enable saving power when no packets are arriving. It is based on counting the number of empty polls and, when the number reaches a certain threshold, entering an architecture-defined optimized power state that will either wait until a TSC timestamp expires, or w

[dpdk-dev] [RFC 0/6] Power-optimized RX for Ethernet devices

2020-05-27 Thread Anatoly Burakov
This patchset proposes a simple API for Ethernet drivers to cause the CPU to enter a power-optimized state while waiting for packets to arrive, along with a set of (hopefully generic) intrinsics that facilitate that. This is achieved through cooperation with the NIC driver that will allow us to kno

[dpdk-dev] [RFC 5/6] net/ice: implement power management API

2020-05-27 Thread Anatoly Burakov
Implement support for the power management API by implementing a `next_rx_desc` function that will return an address of an RX ring's status bit. Signed-off-by: Liang J. Ma Signed-off-by: Anatoly Burakov --- drivers/net/ice/ice_ethdev.c | 1 + drivers/net/ice/ice_rxtx.c | 23 +

Re: [dpdk-dev] [PATCH v1 2/3] common/mlx5: move netlink files under Linux directory

2020-05-27 Thread Stephen Hemminger
On Wed, 27 May 2020 16:14:24 + Ophir Munk wrote: > + DRV_LOG(DEBUG, > + "Interface %u cannot %s MAC address" > + " %02X:%02X:%02X:%02X:%02X:%02X %s", > + iface_idx, > + add ? "add" : "remove", > + mac->addr_bytes[0], mac->addr_by

Re: [dpdk-dev] [PATCH v5 03/11] eal: introduce memory management wrappers

2020-05-27 Thread Dmitry Kozlyuk
Answers below is the summary of discussion with Thomas, Ranjit, Tal, et al. On Wed, 27 May 2020 07:33:32 +0100 Ray Kinsella wrote: > Are wrappers 100% are required. > Would it be simpler (and less invasive) to have a windows_compat.h that > plugged this holes? > I am not sure on the standard app

[dpdk-dev] [PATCH v1 2/3] common/mlx5: move netlink files under Linux directory

2020-05-27 Thread Ophir Munk
File mlx5_nl.c is using Netlink APIs which are Linux specifics. Move it (including file mlx5_nl.h) to common/mlx5/linux directory. Signed-off-by: Ophir Munk --- drivers/common/mlx5/Makefile |2 +- drivers/common/mlx5/linux/meson.build |1 + drivers/common/mlx5/linux/mlx5_nl.c

[dpdk-dev] [PATCH v1 1/3] common/mlx5: move glue files under Linux directory

2020-05-27 Thread Ophir Munk
The glue file mlx5_glue.c is based on Linux specifics APIs. Move it (including file mlx5_glue.h) to common/mlx5/linux directory. Signed-off-by: Ophir Munk --- drivers/common/mlx5/Makefile | 12 +- drivers/common/mlx5/linux/meson.build | 199 + drivers/common/mlx5/linux/mlx5_glue.

[dpdk-dev] [PATCH v1 3/3] common/mlx5: split common file under Linux directory

2020-05-27 Thread Ophir Munk
File mlx5_common.c includes both specific and non-specific Linux APIs. Move the Linux specific APIS into a new file named linux/mlx5_common_os.c. Signed-off-by: Ophir Munk --- drivers/common/mlx5/Makefile | 1 + drivers/common/mlx5/linux/meson.build | 1 + drivers/common/m

[dpdk-dev] rte_log simplification using constructor scheme

2020-05-27 Thread Jerin Kollanukkaran
Based on the discussion happed on http://patches.dpdk.org/patch/69681/, I would like simply the rte_log to use constructor scheme and submit patch to update existing consumer of rte_log to use new scheme for v20.08. RTE_LOG_REGISTER will an optional symbol to use the rte_log registration mechanism

Re: [dpdk-dev] [PATCH] net/bnxt: allow the mark to use a cfa code of zero

2020-05-27 Thread Ferruh Yigit
On 5/23/2020 12:55 AM, Mike Baucom wrote: > The mark code was too restrictive by disallowing a cfa_code of zero. > This code loosens the requirement and allows zero. I can see "if (cfa_code)" check removed, but can you please give some details that what it the impact of having that check and why c

Re: [dpdk-dev] [PATCH] bugfix: udptcp_checksum should tread tcp and udp differently

2020-05-27 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, May 27, 2020 5:03 PM > > On Wed, 27 May 2020 22:41:27 +0800 > guohongzhi wrote: > > > + /* For Udp, if the computed checksum is zero, > > +* it is transmitted as all ones.RFC768 > > +*/ > > +

Re: [dpdk-dev] [PATCH 0/5] misc updates for hns3 PMD driver

2020-05-27 Thread Ferruh Yigit
On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote: > This series are improvement and bugfixes for hns3 PMD driver. > > Chengchang Tang (2): > net/hns3: replace PF vport id zero with private macro > net/hns3: fix promiscuous config not clear for PF on uninit > > Lijun Ou (2): > net/hns3: add RSS

Re: [dpdk-dev] [PATCH] net/failsafe: report valid RSS RETA size

2020-05-27 Thread Andrew Rybchenko
On 5/27/20 6:07 PM, Gaëtan Rivet wrote: > On 27/05/20 15:34 +0100, Andrew Rybchenko wrote: >> From: Ian Dolzhansky >> >> Failsafe driver has been indicating zero for RSS redirection table size >> after device info reporting had been reworked. Report proper value. >> >> Fixes: 4586be3743d4 ("net/fa

Re: [dpdk-dev] [PATCH] net/failsafe: report valid RSS RETA size

2020-05-27 Thread Gaëtan Rivet
On 27/05/20 15:34 +0100, Andrew Rybchenko wrote: > From: Ian Dolzhansky > > Failsafe driver has been indicating zero for RSS redirection table size > after device info reporting had been reworked. Report proper value. > > Fixes: 4586be3743d4 ("net/failsafe: fix reported device info") > Cc: Steph

Re: [dpdk-dev] [PATCH] bugfix: udptcp_checksum should tread tcp and udp differently

2020-05-27 Thread Stephen Hemminger
On Wed, 27 May 2020 22:41:27 +0800 guohongzhi wrote: > + /* For Udp, if the computed checksum is zero, > + * it is transmitted as all ones.RFC768 > + */ > + if (cksum == 0 && ipv4_hdr->next_proto_id == IPPROTO_UDP) > cksum = 0x; > The comment should be refo

Re: [dpdk-dev] [PATCH] bugfix: rte_raw_checksum

2020-05-27 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of guohongzhi > Sent: Wednesday, May 27, 2020 3:40 PM > > From: Hongzhi Guo > > __rte_raw_cksum should consider Big Endian. > > Signed-off-by: Hongzhi Guo > --- > lib/librte_net/rte_ip.h | 4 > 1 file changed, 4 insertions(+) > > diff

[dpdk-dev] [PATCH] app/test: fix build with ring pmd but no bond pmd

2020-05-27 Thread Bruce Richardson
If the bonding pmd is disabled, all autotest associated with it should be disabled. However, some of those tests also depended upon the ring PMD so were placed in a block depending on that driver - and unfortunately that driver alone. This caused build failures if the ring PMD was enabled but the b

Re: [dpdk-dev] [PATCH v2 2/7] ethdev: add a link status textrepresentation

2020-05-27 Thread Stephen Hemminger
On Wed, 27 May 2020 09:45:49 +0200 Morten Brørup wrote: > void rte_eth_link_prepare_text(char *str, const struct rte_eth_link *const > link) > { > if (link.link_status == ETH_LINK_DOWN) { > str += sprintf(str, "Link down"); > } else { > str += sprintf(str, "Link up at ");

[dpdk-dev] [PATCH] bugfix: udptcp_checksum should tread tcp and udp differently

2020-05-27 Thread guohongzhi
From: Hongzhi Guo RFC 768 for UDP specifies: If the computed checksum is zero, it is transmitted as all ones. An all zero transmitted checksum value means that the transmitter generated no checksum. RFC 793 for TCP has no such special treatment for the checksum of zero. Signed-off-by: Hon

[dpdk-dev] [PATCH] bugfix: udptcp_checksum should tread tcp and udp differently

2020-05-27 Thread guohongzhi
RFC 768 for UDP specifies: If the computed checksum is zero, it is transmitted as all ones. An all zero transmitted checksum value means that the transmitter generated no checksum. RFC 793 for TCP has no such special treatment for the checksum of zero. Signed-off-by: guohongzhi --- lib/li

[dpdk-dev] [PATCH] net/failsafe: report valid RSS RETA size

2020-05-27 Thread Andrew Rybchenko
From: Ian Dolzhansky Failsafe driver has been indicating zero for RSS redirection table size after device info reporting had been reworked. Report proper value. Fixes: 4586be3743d4 ("net/failsafe: fix reported device info") Cc: Stephen Hemminger Cc: sta...@dpdk.org Signed-off-by: Ian Dolzhansk

Re: [dpdk-dev] ABI versioning in Windows

2020-05-27 Thread Ray Kinsella
Is my impression is the the Windows build is nascent, a fair one? Would we consider the entire build experimental for the moment? Thanks, Ray K On 27/05/2020 13:50, Thomas Monjalon wrote: > +Cc more people > > 27/05/2020 12:41, Fady Bader: >> What should we do with the ABI versioning in Wind

[dpdk-dev] [PATCH] net: do fragmented headers check in non-debug build as well

2020-05-27 Thread Andrew Rybchenko
Pseudo-header checksum calculation requires contiguous headers. There is no any formal requirements on data location and mbuf structure which could be used by the application. Make corresponding check to be done in non-debug build as well to avoid bad accesses, incorrect checksum caclculation and

[dpdk-dev] [PATCH] ether: check the first segment length on SW VLAN insertion

2020-05-27 Thread Andrew Rybchenko
SW VLAN insertion relies on Ethernet addresses location in contigous memory (do not split across mbuf segments). There is no any formal requirements on data location and mbuf structure which guarantee it. So, check it explicitly to avoid corrupted packets if the condition is violated. Typically sof

[dpdk-dev] [PATCH v2 5/5] bpf: x86 JIT support for packet data load instructions

2020-05-27 Thread Konstantin Ananyev
Make x86 JIT to generate native code for (BPF_ABS | | BPF_LD) and (BPF_IND | | BPF_LD) instructions. Signed-off-by: Konstantin Ananyev --- lib/librte_bpf/bpf_jit_x86.c | 181 ++ lib/librte_bpf/bpf_validate.c | 17 +++- 2 files changed, 197 insertions(+), 1 del

[dpdk-dev] [PATCH v2 1/5] test/bpf: fix few small issues

2020-05-27 Thread Konstantin Ananyev
Address for few small issues: - unreachable return statement - failed test-case can finish with 'success' status Also use unified cmp_res() function to check return value. Fixes: a9de470cc7c0 ("test: move to app directory") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev --- app/test/t

[dpdk-dev] [PATCH v2 2/5] bpf: fix add/sub min/max estimations

2020-05-27 Thread Konstantin Ananyev
eval_add()/eval_sub() not always correctly estimate minimum and maximum possible values of add/sub operations. Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev --- lib/librte_bpf/bpf_validate.c | 10 +- 1 file

[dpdk-dev] [PATCH v2 3/5] bpf: add support for packet data load instructions

2020-05-27 Thread Konstantin Ananyev
To fill the gap with linux kernel eBPF implementation, add support for two non-generic instructions: (BPF_ABS | | BPF_LD) and (BPF_IND | | BPF_LD) which are used to access packet data. These instructions can only be used when BPF context is a pointer to 'struct rte_mbuf' (i.e: RTE_BPF_ARG_PTR_MBU

[dpdk-dev] [PATCH v2 4/5] test/bpf: add new test cases for mbuf load instructions

2020-05-27 Thread Konstantin Ananyev
Add new test-cases for BPF_ABS/BPF_IND load instructions. Signed-off-by: Konstantin Ananyev --- app/test/test_bpf.c | 463 1 file changed, 463 insertions(+) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 4a61a7d7c..7c3de96c6 100644 ---

[dpdk-dev] [PATCH v2 0/5] bpf: add support for BPF_ABS/BPF_IND instructions

2020-05-27 Thread Konstantin Ananyev
To fill the gap with linux kernel eBPF implementation, add support for two non-generic instructions: (BPF_ABS | | BPF_LD) and (BPF_IND | | BPF_LD) which are used to access packet data in a safe manner. Make necessary changes in BPF verifier, interpreter and x86 JIT code. Konstantin Ananyev (5):

[dpdk-dev] [PATCH] bugfix: rte_raw_checksum

2020-05-27 Thread guohongzhi
From: Hongzhi Guo __rte_raw_cksum should consider Big Endian. Signed-off-by: Hongzhi Guo --- lib/librte_net/rte_ip.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h index 1ceb7b7..eb863d4 100644 --- a/lib/librte_net/rte_ip.h +++ b/lib/l

[dpdk-dev] [PATCH 36/37] net/dpaa2: configure per class distribution size

2020-05-27 Thread Hemant Agrawal
From: Jun Yang TC distribution size is set with dist_queues or nb_rx_queues % dist_queues in order of TC priority. Signed-off-by: Jun Yang --- drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/net/dpaa2/base/

[dpdk-dev] [PATCH 37/37] net/dpaa2: support raw flow classification

2020-05-27 Thread Hemant Agrawal
From: Nipun Gupta Add support for raw flow, which can be used for any protocol rules. Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/dpaa2_ethdev.h | 3 +- drivers/net/dpaa2/dpaa2_flow.c | 135 +++ 2 files changed, 137 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 35/37] net/dpaa2: flow API FS miss action configuration

2020-05-27 Thread Hemant Agrawal
From: Jun Yang 1) dpni_set_rx_hash_dist and dpni_set_rx_fs_dist used for TC configuration instead of dpni_set_rx_tc_dist. Otherwise, re-configuration of default TC of QoS fails. 2) Default miss action is to drop. "export DPAA2_FLOW_CONTROL_MISS_FLOW=flow_id" is used receive the missed packets f

[dpdk-dev] [PATCH 34/37] net/dpaa2: flow API QoS setup follows FS setup

2020-05-27 Thread Hemant Agrawal
From: Jun Yang In HW/MC logical, QoS setup should follow FS setup. In addition, Skip QoS setup if MAX TC number of DPNI is set 1. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 151 ++--- 1 file changed, 84 insertions(+), 67 deletions(-) diff --git a/

[dpdk-dev] [PATCH 33/37] net/dpaa2: flow data sanity check

2020-05-27 Thread Hemant Agrawal
From: Jun Yang Check flow attributions and actions before creating flow. Otherwise, the QoS table and FS table need to re-build if checking fails. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 84 ++ 1 file changed, 65 insertions(+), 19 deletions(

[dpdk-dev] [PATCH 30/37] net/dpaa2: discrimination between IPv4 and IPv6

2020-05-27 Thread Hemant Agrawal
From: Jun Yang Discriminate between IPv4 and IPv6 in generic IP flow setup. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 153 + 1 file changed, 80 insertions(+), 73 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpa

[dpdk-dev] [PATCH 32/37] net/dpaa2: index of queue action for flow

2020-05-27 Thread Hemant Agrawal
From: Jun Yang Make more sense to use RXQ index for queue distribution instead of flow ID. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/

[dpdk-dev] [PATCH 31/37] net/dpaa2: distribution size set on multiple TCs

2020-05-27 Thread Hemant Agrawal
From: Jun Yang Default distribution size of TC is 1, which is limited by MC. We have to set the distribution size for each TC to support multiple RXQs per TC. Signed-off-by: Jun Yang --- drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 6 +-- drivers/net/dpaa2/dpaa2_ethdev.c | 51 ++

[dpdk-dev] [PATCH 28/37] net/dpaa2: define the size of table entry

2020-05-27 Thread Hemant Agrawal
From: Jun Yang If entry size is not bigger than 27, MC alloc one TCAM entry, otherwise, alloc 2 TCAM entries. Extracts size by HW must be not bigger than TCAM entry size(27 or 54). So define the flow entry size as 54. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 90

[dpdk-dev] [PATCH 24/37] net/dpaa2: key extracts of flow API

2020-05-27 Thread Hemant Agrawal
From: Jun Yang 1) Support QoS extracts and TC extracts for multiple TCs. 2) Protocol type of L2 extract is used to parse L3. Next protocol of L3 extract is used to parse L4. 3) generic IP key extracts instead of IPv4 and IPv6 respectively. 4) Special for IP address extracts: Put IP(v4/v6

[dpdk-dev] [PATCH 27/37] net/dpaa2: flow QoS or FS table entry indexing

2020-05-27 Thread Hemant Agrawal
From: Jun Yang Calculate QoS/FS entry index by group and priority of flow. 1)The less index of entry, the higher priority of flow. 2)Verify if the flow with same group and priority has been added before creating flow. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 + dri

[dpdk-dev] [PATCH 26/37] net/dpaa2: free flow rule memory

2020-05-27 Thread Hemant Agrawal
From: Jun Yang Free rule memory when the flow is destroyed. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_flow.c index 507a5d0e3..941d62b80 100644 --- a/drivers/net/dp

[dpdk-dev] [PATCH 25/37] net/dpaa2: sanity check for flow extracts

2020-05-27 Thread Hemant Agrawal
From: Jun Yang Define extracts support for each protocol and check the fields of each pattern before building extracts of QoS/FS table. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_ethdev.c | 7 +- drivers/net/dpaa2/dpaa2_flow.c | 250 +-- 2 files changed

[dpdk-dev] [PATCH 29/37] net/dpaa2: log of flow extracts and rules

2020-05-27 Thread Hemant Agrawal
From: Jun Yang This patch add support for logging the flow rules. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 213 - 1 file changed, 209 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_flow.c

[dpdk-dev] [PATCH 22/37] net/dpaa: add RSS update func with FMCless

2020-05-27 Thread Hemant Agrawal
From: Sachin Saxena With FMCLESS mode now RSS can be modified on runtime. This patch add support for RSS update functions Signed-off-by: Hemant Agrawal Signed-off-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethdev.c | 37 ++ 1 file changed, 37 insertions(+) di

[dpdk-dev] [PATCH 23/37] net/dpaa2: dynamic flow control support

2020-05-27 Thread Hemant Agrawal
From: Jun Yang Dynamic flow used instead of layout defined. The actual key/mask size depends on protocols and(or) fields of patterns specified. Also, the key and mask should start from the beginning of IOVA. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 146

[dpdk-dev] [PATCH 20/37] net/dpaa: add support for Virtual Storage Profile

2020-05-27 Thread Hemant Agrawal
From: Jun Yang This patch adds support for Virtual Storage profile (VSP) feature. With VSP support when memory pool is created, the bpid is not allocated; the bpid is identified by dpaa flow create API. The memory pool of RX queue is attached to specific BMan pool according to the VSP ID when RX

[dpdk-dev] [PATCH 21/37] net/dpaa: add fmc parser support for VSP

2020-05-27 Thread Hemant Agrawal
From: Jun Yang Parse the fmc.bin generated by fmc to setup RXQs for each port on fmc mode. The parser gets the fqids and vspids from fmc.bin. Signed-off-by: Jun Yang --- drivers/net/dpaa/Makefile | 1 + drivers/net/dpaa/dpaa_ethdev.c | 26 +- drivers/net/dpaa/dpaa_ethdev.h | 10 +- dr

[dpdk-dev] [PATCH 19/37] bus/dpaa: add Virtual Storage Profile port init

2020-05-27 Thread Hemant Agrawal
This patch add support to initialize the VSP ports in the FMAN library. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 57 +++ drivers/bus/dpaa/include/fman.h | 3 ++ 2 files changed, 60 insertions(+) diff --git a/drivers/bus/dpaa/base/fman/

[dpdk-dev] [PATCH 18/37] bus/dpaa: add shared MAC support

2020-05-27 Thread Hemant Agrawal
From: Radu Bulie A shared MAC interface is an interface which can be used by both kernel and userspace based on classification configuration It is defined in dts with the compatible string "fsl,dpa-ethernet-shared" which bpool will be seeded by the dpdk partition and configured as a netdev by the

[dpdk-dev] [PATCH 16/37] net/dpaa: add VSP support in FMLIB

2020-05-27 Thread Hemant Agrawal
From: Jun Yang This patch adds support for VSP (Virtual Storage Profile) FMLIB routines. VSP allow a network interface to be divided into physical and virtual instances. Signed-off-by: Jun Yang --- drivers/net/dpaa/Makefile | 1 + drivers/net/dpaa/fmlib/fm_vsp.c | 143

[dpdk-dev] [PATCH 17/37] net/dpaa: add support for fmcless mode

2020-05-27 Thread Hemant Agrawal
From: Sachin Saxena This patch uses fmlib to configure the FMAN HW for flow and distribution configuration, thus avoiding the need for static FMC tool execution optionally. Signed-off-by: Sachin Saxena Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/Makefile | 1 + drivers/net/dpaa/

[dpdk-dev] [PATCH 14/37] bus/dpaa: enable set link status

2020-05-27 Thread Hemant Agrawal
From: Rohit Raj Enabled set link status API to start/stop phy device from application. Signed-off-by: Rohit Raj --- drivers/bus/dpaa/base/qbman/process.c | 27 + drivers/bus/dpaa/include/process.h| 11 +++ drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 + driver

[dpdk-dev] [PATCH 11/37] net/dpaa: update process specific device info

2020-05-27 Thread Hemant Agrawal
From: Nipun Gupta For DPAA devices the memory maps stored in the FMAN interface information is per process. Store them in the device process specific area. This is required to support multi-process apps. Signed-off-by: Nipun Gupta --- drivers/net/dpaa/dpaa_ethdev.c | 207 --

[dpdk-dev] [PATCH 12/37] drivers: optimize thread local storage for dpaa

2020-05-27 Thread Hemant Agrawal
From: Rohit Raj Minimize the number of different thread variables Add all the thread specific variables in dpaa_portal structure to optimize TLS Usage. Signed-off-by: Rohit Raj --- drivers/bus/dpaa/dpaa_bus.c | 24 ++--- drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 -

[dpdk-dev] [PATCH 10/37] net/dpaa: add 2.5G support

2020-05-27 Thread Hemant Agrawal
From: Sachin Saxena Handle 2.5Gbps ethernet ports as well. Signed-off-by: Sachin Saxena Signed-off-by: Gagandeep Singh --- doc/guides/nics/features/dpaa.ini | 2 +- drivers/bus/dpaa/base/fman/fman.c | 6 -- drivers/bus/dpaa/base/fman/netcfg_layer.c | 3 ++- drivers/bus/dpa

[dpdk-dev] [PATCH 13/37] bus/dpaa: enable link state interrupt

2020-05-27 Thread Hemant Agrawal
From: Rohit Raj Enable/disable link state interrupt and get link state api is defined using IOCTL calls from kernel driver Signed-off-by: Rohit Raj --- drivers/bus/dpaa/base/fman/fman.c | 4 +- drivers/bus/dpaa/base/qbman/process.c | 72 - drivers/bus/dpaa/dpaa_bus

[dpdk-dev] [PATCH 07/37] bus/fslmc: support portal migration

2020-05-27 Thread Hemant Agrawal
From: Nipun Gupta The patch adds support for portal migration by disabling stashing for the portals which is used in the non-affined threads, or on threads affined to multiple cores Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 83 + .../bus/fslmc/qbman/in

[dpdk-dev] [PATCH 08/37] bus/fslmc: rename the cinh read functions used for ls1088

2020-05-27 Thread Hemant Agrawal
From: Nipun Gupta This patch changes the qbman I/O function names as they are only reading from cinh register, but writing to cena registers. This gives way to add functions which purely work in cinh mode Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/qbman/qbman_portal.c | 250

[dpdk-dev] [PATCH 09/37] net/dpaa: enable Tx queue taildrop

2020-05-27 Thread Hemant Agrawal
From: Gagandeep Singh Enable congestion handling/tail drop for TX queues. Signed-off-by: Gagandeep Singh --- drivers/bus/dpaa/base/qbman/qman.c| 43 + drivers/bus/dpaa/include/fsl_qman.h | 17 drivers/bus/dpaa/rte_bus_dpaa_version.map | 2 + drivers/net/dpaa/dpaa

[dpdk-dev] [PATCH 06/37] bus/fslmc: support handle portal alloc failure

2020-05-27 Thread Hemant Agrawal
Add the error handling on failure. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 28 ++-- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/p

[dpdk-dev] [PATCH 04/37] bus/fslmc: combine thread specific variables

2020-05-27 Thread Hemant Agrawal
From: Gagandeep Singh This is to reduce the thread local storage Signed-off-by: Gagandeep Singh --- drivers/bus/fslmc/fslmc_bus.c | 2 -- drivers/bus/fslmc/portal/dpaa2_hw_dpio.h| 7 +++ drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 8 drivers/bus/fslmc/rte_bu

  1   2   >