Hi Gage, Do you have any idea. If the change from experimental to stable symbol is likely to break anyone's application? (are folks actively using the api with shared libraries)
If so, you _may_ consider offering a temporary alias to experimental until the v21 is declared at 20.11. This is entirely at your discretion, see https://doc.dpdk.org/guides/contributing/abi_versioning.html (4.3.1.4) Please see my additional comments on the map file below. On 28/05/2020 02:04, Gage Eads wrote: > The stack library was first released in 19.05, and its interfaces have been > stable since their initial introduction. This commit promotes the full > interface to stable, starting with the 20.08 ABI. > > Signed-off-by: Gage Eads <gage.e...@intel.com> > --- > lib/librte_stack/rte_stack.h | 29 ----------------------------- > lib/librte_stack/rte_stack_lf.h | 2 -- > lib/librte_stack/rte_stack_std.h | 3 --- > lib/librte_stack/rte_stack_version.map | 2 +- > 4 files changed, 1 insertion(+), 35 deletions(-) > > diff --git a/lib/librte_stack/rte_stack.h b/lib/librte_stack/rte_stack.h > index 27ddb199e..343dd019a 100644 > --- a/lib/librte_stack/rte_stack.h > +++ b/lib/librte_stack/rte_stack.h > @@ -4,7 +4,6 @@ > > /** > * @file rte_stack.h > - * @b EXPERIMENTAL: this API may change without prior notice > * > * RTE Stack > * > @@ -98,9 +97,6 @@ struct rte_stack { > #include "rte_stack_lf.h" > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Push several objects on the stack (MT-safe). > * > * @param s > @@ -112,7 +108,6 @@ struct rte_stack { > * @return > * Actual number of objects pushed (either 0 or *n*). > */ > -__rte_experimental > static __rte_always_inline unsigned int > rte_stack_push(struct rte_stack *s, void * const *obj_table, unsigned int n) > { > @@ -126,9 +121,6 @@ rte_stack_push(struct rte_stack *s, void * const > *obj_table, unsigned int n) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Pop several objects from the stack (MT-safe). > * > * @param s > @@ -140,7 +132,6 @@ rte_stack_push(struct rte_stack *s, void * const > *obj_table, unsigned int n) > * @return > * Actual number of objects popped (either 0 or *n*). > */ > -__rte_experimental > static __rte_always_inline unsigned int > rte_stack_pop(struct rte_stack *s, void **obj_table, unsigned int n) > { > @@ -154,9 +145,6 @@ rte_stack_pop(struct rte_stack *s, void **obj_table, > unsigned int n) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Return the number of used entries in a stack. > * > * @param s > @@ -164,7 +152,6 @@ rte_stack_pop(struct rte_stack *s, void **obj_table, > unsigned int n) > * @return > * The number of used entries in the stack. > */ > -__rte_experimental > static __rte_always_inline unsigned int > rte_stack_count(struct rte_stack *s) > { > @@ -177,9 +164,6 @@ rte_stack_count(struct rte_stack *s) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Return the number of free entries in a stack. > * > * @param s > @@ -187,7 +171,6 @@ rte_stack_count(struct rte_stack *s) > * @return > * The number of free entries in the stack. > */ > -__rte_experimental > static __rte_always_inline unsigned int > rte_stack_free_count(struct rte_stack *s) > { > @@ -197,9 +180,6 @@ rte_stack_free_count(struct rte_stack *s) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Create a new stack named *name* in memory. > * > * This function uses ``memzone_reserve()`` to allocate memory for a stack of > @@ -226,28 +206,20 @@ rte_stack_free_count(struct rte_stack *s) > * - ENOMEM - insufficient memory to create the stack > * - ENAMETOOLONG - name size exceeds RTE_STACK_NAMESIZE > */ > -__rte_experimental > struct rte_stack * > rte_stack_create(const char *name, unsigned int count, int socket_id, > uint32_t flags); > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Free all memory used by the stack. > * > * @param s > * Stack to free > */ > -__rte_experimental > void > rte_stack_free(struct rte_stack *s); > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Lookup a stack by its name. > * > * @param name > @@ -258,7 +230,6 @@ rte_stack_free(struct rte_stack *s); > * - ENOENT - Stack with name *name* not found. > * - EINVAL - *name* pointer is NULL. > */ > -__rte_experimental > struct rte_stack * > rte_stack_lookup(const char *name); > > diff --git a/lib/librte_stack/rte_stack_lf.h b/lib/librte_stack/rte_stack_lf.h > index e67630c27..eb106e64e 100644 > --- a/lib/librte_stack/rte_stack_lf.h > +++ b/lib/librte_stack/rte_stack_lf.h > @@ -27,7 +27,6 @@ > * @return > * Actual number of objects enqueued. > */ > -__rte_experimental > static __rte_always_inline unsigned int > __rte_stack_lf_push(struct rte_stack *s, > void * const *obj_table, > @@ -66,7 +65,6 @@ __rte_stack_lf_push(struct rte_stack *s, > * @return > * - Actual number of objects popped. > */ > -__rte_experimental > static __rte_always_inline unsigned int > __rte_stack_lf_pop(struct rte_stack *s, void **obj_table, unsigned int n) > { > diff --git a/lib/librte_stack/rte_stack_std.h > b/lib/librte_stack/rte_stack_std.h > index 7142cbf8e..ae28add5c 100644 > --- a/lib/librte_stack/rte_stack_std.h > +++ b/lib/librte_stack/rte_stack_std.h > @@ -19,7 +19,6 @@ > * @return > * Actual number of objects pushed (either 0 or *n*). > */ > -__rte_experimental > static __rte_always_inline unsigned int > __rte_stack_std_push(struct rte_stack *s, void * const *obj_table, > unsigned int n) > @@ -59,7 +58,6 @@ __rte_stack_std_push(struct rte_stack *s, void * const > *obj_table, > * @return > * Actual number of objects popped (either 0 or *n*). > */ > -__rte_experimental > static __rte_always_inline unsigned int > __rte_stack_std_pop(struct rte_stack *s, void **obj_table, unsigned int n) > { > @@ -94,7 +92,6 @@ __rte_stack_std_pop(struct rte_stack *s, void **obj_table, > unsigned int n) > * @return > * The number of used entries in the stack. > */ > -__rte_experimental > static __rte_always_inline unsigned int > __rte_stack_std_count(struct rte_stack *s) > { > diff --git a/lib/librte_stack/rte_stack_version.map > b/lib/librte_stack/rte_stack_version.map > index 6662679c3..22c703d3b 100644 > --- a/lib/librte_stack/rte_stack_version.map > +++ b/lib/librte_stack/rte_stack_version.map > @@ -1,4 +1,4 @@ > -EXPERIMENTAL { > +DPDK_20.0.3 { > global: > > rte_stack_create; > Should be DPDK_21, the next major ABI version is v21.
