Re: [dpdk-dev] [RFC] eal: adjust barriers for IO on Armv8-a

2020-05-11 Thread Jerin Jacob
On Tue, May 12, 2020 at 11:48 AM Ruifeng Wang wrote: > > > > -Original Message- > > From: Honnappa Nagarahalli > > Sent: Tuesday, May 12, 2020 2:07 AM > > To: dev@dpdk.org; jer...@marvell.com; hemant.agra...@nxp.com; Ajit > > Khaparde (ajit.khapa...@broadcom.com) ; > > igo...@amazon.com;

[dpdk-dev] [PATCH] net/i40e: fix the security risk of wild pointer operation

2020-05-11 Thread Wei Zhao
In i40e PMD code of function i40e_res_pool_free(), if valid_entry is freed by "rte_free(valid_entry);" in the following code: if (prev != NULL) { if (insert == 1) { LIST_REMOVE(valid_entry, next); rte_free(valid_entry); } else { rte_free(valid_entry

Re: [dpdk-dev] [RFC] eal: adjust barriers for IO on Armv8-a

2020-05-11 Thread Ruifeng Wang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, May 12, 2020 2:07 AM > To: dev@dpdk.org; jer...@marvell.com; hemant.agra...@nxp.com; Ajit > Khaparde (ajit.khapa...@broadcom.com) ; > igo...@amazon.com; tho...@monjalon.net; viachesl...@mellanox.com; > arybche...@solarfla

Re: [dpdk-dev] [PATCH] doc: fix wrong multicast filter flag

2020-05-11 Thread Ye Xiaolong
On 05/08, Qiming Yang wrote: >Multicast MAC filter flag means device ops set_mc_addr_list support >or not. This patch fixes the wrong flag value in intel driver's document. > >Fixes: 9db3f52126fb ("doc: generate NIC overview table from ini files") >Fixes: cb25d4323fbf ("net/avf: enable MAC VLAN and

Re: [dpdk-dev] [PATCH] net/iavf: delete unused value

2020-05-11 Thread Ye Xiaolong
On 05/11, Leyi Rong wrote: >Fix coverity defects of unused value. > >Coverity issue: 357745, 357769 > >Fixes: b8b4c54ef9b0 ("net/iavf: support flexible Rx descriptor in normal path") > >Signed-off-by: Leyi Rong >--- > drivers/net/iavf/iavf_rxtx.c | 4 > 1 file changed, 4 deletions(-) > >diff -

Re: [dpdk-dev] [PATCH] examples/l2fwd/main.c: free resources in case of error

2020-05-11 Thread Jerin Jacob
On Tue, May 12, 2020 at 10:20 AM Varghese, Vipin wrote: > > snipped > > Subject: [PATCH] examples/l2fwd/main.c: free resources in case of error > > > > Bugzilla ID: 437 > > Cc: dev@dpdk.org > > Cc: sta...@dpdk.org > > Cc: bruce.richard...@intel.com > > Cc: vipin.vargh...@intel.com > > Cc: jgraj...

Re: [dpdk-dev] [PATCH v3] net/igc: fix memory illegal accesses

2020-05-11 Thread Ye Xiaolong
On 05/08, alvinx.zh...@intel.com wrote: >From: Alvin Zhang > >Fix some out-of-bounds memory issues, they may lead to wrong results >or affect application stability. > >Coverity issue: 357759, 357713 >Fixes: bd3fcf0d0fa1 (net/igc: support RSS) >Cc: sta...@dpdk.org > >Signed-off-by: Alvin Zhang >--

Re: [dpdk-dev] [PATCH] net/e1000: fix port hotplug for multi-process

2020-05-11 Thread Ye Xiaolong
On 04/29, alvinx.zh...@intel.com wrote: >From: Alvin Zhang Cc: sta...@dpdk.org > >Enable detach device on secondary process. > >Fixes: b9eee2cb8c29 (e1000: support port hotplug) >Cc: bernard.iremon...@intel.com >Cc: sta...@dpdk.org > >Signed-off-by: Alvin Zhang >--- > drivers/net/e1000/em_ethdev.

Re: [dpdk-dev] [PATCH] examples/l2fwd/main.c: free resources in case of error

2020-05-11 Thread Varghese, Vipin
snipped > Subject: [PATCH] examples/l2fwd/main.c: free resources in case of error > > Bugzilla ID: 437 > Cc: dev@dpdk.org > Cc: sta...@dpdk.org > Cc: bruce.richard...@intel.com > Cc: vipin.vargh...@intel.com > Cc: jgraj...@cisco.com > Signed-off-by: Muhammad Bilal > --- > examples/l2fwd/main.c |

Re: [dpdk-dev] [PATCH] net/e1000: fix port hotplug for multi-process

2020-05-11 Thread Jeff Guo
hi alvin On 5/12/2020 11:44 AM, Zhang, AlvinX wrote: Hi Jia, It shouldn't return error for secondary. 'rte_eth_dev_release_port()' has already process type in it, so returning '0' should work better which will cause some process specific variables cleared. In otherwise, only primary process n

Re: [dpdk-dev] [PATCH v2] crypto/caam_jr: fix wrong check of fd

2020-05-11 Thread Gagandeep Singh
> -Original Message- > From: wangyunjian > Sent: Monday, May 11, 2020 10:07 AM > To: dev@dpdk.org > Cc: Gagandeep Singh ; Hemant Agrawal > ; jerry.lili...@huawei.com; > xudin...@huawei.com; Yunjian Wang ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] crypto/caam_jr: fix wrong check

Re: [dpdk-dev] [PATCH] net/e1000: fix port hotplug for multi-process

2020-05-11 Thread Zhang, AlvinX
Hi Jia, It shouldn't return error for secondary. 'rte_eth_dev_release_port()' has already process type in it, so returning '0' should work better which will cause some process specific variables cleared. In otherwise, only primary process need to really close the device. BR, Alvin > -Origi

Re: [dpdk-dev] [PATCH v2] net/virtio: fix AVX512 datapath selection

2020-05-11 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, May 12, 2020 3:50 AM > To: Yigit, Ferruh ; Wang, Zhihong > ; Ye, Xiaolong ; Liu, > Yong > Cc: dev@dpdk.org; Thomas Monjalon ; David > Marchand ; Richardson, Bruce > ; Nicolau, Radu ; > Luca Boccassi > Subject: Re: [PATCH v2]

Re: [dpdk-dev] [PATCH] net/e1000: fix port hotplug for multi-process

2020-05-11 Thread Jeff Guo
hi, alvin On 4/29/2020 2:37 PM, alvinx.zh...@intel.com wrote: From: Alvin Zhang Enable detach device on secondary process. Fixes: b9eee2cb8c29 (e1000: support port hotplug) Cc: bernard.iremon...@intel.com Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/e1000/em_ethdev.c |

Re: [dpdk-dev] [PATCH] net/virtio: fix AVX512 datapath selection

2020-05-11 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Monday, May 11, 2020 10:47 PM > To: Liu, Yong ; Ye, Xiaolong ; > Yigit, Ferruh ; dev@dpdk.org > Cc: Maxime Coquelin > Subject: [PATCH] net/virtio: fix AVX512 datapath selection > > The AVX512 packed ring datapath selection was only

[dpdk-dev] [dpdk-announce] release candidate 20.05-rc2

2020-05-11 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v20.05-rc2 There are 286 new patches in this snapshot. Release notes: http://doc.dpdk.org/guides/rel_notes/release_20_05.html Highlights of 20.05-rc2: - rte_graph - telemetry rewo

Re: [dpdk-dev] net/iavf: fix rss algorithm configure issue

2020-05-11 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, May 12, 2020 10:18 AM > To: Guo, Jia ; Xing, Beilei ; Wu, > Jingjing > Cc: Ye, Xiaolong ; dev@dpdk.org > Subject: RE: [dpdk-dev] net/iavf: fix rss algorithm configure issue > > > > > -Original Message- > > From: Guo, J

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang

2020-05-11 Thread Xu, Ting
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, May 12, 2020 12:29 AM > To: Xu, Ting ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; sta...@dpdk.org; Andrew Rybchenko > ; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: fix DCB set

Re: [dpdk-dev] net/iavf: fix rss algorithm configure issue

2020-05-11 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Sunday, May 10, 2020 4:28 AM > To: Xing, Beilei ; Zhang, Qi Z ; > Wu, Jingjing > Cc: Ye, Xiaolong ; dev@dpdk.org; Guo, Jia > > Subject: [dpdk-dev] net/iavf: fix rss algorithm configure issue > > When configure rss rule, the etherdev rss h

[dpdk-dev] [PATCH v2] app/testpmd: fix DCB set failure

2020-05-11 Thread Ting Xu
When set DCB in testpmd, there is a segmentation fault. It is because the local variable rss_conf in get_eth_dcb_conf() is not cleared, so that the pointer member variable rss_key has a random address, which leads to an error in the following processing. This patch initialized the local variable rs

Re: [dpdk-dev] [PATCH v1 1/3] ethdev: remove extra 'new line' in output

2020-05-11 Thread Thomas Monjalon
07/05/2020 20:26, Ivan Dyukov: > This is testpmd part of new line cleanup > > Fixes: 002ade70e9 (app/test: measure cycles per packet in Rx/Tx) > Fixes: ce8d561418 (app/testpmd: add port configuration settings) > Cc: sta...@dpdk.org > > Acked-by: Andrew Rybchenko > Signed-off-by: Ivan Dyukov Se

[dpdk-dev] [PATCH] net/qede: fix link state configuration

2020-05-11 Thread Rasesh Mody
Move link state enable/disable to dev_start() and dev_stop() respectively. This will ensure when devices are stopped, link status will be appropriately shown as down. Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh Signed-off-by: R

Re: [dpdk-dev] [pull-request] next-crypto 20.05 rc2

2020-05-11 Thread Thomas Monjalon
11/05/2020 13:21, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks > Arek Kusztal (4): > crypto/qat: fix computation of cd ptr in zuc and snow > doc: fix missing release notes for AES GCM J0 in QAT > cryptodev: add chacha20-poly1305 aead algorithm >

Re: [dpdk-dev] [PATCH v2] net/virtio: fix AVX512 datapath selection

2020-05-11 Thread Ferruh Yigit
On 5/11/2020 8:49 PM, Maxime Coquelin wrote: > > > On 5/11/20 8:48 PM, Ferruh Yigit wrote: >> From: Maxime Coquelin >> >> The AVX512 packed ring datapath selection was only done >> at build time, but it should also be checked at runtime >> that the CPU supports it. >> >> This patch add a CPU fla

Re: [dpdk-dev] [PATCH] test/flow-classify: fix failure on dual socket systems

2020-05-11 Thread David Marchand
On Fri, May 1, 2020 at 1:07 PM Harry van Haaren wrote: > > This commit fixes failures of the flow_classify_autotest when > ran on dual-socket servers, as the sample application does not > support more than a single socket. Increasing the NB_SOCKETS > value allows the test to run successfully. > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix match on empty VLAN item in DV mode

2020-05-11 Thread Ferruh Yigit
On 5/11/2020 7:19 PM, Dekel Peled wrote: > Repo link: > https://git.dpdk.org/next/dpdk-next-net-mlx/commit/?id=40513808b165f7436389bfffcc8a35dbdc93121c I mean as following: commit 40513808b165 ("doc: refine ethernet and VLAN flow rule items") > > Regards, > Dekel > >> -Original Message-

Re: [dpdk-dev] [PATCH v5 0/4] Support ipv6 flow rules

2020-05-11 Thread Ferruh Yigit
On 5/11/2020 8:04 PM, Ferruh Yigit wrote: > On 5/9/2020 5:04 AM, Xiaoyun wang wrote: >> This patch adds jumbo frame offload flag, increases >> judgment whether Tx/Rx queues is non-null when free >> resources, and if card mode does not support nic, >> driver will be initialized failed, supports ipv

Re: [dpdk-dev] [PATCH v5 4/4] net/hinic/base: support ipv6 flow rules

2020-05-11 Thread Ferruh Yigit
On 5/9/2020 5:04 AM, Xiaoyun wang wrote: > The patch supports ipv6 flow rules for BGP or ICMP packets. > > Signed-off-by: Xiaoyun wang > --- > drivers/net/hinic/hinic_pmd_ethdev.h | 57 +- > drivers/net/hinic/hinic_pmd_flow.c | 209 > --- > 2 files cha

Re: [dpdk-dev] [PATCH v2] net/virtio: fix AVX512 datapath selection

2020-05-11 Thread Maxime Coquelin
On 5/11/20 8:48 PM, Ferruh Yigit wrote: > From: Maxime Coquelin > > The AVX512 packed ring datapath selection was only done > at build time, but it should also be checked at runtime > that the CPU supports it. > > This patch add a CPU flags check so that non-vectorized > path is selected at r

Re: [dpdk-dev] [PATCH] app/test: allow building with bonding net driver disabled

2020-05-11 Thread Thomas Monjalon
04/05/2020 21:26, Lukasz Wojciechowski: > W dniu 01.05.2020 o 17:05, Bruce Richardson pisze: > > The autotest application build was partially enabled for building with > > the net/bond driver disabled, but a number of items were missed, leading > > to build errors when the driver was disabled, e.g.

Re: [dpdk-dev] [PATCH v3] l3fwd-power: add Rx interrupt timeout

2020-05-11 Thread Thomas Monjalon
07/05/2020 12:46, Anatoly Burakov: > Currently, thread waiting on an interrupt does not have a timeout, so > it will not ever wake up until traffic arrives. This means that, when > time comes to exit the application, it will not quit unless there > happens to be traffic coming in and waking up the

Re: [dpdk-dev] [PATCH v3 1/4] ring: fix build for gcc O1 optimization

2020-05-11 Thread Thomas Monjalon
11/05/2020 18:07, Ferruh Yigit: > Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using > gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) Series applied, thanks

Re: [dpdk-dev] [PATCH v5 1/4] net/hinic: increase Tx/Rx queues non-null judgment

2020-05-11 Thread Ferruh Yigit
On 5/9/2020 5:04 AM, Xiaoyun wang wrote: > Increase tx_queues and rx_queues non-null judgment before free tx or > rx resources, and modify some formate for logs. The fix is small, but it is lost in the format/syntax changes, can you please seperate the fix. Btw, fix is adding null check for point

Re: [dpdk-dev] [PATCH v5 0/4] Support ipv6 flow rules

2020-05-11 Thread Ferruh Yigit
On 5/9/2020 5:04 AM, Xiaoyun wang wrote: > This patch adds jumbo frame offload flag, increases > judgment whether Tx/Rx queues is non-null when free > resources, and if card mode does not support nic, > driver will be initialized failed, supports ipv6 > flow director for BGP or ICMP packets. > >

[dpdk-dev] [PATCH v2] net/virtio: fix AVX512 datapath selection

2020-05-11 Thread Ferruh Yigit
From: Maxime Coquelin The AVX512 packed ring datapath selection was only done at build time, but it should also be checked at runtime that the CPU supports it. This patch add a CPU flags check so that non-vectorized path is selected at runtime if AVX512 is not supported. Also in meson build ena

Re: [dpdk-dev] [PATCH v6 3/3] timer: support EAL functions on Windows

2020-05-11 Thread Dmitry Kozlyuk
On Sun, 10 May 2020 15:03:05 +0300 Fady Bader wrote: > Implemented the needed Windows eal timer functions. > > Signed-off-by: Fady Bader > --- > lib/librte_eal/common/meson.build | 1 + > lib/librte_eal/windows/eal.c| 6 +++ > lib/librte_eal/windows/eal_timer.c | 86 >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix match on empty VLAN item in DV mode

2020-05-11 Thread Dekel Peled
Repo link: https://git.dpdk.org/next/dpdk-next-net-mlx/commit/?id=40513808b165f7436389bfffcc8a35dbdc93121c Regards, Dekel > -Original Message- > From: Ferruh Yigit > Sent: Monday, May 11, 2020 8:19 PM > To: Dekel Peled ; Matan Azrad > ; Slava Ovsiienko ; > Raslan Darawsheh > Cc: dev@dpd

[dpdk-dev] [RFC] eal: adjust barriers for IO on Armv8-a

2020-05-11 Thread Honnappa Nagarahalli
Change the barrier APIs for IO to reflect that Armv8-a is other-multi-copy atomicity memory model. Armv8-a memory model has been strengthened to require other-multi-copy atomicity. This property requires memory accesses from an observer to become visible to all other observers simultaneously [3].

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix match on empty VLAN item in DV mode

2020-05-11 Thread Ferruh Yigit
On 5/5/2020 1:57 PM, Dekel Peled wrote: > In existing implementation, using wild card VLAN item is not allowed. > A VLAN item in flow pattern must include VLAN ID (vid) value. > This obligation contradics the intention of documentation update [1]. At this perspective it is not "documentation updat

Re: [dpdk-dev] [PATCH] telemetry: fix error log output

2020-05-11 Thread David Marchand
On Mon, May 11, 2020 at 6:38 PM Bruce Richardson wrote: > > On Mon, May 11, 2020 at 05:09:31PM +0200, David Marchand wrote: > > Caught while running testpmd: > > No telemetry legacy support- No legacy callbacks, legacy socket not > > createdInteractive-mode selected > > > > Add missing \n. > > >

Re: [dpdk-dev] [PATCH v2] doc: remove Intel PMD examples in flow bifurcation guide

2020-05-11 Thread Ferruh Yigit
On 5/8/2020 3:54 PM, Stephen Hemminger wrote: > On Fri, 8 May 2020 16:48:23 +0800 > Xiaolong Ye wrote: > >> Now this feature is no longer supported by kernel side, (i40e kernel >> driver doesn't support it from v2.3.2 and ixgbe kernel driver isn't >> guaranteed to support this feature as well in

Re: [dpdk-dev] [PATCH v2] net/ring: fix eth_dev device pointer on allocation

2020-05-11 Thread Ferruh Yigit
On 5/8/2020 12:00 PM, Ferruh Yigit wrote: > On 5/6/2020 7:09 PM, Gaetan Rivet wrote: >> When a net_ring device is allocated, its device pointer is not set >> before calling rte_eth_dev_probing_finish, which is incorrect. >> >> The following: >> commit: 96cb19521147 ("net/ring: use EAL APIs in PMD

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/eventdev_pipeline: fix segfault on exit

2020-05-11 Thread Thomas Monjalon
07/05/2020 12:07, Zhou, JunX W: > From: Van Haaren, Harry > > This commit fixes a segfault on exit by using Ctrl^C if the master lcore > > was also being used as a worker core. The root cause of the issue was > > that the interrupt handler was cleaning up resources such as the ethdev > > and event

Re: [dpdk-dev] [PATCH] telemetry: fix error log output

2020-05-11 Thread Bruce Richardson
On Mon, May 11, 2020 at 05:09:31PM +0200, David Marchand wrote: > Caught while running testpmd: > No telemetry legacy support- No legacy callbacks, legacy socket not > createdInteractive-mode selected > > Add missing \n. > > Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") > > Sig

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang

2020-05-11 Thread Ferruh Yigit
On 5/11/2020 11:25 AM, Ting Xu wrote: > When set DCB in testpmd by clang, there is a segmentation fault. > It is because the local variable rss_conf in get_eth_dcb_conf() > is not cleared, so that the pointer member variable rss_key has > a random address, which leads to an error in the following >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] examples/l2fwd-keepalive: fix packet drops limited mbufs

2020-05-11 Thread Thomas Monjalon
27/04/2020 16:57, Louise Kilheeney: > MBUF pool of size 8192 was causing packet loss when using four ports. To > fix this issue this patch specifies the number of MBUF's per port > instead of having one set MBUF pool size, this way it will adapt to any > number of ports. > > Fixes: e64833f2273a ("

Re: [dpdk-dev] [PATCH v3] crypto/qat: support DOCSIS AES-256

2020-05-11 Thread Akhil Goyal
In that case you should send only the incremental patch and add a Fixes reference to the original patch. > > These are the patches for QAT AES-256 DOCSIS along with the documentation > update (which was missing from previous version) > > Regards, > Mairtin > > -Original Message- > From

Re: [dpdk-dev] [PATCH] net/tap: fix compilation issue glibc < 2.24

2020-05-11 Thread Ferruh Yigit
On 5/10/2020 1:23 PM, Raslan Darawsheh wrote: > When trying to compile with glibc < 2.24 that doesn't > support SOL_NETLINK it will cause compilation failure: > > drivers/net/tap/tap_netlink.c:70:17: error: > 'SOL_NETLINK' undeclared (first use in this function) > setsockopt(fd, SOL_NETLINK, NE

Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

2020-05-11 Thread Ray Kinsella
Seems to be an issues on my side (see below). Everything that the ABI Compliance Checker 2.3 complains about has already been reported and suppressed in libabigail.ignore. Suggest you use libabigail going forward. Oddly enough Fedora 31 / ABI Compliance Checker 2.3 [root@xyz abi-check]# abi

[dpdk-dev] [PATCH v3 4/4] event/octeontx2: fix build for O1 optimization

2020-05-11 Thread Ferruh Yigit
Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc 7.3.0 Build error In file included from .../drivers/event/octeontx2/ot x2_evdev.c:15:0: .../drivers/event/octeontx2/otx2_evdev_stats.h: In function ‘otx2_sso_xstats_get’: .../drivers/event/octeontx2/otx2_evdev_stats.h:124:9:

[dpdk-dev] [PATCH v3 3/4] net/ena: fix build for O1 optimization

2020-05-11 Thread Ferruh Yigit
Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) Build error: .../drivers/net/ena/ena_ethdev.c: In function ‘eth_ena_dev_init’: .../drivers/net/ena/ena_ethdev.c:1815:20: error: ‘wd_state’ may be used uninitialized in this function

[dpdk-dev] [PATCH v3 2/4] mempool/octeontx2: fix build for gcc O1 optimization

2020-05-11 Thread Ferruh Yigit
Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) Build error: In file included from .../drivers/mempool/octeontx2/otx2_mempool.h:13, from .../drivers/mempool/octeontx2/otx2_mempool_ops.c:8: .../drivers/mempool/octeontx2/otx2_

[dpdk-dev] [PATCH v3 1/4] ring: fix build for gcc O1 optimization

2020-05-11 Thread Ferruh Yigit
Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) Two build errors: 1) In file included from .../build/include/rte_ring_elem.h:1093, from .../lib/librte_rcu/rte_rcu_qsbr.c:21: ../lib/librte_rcu/rte_rcu_qsbr.c: In function ‘rt

Re: [dpdk-dev] [PATCH] telemetry: fix build for armv7

2020-05-11 Thread David Marchand
On Mon, May 11, 2020 at 3:32 PM David Marchand wrote: > > telemetry can not depend on EAL anymore but it still wants to get arch > headers. > We directly point at the right source directories by using the same logic > than EAL. However the special case of armv7 has been missed. > > Fix this by def

Re: [dpdk-dev] [PATCH] net/virtio: fix AVX512 datapath selection

2020-05-11 Thread Ferruh Yigit
On 5/11/2020 3:47 PM, Maxime Coquelin wrote: > The AVX512 packed ring datapath selection was only done > at build time, but it should also be checked at runtime > that the CPU supports it. > > This patch add a CPU flags check so that non-vectorized > path is selected at runtime if AVX512 is not su

[dpdk-dev] [PATCH] telemetry: fix error log output

2020-05-11 Thread David Marchand
Caught while running testpmd: No telemetry legacy support- No legacy callbacks, legacy socket not createdInteractive-mode selected Add missing \n. Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") Signed-off-by: David Marchand --- lib/librte_telemetry/telemetry.c | 8 1

Re: [dpdk-dev] [PATCH v2] raw/ioat: add ICX support

2020-05-11 Thread Thomas Monjalon
05/05/2020 18:07, Bruce Richardson: > On Wed, Apr 29, 2020 at 01:29:30PM +0100, Radu Nicolau wrote: > > Add support for Ice Lake IOAT DMA engine PCI Device ID. > > > > Signed-off-by: Radu Nicolau > > --- > > v2: squash commits, add description. > > > > drivers/raw/ioat/ioat_rawdev.c | 2 ++ > >

Re: [dpdk-dev] [PATCH v5 1/1] bus/pci: optimise scanning with whitelist/blacklist

2020-05-11 Thread David Marchand
On Sat, May 2, 2020 at 9:42 AM Sunil Kumar Kori wrote: > > rte_bus_scan API scans all the available PCI devices irrespective of white > or black listing parameters then further devices are probed based on white > or black listing parameters. So unnecessary CPU cycles are wasted during > rte_pci_sc

Re: [dpdk-dev] [PATCH 1/2] remove references to private PCI probe function

2020-05-11 Thread David Marchand
On Wed, May 6, 2020 at 2:43 PM David Marchand wrote: > > rte_pci_probe() is private to the PCI bus. > Clean the remaining references in the documentation and comments. > > Fixes: c752998b5e2e ("pci: introduce library and driver") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Reviewed-b

Re: [dpdk-dev] [PATCH v3] mem: fix the alloc size roundup overflow

2020-05-11 Thread David Marchand
On Thu, May 7, 2020 at 10:03 AM Bing Zhao wrote: > > The size checking is done in the caller. The size parameter is an > unsigned (64b wide) right now, so the comparison with zero should be > enough in most cases. But it won't help in the following case. > If the allocating request input a huge nu

[dpdk-dev] [PATCH] net/virtio: fix AVX512 datapath selection

2020-05-11 Thread Maxime Coquelin
The AVX512 packed ring datapath selection was only done at build time, but it should also be checked at runtime that the CPU supports it. This patch add a CPU flags check so that non-vectorized path is selected at runtime if AVX512 is not supported. Fixes: ccb10995c2ad ("net/virtio: add election

Re: [dpdk-dev] [PATCH 1/2] common/octeontx2: move internal symbols to INTERNAL section

2020-05-11 Thread Thomas Monjalon
11/05/2020 12:00, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > Move the internal symbols to INTERNAL sections so that any > change in them is not reported as ABI breakage. > > Signed-off-by: Pavan Nikhilesh > --- > drivers/common/octeontx2/otx2_common.h | 8 > driv

Re: [dpdk-dev] [PATCH v2 1/9] cryptodev: add feature flag for non-byte aligned data

2020-05-11 Thread De Lara Guarch, Pablo
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Monday, May 11, 2020 11:05 AM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: ruifeng.w...@arm.com; Doherty, Declan ; > asoma...@amd.com; ano...@marvell.com; Zhang, Roy Fan > ; Trahe, Fiona ; > rnagadhee...@marvell.com; adwiv...@

Re: [dpdk-dev] [PATCH v2] bus/pci: set boot-up log prints to absolute minimum

2020-05-11 Thread Thomas Monjalon
07/05/2020 17:36, Thomas Monjalon: > 07/05/2020 15:54, Jerin Jacob: > > On Mon, May 4, 2020 at 6:56 PM wrote: > > > > > > From: Jerin Jacob > > > > > > Some machines may have a lot of PCI devices and all of them are > > > not bound to DPDK. In such case the logs from EAL creates a lot of > > > cl

Re: [dpdk-dev] [PATCH] net/mlx5: support match on GTP flags

2020-05-11 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dekel Peled > Sent: Wednesday, May 6, 2020 8:14 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: support match on GTP flags > > This patch adds to MLX5 PMD the support of matching on > GTP header

Re: [dpdk-dev] [PATCH] telemetry: fix build for armv7

2020-05-11 Thread Bruce Richardson
On Mon, May 11, 2020 at 03:58:47PM +0200, David Marchand wrote: > On Mon, May 11, 2020 at 3:47 PM Bruce Richardson > wrote: > > > > On Mon, May 11, 2020 at 03:32:12PM +0200, David Marchand wrote: > > > telemetry can not depend on EAL anymore but it still wants to get arch > > > headers. > > > We d

Re: [dpdk-dev] [PATCH v3] crypto/qat: support DOCSIS AES-256

2020-05-11 Thread O'loingsigh, Mairtin
These are the patches for QAT AES-256 DOCSIS along with the documentation update (which was missing from previous version) Regards, Mairtin -Original Message- From: Akhil Goyal Sent: Monday, May 11, 2020 2:14 PM To: O'loingsigh, Mairtin ; Trahe, Fiona Cc: dev@dpdk.org Subject: RE: [P

Re: [dpdk-dev] [PATCH] telemetry: fix build for armv7

2020-05-11 Thread David Marchand
On Mon, May 11, 2020 at 3:47 PM Bruce Richardson wrote: > > On Mon, May 11, 2020 at 03:32:12PM +0200, David Marchand wrote: > > telemetry can not depend on EAL anymore but it still wants to get arch > > headers. > > We directly point at the right source directories by using the same logic > > than

Re: [dpdk-dev] [PATCH] net/mlx5: fix TxQ release debug log timing

2020-05-11 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, May 6, 2020 9:11 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > > Subject: [PATCH] net/mlx5: fix TxQ release debug log timing > > Program received signal SIGSEGV, Segm

Re: [dpdk-dev] [PATCH] telemetry: fix build for armv7

2020-05-11 Thread Bruce Richardson
On Mon, May 11, 2020 at 03:32:12PM +0200, David Marchand wrote: > telemetry can not depend on EAL anymore but it still wants to get arch > headers. > We directly point at the right source directories by using the same logic > than EAL. However the special case of armv7 has been missed. > No object

[dpdk-dev] [PATCH] eal: fix epoll fd list rebuild

2020-05-11 Thread Harman Kalra
An issue has been observed where epoll file descriptor list rebuilds every time an interrupt/alarm event is received. eal_intr_process_interrupts() should notify pipe fd only if any source is removed from the source list i.e (rv > 0) Fixes: 0c7ce182a760 ("eal: add pending interrupt callback unreg

Re: [dpdk-dev] [PATCH] net/mlx4: fix drop queue mem alloc failure handle

2020-05-11 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, May 6, 2020 7:28 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx4: fix drop queue mem alloc failure > handle > > The function mlx4_drop_get

[dpdk-dev] [PATCH] telemetry: fix build for armv7

2020-05-11 Thread David Marchand
telemetry can not depend on EAL anymore but it still wants to get arch headers. We directly point at the right source directories by using the same logic than EAL. However the special case of armv7 has been missed. Fix this by defaulting ARCH_DIR to RTE_ARCH. Caught on OBS: [ 162s] SYMLINK-FIL

Re: [dpdk-dev] [PATCH v3] crypto/qat: support DOCSIS AES-256

2020-05-11 Thread Akhil Goyal
I believe this patch is already applied. Why is it recent?

Re: [dpdk-dev] [PATCH v3] doc: QAT support for AES-256 DOCSIS

2020-05-11 Thread Akhil Goyal
> > Update QAT pmd to support AES-256 DOCSIS > > Signed-off-by: Mairtin o Loingsigh > --- Release note should be part of the patch which is supporting the feature.

Re: [dpdk-dev] [PATCH 1/2] crypto/dpaa_sec: improve memory freeing

2020-05-11 Thread Lukasz Wojciechowski
W dniu 11.05.2020 o 12:20, Akhil Goyal pisze: >> W dniu 09.05.2020 o 23:58, Akhil Goyal pisze: >>> Hi Lukasz, >>> >>> Thanks for the detailed analysis. >>> Series >>> Acked-by: Akhil Goyal >>> >>> Applied to dpdk-next-crypto >>> >>> Thanks. >> I am a fan of big commit messages. Just let me know

Re: [dpdk-dev] [PATCH v3] test/crypto: add AES-256 DOCSIS test vectors

2020-05-11 Thread Akhil Goyal
Hi Mairtin, I believe your patch is not rebased on top of current tree. There is no pmd_mask now. Also, I see that the AES 256 cases are already there. This patch is already there I guess. > static const uint8_t > cipher_aescbc_offset_16[] = { > 0x57, 0x68, 0x61, 0x74, 0x20, 0x61, 0x20

Re: [dpdk-dev] [PATCH] net/mlx5: fix meter color register consideration

2020-05-11 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, May 6, 2020 7:24 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix meter color register consideration > > The mlx5_flow_get_reg_id() f

Re: [dpdk-dev] [RFC] hash: unify crc32 API header for x86 and ARM

2020-05-11 Thread Pavan Nikhilesh Bhagavatula
>> >> >> >> From: Pavan Nikhilesh >> >> >> >> >> >> >> >> Merge crc32 hash calculation public API headers for x86 and >> >ARM, >> >> >> >> split implementations of x86 and ARM into their respective >> >private >> >> >> >> headers. >> >> >> >> This reduces the ifdef code clutter while keeping curre

Re: [dpdk-dev] [RFC] hash: unify crc32 API header for x86 and ARM

2020-05-11 Thread Ananyev, Konstantin
> > >> >> >> From: Pavan Nikhilesh > >> >> >> > >> >> >> Merge crc32 hash calculation public API headers for x86 and > >ARM, > >> >> >> split implementations of x86 and ARM into their respective > >private > >> >> >> headers. > >> >> >> This reduces the ifdef code clutter while keeping current AB

Re: [dpdk-dev] [PATCH v3 1/2] crypto/zuc: support IPSec Multi-buffer lib v0.54

2020-05-11 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, May 11, 2020 10:14 AM > To: akhil.go...@nxp.com > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v3 1/2] crypto/zuc: support IPSec Multi-buffer lib v0.54 > > The latest version of the Intel IPSec Multi-bu

Re: [dpdk-dev] [PATCH v6 2/5] app/flow-perf: add insertion rate calculation

2020-05-11 Thread Andrew Rybchenko
On 5/11/20 2:09 PM, Wisam Jaddo wrote: > Add insertion rate calculation feature into flow > performance application. > > The application now provide the ability to test > insertion rate of specific rte_flow rule, by > stressing it to the NIC, and calculate the > insertion rate. > > The applicatio

Re: [dpdk-dev] [PATCH v6 1/5] app/flow-perf: add flow performance skeleton

2020-05-11 Thread Andrew Rybchenko
On 5/11/20 2:09 PM, Wisam Jaddo wrote: > Add flow performance application skeleton. > > Signed-off-by: Wisam Jaddo Reviewed-By: Andrew Rybchenko

[dpdk-dev] [PATCH v2] event/dsw: update release notes

2020-05-11 Thread Mattias Rönnblom
Update release notes with recent DSW event device improvements. Signed-off-by: Mattias Rönnblom --- doc/guides/rel_notes/release_20_05.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst index 82df72

Re: [dpdk-dev] [PATCH v4] net/mlx5: fix matching for UDP tunnels with verbs

2020-05-11 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Raslan Darawsheh > Sent: Wednesday, May 6, 2020 9:58 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Ori Kam ; sta...@dpdk.org > Subject: [PATCH v4] net/mlx5: fix matching for UDP tunnels with verbs > > When creating flow rule with zero spec

[dpdk-dev] [pull-request] next-crypto 20.05 rc2

2020-05-11 Thread Akhil Goyal
The following changes since commit 205032bbfcf09a1fd9bea715eafb5c97ca73772c: service: relax barriers with C11 atomics (2020-05-11 13:21:54 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 6488cc1cfac29633b6d0b646e8e76b4

Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

2020-05-11 Thread Akhil Goyal
Hi Ray, I have applied the series on dpdk-next-crypto as per your validation of ABI. Thomas, Please validate this series at your end before applying to master. I am not too sure on the ABI stuff. Regards, Akhil > -Original Message- > From: Akhil Goyal > Sent: Monday, May 11, 2020 1:48

Re: [dpdk-dev] [PATCH] test/ring: code rework to reduce compilation time

2020-05-11 Thread Ananyev, Konstantin
> > > > > > > > > > > > > > > > > > > > > Hi Konstantin, > > > > > > > > > > > I like the way the tests are organized and it looks > > good. > > > > > > > > > > > > > > > > > > > > > > I am just wondering about the way it is being tested here. > > > > > > > > > > > The intent to write the test ca

[dpdk-dev] [PATCH] examples/l2fwd/main.c: free resources in case of error

2020-05-11 Thread Muhammad Bilal
Bugzilla ID: 437 Cc: dev@dpdk.org Cc: sta...@dpdk.org Cc: bruce.richard...@intel.com Cc: vipin.vargh...@intel.com Cc: jgraj...@cisco.com Signed-off-by: Muhammad Bilal --- examples/l2fwd/main.c | 72 ++- 1 file changed, 57 insertions(+), 15 deletions(-) dif

Re: [dpdk-dev] [PATCH v6 0/6] use c11 atomics for service core lib

2020-05-11 Thread David Marchand
On Wed, May 6, 2020 at 5:28 PM Phil Yang wrote: > > The rte_atomic ops and rte_smp barriers enforce DMB barriers on aarch64. > Using c11 atomics with explicit memory ordering instead of the rte_atomic > ops and rte_smp barriers for inter-threads synchronization can uplift the > performance on aarc

Re: [dpdk-dev] [PATCH] ipsec: fix unchecked return value

2020-05-11 Thread Akhil Goyal
> > Explicitly check return value in add_specific() > > CID 357760 (#2 of 2): Negative array index write (NEGATIVE_RETURNS) > > 8. negative_returns: Using variable ret as an index to array sad->cnt_arr > > > > Fixes: b2ee26926775 ("ipsec: add SAD add/delete/lookup implementation") > > Cc: sta...

Re: [dpdk-dev] [PATCH v2] test/service: add perf test for service on app lcore

2020-05-11 Thread David Marchand
On Wed, May 6, 2020 at 7:15 PM Harry van Haaren wrote: > > This commit adds a basic test to check the cycle cost > of related to calling into a service. > > Signed-off-by: Harry van Haaren Tested-by: Phil Yang Reviewed-by: Phil Yang Restored output to v1 format following Phil comment. Applie

[dpdk-dev] [PATCH v6 5/5] app/flow-perf: add packet forwarding support

2020-05-11 Thread Wisam Jaddo
Introduce packet forwarding support to the app to do some performance measurements. The measurements are reported in term of packet per second unit. The forwarding will start after the end of insertion/deletion operations. The support has single and multi performance measurements. Signed-off-by:

[dpdk-dev] [PATCH v6 3/5] app/flow-perf: add deletion rate calculation

2020-05-11 Thread Wisam Jaddo
Add the ability to test deletion rate for flow performance application. This feature is disabled by default, and can be enabled by add "--deletion-rate" in the application command line options. Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 87 ++

[dpdk-dev] [PATCH v6 4/5] app/flow-perf: add memory dump to app

2020-05-11 Thread Wisam Jaddo
Introduce new feature to dump memory statistics of each socket and a total for all before and after the creation. This will give two main advantage: 1- Check the memory consumption for large number of flows "insertion rate scenario alone" 2- Check that no memory leackage after doing insertion the

[dpdk-dev] [PATCH v6 2/5] app/flow-perf: add insertion rate calculation

2020-05-11 Thread Wisam Jaddo
Add insertion rate calculation feature into flow performance application. The application now provide the ability to test insertion rate of specific rte_flow rule, by stressing it to the NIC, and calculate the insertion rate. The application offers some options in the command line, to configure w

[dpdk-dev] [PATCH v6 0/5] Introduce flow perf application

2020-05-11 Thread Wisam Jaddo
Add new application to test rte flow performance from: - Insertion rate. - Deletion rate. - Memory consumption. - PPS forward measurement. --- v6: * Move compare vs 0 logic instead of logical not. * Logged errors into stderr. * Remove offload parse on queue level. * Fix documentation and limitatio

[dpdk-dev] [PATCH v6 1/5] app/flow-perf: add flow performance skeleton

2020-05-11 Thread Wisam Jaddo
Add flow performance application skeleton. Signed-off-by: Wisam Jaddo --- MAINTAINERS| 5 + app/Makefile | 1 + app/meson.build| 1 + app/test-flow-perf/Makefile| 23 +++ app/test-flow-perf/config.h

[dpdk-dev] [PATCH v6 5/5] app/flow-perf: add packet forwarding support

2020-05-11 Thread Wisam Jaddo
Introduce packet forwarding support to the app to do some performance measurements. The measurements are reported in term of packet per second unit. The forwarding will start after the end of insertion/deletion operations. The support has single and multi performance measurements. Signed-off-by:

Re: [dpdk-dev] [PATCH] ipsec: fix unchecked return value

2020-05-11 Thread Ananyev, Konstantin
> Explicitly check return value in add_specific() > CID 357760 (#2 of 2): Negative array index write (NEGATIVE_RETURNS) > 8. negative_returns: Using variable ret as an index to array sad->cnt_arr > > Fixes: b2ee26926775 ("ipsec: add SAD add/delete/lookup implementation") > Cc: sta...@dpdk.org > >

  1   2   >