Re: [dpdk-dev] [PATCH] build: add arm 32bit cross compilation to Meson

2020-04-13 Thread Juraj Linkeš
Hi Bruce, -Original Message- From: Bruce Richardson Sent: Friday, April 10, 2020 11:46 AM To: Juraj Linkeš Cc: dev@dpdk.org Subject: Re: [PATCH] build: add arm 32bit cross compilation to Meson On Thu, Apr 09, 2020 at 04:14:48PM +0200, Juraj Linkeš wrote: > * Add arm-linux-gnueabihf cro

[dpdk-dev] [PATCH v8] net/i40e: enable advanced RSS

2020-04-13 Thread Chenxu Di
This patch supports: - symmetric hash configuration - Input set configuration Signed-off-by: Chenxu Di --- doc/guides/nics/i40e.rst | 35 ++ doc/guides/rel_notes/release_20_05.rst | 7 + drivers/net/i40e/i40e_ethdev.c | 509 ++--- drivers/net/i40e/i4

Re: [dpdk-dev] i40eVF pmd vlan id handling

2020-04-13 Thread Xing, Beilei
Hi Souvik, With kernel PF + DPDK VF, enable vlan filter and disable vlan strip on VF side, is this your requirement? If yes, I think you can do . vlan_offload_set after doing . vlan_filter_set on VF side. BR, Beilei From: Dey, Souvik Sent: Tuesday, April 14, 2020 4:04 AM To: dev@dpdk.org; us.

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset

2020-04-13 Thread Zhang, XuemingX
Tested-by: Zhang, XuemingX >-Original Message- >From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shougang Wang >Sent: Monday, April 13, 2020 9:39 AM >To: dev@dpdk.org >Cc: Lu, Wenzhuo ; Yang, Qiming >; Wang, ShougangX ; >sta...@dpdk.org >Subject: [dpdk-dev] [PATCH] net/ixgbe: fix lin

[dpdk-dev] [PATCH v4 11/11] net/iavf: add RSS hash parsing in SSE path

2020-04-13 Thread Leyi Rong
Support RSS hash parsing from Flex Rx descriptor in SSE data path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_sse.c | 86 ++-- 1 file changed, 70 insertions(+), 16 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/iavf_rx

[dpdk-dev] [PATCH v4 10/11] net/iavf: add RSS hash parsing in AVX path

2020-04-13 Thread Leyi Rong
Support RSS hash parsing from Flex Rx descriptor in AVX data path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 92 ++- 1 file changed, 90 insertions(+), 2 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf/iavf_rx

[dpdk-dev] [PATCH v4 09/11] net/iavf: support flow mark in SSE path

2020-04-13 Thread Leyi Rong
Support Flow Director mark ID parsing from Flex Rx descriptor in SSE path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_sse.c | 52 +++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/i

[dpdk-dev] [PATCH v4 08/11] net/iavf: support flow mark in AVX path

2020-04-13 Thread Leyi Rong
Support Flow Director mark ID parsing from Flex Rx descriptor in AVX path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 72 +-- 1 file changed, 67 insertions(+), 5 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf

[dpdk-dev] [PATCH v4 05/11] net/iavf: flexible Rx descriptor support in SSE path

2020-04-13 Thread Leyi Rong
Support flexible Rx descriptor format in SSE path of iAVF PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c | 4 +- drivers/net/iavf/iavf_rxtx.h | 5 + drivers/net/iavf/iavf_rxtx_vec_sse.c | 414 +++ 3 files changed, 421 insertions(+), 2 d

[dpdk-dev] [PATCH v4 07/11] net/iavf: support flow mark in normal data path

2020-04-13 Thread Leyi Rong
Support Flow Director mark ID parsing in normal path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf.h | 3 +++ drivers/net/iavf/iavf_rxtx.c | 37 2 files changed, 40 insertions(+) diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h inde

[dpdk-dev] [PATCH v4 06/11] net/iavf: add flow director enabled switch value

2020-04-13 Thread Leyi Rong
The commit adds fdir_enabled flag into iavf_rx_queue structure to identify if fdir id is active. Rx data path can be benefit if fdir id parsing is not needed, especially in vector path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf.h | 1 + drivers/net/iavf/iavf_rxtx.h | 30 ++

[dpdk-dev] [PATCH v4 04/11] net/iavf: flexible Rx descriptor support in AVX path

2020-04-13 Thread Leyi Rong
Support flexible Rx descriptor format in AVX path of iAVF PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c | 24 +- drivers/net/iavf/iavf_rxtx.h | 6 + drivers/net/iavf/iavf_rxtx_vec_avx2.c | 550 +- 3 files changed, 570 insertions(+), 1

[dpdk-dev] [PATCH v4 03/11] net/iavf: flexible Rx descriptor support in normal path

2020-04-13 Thread Leyi Rong
Support flexible Rx descriptor format in normal path of iAVF PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf.h| 2 + drivers/net/iavf/iavf_ethdev.c | 8 + drivers/net/iavf/iavf_rxtx.c | 479 ++--- drivers/net/iavf/iavf_rxtx.h | 8 + drivers/n

[dpdk-dev] [PATCH v4 00/11] framework for advanced iAVF PMD

2020-04-13 Thread Leyi Rong
This patchset enable framework for advanced iAVF, includes flexible descriptor support, FDIR mark id and RSS hash support. --- v4: - Avoid initial declaration in 'for' loop to backward-compatible with older gcc versions. v3: - Remove patch to query DDP package info as it's specific to DCF. - Sp

[dpdk-dev] [PATCH v4 02/11] net/iavf: return error if opcode is mismatched

2020-04-13 Thread Leyi Rong
Adds error return when the opcode of read message is mismatched which is received from adminQ. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_vchnl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index fa4

[dpdk-dev] [PATCH v4 01/11] net/iavf: flexible Rx descriptor definitions

2020-04-13 Thread Leyi Rong
Add definitions for flexible Rx descriptor structures and macros. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.h | 200 +++ 1 file changed, 200 insertions(+) diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index 09b5bd99e..5e30

[dpdk-dev] [PATCH] net/memif: implement promisc enable/disable

2020-04-13 Thread Jakub Grajciar
implement promisc enable/disable for memif PMD Signed-off-by: Jakub Grajciar --- drivers/net/memif/rte_eth_memif.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 81d71c53a..d138ec89e 100644 --- a/

Re: [dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU type

2020-04-13 Thread Ori Kam
Hi Jeff, No problem about the review. I will see v3 right? From: Jeff Guo Sent: Tuesday, April 14, 2020 6:06 AM To: Ori Kam ; xiaolong...@intel.com; qi.z.zh...@intel.com Cc: dev@dpdk.org; jingjing...@intel.com; yahui@intel.com; simei...@intel.com Subject: Re: [dpdk-dev] [dpdk-dev v2 3/4] app/

[dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting

2020-04-13 Thread Marvin Liu
When doing virtio device initialization, virtqueues will be reset in server mode if ring type is packed. This will cause issue because queues have been freed in the beginning of device initialization. Fix this issue by splitting device initial process and device reinit process. Virt queues won't b

Re: [dpdk-dev] [PATCH dpdk-dev] rte_random: fix crash when random init

2020-04-13 Thread Tonghao Zhang
On Tue, Apr 14, 2020 at 12:07 PM Stephen Hemminger wrote: > > On Sun, 12 Apr 2020 16:27:53 +0800 > xiangxia.m@gmail.com wrote: > > > From: Tonghao Zhang > > > > When rte_rand_init is invoked, and the kernel > > (kernel version < 3.17) running dpdk does't support > > *getentropy, at the same t

Re: [dpdk-dev] [PATCH v3 9/9] ring: add C11 memory model for new sync modes

2020-04-13 Thread Honnappa Nagarahalli
Hi Konstantin, It would be good to blend this commit with the other commits. Few comments inline. > Subject: [PATCH v3 9/9] ring: add C11 memory model for new sync modes > > Add C11 atomics based implementation for RTS and HTS head/tail update > primitivies. > > Signed-off-by: Konstant

Re: [dpdk-dev] [PATCH dpdk-dev] rte_random: fix crash when random init

2020-04-13 Thread Stephen Hemminger
On Sun, 12 Apr 2020 16:27:53 +0800 xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > When rte_rand_init is invoked, and the kernel > (kernel version < 3.17) running dpdk does't support > *getentropy, at the same time, the cpu does't support > rdseed, the rte_rand_init will invoke rte_get

Re: [dpdk-dev] [PATCH v3 7/9] ring: introduce peek style API

2020-04-13 Thread Honnappa Nagarahalli
> > For rings with producer/consumer in RTE_RING_SYNC_ST, > RTE_RING_SYNC_MT_HTS mode, provide an ability to split enqueue/dequeue > operation into two phases: > - enqueue/dequeue start > - enqueue/dequeue finish > That allows user to inspect objects in the ring without removing them

Re: [dpdk-dev] [dpdk-dev v3 2/4] net/iavf: add RSS configuration for VFs

2020-04-13 Thread Jeff Guo
hi, qi On 4/13/2020 10:02 AM, Zhang, Qi Z wrote: Hi Jeff: -Original Message- From: Guo, Jia Sent: Saturday, April 11, 2020 8:10 AM To: Ye, Xiaolong ; Zhang, Qi Z Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui ; Su, Simei ; Guo, Jia Subject: [dpdk-dev v3 2/4] net/iavf: add RSS configur

[dpdk-dev] [PATCH v6 2/2] eal: support for VFIO-PCI VF token

2020-04-13 Thread Haiyue Wang
The kernel module vfio-pci introduces the VF token to enable SR-IOV support since 5.7. The VF token can be set by a vfio-pci based PF driver and must be known by the vfio-pci based VF driver in order to gain access to the device. An example VF token option would take this form: 1. Install vfio-p

[dpdk-dev] [PATCH v6 1/2] eal: add uuid dependent header files explicitly

2020-04-13 Thread Haiyue Wang
Add the dependent header files explicitly, so that the user just needs to include the 'rte_uuid.h' header file directly to avoid compile error: (1). rte_uuid.h:97:55: error: unknown type name ‘size_t’ (2). rte_uuid.h:58:2: error: implicit declaration of function ‘memcpy’ Signed-off-by: Haiyue Wa

[dpdk-dev] [PATCH v6 0/2] support for VFIO-PCI VF token interface

2020-04-13 Thread Haiyue Wang
v6: Drop the Fixes tag in uuid, since the file has been moved to another place, not suitable to apply on stable. And this is not a bug, just some kind of enhancement. v5: 1. Add the VF token parse error handling. 2. Split into two patches for different logic module. 3. Add more com

[dpdk-dev] [PATCH v5 1/2] eal: add uuid dependent header files explicitly

2020-04-13 Thread Haiyue Wang
Add the dependent header files explicitly, so that the user just needs to include the 'rte_uuid.h' header file directly to avoid compile error: (1). rte_uuid.h:97:55: error: unknown type name ‘size_t’ (2). rte_uuid.h:58:2: error: implicit declaration of function ‘memcpy’ Fixes: 6bc67c497a51 ("ea

[dpdk-dev] [PATCH v5 0/2] support for VFIO-PCI VF token interface

2020-04-13 Thread Haiyue Wang
v5: 1. Add the VF token parse error handling. 2. Split into two patches for different logic module. 3. Add more comments into the code for explaining the design. 4. Drop the ABI change workaround, this patch set focuses on code review. v4: 1. Ignore rte_vfio_setup_device ABI check sinc

[dpdk-dev] [PATCH v5 2/2] eal: support for VFIO-PCI VF token

2020-04-13 Thread Haiyue Wang
The kernel module vfio-pci introduces the VF token to enable SR-IOV support since 5.7. The VF token can be set by a vfio-pci based PF driver and must be known by the vfio-pci based VF driver in order to gain access to the device. An example VF token option would take this form: 1. Install vfio-p

Re: [dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU type

2020-04-13 Thread Jeff Guo
hi, Ori On 4/12/2020 5:58 PM, Ori Kam wrote: Hi Jeff, For some reason I got the mail in HTML format So please see my comments marked by [Ori] Thanks, Ori *From:* Jeff Guo *Sent:* Tuesday, April 7, 2020 8:37 AM *To:* Ori Kam ; xiaolong...@intel.com; qi.z.zh...@intel.com *Cc:* dev@dpdk.or

Re: [dpdk-dev] [PATCH 2/3] net/ice/base: add mask check when find switch recipe

2020-04-13 Thread Lu, Nannan
Tested-by: Lu, Nannan -Original Message- From: Zhao1, Wei Sent: Friday, April 10, 2020 8:42 AM To: dev@dpdk.org Cc: Zhang, Qi Z ; Lu, Nannan ; Peng, Yuan ; Zhao1, Wei Subject: [PATCH 2/3] net/ice/base: add mask check when find switch recipe In order to find accurate recipe for switch

[dpdk-dev] [PATCH] net/iavf: fix return value of stats get function

2020-04-13 Thread cheng.peng5
The iavf_dev_stats_get function should return ret instead of -eio. Signed-off-by: Peng Cheng --- drivers/net/iavf/iavf_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 34913f9..93ab121 100644 --- a/

Re: [dpdk-dev] [ovs-dev] OvS DPDK crash when HPET timer enabled

2020-04-13 Thread Tonghao Zhang
On Tue, Apr 14, 2020 at 7:20 AM Ilya Maximets wrote: > > On 4/13/20 5:27 PM, Ravi Kerur wrote: > > On Sun, Apr 12, 2020 at 5:05 AM Tonghao Zhang > > wrote: > > > >> On Sun, Apr 12, 2020 at 7:57 AM Ravi Kerur wrote: > >>> > >>> Hello OvS DPDK team, > >>> > >>> I am using OvS 2.13.90 and DPDK 19.1

Re: [dpdk-dev] [PATCH v2 06/13] baseband/fpga_5gnr_fec: add queue configuration

2020-04-13 Thread Chautru, Nicolas
Thanks Rosen for your thorough code review. Some comments in-line below. > From: Xu, Rosen > > Hi, > > Could you prefix all functions name with the FPGA IP name? FPGA is a very > common device name. > I don't see such a guideline being used across all other PMDs. Unsure it always help notab

Re: [dpdk-dev] [PATCH v3 5/9] ring: introduce HTS ring mode

2020-04-13 Thread Honnappa Nagarahalli
Hi Konstantin, Few nits/comments inline. > diff --git a/lib/librte_ring/rte_ring_hts.h b/lib/librte_ring/rte_ring_hts.h > new > file mode 100644 index 0..062d7be6c > --- /dev/null > +++ b/lib/librte_ring/rte_ring_hts.h > @@ -0,0 +1,210 @@ > +/* SPDX-License-Identifier: BSD-3-Cla

Re: [dpdk-dev] [ovs-dev] OvS DPDK crash when HPET timer enabled

2020-04-13 Thread Ilya Maximets
On 4/13/20 5:27 PM, Ravi Kerur wrote: > On Sun, Apr 12, 2020 at 5:05 AM Tonghao Zhang > wrote: > >> On Sun, Apr 12, 2020 at 7:57 AM Ravi Kerur wrote: >>> >>> Hello OvS DPDK team, >>> >>> I am using OvS 2.13.90 and DPDK 19.11 and wanted to use HPET timer >> instead >>> of invariant TSC. >>> >>> E

[dpdk-dev] [PATCH v2] net/bnx2x: add multicast MAC address filtering

2020-04-13 Thread Rasesh Mody
From: Souvik Dey Add support the set_mc_addr_list device operation in the bnx2xvf PMD. The configured addresses are stored in the device private area, so they can be flushed before adding new ones. Without this v6 multicast packets were properly forwarded to the Guest VF. v2: * Fixed the Wrong

[dpdk-dev] [PATCH v3] net/bnx2x: handle guest VLAN for SR-IOV case

2020-04-13 Thread Rasesh Mody
From: Souvik Dey In case of bnx2xvf pmd, tx packets can support vland id in 2 ways: 1. setting the mbuf ol_flags=PKT_TX_VLAN_PKT and passing the vlanid in mbuf->vlan_tci. 2. the tx packet itself has the vlan id included in the packet. The first case is working as expected but the second case wher

Re: [dpdk-dev] [PATCH v2 00/34] add support for host based flow table management

2020-04-13 Thread Thomas Monjalon
13/04/2020 21:39, Venkat Duvvuru: > This patchset introduces a new mechanism to allow host-memory based > flow table management. This should allow higher flow scalability > than what is currently supported. This new approach also defines a > new rte_flow parser, and mapper which currently supports

[dpdk-dev] [PATCH v4 1/2] common/mlx5: refactor multi-process IPC handling codes to common driver

2020-04-13 Thread Vu Pham
Refactor common multi-process handling codes from net PMD to common driver. Using tuple mp_id{name, port_id} as standard input parameter for all multi-process IPC APIs instead of using rte_eth_dev. Modify net PMD to use multi-process APIs from common driver. Signed-off-by: Vu Pham --- drivers/c

[dpdk-dev] [PATCH v4 2/2] common/mlx5: refactor memory management codes

2020-04-13 Thread Vu Pham
Refactor common memory btree and cache management to common driver. Replace some input parameters of MR APIs to more common datastructure like PD, port_id, share_cache,... so that muliptle PMD drivers can use those MR APIs. Modify mlx5 net pmd driver to use MR management APIs from common driver.

[dpdk-dev] [PATCH v4 0/2] refactor multi-process IPC and memory management codes to common driver

2020-04-13 Thread Vu Pham
Current mlx5 net PMD and future mlx5(regex,...) PMDs that run and share the same HCAs need to use common memory management driver. Memory management codes embeddedly use multi-process IPC for primary/secondary processes to register and sync on memory registrations MRs. That's the main reason to ref

[dpdk-dev] [PATCH v2 34/34] net/bnxt: enable meson build on truflow code

2020-04-13 Thread Venkat Duvvuru
Include tf_ulp & tf_core directories and the files inside them. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/meson.build | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/net/bnxt/meson.buil

Re: [dpdk-dev] i40eVF pmd vlan id handling

2020-04-13 Thread Dey, Souvik
On debugging further it looks like that linux driver enables vlan_striping by default when VIRTCHNL_OP_ADD_VLAN is sent to the PF. static int i40e_vc_add_vlan_msg(struct i40e_vf *vf, u8 *msg) { . i40e_vlan_stripping_enable(vsi); } Due to this when ever we enable vlan o

[dpdk-dev] [PATCH v2 33/34] net/bnxt: add support for injecting mark into packet’s mbuf

2020-04-13 Thread Venkat Duvvuru
When a flow is offloaded with MARK action (RTE_FLOW_ACTION_TYPE_MARK), each packet of that flow will have metadata set in its completion. This metadata will be used to fetch an index into a mark table where the actual MARK for that flow is stored. Fetch the MARK from the mark table and inject it in

[dpdk-dev] [PATCH v2 30/34] net/bnxt: add support for rte flow flush driver hook

2020-04-13 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Gets the ulp session information from eth_dev 2. Fetches the rte_flow table associated with this session 3. Iterates through all the flows in the flow table 4. Calls ulp_mapper_resources_free which releases the key & action tables assoc

[dpdk-dev] [PATCH v2 29/34] net/bnxt: add support for rte flow destroy driver hook

2020-04-13 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Gets the ulp session information from eth_dev 2. Fetches the flow associated with the flow id from the flow table 3. Calls ulp_mapper_resources_free which releases the key & action tables associated with that flow Signed-off-by: Kishor

[dpdk-dev] [PATCH v2 28/34] net/bnxt: add support for rte flow validate driver hook

2020-04-13 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Validates rte_flow_create arguments 2. Parses rte_flow_item types 3. Parses rte_flow_action types 4. Calls ulp_matcher_pattern_match to see if the flow is supported 5. If there is a match, returns success otherwise failure Signed-off-by:

[dpdk-dev] [PATCH v2 31/34] net/bnxt: register tf rte flow ops

2020-04-13 Thread Venkat Duvvuru
Register bnxt_ulp_rte_flow_ops when host based TRUFLOW is enabled. Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt_ethdev.c | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v2 32/34] net/bnxt: disable vector mode when host based TRUFLOW is enabled

2020-04-13 Thread Venkat Duvvuru
If bp->truflow is not set then don't enable vector mode. Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/driver

[dpdk-dev] [PATCH v2 26/34] net/bnxt: add support for rte flow action parsing

2020-04-13 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Registers a callback handler for each rte_flow_action type, if it is supported 2. Iterates through each rte_flow_action till RTE_FLOW_ACTION_TYPE_END 3. Invokes the action call back handler 4. Each action call back handler will populate

[dpdk-dev] [PATCH v2 24/34] net/bnxt: match rte flow actions with flow template actions

2020-04-13 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Takes act_bitmap generated from the rte_flow_actions 2. Iterates through the static act_bitmap list 3. Returns success if a match is found, otherwise an error Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by:

[dpdk-dev] [PATCH v2 23/34] net/bnxt: match rte flow items with flow template patterns

2020-04-13 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Takes hdr_bitmap generated from the rte_flow_items 2. Iterates through the static hdr_bitmap list 3. Returns success if a match is found, otherwise an error Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: La

[dpdk-dev] [PATCH v2 22/34] net/bnxt: add support to alloc and program key and act tbls

2020-04-13 Thread Venkat Duvvuru
From: Mike Baucom This patch does the following 1. Gets the action tables information from the action template id 2. Gets the class tables information from the class template id 3. Initializes the registry file 4. Allocates a flow id from the flow table 5. Process the class & action tables Signe

[dpdk-dev] [PATCH v2 27/34] net/bnxt: add support for rte flow create driver hook

2020-04-13 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Validates rte_flow_create arguments 2. Parses rte_flow_item types 3. Parses rte_flow_action types 4. Calls ulp_matcher_pattern_match to see if the flow is supported 5. If there is a match, calls ulp_mapper_flow_create to program key & a

[dpdk-dev] [PATCH v2 25/34] net/bnxt: add support for rte flow item parsing

2020-04-13 Thread Venkat Duvvuru
From: Kishore Padmanabha 1. Registers a callback handler for each rte_flow_item type, if it is supported 2. Iterates through each rte_flow_item till RTE_FLOW_ITEM_TYPE_END 3. Invokes the header call back handler 4. Each header call back handler will populate the respective fields in hdr_fie

[dpdk-dev] [PATCH v2 20/34] net/bnxt: add support to process key tables

2020-04-13 Thread Venkat Duvvuru
From: Mike Baucom This patch creates the classifier table entries for a flow. Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c| 773

[dpdk-dev] [PATCH v2 19/34] net/bnxt: add support to process action tables

2020-04-13 Thread Venkat Duvvuru
From: Mike Baucom This patch processes the action template. Iterates through the list of action info templates and processes it. Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson --- drivers/net/bnxt/Makefile

[dpdk-dev] [PATCH v2 17/34] net/bnxt: add support for ULP session manager cleanup

2020-04-13 Thread Venkat Duvvuru
A ULP session will contain all the resources needed to support rte flow offloads. A session is initialized as part of rte_eth_device start. A DPDK application can have multiple interfaces which means rte_eth_device start will be called for each of these devices. ULP session manager will make sure t

[dpdk-dev] [PATCH v2 18/34] net/bnxt: add helper functions for blob/regfile ops

2020-04-13 Thread Venkat Duvvuru
From: Mike Baucom 1. blob routines for managing key/mask/result data 2. regfile routines for managing temporal data during flow construction Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Kha

[dpdk-dev] [PATCH v2 21/34] net/bnxt: add support to free key and action tables

2020-04-13 Thread Venkat Duvvuru
From: Mike Baucom This patch does the following 1. Gets all the flow resources from the flow id 2. Frees all the table resources 3. Frees the flow in the flow table Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Review

[dpdk-dev] [PATCH v2 15/34] net/bnxt: add devargs parameter for host memory based TRUFLOW feature

2020-04-13 Thread Venkat Duvvuru
This feature can be enabled by passing "-w :0d:00.0,host-based-truflow=1” to the DPDK application. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt.h| 4 ++- drivers/net/bnxt/bnxt_ethdev.c | 73 ++ 2 files ch

[dpdk-dev] [PATCH v2 16/34] net/bnxt: add support for ULP session manager init

2020-04-13 Thread Venkat Duvvuru
A ULP session will contain all the resources needed to support rte flow offloads. A session is initialized as part of rte_eth_device start. A DPDK application can have multiple interfaces which means rte_eth_device start will be called for each of these devices. ULP session manager will make sure t

[dpdk-dev] [PATCH v2 13/34] net/bnxt: fetch SVIF information from the firmware

2020-04-13 Thread Venkat Duvvuru
SVIF (source virtual interface) is used to represent a physical port, physical function, or a virtual function. SVIF is compared during L2 context and exact match lookups in TX direction. SVIF is masked for port information during L2 context and exact match lookup in RX direction. Hence, driver nee

[dpdk-dev] [PATCH v2 14/34] net/bnxt: fetch vnic info from DPDK port

2020-04-13 Thread Venkat Duvvuru
VNIC is needed for the driver to program the action record for rx flows. VNIC determines what receive rings to use to place the received packets. This patch introduces a routine that will convert a given dpdk port to VNIC. Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by:

[dpdk-dev] [PATCH v2 12/34] net/bnxt: add EM/EEM functionality

2020-04-13 Thread Venkat Duvvuru
From: Pete Spreadborough - Add TruFlow flow memory support - Exact Match (EM) adds the capability to manage and manipulate data flows using on chip memory. - Extended Exact Match (EEM) behaves similarly to EM, but at a vastly increased scale by using host DDR, with performance tradeoff due

[dpdk-dev] [PATCH v2 07/34] net/bnxt: add initial tf core resource mgmt support

2020-04-13 Thread Venkat Duvvuru
From: Shahaji Bhosle - Add TruFlow public API definitions for resources as well as RM infrastructure Signed-off-by: Shahaji Bhosle Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Makefile |1 + drivers/net/bnxt/tf_core/tf_core.c| 39 +

[dpdk-dev] [PATCH v2 09/34] net/bnxt: add tf core identifier support

2020-04-13 Thread Venkat Duvvuru
From: Farah Smith - Add TruFlow Identifier resource support - Add TruFlow public API for Identifier resources. - Add support code and stack for Identifier resource allocation control. Signed-off-by: Farah Smith Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt

[dpdk-dev] [PATCH v2 08/34] net/bnxt: add resource manager functionality

2020-04-13 Thread Venkat Duvvuru
From: Michael Wildt - Add TruFlow RM functionality for resource handling - Update the TruFlow Resource Manager (RM) with resource support functions for debugging as well as resource cleanup. - Add support for Internal and external pools. Signed-off-by: Michael Wildt Reviewed-by: Randy Schache

[dpdk-dev] [PATCH v2 11/34] net/bnxt: add tf core table scope support

2020-04-13 Thread Venkat Duvvuru
From: Farah Smith - Added TruFlow Table public API - Added Table Scope capability including Table Type support code for setting and getting Table Types. Signed-off-by: Farah Smith Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnx

[dpdk-dev] [PATCH v2 10/34] net/bnxt: add tf core TCAM support

2020-04-13 Thread Venkat Duvvuru
From: Shahaji Bhosle - Add TruFlow TCAM public API functions - Add TCAM support functions as well as public APIs. Signed-off-by: Shahaji Bhosle Signed-off-by: Jay Ding Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/tf_core/tf_core.c | 163 +

[dpdk-dev] [PATCH v2 04/34] net/bnxt: add initial tf core session open

2020-04-13 Thread Venkat Duvvuru
From: Michael Wildt - Add infrastructure support - Add tf_core open session support Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Makefile| 8 + drivers/net/bnxt/bnxt.h | 4 + drivers/net/bn

[dpdk-dev] [PATCH v2 06/34] net/bnxt: add tf core session sram functions

2020-04-13 Thread Venkat Duvvuru
From: Michael Wildt - Add TruFlow session resource support functionality - Add TruFlow session hw flush capability as well as sram support functions. - Add resource definitions for session pools. Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde ---

[dpdk-dev] [PATCH v2 05/34] net/bnxt: add initial tf core session close support

2020-04-13 Thread Venkat Duvvuru
From: Michael Wildt - Add TruFlow session and resource support functions - Add Truflow session close API and related message support functions for both session and hw resources Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Ma

[dpdk-dev] [PATCH v2 02/34] net/bnxt: update hwrm prep to use ptr

2020-04-13 Thread Venkat Duvvuru
From: Randy Schacher - Change HWRM_PREP to use pointer and use the full HWRM enum Signed-off-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt.h | 2 +- drivers/net/bnxt/bnxt_hwrm.c | 200 +-- 2 files changed, 101 in

[dpdk-dev] [PATCH v2 03/34] net/bnxt: add truflow message handlers

2020-04-13 Thread Venkat Duvvuru
From: Pete Spreadborough - Add bnxt message functions for truflow APIs Signed-off-by: Pete Spreadborough Signed-off-by: Randy Schacher Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 83 drivers/n

[dpdk-dev] [PATCH v2 00/34] add support for host based flow table management

2020-04-13 Thread Venkat Duvvuru
This patchset introduces a new mechanism to allow host-memory based flow table management. This should allow higher flow scalability than what is currently supported. This new approach also defines a new rte_flow parser, and mapper which currently supports basic packet classification in receive pat

Re: [dpdk-dev] [PATCH v2] net/mlx5: Allow configuring mlx5 port for TX only

2020-04-13 Thread Alexander Kozyrev
Hi Mohsin, the problem you described has been already fixed by 606d690 ("net/mlx5: fix running without Rx queue"). I guess you see the issue on 19.11 branch, right? Could you please apply this patch and verify that it fixes the issue for you? Regards, Alex > -Original Message- > From:

Re: [dpdk-dev] [PATCH v4] eal: add VFIO-PCI SR-IOV support

2020-04-13 Thread Wang, Haiyue
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Monday, April 13, 2020 20:18 > To: Wang, Haiyue > Cc: dev@dpdk.org; vattun...@marvell.com; jer...@marvell.com; > alex.william...@redhat.com; > david.march...@redhat.com > Subject: Re: [PATCH v4] eal: add VFIO-PCI SR-IOV sup

[dpdk-dev] [PATCH v2] net/bnxt: add missing counters to xstats

2020-04-13 Thread Christos Ricudis
Add several missing hardware counters to xstats Signed-off-by: Christos Ricudis --- drivers/net/bnxt/bnxt_stats.c | 127 ++ 1 file changed, 127 insertions(+) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index 4668629..29628bd

[dpdk-dev] [PATCH v2] net/bnxt: add missing counters to xstats

2020-04-13 Thread Christos Ricudis
--- v2: * Fix checkpatch issues Christos Ricudis (1): net/bnxt: add missing counters to xstats drivers/net/bnxt/bnxt_stats.c | 127 ++ 1 file changed, 127 insertions(+) -- 1.8.3.1

Re: [dpdk-dev] [PATCH RFC v2 0/7] introduce new barrier class and use it for mlx5 PMD

2020-04-13 Thread Gavin Hu
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, April 13, 2020 5:52 PM > To: Gavin Hu ; dev@dpdk.org > Cc: nd ; david.march...@redhat.com; > tho...@monjalon.net; rasl...@mellanox.com; d...@linux.vnet.ibm.com; > bruce.richard...@intel.com; konstantin.anan...@intel.

Re: [dpdk-dev] [PATCH v4] eal: add VFIO-PCI SR-IOV support

2020-04-13 Thread Wang, Haiyue
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, April 13, 2020 23:38 > To: Wang, Haiyue ; dev@dpdk.org; tho...@monjalon.net; > vattun...@marvell.com; > jer...@marvell.com; alex.william...@redhat.com; david.march...@redhat.com > Subject: Re: [dpdk-dev] [PATCH v4]

Re: [dpdk-dev] [PATCH v3 3/9] ring: introduce RTS ring mode

2020-04-13 Thread Honnappa Nagarahalli
> > > > > > > > > > diff --git a/devtools/libabigail.abignore > > > > > b/devtools/libabigail.abignore index a59df8f13..cd86d89ca 100644 > > > > > --- a/devtools/libabigail.abignore > > > > > +++ b/devtools/libabigail.abignore > > > > > @@ -11,3 +11,10 @@ > > > > > type_kind = enum > > >

[dpdk-dev] [PATCH v3 1/2] net/i40e: relax barrier in Tx fastpath for NEON vPMD

2020-04-13 Thread Gavin Hu
To keep ordering of mixed accesses, 'DMB OSH' is sufficient. 'DSB' inside the I40E_PCI_REG_WRITE is overkill.[1] This patch fixes by replacing with just sufficient barriers in the normal PMD and vPMD. It showed 7% performance uplift on ThunderX2 and 4% on Arm N1SDP. The test case is the RFC2544 z

[dpdk-dev] [PATCH v3 0/2] i40e NEON vPMD optimization on aarch64

2020-04-13 Thread Gavin Hu
V3: - fix the 'Fixes' line warning. V2: - drop the 3/3 auto-vectorization patch from this series, it requires more rework and will submit in a separate patch. This series is to optimize the i40e NEON vPMD performance on aarch64. The patches were benchmarked by running the following command on

[dpdk-dev] [PATCH v3 2/2] net/i40e: restrict pointer aliasing for NEON vPMD

2020-04-13 Thread Gavin Hu
restrict pointer aliasing to optimize the code generated. The patch showed ~3% performnace uplift on Arm N1SDP platform, and no degradation on ThunderX2. The tet case is RFC2544 zero-loss L2 forwarding running testpmd. [1] https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/Restricted-Pointers.html Sig

[dpdk-dev] [PATCH v2] usertools: decode PCI device name as UTF-8

2020-04-13 Thread Christos Ricudis
Fixes the case where a PCI device string identifier contains non-ASCII UTF-8 A particular example is Mellanox Connext-X 5 EN MT27800: 28:00.0 Ethernet controller: Mellanox Technologies MT27800 Family [ConnectX-5] Subsystem: Mellanox Technologies ConnectX®-5 EN network interface card, 100GbE sing

Re: [dpdk-dev] [PATCH v2] usertools: decode PCI device name as UTF-8

2020-04-13 Thread Andrew Rybchenko
On 4/13/20 7:18 PM, Christos Ricudis wrote: > Fixes the case where a PCI device string identifier > contains non-ASCII UTF-8 > > A particular example is Mellanox Connext-X 5 EN MT27800: > > 28:00.0 Ethernet controller: Mellanox Technologies > MT27800 Family [ConnectX-5] > > Subsystem: Mellanox T

[dpdk-dev] i40eVF pmd vlan id handling

2020-04-13 Thread Dey, Souvik
Hi All, I am using DPDK 18.11.2 and i40e PF linux driver on the host 2.4.6. I see there, when I enable DEV_RX_OFFLOAD_VLAN_FILTER from the DPDK app, and then configure the specific vlan id using rte_eth_dev_vlan_filter(). As per DPDK code by default when we do dev_configure, we call i40e

[dpdk-dev] [PATCH v2 1/2] net/i40e: relax barrier in Tx fastpath for NEON vPMD

2020-04-13 Thread Gavin Hu
To keep ordering of mixed accesses, 'DMB OSH' is sufficient. 'DSB' inside the I40E_PCI_REG_WRITE is overkill.[1] This patch fixes by replacing with just sufficient barriers in the normal PMD and vPMD. It showed 7% performance uplift on ThunderX2 and 4% on Arm N1SDP. The test case is the RFC2544 z

[dpdk-dev] [PATCH v2 2/2] net/i40e: restrict pointer aliasing for NEON vPMD

2020-04-13 Thread Gavin Hu
restrict pointer aliasing to optimize the code generated. The patch showed ~3% performnace uplift on Arm N1SDP platform, and no degradation on ThunderX2. The tet case is RFC2544 zero-loss L2 forwarding running testpmd. [1] https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/Restricted-Pointers.html Sig

[dpdk-dev] [PATCH v2 0/2] i40e NEON vPMD optimization on aarch64

2020-04-13 Thread Gavin Hu
V2: - drop the 3/3 auto-vectorization patch from this series, it requires more rework and will submit in a separate patch. This series is to optimize the i40e NEON vPMD performance on aarch64. The patches were benchmarked by running the following command on Marvell ThunderX2 and Arm N1SDP and

Re: [dpdk-dev] [PATCH] usertools: decode PCI device name as UTF-8

2020-04-13 Thread Christos Rikoudis
> On 13 Apr 2020, at 11:14 PM, Andrew Rybchenko > wrote: > > On 4/13/20 5:58 PM, Christos Ricudis wrote: >> Fixes the case where a PCI device string identifier contains non-ASCII UTF-8. >> >> A particular example is Mellanox Connext-X 5 EN MT27800: >> >> 28:00.0 Ethernet controller: Mellanox

Re: [dpdk-dev] [PATCH v3 03/13] security: fix session counter

2020-04-13 Thread Anoob Joseph
> Fix session counter to be decreased in rte_security_session_destroy only when > session was successfully destroyed. > > Formerly session counter was decreased prior session destroying and returning > session object to mempool. It remained decreased even if session was not > destroyed and mempool

Re: [dpdk-dev] [PATCH v3 02/13] security: fix return types in documentation

2020-04-13 Thread Anoob Joseph
> Enhance returned values description for rte_security_session_destroy and some > other minor description changes. > > Fixes: c261d1431bd8 ("security: introduce security API and framework") > Cc: akhil.go...@nxp.com > > Cc: sta...@dpdk.org > > Signed-off-by: Lukasz Wojciechowski Acked-by: Anoo

Re: [dpdk-dev] [PATCH v3 01/13] security: fix verification of parameters

2020-04-13 Thread Anoob Joseph
> This patch adds verification of the parameters to the ret_security API > functions. > All required parameters are checked if they are not NULL. > > Checks verify full chain of pointers, e.g. in case of verification of > "instance->ops- > >session_XXX", they check also "instance" > and "instan

Re: [dpdk-dev] [PATCH v4] eal: add VFIO-PCI SR-IOV support

2020-04-13 Thread Andrew Rybchenko
On 4/13/20 11:29 AM, Haiyue Wang wrote: > The kernel module vfio-pci introduces the VF token to enable SR-IOV > support since 5.7. > > The VF token can be set by a vfio-pci based PF driver and must be known > by the vfio-pci based VF driver in order to gain access to the device. > > An example VF

Re: [dpdk-dev] [PATCH v3 03/11] net/igc: implement device base ops

2020-04-13 Thread Stephen Hemminger
On Mon, 13 Apr 2020 14:30:29 +0800 alvinx.zh...@intel.com wrote: > + PMD_DRV_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d", > + pci_dev->addr.domain, > + pci_dev->addr.bus, > + pci_dev->addr.devid, > +

  1   2   >