Hi Bruce, -----Original Message----- From: Bruce Richardson <bruce.richard...@intel.com> Sent: Friday, April 10, 2020 11:46 AM To: Juraj Linkeš <juraj.lin...@pantheon.tech> Cc: dev@dpdk.org Subject: Re: [PATCH] build: add arm 32bit cross compilation to Meson
On Thu, Apr 09, 2020 at 04:14:48PM +0200, Juraj Linkeš wrote: > * Add arm-linux-gnueabihf cross-file > * Add generic and default arm 32 bit flags to arm meson.build > * Add support for disabling drivers using flags defined in Meson > * Change checks from dpdk_conf.has() to dpdk.conf.get() > * When processing which drivers to build, check whether the > appropriate RTE flag isn't set to false > This is probably best done as separate patches that can be reviewed separately. While the first two seem straight-forward, the last item seems strange and should be reviewed separately. Why do you want flags defined in meson to enable/disable drivers? It's taking a big step back towards having a statically defined configuration, which is something we really want to get away from. /Bruce I will split the patch. I don't have any particular reason to do it this way. What should I do? Add conditions that check for arm32 build to each of these drivers? Thanks, Juraj
