Re: [dpdk-dev] [PATCH 07/12] net/iavf: add flow director enabled switch value

2020-03-25 Thread Wu, Jingjing
-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Leyi Rong Sent: Monday, March 16, 2020 3:46 PM To: Zhang, Qi Z ; Ye, Xiaolong Cc: dev@dpdk.org; Rong, Leyi Subject: [dpdk-dev] [PATCH 07/12] net/iavf: add flow director enabled switch value The commit adds fdir_e

[dpdk-dev] [PATCH v2] net/ice: fix RSS advanced rule invalid issue

2020-03-25 Thread Junyu Jiang
This patch added a restore function for RSS advanced rule to fix the rule invalid after running port stop and port start. Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") Cc: sta...@dpdk.org Signed-off-by: Junyu Jiang --- drivers/net/ice/ice_ethdev.c | 47 +++

Re: [dpdk-dev] [PATCH 04/12] net/iavf: flexible Rx descriptor support in normal path

2020-03-25 Thread Wu, Jingjing
One general comment: Looks like there are exact same code comparing with legacy rx, such as logic to update tail, multi-segments loop. It will be good if all the common code can be wrapped and use for multi recv functions [...] +/* Get the number of used descriptors of a rx queue for flexible R

[dpdk-dev] [dpdk-dev v2] [PATCH] examples/l2fwd-event: add option to configure port pairs

2020-03-25 Thread pbhagavatula
From: Pavan Nikhilesh Current l2fwd-event application statically configures adjacent ports as destination ports for forwarding the traffic. Add a config option to pass the forwarding port pair mapping which allows the user to configure forwarding port mapping. If no config argument is specified

Re: [dpdk-dev] [PATCH] examples/l2fwd-event: add option to configure port pairs

2020-03-25 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Sunil Kumar Kori >Sent: Wednesday, March 25, 2020 4:10 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; Marko Kovacevic >; Ori Kam ; Bruce >Richardson ; Radu Nicolau >; Akhil Goyal ; Tomasz >Kantecki ; Pavan Nikhilesh Bhagavatula >; John McNa

[dpdk-dev] [dpdk-dev v3] [PATCH] mempool/octeontx2: add devargs to lock ctx in cache

2020-03-25 Thread pbhagavatula
From: Pavan Nikhilesh Add device arguments to lock NPA aura and pool contexts in NDC cache. The device args take hexadecimal bitmask where each bit represent the corresponding aura/pool id. Example: -w 0002:02:00.0,npa_lock_mask=0xf // Lock first 4 aura/pool ctx Signed-off-by: Pavan Nikh

[dpdk-dev] [dpdk-dev v3] [PATCH] net/octeontx2: add devargs to lock Rx/Tx ctx

2020-03-25 Thread pbhagavatula
From: Pavan Nikhilesh Add device arguments to lock Rx/Tx contexts. Application can either choose to lock Rx or Tx contexts by using 'lock_rx_ctx' or 'lock_tx_ctx' respectively per each port. Example: -w 0002:02:00.0,lock_rx_ctx=1 -w 0002:03:00.0,lock_tx_ctx=1 Signed-off-by: Pavan Nikhil

[dpdk-dev] [PATCH] doc/guides/contributing/patches.rst: corrected typing mistake in line 185

2020-03-25 Thread Muhammad Bilal
Bugzilla ID: 422 Cc: marko.kovace...@intel.com Cc: john.mcnam...@intel.com Cc: dev@dpdk.org Cc: sta...@dpdk.org Signed-off-by: Muhammad Bilal --- doc/guides/contributing/patches.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/contributing/patches.rst b/doc/guid

Re: [dpdk-dev] [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC

2020-03-25 Thread Akhil Goyal
> > From: Akhil Goyal > >> > >> From: Nic Chautru > >> > >> Supports for FEC 5G PMD Driver on FPGA card PAC N3000 > >> > >> Signed-off-by: Nic Chautru > >> --- > > > >I cannot review this patch. This patch should be a separate series. > >This should be split into logical parts as a new PMD is s

Re: [dpdk-dev] [PATCH v4 0/7] add Intel DCF PMD support

2020-03-25 Thread Wang, Haiyue
Hi Xiaolong, Yes, found the root cause. Will fix it next version. BR, Haiyue > -Original Message- > From: Ye, Xiaolong > Sent: Thursday, March 26, 2020 13:06 > To: Wang, Haiyue > Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > ; Xing, > Beilei ; Zhao1, Wei > Subject: Re: [PATCH v4 0/7

Re: [dpdk-dev] [PATCH v4 0/7] add Intel DCF PMD support

2020-03-25 Thread Ye Xiaolong
There is build error about this patchset, could you double check? OS: CENTOS77-64 Target: x86_64-native-linuxapp-gcc+shared LD librte_pmd_ice.so.20.0.2 CC sfc_ev.o ice_dcf_parent.o: In function `ice_dcf_handle_pf_event_msg': ice_dcf_parent.c:(.text+0x556): undefined reference to `pthread_cr

Re: [dpdk-dev] [PATCH v4 0/7] add Intel DCF PMD support

2020-03-25 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, March 26, 2020 11:04 AM > To: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > ; Yang, Qiming ; Xing, Beilei > > Cc: Zhao1, Wei ; Wang, Haiyue > > Subject: [PATCH v4 0/7] add Intel DCF PMD support > > A DCF (Device Config Function

[dpdk-dev] [PATCH v5 06/10] test-bbdev: support HARQ validation

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru Adding functionality to validate HARQ for different devices implementation. Adding capacity to fetch HARQ data when required as part of this validation. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 564 - app/test-bbd

Re: [dpdk-dev] [PATCH v4 1/7] net/iavf: stop the PCI probe in DCF mode

2020-03-25 Thread Wu, Jingjing
-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Haiyue Wang Sent: Thursday, March 26, 2020 11:04 AM To: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z ; Yang, Qiming ; Xing, Beilei Cc: Zhao1, Wei ; Wang, Haiyue Subject: [dpdk-dev] [PATCH v4 1/7] net/iavf: stop the P

[dpdk-dev] [PATCH v5 09/10] test-bbdev: support for offload test for LDPC

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru Adding support for the offload latency tests when using the LDPC encoder and decoder operations. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/app/test-bbdev/test

[dpdk-dev] [PATCH v5 07/10] test-bbdev: support for performance tests

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru Includes support for BLER (Block Error Rate) wireless performance test with new arguments for SNR and number of iterations for 5G. This generates LLRs for a given SNR level then measures the ratio of code blocks being successfully decoded or not. Signed-off-by: Nic Chautru ---

[dpdk-dev] [PATCH v5 08/10] test-bbdev: support for LDPC interrupt test

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru Adding missing implementation for the interrupt tests for LDPC encoder and decoders. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 202 ++- 1 file changed, 200 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/t

[dpdk-dev] [PATCH v5 05/10] test-bbdev: rename FPGA LTE macros to be more explicit

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru Self-contained and cosmetic renaming of macro so that to be more explicit for future extension. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 51 +++- 1 file changed, 19 insertions(+), 32 deletions(-) diff --git a/app/t

[dpdk-dev] [PATCH v5 03/10] baseband/turbo_sw: fix the exposed LLR decimals assumption

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru The actual LLR representation was incorrectly assumed to be 2 instead of 4. This would impact wireless performance but is not critical to be back ported on LTS branches. Fixes: c769c711757a ("baseband/turbo_sw: extend for 5G") Signed-off-by: Nic Chautru --- drivers/baseband/

[dpdk-dev] [PATCH v5 01/10] bbdev: add capability flag for filler bits inclusion in HARQ

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru Adding capability flag for device variants when HARQ buffer may or may not include the filler bits. Minor cosmetic changes in same file. Signed-off-by: Nic Chautru --- lib/librte_bbdev/rte_bbdev.h| 2 ++ lib/librte_bbdev/rte_bbdev_op.h | 12 ++-- 2 files changed,

[dpdk-dev] [PATCH v5 00/10] bbdev new features

2020-03-25 Thread Nicolas Chautru
v5: cosmetic change v4: Changes based on review comments from Akhil. Also taking the new PMD out of this serie to be pushed in separate serie. v3: squash the release notes updates into the related commits v2: including release note update + fix for typo in commit message reported by DPDK CI. T

[dpdk-dev] [PATCH v5 04/10] baseband/turbo_sw: support large size code block

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru This is to support cases when the input data for decoding a code block is larger than 64kB and would not fit as a contiguous block of data into one mbuf. In that case the length from the operation supersedes the mbuf default structure. Signed-off-by: Nic Chautru --- app/test-

[dpdk-dev] [PATCH v5 02/10] bbdev: expose device HARQ buffer size at device level

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru This exposes the HARQ buffer size at the device driver level instead of using the capability of a specific operation. This is currently not yet used by a device until future commit. Signed-off-by: Nic Chautru --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 2 +- lib/l

Re: [dpdk-dev] [PATCH] net/iavf: enable port reset

2020-03-25 Thread Wu, Jingjing
-Original Message- From: Cui, LunyuanX Sent: Wednesday, March 25, 2020 10:48 AM To: dev@dpdk.org Cc: Wu, Jingjing ; Yang, Qiming ; Cui, LunyuanX Subject: [PATCH] net/iavf: enable port reset This patch is intended to add iavf_dev_reset ops, enable iavf to support "port reset all". Si

Re: [dpdk-dev] [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC

2020-03-25 Thread Chautru, Nicolas
From: Akhil Goyal >> >> From: Nic Chautru >> >> Supports for FEC 5G PMD Driver on FPGA card PAC N3000 >> >> Signed-off-by: Nic Chautru >> --- > >I cannot review this patch. This patch should be a separate series. >This should be split into logical parts as a new PMD is submitted for review.

[dpdk-dev] [PATCH v4 4/7] net/ice: handle the AdminQ command by DCF

2020-03-25 Thread Haiyue Wang
The DCF (Device Config Function) splits the AdminQ command into two parts: one is the descriptor of AdminQ command, the other is the buffer of AdminQ command (the descriptor has BUF flag set). When both of them are received by the PF, the PF will handle them as one command. And also, the filled de

[dpdk-dev] [PATCH v4 5/7] net/ice: export the DDP definition symbols

2020-03-25 Thread Haiyue Wang
A new DCF PMD will be introduced, which runs on Intel VF hardware, and it is a pure software design to control the advance functionality (such as switch, ACL) for rest of the VFs. The DCF (Device Config Function) feature shares the core functions of the ICE PMD, like it needs to export the DDP def

[dpdk-dev] [PATCH v4 6/7] net/ice: handle the PF initialization by DCF

2020-03-25 Thread Haiyue Wang
The DCF (Device Config Function) works at the user PF level, it can't access the real PF hardware directly. So it will pass through the PF's AdminQ command by the DCF's mailbox. And the DCF is mainly used to control the flow setting of other VFs, so it only needs to initialize some core functions

[dpdk-dev] [PATCH v4 7/7] net/ice: get the VF hardware index in DCF

2020-03-25 Thread Haiyue Wang
The DCF (Device Config Function) needs the hardware index of the VFs to control the flow setting. And also if the VF resets, the index may be changed, so it should handle this in VF reset event. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_dcf.c| 89 +++

[dpdk-dev] [PATCH v4 2/7] net/ice: add the DCF hardware initialization

2020-03-25 Thread Haiyue Wang
Introduce the DCF (Device Config Function) feature in the ice PMD, it works as a standalone PMD which doesn't handle the packet Rx/Tx related things. Its hardware entity is the VF. Add the basic DCF hardware initialization, this is specified by devarg 'cap=dcf'. Signed-off-by: Haiyue Wang --- d

[dpdk-dev] [PATCH v4 3/7] net/ice: acquire and disable the DCF capability

2020-03-25 Thread Haiyue Wang
Since the DCF (Device Config Function) controls the flow setting of other VFs by the mailbox with PF, for security, it needs to acquire the DCF capability from PF when starts, and disable it when exits. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_dcf.c | 27 ++- 1

[dpdk-dev] [PATCH v4 0/7] add Intel DCF PMD support

2020-03-25 Thread Haiyue Wang
A DCF (Device Config Function) based approach is proposed where a device bound to the device's VF0 can act as a sole controlling entity to exercise advance functionality (such as switch, ACL) for rest of the VFs. The DCF works as a standalone PMD to support this function, which shares the ice PMD

[dpdk-dev] [PATCH v4 1/7] net/iavf: stop the PCI probe in DCF mode

2020-03-25 Thread Haiyue Wang
A new DCF PMD will be introduced, which runs on Intel VF hardware, and it is a pure software design to control the advance functionality (such as switch, ACL) for rest of the VFs. So if the DCF (Device Config Function) mode is specified by the devarg 'cap=dcf', then it will stop the PCI probe in t

Re: [dpdk-dev] [PATCH v3 11/14] doc: update of testbbdev documentation

2020-03-25 Thread Chautru, Nicolas
From: Akhil Goyal >> From: Nic Chautru >> >> Update related to the changes introduced by the previous commits. >> >> Signed-off-by: Nic Chautru >> --- > >Please split this patch and merge the relevant sections in the respective >patches. > >And it would be better to add reference to the Stan

Re: [dpdk-dev] [PATCH v3 10/14] test-bbdev: vectors update

2020-03-25 Thread Chautru, Nicolas
From: Akhil Goyal >> From: Nic Chautru >> >> Modification to vectors parameters used for unit test for coverage and >> performance test of bbdev drivers across all devices. >> Reducing list for focused coverage when required. >> >> Signed-off-by: Nic Chautru > >Not able to get the reason for

Re: [dpdk-dev] [PATCH v3 09/14] test-bbdev: support for offload test for LDPC

2020-03-25 Thread Chautru, Nicolas
From: Akhil Goyal >> @@ -4552,7 +4552,12 @@ typedef int (test_case_function)(struct >> active_device *ad, >> >> if (unlikely(num_to_process - deq_total < burst_sz)) >> burst_sz = num_to_process - deq_total; >> -rte_bbdev_dequeue_dec_ops(dev_id, queu

Re: [dpdk-dev] [PATCH v3 07/14] test-bbdev: support for performance tests

2020-03-25 Thread Chautru, Nicolas
From: Akhil Goyal >> >> From: Nic Chautru >> >> Includes support for BLER wireless performance test with new arguments >> for SNR and number of iterations for 5G. >> >It would be better to add more info in the commit log. >You can add reference to some standard link which is being Followed s

Re: [dpdk-dev] [PATCH v3 06/14] test-bbdev: support HARQ validation

2020-03-25 Thread Chautru, Nicolas
From: Akhil Goyal >> +/* ignore parity mismatch false alarms for long iterations */ >> +{ >> +if (!(expected_status & (1 << RTE_BBDEV_SYNDROME_ERROR)) > >What is the need of these extra braces. > Missing check added now on new patchset. Thanks. >> + >> +/* Compute K0 for a

Re: [dpdk-dev] [PATCH v3 04/14] baseband/turbo_sw: support large size code block

2020-03-25 Thread Chautru, Nicolas
From: Akhil Goyal >> +if (seg->length > 64000) { >Shouldn't this be seg->length + RTE_PKTMBUF_HEADROOM and you don't need A >check again in assert. >64000 should be a MACRO Adding macro for this at rte_bbdev level in new version uploaded today. >> +data

Re: [dpdk-dev] [PATCH v3 01/14] bbdev: add capability flag for filler bits inclusion in HARQ

2020-03-25 Thread Chautru, Nicolas
From: Akhil Goyal >> +/** Set if a device includes LLR filler bits in the circular buffer >> + * for HARQ memory. If not set, it is assumed the filler are not in >Filler bits are not > >> + * HARQ memory and handled directory by the LDPC decoder. >Handled directly by the LDPC decode

[dpdk-dev] [PATCH v4 04/10] baseband/turbo_sw: support large size code block

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru This is to support cases when the input data for decoding a code block is larger than 64kB and would not fit as a contiguous block of data into one mbuf. In that case the length from the opearation supersedes the mbuf default structure. Signed-off-by: Nic Chautru --- app/test

[dpdk-dev] [PATCH v4 08/10] test-bbdev: support for LDPC interrupt test

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru Adding missing implementation for the interrupt tests for LDPC encoder and decoders. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 202 ++- 1 file changed, 200 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/t

[dpdk-dev] [PATCH v4 06/10] test-bbdev: support HARQ validation

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru Adding functionality to validate HARQ for different devices implementation. Adding capacity to fetch HARQ data when required as part of this validation. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 564 - app/test-bbd

[dpdk-dev] [PATCH v4 07/10] test-bbdev: support for performance tests

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru Includes support for BLER (Block Error Rate) wireless performance test with new arguments for SNR and number of iterations for 5G. This generates LLRs for a given SNR level then measures the ratio of code blocks being successfully decoded or not. Signed-off-by: Nic Chautru ---

[dpdk-dev] [PATCH v4 09/10] test-bbdev: support for offload test for LDPC

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru Adding support for the offload latency tests when using the LDPC encoder and decoder operations. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/app/test-bbdev/test

[dpdk-dev] [PATCH v4 01/10] bbdev: add capability flag for filler bits inclusion in HARQ

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru Adding capability flag for device variants when HARQ buffer may or may not include the filler bits. Minor cosmetic changes in same file. Signed-off-by: Nic Chautru --- lib/librte_bbdev/rte_bbdev.h| 2 ++ lib/librte_bbdev/rte_bbdev_op.h | 12 ++-- 2 files changed,

[dpdk-dev] [PATCH v4 02/10] bbdev: expose device HARQ buffer size at device level

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru This exposes the HARQ buffer size at the device driver level instead of using the capability of a specific operation. This is currently not yet used by a device until future commit. Signed-off-by: Nic Chautru --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 2 +- lib/l

[dpdk-dev] [PATCH v4 00/10] bbdev new features

2020-03-25 Thread Nicolas Chautru
This set includes extending support for the bbdev device drivers for 20.05. Documentation is updated as well accordingly. Nic Chautru (10): bbdev: add capability flag for filler bits inclusion in HARQ bbdev: expose device HARQ buffer size at device level baseband/turbo_sw: fix the exposed

[dpdk-dev] [PATCH v4 03/10] baseband/turbo_sw: fix the exposed LLR decimals assumption

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru The actual LLR representation was incorrectly assumed to be 2 instead of 4. This would impact wireless performance but is not critical to be back ported on LTS branches. Fixes: c769c711757a ("baseband/turbo_sw: extend for 5G") Signed-off-by: Nic Chautru --- drivers/baseband/

[dpdk-dev] [PATCH v4 05/10] test-bbdev: rename FPGA LTE macros to be more explicit

2020-03-25 Thread Nicolas Chautru
From: Nic Chautru Self-contained and cosmetic renaming of macro so that to be more explicit for future extension. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 51 +++- 1 file changed, 19 insertions(+), 32 deletions(-) diff --git a/app/t

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: support 192/256 AES key sizes

2020-03-25 Thread Anoob Joseph
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Thursday, March 26, 2020 12:07 AM > To: Anoob Joseph ; Radu Nicolau > > Cc: Narayana Prasad Raju Athreya ; Tejasree Kondoj > ; dev@dpdk.org > Subject: [EXT] RE: [PATCH] examples/ipsec-secgw: support 192/256 AES key > sizes > > E

Re: [dpdk-dev] [PATCH 0/4] iavf share code update

2020-03-25 Thread Ye Xiaolong
On 03/26, Xing, Beilei wrote: > > >> -Original Message- >> From: Zhang, Qi Z >> Sent: Tuesday, March 10, 2020 8:37 AM >> To: Yang, Qiming ; Xing, Beilei >> >> Cc: Ye, Xiaolong ; dev@dpdk.org; Zhang, Qi Z >> >> Subject: [PATCH 0/4] iavf share code update >> >> Main change: >> >> update vi

Re: [dpdk-dev] [PATCH] net/ice: fix RSS advanced rule invalid issue

2020-03-25 Thread Yang, Qiming
Hi, Junyu Comments inline. And I have a proposal, why we don't put ice_rss_init into ice_dev_init, so the rss rule will not recovery. Qiming > -Original Message- > From: Jiang, JunyuX > Sent: Thursday, March 19, 2020 15:48 > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Jiang, J

Re: [dpdk-dev] [RFC 0/6] New sync modes for ring

2020-03-25 Thread Ananyev, Konstantin
> > > > > Subject: [dpdk-dev] [RFC 0/6] New sync modes for ring > > > > Upfront note - that RFC is not a complete patch. > > It introduces an ABI breakage, plus it doesn't update ring_elem code > > properly, > As per the current rules, these changes (in the current form) will be > accepted onl

Re: [dpdk-dev] [PATCH v2 0/2] examples/vmdq: fix RSS configuration

2020-03-25 Thread Han, YingyaX
Tested-by: Han,YingyaX -Original Message- From: dev On Behalf Of Junyu Jiang Sent: Wednesday, March 25, 2020 2:33 PM To: dev@dpdk.org Cc: Yang, Qiming ; Yigit, Ferruh ; Jiang, JunyuX Subject: [dpdk-dev] [PATCH v2 0/2] examples/vmdq: fix RSS configuration This patch set fixed a bug of

Re: [dpdk-dev] [PATCH 0/4] iavf share code update

2020-03-25 Thread Xing, Beilei
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, March 10, 2020 8:37 AM > To: Yang, Qiming ; Xing, Beilei > > Cc: Ye, Xiaolong ; dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH 0/4] iavf share code update > > Main change: > > update virtual channel to support DCF > > Qi Zhan

Re: [dpdk-dev] [RFC] ring: make ring implementation non-inlined

2020-03-25 Thread Ananyev, Konstantin
Hi Jerin, > > On Fri, Mar 20, 2020 at 10:11 PM Konstantin Ananyev > wrote: > > > > As was discussed here: > > http://mails.dpdk.org/archives/dev/2020-February/158586.html > > this RFC aimed to hide ring internals into .c and make all > > ring functions non-inlined. In theory that might help to >

[dpdk-dev] [Bug 424] malloc_autotest fails with message "Unexpected - ptr4 != ptr3"

2020-03-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=424 Bug ID: 424 Summary: malloc_autotest fails with message "Unexpected - ptr4 != ptr3" Product: DPDK Version: 20.05 Hardware: All OS: Linux Status: UNCONFIR

[dpdk-dev] [PATCH v2 31/32] mempool: add tracepoints

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS| 2 + drivers/common/cpt/Makefile| 1 + drivers/mempool/ring/Makefile | 1 + drivers/me

[dpdk-dev] [PATCH v2 29/32] eventdev: add tracepoints

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 2 + drivers/event/skeleton/Makefile | 1 + drivers/event/skeleton/meson.build| 1 + l

[dpdk-dev] [PATCH v2 32/32] doc: add trace library guide

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Add programmar's guide for trace library support. Signed-off-by: Sunil Kumar Kori Signed-off-by: Jerin Jacob --- doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/trace_lib.rst| 265 + doc/guides/rel_notes/release_20_05.rs

[dpdk-dev] [PATCH v2 28/32] ethdev: add tracepoints

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 2 + app/pdump/Makefile| 1 + app/pdump/meson.build | 1 + app/

[dpdk-dev] [PATCH v2 30/32] cryptodev: add tracepoints

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 2 + drivers/crypto/ccp/Makefile | 1 + drivers/crypto/ccp/meson.build| 2 + d

[dpdk-dev] [PATCH v2 26/32] eal/trace: add unit test cases

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Example commands to run UT and check the traces with babeltrace viewer. - Delete the existing /root/dpdk-traces/ directory if needed. > sudo rm -rf /root/dpdk-traces/ - Start the dpdk-test > sudo ./build/app/test/dpdk-test -c 0x3 - --trace-level=8 - Run trace_autotest >

[dpdk-dev] [PATCH v2 24/32] eal/trace: add trace bufsize configuration parameter

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-bufsz EAL parameter to configure maximum size of ring buffer where events are to be stored. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 13 lib/librte_eal/common/eal_common_options.c| 17 +

[dpdk-dev] [PATCH v2 27/32] eal/trace: add trace performance test cases

2020-03-25 Thread jerinj
From: Jerin Jacob This test case shall be used to measure the trace overhead. Example command to run the performance test case. echo "trace_perf" | ./build/app/test/dpdk-test -c 0x3 --trace-level=8 Signed-off-by: Jerin Jacob --- app/test/Makefile | 1 + app/test/meson.build

[dpdk-dev] [PATCH v2 25/32] eal/trace: add trace mode configuration parameter

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-mode eal parameter to configure event record mode when ring buffers are full. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 12 ++ lib/librte_eal/common/eal_common_options.c| 17 .../com

[dpdk-dev] [PATCH v2 22/32] eal/trace: add trace level configuration parameter

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-level EAL parameter to configure global and trace point specific level. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 19 lib/librte_eal/common/eal_common_options.c| 19 +++- lib/librte_eal/co

[dpdk-dev] [PATCH v2 23/32] eal/trace: add trace dir configuration parameter

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-dir EAL parameter to configure directory where traces will be generated. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 11 lib/librte_eal/common/eal_common_options.c| 15 ++ .../common/eal_c

[dpdk-dev] [PATCH v2 21/32] eal/trace: add interrupt tracepoints

2020-03-25 Thread jerinj
From: Jerin Jacob Add the following interrupt related tracepoints. rte_trace_lib_eal_intr_callback_register; rte_trace_lib_eal_intr_callback_unregister; rte_trace_lib_eal_intr_enable; rte_trace_lib_eal_intr_disable; Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points.c

[dpdk-dev] [PATCH v2 20/32] eal/trace: add thread tracepoints

2020-03-25 Thread jerinj
From: Jerin Jacob Add the following thread related tracepoints. rte_trace_lib_eal_thread_remote_launch; rte_trace_lib_eal_thread_lcore_ready; Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace_points.c | 9 + lib/librte_eal/common/include/rte_trace_eal.h | 14 +++

[dpdk-dev] [PATCH v2 15/32] eal/trace: hook internal trace APIs to FreeBSD

2020-03-25 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to FreeBSD EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/freebsd/eal/eal.c| 10 ++ lib/librte_eal/freebsd/eal/eal_thread.c | 3 +++ 2 files changed, 13 insertions(+) diff --git a/lib/librte_eal/freebsd/eal/eal.c

[dpdk-dev] [PATCH v2 17/32] eal/trace: add alarm tracepoints

2020-03-25 Thread jerinj
From: Jerin Jacob Add following alarm related trace points. rte_trace_lib_eal_alarm_set() rte_trace_lib_eal_alarm_cancel() Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points.c | 9 + lib/librte_eal/common/include/rte_trace_eal.h | 18 ++ lib/

[dpdk-dev] [PATCH v2 19/32] eal/trace: add memzone tracepoints

2020-03-25 Thread jerinj
From: Jerin Jacob Add the following memzone related tracepoints. rte_trace_lib_eal_memzone_reserve rte_trace_lib_eal_memzone_lookup rte_trace_lib_eal_memzone_free Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_memzone.c| 9 +++ .../common/eal_common_trace_points.c

[dpdk-dev] [PATCH v2 18/32] eal/trace: add memory tracepoints

2020-03-25 Thread jerinj
From: Jerin Jacob Add the following memory-related tracepoints. rte_trace_lib_eal_mem_zmalloc; rte_trace_lib_eal_mem_malloc; rte_trace_lib_eal_mem_realloc; rte_trace_lib_eal_mem_free; rte_malloc() and rte_free() has been used in the trace implementation, in order to avoid tracing implementation

[dpdk-dev] [PATCH v2 16/32] eal/trace: add generic tracepoints

2020-03-25 Thread jerinj
From: Jerin Jacob This patch creates the following generic tracepoint for generic tracing when there is no dedicated tracepoint is available. rte_trace_lib_eal_generic_void() rte_trace_lib_eal_generic_u64() rte_trace_lib_eal_generic_u32() rte_trace_lib_eal_generic_u16() rte_trace_lib_eal_generic

[dpdk-dev] [PATCH v2 13/32] eal/trace: implement provider payload

2020-03-25 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_ctf_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace mem emitters aka provider payload. When it used as provider payload, those function copy the trace field to tr

[dpdk-dev] [PATCH v2 11/32] eal/trace: implement trace save

2020-03-25 Thread jerinj
From: Jerin Jacob Implement rte_trace_save(), which will save the metadata file and trace memory snapshot to the trace directory. Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_utils.c | 80 +++ lib/librte_eal/rte_eal_version.map| 1 + 2 files

[dpdk-dev] [PATCH v2 12/32] eal/trace: implement registration payload

2020-03-25 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_ctf_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace memory emitters. When it used as registration payload, it will do the following to fulfill the registration jo

[dpdk-dev] [PATCH v2 10/32] eal/trace: implement debug dump function

2020-03-25 Thread jerinj
From: Jerin Jacob Implement rte_trace_metadata_dump() and rte_trace_dump() functions. Former one used to dump the CTF metadata file and the latter one to dump all the registered events and its status. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_com

[dpdk-dev] [PATCH v2 14/32] eal/trace: hook internal trace APIs to Linux

2020-03-25 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to Linux EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_thread.c | 3 ++- lib/librte_eal/linux/eal/eal.c| 9 + lib/librte_eal/linux/eal/eal_thread.c | 3 +++ 3 files changed, 14 insertions(

[dpdk-dev] [PATCH v2 09/32] eal/trace: implement trace memory allocation

2020-03-25 Thread jerinj
From: Jerin Jacob Trace memory will be allocated per thread to enable lockless trace events updates to the memory. The allocator will first attempt to allocate from hugepage, if not available from hugepage then fallback to malloc memory. Later in the patches series, This API will be hooked to DP

[dpdk-dev] [PATCH v2 08/32] eal/trace: handle CTF keyword collision

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Some of the keyword like align, event, "." and "->" etc will be used in CTF metadata syntax. This patch support for handling those keywords with DPDK events name. Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_common_trace_ctf.c | 119 +++

[dpdk-dev] [PATCH v2 05/32] eal/trace: add internal trace init and fini interface

2020-03-25 Thread jerinj
From: Jerin Jacob Define eal_trace_init() and eal_trace_fini() EAL interface functions that rte_eal_init() and rte_eal_cleanup() function can be use to initialize and finalize the trace subsystem. eal_trace_init() function will add the following functionality if trace is enabled through EAL comma

[dpdk-dev] [PATCH v2 06/32] eal/trace: get bootup timestamp for trace

2020-03-25 Thread jerinj
From: Jerin Jacob Find epoch_sec, epoch_nsec and uptime_ticks time information on eal_trace_init()/bootup to derive the time in the trace. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace.c | 3 +++ .../common/eal_common_trace_utils.c | 22 +

[dpdk-dev] [PATCH v2 07/32] eal/trace: create CTF TDSL metadata in memory

2020-03-25 Thread jerinj
From: Jerin Jacob Common trace format(CTF) defines the metadata[1][2] for trace events, This patch creates the metadata for the DPDK events in memory and latter this will be saved to trace directory on rte_trace_save() invocation. [1] https://diamon.org/ctf/#specification [2] https://diamon.org/

[dpdk-dev] [PATCH v2 03/32] eal/trace: implement trace register API

2020-03-25 Thread jerinj
From: Jerin Jacob The consumers of trace API defines the tracepoint and registers to eal. Internally these tracepoints will be stored in STAILQ for future use. This patch implements the tracepoint registration function. Signed-off-by: Jerin Jacob --- MAINTAINERS

[dpdk-dev] [PATCH v2 04/32] eal/trace: implement trace operation APIs

2020-03-25 Thread jerinj
From: Jerin Jacob This patch implements the following public trace APIs. - rte_trace_global_is_enabled() - rte_trace_global_is_disabled() - rte_trace_is_id_invalid() - rte_trace_global_level_set() - rte_trace_global_level_get() - rte_trace_global_mode_set() - rte_trace_global_mode_get() - rte_tr

[dpdk-dev] [PATCH v2 02/32] eal: define the public API for trace support

2020-03-25 Thread jerinj
From: Jerin Jacob Define the public API for trace support. This patch also adds support for the build infrastructure and update the MAINTAINERS file for the trace subsystem. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 6 + confi

[dpdk-dev] [PATCH v2 00/32] DPDK Trace support

2020-03-25 Thread jerinj
From: Jerin Jacob v2: Addressed the following review comments from Mattias Rönnblom: 1) Changed from: typedef uint64_t* rte_trace_t; to typedef uint64_t rte_trace_t; Initially thought to make the handle as struct rte_trace { uint64_t val; } but changed to uint64_t for the following reas

[dpdk-dev] [PATCH v2 01/32] eal: introduce API for getting thread name

2020-03-25 Thread jerinj
From: Jerin Jacob Introduce rte_thread_getname() API to get the thread name and implement it for Linux and FreeBSD. FreeBSD does not support getting the thread name. One of the consumers of this API will be the trace subsystem where it used as an informative purpose. Signed-off-by: Jerin Jacob

Re: [dpdk-dev] [RFC] ring: make ring implementation non-inlined

2020-03-25 Thread Jerin Jacob
On Fri, Mar 20, 2020 at 10:11 PM Konstantin Ananyev wrote: > > As was discussed here: > http://mails.dpdk.org/archives/dev/2020-February/158586.html > this RFC aimed to hide ring internals into .c and make all > ring functions non-inlined. In theory that might help to > maintain ABI stability in f

Re: [dpdk-dev] [PATCH v3 1/3] eal/linux: select iova-mode va with no-huge option

2020-03-25 Thread dwilder
On 2020-03-23 23:19, Jerin Jacob wrote: On Mon, Mar 23, 2020 at 11:11 PM dwilder wrote: Thanks you for your review Jerin. See my responses are inline. On 2020-03-20 06:24, Jerin Jacob wrote: > On Fri, Feb 21, 2020 at 4:22 AM David Wilder > wrote: >> >> If --no-huge is set and iova-mode has

Re: [dpdk-dev] [RFC 5/6] ring: introduce HTS ring mode

2020-03-25 Thread Honnappa Nagarahalli
> > Introduce head/tail sync mode for MT ring synchronization. > In that mode enqueue/dequeue operation is fully serialized: > only one thread at a time is allowed to perform given op. > Suppose to reduce stall times in case when ring is used on overcommitted > cpus (multiple active threads on t

Re: [dpdk-dev] [RFC 1/1] lib/ring: add scatter gather and serial dequeue APIs

2020-03-25 Thread Honnappa Nagarahalli
> > > > > > > > > > +/** > > > > > > + * @internal Reserve ring elements to enqueue several objects > > > > > > +on the ring > > > > > > + * > > > > > > + * @param r > > > > > > + * A pointer to the ring structure. > > > > > > + * @param esize > > > > > > + * The size of ring element, in byt

Re: [dpdk-dev] [RFC 0/6] New sync modes for ring

2020-03-25 Thread Honnappa Nagarahalli
> Subject: [dpdk-dev] [RFC 0/6] New sync modes for ring > > Upfront note - that RFC is not a complete patch. > It introduces an ABI breakage, plus it doesn't update ring_elem code properly, As per the current rules, these changes (in the current form) will be accepted only for 20.11 release. Ho

[dpdk-dev] [PATCH] net/mlx5: fix call to modify action without init item

2020-03-25 Thread Asaf Penso
The item is being set according to the attribute value, whether it is udp/tcp or ipv4/6. Also, there are two condition calls. If the attribute is neither udp/tcp or ipv4/6 the item is not initialized at all, but the call to the flow_dv_convert_modify_action is still being done. Also, even if the a

[dpdk-dev] [PATCH v6] net/vmxnet3: Added mtu_set() function to allow setting MTU.

2020-03-25 Thread Eduard Serra
(Picked up from @Charles Myers patch https://patchwork.dpdk.org/patch/57771/) When the mtu_set() function is not implemented, rte_eth_dev_set_mtu() fails with -ENOTSUP and mtu is not stored in the mtu field in the rte_eth_dev_data. This causes the mtu in Vmxnet3_MiscConf which is shared with hype

Re: [dpdk-dev] [PATCH] cryptodev: fix missing device id range checking

2020-03-25 Thread Akhil Goyal
> -Original Message- > From: dev On Behalf Of Akhil Goyal > Sent: Friday, March 13, 2020 12:50 PM > To: Adam Dybkowski ; dev@dpdk.org; > fiona.tr...@intel.com > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] cryptodev: fix missing device id range > checking > > > Fixes: 3dd4435

Re: [dpdk-dev] [PATCH v2 1/2] crypto/qat: support DOCSIS AES-256

2020-03-25 Thread Akhil Goyal
> > > > This patch adds support for DOCSIS AES-256 when using qat > > > > Signed-off-by: Mairtin o Loingsigh > Acked-by: Fiona Trahe Series Applied to dpdk-next-crypto Thanks.

  1   2   >