From: Akhil Goyal <akhil.go...@nxp.com>
>> + if (seg->length > 64000) {
>Shouldn't this be seg->length + RTE_PKTMBUF_HEADROOM and you don't need A
>check again in assert.
>64000 should be a MACRO
Adding macro for this at rte_bbdev level in new version uploaded today.
>> + data = rte_malloc(NULL, 128 * 1024, 0);
>Again hard coding. Define some macros to know the basis of this value.
>
>> + Updated the ``turbo_sw`` bbdev driver with changes including:
>> +
>> + * Support for large size code block not fitting in one mbuf segment.
>> + * Exposes the accurate LLR decimal assumption.
>
>Is it really worth to highlight this in release note? You even suggested not
>to Backport it to stable. I am not sure if it is really that important to be
>highlighted In release notes.
>If at all, this patch is not changing the LLR decimal. This should be moved to
>Appropriate patch.
Removed.
Thanks
