[dpdk-dev] [PATCH v2] net/i40e: implement hash function in rte flow API

2020-03-18 Thread Chenxu Di
implement set hash global configurations, set symmetric hash enable and set hash input set in rte flow API. Signed-off-by: Chenxu Di --- v2: -canceled remove legacy filter functions. --- doc/guides/nics/i40e.rst | 14 + doc/guides/rel_notes/release_20_05.rst | 6 + drivers/net/

Re: [dpdk-dev] [PATCH] net/ipn3ke: use ctrl thread to check link status

2020-03-18 Thread Xu, Rosen
Hi, > -Original Message- > From: Pei, Andy > Sent: Monday, March 16, 2020 14:07 > To: dev@dpdk.org > Cc: Pei, Andy ; Xu, Rosen ; > sta...@dpdk.org; david.march...@redhat.com; Ye, Xiaolong > ; Yigit, Ferruh > Subject: [PATCH] net/ipn3ke: use ctrl thread to check link status > > ipn3ke dr

[dpdk-dev] [PATCH] kvargs: fix a heap-buffer-overflow when detect list

2020-03-18 Thread wangyunjian
From: Yunjian Wang When an input params'value is '[', leading to the 'str' over read or heap-buffer-overflow. So we can check the 'ctx1' length to avoid this problem. Fixes: cc0579f2339a ("kvargs: support list value") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/librte_kvargs/rte_k

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status inconsistencies

2020-03-18 Thread Zhu, TaoX
+Jiang Yu BR, Zhu, Tao > -Original Message- > From: Zhu, TaoX > Sent: Tuesday, March 3, 2020 10:00 AM > To: Ananyev, Konstantin ; Lu, Wenzhuo > ; Ye, Xiaolong > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/ixgbe: fix link status inconsistencies > > +Xiaolong > > BR, >

Re: [dpdk-dev] [PATCH 1/2] net/iavf: support generic flow

2020-03-18 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Qiming Yang > Sent: Tuesday, March 17, 2020 4:18 PM > To: dev@dpdk.org > Cc: Yang, Qiming > Subject: [dpdk-dev] [PATCH 1/2] net/iavf: support generic flow > > This patch added iavf_flow_create, iavf_flow_destroy, iavf_flow_flush and > iavf

Re: [dpdk-dev] [PATCH 2/5] net/iavf: add support for FDIR GTPU

2020-03-18 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Wednesday, March 18, 2020 1:42 PM > To: Ye, Xiaolong ; Zhang, Qi Z > Cc: dev@dpdk.org; Cao, Yahui ; Wu, Jingjing > ; Su, Simei > Subject: [PATCH 2/5] net/iavf: add support for FDIR GTPU > > This patch enables GTPU pattern for RTE_FLOW.

Re: [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power builds

2020-03-18 Thread Xu, Rosen
Thanks David. > -Original Message- > From: David Marchand > Sent: Wednesday, March 18, 2020 3:39 > To: David Christensen > Cc: Xu, Rosen ; Gaetan Rivet ; dev > ; Richardson, Bruce ; David > Wilder > Subject: Re: [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power > builds >

[dpdk-dev] [PATCH v1 24/26] l3fwd-graph: add graph based l3fwd skeleton

2020-03-18 Thread jerinj
From: Nithin Dabilpuram Add graph based l3fwd application skeleton with cmdline parsing support inline with normal l3fwd. Signed-off-by: Nithin Dabilpuram --- MAINTAINERS | 3 + examples/Makefile| 3 + examples/l3fwd-graph/Makefile| 58 exampl

[dpdk-dev] [PATCH v1 26/26] l3fwd-graph: add graph config and main loop

2020-03-18 Thread jerinj
From: Nithin Dabilpuram Add graph creation, configuration logic and graph main loop. This graph main loop is run on every slave lcore and calls rte_graph_walk() to walk over lcore specific rte_graph. Master core accumulates and prints graph walk stats of all the lcore's graph's. Signed-off-by: N

[dpdk-dev] [PATCH v1 22/26] node: add ipv4 rewrite and lookup ctrl API

2020-03-18 Thread jerinj
From: Nithin Dabilpuram Add ip4_rewrite and ip4_lookup ctrl API. ip4_lookup ctrl API is used to add route entries for LPM lookup with result data containing next hop id and next proto. ip4_rewrite ctrl API is used to add rewrite data for every next hop. Signed-off-by: Nithin Dabilpuram Signed-o

[dpdk-dev] [PATCH v1 25/26] l3fwd-graph: add ethdev configuration changes

2020-03-18 Thread jerinj
From: Nithin Dabilpuram Add changes to ethdev port and queue configuration based on command line parameters for l3fwd graph application. Signed-off-by: Nithin Dabilpuram --- examples/l3fwd-graph/main.c | 350 +++- 1 file changed, 349 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v1 23/26] node: add pkt drop node

2020-03-18 Thread jerinj
From: Nithin Dabilpuram Add pkt drop node process function for pkt_drop rte_node. This node simply free's every object received as an rte_mbuf to its rte_pktmbuf pool. Signed-off-by: Nithin Dabilpuram Signed-off-by: Pavan Nikhilesh Signed-off-by: Kiran Kumar K --- lib/librte_node/Makefile

[dpdk-dev] [PATCH v1 21/26] node: add ipv4 rewrite node

2020-03-18 Thread jerinj
From: Kiran Kumar K Add ip4 rewrite process function for ip4_rewrite rte_node. On every packet received by this node, header is overwritten with new data before forwarding it to next node. Header data to overwrite with is identified by next hop id passed in mbuf priv data by previous node. Signe

[dpdk-dev] [PATCH v1 18/26] node: add ethdev Rx and Tx node ctrl API

2020-03-18 Thread jerinj
From: Nithin Dabilpuram Add ctrl api to setup ethdev_rx and ethdev_tx node. This ctrl api clones 'N' number of ethdev_rx and ethdev_tx nodes with specific (port, queue) pairs updated in their context. All the ethdev ports and queues are setup before this api is called. Signed-off-by: Nithin Dabi

[dpdk-dev] [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-18 Thread jerinj
From: Pavan Nikhilesh Add IPv4 lookup process function for ip4_lookup rte_node. This node performs LPM lookup using x86_64 vector supported RTE_LPM API on every packet received and forwards it to a next node that is identified by lookup result. Signed-off-by: Pavan Nikhilesh Signed-off-by: Nith

[dpdk-dev] [PATCH v1 17/26] node: add ethdev Tx node

2020-03-18 Thread jerinj
From: Nithin Dabilpuram Add rte_node ethdev_tx process function and register it to graph infra. This node has a specific (port, tx-queue) as context and it enqueue's all the packets received to that specific queue pair. When rte_eth_tx_burst() i.e enqueue to queue pair fails, packets are forwarde

[dpdk-dev] [PATCH v1 19/26] node: ipv4 lookup for arm64

2020-03-18 Thread jerinj
From: Nithin Dabilpuram Add arm64 specific IPv4 lookup process function for ip4_lookup node. This node performs LPM lookup on every packet received and forwards it to a next node that is identified by lookup result. Signed-off-by: Nithin Dabilpuram Signed-off-by: Kiran Kumar K Signed-off-by: P

[dpdk-dev] [PATCH v1 14/26] graph: add performance testcase

2020-03-18 Thread jerinj
From: Pavan Nikhilesh Add unit test framework to create and test performance of various graph models. example command to test: echo "graph_perf_autotest" | sudo ./build/app/test/dpdk-test -c 0x30 Signed-off-by: Pavan Nikhilesh --- app/test/Makefile |1 + app/test/meson.build

[dpdk-dev] [PATCH v1 16/26] node: add ethdev Rx node

2020-03-18 Thread jerinj
From: Nithin Dabilpuram Add source rte_node ethdev_rx process function and register it. This node is a source node that will be called periodically and when called, performs rte_eth_rx_burst() on a specific (port, queue) pair and enqueue them as stream of objects to next node. Signed-off-by: Nit

[dpdk-dev] [PATCH v1 11/26] graph: implement stats support

2020-03-18 Thread jerinj
From: Jerin Jacob Adding implementation for graph stats collection API. This API will create a cluster for a specified node pattern and aggregate the node runtime stats. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh Signed-off-by: Nithin Dabilpuram --

[dpdk-dev] [PATCH v1 13/26] graph: add unit test case

2020-03-18 Thread jerinj
From: Kiran Kumar K Adding the unit test to test the functionality of node and graph APIs. Testing includes registering a node, cloning a node, creating a graph, perform graph walk, collecting stats and all node and graph debug APIs. example command to test: echo "graph_autotest" | sudo ./build/

[dpdk-dev] [PATCH v1 15/26] node: add log infra and null node

2020-03-18 Thread jerinj
From: Nithin Dabilpuram Add log infra for node specific logging. Also, add null rte_node that just ignores all the objects directed to it. Signed-off-by: Nithin Dabilpuram Signed-off-by: Pavan Nikhilesh Signed-off-by: Kiran Kumar K --- MAINTAINERS | 5 + config/

[dpdk-dev] [PATCH v1 12/26] graph: implement fastpath API routines

2020-03-18 Thread jerinj
From: Jerin Jacob Adding implementation for rte_graph_walk() API. This will perform a walk on the circular buffer and call the process function of each node and collect the stats if stats collection is enabled. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhil

[dpdk-dev] [PATCH v1 06/26] graph: populate fastpath memory for graph reel

2020-03-18 Thread jerinj
From: Jerin Jacob Adding support to create and populate the memory for graph reel. This includes reserving the memory in the memzone, populating the nodes, Allocating memory for node-specific streams to hold objects. Once it is populated the reel memory contains the following sections. +---

[dpdk-dev] [PATCH v1 08/26] graph: implement graph operation APIs

2020-03-18 Thread jerinj
From: Jerin Jacob Adding support for graph specific API implementation like Graph lookup to get graph object, retrieving graph ID >From name and graph name from ID. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh --- lib/librte_graph/graph.c

[dpdk-dev] [PATCH v1 10/26] graph: implement debug routines

2020-03-18 Thread jerinj
From: Jerin Jacob Adding implementation for graph specific API to dump the Graph information to a file. This API will dump detailed internal info about node objects and graph objects. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh --- lib/librte_graph/

[dpdk-dev] [PATCH v1 07/26] graph: implement create and destroy APIs

2020-03-18 Thread jerinj
From: Jerin Jacob Adding graph specific API implementations like graph create and graph destroy. This detect loops in the graph, check for isolated nodes and operation to verify the validity of graph. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh ---

[dpdk-dev] [PATCH v1 09/26] graph: implement Graphviz export

2020-03-18 Thread jerinj
From: Jerin Jacob Adding API implementation support exporting the graph object to file. This will export the graph to a file in Graphviz format. It can be viewed in many viewers such as https://dreampuf.github.io/GraphvizOnline/ Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-of

[dpdk-dev] [PATCH v1 05/26] graph: implement internal graph operation helpers

2020-03-18 Thread jerinj
From: Jerin Jacob Adding internal graph API helpers support to check whether a graph has isolated nodes and any node have a loop to itself and BFS algorithm implementation etc. Signed-off-by: Jerin Jacob --- lib/librte_graph/Makefile| 1 + lib/librte_graph/graph.c | 2 +- l

[dpdk-dev] [PATCH v1 04/26] graph: implement node debug routines

2020-03-18 Thread jerinj
From: Jerin Jacob Adding node debug API implementation support to dump single or all the node objects to the given file. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh --- lib/librte_graph/Makefile | 1 + lib/librte_graph/graph_debug.c

[dpdk-dev] [PATCH v1 03/26] graph: implement node operations

2020-03-18 Thread jerinj
From: Jerin Jacob Adding node-specific API implementation like cloning node, updating edges for the node, shrinking edges of a node, retrieving edges of a node. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh --- lib/librte_graph/graph_private.h |

[dpdk-dev] [PATCH v1 02/26] graph: implement node registration

2020-03-18 Thread jerinj
From: Jerin Jacob Adding rte_node_register() API implementation includes allocating memory for node object, check for duplicate node name and add the allocated node to STAILQ node_list for future use. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K Signed-off-by: Pavan Nikhilesh ---

[dpdk-dev] [PATCH v1 00/26] graph: introduce graph subsystem

2020-03-18 Thread jerinj
From: Jerin Jacob It is the v1 version of the DPDK graph support based on the following RFC http://patches.dpdk.org/cover/65432/ This patch set contains an implementation of graph architecture for packet processing using DPDK primitives. Using graph traversal for packet processing is a proven a

[dpdk-dev] [PATCH v1 01/26] graph: define the public API for graph support

2020-03-18 Thread jerinj
From: Jerin Jacob Graph architecture abstracts the data processing functions as "node" and "link" them together to create a complex "graph" to enable reusable/modular data processing functions. These APIs enables graph framework operations such as create, lookup, dump and destroy on graph and no

Re: [dpdk-dev] [PATCH v1 02/32] eal: define the public API for trace support

2020-03-18 Thread Mattias Rönnblom
On 2020-03-18 20:02, jer...@marvell.com wrote: > From: Jerin Jacob > > Define the public API for trace support. > This patch also adds support for the build infrastructure and > update the MAINTAINERS file for the trace subsystem. > > Signed-off-by: Jerin Jacob > Signed-off-by: Sunil Kumar Kori

[dpdk-dev] [PATCH v3 1/4] net/netvsc: propagate descriptor limits from VF to netvsc

2020-03-18 Thread Stephen Hemminger
If application cares about descriptor limits, the netvsc device values should reflect those of the VF as well. Fixes: dc7680e8597c ("net/netvsc: support integrated VF") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_vf.c | 13 + 1 file changed, 13 inse

[dpdk-dev] [PATCH v3 4/4] net/netvsc: don't enable RSS if only single receive queue

2020-03-18 Thread Stephen Hemminger
If application has multiple transmit queues but only a single receive queue, then do not enable RSS. Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 13 - 1 file cha

[dpdk-dev] [PATCH v3 3/4] net/netvsc: split send buffers from transmit descriptors

2020-03-18 Thread Stephen Hemminger
The VMBus has reserved transmit area (per device) and transmit descriptors (per queue). The previous code was always having a 1:1 mapping between send buffers and descriptors. This can lead to one queue starving another and also buffer bloat. Change to working more like FreeBSD where there is a po

[dpdk-dev] [PATCH v3 2/4] net/netvsc: handle receive packets during multi-channel setup

2020-03-18 Thread Stephen Hemminger
It is possible for a packet to arrive during the configuration process when setting up multiple queue mode. This would cause configure to fail; fix by just ignoring receive packets while waiting for control commands. Use the receive ring lock to avoid possible races between oddly behaved applicati

[dpdk-dev] [PATCH v3 0/4] net/netvsc patches

2020-03-18 Thread Stephen Hemminger
These are bug fixes for netvsc PMD mostly related to issues discovered by users of multi-queue. v3 - fix checkpatch complaints v2 - simplify the locking on multi-channel setup add patches to handle single queue and tx descriptor pool Stephen Hemminger (4): net/netvsc: propagate descriptor

[dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-03-18 Thread Arek Kusztal
This patch adds versioned function rte_cryptodev_info_get. Node 20.05 function works the same way it was working before. Node 20.0 function strips capability added in 20.05 release to prevent some issues with ABI policy. To do that new capability array is allocated per device and returned to user i

[dpdk-dev] [PATCH v2 1/4] net/netvsc: propogate descriptor limits from VF to netvsc

2020-03-18 Thread Stephen Hemminger
If application cares about descriptor limits, the netvsc device values should reflect those of the VF as well. Fixes: dc7680e8597c ("net/netvsc: support integrated VF") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_vf.c | 13 + 1 file changed, 13 inse

[dpdk-dev] [PATCH v2 4/4] net/netvsc: don't enable RSS if only single receive queue

2020-03-18 Thread Stephen Hemminger
If application has multiple transmit queues but only a single receive queue, then do not enable RSS. Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 13 - 1 file cha

[dpdk-dev] [PATCH v2 2/4] net/netvsc: handle receive packets during multi-channel setup

2020-03-18 Thread Stephen Hemminger
It is possible for a packet to arrive during the configuration process when setting up multiple queue mode. This would cause configure to fail; fix by just ignoring receive packets while waiting for control commands. Use the receive ring lock to avoid possible races between oddly behaved applicati

[dpdk-dev] [PATCH v2 0/4] net/netvsc patches

2020-03-18 Thread Stephen Hemminger
These are bug fixes for netvsc PMD mostly related to issues discovered by users of multi-queue. v2 -- simplify the locking on multi-channel setup add patches to handle single queue and tx descriptor pool Stephen Hemminger (4): net/netvsc: propogate descriptor limits from VF to netvsc ne

[dpdk-dev] [PATCH v2 3/4] net/netvsc: split send buffers from transmit descriptors

2020-03-18 Thread Stephen Hemminger
The VMBus has reserved transmit area (per device) and transmit descriptors (per queue). The previous code was always having a 1:1 mapping between send buffers and descriptors. This can lead to one queue starving another and also buffer bloat. Change to working more like FreeBSD where there is a po

[dpdk-dev] [PATCH v1 32/32] doc: add trace library guide

2020-03-18 Thread jerinj
From: Sunil Kumar Kori Add programmar's guide for trace library support. Signed-off-by: Sunil Kumar Kori Signed-off-by: Jerin Jacob --- doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/trace_lib.rst| 264 + doc/guides/rel_notes/release_20_05.rs

[dpdk-dev] [PATCH v1 28/32] ethdev: add tracepoints

2020-03-18 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 2 + app/pdump/Makefile| 1 + app/pdump/meson.build | 1 + app/

[dpdk-dev] [PATCH v1 31/32] mempool: add tracepoints

2020-03-18 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS| 2 + drivers/common/cpt/Makefile| 1 + drivers/mempool/ring/Makefile | 1 + drivers/me

[dpdk-dev] [PATCH v1 29/32] eventdev: add tracepoints

2020-03-18 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 2 + drivers/event/skeleton/Makefile | 1 + drivers/event/skeleton/meson.build| 1 + l

[dpdk-dev] [PATCH v1 30/32] cryptodev: add tracepoints

2020-03-18 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 2 + drivers/crypto/ccp/Makefile | 1 + drivers/crypto/ccp/meson.build| 2 + d

[dpdk-dev] [PATCH v1 27/32] eal/trace: add trace performance test cases

2020-03-18 Thread jerinj
From: Jerin Jacob This test case shall be used to measure the trace overhead. Example command to run the performance test case. echo "trace_perf" | ./build/app/test/dpdk-test -c 0x3 --trace-level=8 Signed-off-by: Jerin Jacob --- app/test/Makefile | 1 + app/test/meson.build

[dpdk-dev] [PATCH v1 25/32] eal/trace: add trace mode configuration parameter

2020-03-18 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-mode eal parameter to configure event record mode when ring buffers are full. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 12 ++ lib/librte_eal/common/eal_common_options.c| 17 .../com

[dpdk-dev] [PATCH v1 23/32] eal/trace: add trace dir configuration parameter

2020-03-18 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-dir EAL parameter to configure directory where traces will be generated. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 11 lib/librte_eal/common/eal_common_options.c| 15 ++ .../common/eal_c

[dpdk-dev] [PATCH v1 26/32] eal/trace: add unit test cases

2020-03-18 Thread jerinj
From: Sunil Kumar Kori Example commands to run UT and check the traces with babeltrace viewer. - Delete the existing /root/dpdk-traces/ directory if needed. > sudo rm -rf /root/dpdk-traces/ - Start the dpdk-test > sudo ./build/app/test/dpdk-test -c 0x3 - --trace-level=8 - Run trace_autotest >

[dpdk-dev] [PATCH v1 24/32] eal/trace: add trace bufsize configuration parameter

2020-03-18 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-bufsz EAL parameter to configure maximum size of ring buffer where events are to be stored. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 13 lib/librte_eal/common/eal_common_options.c| 17 +

[dpdk-dev] [PATCH v1 22/32] eal/trace: add trace level configuration parameter

2020-03-18 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-level EAL parameter to configure global and trace point specific level. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 19 lib/librte_eal/common/eal_common_options.c| 19 +++- lib/librte_eal/co

[dpdk-dev] [PATCH v1 19/32] eal/trace: add memzone tracepoints

2020-03-18 Thread jerinj
From: Jerin Jacob Add the following memzone related tracepoints. rte_trace_lib_eal_memzone_reserve rte_trace_lib_eal_memzone_lookup rte_trace_lib_eal_memzone_free Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_memzone.c| 9 +++ .../common/eal_common_trace_points.c

[dpdk-dev] [PATCH v1 14/32] eal/trace: hook internal trace APIs to Linux

2020-03-18 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to Linux EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_thread.c | 3 ++- lib/librte_eal/linux/eal/eal.c| 9 + lib/librte_eal/linux/eal/eal_thread.c | 3 +++ 3 files changed, 14 insertions(

[dpdk-dev] [PATCH v1 21/32] eal/trace: add interrupt tracepoints

2020-03-18 Thread jerinj
From: Jerin Jacob Add the following interrupt related tracepoints. rte_trace_lib_eal_intr_callback_register; rte_trace_lib_eal_intr_callback_unregister; rte_trace_lib_eal_intr_enable; rte_trace_lib_eal_intr_disable; Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points.c

[dpdk-dev] [PATCH v1 20/32] eal/trace: add thread tracepoints

2020-03-18 Thread jerinj
From: Jerin Jacob Add the following thread related tracepoints. rte_trace_lib_eal_thread_remote_launch; rte_trace_lib_eal_thread_lcore_ready; Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace_points.c | 9 + lib/librte_eal/common/include/rte_trace_eal.h | 14 +++

[dpdk-dev] [PATCH v1 18/32] eal/trace: add memory tracepoints

2020-03-18 Thread jerinj
From: Jerin Jacob Add the following memory-related tracepoints. rte_trace_lib_eal_mem_zmalloc; rte_trace_lib_eal_mem_malloc; rte_trace_lib_eal_mem_realloc; rte_trace_lib_eal_mem_free; rte_malloc() and rte_free() has been used in the trace implementation, in order to avoid tracing implementation

[dpdk-dev] [PATCH v1 17/32] eal/trace: add alarm tracepoints

2020-03-18 Thread jerinj
From: Jerin Jacob Add following alarm related trace points. rte_trace_lib_eal_alarm_set() rte_trace_lib_eal_alarm_cancel() Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points.c | 9 + lib/librte_eal/common/include/rte_trace_eal.h | 18 ++ lib/

[dpdk-dev] [PATCH v1 16/32] eal/trace: add generic tracepoints

2020-03-18 Thread jerinj
From: Jerin Jacob This patch creates the following generic tracepoint for generic tracing when there is no dedicated tracepoint is available. rte_trace_lib_eal_generic_void() rte_trace_lib_eal_generic_u64() rte_trace_lib_eal_generic_u32() rte_trace_lib_eal_generic_u16() rte_trace_lib_eal_generic

[dpdk-dev] [PATCH v1 11/32] eal/trace: implement trace save

2020-03-18 Thread jerinj
From: Jerin Jacob Implement rte_trace_save(), which will save the metadata file and trace memory snapshot to the trace directory. Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_utils.c | 75 +++ lib/librte_eal/rte_eal_version.map| 1 + 2 files

[dpdk-dev] [PATCH v1 13/32] eal/trace: implement provider payload

2020-03-18 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_ctf_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace mem emitters aka provider payload. When it used as provider payload, those function copy the trace field to tr

[dpdk-dev] [PATCH v1 15/32] eal/trace: hook internal trace APIs to FreeBSD

2020-03-18 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to FreeBSD EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/freebsd/eal/eal.c| 10 ++ lib/librte_eal/freebsd/eal/eal_thread.c | 3 +++ 2 files changed, 13 insertions(+) diff --git a/lib/librte_eal/freebsd/eal/eal.c

[dpdk-dev] [PATCH v1 09/32] eal/trace: implement trace memory allocation

2020-03-18 Thread jerinj
From: Jerin Jacob Trace memory will be allocated per thread to enable lockless trace events updates to the memory. The allocator will first attempt to allocate from hugepage, if not available from hugepage then fallback to malloc memory. Later in the patches series, This API will be hooked to DP

[dpdk-dev] [PATCH v1 10/32] eal/trace: implement debug dump function

2020-03-18 Thread jerinj
From: Jerin Jacob Implement rte_trace_metadata_dump() and rte_trace_dump() functions. Former one used to dump the CTF metadata file and the latter one to dump all the registered events and its status. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_com

[dpdk-dev] [PATCH v1 12/32] eal/trace: implement registration payload

2020-03-18 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_ctf_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace memory emitters. When it used as registration payload, it will do the following to fulfill the registration jo

[dpdk-dev] [PATCH v1 08/32] eal/trace: handle CTF keyword collision

2020-03-18 Thread jerinj
From: Sunil Kumar Kori Some of the keyword like align, event, "." and "->" etc will be used in CTF metadata syntax. This patch support for handling those keywords with DPDK events name. Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_common_trace_ctf.c | 119 +++

[dpdk-dev] [PATCH v1 06/32] eal/trace: get bootup timestamp for trace

2020-03-18 Thread jerinj
From: Jerin Jacob Find epoch_sec, epoch_nsec and uptime_ticks time information on eal_trace_init()/bootup to derive the time in the trace. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace.c | 3 +++ .../common/eal_common_trace_utils.c | 22 +

[dpdk-dev] [PATCH v1 07/32] eal/trace: create CTF TDSL metadata in memory

2020-03-18 Thread jerinj
From: Jerin Jacob Common trace format(CTF) defines the metadata[1][2] for trace events, This patch creates the metadata for the DPDK events in memory and latter this will be saved to trace directory on rte_trace_save() invocation. [1] https://diamon.org/ctf/#specification [2] https://diamon.org/

[dpdk-dev] [PATCH v1 05/32] eal/trace: add internal trace init and fini interface

2020-03-18 Thread jerinj
From: Jerin Jacob Define eal_trace_init() and eal_trace_fini() EAL interface functions that rte_eal_init() and rte_eal_cleanup() function can be use to initialize and finalize the trace subsystem. eal_trace_init() function will add the following functionality if trace is enabled through EAL comma

[dpdk-dev] [PATCH v1 02/32] eal: define the public API for trace support

2020-03-18 Thread jerinj
From: Jerin Jacob Define the public API for trace support. This patch also adds support for the build infrastructure and update the MAINTAINERS file for the trace subsystem. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 6 + confi

[dpdk-dev] [PATCH v1 04/32] eal/trace: implement trace operation APIs

2020-03-18 Thread jerinj
From: Jerin Jacob This patch implements the following public trace APIs. - rte_trace_global_is_enabled() - rte_trace_global_is_disabled() - rte_trace_is_id_invalid() - rte_trace_global_level_set() - rte_trace_global_level_get() - rte_trace_global_mode_set() - rte_trace_global_mode_get() - rte_tr

[dpdk-dev] [PATCH v1 03/32] eal/trace: implement trace register API

2020-03-18 Thread jerinj
From: Jerin Jacob The consumers of trace API defines the tracepoint and registers to eal. Internally these tracepoints will be stored in STAILQ for future use. This patch implements the tracepoint registration function. Signed-off-by: Jerin Jacob --- MAINTAINERS

[dpdk-dev] [PATCH v1 01/32] eal: introduce API for getting thread name

2020-03-18 Thread jerinj
From: Jerin Jacob Introduce rte_thread_getname() API to get the thread name and implement it for Linux and FreeBSD. FreeBSD does not support getting the thread name. One of the consumers of this API will be the trace subsystem where it used as an informative purpose. Signed-off-by: Jerin Jacob

[dpdk-dev] [PATCH v1 00/32] DPDK Trace support

2020-03-18 Thread jerinj
From: Jerin Jacob It is the v1 version of the DPDK trace support based on the following RFC https://www.mail-archive.com/dev@dpdk.org/msg154457.html This patch set contains # The native implementation of common trace format(CTF)[1] based tracer # Public API to create

Re: [dpdk-dev] [PATCH 0/2] net/netvsc: patches

2020-03-18 Thread Stephen Hemminger
On Wed, 18 Mar 2020 17:33:18 + Ferruh Yigit wrote: > On 3/16/2020 11:56 PM, Stephen Hemminger wrote: > > A couple of fixes for netvsc PMD. > > The first is more serious than the second. > > > > Stephen Hemminger (2): > > net/netvsc: handle receive packets during multi-channel setup > > n

Re: [dpdk-dev] [PATCH 0/2] net/netvsc: patches

2020-03-18 Thread Ferruh Yigit
On 3/16/2020 11:56 PM, Stephen Hemminger wrote: > A couple of fixes for netvsc PMD. > The first is more serious than the second. > > Stephen Hemminger (2): > net/netvsc: handle receive packets during multi-channel setup > net/netvsc: avoid mixing buffered and direct packets > Series applied

[dpdk-dev] [RFC] net/mlx5: support match on IPv4 and IPv6 fragment fields

2020-03-18 Thread Dekel Peled
In order to send a packet that is larger than the path MTU, the sending node splits the packet into fragments. IPv4 Flags and Fragment Offset header fields , and IPv6 fragment extension header fields, contain the required Information to

[dpdk-dev] [RFC] ethdev: add IPv6 fragment extension header item

2020-03-18 Thread Dekel Peled
Applications handling fragmented IPv6 packets need to match on IPv6 fragment extension header, in order to identify the fragments order and location in the packet. This RFC introduced the IPv6 fragment extension header item. Signed-off-by: Dekel Peled mailto:dek...@mellanox.com>> --- diff --git

[dpdk-dev] [PATCH 2/2] test/compress: im buffer too small - add unit tests

2020-03-18 Thread Adam Dybkowski
This patch adds new test suites for verification of the "internal QAT IM buffer too small" case handling. These unit tests are specific to the QAT PMD only - that's why they are contained in new test suites (separate for positive and negative tests for better maintability). Signed-off-by: Adam Dyb

[dpdk-dev] [PATCH 1/2] drivers/qat: im buffer too small - split op

2020-03-18 Thread Adam Dybkowski
This patch implements a special way of buffer handling when internal QAT IM buffer is too small for Huffman dynamic compression operation. Instead of falling back to fixed compression, the operation is now split into multiple smaller dynamic compression requests (possible to execute on QAT) and the

Re: [dpdk-dev] [PATCH v2] testpmd: added rte_eth_dev_fw_version_get in testpmd

2020-03-18 Thread Ferruh Yigit
On 3/18/2020 3:22 PM, Muhammad Ahmad wrote: > rte_eth_dev_fw_version_get() was not called in test pmd > Added rte_eth_dev_fw_version_get() in testpmd under show port info > > Bugzilla ID: 225 > > Cc: dev@dpdk.org > Reported-by: Thomas Monjalon > Signed-off-by: Muhammad Ahmad > --- > app/test-

[dpdk-dev] [PATCH v2] testpmd: added rte_eth_dev_fw_version_get in testpmd

2020-03-18 Thread Muhammad Ahmad
rte_eth_dev_fw_version_get() was not called in test pmd Added rte_eth_dev_fw_version_get() in testpmd under show port info Bugzilla ID: 225 Cc: dev@dpdk.org Reported-by: Thomas Monjalon Signed-off-by: Muhammad Ahmad --- app/test-pmd/config.c | 13 + 1 file changed, 13 insertions(+

Re: [dpdk-dev] [PATCH] kni: fix kernel deadlock when using mlx devices

2020-03-18 Thread Thomas Monjalon
17/01/2020 17:43, Ferruh Yigit: > On 12/22/2019 5:55 PM, Stephen Hemminger wrote: > > This fixes a deadlock when using KNI with bifurcated drivers. > > Bringing kni device up always times out when using Mellanox > > devices. > > > > The kernel KNI driver sends message to userspace to complete > >

Re: [dpdk-dev] [PATCH v3 00/12] generic rte atomic APIs deprecate proposal

2020-03-18 Thread Thomas Monjalon
18/03/2020 15:01, Van Haaren, Harry: > Hi Phil & Honnappa, > > From: Phil Yang > > > > DPDK provides generic rte_atomic APIs to do several atomic operations. > > These APIs are using the deprecated __sync built-ins and enforce full > > memory barriers on aarch64. However, full barriers are not n

Re: [dpdk-dev] [PATCH 0/9] net/cxgbe: updates for rte_flow support

2020-03-18 Thread Thomas Monjalon
18/03/2020 14:06, Rahul Lakkireddy: > Hi Thomas, > > On Wednesday, March 03/18/20, 2020 at 13:09:47 +0100, Thomas Monjalon wrote: > > 11/03/2020 10:05, Rahul Lakkireddy: > > > From: Karra Satwik > > > > > > This series of patches contain rte_flow support for matching > > > Q-in-Q VLAN, IP TOS, P

Re: [dpdk-dev] [PATCH] net/cxgbe: fix build with clang 3.4.2

2020-03-18 Thread Ferruh Yigit
On 3/18/2020 1:48 PM, Rahul Lakkireddy wrote: > On Wednesday, March 03/18/20, 2020 at 12:52:36 +, Ferruh Yigit wrote: >> Build error: >> .../drivers/net/cxgbe/cxgbe_flow.c:315:2: >> error: implicit truncation from 'int' to bitfield changes value >> from -1 to 7 [-Werror,-Wbitfield-const

Re: [dpdk-dev] [PATCH] net/cxgbe: fix build with clang 3.4.2

2020-03-18 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rahul Lakkireddy > Sent: Wednesday, March 18, 2020 3:48 PM > To: Ferruh Yigit > Cc: Karra Satwik ; dev@dpdk.org; Raslan > Darawsheh ; Xueming Zhang > > Subject: Re: [PATCH] net/cxgbe: fix build with clang 3.4.2 > > On Wednesday, March 03/18/20, 2020 at 1

Re: [dpdk-dev] [PATCH v3 00/12] generic rte atomic APIs deprecate proposal

2020-03-18 Thread Van Haaren, Harry
Hi Phil & Honnappa, > -Original Message- > From: Phil Yang > Sent: Tuesday, March 17, 2020 1:18 AM > To: tho...@monjalon.net; Van Haaren, Harry ; > Ananyev, Konstantin ; > step...@networkplumber.org; maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvell.

Re: [dpdk-dev] [PATCH] net/cxgbe: fix build with clang 3.4.2

2020-03-18 Thread Rahul Lakkireddy
On Wednesday, March 03/18/20, 2020 at 12:52:36 +, Ferruh Yigit wrote: > Build error: > .../drivers/net/cxgbe/cxgbe_flow.c:315:2: > error: implicit truncation from 'int' to bitfield changes value > from -1 to 7 [-Werror,-Wbitfield-constant-conversion] > CXGBE_FILL_FS(adap->pf, ~0

[dpdk-dev] [PATCH] examples/ipsec-secgw: enable cpu-crypto fallback

2020-03-18 Thread Mariusz Drost
Added cpu-crypto fallback option parsing as well as tests for it Signed-off-by: Mariusz Drost --- examples/ipsec-secgw/sa.c| 6 -- examples/ipsec-secgw/test/common_defs.sh | 12 .../test/trs_aesgcm_inline_crypto_fallback_defs.sh | 7 ++

Re: [dpdk-dev] [PATCH 0/9] net/cxgbe: updates for rte_flow support

2020-03-18 Thread Rahul Lakkireddy
Hi Thomas, On Wednesday, March 03/18/20, 2020 at 13:09:47 +0100, Thomas Monjalon wrote: > 11/03/2020 10:05, Rahul Lakkireddy: > > From: Karra Satwik > > > > This series of patches contain rte_flow support for matching > > Q-in-Q VLAN, IP TOS, PF, and VF fields. Also, adds Destination > > MAC rew

Re: [dpdk-dev] [PATCH] net/cxgbe: fix build with clang 3.4.2

2020-03-18 Thread Ferruh Yigit
On 3/18/2020 12:52 PM, Ferruh Yigit wrote: > Build error: > .../drivers/net/cxgbe/cxgbe_flow.c:315:2: > error: implicit truncation from 'int' to bitfield changes value > from -1 to 7 [-Werror,-Wbitfield-constant-conversion] > CXGBE_FILL_FS(adap->pf, ~0, pf); > ^~

[dpdk-dev] [PATCH] net/cxgbe: fix build with clang 3.4.2

2020-03-18 Thread Ferruh Yigit
Build error: .../drivers/net/cxgbe/cxgbe_flow.c:315:2: error: implicit truncation from 'int' to bitfield changes value from -1 to 7 [-Werror,-Wbitfield-constant-conversion] CXGBE_FILL_FS(adap->pf, ~0, pf); ^~~ .../drivers/net/cxgbe/cxgbe_flow.c:25

[dpdk-dev] [PATCH 3/3] net/i40e: configure RSS hash from RSS action

2020-03-18 Thread Bernard Iremonger
handle RSS offload types in RSS action handle ipv4, ipv6 and udp RSS patterns handle queue_num 0 in RSS action Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_flow.c | 46 1 file changed, 34 insertions(+), 12 deletions(-) diff --git a/driv

[dpdk-dev] [PATCH 2/3] app/testpmd: handle RSS offload types ESP and AH

2020-03-18 Thread Bernard Iremonger
parse RSS offload types ESP and AH add printf for rss_hf Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 4 +++- app/test-pmd/config.c | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index a037a55..997f063 10064

  1   2   >