Re: [dpdk-dev] [RFC v5] regexdev: introduce regexdev subsystem

2020-03-02 Thread Jerin Jacob
On Tue, Mar 3, 2020 at 1:14 PM Ori Kam wrote: > > Hi Xiang, > > May I ask when do you plan to add the Hyperscan code to the DPDK? > > > -Original Message- > > From: dev On Behalf Of Wang Xiang > > Sent: Monday, March 2, 2020 9:05 AM > > To: Ori Kam > > Cc: jer...@marvell.com; dev@dpdk.or

Re: [dpdk-dev] [RFC v5] regexdev: introduce regexdev subsystem

2020-03-02 Thread Ori Kam
Hi Xiang, May I ask when do you plan to add the Hyperscan code to the DPDK? > -Original Message- > From: dev On Behalf Of Wang Xiang > Sent: Monday, March 2, 2020 9:05 AM > To: Ori Kam > Cc: jer...@marvell.com; dev@dpdk.org; pbhagavat...@marvell.com; Shahaf > Shuler ; hemant.agra...@nxp

Re: [dpdk-dev] [PATCH v3] net/ice: fix hash flow segmentation fault

2020-03-02 Thread Ye Xiaolong
On 03/03, taox@intel.com wrote: >From: Zhu Tao > >Macro rte_errno is not a static value, so it needs to be updated in all >error handling code. > >Patch 'dc36bd5dfdeb' mistakenly consider that rte_errno is a constant, >which causes the unrecognized flow rule to be marked as recognition >succes

Re: [dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error

2020-03-02 Thread Matan Azrad
Hi From: xiangxia.m@gmail.com > From: Tonghao Zhang > > When setting the CONFIG_RTE_BUILD_SHARED_LIB to y, and build the mlx5 > pmd, there is a building error. > To fix it, add RTE_IBVERBS_LINK_DLOPEN to include relative codes. > > > mlx5_common.o: In function `mlx5_glue_init': > > driver

Re: [dpdk-dev] [EXT] [RFC v5] regexdev: introduce regexdev subsystem

2020-03-02 Thread Ori Kam
Hi All, > -Original Message- > From: Jerin Jacob > Sent: Monday, March 2, 2020 9:19 AM > To: Pavan Nikhilesh Bhagavatula > Cc: Ori Kam ; Jerin Jacob Kollanukkaran > ; xiang.w.w...@intel.com; dev@dpdk.org; Shahaf Shuler > ; hemant.agra...@nxp.com; Opher Reviv > ; Alex Rosenbaum ; Dovrat >

Re: [dpdk-dev] [PATCH v2] net/i40e: fix X722 performance drop

2020-03-02 Thread Ye Xiaolong
On 03/03, Qiming Yang wrote: >Lack of GL_SWR_PM_UP_THR value for mac type 4x10G X722 caused it can't >reach line rate in one queue one core forwarding case. It's about 1% >performance drop. This patch add value as: > > Device-ID ValueComments > 0x37D00x03030303 4x10G FPK > >This val

[dpdk-dev] [PATCH v2] net/i40e: fix X722 performance drop

2020-03-02 Thread Qiming Yang
Lack of GL_SWR_PM_UP_THR value for mac type 4x10G X722 caused it can't reach line rate in one queue one core forwarding case. It's about 1% performance drop. This patch add value as: Device-ID ValueComments 0x37D00x03030303 4x10G FPK This value is hardware specific. Fixes: 3320

[dpdk-dev] [PATCH v3] net/ice: fix hash flow segmentation fault

2020-03-02 Thread taox . zhu
From: Zhu Tao Macro rte_errno is not a static value, so it needs to be updated in all error handling code. Patch 'dc36bd5dfdeb' mistakenly consider that rte_errno is a constant, which causes the unrecognized flow rule to be marked as recognition success. Later, when the code tried to parse the f

[dpdk-dev] [PATCH v2] net/ice: fix hash flow segmentation fault

2020-03-02 Thread taox . zhu
From: Zhu Tao Macro rte_errno is not a static value, so it needs to be updated in all error handling code. Patch 'dc36bd5dfdeb' mistakenly consider that rte_errno is a constant, which causes the unrecognized flow rule to be marked as recognition success. Later, when the code tried to parse the f

Re: [dpdk-dev] [DPDK] net/ice: fix hash flow segmentation fault

2020-03-02 Thread Zhu, TaoX
Hi Xiaolong, Commit SHA length non-compliance will be modified in V2 patch. The reason why they did not return immediately after the error is that they need to release the allocated memory after the error, which is released uniformly in error processing, so they did not return directly. BR, Zhu

[dpdk-dev] [PATCH] net/bnx2x: add multicast MAC address filtering

2020-03-02 Thread sodey
From: "Dey, Souvik" Add support the set_mc_addr_list device operation in the bnx2xvf PMD. The configured addresses are stored in the device private area, so they can be flushed before adding new ones. Without this v6 multicast packets were properly forwarded to the Guest VF. Signed-off-by: "De

Re: [dpdk-dev] [PATCH] net/bnxt: fix to handle default mac address setting when port is stopped

2020-03-02 Thread Ajit Khaparde
On Thu, Feb 27, 2020 at 12:02 AM Kalesh A P < kalesh-anakkur.pura...@broadcom.com> wrote: > From: Kalesh AP > > Driver destroys the vnic when the port is brought down. > Port hw filter setting such as default mac address and > unicast mac filters will be applied when port is started. > > Fixed to

[dpdk-dev] [PATCH v2] net/ice: remove unnecessary variable

2020-03-02 Thread Qi Zhang
Remove unnecessary variable "meta" in ice_flow_create and ice_flow_validate, it should be defined when really be needed: its ice_parse_engine_create and ice_parse_engine_validate. In a validate opertion, a meta is not necessary be created during parser, so NULL will be parsed to low level engine a

Re: [dpdk-dev] [PATCH v2] net/bnxt: fix to cancel recovery alarm in port close

2020-03-02 Thread Ajit Khaparde
On Fri, Feb 28, 2020 at 2:04 AM Kalesh A P < kalesh-anakkur.pura...@broadcom.com> wrote: > From: Kalesh AP > > There is a race condition when port is closed while error recovery > is happening in driver. Fixed this by canceling the recovery threads > during port close. > > Fixes: df6cd7c1f73a ("n

Re: [dpdk-dev] [DPDK] net/ice: fix hash flow segmentation fault

2020-03-02 Thread Ye Xiaolong
On 03/03, taox@intel.com wrote: >From: Zhu Tao > >Macro rte_errno is not a static value, so it needs to be updated in all >error handling code. > >Patch 'dc36bd5dfd' mistakenly consider that rte_errno is a constant, which >causes the unrecognized flow rule to be marked as recognition success.

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/1] net/octeontx: fix meson build for disabled octeontx drivers

2020-03-02 Thread Amit Gupta
test_dep_obj is being formatted as string object, so can't be used as static obj.. Amit > -Original Message- > From: Bruce Richardson > Sent: Monday, March 2, 2020 4:23 PM > To: Amit Gupta > Cc: Harman Kalra ; dev@dpdk.org; sta...@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [PATCH v2 1/1

Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported check

2020-03-02 Thread Zhang, Xiao
> -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, March 3, 2020 10:53 AM > To: Zhang, Xiao > Cc: Yigit, Ferruh ; dev@dpdk.org; Xing, Beilei > ; Zhang, Qi Z ; sta...@dpdk.org > Subject: Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported check > > On 03/03, Zhang, Xi

Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported check

2020-03-02 Thread Ye Xiaolong
On 03/03, Zhang, Xiao wrote: >Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Monday, March 2, 2020 5:09 PM >> To: Zhang, Xiao ; dev@dpdk.org >> Cc: Xing, Beilei ; Zhang, Qi Z ; >> sta...@dpdk.org >> Subject: Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported

[dpdk-dev] [DPDK] net/ice: fix hash flow segmentation fault

2020-03-02 Thread taox . zhu
From: Zhu Tao Macro rte_errno is not a static value, so it needs to be updated in all error handling code. Patch 'dc36bd5dfd' mistakenly consider that rte_errno is a constant, which causes the unrecognized flow rule to be marked as recognition success. Later, when the code tried to parse the flo

Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported check

2020-03-02 Thread Zhang, Xiao
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, March 2, 2020 5:09 PM > To: Zhang, Xiao ; dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported check > > On 2/28/2020 3:22 AM, Xiao

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status inconsistencies

2020-03-02 Thread Zhu, TaoX
+Xiaolong BR, Zhu, Tao > -Original Message- > From: Zhu, TaoX > Sent: Wednesday, February 26, 2020 8:07 PM > To: Ananyev, Konstantin ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhu, TaoX ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix link status inconsistencies > > From: Zhu Tao > > Sett

Re: [dpdk-dev] [PATCH] net/i40e: fix X722 performance drop

2020-03-02 Thread Ye Xiaolong
Hi, Qiming On 02/26, Qiming Yang wrote: >GL_SWR_PM_UP_THR value lack in X722 caused configure register write not be >called. This is the root cause of performance drop. This patch add support >for: Could you elaborate what kind of performance drop caused by the missing register cfg? Thanks, Xi

[dpdk-dev] [PATCH v2] net/bnx2x: handle guest vlan for SR-IOV case

2020-03-02 Thread Dey, Souvik
In case of bnx2xvf pmd, tx packets can support vland id in 2 ways : 1. setting the mbuf ol_flags=PKT_TX_VLAN_PKT and passing the vlanid in mbuf->vlan_tci. 2. the tx packet itself has the vlan id included in the packet. The first case is working as expected but the second case where the vlan id is i

[dpdk-dev] [PATCH] net/vhost: fix potential memory leak

2020-03-02 Thread Itsuro Oda
If a vhost device is closed before eth_dev_configure is done to the device, internal resources allocated to the device does not freed. This patch fixes it. Fixes: 3d01b759d267 ("net/vhost: delay driver setup") Signed-off-by: Itsuro Oda --- drivers/net/vhost/rte_eth_vhost.c | 16 +++-

Re: [dpdk-dev] [PATCH] net/ice: remove unnecessary variable

2020-03-02 Thread Zhang, Qi Z
> -Original Message- > From: Ye, Xiaolong > Sent: Monday, March 2, 2020 4:20 PM > To: Zhang, Qi Z > Cc: Xing, Beilei ; Cao, Yahui ; > dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ice: remove unnecessary variable > > Hi, Qi > > On 02/25, Qi Zhang wrote: > >Remov

[dpdk-dev] [PATCH] doc: add required Linux capabilities in mlx5 guide

2020-03-02 Thread Thomas Monjalon
If running DPDK as non-root, some extra capabilities may be required. The Mellanox devices, using a bifurcated model with Linux drivers, have some specific requirements summarized in mlx5 PMD guide. Signed-off-by: Thomas Monjalon --- doc/guides/nics/mlx5.rst | 26 ++ 1 fi

[dpdk-dev] [PATCH] test/autotest: checking for skipped or unsupported tests

2020-03-02 Thread Thinh Tran
- When running the dedault configuration of autotest of the make test it'd take 900 seconds (15 minutes) for the script TIMEOUT and marks Failed for a specific device test that is not supported on the system under test. - Adding the checking for those tests, print out as "Skipped [Not Run]"

Re: [dpdk-dev] [RFC 1/1] lib/ring: add scatter gather and serial dequeue APIs

2020-03-02 Thread Ananyev, Konstantin
> > > +/** > > > + * @internal Reserve ring elements to enqueue several objects on the > > > +ring > > > + * > > > + * @param r > > > + * A pointer to the ring structure. > > > + * @param esize > > > + * The size of ring element, in bytes. It must be a multiple of 4. > > > + * This must be

[dpdk-dev] [PATCH] maintainers: update for Netcope PMDs

2020-03-02 Thread Jan Remes
Jan and Rastislav are leaving Netcope. Martin and Jakub will replace them as Netcope PMD maintainers. Signed-off-by: Jan Remes --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f4e0ed8e0..69ce71ffb 100644 --- a/MAINTAINERS

Re: [dpdk-dev] [PATCH] maintainers: update for Netcope PMDs

2020-03-02 Thread Thomas Monjalon
02/03/2020 17:34, Jan Remes: > Jan and Rastislav are leaving Netcope. Martin and Jakub > will replace them as Netcope PMD maintainers. > > Signed-off-by: Jan Remes Applied

[dpdk-dev] [PATCH 6/6] net/null: add argument for no Rx

2020-03-02 Thread Ferruh Yigit
Add an new device argument 'no-rx', which will prevent PMD receiving packets. This is useful for testing when a PMD is needed only to send packets to. Signed-off-by: Ferruh Yigit --- doc/guides/nics/null.rst| 4 +++ drivers/net/null/rte_eth_null.c | 55 -

[dpdk-dev] [PATCH 1/6] net/null: fix secondary burst function selection

2020-03-02 Thread Ferruh Yigit
Secondary process uses the primary process device and while setting the Rx/Tx functions it uses the device arguments from the secondary process instead of the primary ones. This may cause primary and secondary process use different Rx/Tx functions unintentionally. Fixes: bccc77a6a74a ("net/null:

[dpdk-dev] [PATCH 2/6] doc: add net null PMD guide

2020-03-02 Thread Ferruh Yigit
Net null PMD was missing documentation, adding it. Signed-off-by: Ferruh Yigit --- doc/guides/nics/index.rst | 1 + doc/guides/nics/null.rst | 39 +++ 2 files changed, 40 insertions(+) create mode 100644 doc/guides/nics/null.rst diff --git a/doc/guides/nic

[dpdk-dev] [PATCH 5/6] net/null: group device arguments

2020-03-02 Thread Ferruh Yigit
Group device argument to the struct, to increase code readability. Signed-off-by: Ferruh Yigit --- drivers/net/null/rte_eth_null.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null

[dpdk-dev] [PATCH 3/6] net/null: remove redundant check

2020-03-02 Thread Ferruh Yigit
There is no need to check if the argument exist or not, `rte_kvargs_process` returns success if the argument is not provided at all. Fixes: c743e50c475f ("null: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- Cc: muk...@igel.co.jp --- drivers/net/null/rte_eth_null.c |

[dpdk-dev] [PATCH 4/6] net/null: prefer unsigned int

2020-03-02 Thread Ferruh Yigit
Prefer 'unsigned int' storage type keyword against 'unsigned', this also silence the checkpatch warnings. Signed-off-by: Ferruh Yigit --- drivers/net/null/rte_eth_null.c | 46 - 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/net/null/rte_e

Re: [dpdk-dev] [PATCH] maintainers: update for virtio and vhost

2020-03-02 Thread Thomas Monjalon
25/02/2020 19:01, Maxime Coquelin: > On 2/21/20 2:35 PM, Xiaolong Ye wrote: > > I volunteer to be co-maintainer for Vhost-user/Vhost PMD/Virtio PMD. > > > > Thanks for offering your help, I really appreciate it! > > Acked-by: Maxime Coquelin Applied, thanks

Re: [dpdk-dev] [PATCH v2] net/af_packet: remove limitation on number of qpairs

2020-03-02 Thread Ferruh Yigit
On 3/2/2020 4:43 PM, Stephen Hemminger wrote: > On Mon, 2 Mar 2020 16:24:23 + > Ferruh Yigit wrote: > >> On 2/27/2020 8:56 PM, John W. Linville wrote: >>> On Thu, Feb 27, 2020 at 12:00:03PM -0800, Stephen Hemminger wrote: Since qpairs is part of the vdev arguments, there is no need to

Re: [dpdk-dev] [PATCH] maintainers: resign from virtio and vhost

2020-03-02 Thread Thomas Monjalon
25/02/2020 18:51, Maxime Coquelin: > On 2/21/20 2:28 PM, Tiwei Bie wrote: > > I'm leaving Intel, and I'm not sure when I could dedicate enough > > time to DPDK in the future. So I'm removing my name from the > > MAINTAINERS file. > > > > Signed-off-by: Tiwei Bie > > --- > > Xiaolong has been an a

Re: [dpdk-dev] [PATCH v2] net/af_packet: remove limitation on number of qpairs

2020-03-02 Thread Stephen Hemminger
On Mon, 2 Mar 2020 16:24:23 + Ferruh Yigit wrote: > On 2/27/2020 8:56 PM, John W. Linville wrote: > > On Thu, Feb 27, 2020 at 12:00:03PM -0800, Stephen Hemminger wrote: > >> Since qpairs is part of the vdev arguments, there is no need to > >> limit it to 16. The queue arrays can be dynamica

Re: [dpdk-dev] [PATCH v2] net/af_packet: remove limitation on number of qpairs

2020-03-02 Thread Ferruh Yigit
On 2/27/2020 8:56 PM, John W. Linville wrote: > On Thu, Feb 27, 2020 at 12:00:03PM -0800, Stephen Hemminger wrote: >> Since qpairs is part of the vdev arguments, there is no need to >> limit it to 16. The queue arrays can be dynamically sized based >> on the requested parameters. >> >> Signed-off-b

Re: [dpdk-dev] [PATCH v2] net/af_packet: remove limitation on number of qpairs

2020-03-02 Thread Ferruh Yigit
On 2/28/2020 4:52 PM, John W. Linville wrote: > On Fri, Feb 28, 2020 at 10:08:43AM +, Ferruh Yigit wrote: >> On 2/27/2020 8:00 PM, Stephen Hemminger wrote: >>> Since qpairs is part of the vdev arguments, there is no need to >>> limit it to 16. The queue arrays can be dynamically sized based >>>

Re: [dpdk-dev] net/netvsc: subchannel configuration failed due to unexpected NVS response

2020-03-02 Thread Stephen Hemminger
On Mon, 2 Mar 2020 10:40:17 -0500 Min Tang wrote: > Hi Stephen: > > If there is no intention to process the response message of NVS_TYPE_RNDIS, > would it be better to not set the flags to VMBUS_CHANPKT_FLAG_RC so that it > won't receive any response message? > > Best Regards, > Min Tang > > O

Re: [dpdk-dev] net/netvsc: subchannel configuration failed due to unexpected NVS response

2020-03-02 Thread Min Tang
Hi Stephen: If there is no intention to process the response message of NVS_TYPE_RNDIS, would it be better to not set the flags to VMBUS_CHANPKT_FLAG_RC so that it won't receive any response message? Best Regards, Min Tang On Sun, Mar 1, 2020 at 12:54 PM Stephen Hemminger < step...@networkplumbe

Re: [dpdk-dev] [PATCH v2] app: test: measure libipsec performance

2020-03-02 Thread Medvedkin, Vladimir
Hi Savinay, On 02/03/2020 11:43, Savinay Dharmappa wrote: test app to measures the performance of libipsec api rte_ipsec_pkt_crypto and rte_ipsec_pkt_process. Signed-off-by: Savinay Dharmappa --- app/test/Makefile | 2 +- app/test/meson.build | 2 + app/test/test_ipsec_p

Re: [dpdk-dev] [PATCH] mempool: sort the rte_mempool_ops by name

2020-03-02 Thread Jerin Jacob
On Mon, Mar 2, 2020 at 7:27 AM wrote: > > From: Tonghao Zhang > > The order of mempool initiation affects mempool index in the > rte_mempool_ops_table. For example, when building APPs with: > > $ gcc -lrte_mempool_bucket -lrte_mempool_ring ... > > The "bucket" mempool will be registered firstly,

Re: [dpdk-dev] [PATCH 00/16] NXP DPAAx fixes and enhancements

2020-03-02 Thread David Marchand
On Mon, Mar 2, 2020 at 10:26 AM Hemant Agrawal wrote: > > This patch series add various patches for enhancing and fixing NXP > fslmc bus, dpaa bus, and dpaax. > > - the main change is support to allow thread migration across lcores > - improving the multi-process support This series triggers an A

Re: [dpdk-dev] [PATCH v2] app: test: measure libipsec performance

2020-03-02 Thread David Marchand
On Mon, Mar 2, 2020 at 12:43 PM Savinay Dharmappa wrote: > > test app to measures the performance of libipsec > api rte_ipsec_pkt_crypto and rte_ipsec_pkt_process. > > Signed-off-by: Savinay Dharmappa Missing MAINTAINERS update. > --- > app/test/Makefile | 2 +- > app/test/meson.bu

Re: [dpdk-dev] [v2] app/testpmd: parse flow command line for AH

2020-03-02 Thread Ferruh Yigit
On 3/1/2020 7:56 AM, Ori Kam wrote: > > >> -Original Message- >> From: Xiao Zhang >> Subject: [v2] app/testpmd: parse flow command line for AH >> >> Add AH and AH SPI to testpmd rte flow command line. >> Add note and sample AH rules in testpmd guide. >> > > Acked-by: Ori Kam > Applie

[dpdk-dev] [PATCH v2] app: test: measure libipsec performance

2020-03-02 Thread Savinay Dharmappa
test app to measures the performance of libipsec api rte_ipsec_pkt_crypto and rte_ipsec_pkt_process. Signed-off-by: Savinay Dharmappa --- app/test/Makefile | 2 +- app/test/meson.build | 2 + app/test/test_ipsec_perf.c | 637 + 3 files chang

[dpdk-dev] 19.11.1 patches review and test

2020-03-02 Thread luca . boccassi
Hi all, Here is a list of patches targeted for stable release 19.11.1. The planned date for the final release is March the 16th. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported valid

Re: [dpdk-dev] [dpdk v1] net/mlx5: fix possible building error

2020-03-02 Thread Tonghao Zhang
On Mon, Mar 2, 2020 at 5:47 PM Ali Alnubani wrote: > > > > Do you mind sharing which OS are you using, which gcc/clang version, > > whether you have MLNX_OFED or rdma-core installed, and which version? > > 1. CentOS Linux release 7.6.1810 (Core) > > 2. kernel 3.10.0-957.1.3.el7.x86_64 > > 3. OFED

[dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error

2020-03-02 Thread xiangxia . m . yue
From: Tonghao Zhang When setting the CONFIG_RTE_BUILD_SHARED_LIB to y, and build the mlx5 pmd, there is a building error. To fix it, add RTE_IBVERBS_LINK_DLOPEN to include relative codes. > mlx5_common.o: In function `mlx5_glue_init': > drivers/common/mlx5/mlx5_common.c:324: undefined reference

[dpdk-dev] [PATCH v1] app: test: measure libipsec performance

2020-03-02 Thread Savinay Dharmappa
test app to measures the performance of libipsec api rte_ipsec_pkt_crypto and rte_ipsec_pkt_process. Signed-off-by: Savinay Dharmappa --- app/test/Makefile | 2 +- app/test/meson.build | 2 + app/test/test_ipsec_perf.c | 637 + 3 files chang

Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx: fix meson build for disabled octeontx drivers

2020-03-02 Thread Bruce Richardson
On Mon, Mar 02, 2020 at 12:01:55PM +0530, agup...@marvell.com wrote: > From: Amit Gupta > > Add a additional condition to check if all required internal > dependencies are met before building octeontx drivers using meson. > > Bugzilla ID: 387 > > Fixes: 7f615033d64f ("drivers/net: build Cavium

Re: [dpdk-dev] [dpdk v1] net/mlx5: fix possible building error

2020-03-02 Thread Ali Alnubani
> > Do you mind sharing which OS are you using, which gcc/clang version, > whether you have MLNX_OFED or rdma-core installed, and which version? > 1. CentOS Linux release 7.6.1810 (Core) > 2. kernel 3.10.0-957.1.3.el7.x86_64 > 3. OFED 4.7-3.2.9 > 4. FW 16.26.4012 > 5. gcc (GCC) 4.8.5 20150623 (Red

[dpdk-dev] [PATCH 16/16] net/dpaa2: do not prefetch annotaion for physical mode

2020-03-02 Thread Hemant Agrawal
From: Nipun Gupta When IOVA is physical address do not prefetch the annotation of the next frame, as there is a cost involved there to convert the physical address to virtual address. Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 6 ++-- drivers/net/dpaa2/dpaa2_rxtx

[dpdk-dev] [PATCH 15/16] bus/dpaa: enable set link status

2020-03-02 Thread Hemant Agrawal
From: Rohit Raj Enabled set link status API to start/stop phy device from application. Signed-off-by: Rohit Raj --- drivers/bus/dpaa/base/qbman/process.c | 35 --- drivers/bus/dpaa/include/process.h| 3 ++ drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 + drive

[dpdk-dev] [PATCH 14/16] bus/dpaa: enable link state interrupt

2020-03-02 Thread Hemant Agrawal
From: Rohit Raj Enable/disable link state interrupt and get link state api is defined using IOCTL calls. Signed-off-by: Rohit Raj --- drivers/bus/dpaa/base/fman/fman.c | 4 +- drivers/bus/dpaa/base/qbman/process.c | 68 ++- drivers/bus/dpaa/dpaa_bus.c

[dpdk-dev] [PATCH 09/16] bus/fslmc: rename the cinh read functions used for ls1088

2020-03-02 Thread Hemant Agrawal
From: Nipun Gupta This patch changes the qbman I/O function names as they are only reading from cinh register, but writing to cena registers. This gives way to add functions which purely work in cinh mode Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/qbman/qbman_portal.c | 34 +

[dpdk-dev] [PATCH 12/16] net/dpaa: add 2.5G support

2020-03-02 Thread Hemant Agrawal
From: Sachin Saxena Handle 2.5Gbps ethernet ports as well. Signed-off-by: Sachin Saxena Signed-off-by: Gagandeep Singh --- drivers/bus/dpaa/base/fman/fman.c | 6 -- drivers/bus/dpaa/base/fman/netcfg_layer.c | 3 ++- drivers/bus/dpaa/include/fman.h | 1 + drivers/net/dpaa

[dpdk-dev] [PATCH 11/16] net/dpaa: enable Tx queue taildrop

2020-03-02 Thread Hemant Agrawal
From: Gagandeep Singh Enable congestion handling/tail drop for TX queues. Signed-off-by: Gagandeep Singh --- drivers/bus/dpaa/base/qbman/qman.c| 43 + drivers/bus/dpaa/include/fsl_qman.h | 17 drivers/bus/dpaa/rte_bus_dpaa_version.map | 7 ++ drivers/net/dpaa/dpa

[dpdk-dev] [PATCH 10/16] net/dpaa: return error on multiple mp config

2020-03-02 Thread Hemant Agrawal
From: Nipun Gupta multiple buffer pools are not supported on a single device. Signed-off-by: Nipun Gupta --- drivers/mempool/dpaa/dpaa_mempool.c | 1 + drivers/net/dpaa/dpaa_ethdev.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/

[dpdk-dev] [PATCH 13/16] net/dpaa: update process specific device info

2020-03-02 Thread Hemant Agrawal
From: Nipun Gupta For DPAA devices the memory maps stored in the FMAN interface information is per process. Store them in the device process specific area. Signed-off-by: Nipun Gupta --- drivers/net/dpaa/dpaa_ethdev.c | 207 - drivers/net/dpaa/dpaa_ethdev.h |

[dpdk-dev] [PATCH 08/16] drivers: enhance portal allocation failure log

2020-03-02 Thread Hemant Agrawal
From: Nipun Gupta The change adds printing the thread id when portal allocation failure occurs Signed-off-by: Nipun Gupta --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 ++-- drivers/event/dpaa2/dpaa2_eventdev.c| 8 ++-- drivers/mempool/dpaa2/dpaa2_hw_mempool.c| 12 +

[dpdk-dev] [PATCH 05/16] bus/fslmc: support handle portal alloc failure

2020-03-02 Thread Hemant Agrawal
Add the error handling on failure. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 28 ++-- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/p

[dpdk-dev] [PATCH 04/16] bus/fslmc: rework portal allocation to a per thread basis

2020-03-02 Thread Hemant Agrawal
From: Nipun Gupta The patch reworks the portal allocation which was previously being done on per lcore basis to a per thread basis. Now user can also create its own threads and use DPAA2 portals for packet I/O. Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/Makefile | 1 + dr

[dpdk-dev] [PATCH 07/16] bus/fslmc: support portal migration

2020-03-02 Thread Hemant Agrawal
From: Nipun Gupta The patch adds support for portal migration by disabling stashing for the portals which is used in the non-affined threads, or on threads affined to multiple cores Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 83 +-- .../fslmc/qbman/include/

[dpdk-dev] [PATCH 06/16] bus/fslmc: limit pthread destructor called for dpaa2 only

2020-03-02 Thread Hemant Agrawal
From: Nipun Gupta The destructor was being called for non-dpaa2 as well Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/portal/d

[dpdk-dev] [PATCH 00/16] NXP DPAAx fixes and enhancements

2020-03-02 Thread Hemant Agrawal
This patch series add various patches for enhancing and fixing NXP fslmc bus, dpaa bus, and dpaax. - the main change is support to allow thread migration across lcores - improving the multi-process support Apeksha Gupta (1): bus/fslmc: fix dereferencing null pointer Gagandeep Singh (2): bus

[dpdk-dev] [PATCH 03/16] bus/fslmc: combine thread specific variables

2020-03-02 Thread Hemant Agrawal
From: Gagandeep Singh This is to reduce the thread local storage Signed-off-by: Gagandeep Singh --- drivers/bus/fslmc/fslmc_bus.c| 2 -- drivers/bus/fslmc/portal/dpaa2_hw_dpio.h | 7 +++ drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 8 drivers/bus/fslmc/rte_fslmc.h

[dpdk-dev] [PATCH 01/16] net/dpaa2: fix 10g port negotiation issue

2020-03-02 Thread Hemant Agrawal
From: Rohit Raj Fixed 10g port negotiation issue with another 10G/non 10G port. Initialize the port link speed. Fixes: c5acbb5ea20e ("net/dpaa2: support link status event") Cc: sta...@dpdk.org Signed-off-by: Rohit Raj --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 +--- 1 file changed, 1 insertion(

[dpdk-dev] [PATCH 02/16] bus/fslmc: fix dereferencing null pointer

2020-03-02 Thread Hemant Agrawal
From: Apeksha Gupta This patch fixees the nxp internal coverity reported null pointer dereferncing issue. Fixes: 6fef517e17cf ("bus/fslmc: add qman HW fq query count API") Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta --- drivers/bus/fslmc/qbman/qbman_debug.c | 9 + 1 file changed,

Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported check

2020-03-02 Thread Ferruh Yigit
On 2/28/2020 3:22 AM, Xiao Zhang wrote: > Return ENOTSUP error code when configuring i40evf promiscuous mode to > fix port start hang issue on platforms which are unsupported to configure > promiscuous mode. Hi Xiao, What is the cause of the hang, was the application keep trying because of the "-

[dpdk-dev] [PATCH 05/10] net/enetc: improve batching Rx ring refill

2020-03-02 Thread Hemant Agrawal
From: Alex Marginean Move from doing batch refill of Rx ring from bundles of 8 to once per enetc_clean_rx_ring call. One benefit is that we're cleaning up all the BDs that we just processed, which should still be cached. The other is that hardware Rx index stays a little back and doesn't cause

[dpdk-dev] [PATCH 08/10] net/enetc: use bulk free in Tx clean

2020-03-02 Thread Hemant Agrawal
From: Alex Marginean Use rte_pktmbuf_free_bulk to release all mbufs at once. This is flagged as obsolete/not yet stable in DPDK but seems to be functional. Don't count the released frames, it's no longer needed in the caller. Signed-off-by: Alex Marginean --- drivers/net/enetc/Makefile |

[dpdk-dev] [PATCH 10/10] net/enetc: init SI transactions attribute reg

2020-03-02 Thread Hemant Agrawal
From: Alex Marginean This was left to its default value. With the patch transactions are: - coherent, - do not allocate in downstream cache (there is none on LS1028a), - merge surrounding data for BD writes, - overwrite surrounding data for frame data writes. Signed-off-by: Alex Marginean ---

[dpdk-dev] [PATCH 09/10] net/enetc: improve prefetch in Rx ring clean

2020-03-02 Thread Hemant Agrawal
From: Alex Marginean LS1028A does not have platform cache so any reads following a hardware write will go directly to DDR. Latency of such a read is in excess of 100 core cycles, so try to prefetch more in advance to mitigate this. How much is worth prefetching really depends on traffic conditio

[dpdk-dev] [PATCH 07/10] net/enetc: use bulk alloc in Rx refill ring

2020-03-02 Thread Hemant Agrawal
From: Alex Marginean Since we know in advance that we're going to fill in multiple descriptors it's convenient to allocate the buffers in batches. Signed-off-by: Alex Marginean --- drivers/net/enetc/enetc_rxtx.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff

[dpdk-dev] [PATCH 06/10] net/enetc: cache align enetc bdr structure

2020-03-02 Thread Hemant Agrawal
From: Alex Marginean Reorder the members of the structure so that the ones used on datapath fit in a single cache line, to slightly reduce pressure on cache and miss rate. Signed-off-by: Alex Marginean --- drivers/net/enetc/enetc.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(

[dpdk-dev] [PATCH 03/10] net/enetc: batch process enetc clean Tx ring calls

2020-03-02 Thread Hemant Agrawal
From: Alex Marginean Each call to enetc_clean_tx_ring will cost at least 150-200 CPU cycles even if no clean-up is done, due to the CI register read. We're only calling it once at the end of the function, on the assumption that software is slower than hardware and hardware completed sending older

[dpdk-dev] [PATCH 04/10] net/enetc: erratum wa for Rx lock-up issue

2020-03-02 Thread Hemant Agrawal
From: Alex Marginean The default value in hardware for the Rx MAC FIFO (@) is higher than it should be and can lead to Rx lock-up under traffic. Set it to the value recommended by hardware team, 1. Signed-off-by: Alex Marginean Signed-off-by: Gagandeep Singh --- drivers/net/enetc/base/enetc_h

[dpdk-dev] [PATCH 01/10] net/enetc: do not stall in clean Tx ring

2020-03-02 Thread Hemant Agrawal
From: Alex Marginean Don't read the hardware CI register in a loop, read it once, clean up and exit. The issue with reading the register in a loop is that we're stalling here trying to catch up with hardware which keeps sending traffic as long as it has traffic to send, so in effect we could be w

[dpdk-dev] [PATCH 00/10] net/enetc: optimization and cleanup

2020-03-02 Thread Hemant Agrawal
This patch series includes patches to optimize and clean the network driver for ENETC Alex Marginean (10): net/enetc: do not stall in clean Tx ring net/enetc: use relaxed read for Tx CI in clean Tx net/enetc: batch process enetc clean Tx ring calls net/enetc: erratum wa for Rx lock-up issu

[dpdk-dev] [PATCH 02/10] net/enetc: use relaxed read for Tx CI in clean Tx

2020-03-02 Thread Hemant Agrawal
From: Alex Marginean We don't need barriers here since this read doesn't have to be strictly serialized in relation to other surrounding memory/register accesses. We only want a reasonably recent value out of hardware so we know how much we can clean. Signed-off-by: Alex Marginean --- drivers/

Re: [dpdk-dev] [PATCH v5 00/15] add eventmode to ipsec-secgw

2020-03-02 Thread Akhil Goyal
Hi Anoob, I will merge this series in this week. Regards, Akhil > -Original Message- > From: Anoob Joseph > Sent: Monday, March 2, 2020 2:17 PM > To: Akhil Goyal ; Konstantin Ananyev > > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Ankur Dwivedi ; > Archana Munigant

Re: [dpdk-dev] [PATCH v5 00/15] add eventmode to ipsec-secgw

2020-03-02 Thread Anoob Joseph
Hi Akhil, Konstantin, Are there any more comments? Or can we have the patches merged? Thanks, Anoob > -Original Message- > From: Lukasz Bartosik > Sent: Thursday, February 27, 2020 9:48 PM > To: Akhil Goyal ; Radu Nicolau > ; Thomas Monjalon > Cc: Jerin Jacob Kollanukkaran ; Narayana P

Re: [dpdk-dev] [PATCH] net/ice: remove unnecessary variable

2020-03-02 Thread Ye Xiaolong
Hi, Qi On 02/25, Qi Zhang wrote: >Remove unnecessary variable "meta" in ice_flow_create and >ice_flow_validate, it should be defined when really be needed: >its ice_parse_engine_create and ice_parse_engine_validate. > >The patch also move the meta's memory free from each filter s/move/moves >eng

[dpdk-dev] [PATCH v1 2/3] net/axgbe: get packet types API

2020-03-02 Thread asomalap
From: Amaranath Somalapuram Adding api for eth_dev_supported_ptypes_get_t Signed-off-by: Amaranath Somalapuram --- drivers/net/axgbe/axgbe_ethdev.c | 37 1 file changed, 37 insertions(+) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_e

[dpdk-dev] [PATCH v1 1/3] net/axgbe: support for rxq and txq info API

2020-03-02 Thread asomalap
From: Amaranath Somalapuram Adding API for axgbe_rxq_info_get, axgbe_txq_info_get Signed-off-by: Amaranath Somalapuram --- drivers/net/axgbe/axgbe_ethdev.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/a

[dpdk-dev] [PATCH v1 3/3] net/axgbe: support for rxq and txq descriptor status API

2020-03-02 Thread asomalap
From: Amaranath Somalapuram Adding API axgbe_dev_rx_descriptor_status, axgbe_dev_tx_descriptor_status Signed-off-by: Amaranath Somalapuram --- drivers/net/axgbe/axgbe_ethdev.c | 2 ++ drivers/net/axgbe/axgbe_rxtx.c | 46 drivers/net/axgbe/axgbe_rxtx.h | 2

[dpdk-dev] [PATCH v4 1/2] net/axgbe: support flow control API

2020-03-02 Thread asomalap
From: Amaranath Somalapuram Adding api for flow_ctrl_get and flow_ctrl_set. By default axgbe driver flow control is disabled. Adding dpdk flow control to set water high and low. Signed-off-by: Amaranath Somalapuram --- drivers/net/axgbe/axgbe_ethdev.c | 84 dri

[dpdk-dev] [PATCH v4 2/2] net/axgbe: support priority flow control API

2020-03-02 Thread asomalap
From: Amaranath Somalapuram Adding API for priority_flow_ctrl_set. Priority flow control to set water high and low, pause_time and priority. Signed-off-by: Amaranath Somalapuram --- drivers/net/axgbe/axgbe_ethdev.c | 94 1 file changed, 94 insertions(+) diff

Re: [dpdk-dev] [dpdk v1] net/mlx5: fix possible building error

2020-03-02 Thread Tonghao Zhang
On Mon, Mar 2, 2020 at 3:35 PM Ali Alnubani wrote: > > > -Original Message- > > From: Tonghao Zhang > > Sent: Monday, March 2, 2020 2:23 AM > > To: Ali Alnubani > > Cc: sta...@dpdk.org; Matan Azrad ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [dpdk v1] net/mlx5: fix possible building error