On 03/03, Zhang, Xiao wrote: >Hi Ferruh, > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Monday, March 2, 2020 5:09 PM >> To: Zhang, Xiao <xiao.zh...@intel.com>; dev@dpdk.org >> Cc: Xing, Beilei <beilei.x...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; >> sta...@dpdk.org >> Subject: Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported check >> >> On 2/28/2020 3:22 AM, Xiao Zhang wrote: >> > Return ENOTSUP error code when configuring i40evf promiscuous mode to >> > fix port start hang issue on platforms which are unsupported to >> > configure promiscuous mode. >> >> Hi Xiao, >> >> What is the cause of the hang, was the application keep trying because of >> the "- >> EAGAIN" error? > >When starting port, rte_eth_dev_start will call rte_eth_dev_config_restore in >which promisc configure will be called to enable/disable promiscuous mode. >Since "-EAGAIN" was returned if platforms not supported to configure promisc >mode, it would return error and stop port starting.
So the real issue caused by this is "Fail to start port", not "hang", right? I can change the description in the commit log directly. Thanks, Xiaolong
